summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* FBTF: Remove unneeded headers from base/ (part 7)thestig@chromium.org2010-08-278-15/+10
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land. Fixed previous errors.dimich@chromium.org2010-08-272-0/+169
| | | | | | | | | | | | | | | | | | | | | | | | | | Implement OSX version for "Start on Login" for background-enabled extensions. When user installs first background-enabled extension we set Chrome to be a hidden "Login Item", and when user uninstalls the last one, we remove Chrome from the "Login Items List". Login Items are the apps that are listed in Systempreferences->Accounts->Login Items, or which have a "Open on Login" check for their Dock icon. Since we manipulate the user-faced UI item here, we try to do it in a way that will likely not interfere with user settings. Most typically, users do not use 'hidden' property, so if we ever encounter setting w/o this property, we won't override. Also there is a hidden preference used to remember the fact that Chrome changed the settings earlier - to avoid override on uninstall of the last persistent app in opposite case. Using the same bit that user can manipulate separately and perhaps even knows about is beneficial since it provides for unified place to "start Chrome on Login" and reduces confusion. Implementation for Login Items List access uses LSSharedFileList API that is available starting 10.5, which I think is our minimal supported version of OSX. BUG=43382 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57569 Reverted Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57614 Reverted Review URL: http://codereview.chromium.org/3163029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57699 0039d316-1c4b-4281-b951-d872f2087c98
* This CL introduces the stack shadowing mechanism that should help TCMalloc'sglider@chromium.org2010-08-271-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | heap leak checker to unwind the memory allocation stacks better. Currently, if a memory region is allocated from a library built without frame pointers heapchecker is unable to unwind the stack and records only the top frame. This is inconvenient, because: -- several leaks from different places are treated as leaks from the same source -- it's hard to suppress such leaks, because a one-line suppression is uninformative linux_shadow_stacks.cc keeps the threads' IP and SP values in thread-local stacks upon each function entry/exit using gcc function instrumentation (-finstrument-functions). The GetStackTrace routine from stacktrace_shadow-inl.h unwinds the stack as usual (using frame pointers), but then updates the result with the shadow stack frames which SP values are below the bottom frame of the unwind result. Note that -finstrument-functions affects only Chromium code, not the libraries. This means that we cannot get more than one library function frame at the top of the stack. For example, consider a libfoo library that has a public foo_do_something() routine which allocates memory via foo_alloc(). If Chromium calls foo_do_something() from ChromeCallFoo(), then the following call chain effectively happens: main -> ChromeCallFoo -> foo_do_something -> foo_alloc If libfoo is built with -fomit-frame-pointers, heapcheck can unwind only the last stack frame: foo_alloc On the other hand, the shadow stack at the allocation site contains everything below the libfoo calls: main -> ChromeCallFoo As a result the following allocation stack is recorded: main -> ChromeCallFoo -> foo_alloc This is enough to distinguish between e.g. ChromeCallFoo1 and ChromeCallFoo2 Review URL: http://codereview.chromium.org/3120017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57658 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57614 - Re-land. Fixed previous build error.dimich@chromium.org2010-08-272-169/+0
| | | | | | | | | | | | | | | It looks like it broke browser_tests. Will revert and investigate. Implement OSX version for "Start on Login" for background-enabled extensions. Review URL: http://codereview.chromium.org/3163029 TBR=dimich@chromium.org Review URL: http://codereview.chromium.org/3226002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57625 0039d316-1c4b-4281-b951-d872f2087c98
* Move the SingletonSocket to a temporary directorydavidben@chromium.org2010-08-272-3/+11
| | | | | | | | | | | | | | | | This is to workaround problems on certain network filesystems (notably AFS) which do not support Unix domain sockets. We move the sockets into a temporary folder and symlink. To avoid the possibility of a dangling link to a missing (and later intercepted) remote directory, we create and check cookie files and rely on the stickiness of /tmp/ to avoid a race condition in the check. R=mattm BUG=44606 TEST=ProcessSingletonLinuxTest.* Review URL: http://codereview.chromium.org/2838034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57623 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land. Fixed previous build error.dimich@chromium.org2010-08-272-0/+169
| | | | | | | | | | | | | | | | | | | | | | | | Implement OSX version for "Start on Login" for background-enabled extensions. When user installs first background-enabled extension we set Chrome to be a hidden "Login Item", and when user uninstalls the last one, we remove Chrome from the "Login Items List". Login Items are the apps that are listed in Systempreferences->Accounts->Login Items, or which have a "Open on Login" check for their Dock icon. Since we manipulate the user-faced UI item here, we try to do it in a way that will likely not interfere with user settings. Most typically, users do not use 'hidden' property, so if we ever encounter setting w/o this property, we won't override. Also there is a hidden preference used to remember the fact that Chrome changed the settings earlier - to avoid override on uninstall of the last persistent app in opposite case. Using the same bit that user can manipulate separately and perhaps even knows about is beneficial since it provides for unified place to "start Chrome on Login" and reduces confusion. Implementation for Login Items List access uses LSSharedFileList API that is available starting 10.5, which I think is our minimal supported version of OSX. BUG=43382 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57569 Reverted, trying to re-land. Review URL: http://codereview.chromium.org/3163029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57614 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57572 - Remove the default argument from RegKey::Open.chase@chromium.org2010-08-261-1/+1
| | | | | | | | | | | | | | | | | | Caused a failure on Windows Chromium Builder (dbg): ...\configuration_policy_provider_win.cc(71) : error C2660: 'RegKey::Open' : function does not take 2 arguments BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Review URL: http://codereview.chromium.org/3205007 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/3211004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57575 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57569 - Implement OSX version for "Start on Login" for ↵dimich@chromium.org2010-08-262-171/+0
| | | | | | | | | | | background-enabled extensions. Review URL: http://codereview.chromium.org/3163029 TBR=dimich@chromium.org Review URL: http://codereview.chromium.org/3130052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57573 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the default argument from RegKey::Open.tfarina@chromium.org2010-08-261-1/+1
| | | | | | | | | BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Review URL: http://codereview.chromium.org/3205007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57572 0039d316-1c4b-4281-b951-d872f2087c98
* Implement OSX version for "Start on Login" for background-enabled extensions.dimich@chromium.org2010-08-262-0/+171
| | | | | | | | | | | | | | | | | | | | When user installs first bacground-enabled extension we set Chrome to be a "Login Item", and when user uninstalls the last one, we remove Chrome from the "Login Items List". Login Items are the apps that are listed in Systempreferences->Accounts->Login Items, or which have a "Open on Login" check for their Dock icon. Since we manipulate the user-faced UI item here, we try to do it minimally (only on first installed and last uninstalled background app) with understanding that when we have UI for install/uninstall we'll convert this into more visible, cancellable suggestion on that UI. Using the same bit that user can manipulate separately and perhaps even knows about is beneficial since it provides for unified place to "start Chrome on Login" and reduces confusion. The patch also removes SetKeepAlive/EndKeepAlive calls for OSX since on OSX they are already used properly to keep Chrome alive when all windows are closed (in other words, on Mac there is only one behavior that also fits what is needed for background apps) Implementation for Login Items List access uses LSSharedFileList API that is availabel starting 10.5, which I think is our minimal supported version of OSX. Also added a check in BackgroundModeManager::RemoveStatusTrayIcon() which could crash on OSX because there is no icon_tray_ yet. Review URL: http://codereview.chromium.org/3163029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57569 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting for Erik:tommi@chromium.org2010-08-264-2/+70
| | | | | | | | | | | | | | | | | | | (http://codereview.chromium.org/3167040/show) In IE8, on Vista, when the user deletes their browsing data, the IDeleteBrowsingHistory interface is invoked twice - once in a low integrity process and once in a medium integrity process. Only the medium integrity process may succeed, but the low integrity process will restart the automation server after failing to connect to it. Upon invocation by IE, check the integrity level of the current process - if it is low, exit. GetProcessIntegrityLevel was adapted from rlz. A follow-up changeset will modify rlz to use this implementation. During editing, some unnecessary headers were removed from win_util.h and correspondingly added to win_util.cc and certain clients who were depending on transient includes. BUG=56212 TEST=Load some pages using Chrome Frame. Close IE. Verify that the Chrome Frame cache has grown and that the accessed domains appear in the history files. Launch IE, load a page using Chrome Frame. Delete Browsing Data. Note that the tab does not crash, that the on-disk cache files shrink, and that the accessed domains no longer appear in the history file Review URL: http://codereview.chromium.org/3171033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57567 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Switch to DWARF for official builds. Good riddence.thestig@chromium.org2010-08-261-5/+0
| | | | | | | | BUG=20737 TEST=none Review URL: http://codereview.chromium.org/2892001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57553 0039d316-1c4b-4281-b951-d872f2087c98
* Make crash reporting client_id accessible through child_process_logging.mnissler@chromium.org2010-08-262-6/+21
| | | | | | | | | | | | | | | | | | On Mac and Linux, keep the client id in a global variable kept by the child_process_logging implementations. This allows to read it in a thread safe fashion when starting a child process. Also replace std::string with statically allocated buffers for the various items we add to the crash reports. This allows to properly handle crashes upon shutdown (std::string would run its destructor, invalidating the memory). BUG=53231 TEST=Crash reporting should still work Review URL: http://codereview.chromium.org/3186028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57497 0039d316-1c4b-4281-b951-d872f2087c98
* Move task_queue.* to base because it makes more sense there.levin@chromium.org2010-08-265-0/+242
| | | | | | | | | TEST=base_test --gtest_filter=TaskQueue*.* (added in this patch). BUG=38475 Review URL: http://codereview.chromium.org/3205004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57479 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the default argument from RegKey::Create.tfarina@chromium.org2010-08-261-1/+1
| | | | | | | | | BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Review URL: http://codereview.chromium.org/3104032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57430 0039d316-1c4b-4281-b951-d872f2087c98
* Fix perms on another of tfarina's commits.viettrungluu@chromium.org2010-08-251-0/+0
| | | | | | | | | | TBR=tfarina@chromium.org BUG=fix your checkout/git setup/whatever TEST=none Review URL: http://codereview.chromium.org/3165058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57291 0039d316-1c4b-4281-b951-d872f2087c98
* base: Assert that RegKey::ValueCount() is updated according in RegistryTest.tfarina@chromium.org2010-08-251-0/+1
| | | | | | | | | BUG=None TEST=out/Debug/base_unittests --gtest_filter=RegistryTest.ValueTest Review URL: http://codereview.chromium.org/3132035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57289 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] if someone overrides FILE_EXE/DIR_EXE in the path service, it can ↵thomasvl@chromium.org2010-08-241-24/+39
| | | | | | | | | | cause the calculation for DIR_SOURCE_ROOT to go wrong. Avoid this by not using the value from the path service. BUG=52918 TEST=green tree Review URL: http://codereview.chromium.org/3176036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57237 0039d316-1c4b-4281-b951-d872f2087c98
* Change the FileUtilProxy callbacks to report error codes instead of booleans.dumi@chromium.org2010-08-243-39/+61
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3165050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57228 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid spawning a thread while enabling the OOM killer on the Mac.avi@chromium.org2010-08-241-7/+14
| | | | | | | | | BUG=53200 TEST=n/a Review URL: http://codereview.chromium.org/3162034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57218 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Revert the diagnostic messages added in r57088.rohitrao@chromium.org2010-08-241-12/+2
| | | | | | | | BUG=52918 TEST=Less log spam. Review URL: http://codereview.chromium.org/3164035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57194 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run CancellationFlagTest.SetOnDifferentThreadDeathTest under Valgrind ↵timurrrr@chromium.org2010-08-241-0/+3
| | | | | | | | | | on Mac TBR=glider BUG=53196 Review URL: http://codereview.chromium.org/3112032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57180 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the gtest filter for the changed OutOfMemoryTest test fixture name.glider@chromium.org2010-08-241-1/+1
| | | | | | | | TBR=levin Review URL: http://codereview.chromium.org/3162033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57157 0039d316-1c4b-4281-b951-d872f2087c98
* Sometimes you want to enforce that some but not all of your methods are ↵levin@chromium.org2010-08-248-15/+296
| | | | | | | | | | | called on the same thread as the constructor. ThreadChecker allows you to do this. BUG=38475 TEST=base_unittests --gtest_filter=NonThreadSafeTest.* and base_unittests --gtest_filter=ThreadChecker.* Review URL: http://codereview.chromium.org/3148032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57140 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gtest warnings when running the process_util_unittest.levin@chromium.org2010-08-231-48/+109
| | | | | | | | | | | | | | | When I run them on OSX, I get a gtest warning about multiple threads: "Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 2 threads." This patch fixes the warnings. BUG=43165 TEST=base_unittest --gtest_filter=OutOfMemoryDeathTest.* Review URL: http://codereview.chromium.org/3201009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57118 0039d316-1c4b-4281-b951-d872f2087c98
* base: Disallow mixing NDEBUG settings in logging.{h,cc}.derat@chromium.org2010-08-232-12/+35
| | | | | | | | | | | | | | | | | | | I am concerned about the possibility that other users of the files in Chrome's base/ directory (e.g. Chrome OS) may build a library from these files with NDEBUG defined and then link it into a binary that includes the headers without defining NDEBUG, or vice versa. This change mangles InitLogging()'s name in logging.h based on whether NDEBUG is defined so that linking will fail if there's a mismatch (Evan provided useful advice here). BUG=chromium-os:1124 TEST=built Debug and Release Chrome, built all Chrome OS packages, and then changed a Chrome OS package that links against libbase.a to define NDEBUG and checked that it failed to link Review URL: http://codereview.chromium.org/3106032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57098 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add diagnostic logging to AmIBundled() to help with bot failures.rohitrao@chromium.org2010-08-231-3/+16
| | | | | | | | | | This change should be reverted as soon as we figure out what's going wrong. BUG=52918 TEST=None Review URL: http://codereview.chromium.org/3197012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57088 0039d316-1c4b-4281-b951-d872f2087c98
* Add functions to get the length or compute a substring of UTF8 and UTF16dmazzoni@chromium.org2010-08-234-0/+279
| | | | | | | | | | | encoded strings. BUG=none TEST=Added new unit tests for each. Review URL: http://codereview.chromium.org/3133028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57051 0039d316-1c4b-4281-b951-d872f2087c98
* Spelling correction: "nonexistant" -> "nonexistent".viettrungluu@chromium.org2010-08-221-1/+1
| | | | | | | | | BUG=none TEST=good spellers are slightly happier Review URL: http://codereview.chromium.org/3143037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57020 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obviously unneeded forward declarations from headers under ↵viettrungluu@chromium.org2010-08-214-13/+2
| | | | | | | | | | | src/{app,base,net}. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3136025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56995 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add basic ReadValue test to RegistryTest.tfarina@chromium.org2010-08-211-1/+6
| | | | | | | | | BUG=None TEST=out/Debug/base_unittests --gtest_filter=RegistryTest.* Review URL: http://codereview.chromium.org/3190010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56965 0039d316-1c4b-4281-b951-d872f2087c98
* Add the reverse test to EnvironmentTest.tfarina@chromium.org2010-08-211-0/+28
| | | | | | | | | | | | This test basically test another behavior of the GetVar function. It tries to get a variable by looking for its reverse form. BUG=None TEST=out/Debug/base_unittests --gtest_filter=EnvironmentTest.GetVarReverse. Review URL: http://codereview.chromium.org/3162025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56950 0039d316-1c4b-4281-b951-d872f2087c98
* Moving file_system_proxy to base/ and changing it to work with ↵dumi@chromium.org2010-08-203-0/+311
| | | | | | | | | | | MessageLoopProxies instead of ChromeThreads. BUG=none TEST=none Review URL: http://codereview.chromium.org/3131026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56923 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/3153008 for bryeung:sky@chromium.org2010-08-205-0/+364
| | | | | | | | | | | | | | | | Synthetic KeyEvent delivery, part I. This delivers synthetic key events to the views hierarchy. This currently does nothing, as nothing is listening for the event in TOUCH_UI (or elsewhere). That part will come later. BUG=none TEST=unit test for key identifier conversion + manual for extension api Review URL: http://codereview.chromium.org/3130029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56886 0039d316-1c4b-4281-b951-d872f2087c98
* Mark StatsTableTest.MultipleProcesses as flaky (again)maruel@chromium.org2010-08-201-1/+2
| | | | | | | | | BUG=10611 TEST=flaky test Review URL: http://codereview.chromium.org/3107028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56859 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use const char kFoo[] in the stack place.tfarina@chromium.org2010-08-201-4/+4
| | | | | | | | | | | | It creates a variable and copy the value all around. Instead use pointer so the other places where the variable is used just point to the orignal variable instead of copying the value. BUG=None TEST=out/Debug/base_unittests --gtest_filter=EnvironmentTest.* Review URL: http://codereview.chromium.org/3186017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56802 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add UMA stat for the file system where the prefs are storedevan@chromium.org2010-08-203-2/+82
| | | | | | | | | | | | | I'd like to see how common it is to use a network file system for your home directory. This would help evaluate how important it is to support these users. See also: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/b43d2905f079fa1c Review URL: http://codereview.chromium.org/3187011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56786 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56738 - Fix CheckFalseTest.CheckFails on Linux after my change to ↵rvargas@google.com2010-08-192-33/+16
| | | | | | | | | | | | | | | | | | ui_test. This makes PathService clear its cache after overriding a path. We have many paths depending on each other, so this is necessary to avoid inconsistencies. TEST=ui_tests in Release mode BUG=49838 Review URL: http://codereview.chromium.org/2805100 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3169031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56778 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FormatBytes to string16.evan@chromium.org2010-08-193-48/+48
| | | | | | | | | | I considered ASCII, but it's producing what is intended to be a human-readable string. For example, in theory the "bytes/s" annotation could be localized into a language where the "b" is non-ASCII. Review URL: http://codereview.chromium.org/3107021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56771 0039d316-1c4b-4281-b951-d872f2087c98
* Fix CheckFalseTest.CheckFails on Linux after my change to ui_test.phajdan.jr@chromium.org2010-08-192-16/+33
| | | | | | | | | | | | | This makes PathService clear its cache after overriding a path. We have many paths depending on each other, so this is necessary to avoid inconsistencies. TEST=ui_tests in Release mode BUG=49838 Review URL: http://codereview.chromium.org/2805100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56738 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix leak in tabpose.thakis@chromium.org2010-08-191-1/+2
| | | | | | | | | BUG=51786 TEST=valgrind stays green Review URL: http://codereview.chromium.org/3183019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56730 0039d316-1c4b-4281-b951-d872f2087c98
* Remove forward declares for ASCIIToUTF16 from string_util. All callers now usebrettw@chromium.org2010-08-192-5/+13
| | | | | | | | | | utf_string_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3148019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56719 0039d316-1c4b-4281-b951-d872f2087c98
* Initial version of chrome.experimental.sidebar extension API. brettw@chromium.org2010-08-191-0/+5
| | | | | | | | | | | | | | BUG=51084 TEST=Run interactive_ui_tests and browser_tests. New: - sidebar Extension API (design doc: https://docs.google.com/a/google.com/Doc?docid=0AV4Qg3xyZ8RQZGZtbWIydDJfNWc0eHJtbmRm&hl=en); - Sidebar panel in Chrome browser view; Original review=http://codereview.chromium.org/2836040/show Patch by alekseys@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56716 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 6)thestig@chromium.org2010-08-193-3/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3093013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Convert FormatBytes to string16."evan@chromium.org2010-08-183-48/+48
| | | | | | This reverts commit r56603. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56608 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FormatBytes to string16.evan@chromium.org2010-08-183-48/+48
| | | | | | | | | | I considered ASCII, but it's producing what is intended to be a human-readable string. For example, in theory the "bytes/s" annotation could be localized into a language where the "b" is non-ASCII. Review URL: http://codereview.chromium.org/3107021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56603 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all wstrings from the IPC logging subsystem.erg@google.com2010-08-181-6/+6
| | | | | | | | | | | | | | | | Changes all IPC Log methods from wstring to string. All static logging debug data changed from wchar[] to char[]. Various string conversion/numeric headers no longer need to be included in ipc_message_utils.h and have been removed (and added in all implementation files that require them). BUG=none TEST=none Review URL: http://codereview.chromium.org/3159013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56563 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DictionaryValue::Equals() to also detect differences in key names.mnissler@chromium.org2010-08-182-7/+15
| | | | | | | | | BUG=52419 TEST=unit tests in values_unittest.cc Review URL: http://codereview.chromium.org/3163020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56536 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetDisplayStringInLTRDirectionality from wstring to string16.tony@chromium.org2010-08-183-11/+15
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3108027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56535 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the deprecated file_util::InsertBeforeExtension.tfarina@chromium.org2010-08-182-66/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3161018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56477 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 03:04:35 +0000