summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Improve GPU tests to fail when GPU drawing fails.jbates@chromium.org2011-12-021-0/+13
| | | | | | | | | | | Changed the accelerated html pages to use raf to draw multiple frames. Changed the webgl and canvas2d pages to draw onscreen rather than offscreen to make sure the compositor draws the page. BUG=105785,104142 Review URL: http://codereview.chromium.org/8692013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112763 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Aura build break.jbates@chromium.org2011-12-021-1/+1
| | | | | | | | TBR=avi Review URL: http://codereview.chromium.org/8772049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112727 0039d316-1c4b-4281-b951-d872f2087c98
* Add TraceAnalyzer support for START/FINISH events and JSON error loggingjbates@chromium.org2011-12-023-40/+136
| | | | | | Review URL: http://codereview.chromium.org/8682027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112723 0039d316-1c4b-4281-b951-d872f2087c98
* trace_event: distinguish between scoped begin/end and global start/finish eventsjbates@chromium.org2011-12-028-171/+388
| | | | | | | | BUG=100131 Review URL: http://codereview.chromium.org/8590015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112722 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab backgroundingdavemoore@chromium.org2011-12-024-106/+106
| | | | | | | | | | | This broke because an incompatible change was made to Process, and because there was no test that would catch it. I've fixed the underlying problem for both Linux and ChromeOS and made it testable. BUG=102726 TEST=Added new RenderProcessHostTest.Backgrounding Review URL: http://codereview.chromium.org/8506036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112712 0039d316-1c4b-4281-b951-d872f2087c98
* Move gtest_prod.h into its own target so it can be correctly set as a ↵ensonic@google.com2011-12-021-0/+1
| | | | | | | | | | | | | dependent target for base and reused as a dependency in gtest. R=brettw BUG=105855 TEST= Review URL: http://codereview.chromium.org/8201001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112701 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a possible mismatch in OS-specific code in WaitableEventWatcher.joi@chromium.org2011-12-021-3/+2
| | | | | | | | | | | Also, sort headers to the extent possible. BUG=none Review URL: http://codereview.chromium.org/8776008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112678 0039d316-1c4b-4281-b951-d872f2087c98
* Make CHECK not print messages in official buildsakalin@chromium.org2011-12-024-28/+88
| | | | | | | | | | | | | | | | | | | | | | | | This cuts down on the number of strings in the executable, as well as executable code to print them. On Linux, this saves 208kb on a stripped official build (chrome executable file went from 64569072 bytes -> 64782064 bytes) On OS X, this saves 209kb on an official build (Google Chrome Framework went from 51483872 bytes -> 51274984 bytes) On Windows, this saves 139kb on an official build (chrome.dll went from 28619264 bytes -> 28477440 bytes) Fix test failure in logging_unittest.cc in official builds. Add new executable check_example for easy testing of changes to the CHECK macros. BUG=101561 TEST= Review URL: http://codereview.chromium.org/8734021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112649 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Android build.jrg@google.com2011-12-021-2/+2
| | | | | | | | | | | Accomodate shmem changes in http://codereview.chromium.org/8585002. BUG=None TEST= Review URL: http://codereview.chromium.org/8771022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112588 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Move ScopedSendingEvent from content/common/mac to base/mac.shess@chromium.org2011-12-017-11/+147
| | | | | | | | | | | Also merge content/ MockCrControlApp into base/ MockCrApp. Also use MockCrApp in test_shell_tests, and slight tweak to autorelease pool in test_shell's initialization. BUG=102224 Review URL: http://codereview.chromium.org/8724004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112578 0039d316-1c4b-4281-b951-d872f2087c98
* Give base::SharedMemory::CreateAnonymous an executable flagmcgrathr@chromium.org2011-12-015-32/+83
| | | | | | | | | | | | | | | | | | | | | NaCl on Mac and Linux needs to create a shared memory object that it can later make executable with mprotect. Express this need in the interface it uses. Add a test that pages mapped from such an object can later be passed to mprotect with PROT_EXEC. This lays the groundwork for a later change that will sometimes use a different method to allocate an object on Linux when it needs to be executable. On some Linux distributions, shm_open yields objects whose mappings cannot be made executable. BUG= http://code.google.com/p/chromium/issues/detail?id=103377 TEST= SharedMemory.AnonymousExecutable R=mark@chromium.org,jam@chromium.org,amit@chromium.org,ben@chromium.org Review URL: http://codereview.chromium.org/8585002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112570 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new base::mac::GetValueFromDictionary<>() method.kushi.p@gmail.com2011-12-013-68/+21
| | | | | | | | | | | | Remove all cases of the old method signature (and related tests) and use the new form. BUG=104200 Review URL: http://codereview.chromium.org/8769016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112553 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Fix unit_tests on linuxsadrul@chromium.org2011-12-011-5/+3
| | | | | | | | | | | | | | | | | Make sure the aura::Desktop is destroyed with the message-loop. This is done by adding a DestroyMessagePump notification to MessagePumpObserver. Also remove some views_unittests that were added to test NativeWidgetViews (which aren't used anymore), and do proper cleanup in AccessibilityEventRouter unittest. TBR=darin@chromium.org BUG=104559, 105613 TEST=unit_tests Review URL: http://codereview.chromium.org/8566037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112474 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 112249 - [Mac] Move ScopedSendingEvent from content/common/mac to ↵hayato@chromium.org2011-12-017-147/+11
| | | | | | | | | | | | | | | base/mac. Also merge content/ MockCrControlApp into base/ MockCrApp. BUG=102224 Review URL: http://codereview.chromium.org/8724004 TBR=shess@chromium.org Review URL: http://codereview.chromium.org/8762020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112411 0039d316-1c4b-4281-b951-d872f2087c98
* Add TraceAnalyzer support for calculating common event rate statisticsjbates@chromium.org2011-12-013-0/+89
| | | | | | Review URL: http://codereview.chromium.org/8678035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112354 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Implement a 1-arity CancelableCallback and use this to implementjhawkins@chromium.org2011-11-304-90/+147
| | | | | | | | | | | | | net::CancelableCompletionClosure. BUG=none TEST=none R=ajwong@chromium.org Review URL: http://codereview.chromium.org/8662047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112279 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Move ScopedSendingEvent from content/common/mac to base/mac.shess@chromium.org2011-11-307-11/+147
| | | | | | | | | | Also merge content/ MockCrControlApp into base/ MockCrApp. BUG=102224 Review URL: http://codereview.chromium.org/8724004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112249 0039d316-1c4b-4281-b951-d872f2087c98
* base: remove unused header and include the right one insteadensonic@google.com2011-11-301-1/+0
| | | | | | | | | | | Don't include "base/gtest_prod_util.h". It defines one macro and that is not used here. Include the needed testing header in two places instead. BUG=105855 Review URL: http://codereview.chromium.org/8555003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112209 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sources list for symbolize.ensonic@google.com2011-11-301-1/+7
| | | | | | | | | BUG=105855 Review URL: http://codereview.chromium.org/8440064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112200 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid holding the lock while we do alarm processingjar@chromium.org2011-11-301-1/+4
| | | | | | | r=rtenneti Review URL: http://codereview.chromium.org/8686011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112144 0039d316-1c4b-4281-b951-d872f2087c98
* Make ThreadLocalStorage more posix pthread compliantjar@chromium.org2011-11-293-30/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is my first shot at cleaning up the implementation. 1) I support multiple calls to destructors, as suggested in pthread standards 2) I added volatile so that the destructors can't cause any compiler confusion if they are nulled out while a second thread is calling the list of destructors. 3) Windows already avoids producing a key which has value zero <good!>, but I added some DHECKs to make this fact more obvious. I plan to try to enforce that in the posix is similarly constrained... but that will be in a future CL. 4) I did some extra cleaning of destructor handling, so that it is plausible that TCMalloc can use this service (and not have to hack its own). The problem *was* that initialization called new, which would trigger allocation activities before a thread local heap could be setup <sigh>. This is now fixed (in this CL). I also handled the destructor calls with greater care, avoiding calling delete after all the destructors have been called (as that would re-incarnate a TCMalloc heap). This is also fixed. r=willchan BUG=105410 Review URL: http://codereview.chromium.org/8702014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112030 0039d316-1c4b-4281-b951-d872f2087c98
* Allow const pointers to be stored in ThreadLocalPointer.jbates@chromium.org2011-11-292-5/+5
| | | | | | Review URL: http://codereview.chromium.org/8666010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112021 0039d316-1c4b-4281-b951-d872f2087c98
* ake string_util::WriteInto() DCHECK() that the supplied |length_with_null| > ↵pkasting@chromium.org2011-11-296-70/+51
| | | | | | | | | | | | 1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all. Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds. BUG=none TEST=none Review URL: http://codereview.chromium.org/8418034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98
* remove entry from includes as it is already pulled from the dependenciesensonic@google.com2011-11-291-1/+0
| | | | | | Review URL: http://codereview.chromium.org/8440063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111958 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all usages of FRIEND_TEST() with FRIEND_TEST_ALL_PREFIXES()robertshield@chromium.org2011-11-293-21/+27
| | | | | | | | BUG=105287 TEST=NONE Review URL: http://codereview.chromium.org/8678017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111935 0039d316-1c4b-4281-b951-d872f2087c98
* Remove several more custom Task implementations from base/dcheng@chromium.org2011-11-293-153/+99
| | | | | | | | | | | BUG=none TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111865 Review URL: http://codereview.chromium.org/8702016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111879 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111865 - Remove several more custom Task implementations from base/dcheng@chromium.org2011-11-293-90/+151
| | | | | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/8702016 TBR=dcheng@chromium.org Review URL: http://codereview.chromium.org/8729020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111868 0039d316-1c4b-4281-b951-d872f2087c98
* Remove several more custom Task implementations from base/dcheng@chromium.org2011-11-293-151/+90
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/8702016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111865 0039d316-1c4b-4281-b951-d872f2087c98
* Increase Bind/Callback Arity from 6 -> 7.ajwong@chromium.org2011-11-288-21/+751
| | | | | | | | | | | | | | A few functions need this and the expected compile-speed impact is low. We should be careful when raising this number higher. If you're binding a function that has more parameters than this supports, consider refactoring your API to use a parameter struct or something. Template equation: (n^2 + 26n) / 2 Template growth: 96 -> 116 types. BUG=98542 TEST=try bots Review URL: http://codereview.chromium.org/8728010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111788 0039d316-1c4b-4281-b951-d872f2087c98
* callback_forward.h forward-declares base::Callback and base::Closure.erikwright@chromium.org2011-11-285-4/+22
| | | | | | | | | | | | | | This CL includes callback_forward.h and a number of files that depend on it. Other CLs have been sent to other reviewers, according to OWNERS files. This search shows the other CLs: http://goo.gl/vzQoJ See this chromium-dev thread for the rationale behind the change: http://goo.gl/I3kob BUG=None TEST=Compiles Review URL: http://codereview.chromium.org/8702019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111782 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Convert ASCIIToUTF16("") to string16().jhawkins@chromium.org2011-11-283-12/+15
| | | | | | | | | | | | | Inspired by r111713. BUG=none TEST=none R=gbillock@chromium.org Review URL: http://codereview.chromium.org/8687002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111768 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert devtools_sanity_unittest.cc.jhawkins@chromium.org2011-11-281-1/+1
| | | | | | | | | | | BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8715001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111723 0039d316-1c4b-4281-b951-d872f2087c98
* Value::GetAsDictionarybattre@chromium.org2011-11-263-1/+44
| | | | | | | | | | BUG=none TEST=no Review URL: http://codereview.chromium.org/8701002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111623 0039d316-1c4b-4281-b951-d872f2087c98
* Removing SignalingTask and replace with base::Bind(&WaitableEvent::Signal, ...)dcheng@chromium.org2011-11-253-53/+0
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/8696001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111603 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111548 - Broke OmniboxViewTest.AcceptKeywordBySpace on Linuxrsleevi@chromium.org2011-11-241-1/+1
| | | | | | | | | | | | | | | | Strip invalid characters (line breaks, tabs), javascript:schemes from the copied text while pasting text, droping text and creating right click popup for omnibox. BUG=82181, 103703. TEST=Copy a string with line breaks "\n" or tabs "\t". Then right click on omnibox. Chromium should not trigger DCHECKS. Review URL: http://codereview.chromium.org/8513002 TBR=ncj674@motorola.com Review URL: http://codereview.chromium.org/8690006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111558 0039d316-1c4b-4281-b951-d872f2087c98
* Strip invalid characters (line breaks, tabs), javascript:schemes from the ↵ncj674@motorola.com2011-11-241-1/+1
| | | | | | | | | | | | | copied text while pasting text, droping text and creating right click popup for omnibox. BUG=82181, 103703. TEST=Copy a string with line breaks "\n" or tabs "\t". Then right click on omnibox. Chromium should not trigger DCHECKS. Review URL: http://codereview.chromium.org/8513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111548 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Implement CancelableCallback to replace CancelableTask.jhawkins@chromium.org2011-11-246-1/+334
| | | | | | | | | | | | | Designed by groby,binji,csilv,jhawkins. BUG=96749 TEST=CancelableCallbackTest.* R=ajwong@chromium.org,darin@chromium.org Review URL: http://codereview.chromium.org/8673008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111493 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Increase Bind/Callback Arity from 6 -> 11: These go to eleven."ajwong@chromium.org2011-11-248-4792/+5
| | | | | | | | | | | | | | | This reverts r111410. Doing this increased Win builder cycle time by about 10s on incrementals (eyeballed from stats dashboard). Alas, 11 proved to be too high for us. BUG=98542 TEST=none Review URL: http://codereview.chromium.org/8682030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111463 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bogus line and fix treejar@chromium.org2011-11-241-2/+0
| | | | | | | tbr=rtenneti Review URL: http://codereview.chromium.org/8680037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111453 0039d316-1c4b-4281-b951-d872f2087c98
* Check that thread contexts are cleaned up during profilingjar@chromium.org2011-11-242-19/+57
| | | | | | | | | | | | | | | | | There was a Thread Local Store regression, wherein thread cleanup notifcation was not sent to TLS users. This CL ensures that when this happens, that Chrome will crash. For now, I'm landed with a short-circuit (returns true all the time) in the test. I'll remove the TODO when we have XP properly supported. r=rtenneti BUG=103209 Review URL: http://codereview.chromium.org/8606001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111451 0039d316-1c4b-4281-b951-d872f2087c98
* Extract similar code into SetJobObjectAsKillOnJobClose()toyoshim@chromium.org2011-11-232-0/+20
| | | | | | | | | | | | | For now, Chromium have five same code in various place to handle JobObject as KILL_ON_JOB_CLOSE. This change provide a common utility function to be used by them. BUG=n/a TEST=n/a; run existing unit tests because this is just a refactoring change Review URL: http://codereview.chromium.org/8667006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111441 0039d316-1c4b-4281-b951-d872f2087c98
* Fix many* python scripts in src/maruel@chromium.org2011-11-231-1/+0
| | | | | | | | | | | | | | | | | | | | Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. * Do not fix them all at once otherwise the CL would be too large. TBR=jamiewalch@chromium.org BUG=105108 TEST= Review URL: http://codereview.chromium.org/8665013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111427 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to base/, dbus/.avi@chromium.org2011-11-231-4/+4
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8684001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111411 0039d316-1c4b-4281-b951-d872f2087c98
* Increase Bind/Callback Arity from 6 -> 11: These go to eleven.ajwong@chromium.org2011-11-238-5/+4792
| | | | | | | | | | | | | | | | | | | | | | | | This is only for a build time stress test only. I will revert back to 6 after getting the data. 11 allows for binding of 11 arguments to a function, and 10 arguments to a method. 10 seemed like a nice round number to try (MSVC's tr1::bind() only supports 10). Template Growth rate (n == arity): bind.h: n bind_internal.h: (n^2 + 20n)/2 bind_internal_win.h: n callback.h: n Template growth equation: (n^2 + 26n) / 2 Template growth: 96 -> 203 types BUG=98542 TEST=try bots. Then we get to watch the bot cycle times. Review URL: http://codereview.chromium.org/8682015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111410 0039d316-1c4b-4281-b951-d872f2087c98
* Remove custom Task implementations in base.dcheng@chromium.org2011-11-237-104/+61
| | | | | | | | | | | | I left a few unconverted in this one, because they made my head hurt. BUG=none TEST=base_unittests Review URL: http://codereview.chromium.org/8653006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111407 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert FilePathWatcher.jhawkins@chromium.org2011-11-235-70/+44
| | | | | | | | | | | BUG=none TEST=none R=willchan@chromium.org Review URL: http://codereview.chromium.org/8677015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111405 0039d316-1c4b-4281-b951-d872f2087c98
* Make ObserverListThreadSafe key its observers by PlatformThreadId instead of ↵rsesek@chromium.org2011-11-232-16/+70
| | | | | | | | | | | | | | MessageLoop. This fixes a subtle behavior that drops RemoveObserver operations when the current() loop is NULL. Now those operations will always succeed. BUG=104826 TEST=base_unittests Review URL: http://codereview.chromium.org/8635002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111404 0039d316-1c4b-4281-b951-d872f2087c98
* Move the ProcessWatcher methods out of content/common/process_watcher into ↵jam@chromium.org2011-11-235-0/+394
| | | | | | | | | | | base/process_util, alongside the other process methods. The only non-trivial move change is to the Windows implementation, where I changed KillProcess to use an exit code of kProcessKilledExitCode instead of content::RESULT_CODE_HUNG. cpu said that the existing code was incorrect, since GetTerminationStatus() should be mapping that result to TERMINATION_STATUS_PROCESS_WAS_KILLED. So I changed the exit code to kProcessKilledExitCode. This might make the UMA stats for killed processes to go up (and crashed to go down), but that will be an accounting change and should be zero-sum. BUG=98716 Review URL: http://codereview.chromium.org/8674003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111371 0039d316-1c4b-4281-b951-d872f2087c98
* Add CHECKs for file descriptors used in select() by InotifyReaderTaskmnissler@chromium.org2011-11-231-0/+5
| | | | | | | | | | | | Since these are used in an fd_set, there's the possibility that invalid file descriptors cause stack overflow/corruption. BUG=chromium:105162 TEST=No functional changes, compiles and passes tests. Review URL: http://codereview.chromium.org/8681006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111369 0039d316-1c4b-4281-b951-d872f2087c98
* DefaultDispatcher for MessagePumpXoshima@chromium.org2011-11-232-5/+22
| | | | | | | | | | | | | | MPX itself doesn't know how to handle events and we've been converting MessageLoop::Run() -> Desktop::Run() or RunAllPending to use ui_test_utils::RunAllPendingInMessageLoop(). It's no longer necessary with this CL. Windows's message pump can dispatch events without dispatcher. BUG=none TEST=none, but I believe some of browser_tests on aura is flaky because of this, and this CL should make them less/non flaky. Review URL: http://codereview.chromium.org/8635014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111324 0039d316-1c4b-4281-b951-d872f2087c98