summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Initialize members in Encryptor constructors.finnur@chromium.org2011-02-164-8/+16
| | | | | | | | | | BUG=None TEST=None CID=8517 Review URL: http://codereview.chromium.org/6482024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75089 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r74850 and r74865:ajwong@chromium.org2011-02-152-26/+11
| | | | | | | | | | | | - Redo "Add extra heap-allocation to refcounting. For perf test only." - Another intentional leak introduced by r74850 BUG=none TEST=none Review URL: http://codereview.chromium.org/6484047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75005 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete dependencies that create needless recompiling.jeanluc@chromium.org2011-02-151-1/+0
| | | | | | | | | BUG=71130 Review URL: http://codereview.chromium.org/6523009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74966 0039d316-1c4b-4281-b951-d872f2087c98
* Clang doesn't like EXPECT_EQ with false and a template value.ajwong@chromium.org2011-02-151-7/+7
| | | | | | | | | BUG=none TEST=Clang try-bot passes. Review URL: http://codereview.chromium.org/6523014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74908 0039d316-1c4b-4281-b951-d872f2087c98
* Unified callback system based on tr1::function/tr1::bind and Google's ↵ajwong@chromium.org2011-02-1514-214/+4103
| | | | | | | | | | | | | | | internal callback code. This callback system allows for creation of functors for normal functions, methods, and const methods. It is a superset of the functionality of NewRunnableMethod, NewRunnableFunction, NewCallback, and CreateFunctor. We support partial binding of function arguments, and also specification of refcounting semantics by wrapping a target object in a wrapper object. BUG=35223 TEST=none Review URL: http://codereview.chromium.org/6109007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74904 0039d316-1c4b-4281-b951-d872f2087c98
* Redo "Add extra heap-allocation to refcounting. For perf test only."ajwong@chromium.org2011-02-142-11/+26
| | | | | | | | | | | | | Leaving it in tree for longer perf testing. Original review http://codereview.chromium.org/6484024/ BUG=none TEST=none Review URL: http://codereview.chromium.org/6517022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74850 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize SecureHashAlgorithm members.finnur@chromium.org2011-02-141-1/+6
| | | | | | | | | | BUG=None TEST=None CID=7562 Review URL: http://codereview.chromium.org/6482025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74793 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize EventRecorder member.finnur@chromium.org2011-02-141-1/+4
| | | | | | | | | | BUG=None TEST=None CID=1647 Review URL: http://codereview.chromium.org/6469028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74791 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add extra heap-allocation to refcounting. For perf test only. Will ↵ajwong@chromium.org2011-02-132-26/+11
| | | | | | | | | | Revert after one build." This reverts commit r74764. TBR=willchan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74765 0039d316-1c4b-4281-b951-d872f2087c98
* Add extra heap-allocation to refcounting. For perf test only. Will Revert ↵ajwong@chromium.org2011-02-132-11/+26
| | | | | | | | | | | after one build. BUG= TEST= Review URL: http://codereview.chromium.org/6484024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74764 0039d316-1c4b-4281-b951-d872f2087c98
* Fix *RegValueWorkItem to handle a case where previous value is empty.amit@chromium.org2011-02-111-1/+1
| | | | | | | | | | | Not handling correctly caused a crash. Added unit tests to cover those cases. BUG=71953 TEST=covered by installer util unit tests Review URL: http://codereview.chromium.org/6485026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74675 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Prefetch the browser with a longer timeout before running browser tests.phajdan.jr@chromium.org2011-02-111-1/+1
| | | | | | | | | | | | Also remove hacky code to increase timeout for specific tests. Instead, allow to increase test termination timeout via SLOW_ prefix (should be used as last resort). BUG=none TEST=none Review URL: http://codereview.chromium.org/6410059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74649 0039d316-1c4b-4281-b951-d872f2087c98
* Use DispatchX for dispatching X events.sadrul@chromium.org2011-02-112-2/+2
| | | | | | | | | | This fixes an error clang shows with -Woverloaded-virtual. BUG=72575 TEST=none Review URL: http://codereview.chromium.org/6487004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74595 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize StatsTable::Private members.finnur@chromium.org2011-02-111-2/+9
| | | | | | | | | | BUG=None TEST=None CID=13412 Review URL: http://codereview.chromium.org/6483011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74594 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize members of ThreadLocalStorage::Slot.finnur@chromium.org2011-02-112-4/+6
| | | | | | | | | | BUG=None TEST=None CID=14347 Review URL: http://codereview.chromium.org/6476028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74593 0039d316-1c4b-4281-b951-d872f2087c98
* Stats tables are only used for debugging at this point, and when I turnmbelshe@chromium.org2011-02-101-1/+1
| | | | | | | | | | | | | | on full dom tracing, I need larger names and more of them. Increase the counter limit and the size per name. This only has effect when the user is using --enable-stats-table BUG=none TEST=none Review URL: http://codereview.chromium.org/6474008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74481 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for ICU data in a data file.thomasvl@chromium.org2011-02-103-1/+48
| | | | | | | | | | | | | | | | | | | | | - Mac Foundation utility for fetching a resource from the MainAppBundle. - Bringing in newer ICU dep that has optional support for using the ICU data file. - If Mac is built using a ICU data file, directly map in the data so it will work even in a sandboxed process. **The build does not use this data file support at this time.** This might help the Mac bots as it means each unittest that depends on base will be ~10meg smaller, helping link and also helping with the copy of bits from the builder to the tester. If Mac ever support a Universal binary (32bit and 64bit) it will also probably want to use this to avoid carrying two copies of the ICU data. Review URL: http://codereview.chromium.org/6479021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74474 0039d316-1c4b-4281-b951-d872f2087c98
* Lower process priorities of backgrounded tabs on restoredavemoore@chromium.org2011-02-091-0/+7
| | | | | | | | | BUG=chromium-os:10876,chromium-os:10924 TEST=login (w/auto restore) with a large number of tabs. Verify that system is still responsive. Review URL: http://codereview.chromium.org/6459003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74332 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Restrict access to xdg-mime functions to the FILE thread.thestig@chromium.org2011-02-081-0/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6312195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74183 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to create self signed certs to mac.dmaclach@chromium.org2011-02-086-57/+207
| | | | | | | | | BUG=67929 TEST=BUILD Review URL: http://codereview.chromium.org/6312157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74115 0039d316-1c4b-4281-b951-d872f2087c98
* [Logging] Remove unneeded CheckOpString struct for CHECKsakalin@chromium.org2011-02-082-21/+15
| | | | | | | | | | | | | | | Using string* directly works. Made LogMessage delete any passed in string* after it uses it. Removed suppressions for fixed memory leak. BUG=57683 TEST=Existing unit tests Review URL: http://codereview.chromium.org/6413032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74100 0039d316-1c4b-4281-b951-d872f2087c98
* Make a DCHECK into a much more useful DCHECK_EQ in message_pump_win.cc.adamk@chromium.org2011-02-081-1/+1
| | | | | | Review URL: http://codereview.chromium.org/6246155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74065 0039d316-1c4b-4281-b951-d872f2087c98
* Roll clang to r124477.thakis@chromium.org2011-02-071-3/+2
| | | | | | | | | | | Also reenable OVERRIDE. BUG=71088 TEST=none Review URL: http://codereview.chromium.org/6250188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73994 0039d316-1c4b-4281-b951-d872f2087c98
* FilePath: Remove much of ToWStringHack, adding a LossyDisplayName()evan@chromium.org2011-02-043-5/+22
| | | | | | | | | | | | | | | The reason we don't want a free conversion between FilePaths and Unicode is that it can be lossy. But when displaying a string to the user, we're ok if it's lossy when we have no other option. This change introduces a LossyDisplayName() method that returns a string16, and converts many of the users of ToWStringHack to use it. BUG=69467 Review URL: http://codereview.chromium.org/6246036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73840 0039d316-1c4b-4281-b951-d872f2087c98
* Update the dynamic annotations to the trunk version fromglider@chromium.org2011-02-042-176/+266
| | | | | | | | | http://code.google.com/p/data-race-test This is necessary to build Chromium with a custom annotations prefix in order to link it against ThreadSanitizer runtime library. Review URL: http://codereview.chromium.org/6250125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73794 0039d316-1c4b-4281-b951-d872f2087c98
* Copy buffers in base::FileUtilProxy::{Read,Write} to avoid memory corruption. darin@chromium.org2011-02-042-20/+21
| | | | | | | | | | | | | | | | | | If caller has called PPB_FileIO_Impl::Close() while a read or write operation is in flight, and deletes the read or write buffer, we now avoid corrupting memory. For Write, FileUtilProxy::Write simply copies the input buffer before passing control to the FILE thread. For Read, the caller no longer passes a buffer; instead, they are passed a const char* in the ReadCallback. One caller of FileUtilProxy::Read outside of PPAPI was also updated. BUG=70285 R=darin Patch by Adam Klein (adamk@chromium.org) Originally reviewed at http://codereview.chromium.org/6312040/ Review URL: http://codereview.chromium.org/6349090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73714 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform CL to remove app/win/win_util.h&cc and related work.msw@chromium.org2011-02-034-74/+3
| | | | | | | | | | | | | | | | | | | | See Issue 70141 for the full move details; see my inline review comments. Changes significantly different from or beyond those prescribed by the bug: *Consolidated a lot of GrabWindowSnapshot code. *Moved EnsureRectIsVisibleInRect to views::internal namespace for test access. *Moved app/win/win_util_unittest.cc to views/window/window_win_unittest.h *Named ui/base/message_box_win.h instead of ui/base/message_box.h *Made WindowWin::GetWindowTitleFont static; needed in static contexts. *Denoted WindowWin::FrameTypeChanged as a Window override, moved code. *Moved TestGrabWindowSnapshot into new file: chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm BUG=70141 TEST=none Review URL: http://codereview.chromium.org/6386009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73589 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup base & app unit test MockCrApp NSApp initialization.msw@chromium.org2011-02-032-3/+10
| | | | | | | | | | | | | | Provide chrome unit test CrApplication NSApp initialization. Chrome requires a legitimate message loop for its unit tests. Ensure that init occurs before the base class MockCrApp init. BUG=71686 TEST=Run all base/app/chrome unit tests on Mac; try bug repro Review URL: http://codereview.chromium.org/6349058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73581 0039d316-1c4b-4281-b951-d872f2087c98
* Added command line switches and UI (controlled via a build option)davemoore@chromium.org2011-02-013-0/+102
| | | | | | | | | | | to make it easier to use the sampling profiler. BUG=None TEST=None Review URL: http://codereview.chromium.org/6250070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73374 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DIR_SOURCE_ROOT for WebKit checkouts on linuxjamesr@chromium.org2011-02-011-3/+3
| | | | | | | | | | | | There's a hardcoded path fixup for base::DIR_SOURCE_ROOT for WebKit-only checkouts that wasn't updated when the WebKit/chromium directory moved under Source/ a few weeks ago. BUG= TEST= Review URL: http://codereview.chromium.org/6334035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73371 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Real* to Double* in values.* and dependent filesarv@chromium.org2011-02-017-91/+91
| | | | | | | | | BUG=None TEST=Compiles and passes all tests Review URL: http://codereview.chromium.org/6248026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73232 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete files from 'sources'. This causes needless work on ↵jeanluc@chromium.org2011-01-311-1/+0
| | | | | | | | | | | incremental builds in VS2010. BUG=71130 TEST=Check that Chrome builds. Review URL: http://codereview.chromium.org/6386019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73190 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 73121 - Remove obsolete files from 'sources'. This causes needless ↵nsylvain@chromium.org2011-01-312-0/+2
| | | | | | | | | | | | | | | | | | work on incremental builds in VS2010. This is breaking clobber builds with this error : e:\b\build\slave\google-chrome-rel-win\build\src\chrome_frame\iids.cc(6) : fatal error C1083: Cannot open include file: 'chrome_tab.h': No such file or directory BUG=71130 TEST=Check that Chrome builds. Review URL: http://codereview.chromium.org/6307018 TBR=jeanluc@chromium.org Review URL: http://codereview.chromium.org/6347032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73124 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete files from 'sources'. This causes needless work on ↵jeanluc@chromium.org2011-01-302-2/+0
| | | | | | | | | | | incremental builds in VS2010. BUG=71130 TEST=Check that Chrome builds. Review URL: http://codereview.chromium.org/6307018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73121 0039d316-1c4b-4281-b951-d872f2087c98
* Change size() function to return a size_t so that result size is not ↵mrossetti@chromium.org2011-01-281-2/+1
| | | | | | | | | | | inadvertently truncated. BUG=None TEST=Ran existing unit tests and trybots. Review URL: http://codereview.chromium.org/6386008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73001 0039d316-1c4b-4281-b951-d872f2087c98
* Move some mac_util functions into foundation_util.rohitrao@chromium.org2011-01-285-293/+340
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6278018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72966 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug in ProcessIterator::CheckForNextProcess(). Under load it'ssky@chromium.org2011-01-281-4/+4
| | | | | | | | | | | | | very easy for the processes to change between the time we get a proc id from /proc then try to get other status. We shouldn't stop iterating in this case, just continue on. BUG=52022 TEST=none Review URL: http://codereview.chromium.org/6398005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72964 0039d316-1c4b-4281-b951-d872f2087c98
* Renames secure_hash.cc to secure_hash_default.ccbulach@chromium.org2011-01-282-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6395006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72963 0039d316-1c4b-4281-b951-d872f2087c98
* Change UTF8ToUTF16 to accept const StringPiece&.suzhe@google.com2011-01-286-38/+24
| | | | | | | | | BUG=70936 TEST=All unit tests should pass. Review URL: http://codereview.chromium.org/6317016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72921 0039d316-1c4b-4281-b951-d872f2087c98
* Disable OVERRIDE for clang for a while.thakis@chromium.org2011-01-271-2/+3
| | | | | | | | | | | This blocks rolling clang, and I need to roll clang for the plugin stuff. BUG=71088 TEST=none Review URL: http://codereview.chromium.org/6329027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72873 0039d316-1c4b-4281-b951-d872f2087c98
* Renames secure_hash_nss.cc to secure_hash.ccbulach@chromium.org2011-01-272-2/+2
| | | | | | | | | | | | | (there's an exclusion for _nss on non-linux platforms, however we need this file for mac and windows as well.) this is a build fix for http://src.chromium.org/viewvc/chrome?view=rev&revision=72782) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6374015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72783 0039d316-1c4b-4281-b951-d872f2087c98
* Abstracts SHA256 context for NSS / OpenSSL.bulach@chromium.org2011-01-276-0/+178
| | | | | | | | | | | Stubs out SslServerSocket for OpenSSL. BUG=none TEST=Sha256Test.TestContext (and compiles with openssl flag). Review URL: http://codereview.chromium.org/6276002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72782 0039d316-1c4b-4281-b951-d872f2087c98
* Check that we've got a complete header before accessing its fields.glider@chromium.org2011-01-263-0/+15
| | | | | | | | | | | | | This patch was prepared by Evgeniy Stepanov (eugenis@chromium.org) and reviewed at http://codereview.chromium.org/6353010/ BUG=70376 TEST=none TBR=darin,willchan Review URL: http://codereview.chromium.org/6347013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72634 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more Valgrind header (memcheck.h) and update the one we already have. glider@chromium.org2011-01-263-122/+1268
| | | | | | | | | | | This patch was prepared by eugenis@chromium.org (doesn't have a committer access yet) and reviewed at http://codereview.chromium.org/6327018/ TBR=evanm,timurrrr Review URL: http://codereview.chromium.org/6312013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72632 0039d316-1c4b-4281-b951-d872f2087c98
* Allow CDSA/CSSM to be used on worker threads in debug builds by making both ↵rsleevi@chromium.org2011-01-261-6/+6
| | | | | | | | | | | | | the CSSM init singleton and the Mac Security Services lock singleton leaky. This primarily affects the use of <keygen> in a debug build, as the RSA private key is generated on a worker thread and needs to hold the Mac Security Services lock. BUG=none TEST=none Review URL: http://codereview.chromium.org/6354017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72580 0039d316-1c4b-4281-b951-d872f2087c98
* Add MessageLoop::AssertIdle(). Use in ChromeOS audio threads.willchan@chromium.org2011-01-262-2/+11
| | | | | | | | | BUG=chrome-os:11110 TEST=existing Review URL: http://codereview.chromium.org/6374010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72576 0039d316-1c4b-4281-b951-d872f2087c98
* Properly order the cc files based off the h files in base/.erg@google.com2011-01-256-399/+389
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6385003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72505 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary whitelist several cases of disk I/O on the UI threads in cros.nkostylev@chromium.org2011-01-241-0/+3
| | | | | | | | | BUG=60211, 70097, 70119, 70131, 62626, 61143, chromium-os:11102, chromium-os:11104, chromium-os:11105, chromium-os:11106, chromium-os:11109 TEST=bots Review URL: http://codereview.chromium.org/6272012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72331 0039d316-1c4b-4281-b951-d872f2087c98
* Remove sanity check in RegKey to prevent usage of checkingamit@chromium.org2011-01-212-67/+34
| | | | | | | | | | | | return value as a bool BUG=none TEST=none Review URL: http://codereview.chromium.org/6346010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72110 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the process is _really_ gone after a __debugbreak(). We've had acevans@chromium.org2011-01-212-0/+6
| | | | | | | | | | | | | few annoying cases where someone has been monitoring Chrome under windbg, which can skip over __debugbreak() and then show them a scary-looking access violation. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6372008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72107 0039d316-1c4b-4281-b951-d872f2087c98