summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* [base] Move AutoReset to base namespace.dbeam@chromium.org2012-11-214-10/+14
| | | | | | | | | | | NOTRY=true R=darin@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11308132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168978 0039d316-1c4b-4281-b951-d872f2087c98
* base/prefs: Remove important_file_writer.h entry from DEPS whitelist.tfarina@chromium.org2012-11-211-1/+0
| | | | | | | | | | | | important_file_writer.h is now in base/files/ directory. BUG=155525 TBR=joi@chromium.org Review URL: https://chromiumcodereview.appspot.com/11417092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168929 0039d316-1c4b-4281-b951-d872f2087c98
* Add copy and assignment to FundamentalValue and StringValue.estade@chromium.org2012-11-202-14/+12
| | | | | | | | | | | | | Also get rid of use of CreateStringValue in chromeos/ directory. This is a retry of r167808, but adding the copy and assign constructors fixes a clang compile error. BUG=160586 Review URL: https://chromiumcodereview.appspot.com/11418048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168868 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECK to avoid binding values to null callbackshashimoto@chromium.org2012-11-203-0/+14
| | | | | | | | | | BUG=161714 TEST=base_unittests Review URL: https://chromiumcodereview.appspot.com/11419061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168764 0039d316-1c4b-4281-b951-d872f2087c98
* Make ShareToProcess return false when dup() fails. This matches the behaviordarin@chromium.org2012-11-201-1/+5
| | | | | | | | | | | of the function on Windows. R=mark@chromium.org BUG=160401 Review URL: https://chromiumcodereview.appspot.com/11416078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168751 0039d316-1c4b-4281-b951-d872f2087c98
* AwContents Compositor bring upjoth@chromium.org2012-11-203-0/+11
| | | | | | | | | | | | | | | | | | Enables DrawGL rendering (when used in downstream integration environment) Still loose ends for: - hiding the view and resource release paths - correctly using the AwDrawGLInfo parameters, esp clip. - and its a bit crashy Depends on http://codereview.chromium.org/11293264/ and http://codereview.chromium.org/11343058/ BUG=161409 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11418025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168712 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize on |trial_name| and |group_name| in field trials API.asvitkine@chromium.org2012-11-193-53/+55
| | | | | | | | | | BUG=none TEST=compiles TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11418065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168579 0039d316-1c4b-4281-b951-d872f2087c98
* Handle portrait mode in is-a-tablet heuristic.grt@chromium.org2012-11-191-1/+4
| | | | | | | | | | BUG=161229 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/11413040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168528 0039d316-1c4b-4281-b951-d872f2087c98
* Add ManagedModeSiteList and use it in ManagedModeURLFilter.bauerb@chromium.org2012-11-191-0/+2
| | | | | | | | | | | | | | Other changes to ManagedModeURLFilter: * Create two copies, one for the UI thread and one for the IO thread. * Support matching hostname hashes in addition to URL patterns TBR=willchan@chromium.org,ben@chromium.org BUG=134417 Review URL: https://chromiumcodereview.appspot.com/11362155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168515 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc 4.7 compilation problem by adding explict unistd.h inclusion.shenhan@google.com2012-11-171-0/+4
| | | | | | | | | | | | | (intptr_t is defined in unistd.h) TEST=Built using gcc 4.7 BUG= Review URL: https://chromiumcodereview.appspot.com/11412026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168439 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_temp_dir from base to base/filesbrettw@chromium.org2012-11-1618-38/+50
| | | | | | | | | | Also add to base namespace. BUG= Review URL: https://codereview.chromium.org/11359217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168281 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 168239 - Extract SIGPIPE ignoring code to a common place.dmichael@google.com2012-11-164-20/+11
| | | | | | | | | | | | | | | | | | | Failed compile on Linux Clang: http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/35971/steps/compile/logs/stdio ../../chrome/test/webdriver/webdriver_server.cc:230:8:error: use of undeclared identifier 'IgnoreSigPipe'; did you mean 'base::IgnoreSigPipe'? if (!IgnoreSigPipe()) { ^~~~~~~~~~~~~ base::IgnoreSigPipe ../../base/process_util.h:153:18: note: 'base::IgnoreSigPipe' declared here BUG=none Review URL: https://codereview.chromium.org/11280010 TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/11308073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168248 0039d316-1c4b-4281-b951-d872f2087c98
* Extract SIGPIPE ignoring code to a common place.phajdan.jr@chromium.org2012-11-164-11/+20
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11280010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168239 0039d316-1c4b-4281-b951-d872f2087c98
* Put Android systrace calls in trace_event_impl only.wangxianzhu@chromium.org2012-11-155-58/+72
| | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/11345019/ added code in both trace_event.h/cc and trace_event_impl.h/cc to support Android systrace. However, to make TRACE_EVENT in Webkit work, we would also need to change the TraceEvent.h in WebKit. This change removes Android systrace calls from trace_event.h/cc and put all ATrace specific code into trace_event_impl.h/cc so that trace_event for Android can work for WebKit without changing WebKit and/or webkit glue code. TBR=brettw BUG= Review URL: https://chromiumcodereview.appspot.com/11360208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167983 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory.kinaba@chromium.org2012-11-151-2/+3
| | | | | | | | | | | | | | | | | | | Reverting because the patch makes clang build failing: > chrome/browser/chromeos/cros/network_library.cc:380:26:error: C++98 requires an > accessible copy constructor for class 'base::StringValue' when binding a > reference to a temporary; was private [-Werror,-Wbind-to-temporary-copy] > SetValueProperty(prop, base::StringValue(str)); etc. BUG=160586 Review URL: https://chromiumcodereview.appspot.com/11363203 TBR=estade@chromium.org Review URL: https://codereview.chromium.org/11369258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167826 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of use of CreateStringValue in chromeos/ directory.estade@chromium.org2012-11-151-3/+2
| | | | | | | | | BUG=160586 Review URL: https://chromiumcodereview.appspot.com/11363203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167808 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style typo (missing space) in base/path_service_unittest.ccgab@chromium.org2012-11-151-1/+1
| | | | | | | | | | | NOTRY=True BUG=None TBR=willchan Review URL: https://chromiumcodereview.appspot.com/11359220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167801 0039d316-1c4b-4281-b951-d872f2087c98
* Move eintr_wrapper.h from base to base/posixbrettw@chromium.org2012-11-1420-22/+22
| | | | | | Review URL: https://codereview.chromium.org/11366229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167739 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove potential for malloc in CrMallocErrorBreak().shess@chromium.org2012-11-141-2/+18
| | | | | | | | | | | | Calling into malloc library from the malloc library error handler is probably a bad idea. BUG=160555 Review URL: https://chromiumcodereview.appspot.com/11363208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167722 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make Linux stack dump signal handler async-signal safe.phajdan.jr@chromium.org2012-11-145-66/+336
| | | | | | | | | | | This also re-enables in-process stack dumping on Linux. BUG=101155 Review URL: https://chromiumcodereview.appspot.com/11362048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167714 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PrefObserver usage, batch 3.joi@chromium.org2012-11-142-0/+7
| | | | | | | | | | | | This also introduces an accessor for the PrefServiceBase* kept by PrefChangeRegistrar. TBR=bauerb@chromium.org,achuith@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11293249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167680 0039d316-1c4b-4281-b951-d872f2087c98
* Make RefCountedData thread-safeakalin@chromium.org2012-11-141-4/+5
| | | | | | | | | | | This is to make it difficult to use a non-thread-safe ref-counted object with multiple threads. BUG=160339 Review URL: https://chromiumcodereview.appspot.com/11359144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167633 0039d316-1c4b-4281-b951-d872f2087c98
* Allow MessagePumpDefault to wait when there is no pending work.scherkus@chromium.org2012-11-142-0/+3
| | | | | | Review URL: https://chromiumcodereview.appspot.com/11377119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167577 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PrefObserver from usages of PrefChangeRegistrar, batch 2.joi@chromium.org2012-11-131-0/+3
| | | | | | | | | | | | Also improves comment on PrefChangeRegistrar::Add. TBR=bauerb@chromium.org,achuith@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11366154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167511 0039d316-1c4b-4281-b951-d872f2087c98
* Move mru_cache to the new containers subdirectory.brettw@chromium.org2012-11-134-6/+6
| | | | | | Review URL: https://codereview.chromium.org/11361193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167456 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a DCHECK() in FieldTrial::SetForced().asvitkine@chromium.org2012-11-132-4/+36
| | | | | | | | | | | | | | | The DCHECK() was added under the assumption that it doesn't make sense to force a trial that only has the default group. However, with VariationsService, which is general-purpose, one could create a server-side trial of this sort, and this works correctly other than the DCHECK(). BUG=160766 TEST=New unit tests in field_trial_unittest.cc. Review URL: https://codereview.chromium.org/11366205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167453 0039d316-1c4b-4281-b951-d872f2087c98
* Android: correctly generates inner class from import clause.bulach@chromium.org2012-11-132-1/+32
| | | | | | | | | | | | | | After r166482, it started deriving the JNI parameters from the "import" clause. However, for "import foo.Outer.Inner", it'd generate "Lfoo/Outer/Inner" rather than "Lfoo/Outer$Inner". BUG= TEST=build/android/jni_generator/jni_generator_tests.py Review URL: https://chromiumcodereview.appspot.com/11293206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167384 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that field trials synced to the renderer process are considered "active".asvitkine@chromium.org2012-11-133-11/+53
| | | | | | | | | | | | | | | | | | | | | http://crrev.com/166168 made trials on which group() hasn't been called not get reported. This resulted in renderer crash reports not being tagged with field trials because group() wasn't called on the renderer side after they are synchronized from the browser process. This change makes CreateTrialsFromString() mark trials as used as well as making trials synchronized to the renderer later via OnSetFieldTrialGroup() notification also get marked as used. Also fixes a couple of lint warnings in chrome_render_process_observer.cc and changes field_trial_unittest.cc to not use a deprecated function. BUG=158801 TEST=New FieldTrialTest.CreateFieldTrialIsActive test. Review URL: https://chromiumcodereview.appspot.com/11376002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167313 0039d316-1c4b-4281-b951-d872f2087c98
* [Win] Don't call GetLongPathName() in CreateTemporaryFileInDir().asanka@chromium.org2012-11-122-7/+60
| | | | | | | | | | | | | | | | GetLongPathName() can fail if the user doesn't have the necessary privileges on an ancestor directory. If this call failed during CreateTemporaryFileInDir(), the temporary file that was created in the previous GetTempFileName() call will leak. None of the callers rely on the path being expanded on return. So get rid of the call. BUG=155612 Review URL: https://chromiumcodereview.appspot.com/11300011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167189 0039d316-1c4b-4281-b951-d872f2087c98
* Need to subtract the speculative memory when calculating available memory on Machongbo.min@intel.com2012-11-121-1/+2
| | | | | | | | | BUG=None Review URL: https://chromiumcodereview.appspot.com/11275252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167186 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Closure-based API to PrefChangeObserver and PrefMember.joi@chromium.org2012-11-123-58/+89
| | | | | | | | | | | | | | | The original was in http://codereview.chromium.org/11368098/ (landed as r166670) but seemed to increase memory usage significantly. This version does away with storing the pref name in callbacks, which should reduce memory usage. TBR=ben@chromium.org,finnur@chromium.org BUG=155525, 160177 Review URL: https://chromiumcodereview.appspot.com/11369153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167179 0039d316-1c4b-4281-b951-d872f2087c98
* Use ';' instead of '|' to separate arguments in Android trace.wangxianzhu@chromium.org2012-11-101-1/+4
| | | | | | | | | | | | According to comments in https://codereview.appspot.com/6822089/, using ';' instead '|' to separate arguments can improve extensibility. BUG= Review URL: https://chromiumcodereview.appspot.com/11366166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167086 0039d316-1c4b-4281-b951-d872f2087c98
* Make it so disabled field trials are not reported as active.asvitkine@chromium.org2012-11-103-22/+51
| | | | | | | | | BUG=160310 TEST=New FieldTrialTest.DisabledTrialNotActive test and updated existing tests. Review URL: https://chromiumcodereview.appspot.com/11359136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167045 0039d316-1c4b-4281-b951-d872f2087c98
* Move stack_container and linked_list to the new containers subdirectory.brettw@chromium.org2012-11-108-26/+41
| | | | | | | | | | This also replaces the StackWString with StackString16 and adds a char traits definition to the string16 header file to make this possible without ifdefs. BUG= Review URL: https://codereview.chromium.org/11360174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167022 0039d316-1c4b-4281-b951-d872f2087c98
* Move global_descriptors to base/posix.brettw@chromium.org2012-11-093-6/+6
| | | | | | | | | | This file represents a posix-only concept. BUG= Review URL: https://codereview.chromium.org/11293210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167008 0039d316-1c4b-4281-b951-d872f2087c98
* Add a SmallMap to base for small map lookups.brettw@chromium.org2012-11-095-0/+1271
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This map has a static array that it will check brute-force before overflowing into a normal map. For cases where simple key-value lookup is needed where there are not expected to be many elements, this will be faster. This adds ManualConstructor which is required for this. This code is from internal util/gtl/small_map.h. I made the following changes: Renamed small_map to SmallMap. Added everything to the base namespace. Added the helper templates at the top to a sub namespace "internal" I renamed small_map_default_init to SmallMapDefaultInit since it's a class and that's how we name clases. However, I didn't rename has_key_equal and select_key_equal since those work with something called key_equal on the base container. I went back and forth on this, I'm happy to change. Renamed the non-STL-like functions to CamelCase. The only case was "using_full_map" -> UsingFullMap Removed unit test for the size of a Small Map (I don't think we care). Added note about preferring hash_map for key equality checking. Redid manual_constructor to use aligned_memory instead of manually doing everything itself. This removed a bunch of preprocessor goop and manual alignment. I also removed the 9-12 argument constructor versions of Init, which seemed excessive. Removed InsertIfNotPresent unit test (we don't have an InsertIfNotPresent map helper function). Added std:: on various things like pairs and make_pair and max. Made SmallMap::size() and count() and erase() return size_t insted of int to keep compat for unsigned-vs-signed for STL. Added "u" after numbers in EXPECT_EQs to avoid signed/unsigned warnings. BUG= Review URL: https://codereview.chromium.org/11366050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167001 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileDescriptorShuffle to base/posix. This file is very posix-specific.brettw@chromium.org2012-11-096-10/+13
| | | | | | | | | TEST=it compiles BUG=none Review URL: https://codereview.chromium.org/10399100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166970 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 166670 - Add Closure-based API to PrefChangeObserver and PrefMember, ↵joi@chromium.org2012-11-093-70/+57
| | | | | | | | | | | | | | | | | | | | | | | | | deprecate PrefObserver-based API. This switches the API with minimal implementation changes; PrefNotifierImpl still uses PrefObserver to accept registrations, and still filters on pref names (which PrefChangeObserver looks up again when it receives callbacks via its PrefObserver implementation). This approach is chosen for now to establish the new API so that usages can be switched, because: a) We need a way for PrefNotifierImpl to dispatch to both PrefChangeObserver and PrefMember, and it's unclear to me whether we want to switch that interface to base::Callback as well (if so, how to unregister?), or whether we want PrefMember to have a PrefChangeObserver instance (probably inefficient?) or something else. b) There are plans to do performance measurements of a few different implementation approaches in how PrefNotifierImpl and PrefChangeObserver interact; that interaction can be changed "under the hood" while the new API stays unchanged, and this lets us start switching users to the new API and removing the now-deprecated PrefObserver-based API. TBR=ben@chromium.org,finnur@chromium.org BUG=155525,160177 Review URL: https://chromiumcodereview.appspot.com/11368098 Speculative revert, to check if memory usage increase from issue 160177 was because of this revision. TBR=joi@chromium.org Review URL: https://codereview.chromium.org/11364174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166888 0039d316-1c4b-4281-b951-d872f2087c98
* On Android, the app package name defines a distribution channelaruslan@chromium.org2012-11-093-0/+13
| | | | | | | | | BUG=159476 Review URL: https://chromiumcodereview.appspot.com/11368146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166844 0039d316-1c4b-4281-b951-d872f2087c98
* Add cpu to base/win/OWNERSbrettw@chromium.org2012-11-091-0/+1
| | | | | | Review URL: https://codereview.chromium.org/11312159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166818 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unused |application_start_time| from FieldTrialList.asvitkine@chromium.org2012-11-082-19/+1
| | | | | | | | | BUG=none TEST=compiles Review URL: https://chromiumcodereview.appspot.com/11361173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166794 0039d316-1c4b-4281-b951-d872f2087c98
* Change PrefStore::ReadResult to a boolean.bauerb@chromium.org2012-11-0814-116/+89
| | | | | | | | | | | The third value in the enum (READ_USE_DEFAULT) isn't used anymore. TBR=phajdan.jr@chromium.org,abodenha@chromium.org,tim@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/11365112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166706 0039d316-1c4b-4281-b951-d872f2087c98
* Add run_isolate.py to all .isolate.maruel@chromium.org2012-11-081-0/+1
| | | | | | | | | | | | | This is in preparation to have run_test_cases.py to be able to reuse common code in run_isolated.py to reduce code duplication. TBR=csharp@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11360143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166705 0039d316-1c4b-4281-b951-d872f2087c98
* Add Closure-based API to PrefChangeObserver and PrefMember, deprecate ↵joi@chromium.org2012-11-083-57/+70
| | | | | | | | | | | | | | | | | | | PrefObserver-based API. This switches the API with minimal implementation changes; PrefNotifierImpl still uses PrefObserver to accept registrations, and still filters on pref names (which PrefChangeObserver looks up again when it receives callbacks via its PrefObserver implementation). This approach is chosen for now to establish the new API so that usages can be switched, because: a) We need a way for PrefNotifierImpl to dispatch to both PrefChangeObserver and PrefMember, and it's unclear to me whether we want to switch that interface to base::Callback as well (if so, how to unregister?), or whether we want PrefMember to have a PrefChangeObserver instance (probably inefficient?) or something else. b) There are plans to do performance measurements of a few different implementation approaches in how PrefNotifierImpl and PrefChangeObserver interact; that interaction can be changed "under the hood" while the new API stays unchanged, and this lets us start switching users to the new API and removing the now-deprecated PrefObserver-based API. TBR=ben@chromium.org,finnur@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11368098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166670 0039d316-1c4b-4281-b951-d872f2087c98
* Moved JsonPrefStore to use SequencedWorkerPool instead of FILE thread. The ↵zelidrag@chromium.org2012-11-085-53/+77
| | | | | | | | | | | pool also ensures that the same file requests are written in order received and that they block on shutdown. BUG=153367 TEST=existing unit/browser tests Review URL: https://codereview.chromium.org/11027070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166603 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable ImportantFileWriterTest.BatchingWritesphajdan.jr@chromium.org2012-11-081-2/+1
| | | | | | | | | | | | | Cannot reproduce crashes locally with >50 000 iterations, and we don't have a stack trace. TBR=asvitkine BUG=109292 Review URL: https://chromiumcodereview.appspot.com/11275205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166595 0039d316-1c4b-4281-b951-d872f2087c98
* Add a histogram enum to determine the cat's flavor and how many bits there aremark@chromium.org2012-11-084-14/+8
| | | | | | | | | in it. BUG=159886 Review URL: https://codereview.chromium.org/11391002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166585 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 166547 - Use tcmalloc's debugallocation for Debug buildsscottmg@google.com2012-11-083-31/+19
| | | | | | | | | | | | | | | | | to catch memory problems early, easily, and cleanly. Because of gyp limitations, this can't be now controlled by a flag. BUG=30715 TEST=none Review URL: https://codereview.chromium.org/11266019 TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/11366141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166566 0039d316-1c4b-4281-b951-d872f2087c98
* Use tcmalloc's debugallocation for Debug buildsphajdan.jr@chromium.org2012-11-073-19/+31
| | | | | | | | | | | | | | to catch memory problems early, easily, and cleanly. Because of gyp limitations, this can't be now controlled by a flag. BUG=30715 TEST=none Review URL: https://codereview.chromium.org/11266019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166547 0039d316-1c4b-4281-b951-d872f2087c98
* Make FieldTrialList::StatesToString() only report active trials.asvitkine@chromium.org2012-11-073-19/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change makes StatesToString() use GetActiveFieldTrialGroups(), making the two function have the same behavior. With this change, group() must be called on trials that are to be synchronized to sub-processes via the initial command line (which was already true for later syncs via the observer child process notification). This also actually fixes a subtle bug that would cause inconsistent behavior when group() wasn't called in the old code. In the previous code, if group() was not called, then if a group other than the default was chosen, it would be reflected in the StatesToString() state, but if the default group was the remaining one and group() wasn't called, its state would not be reflected in the string. With the change, it is now consistent - for any state to be reflected in StatesToString(), group() needs to be called. I've expanded the test to check the default group case that was inconsistent (not working) before. This does mean that any trials that should be visible to the renderer must ensure to call group() in the browser process, but I'm not sure whether there are any such trials that don't do this currently - hoping the reviewers could chime in here. Thanks! BUG=158801 TEST=Expanded unit tests in field_trial_unittest.cc. Review URL: https://chromiumcodereview.appspot.com/11365115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166495 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 19:03:39 +0000