| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/.
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11227026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mark
Review URL: https://codereview.chromium.org/11272008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. HistogramBase supports HasConstructionArguments.
2. Move Histogram::InspectConstructionArguments() to public, so chromeos
does not need to extend Histogram to do arguments checking.
Also grouped OVERRIDE functions in histogram.cc/h together.
TBR=zellidrag@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11231025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11232054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
intialized on the Thread.
This makes one functional change: when COM is initialized in STA mode, the Thread is forced to use a TYPE_UI message loop. Most of the modified consumers here didn't previously do that, but after discussion with cpu and siggi, it seems safest, even though it's more heavyweight.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11048029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Upstream Autofill functionality for Android.
BUG=138235
Review URL: https://chromiumcodereview.appspot.com/11187054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed reland of https://chromiumcodereview.appspot.com/11189043/
TBR=jam@chromium.org,jamesr@chromium.org
BUG=155413
Review URL: https://codereview.chromium.org/11231054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabling 4554 caused a bug to be missed. The comment about
dmg_fp appears to be inaccurate now, so remove that. 4018
appears to be the only warning triggered via base or
base_unittests so un-disable the rest:
4244: 'conversion' conversion from 'type1' to 'type2', possible loss of data
4102: 'label' : unreferenced label -- This warning is no longer emitted post-VS2008.
4554: 'operator' : check operator precedence for possible error; use parentheses to clarify precedence
(Requires http://codereview.chromium.org/11231045/ to be landed)
R=willchan@chromium.org
BUG=157062
Review URL: https://chromiumcodereview.appspot.com/11244002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to the content namespace.
Review URL: https://codereview.chromium.org/11227033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to break dependencies back to Chrome.
This leaves the following in chrome/ for now, which will move later:
- PrefService, to move once sync dependencies and dependencies on
Chrome-specific pref stores are externalized.
- PrefNotifierImpl and PrefObserverMock, to move once
NotificationSource dependency is broken.
- PrefValueStore, to move once PrefModelAssociatior dependency is
externalized.
- ScopedUserPrefUpdate, to move once PrefService moves.
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Just tidying, no functional change.
R=jar@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11236030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See also discussion: http://codereview.chromium.org/10532176/
R=willchan@chromium.org, ananta@chromium.org
BUG=157062
Review URL: https://chromiumcodereview.appspot.com/11231045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Same OWNERS as chrome/browser/prefs, plus joi@ for the refactoring
work needed to break dependencies after the initial move.
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11145019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Checked that build succeeds, launched try jobs.
BUG=136707
Review URL: https://chromiumcodereview.appspot.com/11225004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
if a key name or value larger than MAX_PATH is found.
BUG=156057
Review URL: https://codereview.chromium.org/11141029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/10889028/ since that won't be committed in the end.
1) Notify the shell of the creation of a shortcut (as opposed to only notifying SHCNE_ASSOCCHANGED when updating shortcuts).
1.5) Base "creation" detection off of prior presence of the shortcut rather than on the shortcut operation (as the shortcut could have existed before even if operation is SHORTCUT_CREATE_ALWAYS).
2) Fix Active Setup to use setup_exe.BaseName() as opposed to installer::kSetupExe as requested by grt@ on afore-mentioned CL.
3) Fix Active Setup to add appropriate product and system-level switches to the command to be called by Windows.
4) Hardcode a version for Active Setup rather than forcing a new version every Chrome update (which would end up running Active Setup a lot for, most of the time, no reason).
5) Introduce the INVALID_STATE_FOR_OPTION return code for setup to avoid relying on DCHECKs while making sure setup exits with an error code if unexpected state is present (a new switch for each of these state failures that are never supposed to happen was deemed overkill by me and grt@, but a single one for them all made sense).
R=robertshield@chromium.org
BUG=148539
Review URL: https://chromiumcodereview.appspot.com/11187038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to get around the fact that Timer::Start, which has a friendlier
base::Closure signature, is hidden by BaseTimerMethodPointer::Start.
BUG=148832
Review URL: https://chromiumcodereview.appspot.com/11144010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes a lot of the duplication of the exact details
about how to run isolate.py exactly.. This will permit
inserting arbitrary command line arguments eventually, for
--subdir support.
TBR=csharp@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11236005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=139612
Review URL: https://chromiumcodereview.appspot.com/11192077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11187061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that OWNERS supports per-file owners, we can limit the scope of the
top-level wildcard to just DEPS, and make darin and ben owners for
everything else and remove the broad use of "set noparent".
R=ben@chromium.org, darin@chromium.org
BUG=88315
Review URL: https://codereview.chromium.org/11191038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 184fac5add06d5f4670fa6be4a4d3b39232d51bb.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=155413
Review URL: https://codereview.chromium.org/11189043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Related to this, parse a single dash on the command line as argument, instead of a switch with no value and name
BUG=111316
TEST=out/Debug/content_shell --dump-render-tree path/to/test.html works
Review URL: https://chromiumcodereview.appspot.com/11184050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Discovered while writing a fix to add PKEY_AppUserModel_PreventPinning for http://crbug.com/142980 that adding new properties was kind of redundant, so I removed one layer of unecessary calls; while I don't need to commit this change anymore (as it doesn't work...), here is the code cleanup part of it.
Fix has_dual_mode() enum typo.
R=robertshield@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11202002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a lifetime problem with the lazy instance InotifyReader and the singleton
PluginService. The PluginService has an indirect dependency on InotifyReader
on Linux. By making InotifyReader a leaky lazy instance, we can avoid releasing
the inotify file descriptors while there are still registered watchers.
BUG=156110
TEST=CQ, manual test
Review URL: https://chromiumcodereview.appspot.com/11183043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove non-existant property 18 "DualModeUK" from dual-mode shortcuts (the new REPLACE_EXISTING mechanism applied on update will clean this from existing shortcuts :)).
R=grt@chromium.org
BUG=144420
TEST=No longer adding non-existant property 18 "DualModeUK" to shortcuts.
Review URL: https://chromiumcodereview.appspot.com/11195009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScopedMachPort class.
BUG=119379
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11188003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than requiring early registration for all method id, we can initialize
them lazily as required.
This solves the problem of building against SDK X but running against X - 1.
Also adds a microbenchmark to ensure there are no considerable regressions.
Results are a bit variable, but it hovers over:
[ERROR:jni_android_unittest.cc(125)] JNI LazyMethodIDCall (us) 1983
[ERROR:jni_android_unittest.cc(127)] JNI MethodIDCall (us) 1862
BUG=152987
TEST=JNIAndroidMicrobenchmark.MethodId
TBR=akalin
Review URL: https://chromiumcodereview.appspot.com/11038015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Several unit tests cause the test app to crash when run with coverage=1.
BUG=156058
Review URL: https://chromiumcodereview.appspot.com/11155006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=154293
Review URL: https://chromiumcodereview.appspot.com/11027024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
OperatingSystemArchitecture().
Review URL: https://chromiumcodereview.appspot.com/11140015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary for --ui-enable-threaded-compositing. In principle, we will not be blocking the browser UI any more than we would without --ui-enable-threaded-compositing.
BUG=155048
TEST=by hand
Review URL: https://chromiumcodereview.appspot.com/11085054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RValue&.
For move semantics, we need to create a private "RValue" type that is used to
create move constructors and move operators. Previously, we emulated Boost's
idea of making the RValue type a subclass of the move-only type that doesn't add
any new member fields. We then just reinterpret_cast "this" into a RValue&
depending on the fact that RValue is just a type pun for the move-only type.
This ends up being undefined behavior though (C++98 5.2.10.7).
This change makes use a concrete RValue class that contains a pointer to the
move-only type. With -O2 on clang version 3.2 (trunk 163674), this yields
identical assembly code to the previous implementation. With -O0, we generate
2 more instructions to allocate and initialize the temporary RValue struct's
object field when calling Pass().
This should be acceptable. The snowman says so ☃.
BUG=155436
Review URL: https://chromiumcodereview.appspot.com/11078014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This method is no longer being used, so we're removing it from the FieldTrialList API. We also correct all locations that used to call it, having them assume One Time Randomization is always available.
BUG=None
TEST=No visible changes.
Review URL: https://chromiumcodereview.appspot.com/10448078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123758,154240
Review URL: https://chromiumcodereview.appspot.com/11117010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This went in this CL (https://chromiumcodereview.appspot.com/10979071/).
TBR=huangs@chromium.org
Review URL: https://codereview.chromium.org/11142011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To give up ownership of this object to the autorelease pool:
scoped_nsobject<MyClass> obj;
you could write:
[[obj retain] autorelease];
obj.reset();
or:
[obj.release() autorelease];
This CL makes it more explicit:
obj.autorelease();
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11066079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This documentation clarifies the expected behaviour when a watched PROCESS finishes before observation using ObjectWatcher begins. A unit-test confirms that the behaviour is as expected.
BUG=None
TEST=base_unittests --gtest_filter=ObjectWatcherTest.*
Review URL: https://chromiumcodereview.appspot.com/10979071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds CHECKs to the browser if it attempts to send a
message to the zygote that exceeds the maximum message size
(which causes an EMSGSIZE error in the zygote) or that
contains too many file descriptors.
I'm hoping that this will help make the source of the
problem more apparent when we hit the message size limit,
which we appear to have done multiple times (it was
originally 1 KB and is now 2 KB).
BUG=154409
Review URL: https://chromiumcodereview.appspot.com/11108019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=base compiles clean with vs2012
BUG=143646
Review URL: https://codereview.chromium.org/11117007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses the same method as is used on Mac to enable coverage. Some sources
need to be removed in coverage mode due to a toolchain bug.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11111014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11118004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The EnormousTest annotation is used for Android Instrumentation tests that
access external web sites, are long running, or in general doesn't fall under
the small, medium and large test categories.
Enormous tests should never run on tree closing bots.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11066109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=willchan@chromium.org
R=ajwong@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11091056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutoThreads work much like base::Threads with the difference that the AutoThread will run until the last reference to its TaskRunner has been dropped. When the owner deletes the AutoThread they will be blocked until the thread is ready to be joined.
AutoThread simplifies teardown of multi-threaded code by ensuring that threads persist until no code remains that may need to use them.
BUG=145856
Review URL: https://chromiumcodereview.appspot.com/10919081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ben,brettw,oshima,rdsmith
Review URL: https://chromiumcodereview.appspot.com/11087021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
invoke a caller specified handler function
with a string parameter.
Currently the only consumer of this functionality is the download notification display code which when invoked displays
the downloaded file in the shell.
BUG=151141
R=cpu
Review URL: https://codereview.chromium.org/11096013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specific implementations.
This change moves the IgnoreNavigationResourceThrottle to a separate component
as it will be shared between chrome/android and android_webview.
This change also adds the chrome/ and android_webview/ specializations of the
throttle (or more precisely the callback that is used to find the right method
on the right delegate).
BUG=130006
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10946008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original change descriptions:
- make JNIAndroidTest work with --gtest_repeat
- add java exception info to breakpad
- add JniArray test
BUG=136707
TEST=Built and run jni_android_unittests.cc
Review URL: https://chromiumcodereview.appspot.com/11090022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160895 0039d316-1c4b-4281-b951-d872f2087c98
|