summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Use ftruncate() instead of fwrite() to extend files.pinkerton@chromium.org2009-08-261-20/+4
| | | | | | | | BUG=20249 TEST=Browser still works Review URL: http://codereview.chromium.org/174482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24451 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Issue 19689: Command line URL parameter does not support Chinese.suzhe@chromium.org2009-08-261-9/+9
| | | | | | | | | | | | | | | | This CL fixes issue 19689 by handling command line values with native encoding on non-Windows systems. For Linux, native encoding specified in current locale is used. For Mac, UTF-8 will always be used. This CL only changes command line values and program name to use native encoding, command line switches still use ASCII. BUG=19689: Command line URL parameter does not support Chinese TEST=Execute chrome with "http://www.google.com/search?q=中文" to see if this url can be opened successfully. Review URL: http://codereview.chromium.org/174139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24423 0039d316-1c4b-4281-b951-d872f2087c98
* Convert internal time format to Windows 1601 epoch on Linux & Mac.brettw@chromium.org2009-08-264-56/+93
| | | | | | | | | | | Although we represent time internally starting from 1601, there are still things like time explosion that will not work before the year 1900. This limitation is the same as it was previously. BUG=14734 Review URL: http://codereview.chromium.org/173296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24417 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cases that initialized StringTokenizer with a temporary.mattm@chromium.org2009-08-261-2/+13
| | | | | | | | | | | Fix examples in StringTokenizer header that recommended doing that. BUG=none TEST=on linux, open options, click proxy configuration button a bunch. It should not fail intermittently. Review URL: http://codereview.chromium.org/174490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24398 0039d316-1c4b-4281-b951-d872f2087c98
* Remove uses of deprecated version of FileUtil::ResolveShortcut.evan@chromium.org2009-08-253-17/+8
| | | | | | | | | | BUG=None TEST=run base_unittests.exe Review URL: http://codereview.chromium.org/173181 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24208 0039d316-1c4b-4281-b951-d872f2087c98
* linux: call g_thread_init() at relevant startup pointsevan@chromium.org2009-08-252-28/+30
| | | | | | | | | | | | | | | | | | According to glib docs, we need to do this if it's at all possible for us to hit glib on multiple threads. This may be happening when we grab plugin metadata from the file thread. Rather than explicitly depending on gthread all over the place, just put it in with the GTK dep (since anywhere we're using GTK we ought to init gthread). (Note that this is *not* initializing the GDK locking system.) BUG=18957 Review URL: http://codereview.chromium.org/174264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24207 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: call g_thread_init() at relevant startup points"evan@chromium.org2009-08-252-30/+27
| | | | | | This reverts commit r24203, Mac breakage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24204 0039d316-1c4b-4281-b951-d872f2087c98
* linux: call g_thread_init() at relevant startup pointsevan@chromium.org2009-08-252-27/+30
| | | | | | | | | | | | | | | | | | According to glib docs, we need to do this if it's at all possible for us to hit glib on multiple threads. This may be happening when we grab plugin metadata from the file thread. Rather than explicitly depending on gthread all over the place, just put it in with the GTK dep (since anywhere we're using GTK we ought to init gthread). (Note that this is *not* initializing the GDK locking system.) BUG=18957 Review URL: http://codereview.chromium.org/174264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24203 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: call g_thread_init() at relevant startup points"tony@chromium.org2009-08-241-1/+0
| | | | | | | | | | | This reverts commit r24148 because the FDRemapping unittest is failing. TBR=evanm Review URL: http://codereview.chromium.org/173309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24168 0039d316-1c4b-4281-b951-d872f2087c98
* linux: call g_thread_init() at relevant startup pointsevan@chromium.org2009-08-241-0/+1
| | | | | | | | | | | | | | | | | | According to glib docs, we need to do this if it's at all possible for us to hit glib on multiple threads. This may be happening when we grab plugin metadata from the file thread. Rather than explicitly depending on gthread all over the place, just put it in with the GTK dep (since anywhere we're using GTK we ought to init gthread). (Note that this is *not* initializing the GDK locking system.) BUG=18957 Review URL: http://codereview.chromium.org/174264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24148 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we reused a va_list across multiple calls.deanm@chromium.org2009-08-241-9/+9
| | | | | | | | | | | The problem is that va_arg modifies the va_list so that the next call to va_arg returns the next argument. It looks like this code had attempted to not reuse the list by making a copy, but it passed the original instead of the copy. Review URL: http://codereview.chromium.org/174342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24134 0039d316-1c4b-4281-b951-d872f2087c98
* Fix StackTrace on Windows.maruel@chromium.org2009-08-242-73/+29
| | | | | | | | | | The previous implementation was overly verbose. The new one is now functional and the unit test now works. TEST=unit_test BUG=none Review URL: http://codereview.chromium.org/174250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24097 0039d316-1c4b-4281-b951-d872f2087c98
* Use U_ICU_VERSION_SHORT instead of hard-coding the icu data dll and module name.jshin@chromium.org2009-08-221-3/+5
| | | | | | | | | | | This is a companion to http://codereview.chromium.org/174265 BUG=8198 TEST=All the targets relying on ICU are built and run without a problem. Review URL: http://codereview.chromium.org/173233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24072 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24043, "linux: call g_thread_init() at relevant startup points"evan@chromium.org2009-08-211-1/+0
| | | | | | Build failures. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24044 0039d316-1c4b-4281-b951-d872f2087c98
* linux: call g_thread_init() at relevant startup pointsevan@chromium.org2009-08-211-0/+1
| | | | | | | | | | | | | | According to glib docs, we need to do this if it's at all possible for us to hit glib on multiple threads. This may be happening when we grab plugin metadata from the file thread. (Note that this is *not* initializing the GDK locking system.) BUG=18957 Review URL: http://codereview.chromium.org/174264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24043 0039d316-1c4b-4281-b951-d872f2087c98
* Move gtk_settings_get_default() call to the UI thread.estade@chromium.org2009-08-212-6/+33
| | | | | | | | BUG=19971 Review URL: http://codereview.chromium.org/173216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24034 0039d316-1c4b-4281-b951-d872f2087c98
* Some tweaks to the OS X Sandbox:jeremy@chromium.org2009-08-211-12/+3
| | | | | | | | | | | | | | * Fix 10.6 bug where garbled text was displayed due to insuccesful font loading. * Tightened down the Sandbox a bit, instead of allowing access to /System/Library limit it to certain subdirectories. * Remove unused warmup code now that we allow sysctl-read. BUG=11269 BUG=b/1853366 TEST=On 10.6, copy Arial.ttf from /System/Library/Fonts to ~/Library/Fonts , Launch Chrome. Text on NTP should be displayed normally and not garbled. Review URL: http://codereview.chromium.org/174254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24030 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r23911, which switched from fork to vfork().deanm@chromium.org2009-08-211-28/+22
| | | | | | | | | | | | | Everything still worked correctly, but our performance bots didn't measure any improvements. Perhaps I just ended up measuring the dtrace overhead of fork vs vfork. BUG=19863 Review URL: http://codereview.chromium.org/174229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23969 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using vfork() instead of fork() when we can.deanm@chromium.org2009-08-201-22/+28
| | | | | | | | | | | | | | | | This means we can avoid creating new page tables, but that we share our memory mappings / stack with the parent. This is a bit more fragile, but should be workable. This saves us some work since we are just going to exec(). This also removes some sandbox unsetting code, since we shouldn't be spawning processing under the sandbox anyway. BUG=19863 Review URL: http://codereview.chromium.org/173141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23911 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make the "change proxy settings" button able to start several proxy ↵mdm@chromium.org2009-08-202-4/+35
| | | | | | | | | | | | config utilities. Currently it still only ever starts gnome-network-properties but it is now easy to update. BUG=none TEST=none Review URL: http://codereview.chromium.org/174106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23910 0039d316-1c4b-4281-b951-d872f2087c98
* Print more info in IsStringASCII assertions.phajdan.jr@chromium.org2009-08-201-4/+4
| | | | | | | | | | | This will help debugging when you have only the logs. TEST=none BUG=none Review URL: http://codereview.chromium.org/174110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23900 0039d316-1c4b-4281-b951-d872f2087c98
* Don't compile with TraceLog support on by default.deanm@chromium.org2009-08-201-0/+7
| | | | | | | | | | | This is just some experimental performance code. Previously it was creating a singleton object which created a ProcessMetrics object. This caused a bunch of possibly expensive calls to query system information to happen on startup. Review URL: http://codereview.chromium.org/174118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23819 0039d316-1c4b-4281-b951-d872f2087c98
* Omit DLOGs and DCHECKs from release-mode Google Chrome-branded builds onmark@chromium.org2009-08-201-5/+15
| | | | | | | | | | | | | non-Windows. They were previously omitted on Windows official builds only. BUG=16512 TEST=DCHECK logging unavailable in official builds; Mac .app shrinks by about 740kB; Mac .dmg shrinks by about 315kB; Linux binary and package shrink by similar amounts Review URL: http://codereview.chromium.org/171093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23791 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that SyncWaiter (base/waitable_event_posix.cc) condition variablesmark@chromium.org2009-08-201-37/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cannot be destroyed (pthread_cond_destroy) during a broadcast (pthread_cond_broadcast). SyncWaiter::Fire now holds the lock until the broadcast is complete. Given the lock ordering, this guarantees that the condition variable cannot be destroyed until it is safe to do so. Holding the lock through the broadcast is harmless, as pthread_cond_wait and pthread_cond_timedwait will simply block (if needed) until able to take the lock prior to returning. Ownership of the lock and condition variable is moved to SyncWaiter for better self-documentation. The only true functional change here, however, is the duration that SyncWaiter::Fire holds the lock. This bug caused hangs in optimized official release builds on the Mac when DCHECKS were optimized away. The DCHECK optimization was initially covered in bug 16512 r20497 and was backed out due to bug 16871 r20889. The optimization changed the timings just enough that we wound up hitting this case. On the Mac, pthread_cond_broadcast wound up blocking indefinitely (with a trashed stack) when its condition variable was destroyed beneath it; this caused other locks held by its thread to never be released, resulting in other threads becoming deadlocked and made the bug particularly difficult to diagnose. BUG=19710 TEST=Application works with no unexplained deadlocks, hanging, or crashing base_unittests (specifically WaitableEvent*) ipc_tests (especially IPCSyncChannelTest.ChattyServer, which would hang previously on the Mac with DCHECKs optimized away) Review URL: http://codereview.chromium.org/173059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23790 0039d316-1c4b-4281-b951-d872f2087c98
* Port more browser focus tests to linux.estade@chromium.org2009-08-191-26/+26
| | | | | | | | | | | | | | | | | | | Added a new test to make sure clicking sets focus, since I changed a lot of tests to programatically set focus instead of using clicking. Also set the actual time on our synthetic key events. I'm still not sure this is necessary but would like to avoid subtle bugs. Also get rid of the NineBox constructor that takes a theme provider and convert its callers to use cairo directly or the other NineBox constructor. This change was necessary because theme providers could go stale and then the NineBox would cause seg faults. Also, it was only being used for single images... and UniBox just sounds wrong. Also fix extension shelf to paint its image with the correct x/y (noticeable only with certain themes). Remove the notification observer stuff from the extension shelf, as I don't think there is any action to be taken when the theme changes. BUG=19076 BUG=19659 TEST=all the ported interactive ui tests (as well as all the already-working tests) pass. TEST=(Linux) things still render correctly (frame image, drop shadows, find box, extension shelf) Review URL: http://codereview.chromium.org/173030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23732 0039d316-1c4b-4281-b951-d872f2087c98
* Move IDMap back to base/ where it is needed.phajdan.jr@chromium.org2009-08-193-0/+270
| | | | | | | | | TEST=Covered by base_unittests. BUG=none Review URL: http://codereview.chromium.org/173026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23709 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23645.jhawkins@chromium.org2009-08-182-11/+1
| | | | | | | Crashing the reliability bot. Review URL: http://codereview.chromium.org/174029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23674 0039d316-1c4b-4281-b951-d872f2087c98
* Make NativeControl inherit from base::WindowImpl instead of CWindowImpl to ↵jhawkins@chromium.org2009-08-182-1/+11
| | | | | | | | | | reduce a dependency on ATL. BUG=5027 TEST=none Review URL: http://codereview.chromium.org/169015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23645 0039d316-1c4b-4281-b951-d872f2087c98
* Renames the function CreateTemporaryFilename to CreateTemporaryFile and ↵erikkay@chromium.org2009-08-185-37/+24
| | | | | | | | | | | | | | track down all callers, also removes the deprecated function that uses std::wstring. BUG=3078 (http://crbug.com/3078) TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests. Review URL: http://codereview.chromium.org/164537 Patch from Thiago Farina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23631 0039d316-1c4b-4281-b951-d872f2087c98
* Use 'icu::' namespace explicitly throughout Chrome tree instead of relying ↵jshin@chromium.org2009-08-184-27/+27
| | | | | | | | | | | | | | | | | | | on 'using namespace icu'. This is Chrome's counterpart to the ICU header change that disables 'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece. The webkit change (which is minor) will be dealt with in the webkit bugzilla. This can go in before the ICU change/upgrade without affecting anything. BUG=8198 TEST=All the targets are built without an error on all platforms. Review URL: http://codereview.chromium.org/171012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23613 0039d316-1c4b-4281-b951-d872f2087c98
* Add the UI thread to the list of ChromeThreads.paul@chromium.org2009-08-181-0/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/171088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23605 0039d316-1c4b-4281-b951-d872f2087c98
* Add whitespace so parser doesn't get confused.eroman@chromium.org2009-08-171-3/+3
| | | | | | Review URL: http://codereview.chromium.org/172056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23560 0039d316-1c4b-4281-b951-d872f2087c98
* Add "bool FilePath::ReferencesParent()" which adds a clean & simple way forcevans@chromium.org2009-08-153-1/+50
| | | | | | | | | | | | checking for ".." in a FilePath. Needed to make an upcoming security fix clean. BUG=NONE TEST=FilePathTest.ReferencesParent Review URL: http://codereview.chromium.org/172012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23528 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Reverting 23406" as it didn't break any tests.jhawkins@chromium.org2009-08-142-28/+24
| | | | | | | | | | | | | | Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to reduce a dependency on ATL. BUG=5023 TEST=Uninstall flash. Visit hulu.com and install the flash plugin. Original review: http://codereview.chromium.org/165469 TBR=levin Review URL: http://codereview.chromium.org/165543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23454 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMR for PrependInteger to exceptions list for base_unittests.exe.ericroman@google.com2009-08-141-0/+14
| | | | | | | | | This purify filter is already in the unit_tests.exe_UMR_flakey.txt file, so this is just bringing that hack to base. BUG=http://crbug.com/18795 Review URL: http://codereview.chromium.org/165540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23441 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23406.levin@chromium.org2009-08-142-24/+28
| | | | | | | | | | | | It seems that Tab2OutOfTabStrip is failing consistently after this change. BUG=None TEST=None TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/164543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23411 0039d316-1c4b-4281-b951-d872f2087c98
* Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to ↵jhawkins@chromium.org2009-08-142-28/+24
| | | | | | | | | | reduce a dependency on ATL. BUG=5023 TEST=Uninstall flash. Visit hulu.com and install the flash plugin. Review URL: http://codereview.chromium.org/165469 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23406 0039d316-1c4b-4281-b951-d872f2087c98
* Simple cleanup.maruel@chromium.org2009-08-132-8/+12
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/164424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23327 0039d316-1c4b-4281-b951-d872f2087c98
* Disable RTTI and C++ exceptions in the Mac build. Disable RTTI in the Linuxmark@chromium.org2009-08-132-84/+55
| | | | | | | | | | | | build, where C++ exceptions are already disabled. BUG=19094 12248 TEST=Mac release-mode Google Chrome.app should shrink by about 6MB. Mac disk image should shrink by about 1.5MB. Linux binary and package should shrink too. Review URL: http://codereview.chromium.org/165330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23304 0039d316-1c4b-4281-b951-d872f2087c98
* Reliability test porting: stringy stuff.estade@chromium.org2009-08-132-0/+10
| | | | | | | | | No functional change. This gets things compiling on linux, but it still needs some work before it can be run on linux. BUG=19085 Review URL: http://codereview.chromium.org/164352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23272 0039d316-1c4b-4281-b951-d872f2087c98
* Move IDMap from base/ to common/phajdan.jr@chromium.org2009-08-122-105/+0
| | | | | | | | | | | Nothing in base/ uses it, and I'm going to make some non-trivial changes to it. TEST=none http://crbug.com/19202 Review URL: http://codereview.chromium.org/164428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23243 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-122-0/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PR_ImplodeTime for Linux x64.wtc@chromium.org2009-08-122-6/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following error when building for x64 targets: base/third_party/nspr/prtime.cc: In function 'PRTime PR_ImplodeTime(const PRExplodedTime*)': base/third_party/nspr/prtime.cc:173: error: integer overflow in expression base/third_party/nspr/prtime.cc:176: error: integer overflow in expression PRTime is long long (8 bytes) on ia32, and long (8 bytes) on x64. On ia32, LONG_MAX (4 bytes) converted to microseconds fits in the PRTime type, but on x64 LONG_MAX is 8 bytes and so overflows the PRTime type on conversion. Avoid these issues by only returning INT_MAX. On ia32 this is the correct value, and does not change behaviour. On x64 the call to timegm() will always succeed due to the increased range of time_t, so the error condition of -1 should never be reached. Fix a bug in the conditional expression for 1 second before epoch. Patch by Joel Stanley Original review URL: http://codereview.chromium.org/160511 R=dean,wtc BUG=18231 TEST=new unit test Review URL: http://codereview.chromium.org/164366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23186 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that CreatorCodeForCFBundleRef returns the "unknown" creator code frommark@chromium.org2009-08-121-1/+1
| | | | | | | | | initialized data even if the system is totally unable to service the request. BUG=19000 Review URL: http://codereview.chromium.org/164388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23185 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for constrained windows on os x, based on Avi's ↵thakis@chromium.org2009-08-111-0/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GTMWindowSheetController. Add carpet bombing dialog as first per-tab sheet. Depends http://codereview.appspot.com/105064 . The main issue with this patch is that GTMWindowSheetController doesn't provide an api to move sheets between windows, so this CL disables tab dragging for tabs with sheets, and fullscreen mode for windows with sheets. We can fix this later. Other stuff that should be done at some point, but not now: * Open/Save panels should be per-tab * Need an ui test that goes to page, then page with sheet, then hit back, forward, reload. * Bookmark sheets should not be sheets but in a separate window BUG=14666 TEST=Go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html , a per-window sheet should appear. Things to test with this dialog: * Hitting cmd-q while a sheet is open in any tab should not quit but instead focus the sheet. * Hitting cmd-w while a sheet is open in any tab should not close the window but instead focus the sheet. * Dragging a tab with a sheet should move the window (and keep the tab visible), not detach the tab. * Going fullscreen should be disabled for windows with open tabs. * When a per-tab sheet is open in a non-active tab, it shouldn't steal the focus, i.e. going to the page above, then hitting cmd-t, and then hitting cmd-l should work. * Closing a non-frontmost tab with a per-tab sheet shouldn't crash. * Going to the url above and quickly opening a new tab, so that the sheet opens while its tab is not front-most should work (sheet should display only when you switch back to the tab with the sheet). * Go to google.com, then to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html , hit "backward" with open sheet, hit forward, focus location bar, hit enter. This shouldn't crash. * Hitting escape should dismiss the sheet * Hitting enter should confirm the sheet. Review URL: http://codereview.chromium.org/159780 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23091 0039d316-1c4b-4281-b951-d872f2087c98
* Add checks to DEBUG mode that no instance of URLRequest or URLFetcher ↵ericroman@google.com2009-08-115-0/+598
| | | | | | | | | | | | | | | | | | | | survives the destruction of the IO thread. This checking is done by introducing a new helper class to base called LeakTracker. Classes that you want to check for leaks just need to extend LeakTracker. The reason I am picking on URLFetcher / URLRequest, is I believe we have a bug that is making an instance of URLFetcher to outlive the IO thread. This causes various sorts of badness. For example: If URLFetcher survives the IO thread, then URLRequestContext remains referenced and therefore also survives IO thread. In turn HostResolverImpl survives the IO thread, so any outstanding resolve requests are NOT cancelled before the IO thread is decomissioned. So now, when the worker thread doing the DNS resolve finally finishes (assuming it finishes before the rogue URLRequest is destroyed), it post the result to a defunct message loop. KAB00m! (http://crbug.com/15513) Moreover, I believe we hit this same problem sporadically in AutomationProxyTest.AutocompleteGetSetText -- the test is flaky on the buildbots, and I've seen DCHECKs which suggest it is related to this issue. BUG=http://crbug.com/18372 Review URL: http://codereview.chromium.org/160447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23084 0039d316-1c4b-4281-b951-d872f2087c98
* Use real creator code for Keychain items. Instead of hard-coding 'rimZ', usemark@chromium.org2009-08-112-19/+46
| | | | | | | | | | | the correct creator code for the application. This is 'rimZ' for branded Google Chrome, and 'Cr24' for Chromium. BUG=19000 TEST=No functional change in Google Chrome-branded builds Review URL: http://codereview.chromium.org/164332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23074 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::WindowImpl instead of CWindowImpl to reduce dependencies on ATL.jhawkins@chromium.org2009-08-082-3/+13
| | | | | | | | BUG=5022 TEST=test_shell_tests Review URL: http://codereview.chromium.org/165188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22864 0039d316-1c4b-4281-b951-d872f2087c98
* Add short circuit case for self assignment, and add virtual destructorjar@chromium.org2009-08-072-3/+8
| | | | | | | | | | | | | | | | | | | Pickle is a base class of Message, which has a virtual destructor, so it is better to have Pickle have a virtual destructor as well. Add more defensive code in the case of self assignment. **IF** self assignment was used, and the target was read-only, then the existing code would have a memory fault. I don't think this is currently possible in use cases, but the defensize code is much better. (per suggestion from CPU on last CL). BUG=17027 BUG=17088 r=cpu Review URL: http://codereview.chromium.org/159800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22826 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out window creation into base::WindowImpl. This class will be used ↵jhawkins@chromium.org2009-08-073-0/+324
| | | | | | | | | | in place of CWindowImpl to reduce our dependency on ATL. BUG=none TEST=none Review URL: http://codereview.chromium.org/165022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22787 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 06:02:32 +0000