summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Convert the remaining callers of LaunchApp to LaunchProcess.evan@chromium.org2011-07-181-22/+0
| | | | | | | | | | And delete temporary shims. BUG=88990 Review URL: http://codereview.chromium.org/7386010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92897 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc: make warning-disable flags match upstreamevan@chromium.org2011-07-181-2/+4
| | | | | | | | | | Upstream turns off some warnings. We should too. BUG=89109 Review URL: http://codereview.chromium.org/7396027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92876 0039d316-1c4b-4281-b951-d872f2087c98
* Do a LBYL when getting an X display from GTK.backer@chromium.org2011-07-181-1/+4
| | | | | | | | | | | With a recent CL (r92770), this code got executed in the GPU process, where it fails due to dereferencing a NULL pointer (I'm pretty sure that we're not initializing GTK in that process). This small change returns NULL instead of dereferencing a NULL. BUG=crashes GPU process on TOUCH_UI builds TEST=do some 3D CSS on a TOUCH_UI build Review URL: http://codereview.chromium.org/7398020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92869 0039d316-1c4b-4281-b951-d872f2087c98
* base: Put md5.* into base namespace.tfarina@chromium.org2011-07-182-9/+25
| | | | | | | | | | | BUG=89274 TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7395021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92861 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "clone" option to base/process_util.h:LaunchProcess(). Useful inside ↵bradchen@google.com2011-07-153-9/+32
| | | | | | | | | | | | Linux sandbox. BUG=nativeclient:480 TEST=base/process_util_unittest.cc Review URL: http://codereview.chromium.org/7401002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92771 0039d316-1c4b-4281-b951-d872f2087c98
* use MessageLoop::GetDisplay to get X's Display to make message_pump_x less ↵oshima@google.com2011-07-151-10/+8
| | | | | | | | | | | | | | | GTK/GDK dependent. Add log message to CHECK. I've seen visiblity notify passing through there. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92764 Review URL: http://codereview.chromium.org/7390001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92770 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "use MessageLoop::GetDisplay to get X's Display ..."oshima@google.com2011-07-151-8/+10
| | | | | | | | | | | This reverts commit 4eeea551f778f9c3062e98b8d4f75283a69db60c. BUG= TEST= Review URL: http://codereview.chromium.org/7399012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92766 0039d316-1c4b-4281-b951-d872f2087c98
* use MessageLoop::GetDisplay to get X's Display to make message_pump_x less ↵oshima@google.com2011-07-151-10/+8
| | | | | | | | | | | | | GTK/GDK dependent. Add log message to CHECK. I've seen visiblity notify passing through there. BUG=none TEST=none Review URL: http://codereview.chromium.org/7390001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92764 0039d316-1c4b-4281-b951-d872f2087c98
* Change base::LaunchProcess API slightlyevan@chromium.org2011-07-155-36/+36
| | | | | | | | | | | Rather than passing the out param process handle via the options, take it as a function argument. This simplifies many callers. BUG=88990 Review URL: http://codereview.chromium.org/7377012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92701 0039d316-1c4b-4281-b951-d872f2087c98
* Misc fixes to tracked objectsjoth@chromium.org2011-07-153-10/+9
| | | | | | | | | | | | | PendingTask::post_births could sometimes be left unitialized No way for user to know if Tracked::GetBirthPlace will hit tracked_births_ NULL pointer exception. nit: MissingBirthplace has inconsistent capitalization BUG=None TEST=base_unittests Review URL: http://codereview.chromium.org/7375006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92663 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add namespace base to MD5 unittests.tfarina@chromium.org2011-07-153-34/+24
| | | | | | | | | | | BUG=89274 TEST=base_unittests --gtest_filter=MD5Test.* R=evan@chromium.org Review URL: http://codereview.chromium.org/7363013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92649 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-141-2/+3
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7351003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92598 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CommandLine::GetArgs(), update callers.msw@chromium.org2011-07-133-7/+6
| | | | | | | | | BUG=73195 TEST=none Review URL: http://codereview.chromium.org/7352006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92448 0039d316-1c4b-4281-b951-d872f2087c98
* Nix CommandLine::GetSwitchCount.msw@chromium.org2011-07-132-8/+0
| | | | | | | | | BUG=73195 TEST=none Review URL: http://codereview.chromium.org/7342024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92423 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to disable gtk event pumping in MessagePumpXoshima@google.com2011-07-132-7/+21
| | | | | | | | | | | This is intermediate step to remove gtk from chromeos/touch. BUG=none TEST=none Review URL: http://codereview.chromium.org/7357004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92414 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc: disable the warning about ignoring return valuesevan@chromium.org2011-07-131-0/+5
| | | | | | | | | | | If we ever do fix the code, we can reenable the warning. But right now we just ignore the warning so there's no reason to spam it. BUG=89109 Review URL: http://codereview.chromium.org/7352005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92410 0039d316-1c4b-4281-b951-d872f2087c98
* Add COMPONENT_BUILD global define. darin@chromium.org2011-07-135-19/+42
| | | | | | | | | | | | | | | | | | | | | This avoids the need to define FOO_DLL macros for each project that we wish to optionally build as a DLL (when component=="shared_library"). This in turn means that we do not need direct_dependent_settings to define FOO_DLL, and that means that we don't need to update projects to convert transitive dependencies into explicit dependencies. This makes the component build more consistent with the static build. An alternative would be to use all_dependent_settings, but I feel that the global approach is simpler as it creates less repetition in each target definition for components. A side-effect of this change is that I needed to make base_nacl_win64 be a shared_library in the component build. R=rvargas,bradnelson,evan Review URL: http://codereview.chromium.org/7344022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92409 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-133-43/+16
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7346017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92393 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Don't delete the previous command line when callingrvargas@google.com2011-07-132-1/+15
| | | | | | | | | | | | | | CommandLine::Init() In the multi-DLL build, we can end up initializing the object twice at startup (once in chrome.exe and once in chrome.dll). It should be harmless. BUG=76996 TEST=base_unittests Review URL: http://codereview.chromium.org/7273053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92380 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add COMPONENT_BUILD global define. "yurys@chromium.org2011-07-135-42/+19
| | | | | | | | | | | | | The change broke compilation on Linux Builder (dbg)(shared): http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/3365/steps/compile/logs/stdio TBR=darin BUG=None TEST=None Review URL: http://codereview.chromium.org/7352014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92329 0039d316-1c4b-4281-b951-d872f2087c98
* Add COMPONENT_BUILD global define. darin@chromium.org2011-07-135-19/+42
| | | | | | | | | | | | | | | | | | | | | | This avoids the need to define FOO_DLL macros for each project that we wish to optionally build as a DLL (when component=="shared_library"). This in turn means that we do not need direct_dependent_settings to define FOO_DLL, and that means that we don't need to update projects to convert transitive dependencies into explicit dependencies. This makes the component build more consistent with the static build. An alternative would be to use all_dependent_settings, but I feel that the global approach is simpler as it creates less repetition in each target definition for components. A side-effect of this change is that I needed to make base_nacl_win64 be a shared_library in the component build. R=rvargas,bradnelson Review URL: http://codereview.chromium.org/7344022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92325 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up users of a deprecated base::LaunchApp API."evan@chromium.org2011-07-123-16/+43
| | | | | | This reverts commit r92240, ChromeOS failures. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92244 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-123-43/+16
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7346017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92240 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/values.h into the base namespace. This includes a cros DEPS rolldmazzoni@chromium.org2011-07-124-6/+27
| | | | | | | | | | with a minor change to that code since libcros also uses base/values.h. BUG=88666 TEST=none Review URL: http://codereview.chromium.org/7259019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92208 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-122-24/+13
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7258005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92200 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly ShutdownOnUIThread the HostContentSettingsMap when destroying the ↵bauerb@chromium.org2011-07-122-0/+12
| | | | | | | | | | | | Profile. Also, get rid of Profile dependencies while we're at it. BUG=88037,88557 Review URL: http://codereview.chromium.org/7218073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92128 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the comments setting emands and vim tab width and expansion variables.tony@chromium.org2011-07-112-12/+0
| | | | | | | | | | | | | | | | | These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream android debug and log related filesmichaelbai@google.com2011-07-0711-7/+137
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7238012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91748 0039d316-1c4b-4281-b951-d872f2087c98
* Extend TTS extension API to support richer events returned from the enginedmazzoni@chromium.org2011-07-071-1/+2
| | | | | | | | | | | | | | | | | | to the client. Previously we just had a completed event; this adds start, word boundary, sentence boundary, and marker boundary. In addition, interrupted and canceled, which were previously errors, now become events. Mac and Windows implementations extended to support as many of these events as possible. BUG=67713 BUG=70198 BUG=75106 BUG=83404 TEST=Updates all TTS API tests to be event-based, and adds new tests. Review URL: http://codereview.chromium.org/6792014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91665 0039d316-1c4b-4281-b951-d872f2087c98
* Move kLocalePak into ui/base/ from base/. Fixes component build of ↵sadrul@chromium.org2011-07-062-5/+0
| | | | | | | | | | | views_desktop. BUG=none TEST=none Review URL: http://codereview.chromium.org/7312010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91621 0039d316-1c4b-4281-b951-d872f2087c98
* posix: remove LaunchAppInNewProcessGroupevan@chromium.org2011-07-061-16/+0
| | | | | | | | Due to refactoring, we can use the common API for this. Review URL: http://codereview.chromium.org/7284018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91612 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Time::Explode on Windows and PepperMessageFilter::OnGetLocalTimeZoneOffset.yzshen@chromium.org2011-07-061-18/+32
| | | | | | | | | BUG=None TEST=All time unittests pass. Review URL: http://codereview.chromium.org/7282018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91602 0039d316-1c4b-4281-b951-d872f2087c98
* Added ability to run a command, getting output and exit status on POSIX.benwells@chromium.org2011-07-063-22/+106
| | | | | | | | | | | | | | | Register protocol handler needs to check the return value of scripts it runs and collects output from. There needs a variant of GetAppOutput which returns the exit code of the application run, not just a success or failure, so this function has been added. BUG=83557 TEST=Unit test added Review URL: http://codereview.chromium.org/7198034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91527 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Split SystemMonitor initialization so it's not blocked by the Sandbox.jeremy@chromium.org2011-07-043-17/+40
| | | | | | | | | | | | | In OS X 10.7 Lion, the IO port we listen on to monitor system power events is blocked by the Sandbox. Move the allocation of the IO port so it happens early on during Chrome startup. BUG=83783 TEST=When putting a system to sleep with Chrome running, the browser shouldn't crash. Also, need to monitor crash logs to see that this crash goes away. Review URL: http://codereview.chromium.org/7235023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91462 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure tests check the return of SpawnChild() when they may wait without ↵rsleevi@chromium.org2011-07-021-0/+1
| | | | | | | | | | | | | | | | | | timeouts Ensure that the result of SpawnChild() is consistently checked for unittests. If an child fails to launch, SpawnChild() will return base::kNullProcessHandle. Waiting on this handle is equivalent to waiting for any child to terminate - and if there are no children, this may wait indefinitely, causing the whole test executable to timeout after 10 minutes. BUG=none TEST=none Review URL: http://codereview.chromium.org/7304008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91430 0039d316-1c4b-4281-b951-d872f2087c98
* Change MessagePumpLibevent::Run to process I/O events before doing idlewtc@chromium.org2011-07-012-0/+12
| | | | | | | | | | | | work. R=jar@chromium.org,mark@chromium.org,rvargas@chromium.org BUG=87707 TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/7291010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91252 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add NET_API to more code to enable buildingrvargas@google.com2011-06-301-3/+6
| | | | | | | | | | | a shared net library on Linux, and update base and crypto API definitions. BUG=76997 TEST=none Review URL: http://codereview.chromium.org/7240021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91234 0039d316-1c4b-4281-b951-d872f2087c98
* base: refactor LaunchApp variants into a single functionevan@chromium.org2011-06-303-197/+243
| | | | | | | | | | | | | | | base provides a bunch of process-spawning functions that only differ by one or two arguments; worse, they're all backed by the same implementation anyway. Unify all the functions into one LaunchProcess() function, which takes a struct containing a bunch of optional arguments. For this change, I'm trying to not change the base API. Follow up changes can fix callers. Because of this, I made temporary shims for all of the old API. Review URL: http://codereview.chromium.org/7283019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91220 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use a macro for getting at the process environment.evan@chromium.org2011-06-301-3/+23
| | | | | | | | | I had a struct field named "environ" that was mysteriously not working on OS X until I noticed this code. Review URL: http://codereview.chromium.org/7278004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91184 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 91137 - Change MessagePumpLibevent::Run to process I/O events before ↵torne@chromium.org2011-06-302-10/+0
| | | | | | | | | | | | | | | | | doing idle work. R=agl@chromium.org,jar@chromium.org,mark@chromium.org,rvargas@chromium.org BUG=87707 TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/7262011 TBR=wtc@chromium.org Review URL: http://codereview.chromium.org/7210028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91141 0039d316-1c4b-4281-b951-d872f2087c98
* Change MessagePumpLibevent::Run to process I/O events before doing idlewtc@chromium.org2011-06-302-0/+10
| | | | | | | | | | | | work. R=agl@chromium.org,jar@chromium.org,mark@chromium.org,rvargas@chromium.org BUG=87707 TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/7262011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91137 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream process and thread related code.michaelbai@google.com2011-06-294-4/+19
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7247015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91009 0039d316-1c4b-4281-b951-d872f2087c98
* base: Use TEST() macro in Value unittests.tfarina@chromium.org2011-06-283-32/+29
| | | | | | | | | | | | | | | While I'm here: - Add 'base' namespace to this test file. - Remove unnecessary typedefs of testing::Test. BUG=None TEST=base_unittests R=evan@chromium.org Review URL: http://codereview.chromium.org/7275004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90862 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90805 - I am submitting this with LGTMs from agl@ and evanm@. I'm ↵fischman@chromium.org2011-06-282-41/+5
| | | | | | | | | | | | | | | | | | | | | | | marking this as TBR=jam@ because he is on vacation. He previously LGTMed the reverted CL (link below) and there are not substantive changes since then. Modify the Chrome Linux zygote to support a nacl_helper executable, facilitating a special address-space layout as required by NaCl on ARM and ATOM CPUs. In passing, simplify some shared elements of launching NaCl modules in Chrome. This is an update to a previously reverted CL. Please see http://codereview.chromium.org/6995121 for the earlier reviews. Patching nacl_helper CL into fresh branch. BUG=nativeclient:480 TEST=nativeclient in-browser tests TBR=jam@chromium.org TBR=bradchen@google.com Review URL: http://codereview.chromium.org/7230057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90813 0039d316-1c4b-4281-b951-d872f2087c98
* I am submitting this with LGTMs from agl@ and evanm@. I'm marking this as ↵bradchen@google.com2011-06-282-5/+41
| | | | | | | | | | | | | | | | | | | | TBR=jam@ because he is on vacation. He previously LGTMed the reverted CL (link below) and there are not substantive changes since then. Modify the Chrome Linux zygote to support a nacl_helper executable, facilitating a special address-space layout as required by NaCl on ARM and ATOM CPUs. In passing, simplify some shared elements of launching NaCl modules in Chrome. This is an update to a previously reverted CL. Please see http://codereview.chromium.org/6995121 for the earlier reviews. Patching nacl_helper CL into fresh branch. BUG=nativeclient:480 TEST=nativeclient in-browser tests TBR=jam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90805 0039d316-1c4b-4281-b951-d872f2087c98
* Apply CSP to chrome: and about: pagestsepez@chromium.org2011-06-283-45/+5
| | | | | | | Apply Content Security Policy to the chrome://credits page, and the other pages handled by browser_about_handler.cc while we're at it. Move inline JS out of several html files. Move top-level page generation to the about_handler.cc, with tracked_objects.cc/hisogram.cc generating markup fragments to be included. This keeps this files agnostic to CSP issues. Also fix an output encoding issue in the <title> of some pages. Review URL: http://codereview.chromium.org/7215034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90788 0039d316-1c4b-4281-b951-d872f2087c98
* Added last_modified field to TemplateURL and database. Updated unit tests, ↵stevet@chromium.org2011-06-283-0/+99
| | | | | | | | | | including refactoring MockTimeProvider out of media/. BUG=None TEST=No visible changes. Ensure that changed unittests all pass. Review URL: http://codereview.chromium.org/7232023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90764 0039d316-1c4b-4281-b951-d872f2087c98
* Move the thread test helper to base/testjochen@chromium.org2011-06-283-0/+84
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7239023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix comment in base/auto_reset.h to refer to AutoReset instead ofmark@chromium.org2011-06-281-9/+8
| | | | | | | | | | | | | | | | AutoResetValue. This inconsistency was introduced in r48644. The review history for that change, http://codereview.chromium.org/2394001, indicates that AutoResetValue was initially used in this file but not at any of the use sites. When it changed to AutoReset in patch set 2, matching the use sites, the comment still was not updated. BUG=none, cleanup TEST=none Review URL: http://codereview.chromium.org/7253032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90707 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90681 - New NaCl zygote implementation 2, in which Chrome zygote ↵fischman@chromium.org2011-06-282-40/+4
| | | | | | | | | | | | | | | | forks a NaCl helper. This patch can launch earth_c.html with and without the SUID sandbox. It is enabled with the environment variable NACL_NEW_ZYGOTE. BUG=nativeclient:480 TEST=nativeclient in-browser tests on Linux, ChromeOS Review URL: http://codereview.chromium.org/6995121 TBR=bradchen@google.com Review URL: http://codereview.chromium.org/7274011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90682 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 00:23:30 +0000