summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] When in fullscreen mode, ties the menubar shown state to the overlay ↵rohitrao@chromium.org2010-03-032-31/+107
| | | | | | | | | | | shown state. BUG=36610 TEST=Go fullscreen. Menubar should only be shown when the overlay is fully visible. TEST=While in fullscreen mode, fullscreen a youtube video. Menubar should be autohidden (mousing to the top of the screen should show it). Review URL: http://codereview.chromium.org/661380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40529 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 40490 - Make the pepper 2D flush callback actually function as ↵brettw@chromium.org2010-03-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | advertised. It will now get called asynchronously when the bits are actually copied to the screen, rather than synchronously from inside the paint function. This makes it useful for plugins to use the callback for rate limiting. This also adds a lot of infrastructure for running tests on pepper devices, and includes a unit test for the new flush behavior. I made the existing RenderProcess object an abstract interface and made the existing MockProcess (renamed to be more clear) implement that. This avoids a static cast that would actually crash during a unit test because some code was hardcoded to expect a RenderProcess object. This fixes base's IDMap iterator which has apparently never been used for an IDMap with ownership semantics. TEST=Unit test included BUG=none Review URL: http://codereview.chromium.org/661124 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/660439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40494 0039d316-1c4b-4281-b951-d872f2087c98
* Make the pepper 2D flush callback actually function as advertised. It will nowbrettw@chromium.org2010-03-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | get called asynchronously when the bits are actually copied to the screen, rather than synchronously from inside the paint function. This makes it useful for plugins to use the callback for rate limiting. This also adds a lot of infrastructure for running tests on pepper devices, and includes a unit test for the new flush behavior. I made the existing RenderProcess object an abstract interface and made the existing MockProcess (renamed to be more clear) implement that. This avoids a static cast that would actually crash during a unit test because some code was hardcoded to expect a RenderProcess object. This fixes base's IDMap iterator which has apparently never been used for an IDMap with ownership semantics. TEST=Unit test included BUG=none Review URL: http://codereview.chromium.org/661124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40490 0039d316-1c4b-4281-b951-d872f2087c98
* Switch base to using CHECK_*.willchan@chromium.org2010-03-0211-13/+12
| | | | | | Review URL: http://codereview.chromium.org/660357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40394 0039d316-1c4b-4281-b951-d872f2087c98
* make sure we don't include the obsolete 2008 SDK dir.nsylvain@chromium.org2010-03-021-1/+1
| | | | | | | | | | This is making the nacl 64 app to fail to build, because our code to make sure we use the lib64 folder fails because it does not except to have the sdk Lib dir twice (once for 2008, once for win7). Review URL: http://codereview.chromium.org/660314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40379 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Select right tab in content settings dialog.thakis@chromium.org2010-03-021-0/+1
| | | | | | | | | | | | | Also fix an unrelated TODO in this area. xib change: Make ContentSettingsWindowController the NSTabView's delegate and hook the controller's IBOutlet up to the NSTabView. BUG=36949 TEST=Open content settings via a blocked popups bubble. Popup tab should be selected. Select javascript tab, close window. Reopen window, javascript tab should still be selected. Review URL: http://codereview.chromium.org/661354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40362 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r40289: "Add support for CHECK_* macros.""willchan@chromium.org2010-03-025-45/+79
| | | | | | | | Make sure DEFINE_CHECK_OP_IMPL isn't omitted for official builds. Review URL: http://codereview.chromium.org/661325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40327 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r40289: "Add support for CHECK_* macros."willchan@chromium.org2010-03-015-64/+31
| | | | | | | | Broke official build compilation (only worked on debug/release builds). Review URL: http://codereview.chromium.org/661298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40296 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix the case where the browser livelocks if we cannot open a file."agl@chromium.org2010-03-013-22/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40291 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for CHECK_* macros.willchan@chromium.org2010-03-015-31/+64
| | | | | | | | Convert a few places to make sure it works. Review URL: http://codereview.chromium.org/660221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40289 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use xmessage for the dialog used in LOG(FATAL)evan@chromium.org2010-03-012-23/+31
| | | | | | | | | | | | The previous code printed to stderr, but since the logging code already had logged to stderr we'd end up printing the message twice, which was making me nervous. BUG=29997,31243,37026 Review URL: http://codereview.chromium.org/660269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40271 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: use xmessage for the dialog used in LOG(FATAL)"evan@chromium.org2010-03-011-24/+13
| | | | | | This reverts commit r40261. Test breakage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40262 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use xmessage for the dialog used in LOG(FATAL)evan@chromium.org2010-03-011-13/+24
| | | | | | | | | | | | The previous code printed to stderr, but since the logging code already had logged to stderr we'd end up printing the message twice, which was making me nervous. BUG=31243,37026 Review URL: http://codereview.chromium.org/661260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40261 0039d316-1c4b-4281-b951-d872f2087c98
* Make IsStringUTF8 reject (U+FDD0 .. U+FDEF) jschuh@google.com2010-02-265-148/+20
| | | | | | | | | | | Eliminated the old Mozilla implementation and used an ICU-based implementation. BUG=2759 TEST=base_unittests --gtest_filter=StringUtilTest.IsStringUTF8 Review URL: http://codereview.chromium.org/661205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40178 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the case where the browser livelocks if we cannot open a file.agl@chromium.org2010-02-263-0/+22
| | | | | | | | | | | | | | | | | | | | If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. (Land attempt three: first in r39446, reverted in r39448. Second in r39899, reverted in r39901.) http://codereview.chromium.org/541022 BUG=30850 TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40146 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate file_util::AppendToPath() on non-Windows.evan@chromium.org2010-02-264-8/+15
| | | | | | | | | | | | We still have ~150 callers to AppendToPath in our code, but most of them are in the installer and I'm reluctant to fiddle with that code without having an easy way to test it. BUG=24672 Review URL: http://codereview.chromium.org/654013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40120 0039d316-1c4b-4281-b951-d872f2087c98
* Add some more comments near the *Hack() functions.evan@chromium.org2010-02-261-11/+13
| | | | | | | | | | | This will help newer people hacking on the code to understand how to join the anti-wstring quest. BUG=24672 Review URL: http://codereview.chromium.org/660082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40117 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the LINUX_TC_MALLOC #define with the existing TC_MALLOC #define.thestig@chromium.org2010-02-264-13/+14
| | | | | | | | BUG=36687 TEST=about:tcmalloc, etc, works when tcmalloc is enabled on Linux. Review URL: http://codereview.chromium.org/660118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40080 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent macro redefinitiongregoryd@google.com2010-02-251-0/+4
| | | | | | Review URL: http://codereview.chromium.org/657016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40028 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 39942 - Switch NetworkChangeNotifier implementations to use ObserverList.willchan@chromium.org2010-02-252-54/+132
| | | | | | | | | Fixed build problem with database_tracker.(cc|h). BUG=36590 Review URL: http://codereview.chromium.org/660039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39983 0039d316-1c4b-4281-b951-d872f2087c98
* Give Mac plugin processes descriptive names for Activity Monitorstuartmorgan@chromium.org2010-02-242-0/+70
| | | | | | | | | BUG=none TEST=Open Activity Monitor, and visit a page with a plugin. The plugin process should show the name of the plugin. Review URL: http://codereview.chromium.org/659007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39950 0039d316-1c4b-4281-b951-d872f2087c98
* Custom "menus" for the bookmark bar folders. jrg@chromium.org2010-02-242-0/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Full behavior: http://JRG_WRITE_FULL_DOC_AND_TEST_PLAN_TOMORROW BUG=17608 (and a slew of others) Brief details on how to test: - add some bookmarks and bookmark folders. - at a basic level, make sure bookmark folders feel like menus e.g. -- click to open -- can open "submenus" and sub-sub-menus -- can open (click on) bookmarks in any of these submenus - click-drag does NOT open a menu (different than Mac menus); it initiates a Drag - click on folder in bookmark bar initiates "hover open"; moving mouse over other folders will pop them open immediately (much like Mac menus) - Bookmark bar non-drag hover-open is immediate, but bookmark folder hover-open has a brief delay so quick "move down" a folder does not trigger them all to open while you travel (much like Mac menus). - DnD of bookmarks and folders on bookmark bar. - While doing DnD of bookmark, "hover" over a folder and see it open. - Bookmark folder menus have normal DnD "drop indicators" like the bookmark bar. - Can "hover open" a nested subfolder. - Can drag a bookmark from one deep sub-sub-folder to a different deep one. - Confirm buttons and folders in submenus are themed, both with the theme set at launch time and the theme we change to after launch. - Empty folders have an "(empty)" item which is not selectable. - Intentional delay in closing a sub-sub-folder when hovering over another one. E.g. When moving to a sub-sub-menu, 'brief' travel over a different submenu does not close the destination sub-menu. - can use bookmark context menus in folder "menus". - confirm DnD from "Other bookmarks" to any other random folder and vice versa. - While non-drag hover open is active, clicking anywhere other than the bookmark bar or folder (e.g. the main web view) turns it off. TODO: - random bugs (e.g. "add folder" over a folder doesn't put it in there) - (empty) needs to be revisited, both visually and for a drop indication - core animations instead of drop indicators - ... Review URL: http://codereview.chromium.org/551226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39947 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39942 - Switch NetworkChangeNotifier implementations to use ObserverList.willchan@chromium.org2010-02-242-132/+54
| | | | | | | | | | | | | Fix up observer list so we can use FOR_EACH_OBSERVER when check_empty is set. Clean up the ObserverList API a bit, replacing GetElementAt() with HasObserver() and Clear(). BUG=36590 Review URL: http://codereview.chromium.org/652205 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/661029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39945 0039d316-1c4b-4281-b951-d872f2087c98
* Switch NetworkChangeNotifier implementations to use ObserverList.willchan@chromium.org2010-02-242-54/+132
| | | | | | | | | | Fix up observer list so we can use FOR_EACH_OBSERVER when check_empty is set. Clean up the ObserverList API a bit, replacing GetElementAt() with HasObserver() and Clear(). BUG=36590 Review URL: http://codereview.chromium.org/652205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39942 0039d316-1c4b-4281-b951-d872f2087c98
* I just put the code that does not compile on ARM. Trybots will fail because ↵apatrick@chromium.org2010-02-242-0/+50
| | | | | | | | | | | | | | I had to remove these from the CL to make gcl upload properly accept it. A + base\scoped_open_process.h A + chrome\plugin\command_buffer_stub_win.cc TEST=try BUG=none Review URL: http://codereview.chromium.org/661022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39937 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix the case where the browser livelocks if we cannot open a file."agl@chromium.org2010-02-243-22/+0
| | | | | | (Still breaks Mac net_unittests. Damm you Mac.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39901 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the case where the browser livelocks if we cannot open a file.agl@chromium.org2010-02-243-0/+22
| | | | | | | | | | | | | | | | | | | If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. (Land attempt two: first in r39446, reverted in r39448) http://codereview.chromium.org/541022 BUG=30850 TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39899 0039d316-1c4b-4281-b951-d872f2087c98
* Add '-ldl' to Linux targets that use dynamic loader functions.mmoss@google.com2010-02-231-0/+2
| | | | | | | | | | | | | This fixes compilation errors on Karmic, where dlopen() and friends were undefined: http://chrome-buildbot.corp.google.com:8016/builders/Chromium%20Linux%20Builder%20(dbg-shlib)/builds/7777/steps/compile/logs/stdio The missing '-ldl' is papered over on Hardy because pretty much everything depends on gtk, which brings that in through pkg-config, but pkg-config gtk no longer includes '-ldl' on Karmic. Review URL: http://codereview.chromium.org/656014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39754 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate GetDirectoryFromPath on non-Windows.evan@chromium.org2010-02-234-23/+18
| | | | | | | | | | | Due to a bunch of changes I made last week, we now only need this in Windows-specific codepaths. BUG=24672 Review URL: http://codereview.chromium.org/654009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39715 0039d316-1c4b-4281-b951-d872f2087c98
* Add back a line in file_util.h that was accidentally deleted long ago.evan@chromium.org2010-02-231-0/+1
| | | | | | Review URL: http://codereview.chromium.org/652111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39712 0039d316-1c4b-4281-b951-d872f2087c98
* Move deprecated file_util declarations into a separate file.evan@chromium.org2010-02-233-54/+64
| | | | | | | | | | | | This will make it harder to find them (discouraging new uses) and make it easier to find them for cleanup purposes. BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/654004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39711 0039d316-1c4b-4281-b951-d872f2087c98
* Add MessageLoop::QuitNow and use it to terminate a sync IPC.darin@chromium.org2010-02-232-0/+13
| | | | | | | | | | | | | This is a test to observe the performance impact of this change. As such, I'm reverting r39518 as part of this change. R=jam BUG=36310 TEST=none Review URL: http://codereview.chromium.org/652089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39699 0039d316-1c4b-4281-b951-d872f2087c98
* Fix app shortcut mess up per issue 31789xiyuan@chromium.org2010-02-231-0/+8
| | | | | | | | | | | | | | | | | | Issue 31789 is caused by a longer than MAX_PATH chars web app description. Fix it by limiting the description string size to MAX_PATH. Note: 1. MSDN mentions that the size limitation for Win2000 or later is INFOTIPSIZE but the limit on my vista dev machine is MAX_PATH. <http://msdn.microsoft.com/en-us/library/bb774955(VS.85).aspx> 2. The size limit includes the terminating NULL. BUG=31789 TEST=Verify fix for issue 31789. facebook.com has a 261-char description and chromium should be able to create a working shortcut for it. Review URL: http://codereview.chromium.org/650186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39686 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39530 - GPU plugin forwards repaint events to Pepper plugin.apatrick@chromium.org2010-02-202-50/+0
| | | | | | | | | | | | | | | | WM_PAINT results in a call to Pepper repaint callback. Implemented WM_ERASEBKGND to prevent flickering on repaint. Implemented PGL_NO_CONTEXT (copied from EGL spec). This is already reviewed by alokp but unfortunately got entangled with this CL. TEST=none BUG=none Review URL: http://codereview.chromium.org/571018 TBR=alokp@chromium.org Review URL: http://codereview.chromium.org/650100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39535 0039d316-1c4b-4281-b951-d872f2087c98
* GPU plugin forwards repaint events to Pepper plugin.apatrick@chromium.org2010-02-202-0/+50
| | | | | | | | | | | | | WM_PAINT results in a call to Pepper repaint callback. Implemented WM_ERASEBKGND to prevent flickering on repaint. Implemented PGL_NO_CONTEXT (copied from EGL spec). This is already reviewed by alokp but unfortunately got entangled with this CL. TEST=none BUG=none Review URL: http://codereview.chromium.org/571018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39530 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r39446: "Fix the case where the browser livelocks if we cannot open a ↵agl@chromium.org2010-02-193-53/+0
| | | | | | | | file." This somehow broke net_unittests on the Mac. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39448 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the case where the browser livelocks if we cannot open a file.agl@chromium.org2010-02-193-0/+53
| | | | | | | | | | | | | | | | | If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. http://codereview.chromium.org/541022 BUG=30850 TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39446 0039d316-1c4b-4281-b951-d872f2087c98
* importer: use FilePath instead of wstring in some placesevan@chromium.org2010-02-192-0/+31
| | | | | | | | | | | Added API to DictionaryValue to use ASCII where appropriate. BUG=24672 TEST=profile import still got my bookmarks Review URL: http://codereview.chromium.org/647016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39441 0039d316-1c4b-4281-b951-d872f2087c98
* linux: make NSS version check non-fatalevan@chromium.org2010-02-191-3/+12
| | | | | | | | | | It broke too many people for reasons outside of their control. BUG=33163 Review URL: http://codereview.chromium.org/562039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39436 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-196-246/+258
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* Adds new API to process_utils to launch a new app as a user in a specified ↵gwilson@google.com2010-02-182-1/+15
| | | | | | | | | | | | | desktop. Also modifies toast behavior to use this API instead. R=huanr,cpu BUG=none TEST=Run system-level toast with an attached user, toast should be visible. Review URL: http://codereview.chromium.org/596087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39391 0039d316-1c4b-4281-b951-d872f2087c98
* Solaris: Second set adding in Solaris as an OS optionevan@chromium.org2010-02-182-6/+6
| | | | | | | | | | TEST=compiles BUG=30101 Patch by James Choi <jchoi42@pha.jhu.edu>. Review URL: http://codereview.chromium.org/606075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39362 0039d316-1c4b-4281-b951-d872f2087c98
* Actually delete databases in CookiesTreeModel.jochen@chromium.org2010-02-186-6/+67
| | | | | | | | | BUG=34633 TEST=delete a database while it's opened in the renderer Review URL: http://codereview.chromium.org/600104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39346 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gyp DEPS, and mostly revert r38366 which was fixed better in gyp.mmoss@google.com2010-02-171-3/+1
| | | | | | | | | | This properly triggers build targets that depend on "always run" actions. BUG=22044 Review URL: http://codereview.chromium.org/604061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39223 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. tidy up of various comments found whilst learning the codebase.joth@chromium.org2010-02-171-1/+1
| | | | | | | | | | | | Fix a lint warning in render_messages.h (supersedes http://codereview.chromium.org/464072/show) Also implement a couple comments in geolocaiton/ in follow up to http://codereview.chromium.org/604019 BUG=none TEST=none Review URL: http://codereview.chromium.org/600128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39222 0039d316-1c4b-4281-b951-d872f2087c98
* solaris: minor ifdefsevan@chromium.org2010-02-173-1/+8
| | | | | | | | | | | | | base/process_util_posix.cc, base/third_party/nspr/prcpucfg.h, third_party/npapi/bindings/npapi.h: added alternate Solaris OS choice BUG=30101 TEST=compiles Patch by James Choi <jchoi42@pha.jhu.edu>. Review URL: http://codereview.chromium.org/606069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39220 0039d316-1c4b-4281-b951-d872f2087c98
* Make SharedMemory use uint32 instead of size_t. This removes the remaining ↵jam@chromium.org2010-02-164-16/+16
| | | | | | | | size_t's from the IPC code. Review URL: http://codereview.chromium.org/581001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39164 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Content blocked icons.thakis@chromium.org2010-02-161-1/+9
| | | | | | | | | | | | | Also rewrite how omnibox icons are handled, to make it less repetitive to add the content blocked icons. Remove a O(n^2) while I'm at it. BUG=35594,34894 TEST=Go to a page with popups. "popups blocked" icon should appear in omnibox. It should have a tooltip, and a normal arrow cursor on mouse over. Switching tabs should make it go away, coming back to the tab with the blocked popup should make it go back. Page actions should still work (tooltips, clicking, context menu, display). Security icon should still work. Install rss extension; the preview bubble should point to the right icon. http://imgur.com/Yo0Ss Review URL: http://codereview.chromium.org/600133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39158 0039d316-1c4b-4281-b951-d872f2087c98
* Set chromium_code = 0 on base.gyp:symbolize and base.gyp:xdg_mime.mark@chromium.org2010-02-161-2/+6
| | | | | | | | BUG=35588 TEST=Linux build; these targets should compile without warnings Review URL: http://codereview.chromium.org/601061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39111 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly recognize emptiness of IDMap.phajdan.jr@chromium.org2010-02-162-5/+16
| | | | | | | | | | | | This prevents a leak of RenderProcessHost, and possibly other bad bugs. TEST=Added to base_unittests; also existing browser and unit tests. BUG=35571 Review URL: http://codereview.chromium.org/604048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39084 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 12:27:31 +0000