| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/10987100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the chrome browser expose a JS object for retrieving histograms if a command line flag is passed. Page cycler then gets the histograms by executing JS via the test automation API.
BUG=145352
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159668
Review URL: https://chromiumcodereview.appspot.com/10905073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11028044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breakages:
http://build.chromium.org/p/chromium/buildstatus?builder=Android%20%28dbg%29&number=673
Accounting for moved files and some cleanup.
BUG=137571
Review URL: https://chromiumcodereview.appspot.com/11026080
TBR=nileshagrawal@chromium.org
Review URL: https://codereview.chromium.org/11072009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Accounting for moved files and some cleanup.
BUG=137571
Review URL: https://chromiumcodereview.appspot.com/11026080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=139612
Review URL: https://chromiumcodereview.appspot.com/11022002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=csharp@chromium.org
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/11029063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This had method to check which version of the OS the application is
running.
It also changes the ID generation mechanism to use identifierForVendor
on iOS6 so that the ID are persisted across application reinstallation.
BUG=None
TEST=None
R=stuartmorgan@chromium.org,mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11031066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
webview.
This is needed to build Android webview.
TBR=brettw,willchan,sky
Review URL: https://chromiumcodereview.appspot.com/11065035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
problem was that DesktopActivationClient would be created after an aura::Window so it would never register for notifications that it went away. As a result it would call a deleted Window in its ActivateWindow method.
BUG=146077
Review URL: https://codereview.chromium.org/11062004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting with r160349, isolate.py now produces .swarm instead of .results files.
TBR=csharp@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/11035056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=willchan@chromium.org
TBR=ajwong@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11033037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use this string to check whether the cpu is Intel Atom processor.
This change is to make sure the 2D canvas acceleration is enabled
on Atom / windows system.
BUG=151500
Review URL: https://chromiumcodereview.appspot.com/11009011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=csharp@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/11036026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
src/tools/swarm_client is fetched from tools/swarm_client.
TBR=csharp@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11045023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialized |icon_index| and |dual_mode| member variables in ShortcutProperties constructor.
CID=106232
BUG=none
TEST=none
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11050018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Upstreaming)
Adds information about the Android build fingerprint to information that we
send back in our metrics.
BUG=153694
Review URL: https://chromiumcodereview.appspot.com/11014006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
code, it does mean we do consistent logging and error-checking at all these sites.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11050009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
couple that ensure Stop() has already been called).
BUG=none
TEST=none
TBR=willchan,hans
Review URL: https://codereview.chromium.org/11026019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Upstreaming chrome/common/chrome_* diff for Android.
BUG=152827
Review URL: https://chromiumcodereview.appspot.com/11031008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating JNI bindings for system classes, we try to get the ids
for methods based in the .class file in the SDK.
However, this may trigger run-time errors when trying to run on an older
SDK.
For these system classes, the JNI generator will bind using the "OrNULL"
variation.
BUG=152987
TEST=
Review URL: https://chromiumcodereview.appspot.com/10996063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original description:
Page cyclers: output memory histograms (approach: expose JS object)
This CL makes the chrome browser expose a JS object for retrieving histograms if a command line flag is passed. Page cycler then gets the histograms by executing JS via the test automation API.
BUG=145352
Review URL: https://chromiumcodereview.appspot.com/10905073
TBR=marja@chromium.org
Review URL: https://codereview.chromium.org/11027020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(http://dev.chromium.org/developers/testing/threadsanitizer-tsan-v2)
BUG=128314
Review URL: https://codereview.chromium.org/10948035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the chrome browser expose a JS object for retrieving histograms if a command line flag is passed. Page cycler then gets the histograms by executing JS via the test automation API.
BUG=145352
Review URL: https://chromiumcodereview.appspot.com/10905073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Copy unit tests from MessageLoop.
BUG=119657
TEST=base_unittests
Review URL: https://chromiumcodereview.appspot.com/10828299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none,100309
Review URL: https://chromiumcodereview.appspot.com/10977073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-Windows. Instead change files that use this to specifically #ifdef it for OS_WIN, like we do most other Windows-specific code.
I plan to factor out the "subclass base::Thread to init MTA on Windows" pattern to its own file in a followup change.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/10990079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when a proc field is very large. For example,
proc_stats[VM_VSIZE]=="3073200128" is possible and causes StringToInt
to return false.
Review URL: https://chromiumcodereview.appspot.com/10990101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses a more compact format to avoid generating uber-long names.
Changes media_player_bridge to use such format.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10957037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
greater than 1366x768.
BUG=152198
TEST=Chrome should switch to metro after making it the default browser via first-run UI on a machine that satisfies the new heuristic.
Review URL: https://chromiumcodereview.appspot.com/10986066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10939010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
std::string internals.
BUG=126107
TEST=Unit tests on Windows and Android.
Review URL: https://chromiumcodereview.appspot.com/11004002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
compiler-based ThreadSanitizer (http://dev.chromium.org/developers/testing/threadsanitizer-tsan-v2)
BUG=128314
Review URL: https://codereview.chromium.org/10949021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is to overwrite the shortcut completely (i.e. like SHORTCUT_CREATE_ALWAYS), but only if it exists already.
In this line of thought, SHORTCUT_UPDATE_EXISTING should now only be used when the desire is to update a subset of the properties without affecting other properties currently set on the shortcut.
The two current uses of SHORTCUT_UPDATE_EXISTING at
http://108.166.104.54/xref/chromium/src/chrome/browser/ui/web_applications/web_app_ui.cc#275
and http://108.166.104.54/xref/chromium/src/chrome/browser/shell_integration_win.cc#343
The other uses in the installer are not, but I will change this as part of my big ShellUtil CL coming up.
BUG=148539
TEST=base_unittests.exe --gtest_filter=ShortcutTest*
Review URL: https://chromiumcodereview.appspot.com/10965053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unit tests have to restore the Overrdies they make because they all live in the same
process and not cleaning up their mess means other tests will run against possibly
modified profiles. This class allows tests to set up path overrides and clean them up
in a convenient way and makes sure the global path map stays clean afterwards.
BUG=149161
TEST=unit_tests still pass.
Review URL: https://chromiumcodereview.appspot.com/10948010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
registry key. This is the norm for the Win32 API. base::win::RegKey need not disallow a NULL name in DeleteValue.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10987033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
target base/test/test_shortcut_win.cc
BUG=148539
TEST=base_unittests.exe --gtest_filter=ShortcutTest*
installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest*
unit_tests --gtest_filter=ProfileShortcutManagerTest*
Locally tried a test meant to fail for every property:
TEST_F(ShortcutTest, CreateShortcutVerifyPropertiesWrong) {
ASSERT_TRUE(base::win::CreateOrUpdateShortcutLink(
link_file_, link_properties_, base::win::SHORTCUT_CREATE_ALWAYS));
base::win::ShortcutProperties wrong_properties = link_properties_;
wrong_properties.set_target(FilePath(L"g:\\src\\component\\.gclient"));
wrong_properties.set_working_dir(temp_dir_2_.path());
wrong_properties.set_arguments(string16());
wrong_properties.set_description(L"foo");
wrong_properties.set_icon(temp_dir_2_.path().Append(L"joe.ico"), 8);
wrong_properties.set_app_id(L"JOE");
wrong_properties.set_dual_mode(true);
base::win::ValidateShortcut(link_file_, wrong_properties);
}
And got expected failure output for every property:
[ RUN ] ShortcutTest.CreateShortcutVerifyPropertiesWrong
g:\src\component\src\base\test\test_shortcut_win.cc(54): error: Value of: long_actual_path
Actual: G:\src\temp\scoped_dir14192_645\Target 1.txt
Expected: long_expected_path
Which is: g:\src\component\.gclient
g:\src\component\src\base\test\test_shortcut_win.cc(54): error: Value of: long_actual_path
Actual: G:\src\temp\scoped_dir14192_645
Expected: long_expected_path
Which is: G:\src\temp\scoped_dir14192_27681
g:\src\component\src\base\test\test_shortcut_win.cc(95): error: Value of: read_arguments
Actual: L"--magic --awesome"
Expected: properties.arguments
Which is: L""
g:\src\component\src\base\test\test_shortcut_win.cc(101): error: Value of: read_description
Actual: L"Chrome is awesome."
Expected: properties.description
Which is: L"foo"
g:\src\component\src\base\test\test_shortcut_win.cc(43): error: Expected: (0U) != (::GetLongPathNameW( expected_path.val
ue().c_str(), long_expected_path_chars, 260)), actual: 0 vs 0
Failed to get LongPathName of G:\src\temp\scoped_dir14192_27681\joe.ico
g:\src\component\src\base\test\test_shortcut_win.cc(108): error: Value of: read_icon_index
Actual: 4
Expected: properties.icon_index
Which is: 8
g:\src\component\src\base\test\test_shortcut_win.cc(129): error: Value of: read_app_id
Actual: L"Chrome"
Expected: properties.app_id
Which is: L"JOE"
g:\src\component\src\base\test\test_shortcut_win.cc(138): error: Value of: static_cast<bool>(read_dual_mode)
Actual: false
Expected: properties.dual_mode
Which is: true
[ FAILED ] ShortcutTest.CreateShortcutVerifyPropertiesWrong (37 ms)
Review URL: https://chromiumcodereview.appspot.com/10996005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Used in upcoming http://codereview.chromium.org/10996005/ (and potentially others).
BUG=148539
TEST=Write a test with an error comparing two FilePaths and confirm the paths' values are printed by gtest as opposed to the byte-representation.
Review URL: https://chromiumcodereview.appspot.com/10984028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is especially useful for unit tests because they live in the same process
and share all the singletons including PathService. One can of course override
the overrides but it is much cleaner and sometimes the only good solution to
return to the original PathProvider instead.
BUG=149161
TEST=base_unittests:PathServiceTest.*
Review URL: https://chromiumcodereview.appspot.com/10909228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It stores mapping between object's starting addresses and their
allocated types when a build option 'clang_type_profiler=1' is
specified. It enables information like
"an object at 0x37f3c88 is an instance of std::string."
Nothing is changed when the option is not specified.
It depends on a modified version of the LLVM/Clang compiler
introduced at deps/third_party/llvm-allocated-type.
BUG=123758
TEST=build with clang_type_profiler=1 and run type_profiler_unittests and type_profiler_map_unittests manually.
Review URL: https://chromiumcodereview.appspot.com/10411047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
POSIX versions return consistent architecture names.
Review URL: https://chromiumcodereview.appspot.com/10910247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Gives the GC a little less work todo, especially during repeatedly called async callpaths.
Review URL: https://chromiumcodereview.appspot.com/10913284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DIR_USER_DESKTOP does not apply on iOS, so exclude it from the set of paths that
are tested.
BUG=b/151050
Review URL: https://chromiumcodereview.appspot.com/10970019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp targets should not depend on tests from other packages, but
instead be able to depend on their test utils.
The target including the base utilities is called
base_java_test_support and contains files from
base/test/android/javatests.
base_java_test_support was also the name of the wrongly named target for
building base/android/javatests, but since only contained util-classes,
no new target has been created for tests of base/android/java.
BUG=151561,150773
Review URL: https://chromiumcodereview.appspot.com/10974012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=152037
TEST=none
TBR=willchan@chromium.org
Review URL: https://codereview.chromium.org/10978006
TBR=rvargas@google.com
Review URL: https://codereview.chromium.org/10978007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=152037
TEST=none
TBR=willchan@chromium.org
Review URL: https://codereview.chromium.org/10978006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file contains some hand-written JNI, and a few
hops native<->java.
This clarifies things a bit by:
- adding a MediaPlayerBridge.java to avoid some hops.
- moving code to MediaPlayerListener.java.
Further clean up will be done by auto-generating bindings for
android.media.MediaPlayer directly.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10961015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows to simplify some places such as surface_texture_bridge.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10968009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=base_unittests
TBR=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10969059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158203 0039d316-1c4b-4281-b951-d872f2087c98
|