summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Make sure that Clipboard operations that require dispatchingrvargas@google.com2009-01-314-18/+77
| | | | | | | | | | | | | | | | | | | | of windows messages are performed on the UI thread. SetClipboardData requires the clipboard to be open with a handle to a window that will be notified when the contents are going to change again. If Windows messages are not processed, any other app writing to the clipboard will be locked while we acknowledge their request (by processing the message). The IO thread doesn't pump windows messages anymore so write clipboard operations cannot be performed from that thread and have to be posted to another thread. BUG=5823 Review URL: http://codereview.chromium.org/19733 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9003 0039d316-1c4b-4281-b951-d872f2087c98
* Rename README.google to README.chromium.mal@chromium.org2009-01-303-0/+0
| | | | | | | | | No code change. B=4380 Review URL: http://codereview.chromium.org/19501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8988 0039d316-1c4b-4281-b951-d872f2087c98
* Provides the ability to write a unit test that brings up a browser. Assky@google.com2009-01-301-0/+10
| | | | | | | | | | | | | | a proof of concept I converted FindInPageControllerTest.FindInPageFrames over to this. See the description in InProcessBrowserTest for how it all works. BUG=none TEST=none Review URL: http://codereview.chromium.org/19644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8934 0039d316-1c4b-4281-b951-d872f2087c98
* Create a stub chrome executable that crashes when run.tc@google.com2009-01-292-2/+33
| | | | | | | | | This is mostly making sure we have all the symbols we need. Review URL: http://codereview.chromium.org/19683 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8930 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Version class and matching unit tests, roughly based on ↵erikkay@google.com2009-01-298-0/+214
| | | | | | | | chrome/installer/util/version.*. This version has more flexible parsing rules and is more robust to detecting bogus versions, supporting arbitrary numbers of version components rather than just dotted quads. It's possible that we should switch chrome installer to use this version. Review URL: http://codereview.chromium.org/19667 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8901 0039d316-1c4b-4281-b951-d872f2087c98
* The new version of Inset() Ben added a while ago didn't work quite right for ↵pkasting@chromium.org2009-01-292-10/+4
| | | | | | | | rects whose origin wasn't (0,0). Fix this and reduce some redundancy. Review URL: http://codereview.chromium.org/19457 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8893 0039d316-1c4b-4281-b951-d872f2087c98
* Add routine to close file descriptors on execjeremy@chromium.org2009-01-295-31/+66
| | | | | | | | for linux and mac. See BUG 6598. Review URL: http://codereview.chromium.org/18801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8892 0039d316-1c4b-4281-b951-d872f2087c98
* Add thread checks to the IPC channel.rvargas@google.com2009-01-291-2/+0
| | | | | | | | | | | | | Almost every method of the IPC channel must be invoked from a single thread. This adds the corresponding DCHECKS, and should confirm bug 6489 as a cause of flakiness on the UI tests. BUG: 6489. Review URL: http://codereview.chromium.org/19617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8837 0039d316-1c4b-4281-b951-d872f2087c98
* Add ScopedTempDir - a class that manages the lifetime of a temporary directory.erikkay@google.com2009-01-287-0/+177
| | | | | | Review URL: http://codereview.chromium.org/19411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8824 0039d316-1c4b-4281-b951-d872f2087c98
* Make WebContentsView portable by using the native view types.brettw@chromium.org2009-01-281-4/+8
| | | | | | Review URL: http://codereview.chromium.org/19632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8819 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of Pipeline and FilterHost interfaces. This is a large ↵ralphl@chromium.org2009-01-283-4/+20
| | | | | | | | | | | | change, but all of the objects are interrelated. I am also checking in a basic unit test that creates pipeline, and the data source hangs during initialization. The test sleeps one second and then stops the pipeline. Andrew has already done a first pass on this, and the code has come largely from our working experimental branch. Review URL: http://codereview.chromium.org/18546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8805 0039d316-1c4b-4281-b951-d872f2087c98
* Add portable keyboard codesphajdan.jr@chromium.org2009-01-285-0/+419
| | | | | | Review URL: http://codereview.chromium.org/19021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8804 0039d316-1c4b-4281-b951-d872f2087c98
* Safe browsing cleanup:estade@chromium.org2009-01-284-12/+22
| | | | | | | | | * wstring -> FilePath * create versions of WriteFile/ReadFile with FilePath signatures Review URL: http://codereview.chromium.org/19610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8797 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test addition, cleanup for render_process/thread.jrg@chromium.org2009-01-281-5/+1
| | | | | | Review URL: http://codereview.chromium.org/19606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8782 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath version of ReadFileToString.erikkay@google.com2009-01-282-1/+7
| | | | | | Review URL: http://codereview.chromium.org/19401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8774 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: gfx::NativeViewId and CrossProcessEventagl@chromium.org2009-01-271-2/+42
| | | | | | | | | | | | | | | | | | | Create a couple new typedefs for porting work. Firstly, gfx::NativeViewId is a handle to a platform specific widget in the renderer process. For Windows, this is just a HWND as before. However, in other platforms the ids used in the renderer process will be something else. CrossProcessEvent is the type of a HANDLE to a Windows event object which is used across processes. Since we aren't going to support these sorts of events on non-Windows platforms, this will have to go away at some point. For now, however, this lets us build code without too many ifdefs all over the place. Review URL: http://codereview.chromium.org/18768 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8756 0039d316-1c4b-4281-b951-d872f2087c98
* moved two private functions into an anonymous namespaceerikkay@google.com2009-01-271-0/+4
| | | | | | Review URL: http://codereview.chromium.org/19017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8747 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the amount of #ifdef.maruel@chromium.org2009-01-271-35/+21
| | | | | | Review URL: http://codereview.chromium.org/18852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8743 0039d316-1c4b-4281-b951-d872f2087c98
* Roll forward 8722,8721jeremy@chromium.org2009-01-273-0/+40
| | | | | | Review URL: http://codereview.chromium.org/19028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8734 0039d316-1c4b-4281-b951-d872f2087c98
* FileUtilTest.Contains failed on Vista Home 64 (and wine)dkegel@google.com2009-01-271-4/+7
| | | | | | | | | because deleting an empty directory tree fails there with ERROR_FILE_NOT_FOUND, so allow that return value. Review URL: http://codereview.chromium.org/18830 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8733 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in release with ThreadCollisionWarner unit tests. Less ↵maruel@chromium.org2009-01-271-8/+20
| | | | | | | | than ideal #ifdef's. Review URL: http://codereview.chromium.org/19018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8724 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8722,8721.maruel@chromium.org2009-01-273-40/+0
| | | | | | Review URL: http://codereview.chromium.org/19024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Windows build.jeremy@chromium.org2009-01-271-0/+3
| | | | | | Review URL: http://codereview.chromium.org/19022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8722 0039d316-1c4b-4281-b951-d872f2087c98
* First step of porting VisitedLinkMaster to POSIX:jeremy@chromium.org2009-01-273-0/+37
| | | | | | | | | | | | * Use POSIX file access APIs rather than HANDLEs. * Add stubs so that VisitedLinkMaster compiles on POSIX. Still to be done: * Bring up Surrounding infrastructure to turn on unit tests. Review URL: http://codereview.chromium.org/18530 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8721 0039d316-1c4b-4281-b951-d872f2087c98
* Add HexStringToBytes which takes an arbitrary length hex string and creates ↵erikkay@google.com2009-01-273-0/+97
| | | | | | | | a vector of bytes. Review URL: http://codereview.chromium.org/18814 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8716 0039d316-1c4b-4281-b951-d872f2087c98
* Add include for libjpegnsylvain@chromium.org2009-01-271-0/+1
| | | | | | Review URL: http://codereview.chromium.org/18839 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8703 0039d316-1c4b-4281-b951-d872f2087c98
* Comment out a NOTIMPLEMENTED() so that a layout test passes.estade@chromium.org2009-01-271-1/+3
| | | | | | Review URL: http://codereview.chromium.org/19002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8702 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build.estade@chromium.org2009-01-271-1/+1
| | | | | | Review URL: http://codereview.chromium.org/19008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8700 0039d316-1c4b-4281-b951-d872f2087c98
* Try2 of issue 18772. (move jpeg_codec* to base/gfx)estade@chromium.org2009-01-2710-25/+837
| | | | | | Review URL: http://codereview.chromium.org/18838 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8699 0039d316-1c4b-4281-b951-d872f2087c98
* Moved Init() before startup_data_->event.Signal() because derivedjrg@chromium.org2009-01-272-3/+27
| | | | | | | | | | | | | | | classes may not be safe to use until Init() has been called. As an example, RenderThread() creates it's IPC::SyncChannel in Init(), so it isn't safe to call Send() method until after. Update use of a Thread (hit with ui_tests) to no longer require Init() be called after the startup event is signaled (required old thread behavior). Ran a bunch more tests on Windows to try harder to make sure I didn't break anything. Review URL: http://codereview.chromium.org/18824 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8695 0039d316-1c4b-4281-b951-d872f2087c98
* undo 8692 (fix build failure)estade@chromium.org2009-01-279-788/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8694 0039d316-1c4b-4281-b951-d872f2087c98
* Move jpeg_codec.* to base/gfxestade@chromium.org2009-01-279-1/+788
| | | | | | Review URL: http://codereview.chromium.org/18772 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8692 0039d316-1c4b-4281-b951-d872f2087c98
* Add thread safety checks but keep them disabled for now until I fix all the ↵maruel@chromium.org2009-01-264-7/+43
| | | | | | | | | current places where it triggers. Fix thread_collision_warner for real this (third?) time. Review URL: http://codereview.chromium.org/18569 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8650 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure variables are referenced in CHECK macros, even for official builds.deanm@chromium.org2009-01-261-11/+13
| | | | | | | | | | | | | | Previously the GCC based builds couldn't build with OFFICIAL_BUILD, since code like: bool success = Something(); DCHECK(success); Would result in a compile warning (treated as error) about success being unused. Review URL: http://codereview.chromium.org/18747 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8630 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork test_shell_main:amanda@chromium.org2009-01-265-1/+45
| | | | | | | | | | | | | | | | | - remove Mac version - move platform-specific operations into PlatformDelegate and remove #ifdefs - add event recorder link stubs for use by platforms that don't have event recording working yet Notes: There's a bunch of stuff in test_shell_{gtk,mac,win} that should also be pulled into the platform delegate so that the TestShell class can also be unforked, but those can be worked on independently per platform after this refactoring. Review URL: http://codereview.chromium.org/18451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8629 0039d316-1c4b-4281-b951-d872f2087c98
* Add user script support to extensions.aa@chromium.org2009-01-252-18/+5
| | | | | | | | | | | | | | | This is implemented mostly by relying on the existing user script code. But since extension user scripts are declared, not discovered in a directory, I had to add support for adding 'lone' user scripts to UserScriptMaster. This led to a bit of refactoring. Note that this CL relies on: http://codereview.chromium.org/18352 Review URL: http://codereview.chromium.org/18198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8614 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r8560 due to broken interactive_ui_testsmark@chromium.org2009-01-233-12/+1
| | | | | | Review URL: http://codereview.chromium.org/18722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8570 0039d316-1c4b-4281-b951-d872f2087c98
* Project changes (automatic reordering by UUID).avi@chromium.org2009-01-231-4/+4
| | | | | | Review URL: http://codereview.chromium.org/18629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8568 0039d316-1c4b-4281-b951-d872f2087c98
* Add a PNGEncoder helper function that takes an SkBitmap,nick@chromium.org2009-01-232-0/+22
| | | | | | | | | | | | which is how PNGEncode is used almost everywhere. This should be strictly no functional change, except for the ImageFilterPeer::DataReady case, where we now take an SkAutoLockPixels where previously we did not. Review URL: http://codereview.chromium.org/18347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8561 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2009-01-233-1/+12
| | | | | | Review URL: http://codereview.chromium.org/18446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8560 0039d316-1c4b-4281-b951-d872f2087c98
* Decrements FieldTrialList::constructor_count_ in the destructor. I'msky@google.com2009-01-233-10/+1
| | | | | | | | | | | | | going to run ui tests in process and call BrowserMain multiple times. That means FieldTrialList's constructor is run multiple times. Without this decrement, the constructor isn't happy. BUG=none TEST=none Review URL: http://codereview.chromium.org/18535 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8554 0039d316-1c4b-4281-b951-d872f2087c98
* Use PlatformThreadId, not int when dealing with thread ids.agl@chromium.org2009-01-2310-15/+36
| | | | | | | | | | | | | | | | | Windows uses a DWORD (unsigned long) for thread ids and POSIX uses a pid_t (int on Linux) for the same. In the code, we are currently stuffing thread ids into an int which is dangerous on Windows (because DWORDS can exceed an int and wrap) and will break if pid_t is ever != int. This change changes all the places where we currently have an int to use a new typedef, PlatformThreadId. This change also needs to occur for process ids, but I'm not doing that in this CL. Review URL: http://codereview.chromium.org/18677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8525 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/18690jrg@chromium.org2009-01-222-27/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8506 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8499.maruel@chromium.org2009-01-222-10/+0
| | | | | | Review URL: http://codereview.chromium.org/18687 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8504 0039d316-1c4b-4281-b951-d872f2087c98
* Add (currently disabled) RefCountedBase check. (2nd try)maruel@chromium.org2009-01-222-0/+10
| | | | | | Review URL: http://codereview.chromium.org/18438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8499 0039d316-1c4b-4281-b951-d872f2087c98
* Another horrible workaround for bug 6436 (purify freaking out with ↵erikkay@google.com2009-01-221-0/+4
| | | | | | | | | | | base_unittests.exe). I'm talking to a Rational engineer hoping to get a real solution. In the meantime, this fix will get base_unittests working under Purify again. See the bug for more of the ugly details. BUG=6436 Review URL: http://codereview.chromium.org/18514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8489 0039d316-1c4b-4281-b951-d872f2087c98
* Moved Init() startup_data_->event.Signal() because derived classes mayjrg@chromium.org2009-01-222-3/+27
| | | | | | | | | | | | not be safe to use until Init() has been called. As an example, RenderThread() creates it's IPC::SyncChannel in Init(), so it isn't safe to call Send() method until after. Change tested explicitly on Mac Win Linux. Review URL: http://codereview.chromium.org/18508 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8485 0039d316-1c4b-4281-b951-d872f2087c98
* Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII("").deanm@chromium.org2009-01-221-3/+2
| | | | | | Review URL: http://codereview.chromium.org/18499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8454 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify HexEncode.deanm@chromium.org2009-01-222-24/+9
| | | | | | | Review URL: http://codereview.chromium.org/18659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8450 0039d316-1c4b-4281-b951-d872f2087c98
* Windows fix: missed on the last oneagl@chromium.org2009-01-221-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/18646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8439 0039d316-1c4b-4281-b951-d872f2087c98