summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Exposing the Close() method publicly in the ScopedHandle class.tommi@chromium.org2008-12-121-3/+8
| | | | | | | | | | | | | This is to be more consistent with the interface defined in scoped_handle.h (ScopedStdioHandle) and also to avoid making the user make an explicit, Windows specific call to close the handle The recommendation is currently to do ::CloseHandle(h.Take()); which is less portable. Review URL: http://codereview.chromium.org/13780 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6883 0039d316-1c4b-4281-b951-d872f2087c98
* ...agl@chromium.org2008-12-121-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6872 0039d316-1c4b-4281-b951-d872f2087c98
* ...agl@chromium.org2008-12-121-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6869 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DCHECKS from official builds.rvargas@google.com2008-12-111-2/+60
| | | | | | | | | | | | | | | We keep the current behavior for regular builds: - debug: DCHECKS enabled. - release: DCHECKS present but inactive; can be activated through the command line. Now we add a new behavior for official builds: - dchecks optimized away. B=4555 Review URL: http://codereview.chromium.org/13231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6830 0039d316-1c4b-4281-b951-d872f2087c98
* Build a few more files on the Mac:mark@chromium.org2008-12-111-0/+6
| | | | | | | | | | | | | - base/watchdog.cc - base/watchdog_unittests.cc - net/base/directory_lister.cc - net/base/directory_lister_unittest.cc - net/base/filter_unittest.cc - net/http/http_auth_cache_unittest.cc - net/http/http_util_unittest.cc Review URL: http://codereview.chromium.org/13804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6829 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ViewHandle to NativeView et al.agl@chromium.org2008-12-111-12/+21
| | | | | | | | | | | ViewHandle is a very unfortunate name when we actually start dealing with views, so we are renaming the cross-platform typedefs to make it clear that they refer to platform specific native UI elements. Review URL: http://codereview.chromium.org/13754 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6826 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6815.phajdan.jr@chromium.org2008-12-114-8/+5
| | | | | | Review URL: http://codereview.chromium.org/14006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6816 0039d316-1c4b-4281-b951-d872f2087c98
* Port flush_cache tool and perf_tests.phajdan.jr@chromium.org2008-12-114-5/+8
| | | | | | | BUG=4160,4263 Review URL: http://codereview.chromium.org/9639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6815 0039d316-1c4b-4281-b951-d872f2087c98
* Improve sleep resolution in process_util_linux.phajdan.jr@chromium.org2008-12-111-2/+2
| | | | | | Review URL: http://codereview.chromium.org/13750 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6814 0039d316-1c4b-4281-b951-d872f2087c98
* We need to loop on waiting as there are plenty of reasons why it might not take.avi@google.com2008-12-111-2/+6
| | | | | | Review URL: http://codereview.chromium.org/14002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6813 0039d316-1c4b-4281-b951-d872f2087c98
* Don't require tlslite to be installed, just use what's in the treemark@chromium.org2008-12-111-1/+5
| | | | | | Review URL: http://codereview.chromium.org/13745 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6794 0039d316-1c4b-4281-b951-d872f2087c98
* Move file enumeration to filepaths.avi@google.com2008-12-116-60/+78
| | | | | | Review URL: http://codereview.chromium.org/13315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6784 0039d316-1c4b-4281-b951-d872f2087c98
* Added std::string to Value via Set/GetString overloading.scherkus@chromium.org2008-12-113-9/+99
| | | | | | | | | | All input is converted to UTF-8. Output is converted back to wide during std::wstring version of GetString(). This is part one of some more patches to come where I switch clients over to UTF-8 strings. Review URL: http://codereview.chromium.org/13230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6768 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Added std::string to Value via Set/GetString overloading."scherkus@chromium.org2008-12-103-91/+10
| | | | | | Review URL: http://codereview.chromium.org/13358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6747 0039d316-1c4b-4281-b951-d872f2087c98
* Added std::string to Value via Set/GetString overloading.scherkus@chromium.org2008-12-103-10/+91
| | | | | | | | | | All input is converted to UTF-8. Output is converted back to wide during std::wstring version of GetString(). This is part one of some more patches to come where I switch clients over to UTF-8 strings. Review URL: http://codereview.chromium.org/13230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6740 0039d316-1c4b-4281-b951-d872f2087c98
* Load the Ahem font from the source tree when not running bundled, formark@chromium.org2008-12-102-0/+21
| | | | | | | test_shell_tests. Review URL: http://codereview.chromium.org/13719 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6738 0039d316-1c4b-4281-b951-d872f2087c98
* Move DISALLOW_COPY_AND_ASSIGN(RefCountedThreadSafe<T>) to private section.tim@chromium.org2008-12-101-0/+1
| | | | | | | | | | | | I hope this is as innocent as it seems, but the presence of the "subtle" namespace freaks me out. Given that everything built, I doubt this was affecting anything because if it were somehow abused moving this to private should have generated compilation errors. In any event, smack me if I'm missing something "subtley" obvious or should try something else (besides running tests). Review URL: http://codereview.chromium.org/13219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6715 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up ipc tests on POSIX.jeremy@chromium.org2008-12-091-0/+15
| | | | | | Review URL: http://codereview.chromium.org/13158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6634 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup of the path service. (With some extra utilities to be used later.)avi@google.com2008-12-097-11/+88
| | | | | | Review URL: http://codereview.chromium.org/13260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6584 0039d316-1c4b-4281-b951-d872f2087c98
* * Add timeout support to POSIX WaitForSingleProcess()jeremy@chromium.org2008-12-081-5/+42
| | | | | | | | * Unify Linux & Mac implementations of WaitForSingleProcess() Review URL: http://codereview.chromium.org/12969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6526 0039d316-1c4b-4281-b951-d872f2087c98
* Add FD watching support to message_pump_libevent.jeremy@chromium.org2008-12-084-14/+84
| | | | | | | | This CL goes along the same lines as the WatchSocket code, but we really need better encapsulation for this class in generel. Review URL: http://codereview.chromium.org/13129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6513 0039d316-1c4b-4281-b951-d872f2087c98
* Make FilePath::Append accept FilePath parameter. Patch by Paweł Hajdan jrmark@chromium.org2008-12-084-41/+72
| | | | | | | | | <phajdan.jr@gmail.com> http://codereview.chromium.org/12907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6511 0039d316-1c4b-4281-b951-d872f2087c98
* Third time's a charm?dkegel@google.com2008-12-071-2/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix part of http://code.google.com/p/chromium/issues/detail?id=4510 and improve https support in test shell on linux. This is the same as the earlier ssl cert cl (see http://codereview.chromium.org/11249), but with the certs moved so net can use them without reaching over into chrome's pants and causing test failure on the 'modules' Windows build server, which is set up to test net and base but not chrome. For this to pass, we will need to install the certs on the windows module and try servers. (And make sure tlslite is present.) (A later CL will finish implementing SSLInfo for Linux, and probably reference net/base/ssl_test_util.cc from all three vcproj files that need it, even though that's ugly, because that's less ugly that referencing it from net.lib's vcproj.) Review URL: http://codereview.chromium.org/12930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6495 0039d316-1c4b-4281-b951-d872f2087c98
* Add error messages to JSONReader and friends. This required a bit of ↵aa@chromium.org2008-12-054-79/+271
| | | | | | | | refactoring to do cleanly. This CL doesn't actually use this capability anywhere except for unit tests. I will add that in a future CL. Review URL: http://codereview.chromium.org/13169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6459 0039d316-1c4b-4281-b951-d872f2087c98
* changelist for estade readability review.estade@chromium.org2008-12-053-94/+105
| | | | | | | submitted changelist: http://codereview.chromium.org/9154 Review URL: http://codereview.chromium.org/12605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6457 0039d316-1c4b-4281-b951-d872f2087c98
* * Add timeout support to POSIX WaitForSingleProcess()jeremy@chromium.org2008-12-053-14/+19
| | | | | | | | * Unify Linux & Mac implementations of WaitForSingleProcess() Review URL: http://codereview.chromium.org/12969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6416 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of kPathSeparator on windows. Port some wstring function to take ↵estade@chromium.org2008-12-044-141/+142
| | | | | | | | FilePaths. Re-enable relevant posix unit tests. Review URL: http://codereview.chromium.org/12893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6387 0039d316-1c4b-4281-b951-d872f2087c98
* Changed svn:eol-style of all .sln and .vcproj files to CRLFscherkus@chromium.org2008-12-044-1727/+1727
| | | | | | Review URL: http://codereview.chromium.org/13133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
* Backing out r6315 due to DirectoryWatcherTest.SubDir (base_unittests) failuremark@chromium.org2008-12-034-59/+40
| | | | | | | (again) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6316 0039d316-1c4b-4281-b951-d872f2087c98
* Make FilePath::Append accept FilePath parameter. Patch by Paweł Hajdan jrmark@chromium.org2008-12-034-40/+59
| | | | | | | | | <phajdan.jr@gmail.com> http://codereview.chromium.org/12907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6315 0039d316-1c4b-4281-b951-d872f2087c98
* Fix new include path of skia_utils.brettw@google.com2008-12-031-1/+1
| | | | | | Review URL: http://codereview.chromium.org/12916 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6309 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx/skia_util to skia/ext/skia_util_win.brettw@google.com2008-12-034-141/+0
| | | | | | | In a later pass, I will separate off the cross-platform part of this file into skia/ext/skia_util (only one function). Review URL: http://codereview.chromium.org/13101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6306 0039d316-1c4b-4281-b951-d872f2087c98
* Backing out r6299 due to DirectoryWatcherTest.SubDir (base_unittests) failuremark@chromium.org2008-12-033-57/+38
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6304 0039d316-1c4b-4281-b951-d872f2087c98
* Add Singleton traits for a "leaky singleton" - one that doesmbelshe@google.com2008-12-031-0/+10
| | | | | | | | not clean up at exit. Review URL: http://codereview.chromium.org/13069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6303 0039d316-1c4b-4281-b951-d872f2087c98
* Move skia_utils_mac from base/gfx to skia/ext.brettw@google.com2008-12-033-140/+0
| | | | | | Review URL: http://codereview.chromium.org/12911 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6302 0039d316-1c4b-4281-b951-d872f2087c98
* Make FilePath::Append accept FilePath parameter. Patch by Paweł Hajdan jrmark@chromium.org2008-12-033-38/+57
| | | | | | | | | <phajdan.jr@gmail.com> http://codereview.chromium.org/12907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6299 0039d316-1c4b-4281-b951-d872f2087c98
* Add skia_utils_mac to the base_gfx targetmark@chromium.org2008-12-031-2/+4
| | | | | | Review URL: http://codereview.chromium.org/12909 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6295 0039d316-1c4b-4281-b951-d872f2087c98
* Put back skia_utils into the build. This will be the next step (I didn't ↵brettw@google.com2008-12-031-3/+4
| | | | | | | | move the file yet). Review URL: http://codereview.chromium.org/13097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6293 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the base unittests in scons.brettw@google.com2008-12-031-2/+0
| | | | | | Review URL: http://codereview.chromium.org/12905 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6292 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver and image_operations from base/gfx to skia/ext. This is justbrettw@google.com2008-12-0311-1297/+0
| | | | | | | | like my previous change except does no namespace renaming and doesn't touch skia_utils. Review URL: http://codereview.chromium.org/13080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6290 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my skia file moves because of layout test failures.brettw@google.com2008-12-0317-6/+1561
| | | | | | Review URL: http://codereview.chromium.org/12892 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6266 0039d316-1c4b-4281-b951-d872f2087c98
* Make WordIterator and Snippet::MatchPositions use size_t instead of int for ↵pkasting@chromium.org2008-12-032-9/+6
| | | | | | | | offsets into strings. This avoids some casts. I also added a typedef for Snippet::MatchPosition which cleans up a bit of the calling code a little. Review URL: http://codereview.chromium.org/13064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6260 0039d316-1c4b-4281-b951-d872f2087c98
* Redo fix from yesterday.mbelshe@google.com2008-12-022-6/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Post Mortem on why yesterday's fix was bogus: The motivation for this change was because a separate CL had a OneShotTimer<> as part of a Singleton class. The Singleton is cleaned up in the AtExit manager, which currently runs after the MessageLoop is destroyed. The following sequence left a dangling pointer: 1) Start a OneShotTimer - Creates a task and registers on the MessageLoop 2) Destroy MessageLoop (this deletes all Pending Tasks) 3) Destroy your OneShotTimer - Tries to reference a dangling pointer for the already-deleted task. The fix was to modify the Task such that at destruction it would zero-out the wrapper's pointer to the Task. Now step 3 would not reference a bogus pointer. Unfortunately, the fix is broken. The timers work by having a wrapper Timer class (BaseTimer_Helper) and a Task. The Task has a pointer back to its wrapper and the wrapper has a pointer to the task. For the case where a timer is re-started from within its Run() loop, things fail: 1) Start a RepeatingTimer 2) Timer fires via the MessageLoop MessageLoop calls Run() 3) Run() restarts the timer, which creates a new Task but reuses the same BaseTimer_Helper. BaseTimer_Helper's timer pointer now points to the NEW timer 4) The MessageLoop destroys the Task The new code zeroes out the task pointer in the BaseTimer_Helper, breaking the newly restarted timer. This fix is the same as yesterday's fix, except: 1) More comments 2) Added extra check at line 169. Don't reset the Task pointer when destroying the Task if the Timer does not point to the Task being destroyed. I'm confident, but not 100% positive that this fixes the problem. I did reproduce *something* using PageHeap which now seems to be gone, but I can't quite confirm. Review URL: http://codereview.chromium.org/13067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6251 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build bustage by syncing to new file locations.brettw@google.com2008-12-021-10/+0
| | | | | | Review URL: http://codereview.chromium.org/13068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6250 0039d316-1c4b-4281-b951-d872f2087c98
* Delete files from base unittests that I moved to skia.brettw@google.com2008-12-021-2/+0
| | | | | | Review URL: http://codereview.chromium.org/13066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6249 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver, image_operations, and skia_utils from base/gfx to skia/ext.brettw@google.com2008-12-0215-1549/+6
| | | | | | | | | | | This changes the namespace in those files from "gfx" to "skia". I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win. There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted. Review URL: http://codereview.chromium.org/12842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6248 0039d316-1c4b-4281-b951-d872f2087c98
* Quick touchup requested by revieweravi@google.com2008-12-021-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6238 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r6233, need to move the cert, there is a policy against dkegel@google.com2008-12-021-47/+2
| | | | | | | | net depending on chrome Review URL: http://codereview.chromium.org/13059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6237 0039d316-1c4b-4281-b951-d872f2087c98
* For http://code.google.com/p/chromium/issues/detail?id=4510dkegel@google.com2008-12-021-2/+47
| | | | | | | | | | | | | | | | | | | Extract some UI SSL test code into new class SSLTestUtil to avoid duplication. Point nss at root certs so test_shell can talk to mail.google.com without warnings. Support ciphers needed to talk to testserver.py. Load temporary testing cert needed to run unit tests. Implement part of GetSSLInfo. Change URL in developer error message to point to chromium.org. Re-enable url_request_unittest.cc, which seems to have been disabled by mistake. Later changesets will implement x509 certificates for nss, finish GetSSLInfo support, and update chrome/browser/ssl_uitest.cc to use SSLTestUtil. Earlier version was committed as r6063, but was rolled back. Review URL: http://codereview.chromium.org/11249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6233 0039d316-1c4b-4281-b951-d872f2087c98
* * Cleanup: move base/platform_test.h -> testing/jeremy@chromium.org2008-12-0211-66/+8
| | | | | | | | * Add support for "Debug On Start" switch to MultiprocessTest::SpawnChild Review URL: http://codereview.chromium.org/13052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6227 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 05:41:51 +0000