summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* SCons renaming updates for base, net and googleurl:sgk@google.com2008-10-218-437/+487
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Rename SConscript files to {module}.scons or {moduel}_lib.scons, depending on the primary target involved. * Separate targets into individual *.scons files, with one construction environment (named "env") per *.scons file. * Add using_{module}.scons files (like .vsprops) that will be used by other modules to add CPPDEFINES, CPPPATH, LIBS and LIBPATH values. * Update other modules' *.scons files to use the new using_{module}.scons files (using a temporary one-liner idiom until we have the ApplySConscript() method from the Hammer modules). * Use the idiom of removing to-be-ported files from the master list, so they can be simply deleted from the to-be-ported list as they get ported in the future, instead of having to shuffle entries between lists. * Use $OBJ_ROOT instead of hard-coded '#/$BUILD_TYPE/' for the $*_DIR variables. * Add a addRepository() call mapping build/ to $TARGET_ROOT/googleurl, so its $OBJ_ROOT value can look like the others'. * Formatting changes, primarily modifying indentation to conform to style guidelines. * Fix copyright headers in some third_party/* modules previously overlooked. * Add rudimentary __doc__ strings, setting up for a future ability to generate meaningful documentation. Review URL: http://codereview.chromium.org/7807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3675 0039d316-1c4b-4281-b951-d872f2087c98
* Build SkGraphicsContext under Linuxerg@google.com2008-10-212-0/+7
| | | | | | | Review URL: http://codereview.chromium.org/8019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3671 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another crasher in Spell Checker related to file IO.sidchat@google.com2008-10-211-0/+2
| | | | | | | Issue=3039 Review URL: http://codereview.chromium.org/7528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3659 0039d316-1c4b-4281-b951-d872f2087c98
* Call GdiAlphaBlend directly instead of the AlphaBlend wrapper in ↵deanm@chromium.org2008-10-213-20/+21
| | | | | | | | msimg32.dll. The wrapper does a few additional santity checks, which I presume GdiAlphaBlend will have to handle anyway. This means we don't depend on msimg32.dll anymore. Review URL: http://codereview.chromium.org/7813 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3656 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back switch to hammer patterns again.bradnelson@chromium.org2008-10-202-18/+11
| | | | | | Review URL: http://codereview.chromium.org/7530 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3637 0039d316-1c4b-4281-b951-d872f2087c98
* Modules Linux fixes:sgk@google.com2008-10-201-1/+6
| | | | | | | | | | | | | Construct the $THIRD_PARTY_DIR and $WEBKIT_DIR variables consistently with other $*_DIR variables. Don't execute test scripts from the VariantDir by default; everything isn't installed in the proper place yet. Use the 'build_component' variable from the submodule SConstruct files to restrict how much we build by default (e.g. don't try to build all of webkit if you're only working in base or net). Review URL: http://codereview.chromium.org/7524 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3626 0039d316-1c4b-4281-b951-d872f2087c98
* Include bug reference for r3624.mark@chromium.org2008-10-201-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3625 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ConditionVariableTest.MultiThreadConsumerTest because it'smark@chromium.org2008-10-201-1/+2
| | | | | | | too timing-sensitive. Review URL: http://codereview.chromium.org/7671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3624 0039d316-1c4b-4281-b951-d872f2087c98
* Construct a field trial to see if HIGH or MEDIUM memory model "works better"jar@google.com2008-10-196-4/+246
| | | | | | | | | | | | | | Includes definition of a FieldTrial class to support this. I have thoughts in my head about how this will eventually extend to be controllable via UMA (as well as being able to run tests defined at compile time, as was done in this example. r=mbelshe, mmentovai Review URL: http://codereview.chromium.org/7638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3604 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in new hammer patterns. Restored from rollback change 3578.bradnelson@chromium.org2008-10-182-11/+13
| | | | | | Review URL: http://codereview.chromium.org/7656 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3597 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back CL 3578, discovered hammer.bat had not been updated yet.bradnelson@chromium.org2008-10-182-13/+11
| | | | | | Review URL: http://codereview.chromium.org/7507 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3582 0039d316-1c4b-4281-b951-d872f2087c98
* Applying software construction toolkit patterns in scons build.bradnelson@chromium.org2008-10-172-11/+13
| | | | | | Review URL: http://codereview.chromium.org/6569 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3578 0039d316-1c4b-4281-b951-d872f2087c98
* Remove throttling code from the Browser process and implement throttling in ↵erg@google.com2008-10-171-1/+13
| | | | | | | | | | | | | the Renderer. The previous way of doing throttling was just calling CloseContents() on a window to reject it. But since the Browser is notified about a window opening asynchronously, by the time the CloseContents() sends a message back to the Renderer, a bunch more windows have been opened, leading to memory exhaustion. Instead, make all RenderViews created from a parent RenderView share a counter and start refusing to create RenderViews if too many RV have been created. Every RenderView (except for the first one) is assumed to be an unrequested popup, until notified by the Browser process by either a ViewMsg_DisassociateFromPopupCount message (this RenderView is a new top level page) or a ViewMsg_DisassociatePopup message (this RenderView is a requested popup and therefore shouldn't count against the count.) BUG=3382, 2632 Review URL: http://codereview.chromium.org/7388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3568 0039d316-1c4b-4281-b951-d872f2087c98
* part one of bustage fix - forgot to land this with previous CL. ↵ben@chromium.org2008-10-171-0/+3
| | | | | | http://crbug.com/2186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3553 0039d316-1c4b-4281-b951-d872f2087c98
* Added linux clipboard.estade@chromium.org2008-10-175-6/+179
| | | | | | Review URL: http://codereview.chromium.org/7602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3548 0039d316-1c4b-4281-b951-d872f2087c98
* Add DirectoryWatcher tests to SConscript.evanm@google.com2008-10-171-0/+2
| | | | | | | Review URL: http://codereview.chromium.org/7470 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3505 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DirectoryWatcher class, allowing objects to be notified wheneverevanm@google.com2008-10-175-7/+321
| | | | | | | | a directory's contents change. Review URL: http://codereview.chromium.org/6377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3504 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused shared_event.agl@chromium.org2008-10-166-214/+0
| | | | | | | Review URL: http://codereview.chromium.org/7439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3484 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at fixing image corruption on drag and drop.tc@google.com2008-10-161-2/+1
| | | | | | | | Fix a unittest that needs to specify the size when reading char* data. Review URL: http://codereview.chromium.org/7441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3478 0039d316-1c4b-4281-b951-d872f2087c98
* Make View::SetBounds take a const gfx::Rect& instead of a const CRect&ben@chromium.org2008-10-162-0/+10
| | | | | | | | | | Make View::DidChangeBounds call Layout by default, eliminating this function from most places. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3471 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a bug where we were truncating the last byte of images"tc@google.com2008-10-161-1/+2
| | | | | | | | | | | due to purify regression TBR=sky Review URL: http://codereview.chromium.org/7437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3465 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap some lines that are > 80 columns.tc@google.com2008-10-161-9/+13
| | | | | | Review URL: http://codereview.chromium.org/7158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3453 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we were truncating the last byte of imagestc@google.com2008-10-161-2/+1
| | | | | | | | | | | | | | | dragged from web content. This was caused by using the wrong helper method to create the storage in os_exchange_data. The method GetStorageForString adds an extra null byte to the data that we were removing at the wrong place in the code. BUG=http://crbug.com/2414 TEST=unit_tests still pass; drag an image from a web page and open it in photoshop Review URL: http://codereview.chromium.org/7372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix FileEnumerator (win) for non-recursive, directory-only enumerations.tim@chromium.org2008-10-162-4/+9
| | | | | | | | It previously only actually returned directories for recursive traversals. Review URL: http://codereview.chromium.org/7157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3450 0039d316-1c4b-4281-b951-d872f2087c98
* Store the command line in a more convenient format on non-windows platforms.estade@chromium.org2008-10-153-23/+103
| | | | | | Review URL: http://codereview.chromium.org/7249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3426 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetPreferredSize from:beng@google.com2008-10-151-0/+5
| | | | | | | | | | | | | | | | | void GetPreferredSize(CSize* out); to: gfx::Size GetPreferredSize(); .. and update some other places to use gfx::Size as well. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3400 0039d316-1c4b-4281-b951-d872f2087c98
* get webframe_impl.cc to compile on linuxtc@google.com2008-10-144-0/+32
| | | | | | | | | Includes changes from http://codereview.chromium.org/7244 by icefox (Torchmobile Inc.) Review URL: http://codereview.chromium.org/7319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3366 0039d316-1c4b-4281-b951-d872f2087c98
* Change all ConvertPointTo* methods to use gfx::Point instead of CPoint.ben@chromium.org2008-10-141-0/+5
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3365 0039d316-1c4b-4281-b951-d872f2087c98
* Port parts of base/process_util to Linux.evanm@google.com2008-10-147-4/+136
| | | | | | | | Review URL: http://codereview.chromium.org/6492 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3363 0039d316-1c4b-4281-b951-d872f2087c98
* Replace View::GetBounds(CRect* bounds) const; with gfx::Rect bounds() const. ben@chromium.org2008-10-141-0/+5
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3348 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up idletimer unittest on Mac port.jeremy@chromium.org2008-10-134-38/+71
| | | | | | Review URL: http://codereview.chromium.org/7243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3328 0039d316-1c4b-4281-b951-d872f2087c98
* Add a templatized scoped GDI handle object. Use this to implement ↵ben@chromium.org2008-10-131-37/+26
| | | | | | | | ScopedBitmap and ScopedHRGN. Review URL: http://codereview.chromium.org/7275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3305 0039d316-1c4b-4281-b951-d872f2087c98
* Basic GTK test shell: links in the SConscript and brings up a window with ↵evanm@google.com2008-10-131-1/+7
| | | | | | | | | nonfunctioning UI. Review URL: http://codereview.chromium.org/2983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3299 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in command line unit test.estade@chromium.org2008-10-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3246 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds prompting for dangerous types of files (executable) when they ↵jcampan@chromium.org2008-10-106-2/+89
| | | | | | | | | | | | | | | | are automatically downloaded. The file is saved with a temporary name (dangerous_download_xxxx.download) in the download directory and the user is presented (in the download shelf and the download tab if opened) with a warning message and buttons to save/discard the download. If discarded the download is removed (and its file deleted). If saved, download goes as usual. Dangerous downloads not confirmed by the user are deleted on shutdown. TEST=Download a small exe file, try using the save/discard button from the download shelf and from the download tab (the intent is that the file has been entirely downloaded by the time you take action). Try again with a slow/big download (that time the download is expected not to be finished when approved/discarded). Review URL: http://codereview.chromium.org/6043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3228 0039d316-1c4b-4281-b951-d872f2087c98
* Add a way to register for completion-ports based async operations to be handledrvargas@google.com2008-10-095-7/+223
| | | | | | | | | | | through the windows version of the message pump. As a first step, actual IO processing is still performed using WatchObject instead of using completion ports. Review URL: http://codereview.chromium.org/1950 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3157 0039d316-1c4b-4281-b951-d872f2087c98
* base\gfx file changes from r3137: + gdi_util.cc, - bitmap_header.ccsgk@google.com2008-10-091-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3150 0039d316-1c4b-4281-b951-d872f2087c98
* Patch by Thatcher Ulrich <tulrich@google.com>.ojan@google.com2008-10-0910-24/+176
| | | | | | | | | | | | | | | Implement "iframe shim" behavior for windowed plugins. In FF and IE on windows, iframes are implemented as native HWNDs. This has the side effect that iframes display on top of windowed plugins. This side effect has long been known as a workaround for allowing HTML elements to appear above plugin content. BUG=1788 Review URL: http://codereview.chromium.org/7032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3137 0039d316-1c4b-4281-b951-d872f2087c98
* Comments out the DCHECK in lock as it causes failures.sky@google.com2008-10-091-1/+3
| | | | | | | | TBR=jar TEST=none Review URL: http://codereview.chromium.org/6604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3129 0039d316-1c4b-4281-b951-d872f2087c98
* Changes BookmarkModel to not grab the same lock twice.sky@google.com2008-10-091-2/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3127 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow recursive locking via the Lock classjar@google.com2008-10-092-113/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | Change contract so that Posix locks (which deadlock on attempts by a single thread to acquire a mutex recursively) and windows critical sections can both be used to implement the Lock() cass, by disallowing recursive locking. In DEBUG mode only, we watch for (now) illegal use of recursive locking. Also remove a pile of cruft that has built up in this file as various folks have re-re-refactored and moved around code. Note that Window's condition variable implementation still uses the AutoUnlock() helper class, but now the implementation (sans nested locking) is very trivial. Posix will probably use their own CV implementation. r=mbelshe Review URL: http://codereview.chromium.org/5630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3105 0039d316-1c4b-4281-b951-d872f2087c98
* remove unneeded webkit_glue:: and wrap windows functions in ifdefserg@google.com2008-10-081-1/+3
| | | | | | | | Review URL: http://codereview.chromium.org/6413 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3065 0039d316-1c4b-4281-b951-d872f2087c98
* Change the font search order to try Lucida Sans Unicode before Arial Unicode ↵jungshik@google.com2008-10-081-1/+1
| | | | | | | | | | | | | | | | | | MS because the former is available on Windows XP or later while the latter is only available with MS Office installed. This is partly to make font-dependent layout test results 'invariant' with or without Arial Unicode MS installed. Eventually, we may want to make those tests more robust against the font availability by removing some Unicode characters not commonly available. BUG=2304 TEST=pass the layout tests affected Review URL: http://codereview.chromium.org/6495 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3062 0039d316-1c4b-4281-b951-d872f2087c98
* Make Mac clipboard code tolerant of nil clipboard without crashing. Add amark@chromium.org2008-10-081-30/+36
| | | | | | | DCHECK to catch this case, and clean up some of the clipboard code. Review URL: http://codereview.chromium.org/6580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3051 0039d316-1c4b-4281-b951-d872f2087c98
* Provide converters to and from NSString* in sys_string_conversionsmark@chromium.org2008-10-085-8/+77
| | | | | | Review URL: http://codereview.chromium.org/6355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3050 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo I noticed when looking at object tracking. The wrong argument wasbrettw@google.com2008-10-081-1/+1
| | | | | | | given to the printf. Review URL: http://codereview.chromium.org/6356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3041 0039d316-1c4b-4281-b951-d872f2087c98
* Klocwork bug. Checking the wrong variable.cpu@google.com2008-10-081-7/+12
| | | | | | | | BUG = 3103 Review URL: http://codereview.chromium.org/6453 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3030 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some problems with machine level install.kuchhal@chromium.org2008-10-082-0/+11
| | | | | | | | BUG=2380 Review URL: http://codereview.chromium.org/6402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3015 0039d316-1c4b-4281-b951-d872f2087c98
* Add Mac BeingDebugged implementationmark@chromium.org2008-10-081-7/+33
| | | | | | Review URL: http://codereview.chromium.org/6582 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3009 0039d316-1c4b-4281-b951-d872f2087c98
* backing out debugging changes now that we know the problem.pinkerton@google.com2008-10-081-5/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3006 0039d316-1c4b-4281-b951-d872f2087c98