summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Cherrypick of r34036 to make merge at r34474 build.viettrungluu@chromium.org2009-12-142-0/+48
| | | | | | | | | | | | | | | | | | Merging only changes to base/logging.* (for RAW_LOG()/RAW_CHECK()), and NOT changes to chrome/browser/browser_main.cc. Original CL description: Make POSIX SIGTERM/SIGINT/SIGHUP handler async signal safe. * Don't use LOG/CHECK. Replace with RAW_LOG/DCHECK (newly added to logging.h) * Don't directly post a task to the UI loop. Write to a magic pipe. Read this from a separate thread which will post to a task to the UI loop. BUG=http://crbug.com/29240 Review URL: http://codereview.chromium.org/460094 TBR=viettrungluu@chromium.org,mark@chromium.org,willchan@chromium.org Review URL: http://codereview.chromium.org/501004 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34499 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32972 - linux: fix a warning in the process_util unittestevan@chromium.org2009-12-101-4/+5
| | | | | | | | | | | | | | | | (This fixes a compile failure.) Original review: http://codereview.chromium.org/422003 BUG=none TEST=compiles on gcc 4.4 Review URL: http://codereview.chromium.org/431034 TBR=vandebo@chromium.org Review URL: http://codereview.chromium.org/487015 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34275 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32483 - Remove the unused ProcessFilter destructor.mmoss@google.com2009-11-301-1/+0
| | | | | | | | | | | | | | Adding some code elsewhere was causing pure call errors related to this code, but only for Release builds on gcc 4.2.4. My gcc 4.4.1 computer was fine. I know better than to claim it's a compiler bug, but this destructor is unused anyway so this change is harmless. Review URL: http://codereview.chromium.org/402080 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/449032 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33361 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32078 - linux: Remove NOTIMPL cluttering test outputmmoss@google.com2009-11-301-1/+0
| | | | | | | | | | | BUG=27222 Review URL: http://codereview.chromium.org/395009 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/455005 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33303 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33162 - For now, let's clear local storage whenever we clear cookies.jorlow@chromium.org2009-11-263-0/+16
| | | | | | | | | | | BUG=28788 TEST="Clear private data..." from the menu, check cookies, and tell it ok. Data in "Local Storage" inside the profile's data dir should be deleted and any open websites that were using that data should no longer be able to see it. Review URL: http://codereview.chromium.org/441012 TBR=jorlow@chromium.org Review URL: http://codereview.chromium.org/440034 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33173 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33132 - Properly detect KDE4 on newer systems (e.g. [K]Ubuntu 9.04).thestig@chromium.org2009-11-251-1/+6
| | | | | | | | | | | BUG=25938 TEST=try to configure proxy settings on KDE4 when $DESKTOP_SESSION=kde, it should work Review URL: http://codereview.chromium.org/427013 TBR=mdm@chromium.org Review URL: http://codereview.chromium.org/444006 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33145 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32701 - Don't do work in the SharedIOBuffer constructor; mal@chromium.org2009-11-251-4/+2
| | | | | | | | | | | | | | | use an Init method instead. This eliminates instances of allocatedbutinvalid SharedIOBuffers. Also clean up some CHECKs and TODOs associated with the bug. The upshot is that we no longer crash in AsyncResourceHandler::OnResponseCompleted() when we can't allocate shared memory. We now crash (properly, I believe) in the renderer process if the shared memory that failed to allocate was the TransportDIB, since the renderer can't communicate with the browser without it. BUG=16371 TEST=none Review URL: http://codereview.chromium.org/391009 TBR=hawk@chromium.org Review URL: http://codereview.chromium.org/437070 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33126 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32854 - Fix environment variables not being used after switching to ↵jam@chromium.org2009-11-232-7/+8
| | | | | | | | | | | | | ChildProcessLauncher. BUG=28602 TEST=verified flash works on Mac Review URL: http://codereview.chromium.org/439005 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/436011 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@32867 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32648 - linux: fix a warning in the process_util unittestvandebo@google.com2009-11-231-1/+4
| | | | | | | Review URL: http://codereview.chromium.org/422003 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@32848 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32395 - For Linux, override malloc and friends so that we can detect ↵vandebo@google.com2009-11-232-1/+193
| | | | | | | | | | | | and then stop on out of memory. BUG=27222 TEST=new base unittests Review URL: http://codereview.chromium.org/391044 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@32847 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32081 - Add another variant of the PrependInteger UMR stack.aa@chromium.org2009-11-211-0/+20
| | | | | | | | | | | | BUG=18795 TBR=idana Review URL: http://codereview.chromium.org/401003 TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/426012 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@32740 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32199 - [Mac/Linux] Fix WordIterator::GetWord() for UTF16 surrogate pairs.shess@chromium.org2009-11-192-0/+63
| | | | | | | | | | | | | | | | | | | For systems where !defined(WCHART_T_IS_UTF16), WordIterator transforms the input into UChar data. But GetWord() was using the resulting offsets as indices into the original string, so it could return incorrect data and/or attempt to index off the end of the input. This changes GetWord() to do do the inverse conversion from Init() for those systems. BUG=27698 TEST=See bug. Review URL: http://codereview.chromium.org/399010 TBR=shess@chromium.org Review URL: http://codereview.chromium.org/414001 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@32527 0039d316-1c4b-4281-b951-d872f2087c98
* Revert changes that moved spellchecker to renderer for 249 branch since ↵estade@chromium.org2009-11-184-48/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | there were some crashes and pulling in the fixes is hard. This reverts: ------------------------------------------------------------------------ r31875 | estade@chromium.org | 2009-11-12 17:36:50 -0800 (Thu, 12 Nov 2009) | 4 lines Use renderer spellchecker for windows. BUG=25677 Review URL: http://codereview.chromium.org/372075 ------------------------------------------------------------------------ r31529 | estade@chromium.org | 2009-11-09 17:33:05 -0800 (Mon, 09 Nov 2009) | 8 lines Couple of prospective fix for memory test flakiness: addref/release the url request context getter appropriately; fix a leak. Passing as a straight pointer without addreffing was copied from the previous spellchecker impl. Using .release() instead of = NULL was a plain old mistake. BUG=none TEST=memory test flakiness goes away hopefully? Review URL: http://codereview.chromium.org/379015 ------------------------------------------------------------------------ r31199 | estade@chromium.org | 2009-11-05 19:05:46 -0800 (Thu, 05 Nov 2009) | 28 lines Move the spellchecker to the renderer. The motivation is that this removes the sync IPC on every call to the spellchecker. Also, currently we spellcheck in the IO thread, which frequently needs to go to disk (in particular, the entire spellcheck dictionary starts paged out), so this will block just the single renderer when that happens, rather than the whole IO thread. This breaks the SpellChecker class into two new classes. 1) On the browser side, we have SpellCheckHost. This class handles browser-wide tasks, such as keeping the custom words list in sync with the on-disk custom words dictionary, downloading missing dictionaries, etc. On Posix, it also opens the bdic file since the renderer isn't allowed to open files. SpellCheckHost is created and destroyed on the UI thread. It is initialized on the file thread. 2) On the renderer side, SpellChecker2. This class will one day be renamed SpellChecker. It handles actual checking of the words, memory maps the dictionary file, loads hunspell, etc. There is one SpellChecker2 per RenderThread (hence one per render process). My intention is for this patch to move Linux to this new approach, and follow up with ports for Windows (which will involve passing a dictionary file name rather than a file descriptor through to the renderer) and Mac (which will involve adding sync ViewHost IPC callsfor when the platform spellchecker is enabled). Note that anyone using the platform spellchecker rather than Hunspell will get no benefit out of this refactor. There should be no loss of functionality for Linux (or any other platform) in this patch. The following should all still work: - dictionary is loaded lazily - hunspell is initialized lazily, per renderer - language changes work. - Dynamic downloading of new dictionaries - auto spell correct works (as well as toggling it). - disabling spellcheck works. - custom words work (including adding in one renderer and immediately having it take effect in other renderers, for certain values of "immediate") TODO: - move spellchecker unit tests to test SpellCheck2 - add sync IPC for platform spellchecker; port to Mac - add dictionary location fallback; port to Windows - remove SpellChecker classes from browser/ BUG=25677 Review URL: http://codereview.chromium.org/357003 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@32436 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32264 - Launch processes asynchronously so as not to block the UI ↵jam@chromium.org2009-11-181-4/+2
| | | | | | | | | | | | thread. For now, renderer only, I'll take care of plugin/worker/utility processes in a followup change. (relanding 32203) BUG=6844,27935 Review URL: http://codereview.chromium.org/397031 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/408011 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@32388 0039d316-1c4b-4281-b951-d872f2087c98
* More safe browsing cleanup work:pkasting@chromium.org2009-11-142-0/+25
| | | | | | | | | | | | * Remove |resetting_| from the safe browsing service, it doesn't do anything useful. * Add appropriate locks in a few places in the database that were missing them. * Prevent potential infinite recursion in the database at one spot. BUG=none TEST=none Review URL: http://codereview.chromium.org/391060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31979 0039d316-1c4b-4281-b951-d872f2087c98
* Log warnings, not errors, if we can't fetch memory status forsgk@google.com2009-11-132-6/+9
| | | | | | | | | commit charge reporting. Fix if-blocks around returning 0. BUG=none TEST=none Review URL: http://codereview.chromium.org/386031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31964 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid leaking hash_object_ in SignatureCreator on Windows.dkegel@google.com2009-11-131-1/+0
| | | | | | | | TEST=valgrind wine base_unittests SIgnatureCreatorTest.* BUG=none Review URL: http://codereview.chromium.org/391040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31946 0039d316-1c4b-4281-b951-d872f2087c98
* Split *AndAdjustOffset() functions into their own header, to restore ↵pkasting@chromium.org2009-11-1310-294/+505
| | | | | | | | | | utf_string_conversions.h to a simple, readable state. BUG=4010 TEST=none Review URL: http://codereview.chromium.org/387012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31928 0039d316-1c4b-4281-b951-d872f2087c98
* Use renderer spellchecker for windows.estade@chromium.org2009-11-134-49/+45
| | | | | | | BUG=25677 Review URL: http://codereview.chromium.org/372075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31875 0039d316-1c4b-4281-b951-d872f2087c98
* Print allocation callstacks to LOG(ERROR) rather than std err, since ↵eroman@chromium.org2009-11-121-1/+1
| | | | | | | | otherwise it doesn't show up inline in the log file. Review URL: http://codereview.chromium.org/391029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31822 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure OOM is a killer on the Mac.avi@chromium.org2009-11-123-0/+101
| | | | | | | | | BUG=http://crbug.com/12673 TEST=as in bug Review URL: http://codereview.chromium.org/385054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31819 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Make WatchdogTest.DisarmTest faster by about 2sphajdan.jr@chromium.org2009-11-121-1/+1
| | | | | | | | | | | by really making the alarm instantly go off. TEST=none BUG=none Review URL: http://codereview.chromium.org/377029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31774 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31765 - Experiment: enable TCMalloc on Linux by default.willchan@chromium.org2009-11-122-10/+20
| | | | | | | | | | | | Will revert after looking at the Linux memory bot and perf cycler. TBR=willchan Review URL: http://codereview.chromium.org/386016 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/384074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31769 0039d316-1c4b-4281-b951-d872f2087c98
* Experiment: enable TCMalloc on Linux by default.willchan@chromium.org2009-11-122-20/+10
| | | | | | | | | Will revert after looking at the Linux memory bot and perf cycler. TBR=willchan Review URL: http://codereview.chromium.org/386016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31765 0039d316-1c4b-4281-b951-d872f2087c98
* linux: implement some SysInfo bits to reduce NOTIMPL spewevan@chromium.org2009-11-122-7/+29
| | | | | | | | | | Also added basic tests for these functions. BUG=21732 Review URL: http://codereview.chromium.org/384070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31762 0039d316-1c4b-4281-b951-d872f2087c98
* posix: move mac-specific code into mac-specific fileevan@chromium.org2009-11-122-63/+71
| | | | | | | | No functional change, just cleanup. Review URL: http://codereview.chromium.org/384069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31758 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the memory leak annotations for heap leak checker.willchan@chromium.org2009-11-113-1/+51
| | | | | | | | | | | | | leak_annotations.h provides the ANNOTATE_SCOPED_MEMORY_LEAK macro that can be used for annotating known memory leaks in the tests. Those will be ignored by the heap leak checker. Patch contributed by ramosian.glider@gmail.com. Original review at http://codereview.chromium.org/346038/show Review URL: http://codereview.chromium.org/385049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31721 0039d316-1c4b-4281-b951-d872f2087c98
* linux: TCMalloc-based C++ heap profiler.willchan@chromium.org2009-11-111-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Requires compiling with linux_use_tcmalloc=1. When enabled by --heap-profiler flag in test_shell exposes chromium.HeapProfiler object to JavaScript. The object has three methods: o start() -- starts profiling o dump() -- dumps data accumulated since start() to file named like chromium-YYYY-MM-DD-TS.heap o stop() -- stops profiling. Output can be analyzed by third_party/tcmalloc/tcmalloc/src/pprof. For example: $ third_party/tcmalloc/tcmalloc/src/pprof \ sconsbuild/Release/test_shell \ chromium-2009-11-06-1234567890.heap See http://code.google.com/p/google-perftools/ for details on how to use pprof. Patch contributed by vitalyr@chromium.org. Original review at http://codereview.chromium.org/377010/show. TBR=vitalyr Review URL: http://codereview.chromium.org/390015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31688 0039d316-1c4b-4281-b951-d872f2087c98
* For the immediate milestone, exclude History and Thumbnails from being ↵mrossetti@chromium.org2009-11-113-0/+45
| | | | | | | | | | | backed up by Time Machine. The bug describes appropriate long-term solutions to this problem. BUG=259595 TEST=Launch Chrome. Inspect the following files found in ~/Library/Application Support/Chromium/Default/: a) History, b) History-journal, c) Thumbnails, and d) Thumbnails-journal and verify that they are not being backed up by Time Machine. Review URL: http://codereview.chromium.org/387016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31644 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] ScopedSendingEvent finds NSApp by itself.shess@chromium.org2009-11-102-4/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/385009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31595 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up recent string conversion function changes, part 1: Remove ↵pkasting@chromium.org2009-11-106-256/+39
| | | | | | | | | | | | unnecessary code. Thanks to a change in escape.cc I can basically revert the ICU conversions back to what they used to be; I can also get rid of half the conversions immediately since they aren't used. This does not split out the "adjust" versions of the UTF conversions into their own header/implementation; that's coming in the next patch. BUG=4010 TEST=none Review URL: http://codereview.chromium.org/380007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31533 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Make DirectoryWatcher tests faster by about 15 seconds.phajdan.jr@chromium.org2009-11-091-4/+10
| | | | | | | | | TEST=Covered by base_unittests. BUG=none Review URL: http://codereview.chromium.org/371062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31451 0039d316-1c4b-4281-b951-d872f2087c98
* Expand the purify suppressions for PrivateKeyInfoCodec.willchan@chromium.org2009-11-091-6/+2
| | | | | | Review URL: http://codereview.chromium.org/372062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31439 0039d316-1c4b-4281-b951-d872f2087c98
* More memory stats code cleanup:sgk@chromium.org2009-11-094-0/+111
| | | | | | | | | | | | Move GetSystemCommitCharge() into bsae\process_util*. Kill PrintChromeMemoryUsageInfo(), which was only used by reliability_tests.exe on Windows and whose stats are obsolete. Delete the now-unnecessary chrome\test\perf\mem_usage* files. BUG=none TEST=none Review URL: http://codereview.chromium.org/371025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31423 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NSString conversions to treat a null NSString as a string of length 0, ↵mirandac@chromium.org2009-11-084-1/+28
| | | | | | | | | | | instead of crashing. This allows Cocoa to use null objects as empties, as is its wont, and we only run a check when needed. This CL also removes the now-superfluous checks for null NSStrings from BugReportWindowController. A cursory look through the code shows that there are many places where a check for null precedes a call to an NSString conversion; filed another bug against myself to go through and fix all of these (http://code.google.com/p/chromium/issues/detail?id=27055). Also filed a bug to expand unit tests for NSString conversion methods (http://code.google.com/p/chromium/issues/detail?id=27059). Review URL: http://codereview.chromium.org/371057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31408 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with inline autocomplete and URLs that change length ↵pkasting@chromium.org2009-11-078-409/+720
| | | | | | | | | | | | | | | | | | | | during fixup: * URLs with http auth info, which gets stripped * URLs with IDN hosts * URLs with escaped values that get unescaped In cases like these, we'd inline autocomplete from the wrong locations, highlight the wrong portions of the URL as matches, and sometimes DCHECK() in debug mode. The fix is to track how fixup affects the offsets into the URL we care about. Plumbing this required an enormous number of additions :( There is also a fix here to the URL Fixer Upper, which was obviously modified at some point in the past to use the Parsed components, but without updating the comments or some of the functionality to match. Since this isn't supposed to "fix up" things that aren't simple typos, I removed some code to "fix" bogus ports, which was causing bizarre effects when typing HTTP auth URLs ("http://foo:bar" would be fixed to "http://foo" and then matched for inline autocompletion, which was clearly wrong). This is tested incidentally by one of the new History URL Provider tests (which is how I discovered it). BUG=4010 TEST=Covered by unittests Review URL: http://codereview.chromium.org/372017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31352 0039d316-1c4b-4281-b951-d872f2087c98
* Add 64bit supportgregoryd@google.com2009-11-063-10/+25
| | | | | | | | This CL is part of a larger effort to add support for Native Client on 64-bit Windows. Review URL: http://codereview.chromium.org/360034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31321 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel unused timeout events. Without this change they candkegel@google.com2009-11-061-1/+14
| | | | | | | | | | | | | | accumulate for a while, wasting memory and causing unneeded wakeups. BUG=25641 TEST=green valgrind or heapchecker on net_unittests Previously reviewed as http://codereview.chromium.org/370005/ TBR=timurrrr Review URL: http://codereview.chromium.org/372033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31306 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII.tony@chromium.org2009-11-061-6/+7
| | | | | | | | | | | | BUG=24672 TEST=None Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/296004 Review URL: http://codereview.chromium.org/373013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
* Move the spellchecker to the renderer.estade@chromium.org2009-11-062-12/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The motivation is that this removes the sync IPC on every call to the spellchecker. Also, currently we spellcheck in the IO thread, which frequently needs to go to disk (in particular, the entire spellcheck dictionary starts paged out), so this will block just the single renderer when that happens, rather than the whole IO thread. This breaks the SpellChecker class into two new classes. 1) On the browser side, we have SpellCheckHost. This class handles browser-wide tasks, such as keeping the custom words list in sync with the on-disk custom words dictionary, downloading missing dictionaries, etc. On Posix, it also opens the bdic file since the renderer isn't allowed to open files. SpellCheckHost is created and destroyed on the UI thread. It is initialized on the file thread. 2) On the renderer side, SpellChecker2. This class will one day be renamed SpellChecker. It handles actual checking of the words, memory maps the dictionary file, loads hunspell, etc. There is one SpellChecker2 per RenderThread (hence one per render process). My intention is for this patch to move Linux to this new approach, and follow up with ports for Windows (which will involve passing a dictionary file name rather than a file descriptor through to the renderer) and Mac (which will involve adding sync ViewHost IPC callsfor when the platform spellchecker is enabled). Note that anyone using the platform spellchecker rather than Hunspell will get no benefit out of this refactor. There should be no loss of functionality for Linux (or any other platform) in this patch. The following should all still work: - dictionary is loaded lazily - hunspell is initialized lazily, per renderer - language changes work. - Dynamic downloading of new dictionaries - auto spell correct works (as well as toggling it). - disabling spellcheck works. - custom words work (including adding in one renderer and immediately having it take effect in other renderers, for certain values of "immediate") TODO: - move spellchecker unit tests to test SpellCheck2 - add sync IPC for platform spellchecker; port to Mac - add dictionary location fallback; port to Windows - remove SpellChecker classes from browser/ BUG=25677 Review URL: http://codereview.chromium.org/357003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31199 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implement about:memory.viettrungluu@chromium.org2009-11-056-9/+203
| | | | | | | | | | | | | | | This implements about:memory on Mac. It calls /bin/ps to obtain information about processes (this is Apple's officially supported "API"). Unfortunately, ps provides fairly minimal information (rss and vsize); top is better, but not a stable API -- it has changed greatly between Mac OS 10.5 and 10.6, and moreover the 10.6 version is more limited in its output formatting. BUG=9653 TEST=Go to about:memory under a variety of conditions (with a variety of browsers loaded). Review URL: http://codereview.chromium.org/333008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31168 0039d316-1c4b-4281-b951-d872f2087c98
* Added missing file to fix build.dmaclach@chromium.org2009-11-051-0/+18
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/371002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31141 0039d316-1c4b-4281-b951-d872f2087c98
* First patch in making destructors of refcounted objects private.jam@chromium.org2009-11-059-8/+49
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/360042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31136 0039d316-1c4b-4281-b951-d872f2087c98
* Cleans up our autorelease pool handling by making sure that an autorelease ↵dmaclach@chromium.org2009-11-054-13/+169
| | | | | | | | | | | | | pool isn't created while the app is handling an event sent via -[NSApp sendEvent]. Branches browser/chrome_application_mac into browser/chrome_browser_application and base/chrome_application. Renderers will run as chrome_applications, and browsers will run as chrome_browser_applications. BUG=26418, 25462, 25463, 25465 TEST=1) See bug 25857. 2) Start up. Open 3+ windows. 3)Quit. See bugs for other repro cases. Review URL: http://codereview.chromium.org/345051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31135 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the run time of base_unittests by about 20s by reducing timeouts inphajdan.jr@chromium.org2009-11-052-5/+5
| | | | | | | | | | | | | | | | the following tests: ObserverListThreadSafeTest.CrossThreadObserver ObserverListThreadSafeTest.CrossThreadNotifications ThreadCollisionTest.MTSynchedScopedBookCriticalSectionTest ThreadCollisionTest.MTSynchedScopedRecursiveBookCriticalSectionTest TEST=Covered by base_unittests. BUG=none Review URL: http://codereview.chromium.org/369001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31112 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use /proc/pid/statm to get memory stats when /proc/pid/smaps is ↵thestig@chromium.org2009-11-041-30/+48
| | | | | | | | | | unavailable. BUG=23258 TEST=We get approximate memory usage in about:memory for sandboxed renderers. Review URL: http://codereview.chromium.org/365007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31019 0039d316-1c4b-4281-b951-d872f2087c98
* Implement FormStructure and an initial method, EncodeUploadRequest. This ↵jhawkins@chromium.org2009-11-044-0/+285
| | | | | | | | | | also adds SHA1HashString, a utility method to get the SHA-1 hash of an input string, with appropriate unit tests. BUG=18201 TEST=none Review URL: http://codereview.chromium.org/355003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30980 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow the browser to stay above a modal plugin window (Mac)stuartmorgan@chromium.org2009-11-042-0/+13
| | | | | | | | | | | There's a flicker of the modal window being hidden then coming forward again, and the menus still work, so we'll most likely have fake the modality more aggressively at some point. This gets us the basic infrastructure though, and solves the severe usability problem. BUG=20798 TEST=Open a modal plugin window (e.g., Gmail upload). Switch to another app, then back to Chrome; the plugin window should come to the front. Review URL: http://codereview.chromium.org/355021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30965 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for getting the real process id from within the suid sandbox. ↵thestig@chromium.org2009-11-041-0/+2
| | | | | | | | | | | | | | | | | | The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox. While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox. Original review: http://codereview.chromium.org/262020 This is try 2 - initialize the sandbox host and zygote for InProcessBrowserTest. TBR=agl BUG=20012, 20714, 23072 TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them. Review URL: http://codereview.chromium.org/361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30948 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2009-11-044-1/+60
| | | | | | | | | | | | | | | Gets find bar animation/clipping to work on views/gtk. The only difference between this and the first version is fixing an include in extension_host that was triggering mac to build views, as well as an extraneous SetSlideDuration I had used for testing. BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/342116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30942 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-12-28 02:02:08 +0000