summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Adds baselines for windows 7jamesr@chromium.org2009-12-151-9/+17
| | | | | | | | | TEST=run base_unittests.exe on a Windows 7 machine BUG=none Review URL: http://codereview.chromium.org/466058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34623 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a string leak in GetFunctionPointerFromNativeLibrarystuartmorgan@chromium.org2009-12-151-3/+4
| | | | | | | | | BUG=none TEST=Mac WebKit valgrind Review URL: http://codereview.chromium.org/501031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34616 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the example for weak_ptr so it is correctbrettw@chromium.org2009-12-151-2/+2
| | | | | | | | | BUG=NONE TEST=NONE Patch by dhg@chromium.org Original review: http://codereview.chromium.org/476010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34598 0039d316-1c4b-4281-b951-d872f2087c98
* Fix treejar@chromium.org2009-12-151-1/+2
| | | | | | | | | | Avoid carrying across planned to leak flag, which will cause a DCHECK in the browser process. tbr=mbelshe,raman.tenneti Review URL: http://codereview.chromium.org/503016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34575 0039d316-1c4b-4281-b951-d872f2087c98
* Deserialize UMA flag on histograms moving from renderer to browsersjar@chromium.org2009-12-151-0/+1
| | | | | | | | | | | | | | During a recent migration, we forgot to properly resurrect the flags in a histogram as they are carried from the renderer processes into the browser process. Since the flag is the critical marker that identifies which histograms to upload via UMA, this caused renderer histograms to not get reported. BUG=30478 r=raman.tenetti,mbelshe Review URL: http://codereview.chromium.org/505006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34574 0039d316-1c4b-4281-b951-d872f2087c98
* Make ProcessWatcher use kqueues on Mac.jeremy@chromium.org2009-12-155-1/+55
| | | | | | | | | | | | | * Port ProcessWatcher::EnsureProcessTerminated() to kqueue() APIs on OS X. * Make ProcessWatcher::EnsureProcessGetsReaped() Linux-only, since it's only used there. * Add a unit test. BUG=12731 TEST=Open Chrome/Mac, open and close a few tabs. Processes shouldn't stay around. Review URL: http://codereview.chromium.org/496007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34547 0039d316-1c4b-4281-b951-d872f2087c98
* Use ASSERT_EQ instead of EXPECT_EQ to avoid accessing invalid index in the ↵hayato@chromium.org2009-12-151-12/+12
| | | | | | | | | | | following tests. TEST=FileDescriptorsShuffleTest in base_unitest BUG=None Review URL: http://codereview.chromium.org/486029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34542 0039d316-1c4b-4281-b951-d872f2087c98
* Try 2: Completely redo how themes are stored on disk and processed at ↵erg@google.com2009-12-145-28/+135
| | | | | | | | | | | | | | | | | install time. Same as previous patch, except we now have a BrowserThemeProvider::GetDefaultDisplayProperty() so we don't have UMRs in ntp_resource_cache.cc. BUG=24493,21121 TEST=All the new unit tests pass. All the complex theme startup tests go faster. Previous Review URL: http://codereview.chromium.org/460050 Review URL: http://codereview.chromium.org/499004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34486 0039d316-1c4b-4281-b951-d872f2087c98
* Use namespace in mac_util_unittest.hayato@chromium.org2009-12-141-14/+21
| | | | | | | | | BUG=None TEST=MacUtilTest in base_unittest Review URL: http://codereview.chromium.org/491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34455 0039d316-1c4b-4281-b951-d872f2087c98
* Made chrome_test to fail when the test itself failed.oshima@chromium.org2009-12-121-0/+3
| | | | | | | | | | | Exclude tests that does not pass on valgrind BUG=29578,29579,29853,29586,29587,29592,29598 TEST=run valgrind test Review URL: http://codereview.chromium.org/466047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34403 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Completely redo how themes are stored on disk and processed at installerg@google.com2009-12-115-135/+28
| | | | | | | | | | time," as it fails valgrind tests. This reverts commit 86faccd1028937a69ccc718718fd48c06c0cd471 (r34379). Review URL: http://codereview.chromium.org/490025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34385 0039d316-1c4b-4281-b951-d872f2087c98
* Improve unit tests to verify that directories are listed before files in ↵vandebo@chromium.org2009-12-113-0/+11
| | | | | | | | | | | | | file:/// urls. And fix current regression. BUG=28420 TEST=improved unit tests Review URL: http://codereview.chromium.org/492015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34382 0039d316-1c4b-4281-b951-d872f2087c98
* Completely redo how themes are stored on disk and processed at install time.erg@google.com2009-12-115-28/+135
| | | | | | | | | | | | | | | | | | | | Rewrites most of BrowserThemeProvider and adds a new class BrowserThemePack. BrowserThemePack takes all the logic of generating resources out of the BrowserThemeProvider, does all of them at theme install time (previously, we lazily generated all the button images and a good number of colors, which muddled logic quite a bit), and then writes all the data out into an mmap()able file to speed startup when a theme is installed. In addition, this changes how the GtkThemeProvider works. The GtkThemeProvider now generates all of its images lazily and doesn't reach into the implementation details of BrowserThemeProvider as it used to. BUG=24493,21121 TEST=All the new unit tests pass. All the complex theme startup tests go faster. Review URL: http://codereview.chromium.org/460050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34379 0039d316-1c4b-4281-b951-d872f2087c98
* Force failing CHECK/DCHECKs to end the process on Windows.timurrrr@chromium.org2009-12-102-15/+17
| | | | | | | | | | | | | The current implementation of Windows-only hook simply calls FAIL. According to http://code.google.com/p/googletest/issues/list?cursor=234 it is a misuse of FAIL macros (it may not shut down the process). As a result, it was impossible to write death tests on windows. BUG=24885 Review URL: http://codereview.chromium.org/482001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34273 0039d316-1c4b-4281-b951-d872f2087c98
* Separate ProxyResolverMac and ProxyConfigServiceMac into their own files and ↵hayato@chromium.org2009-12-103-0/+47
| | | | | | | | | | extract common utility functions into other files. TEST=trybot and MacUtilTest in base_unittests BUG=27310 Review URL: http://codereview.chromium.org/463028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34243 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Adjust /proc/pid/oom_adj to sacrifice plugin and renderer processes ↵thestig@chromium.org2009-12-102-2/+23
| | | | | | | | | | to the OOM killer. BUG=29752 TEST=During out of memory conditions, Linux kernel picks a plugin/renderer over the browser process. Review URL: http://codereview.chromium.org/467058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34222 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the NO_TCMALLOC_SAMPLES option from allocator.gyptimurrrr@chromium.org2009-12-091-3/+0
| | | | | | | | | | | | This brings the heap leak checker back again. The patch was originally prepared by Alexander Potapenko (cc'ed) and reviewed as http://codereview.chromium.org/464034 TBR=willchan,antonm Review URL: http://codereview.chromium.org/478002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34170 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup; remove deprecate file_util function and some obsolete TODOs.estade@chromium.org2009-12-092-5/+0
| | | | | | Review URL: http://codereview.chromium.org/467030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34133 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test failure: SysInfoTest.GoogleChromeOSVersionNumbersFirstcmasone@google.com2009-12-092-12/+10
| | | | | | Review URL: http://codereview.chromium.org/467053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34129 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: The member variable |pattern_| has a different type (FilePath) ↵thestig@chromium.org2009-12-083-26/+25
| | | | | | | | | | | | | | | from the constructor parameter (StringType). So fix this type to match with the constructor. Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/465119/show BUG=none TEST=none Review URL: http://codereview.chromium.org/466071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34092 0039d316-1c4b-4281-b951-d872f2087c98
* Make POSIX SIGTERM/SIGINT/SIGHUP handler async signal safe.willchan@chromium.org2009-12-082-0/+48
| | | | | | | | | | * Don't use LOG/CHECK. Replace with RAW_LOG/DCHECK (newly added to logging.h) * Don't directly post a task to the UI loop. Write to a magic pipe. Read this from a separate thread which will post to a task to the UI loop. BUG=http://crbug.com/29240 Review URL: http://codereview.chromium.org/460094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34036 0039d316-1c4b-4281-b951-d872f2087c98
* Add StringPrintV, fix libxml_utils.cc to use itpiman@chromium.org2009-12-082-0/+9
| | | | | | Review URL: http://codereview.chromium.org/464064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34029 0039d316-1c4b-4281-b951-d872f2087c98
* Make base::GetProcId() thread-safe on windows and drop w2k supportjamesr@chromium.org2009-12-071-68/+2
| | | | | | | | | | | base::GetProcId() was previously not threadsafe since it relied upon threads observing reads between two different static variables in the same order that they were written without any explicit synchronization. This probably is responsible for a small number of our startup crashes (http://crash/search?query=product:%22Chrome%22+base::GetProcIdViaGetProcessId). This fixes the race by dropping w2k support and directly calling the function. TEST=start up without crashing BUG=none Review URL: http://codereview.chromium.org/460063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33987 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement font and encoding settings in Under the Hood preferencesrsesek@chromium.org2009-12-071-0/+1
| | | | | | | | | | | | | * Font settings can now be changed for serif, sans serif, and fixed width. * The default encoding can now be changed via preferences. * Language settings are not yet implemented. See http://crbug.com/23828 BUG=20845 TEST=Chromium-->Preferences-->Under the Hood-->Change font and language settings Review URL: http://codereview.chromium.org/461005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33963 0039d316-1c4b-4281-b951-d872f2087c98
* Coalesce damage rects that share an edge.darin@chromium.org2009-12-073-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | This fixes the Bloat HTTP page cycler regression, and allows me to remove the hack I checked in to disable multiple-paints due to an observed DHTML page cycler regression. I added a new histogram, RW_IntermediatePaintRectCount, that would have shown the problem clearly had it been there before. I included some cleanup in PaintAggregator: 1- rename "r" to "existing_rect" for clarity 2- check for contained (i.e., redundant) invalidates up front I also changed the opacity of the paint rects used when --show-paint-rects is specified. I find myself dogfooding with this command line option enabled, and I want it to be a little less annoying but still just as useful. R=brettw BUG=29477 TEST=none Review URL: http://codereview.chromium.org/464057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33949 0039d316-1c4b-4281-b951-d872f2087c98
* Add an implementation of base::SyncSocket::Peek for posix platforms. Alsosehr@google.com2009-12-061-3/+7
| | | | | | | | | update the unit test to test the result. TEST=ipc_tests/sync_socket_unittest.cc Review URL: http://codereview.chromium.org/468023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33944 0039d316-1c4b-4281-b951-d872f2087c98
* Use factory to create histograms, and refcounts to track lifetimesjar@chromium.org2009-12-065-232/+485
| | | | | | | | | | | | | | | This is CL patch 377028 by Raman Tenneti, with minor changes to make the try-bots happier. It is cleanup that better ensures lifetimes of histograms (making it harder for users to abuse them). bug=16495 (repairs leak induced by the first landing) bug=18840 (should make leaks less possible) tbr=raman.tenneti Review URL: http://codereview.chromium.org/462027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33933 0039d316-1c4b-4281-b951-d872f2087c98
* Add non-blocking peek for the syncsocketcpu@chromium.org2009-12-043-0/+18
| | | | | | | | | | | | - Windows only BUG=none TEST=unit test included Review URL: http://codereview.chromium.org/464020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33876 0039d316-1c4b-4281-b951-d872f2087c98
* Split base.gyp and add base_nacl_win64 targetgregoryd@google.com2009-12-043-536/+613
| | | | | | | | | | TEST=none BUG=28176 Review URL: http://codereview.chromium.org/462009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33872 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid including gtk & glib headers in message_pump_glib.h, saves 1 sec on ↵mattm@chromium.org2009-12-042-10/+18
| | | | | | | | | | | do-nothing make. TEST=manual browser test, trybots BUG=none Review URL: http://codereview.chromium.org/464031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33851 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for 64-bit Windows build: base and chrome/appgregoryd@google.com2009-12-041-1/+3
| | | | | | | | | | | This is required to support Native Client on 64-bit Windows. Native Client will use a small 64-bit executable to load NaCl modules on 64-bit Windows. This 64-bit executable will use Chrome code, but some functionality has to be removed to minimize dependencies. This functionality may be enabled later if we decide that it is necessary. TEST=None BUG=28176 Review URL: http://codereview.chromium.org/371073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33823 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to the string MatchPattern functions:tony@chromium.org2009-12-033-26/+32
| | | | | | | | | | | | | | | 1) Make it explicit that it only supports ASCII (since it iterates character by character). 2) Limit the recursion to 16 levels. We could allow more, but in the case of a ?, it has exponential complexity, so I figured 16 was a good stopping point. It seems rare that someone would have more than 16 '?' and '*'s. BUG=28645 Review URL: http://codereview.chromium.org/460047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33748 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK that thinks fd = 0 is invalid.thestig@chromium.org2009-12-031-1/+1
| | | | | | | | BUG=25762 TEST=none Review URL: http://codereview.chromium.org/466023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33725 0039d316-1c4b-4281-b951-d872f2087c98
* Rename AtomicFlag to CancelFlag, change its semantics a bittimurrrr@chromium.org2009-12-037-147/+141
| | | | | | Review URL: http://codereview.chromium.org/454025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33723 0039d316-1c4b-4281-b951-d872f2087c98
* Make no-tcmalloc (really, non-base/allocator) builds work again,dank@chromium.org2009-12-031-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (i.e. this is a plain vanilla build used when layers like base/allocator are getting in the way of debugging) and make sure they use msvcrt rather than libcmt (libcmt is used to help shim malloc/free, but it gets in the way of valgrind doing the same thing). Sadly, this is now a gyp-time operation rather than a Configuration option. Had to remove hardcoded C prototype for _set_new_mode, as that caused link errors. Also add variables win_{release,debug}_{Optimization,RuntimeLibrary} to let the valgrind build override those settings. Fix calling convention on _set_new_mode to match the one in <new.h> BUG=none TEST=build with ~/.gyp/include.gypi set as described in comment in common.gypi, gclient runhooks, do release build, verify all exe's and dll's linked against msvcrt dll Review URL: http://codereview.chromium.org/455037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33719 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for 64-bit Windows buildgregoryd@google.com2009-12-032-4/+4
| | | | | | | | | BUG=28176 TEST=none Review URL: http://codereview.chromium.org/455036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33645 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Rename DIR_CACHE to DIR_USER_CACHE, which is already used on Linux.thestig@chromium.org2009-12-033-4/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/463005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33642 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce number of iterations on TimeTicks.Deltas testmbelshe@google.com2009-12-031-1/+1
| | | | | | | | | | | so that unittests run faster. BUG=22061 TEST=this is the test Review URL: http://codereview.chromium.org/462010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33631 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate a test-only data race on booleantimurrrr@chromium.org2009-12-021-0/+3
| | | | | | | | | We had a suppression for this race, but it couldn't hide the race in some rare cases like http://build.chromium.org/buildbot/waterfall/builders/Linux Tests (tsan)/builds/1213/steps/valgrind test%3A base/logs/stdio when the order of the racing accesses was different. Review URL: http://codereview.chromium.org/466009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33603 0039d316-1c4b-4281-b951-d872f2087c98
* Move some XDG code from chrome to base, make DIR_USER_CACHE generic rather ↵thestig@chromium.org2009-12-029-3/+346
| | | | | | | | | | than Chromium specific, and clean up a few headers. BUG=none TEST=none Review URL: http://codereview.chromium.org/449048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33565 0039d316-1c4b-4281-b951-d872f2087c98
* Tries to catch callbacks expecting scoped_refptr<T> and getting T* using ↵jamesr@chromium.org2009-12-023-1/+182
| | | | | | | | template magic Review URL: http://codereview.chromium.org/414024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33531 0039d316-1c4b-4281-b951-d872f2087c98
* Flush logging output.derat@chromium.org2009-12-021-11/+18
| | | | | | | | | | | It gets buffered otherwise, which is inconvenient when trying to follow what's going on in the Chrome OS window manager. TEST=compiled and ran it Review URL: http://codereview.chromium.org/459001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33520 0039d316-1c4b-4281-b951-d872f2087c98
* Remove emtpy lists and empty dictionaries from Preferences andtony@chromium.org2009-12-023-42/+181
| | | | | | | | | | Local State when writing to disk. BUG=28836 Review URL: http://codereview.chromium.org/449074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33518 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the deprecated version of ContentsEqual.thakis@chromium.org2009-12-013-9/+3
| | | | | | | | | | BUG=24672 TEST=base_unittests Review URL: http://codereview.chromium.org/432001 Patch from tfarina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33483 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unnecessary workaround for NSS bug 455424, now that we requirewtc@chromium.org2009-12-013-13/+0
| | | | | | | | | | | NSS 3.12.3 or later. R=ukai BUG=none TEST=No compilation errors. Review URL: http://codereview.chromium.org/452014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33464 0039d316-1c4b-4281-b951-d872f2087c98
* Point #include lines to files in the new tcmalloc/chromium local branch.sgk@chromium.org2009-12-011-1/+1
| | | | | | | | | Add +third_party\tcmalloc to webkit\DEPS. BUG=27911 TEST=none Review URL: http://codereview.chromium.org/449016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33440 0039d316-1c4b-4281-b951-d872f2087c98
* List all of the tcmalloc src/ files so that IDE users can view everything,sgk@chromium.org2009-12-011-35/+146
| | | | | | | | | adding 'sources!' exclusions for all of the files we don't actually use. BUG=27911 TEST=none Review URL: http://codereview.chromium.org/449033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33439 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add next-protocol-negotiation to libssl.agl@chromium.org2009-11-301-0/+4
| | | | | | | | | | | | This is an experimental, client only implementation of next-protocol-negotiation: http://www.imperialviolet.org/binary/draft-agl-tls-nextprotoneg-00.html This only affects the internal copy of libssl and is only active when built with use_system_ssl=0, which is not currently the default. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33327 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak when calling the one-arg form of ListValue::Remove().pkasting@chromium.org2009-11-303-2/+13
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/434108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33314 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race in directory creation on Windows. Thejoi@chromium.org2009-11-272-3/+55
| | | | | | | | | | | | | | | | | | | | | | | | file_util::CreateDirectory() function is supposed to succeed if the directory already exists, but in the previous implementation when two processes/threads called the function at the same time for the same path, one would see a failure. Also, get rid of the use of SHCreateDirectoryEx function. For one, it is highly serializing because it calls SHChangeNotify. The race was actually easy to reproduce by starting two instances of Chrome both at the same time, with a profile directory flag indicating a profile directory that did not previously exist. For another, SHCreateDirectoryEx would fail with ERROR_CANCELLED if any of the path components were not visible, according to its MSDN documentation. BUG=none TEST=[base_unittests.exe --gtest_filter=*CreateDirectory* ], and/or install Chrome Frame on a fresh machine and make sure the first page you navigate to has two Chrome Frame instances on it - you should get no DCHECK on failure of PathService::Override Review URL: http://codereview.chromium.org/437090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33225 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 02:48:37 +0000