summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* detect preferences errorserikkay@chromium.org2010-04-064-54/+138
| | | | | | | | | BUG=38352 TEST=none Review URL: http://codereview.chromium.org/1120006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43715 0039d316-1c4b-4281-b951-d872f2087c98
* Make DidProcessCrash a bit more solid and accurate on Windowsphajdan.jr@chromium.org2010-04-063-8/+36
| | | | | | | | | | | | | I hit the NOTREACHED() inside it while debugging an unrelated problem. Also, now there is one less special case in this function's contract. TEST=none BUG=38048 Review URL: http://codereview.chromium.org/1315009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43706 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the underlying escaping function JsonDoubleQuoteT to escape < and > ↵inferno@chromium.org2010-04-062-3/+6
| | | | | | | | | | characters BY DEFAULT to prevent script execution. BUG=40147 TEST=StringEscapeTest.* Review URL: http://codereview.chromium.org/1512013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43695 0039d316-1c4b-4281-b951-d872f2087c98
* Move EnvironmentVariableGetter from base/linux_util.h to base/env_var.h and ↵thestig@chromium.org2010-04-037-90/+158
| | | | | | | | | | rename it EnvVarGetter. Label base::SysInfo::{Get,Has}EnvVar as deprecated. BUG=none TEST=none Review URL: http://codereview.chromium.org/1606007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43559 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HMAC-SHA-256.wtc@chromium.org2010-04-024-20/+178
| | | | | | | | | R=albertb BUG=none TEST=added new HMAC unit tests Review URL: http://codereview.chromium.org/1513012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43522 0039d316-1c4b-4281-b951-d872f2087c98
* Use -[NSString UTF8String] to form a char* from an NSException.mark@chromium.org2010-04-021-1/+1
| | | | | | | | | BUG=none TEST=If this exception is ever caught, it should log a message, not the NSException pointer's address. Review URL: http://codereview.chromium.org/1518015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43513 0039d316-1c4b-4281-b951-d872f2087c98
* Move allocator dependency to base for profiler.cc.mmoss@google.com2010-04-022-8/+6
| | | | | | | | | Fixes Linux shlib errors like: lib.target/libbase.so: undefined symbol: ProfilerStart Review URL: http://codereview.chromium.org/1576015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43477 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Create a new sandbox type which allows access to Unix sockets in the Macmsneck@google.com2010-04-021-0/+3
| | | | | | | | | | | | | | | | | | | | | renderer sandbox to support running Native Client. 2. Put the Native Client sel_ldr (which contains the user's untrusted code) into a new Mac sandbox type. 3. Open /dev/random in SandboxWarmup(). 4. Remove the "--nosandbox" flag when running Mac tests. See http://codereview.chromium.org/1234003/show and http://codereview.chromium.org/1525005/show which were both reverted because of problems on Mac 10.6. This change is identical except for the ";NACL" lines in renderer.sb files and the corresponding lines in nacl-loader.sb. Unix socket support for the sandbox changed considerably from 10.5 to 10.6. BUG=http://code.google.com/p/nativeclient/issues/detail?id=327 TEST=nacl_ui_tests still pass while running in the sandbox. Review URL: http://codereview.chromium.org/1559012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43473 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: In functions where we wait for a process with timeout, increment the ↵thestig@chromium.org2010-04-021-14/+24
| | | | | | | | | | amount of time we sleep between polls from 1 to 256 milliseconds instead of always sleeping 250 milliseconds. BUG=none TEST=Perf tests that use WaitForSingleProcess but finishes under 250 ms will get more accurate results. Review URL: http://codereview.chromium.org/1518008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43463 0039d316-1c4b-4281-b951-d872f2087c98
* Move the Nigori classes from base to sync.albertb@chromium.org2010-04-015-397/+0
| | | | | | | | | BUG=none TEST=NigoriTest Review URL: http://codereview.chromium.org/1549012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43366 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/gfx/.estade@chromium.org2010-04-013-328/+0
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/1570005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43362 0039d316-1c4b-4281-b951-d872f2087c98
* Solaris: various edits towards compiling Chromium on Solaris. Changed ↵evan@chromium.org2010-04-015-5/+23
| | | | | | | | | | | | __Solaris__ to __sun. Defined NAME_MAX as MAXNAMLEN for systems where it is undefined. BUG=30101 TEST=compiles Patch by James Choi <jchoi42 at pha.jhu.edu> Review URL: http://codereview.chromium.org/652166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43297 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in encryptor_unittest.ccalbertb@chromium.org2010-03-311-1/+1
| | | | | | | | | BUG=none TEST=valgrind doesn't complain anymore Review URL: http://codereview.chromium.org/1558010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43283 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43253 - 1. Create a new sandbox type which allows access to Unix ↵dmaclach@chromium.org2010-03-311-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | sockets in the Mac renderer sandbox to support running Native Client. 2. Put the Native Client sel_ldr (which contains the user's untrusted code) into a new Mac sandbox type. 3. Open /dev/random in SandboxWarmup(). 4. Remove the "nosandbox" flag when running Mac tests. See http://codereview.chromium.org/1234003/show which was reverted because of problems on Mac 10.6. This change is identical except for the ";NACL" lines in the *.sb files. I've removed the 10.6specific sandbox commands and used the generic commands that work on 10.5 and 10.6. I will work on adding the 10.6specific commands in a different change list. BUG=http://code.google.com/p/nativeclient/issues/detail?id=327 TEST=nacl_ui_tests still pass while running in the sandbox. Review URL: http://codereview.chromium.org/1525005 TBR=msneck@google.com Review URL: http://codereview.chromium.org/1572009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43259 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Create a new sandbox type which allows access to Unix sockets in the Macmsneck@google.com2010-03-311-0/+3
| | | | | | | | | | | | | | | | | | | | | renderer sandbox to support running Native Client. 2. Put the Native Client sel_ldr (which contains the user's untrusted code) into a new Mac sandbox type. 3. Open /dev/random in SandboxWarmup(). 4. Remove the "--nosandbox" flag when running Mac tests. See http://codereview.chromium.org/1234003/show which was reverted because of problems on Mac 10.6. This change is identical except for the ";NACL" lines in the *.sb files. I've removed the 10.6-specific sandbox commands and used the generic commands that work on 10.5 and 10.6. I will work on adding the 10.6-specific commands in a different change list. BUG=http://code.google.com/p/nativeclient/issues/detail?id=327 TEST=nacl_ui_tests still pass while running in the sandbox. Review URL: http://codereview.chromium.org/1525005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43253 0039d316-1c4b-4281-b951-d872f2087c98
* First pass of a Nigori implementation for Chrome. Only unassisted keyalbertb@chromium.org2010-03-3111-23/+427
| | | | | | | | | | | derivation is supported and there is no support for server authentication. BUG=37363 TEST=unit tests Review URL: http://codereview.chromium.org/1357003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43220 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43127 [It resulted in a free memory write because of a consumer that ↵eroman@chromium.org2010-03-313-136/+23
| | | | | | | | | | | | | | | | | | | was relying on the old ordering (BUG=39932).] Don't call Thread::CleanUp() before the MessageLoop destruction observers have run. This is consistent with the comment for Thread::CleanUp(), which says it runs after the message loop has "stopped". Certain consumers depend on this ordering to avoid accessing variables which are deleted by Thread::CleanUp(). BUG=39723 TEST=ThreadTest.CleanUp Review URL: http://codereview.chromium.org/1540002 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/1517006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43174 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow dragging browser actions between regular and incognito windows.mpcomplete@chromium.org2010-03-302-0/+16
| | | | | | | | | | | | This fixes a crash. Also small fix to Pickle::ReadBytes to fix up the iterator if it is NULL. BUG=39340 Review URL: http://codereview.chromium.org/1542007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43147 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call Thread::CleanUp() before the MessageLoop destruction observers ↵eroman@chromium.org2010-03-303-23/+136
| | | | | | | | | | | | | | have run. This is consistent with the comment for Thread::CleanUp(), which says it runs after the message loop has "stopped". Certain consumers depend on this ordering to avoid accessing variables which are deleted by Thread::CleanUp(). BUG=39723 TEST=ThreadTest.CleanUp Review URL: http://codereview.chromium.org/1540002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43127 0039d316-1c4b-4281-b951-d872f2087c98
* For systems where SIZEOF_VOID_P is not defined, determine it basedpvalchev@google.com2010-03-301-1/+15
| | | | | | | | | on __LP64__ (which is predefined in gcc on 64-bit systems) (Necessary for BSD port) Review URL: http://codereview.chromium.org/747003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43108 0039d316-1c4b-4281-b951-d872f2087c98
* Minor C++ fixes found by Clang.evan@chromium.org2010-03-302-5/+7
| | | | | | | | | In cases where I've added an #include, it's generally due to Clang being more picky about templates being available during expansions. Review URL: http://codereview.chromium.org/1432003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43098 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43086 - 1. Create a new sandbox type which allows access to Unix ↵dmaclach@chromium.org2010-03-301-3/+0
| | | | | | | | | | | | | | | | | | sockets in the Mac renderer sandbox to support running Native Client. 2. Put the Native Client sel_ldr (which contains the user's untrusted code into a new Mac sandbox type. 3. Open /dev/random in SandboxWarmup(). 4. Remove the "nosandbox" flag when running Mac tests. BUG=http://code.google.com/p/nativeclient/issues/detail?id=327 TEST=nacl_ui_tests still pass while running in the sandbox. Review URL: http://codereview.chromium.org/1234003 TBR=msneck@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43093 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Create a new sandbox type which allows access to Unix sockets in the Macmsneck@google.com2010-03-301-0/+3
| | | | | | | | | | | | | | renderer sandbox to support running Native Client. 2. Put the Native Client sel_ldr (which contains the user's untrusted code into a new Mac sandbox type. 3. Open /dev/random in SandboxWarmup(). 4. Remove the "--nosandbox" flag when running Mac tests. BUG=http://code.google.com/p/nativeclient/issues/detail?id=327 TEST=nacl_ui_tests still pass while running in the sandbox. Review URL: http://codereview.chromium.org/1234003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43086 0039d316-1c4b-4281-b951-d872f2087c98
* Add win32 gtest filter files shared between Wine and TSan/Windowstimurrrr@chromium.org2010-03-302-18/+7
| | | | | | | BUG=28363 Review URL: http://codereview.chromium.org/1377003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43076 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r42300: "HttpRequestHeaders refactor."willchan@chromium.org2010-03-293-1/+105
| | | | | | | | | Adds a fix and tests for empty header values. The particular bug happened when the value was non-empty, but was all LWS, so it was effectively empty. BUG=22588 Review URL: http://codereview.chromium.org/1370001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43000 0039d316-1c4b-4281-b951-d872f2087c98
* Report unreadable files as size zero when uploading.vandebo@chromium.org2010-03-291-0/+54
| | | | | | | | | | | Upload zero bytes if the file size shrinks. BUG=30850 TEST=uploading an unreadable file works Review URL: http://codereview.chromium.org/1250002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42981 0039d316-1c4b-4281-b951-d872f2087c98
* linux: make shm opening failure fatalevan@chromium.org2010-03-291-3/+5
| | | | | | | | | | | | | | We should eventually add some recovery code path, but right now it's completely broken (see bug) and this is the quicker fix. FATAL logs pop up a dialog explaining what went wrong, too, so this will help users who don't look at the console output. BUG=39710 TEST=sudo chmod o-w /dev/shm; verify you get a dialog that yells at you at startup Review URL: http://codereview.chromium.org/1545003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42973 0039d316-1c4b-4281-b951-d872f2087c98
* Add Mac implementations of new SymmetricKey and Encryptor classes.snej@chromium.org2010-03-2916-96/+379
| | | | | | | | | BUG=none TEST=EncryptorTest, SymmetricKeyTest Review URL: http://codereview.chromium.org/1347002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42964 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Turn on the GTK+ integration by default.erg@chromium.org2010-03-262-0/+5
| | | | | | | | | | | | | | This will regress default startup time for users by 50ms. This doesn't matter because this is what the users want--I've lost count of the number bloggers, people on twitter, and people in our IRC channel complaining about the lack of GTK+ integration...when it's just not on by default. BUG=none TEST=none Review URL: http://codereview.chromium.org/1442001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42804 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run Memcheck sanity tests under ThreadSanitizertimurrrr@chromium.org2010-03-261-0/+5
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1408002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42760 0039d316-1c4b-4281-b951-d872f2087c98
* Implement more sanity tests for Memcheck/Valgrindtimurrrr@chromium.org2010-03-261-1/+67
| | | | | | Review URL: http://codereview.chromium.org/1242008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42751 0039d316-1c4b-4281-b951-d872f2087c98
* Add the linux_use_heapchecker GYP variable that should turn the tcmalloc heapglider@chromium.org2010-03-262-3/+13
| | | | | | | lleak checker on and off. Review URL: http://codereview.chromium.org/1334002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42740 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug where an empty version string is considered valid.akalin@chromium.org2010-03-253-18/+53
| | | | | | | | | | | | Made default constructor public, but DCHECK() on any use of a default-constructed object. BUG=none TEST=unittests Review URL: http://codereview.chromium.org/1364002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42681 0039d316-1c4b-4281-b951-d872f2087c98
* Implement random key generation and AES encryption using NSS.albertb@chromium.org2010-03-2517-138/+422
| | | | | | | | | BUG=none TEST=unit test Review URL: http://codereview.chromium.org/1142004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42649 0039d316-1c4b-4281-b951-d872f2087c98
* posix: stat() uses errno, not its return value, for errorsevan@chromium.org2010-03-251-1/+1
| | | | | | | | | | | | | l/stat() always return -1 on error, so we must examine errno if we want to handle errors specially. (This is only used for judging whether to print an error message, so it's not too harmful.) TEST=symlink to nowhere in a dir; Chrome should not complain about that symlink when enumerating files in the directory Review URL: http://codereview.chromium.org/1352001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42647 0039d316-1c4b-4281-b951-d872f2087c98
* Round the size of shared memory regions up to 64K. This allowssehr@google.com2010-03-251-1/+8
| | | | | | | | | native client modules to map these regions. With this fix, Pepper audio works on all three platforms. Review URL: http://codereview.chromium.org/1242006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42621 0039d316-1c4b-4281-b951-d872f2087c98
* Function to compute the total size of the files in a directorycpu@chromium.org2010-03-243-0/+52
| | | | | | | | | | | | | We need this for the diagnostic mode but it can be used by others. Did not see test for GetFileSize() so added them BUG=none TEST=ut included Review URL: http://codereview.chromium.org/1220001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42540 0039d316-1c4b-4281-b951-d872f2087c98
* Enable WorkerPoolTest.PostTask back under ThreadSanitizer on Mac OS.glider@chromium.org2010-03-241-6/+0
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/1276001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42462 0039d316-1c4b-4281-b951-d872f2087c98
* Annotated the scoped leak inside base::RSAPrivateKey::CreateFromPrivateKeyInfo,glider@chromium.org2010-03-243-17/+4
| | | | | | | | | | | | removed the annotations from the tests calling it (RSAPrivateKeyUnitTest.* and SignatureCreatorTest.BasicTest) BUG=34742 TBR=wtc Review URL: http://codereview.chromium.org/1271002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42459 0039d316-1c4b-4281-b951-d872f2087c98
* print stack trace to stderr as well as to dialog.oshima@chromium.org2010-03-241-12/+10
| | | | | | | | | | | Stacktrace info was shown only in dialog, and chromeos was not getting this as it does not have xmessage. Changed to include stacktrace to the log message before being printed to stderr. BUG=none TEST=none Review URL: http://codereview.chromium.org/1094012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42431 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Reland r42300: "HttpRequestHeaders refactor."""willchan@chromium.org2010-03-233-105/+1
| | | | | | | | Broke another layout test. Review URL: http://codereview.chromium.org/1223001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42387 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r42300: "HttpRequestHeaders refactor.""willchan@chromium.org2010-03-233-1/+105
| | | | | | | | | | | | This time, make sure HttpRequestHeaders::FindHeader() checks key lengths are equal. * Create HttpRequestHeaders. * Switch HttpNetworkTransaction to build request headers. TODO: Change extra_headers to use HttpRequestHeaders. BUG=22588 Review URL: http://codereview.chromium.org/1110014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42376 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r42300: "HttpRequestHeaders refactor."willchan@chromium.org2010-03-233-105/+1
| | | | | | | | | Broke access-control-basic-whitelist-request-headers.html layout test. BUG=22588 Review URL: http://codereview.chromium.org/1110012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42305 0039d316-1c4b-4281-b951-d872f2087c98
* HttpRequestHeaders refactor.willchan@chromium.org2010-03-233-1/+105
| | | | | | | | | | | * Create HttpRequestHeaders. * Switch HttpNetworkTransaction to build request headers. TODO: Change extra_headers to use HttpRequestHeaders. BUG=22588 Review URL: http://codereview.chromium.org/1039001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42300 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux shared library build.mmoss@google.com2010-03-221-0/+8
| | | | | | | | r42182 moved some gtk code into a library that didn't link gtk libs. Review URL: http://codereview.chromium.org/1074007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42261 0039d316-1c4b-4281-b951-d872f2087c98
* Allowing MSI mode detection to work from the master preferences file. robertshield@chromium.org2010-03-222-3/+8
| | | | | | | | | | | | | | | | Refactor the piece of master preferences code that was in setup_util.h|cc (setup) into master_preferences.h|cc (install_util). This adds an install_util -> googleurl dependency, which should to be fine. Add in master_preferences_dummy.cc to keep the nacl64 stuff compiling happily. Add values.h|cc to the portion of base built in 64 bit mode and add a minor fix to values.cc to make it build. Also refactor accompanying master_preferences test code from setup tests to install_util tests. BUG=19370 Review URL: http://codereview.chromium.org/979003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42248 0039d316-1c4b-4281-b951-d872f2087c98
* PBKDF2 implemetation using NSS.albertb@chromium.org2010-03-2214-30/+358
| | | | | | | | | BUG=none TEST=unit test Review URL: http://codereview.chromium.org/1024001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42247 0039d316-1c4b-4281-b951-d872f2087c98
* Annotated the memory leaks in RSAPrivateKeyUnitTest.* and glider@chromium.org2010-03-222-0/+17
| | | | | | | | | | SignatureCreatorTest.BasicTest. BUG=34742 TBR=wtc Review URL: http://codereview.chromium.org/1117007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42223 0039d316-1c4b-4281-b951-d872f2087c98
* fix mac bustage by adding NL to end of fileben@chromium.org2010-03-201-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42183 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-205-1/+611
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98