summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Use higher precision to store the login database's date_created ↵erikchen2014-11-141-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | field" to 2214. > Use higher precision to store the login database's date_created field. > > When a password is created or updated, its creation_date is saved in the login > database with precision seconds. The same data is stored in the password sync > server with precision microseconds. As a result, the two passwords always > appear to differ. > > I've changed the code so that the creation_date is stored in the login database > with precision microseconds, and I've created a migration to update the > existing login database entries. Prior to the migration, creation_date was a > time_t, which has precision seconds and counts from the UTC epoch. After the > migration, creation_date has precision microseconds, and counts from Chrome's > platform independent epoch. > > Note that the very first time passwords are all synced, they will still appear > to differ since the login database lost 6 decimal places of precision. This CL > makes it so that on the second sync (and subsequent syncs), the passwords will > no longer differ. > > BUG=408800 > > Review URL: https://codereview.chromium.org/702893005 > > Cr-Commit-Position: refs/heads/master@{#303783} BUG=408800 TBR=gcasto@chromium.org Review URL: https://codereview.chromium.org/726993002 Cr-Commit-Position: refs/branch-heads/2214@{#48} Cr-Branched-From: 03655fd3f6d72165dc3c9bd2c89807305316fe6c-refs/heads/master@{#303346}
* gn win: disable 4267 (need for win x64)scottmg2014-11-081-1/+6
| | | | | | | | | | (backported from mojo) R=jam@chromium.org Review URL: https://codereview.chromium.org/709793002 Cr-Commit-Position: refs/heads/master@{#303341}
* Update base::BindBlock for three parameters.marq2014-11-072-36/+49
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/708743002 Cr-Commit-Position: refs/heads/master@{#303295}
* Add memory corruption checking to base::File().gavinp2014-11-073-1/+163
| | | | | | | | | | | | | | | | | | | | | | | Since we crash on invalid fd in ScopedFD::Close(), memory corruption in a base::File() object can cause crashes; perhaps long after the memory is actually corrupt. This CL puts a checksum in memory near the fd on POSIX systems. The checksum is different enough to be very unlikely to be correct after a random memory write, but also very cheap to compute, so we can have most operations on a file double quickly double check its integrity, for earlier (and more useful for debugging) crashes. This is intended to help us debug issue 424562. Once we have found out if and where memory is being corrupted, this instrumentation code should be removed. R=thakis@chromium.org,pasko@chromium.org BUG=424562 Review URL: https://codereview.chromium.org/702473009 Cr-Commit-Position: refs/heads/master@{#303251}
* Allow C++11 Delegated Constructors.andersr2014-11-071-1/+1
| | | | | | | | | | | An as-small-as-possible change has been made to JSONReader to test this feature. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/685603005 Cr-Commit-Position: refs/heads/master@{#303245}
* Removing a single-parameter constructor of ScopedProfile, per a TODO item.vadimt2014-11-073-16/+5
| | | | | | | | BUG=401560 Review URL: https://codereview.chromium.org/712443003 Cr-Commit-Position: refs/heads/master@{#303240}
* Enable profiler timing with a field trial.vadimt2014-11-062-11/+29
| | | | | | | | | | | | | | In Browser process, if profiler timing field trial is "Enabled", enable profiler timing. This is necessary to measure the performance impact of enabling profiler timing on Android, and, perhaps, rolling out profiler timing enabling afterwards. Profiler timing is currently disabled on Android because of performance concerns, but the impact on the standard perf metricts is not yet known, hence this CL. BUG=315070 Review URL: https://codereview.chromium.org/693103005 Cr-Commit-Position: refs/heads/master@{#303100}
* Cleanup: Remove unneeded path_service.h includes in base and chrome.thestig2014-11-063-3/+0
| | | | | | Review URL: https://codereview.chromium.org/689553002 Cr-Commit-Position: refs/heads/master@{#303085}
* Non-SFI mode: Enable MSG_TRUNC and MSG_CTRUNC code for nacl_helper_nonsfi.hidehiko2014-11-061-4/+0
| | | | | | | | | | | | Now, the PNaCL toolchain for Non-SFI build supports MSG_TRUNC and MSG_CTRUNC, so this CL enables the related code. BUG=427625, 358465 TEST=Ran trybots. Review URL: https://codereview.chromium.org/703033003 Cr-Commit-Position: refs/heads/master@{#303065}
* UMA: Set Hardware model class on Mac.jeremy2014-11-064-0/+27
| | | | | | | | | | Record the hardware model on Mac e.g. MacPro1,1 . BUG=429487 Review URL: https://codereview.chromium.org/699173002 Cr-Commit-Position: refs/heads/master@{#303054}
* Add a check if file is uncompressed inside zip file to the crazy linker.petrcermak2014-11-064-29/+33
| | | | | | | | | | | This patch adds a check to crazy::FindStartOffsetOfFileInZipFile which ensures that a file is uncompressed in the zip file. BUG=390618 Review URL: https://codereview.chromium.org/705613003 Cr-Commit-Position: refs/heads/master@{#303041}
* Allow Objective-C interfaces in //base/iosdroger2014-11-061-0/+1
| | | | | | | | | | | Objective-C interfaces are disallowed in base because of a bug related to plugins. There are no plugins on iOS, and //base/ios is not compiled for other platforms. Review URL: https://codereview.chromium.org/708513002 Cr-Commit-Position: refs/heads/master@{#303007}
* Add support to base::Timer for custom task runners.petrcermak2014-11-063-4/+61
| | | | | | | | | | | | | | | | | | This patch adds a public method SetTaskRunner(scoped_refptr<SingleThreadTaskRunner>) to base::Timer which changes the task runner used by the timer (ThreadTaskRunnerHandler::Get() by default). This change will enable scheduling timers on the queues of the Blink scheduler (see https://codereview.chromium.org/637303003/). Most importantly, we plan to apply this to the shared timer in blink::Platform. BUG= Review URL: https://codereview.chromium.org/637983003 Cr-Commit-Position: refs/heads/master@{#302947}
* Add UMA for the no map executable support fallback.petrcermak2014-11-064-36/+93
| | | | | | | | | | | | | | This patch adds a "Used no map executable support fallback" value to the "ChromiumAndroidLinker.LibraryLoadFromApkStatus" histogram. To do this, an extra argument is added to crazy_library_open_in_zip_file() which enables the fallback due to lack of support for mapping the APK file with executable permission (https://codereview.chromium.org/692593002/). BUG=398425,390618 Review URL: https://codereview.chromium.org/697953003 Cr-Commit-Position: refs/heads/master@{#302926}
* Non-SFI mode: Clean up macros of base/ and ipc/ libraries for ↵hidehiko2014-11-056-29/+29
| | | | | | | | | | | | | nacl_helper_nonsfi. Now, OS_NACL_SFI and OS_NACL_NONSFI are introduced to build/build_config.h, and these are preferred to __native_client_nonsfi__ and OS_NACL combination. BUG=358465 TEST=Ran trybots. Review URL: https://codereview.chromium.org/704513003 Cr-Commit-Position: refs/heads/master@{#302907}
* Added a marker for field trials passed on the command line to force their ↵georgesak2014-11-053-6/+47
| | | | | | | | | | activation. BUG=430233 Review URL: https://codereview.chromium.org/700933002 Cr-Commit-Position: refs/heads/master@{#302813}
* Export TrialExists to Java layerjaekyun2014-11-052-0/+14
| | | | | | | | | | This change exports TrialExists to Java layer which is used in https://chrome-internal-review.googlesource.com/#/c/182195/ to check whether a trial actually exists or not. BUG=412156 Review URL: https://codereview.chromium.org/700043002 Cr-Commit-Position: refs/heads/master@{#302773}
* Instrumenting URLRequestJob::NotifyHeadersComplete to locate the source of ↵vadimt2014-11-041-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | jankiness Previous instrumentations showed that URLRequestJob::NotifyHeadersComplete alone is responsible for ~57.1 janks per hour in IO thread. I need to instrument the code inside it to find out which part causes jank. This is a mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. The task gets created only in developer build and in Canary channel. BUG=423948 Review URL: https://codereview.chromium.org/696483002 Cr-Commit-Position: refs/heads/master@{#302694}
* Switch to clang for nocompile tests and rebaseline existing results.dcheng2014-11-034-41/+41
| | | | | | | | BUG=105388 Review URL: https://codereview.chromium.org/678263003 Cr-Commit-Position: refs/heads/master@{#302483}
* Library loading fallback.petrcermak2014-11-035-184/+471
| | | | | | | | | | | | | This patch adds support for copying the Chromium library from the APK file to a separate file. This patch is largly based on https://codereview.chromium.org/673093005/. BUG=390618 Review URL: https://codereview.chromium.org/684163002 Cr-Commit-Position: refs/heads/master@{#302456}
* Cleanup various includes and namespace references.fdegans2014-11-032-1/+2
| | | | | | | | | | | | These are mostly mechanical changes found while attempting to compile the Android build with libc++. BUG=427718 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/693773003 Cr-Commit-Position: refs/heads/master@{#302425}
* Enabling augmenting callback with Location.vadimt2014-10-312-0/+27
| | | | | | | | | | | | This is useful for instrumentations required for jankiness investigations. See the .h file comment for details. In fact, one of my investigations is blocked on this feature. BUG=401560 Review URL: https://codereview.chromium.org/683283004 Cr-Commit-Position: refs/heads/master@{#302324}
* Change dont_embed_build_metadata default to 1 except for Official build and ↵sebmarchand2014-10-313-5/+9
| | | | | | | | | | | | | | | | fix some unittests. FieldTrialTest.DisableProbability was using Time::NowFromSystemTime - 1 year to generate a date before the build time. Instead use GetBuildTime - 1 year. TransportSecurityState::IsBuildTimely is using GetBuildTime to determine if the build is older than 10 weeks. Disable this and return a default value if DONT_EMBED_BUILD_METADATA is defined (i.e. The build time is invalid) and we're not doing an official build. CL based on https://codereview.chromium.org/685123005/ with some additional fixes for the unittests. BUG=314403 Review URL: https://codereview.chromium.org/695523002 Cr-Commit-Position: refs/heads/master@{#302316}
* Mac: Use Mavericks occlusion APIs for power savings.ccameron2014-10-302-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use NSWindowDidChangeOcclusionStateNotification (new in 10.9 Mavericks) to detect when the application is hidden, the window is minimized or obscured by another window. Send the WasHidden to the WebContentsImpl, because this will take into account tab capture. When RenderWidgetHostViewMac::WasHidden is called, the previous behavior was to destroy the BrowserCompositorViewMac. This has the undesirable effect of creating a white flash when a hidden window is re-exposed. To prevent this, only destroy the BrowserCompositorViewMac when the the RenderWidgetHostViewMac is removed from all NSWindows. Manage the state of BrowserCompositorViewMac explicitly as being Active (previously whenever it existed), Suspended (the new state where it is kept around, but the RWH and DFH are hidden), and Destroyed (previously wherever it did not exist). Move some 10.7 APIs to base because they belong there, not in content. BUG=310374 Review URL: https://codereview.chromium.org/684343002 Cr-Commit-Position: refs/heads/master@{#302160}
* Revert of Allow POSIX callers to specify a new file's mode. (patchset #1 ↵csharp2014-10-303-39/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/689713006/) Reason for revert: This seems to have broken the Linux MSan test bot. [ RUN ] FileUtilTest.WriteFileWithMode ../../base/files/file_util_unittest.cc:2164: Failure Value of: status.st_mode & 0777 Actual: 384 Expected: mode Which is: 420 [ FAILED ] FileUtilTest.WriteFileWithMode (1 ms) Original issue's description: > Allow POSIX callers to specify a new file's mode. > > Retain the tight 0640 mode for most existing callers, but honor the user's > umask for downloaded files. > > This is a re-land of https://codereview.chromium.org/639253004/. > > BUG=409416, 362887 > TBR=asanka,mdempsky,rvargas > > Committed: https://crrev.com/931e35070097af9837f79ff19f8668e45b92ed3a > Cr-Commit-Position: refs/heads/master@{#302113} TBR=palmer@chromium.org NOTREECHECKS=true NOTRY=true BUG=409416, 362887 Review URL: https://codereview.chromium.org/693493004 Cr-Commit-Position: refs/heads/master@{#302143}
* Allow POSIX callers to specify a new file's mode.palmer2014-10-303-0/+39
| | | | | | | | | | | | | | Retain the tight 0640 mode for most existing callers, but honor the user's umask for downloaded files. This is a re-land of https://codereview.chromium.org/639253004/. BUG=409416, 362887 TBR=asanka,mdempsky,rvargas Review URL: https://codereview.chromium.org/689713006 Cr-Commit-Position: refs/heads/master@{#302113}
* Update PRESUBMIT files for first round of ng trybotsPaweł Hajdan, Jr2014-10-301-14/+0
| | | | | | | | | | | | | | Clean up redundant PRESUBMIT files. linux_redux has been 100% red since at least August 2014, and is presumably not useful. BUG=380709 R=sergiyb@chromium.org Review URL: https://codereview.chromium.org/685363002 Cr-Commit-Position: refs/heads/master@{#302067}
* Fix ninja "multiple rules" warning.petrcermak2014-10-301-1/+0
| | | | | | | | BUG=427526 Review URL: https://codereview.chromium.org/680923002 Cr-Commit-Position: refs/heads/master@{#302064}
* [Android] Add feng@chromium.org to OWNERS of base/test/androidfeng2014-10-291-0/+1
| | | | | | Review URL: https://codereview.chromium.org/684313002 Cr-Commit-Position: refs/heads/master@{#301979}
* [Android] Upstream several test support classes.feng2014-10-292-0/+109
| | | | | | | | BUG=427633 Review URL: https://codereview.chromium.org/685303002 Cr-Commit-Position: refs/heads/master@{#301973}
* Revert "Allow POSIX callers to specify a new file's mode."Mike Wittman2014-10-293-39/+0
| | | | | | | | | | | | This reverts commit 3457f738b0dc2dd7d67fa84148d72066db9e0519. Breaks FileUtilTest.WriteFileWithMode on Android. BUG=409416,362887 Review URL: https://codereview.chromium.org/687163005 Cr-Commit-Position: refs/heads/master@{#301968}
* Switching profiler instrumentations from ScopedProfile to ScopedTracker. ↵vadimt2014-10-293-15/+12
| | | | | | | | | | | | This will disable the instrumentations in all channels except Canary, and developer build. Instrumentations are only enabled in Browser process. This will prevent Stable from sending increased amounts of UMA logs. Also, this will let us observe "true" (untouched by instrumentations) jankiness numbers every week in Dev channel. BUG=401560 Review URL: https://codereview.chromium.org/686963002 Cr-Commit-Position: refs/heads/master@{#301950}
* Allow POSIX callers to specify a new file's mode.Chris Palmer2014-10-293-0/+39
| | | | | | | | | | | | Retain the tight 0640 mode for most existing callers, but honor the user's umask for downloaded files. BUG=409416,362887 R=asanka@chromium.org, mdempsky@chromium.org, rvargas@chromium.org Review URL: https://codereview.chromium.org/639253004 Cr-Commit-Position: refs/heads/master@{#301932}
* Check in executable for iOS test launcher (attempt #2)Paweł Hajdan, Jr2014-10-292-1/+51
| | | | | | | | | | | | | | | This is a reland of https://codereview.chromium.org/669673004 after fixes. This doesn't do anything yet, mostly adds supporting infrastructure. R=lliabraa@chromium.org, mark@chromium.org TBR=darin BUG=426870 Review URL: https://codereview.chromium.org/688663003 Cr-Commit-Position: refs/heads/master@{#301850}
* Fix chronic presubmit warnings/errors.simonb2014-10-292-29/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Readability only. No behavioural effect. Fixes: ** Presubmit Warnings ** base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:188:96: '+' should be on a new line. base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:242:66: '+' should be on a new line. base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:334:94: '?' should be on a new line. base/android/java/src/org/chromium/base/library_loader/Linker.java:245:69: '?' should be on a new line. base/android/java/src/org/chromium/base/library_loader/Linker.java:343:67: '||' should be on a new line. base/android/java/src/org/chromium/base/library_loader/Linker.java:509:66: '+' should be on a new line. base/android/java/src/org/chromium/base/library_loader/Linker.java:764:80: '+' should be on a new line. base/android/java/src/org/chromium/base/library_loader/Linker.java:836:83: '+' should be on a new line. ** Presubmit ERRORS ** base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:189: '"retrying without"' have incorrect indentation level 38, expected level should be 40. base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:212: '&&' have incorrect indentation level 32, expected level should be 36. base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:223: '&&' have incorrect indentation level 20, expected level should be 24. base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:224: '&&' have incorrect indentation level 20, expected level should be 24. base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:226: 'context' have incorrect indentation level 24, expected level should be 28. base/android/java/src/org/chromium/base/library_loader/Linker.java:643: 'String' have incorrect indentation level 18, expected level should be 20. base/android/java/src/org/chromium/base/library_loader/Linker.java:888: 'String' have incorrect indentation level 8, expected level should be 12. base/android/java/src/org/chromium/base/library_loader/Linker.java:889: 'String' have incorrect indentation level 8, expected level should be 12. base/android/java/src/org/chromium/base/library_loader/Linker.java:890: 'long' have incorrect indentation level 8, expected level should be 12. base/android/java/src/org/chromium/base/library_loader/Linker.java:891: 'LibInfo' have incorrect indentation level 8, expected level should be 12. base/android/java/src/org/chromium/base/library_loader/Linker.java:1082: '"org.chromium.base.android.linker.shared_relros"' have incorrect indentation level 8, expected level should be 12. BUG= Review URL: https://codereview.chromium.org/672363003 Cr-Commit-Position: refs/heads/master@{#301818}
* Add logging support for base::Time* types.ricea2014-10-293-3/+148
| | | | | | | | | | | | Define operator<<(ostream&,Time) to permit Time, TimeDelta and TimeTicks types to be used in logging assertions such as DCHECK_EQ(). BUG=425941 TEST=base_unittests Review URL: https://codereview.chromium.org/669083002 Cr-Commit-Position: refs/heads/master@{#301815}
* Add UMA for testing whether the Chromium library was page aligned in the APK ↵petrcermak2014-10-294-16/+99
| | | | | | | | | | | | | | | | | file. The following histogram is added: ChromiumAndroidLinker.LibraryAlignedInApk Whether the Chromium library is page aligned in the APK file. The functionality is checked and reported during every Chromium browser process start up if direct library loading from the APK file is enabled. BUG= Review URL: https://codereview.chromium.org/684453003 Cr-Commit-Position: refs/heads/master@{#301813}
* Add a few missing overrides found by a new clang warning.thakis2014-10-292-5/+5
| | | | | | | | | | | Namely, -Winconsistent-missing-override. No behavior change. BUG=428099 TBR=blundell Review URL: https://codereview.chromium.org/652233006 Cr-Commit-Position: refs/heads/master@{#301761}
* mac: Add UMA metrics for Handoff.erikchen2014-10-281-0/+1
| | | | | | | | BUG=380419 Review URL: https://codereview.chromium.org/686553003 Cr-Commit-Position: refs/heads/master@{#301735}
* Adding /analyze support to common.gypi through GYP_DEFINES=win_analyze=1, ↵brucedawson2014-10-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | and suppress one very noisy warning. When win_analyze=1 is specified then /analyze is added to the command line to enable static code analysis with VC++. WarnAsErrors is set to false to allow reporting of all errors. Additional, WX- is added to disable WarnAsErrors more robustly, necessary because some projects override WarnAsErrors. Additionally, many noisy but low-value warnings are suppressed. Finally, _USING_V110_SDK71_ is un-set when win_analyze is true because this is incompatible with /analyze. The change to callback_internal.h suppresses an extremely noisy warning about a potentially incorrect use of sizeof(): base\callback_internal.h(80) : warning C6334: sizeof operator applied to an expression with an operator might yield unexpected results: Parentheses can be used to disambiguate certain usages. With this change almost all of Chrome can be built with high but useful levels of warnings. bug=427616 Review URL: https://codereview.chromium.org/676743003 Cr-Commit-Position: refs/heads/master@{#301723}
* Replace a few typeofs with delctype.thakis2014-10-281-3/+3
| | | | | | | | | | | No behavior change. BUG=427584 TBR=phajdan Review URL: https://codereview.chromium.org/683963002 Cr-Commit-Position: refs/heads/master@{#301710}
* Creating infrastructure for profiler instrumentation only in developer build ↵vadimt2014-10-2814-32/+162
| | | | | | | | | | | | | | | and Canary channel. This introduces TrackingProfile class that is equivalent to ScopedProfile what tracking is enabled and does nothing otherwise. There is an idea to remove the single-parametered ScopedProfile constructor, but for this CL, I’m leaving it. Otherwise, I’d have to replace ~100 ScopedProfile instantiations throughout the code with TrackingProfile, and the substantial changes would be lost in these changes. I’ll do this in a separate CL. I replaced one ScopedProfile just to make sure this will compile. BUG=401560 TBR=asanka@chromium.org Review URL: https://codereview.chromium.org/663093005 Cr-Commit-Position: refs/heads/master@{#301695}
* Clarify failure to load the crazy linker library.simonb2014-10-281-0/+1
| | | | | | | | | | | | | | | | | On failure to load libchromium_android_linker.so, we retry with libchromium_android_linker.cr.so. If the latter fails then only the name 'libchromium_android_linker.cr.so' appears in the logcat. This is confusing where (commonly) this is not a components build. Add a warning to clarify that libchromium_android_linker.cr.so is a load retry with a different name. BUG= Review URL: https://codereview.chromium.org/683163003 Cr-Commit-Position: refs/heads/master@{#301654}
* Infrastructure for enabling V8's initial snapshot to be loaded from external ↵baixo2014-10-281-11/+32
| | | | | | | | | | | | files as opposed to being statically linked to the binary. This is not currently supported on any architecture. BUG=421063 Review URL: https://codereview.chromium.org/594603003 Cr-Commit-Position: refs/heads/master@{#301595}
* [Android] Initialize CommandLine before any usage in Render.feng2014-10-281-7/+6
| | | | | | | | | | | | | | | | | | | | On low-end devices, if Chrome was upgraded from a previous version, Chrome decides to use normal mode to keep user experience consistent. This is done by force '--low-end-device-mode=0' on both browser and render processes. However, when crazy linker is used, Linker.isUsed() triggers SysUtils.detectLowEndDevice() call which checks CommandLine first. Existing code invokes Linker.isUsed() before initilizing CommandLine, which causes the render process ignores '--low-end-device-mode=0'. This results the browser in normal mode, but render is in low-end device mode. BUG=424228 Review URL: https://codereview.chromium.org/665273003 Cr-Commit-Position: refs/heads/master@{#301581}
* NOTREACHED should use DCHECK if DCHECK_ALWAYS_ON is set on cros.oshima2014-10-281-1/+1
| | | | | | Review URL: https://codereview.chromium.org/686573003 Cr-Commit-Position: refs/heads/master@{#301555}
* Cleanup: Remove some unneeded timer.h includes.thestig2014-10-272-1/+1
| | | | | | Review URL: https://codereview.chromium.org/645343004 Cr-Commit-Position: refs/heads/master@{#301475}
* remove DIR_LOCAL_APP_DATA_LOW from base.cpu2014-10-273-23/+2
| | | | | | | | | | | Not used except for cloud print. BUG=426573 TBR=rvargas Review URL: https://codereview.chromium.org/681533002 Cr-Commit-Position: refs/heads/master@{#301473}
* Listen to Off The Record profiles in ContentSettingsHandler.scheib2014-10-271-1/+4
| | | | | | | | | | | | | | | | | | | | | | ContentSettingsHandler is now made aware of Off The Record profiles and will observe them as well, correcting bugs where changes from the settings webUI would function incorrectly. This is a rework of a previously landed fix [fix] which was reverted due to a crash bug [crash] when OTR profiles already existed before settings were opened. [fix] https://codereview.chromium.org/585953003 [crash] https://code.google.com/p/chromium/issues/detail?id=417597 BUG=425079, 418931 Committed: https://crrev.com/c9ba380c606442a025a38eb67f4d35c65b1a293c Cr-Commit-Position: refs/heads/master@{#301273} Review URL: https://codereview.chromium.org/676083003 Cr-Commit-Position: refs/heads/master@{#301461}
* Add brettw's guidelines about what should be in base to base/OWNERS.thakis2014-10-271-0/+13
| | | | | | | | | BUG=none NOTRY=true Review URL: https://codereview.chromium.org/686463002 Cr-Commit-Position: refs/heads/master@{#301417}
generated by cgit v1.1 at 2025-01-30 21:52:27 +0000