summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Added a thread pool to WorkerPool for Linux that dynamically adds threads as ↵willchan@chromium.org2009-03-246-19/+504
| | | | | | | | needed. Review URL: http://codereview.chromium.org/39102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12414 0039d316-1c4b-4281-b951-d872f2087c98
* Use scoped_ptr to prevent memory leaks on test failures.patrick@chromium.org2009-03-241-19/+12
| | | | | | Review URL: http://codereview.chromium.org/50027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12409 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly instantiate the string16 backer exactly once, avoiding problems inmark@chromium.org2009-03-242-0/+43
| | | | | | | shared library builds and an Apple ld bug Review URL: http://codereview.chromium.org/49023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12406 0039d316-1c4b-4281-b951-d872f2087c98
* SHARED_INTERMEDIATE_DIR is a better place for generated headers.mmoss@chromium.org2009-03-242-6/+4
| | | | | | | | | | Also, use chrome path calculated relative to version.sh, since the passed-in path isn't correct on the buildbot. Review URL: http://codereview.chromium.org/42574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12401 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new histogram macro to replace a few explicit calls.rvargas@google.com2009-03-241-1/+12
| | | | | | | | There is no real change in functionality. Review URL: http://codereview.chromium.org/42514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12400 0039d316-1c4b-4281-b951-d872f2087c98
* Include version information in Linux chrome.mmoss@chromium.org2009-03-243-23/+39
| | | | | | | | | | | This makes use of, and scons-enables, the Linux version header in Issue 45028. BUG=8132 Review URL: http://codereview.chromium.org/42542 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12387 0039d316-1c4b-4281-b951-d872f2087c98
* Use a correct templatized WriteInto for all string typesmark@chromium.org2009-03-241-13/+5
| | | | | | Review URL: http://codereview.chromium.org/53014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12372 0039d316-1c4b-4281-b951-d872f2087c98
* Generate header file of Linux version information (currently gyp-only).mmoss@chromium.org2009-03-242-0/+56
| | | | | | | | | | | | This isn't yet #included in file_version_info_linux.cc since we haven't officially cutover to the gyp build. BUG=8132 Review URL: http://codereview.chromium.org/45028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12369 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DirectoryWatcherTest.SubDirNonRecursive on Windows versionsphajdan.jr@chromium.org2009-03-242-3/+14
| | | | | | | | earlier than Vista. Review URL: http://codereview.chromium.org/42564 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12361 0039d316-1c4b-4281-b951-d872f2087c98
* Enable non-recursive watches for Windows DirectoryWatcher.phajdan.jr@chromium.org2009-03-243-57/+42
| | | | | | | | | | | - enable test for it on Windows - clean up directory_watcher_unittest.cc http://crbug.com/5072 Review URL: http://codereview.chromium.org/42388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12358 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing problem with ScopedVariant in official builds.tommi@chromium.org2009-03-232-4/+1
| | | | | | | | BUG=9197 TBR=jon Review URL: http://codereview.chromium.org/47007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12318 0039d316-1c4b-4281-b951-d872f2087c98
* Skip WatchdogTest.AlarmTest under Valgrind to avoid five-minute hang.dkegel@google.com2009-03-231-0/+2
| | | | | | | | See http://crbug.com/9194 Review URL: http://codereview.chromium.org/52025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12312 0039d316-1c4b-4281-b951-d872f2087c98
* Improve scoped_cftyperef<> and scoped_nsobject<> reset() semantics.mark@chromium.org2009-03-232-11/+11
| | | | | | Review URL: http://codereview.chromium.org/52018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12301 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing Mac headers to base.gypmark@chromium.org2009-03-232-1/+11
| | | | | | Review URL: http://codereview.chromium.org/42509 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12286 0039d316-1c4b-4281-b951-d872f2087c98
* Add scoped_nsobject to help handle ownership of NSObject subclass objects bymark@chromium.org2009-03-232-0/+79
| | | | | | | C++ code. Review URL: http://codereview.chromium.org/52014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12283 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to detect impact of disabling dns prefetching on transaction latencyjar@chromium.org2009-03-232-8/+22
| | | | | | | | | This is also meant to exercise the field trial infrastructure. r=mbelshe Review URL: http://codereview.chromium.org/50084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12271 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium side of trackbar drawing. This is needed to support <input ↵pkasting@chromium.org2009-03-202-20/+126
| | | | | | | | | | | type="range">. This code will not be called until I land the upstream hooks to RenderThemeChromiumWin.cpp to use it. BUG=8931 Review URL: http://codereview.chromium.org/42451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12231 0039d316-1c4b-4281-b951-d872f2087c98
* Update the gyp Linux build:sgk@google.com2009-03-201-1/+32
| | | | | | | | | | | | | | | | | | | | | | | | * Add Linux settings to target_defaults in common.gypi so gyp-generated SConscript files no longer depend on build/SConscript.main or the Hammer infrastructure. * Copy the FilterOut() function from Hammer to the chromium_builders.py Tool module. * Add a ChromiumLoadableModule() builder to chromium_builders.py. * Add dependencies on the 'views' library to the chrome link (target 'app'). * Add missing views/*/*_unittest.cc modules to the 'unit_tests' target. Exclude all but the one that builds on Linux from the non-Windows builds. * Crib a list of chrome/views files to exclude from the Linux build from the old SCons configuration. * Add a new build/linux/system.gyp file with new 'settings' targets to encapsulate the pkg-config checks for gtk+-2.0, nss and pangoft2. * Add depenedencies in the other targets on the new gtk, nss and pangoft2 'settings' targets from build/linux/system.gyp. * Add a pkg_config_wrapper.py script that keeps gyp happy by simply exiting 0 if the package isn't found. * DEPS roll for latest gyp changes to support the above. Review URL: http://codereview.chromium.org/42340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12228 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of tiny near-bugs and bugs that static analysis identifiedjar@chromium.org2009-03-195-8/+8
| | | | | | | r=mbelshe,brettw Review URL: http://codereview.chromium.org/50014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12166 0039d316-1c4b-4281-b951-d872f2087c98
* Reorder some stuff to be in alphabetical order in preparation for adding ↵pkasting@chromium.org2009-03-192-246/+246
| | | | | | | | more. No functional change. Review URL: http://codereview.chromium.org/42418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12164 0039d316-1c4b-4281-b951-d872f2087c98
* Test was examining a variable without first acquiring a required Lock.ralphl@chromium.org2009-03-194-11/+35
| | | | | | | Also changed Lock::AssertAcquired to be const function (it already was const, in practice, just not declared that way). Review URL: http://codereview.chromium.org/42402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12157 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc 4.3 warning in directory_watcher_inotify.ccphajdan.jr@chromium.org2009-03-191-2/+8
| | | | | | | | - check return value of write to self-pipe Review URL: http://codereview.chromium.org/42403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12150 0039d316-1c4b-4281-b951-d872f2087c98
* Call two more shutdown functions, and set an environment variable, dkegel@google.com2009-03-191-0/+9
| | | | | | | | | | | | to make nss play well with valgrind, as recommended by Wan-Teh in http://groups.google.com/group/mozilla.dev.tech.crypto/msg/49fe8582df376d06 Set the same environment variables in chrome_test.sh/valgrind_test.py and valgrind.sh, and explain which is which. Review URL: http://codereview.chromium.org/42326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12093 0039d316-1c4b-4281-b951-d872f2087c98
* Add some UBC eviction code after talking to Amit (and it doesn't even requirethomasvl@chromium.org2009-03-191-3/+21
| | | | | | | a kext) :) Review URL: http://codereview.chromium.org/42391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12090 0039d316-1c4b-4281-b951-d872f2087c98
* ScopedVariant implementation.tommi@chromium.org2009-03-195-0/+593
| | | | | | | | | | | | | | A class for automatically freeing a COM VARIANT at the end of a scope. Additionally provides a few functions to make the encapsulated VARIANT easier to use. Instead of inheriting from VARIANT, I took the containment approach in order to have more control over the usage of the variant and guard against memory leaks. Review URL: http://codereview.chromium.org/46059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12081 0039d316-1c4b-4281-b951-d872f2087c98
* Added a debug method AssertAcquired() that compiles to nothing in non-debug ↵ralphl@chromium.org2009-03-183-28/+49
| | | | | | | | | | | | | | | | | builds. In debug builds, the method will DCHECK if the current thread does not hold the lock. I also removed a class that was not being used (AutoLockImpl) which seems like someone just copied the Lock.h file and blindly added an Impl for the AutoLock class. Thre are places in my code where I want to use the AutoUnlock class. I can't see why it was restricted to use by the condition variable class only, so I just made it into a regular class with no restrictions. I noticed that JamesR posted a CL about a month ago that made AutoUnlock a public class, but it was never committed, so I added him to this CL for review too. Review URL: http://codereview.chromium.org/48109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12037 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: build fix for systems without inotify headersagl@chromium.org2009-03-182-0/+31
| | | | | | | Review URL: http://codereview.chromium.org/42363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12024 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in DirectoryWatcher:phajdan.jr@chromium.org2009-03-183-68/+63
| | | | | | | | | | | - share more code between different platforms - put more code inside anonymous namespace - add more DISALLOW_COPY_AND_ASSIGNs - small #include cleanup Review URL: http://codereview.chromium.org/42343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12007 0039d316-1c4b-4281-b951-d872f2087c98
* The test suite commandline leak is easy to plug, so we may as well.dkegel@google.com2009-03-181-1/+3
| | | | | | | | | | | | | | | | | Fixes 244 bytes in 5 blocks are possibly lost in loss record 57 of 97 at operator new(unsigned int) m_replacemalloc/vg_replace_malloc.c:230 by std::string::_Rep::_S_create(unsigned int, unsigned int, std::allocator<char> const&) (in libstdc++.so.6.0.9) by (within libstdc++.so.6.0.9) by std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) (in libstdc++.so.6.0.9) by CommandLine::CommandLine(int, char const* const*) src/base/command_line.cc:96 by CommandLine::Init(int, char const* const*) src/base/command_line.cc:177 by TestSuite::TestSuite(int, char**) src/base/test_suite.h:34 Review URL: http://codereview.chromium.org/42341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11999 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/ref_counted.h.thestig@chromium.org2009-03-181-1/+0
| | | | | | Review URL: http://codereview.chromium.org/48105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11974 0039d316-1c4b-4281-b951-d872f2087c98
* Port DirectoryWatcher to Linux using inotify.phajdan.jr@chromium.org2009-03-187-49/+492
| | | | | | Review URL: http://codereview.chromium.org/42037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11962 0039d316-1c4b-4281-b951-d872f2087c98
* Change the stub for file_util::EvictFileFromSystemCachethomasvl@chromium.org2009-03-181-3/+4
| | | | | | | | | | I don't think there is a way to get something out of the UBC once it's in, so for now I'm just making this api return true so it won't fail unittests. I have email out to Amit incase he has any ideas. Review URL: http://codereview.chromium.org/42333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11961 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize module_handle_ in IATPatch's constructor.deanm@chromium.org2009-03-181-1/+2
| | | | | | | | | The uninitialized value wasn't used since it was guarded by other members, but it is still better to initialize the member explicitly. Review URL: http://codereview.chromium.org/48130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11959 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused bool member variable "opened_" from StatsTable.deanm@chromium.org2009-03-181-6/+6
| | | | | | | Review URL: http://codereview.chromium.org/48129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11956 0039d316-1c4b-4281-b951-d872f2087c98
* Minor DCHECK cleanups in libevent.willchan@chromium.org2009-03-171-2/+3
| | | | | | | | DCHECK=>DCHECK_EQ where possible. Change a DCHECK not to fire on write() returning -1 && errno==EAGAIN, since this happens normally under heavy load. Review URL: http://codereview.chromium.org/42295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11919 0039d316-1c4b-4281-b951-d872f2087c98
* Some upstream code assumes that the executable path from the path service isthomasvl@chromium.org2009-03-171-15/+4
| | | | | | | | | | | | | | | | standardized, but NSBundle makes not such promise, so we standardize it ourselves. While here, remove the app data dir support since it seems the installer and windows sandbox are the only things that need it. Moved that code upstream to the chrome paths... Directly handle the user data dir w/in the chrome path service call back, return different things for chrome vs. chromium. Review URL: http://codereview.chromium.org/48089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11910 0039d316-1c4b-4281-b951-d872f2087c98
* Use "org.chromium" in place of "com.google.chrome" in posix temporary file ↵estade@chromium.org2009-03-171-0/+4
| | | | | | | | names for non-chrome builds. Review URL: http://codereview.chromium.org/46087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11897 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect guards in base/.deanm@chromium.org2009-03-178-17/+22
| | | | | | | | | This doesn't change _H_ vs _H__, it just fixes guards that didn't properly match the filename. Adds a guard to clipboard_util.h which was previously guardless. Review URL: http://codereview.chromium.org/42278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11856 0039d316-1c4b-4281-b951-d872f2087c98
* Add targets for page_cycler_tests, perf_tests and startup_tests. Listedsgk@google.com2009-03-161-0/+17
| | | | | | | | | | minimal dependencies to build on Linux, Windows will need more. Make a 'test_support_base' library containing the .cc files used in common by perf tests in both net and chrome. Review URL: http://codereview.chromium.org/48021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11803 0039d316-1c4b-4281-b951-d872f2087c98
* Change Pickle to double its capacity by default, rather than increasingmpcomplete@google.com2009-03-162-4/+6
| | | | | | | | | incrementally, when it needs to expand on writing data. BUG=8760 Review URL: http://codereview.chromium.org/46056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11769 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/time.h.thestig@chromium.org2009-03-167-5/+9
| | | | | | Review URL: http://codereview.chromium.org/48019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11766 0039d316-1c4b-4281-b951-d872f2087c98
* Change DCHECK( == 0) to DCHECK_EQ in the posix lock implementation.deanm@chromium.org2009-03-161-7/+7
| | | | | | | | | It is helpful to see the actual value during a check failure. Review URL: http://codereview.chromium.org/42225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11741 0039d316-1c4b-4281-b951-d872f2087c98
* Port visitedlink tests to Linux. Also make them pass on Linux, whichphajdan.jr@chromium.org2009-03-163-0/+13
| | | | | | | | | | | | | may fix the attached bug. The problem was that the debug check was in wrong place (too early, before every member was initialized), so it failed in the test. BUG=8710 Review URL: http://codereview.chromium.org/48005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11734 0039d316-1c4b-4281-b951-d872f2087c98
* This should make ProcessUtilTest.KillSlowChild not-flaky.phajdan.jr@chromium.org2009-03-161-9/+0
| | | | | | | | | | | | | | | | | There is no need to check process count (which tends to induce flakiness). In fact, we are already checking all important facts: - after checking that process handle is a not-null handle we know that the process started successfully - after WaitForSingleProcess returns true we know that the process finished successfully BUG=8811 Review URL: http://codereview.chromium.org/42224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11728 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded includes of gtest_prod.h. Reduce usage from 689 to 601.thestig@chromium.org2009-03-131-1/+0
| | | | | | Review URL: http://codereview.chromium.org/42189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11680 0039d316-1c4b-4281-b951-d872f2087c98
* Basic windowless plugins, try 2.evan@chromium.org2009-03-131-3/+2
| | | | | | | | | | | In response to Dean's comment on http://codereview.chromium.org/39105, I redid that patch to put the X munging into the plugin implementation. This won't work for multiproc, but it's near the correct place and many things will need to be changed for multiproc. Review URL: http://codereview.chromium.org/42056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11674 0039d316-1c4b-4281-b951-d872f2087c98
* wtc: please look at URL related code, and hooks and nitsjar@chromium.org2009-03-131-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | you might have commented on before. huanr: please look at sdch_filter code. The intent was no semantic change, and only change in histograms and stats gathered. I wanted to be sure I had better stats on several failure cases, as the turn-around time of adding stats to instrument such cases after they surface is just too long. The big feature is the mechanism for getting the total number of bytes passed to a filter. We use the filter context to achieve this, and then the SDCH filter can calculate compression ratio (from pre-gunzip vs post SDCH decompress). The number of bytes read was also histogrammed in a number of error scenarios, to better diagnose what is going on when these cases arrise (example: When some data is still buffered in the VCDIFF decoder). The sdch_filter destructor was getting long and hard to read with multiple if blocks, so I cleaned that up as well a bit (less indentation, and use of early returns). Nits not included in previous CL that earlier are listed as well. r=wtc,huanr Review URL: http://codereview.chromium.org/40319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11665 0039d316-1c4b-4281-b951-d872f2087c98
* Implement DownloadFile::Rename() for posix. Downloads work on linux!estade@chromium.org2009-03-132-3/+11
| | | | | | Review URL: http://codereview.chromium.org/46020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11659 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files ↵thestig@chromium.org2009-03-1312-6/+6
| | | | | | | | to ~400. Review URL: http://codereview.chromium.org/46039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the look of the Linux omnibox.deanm@chromium.org2009-03-132-0/+22
| | | | | | | | | | | | | | | | - Paint a border around the input widget, which makes it fit better into the toolbar. A bordered widget is also very nice to have for debugging, so I abstracted a small helper for making a bordered bin. - Improve the results popup by painting with some Pango attributes. Sort of looks awful over NX, but I'm hoping it looks better on a real session. BUG=8236 Review URL: http://codereview.chromium.org/46035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11644 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 18:57:20 +0000