| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for continuous devices (Magic Mouse and trackpad) using NSEvent
APIs introduced in 10.7.
Tweak ScrollView/ScrollBar to allow horizontal scrolling from MouseWheel
events.
BUG=363529
Review URL: https://codereview.chromium.org/456913002
Cr-Commit-Position: refs/heads/master@{#293038}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Proguard strips these methods if they are not annotated because they
are only used in tests.
TBR=brettw
BUG=163393
Review URL: https://codereview.chromium.org/528963003
Cr-Commit-Position: refs/heads/master@{#293009}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Xcode 6 introduced behavior in the iOS Simulator where the software
keyboard does not appear if a hardware keyboard is connected.
This CL enables the software keyboard when a gtest app starts up.
BUG=392433
Review URL: https://codereview.chromium.org/514223002
Cr-Commit-Position: refs/heads/master@{#292916}
|
|
|
|
|
|
|
|
|
|
|
|
| |
A switch RENDERER_WAIT_FOR_JAVA_DEBUGGER is newly added to block
ChildProcessMain thread of ChildProcessService until a Java debugger is
attached.
BUG=378975
Review URL: https://codereview.chromium.org/511683003
Cr-Commit-Position: refs/heads/master@{#292733}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a class of test flakes that impacts all Windows tests that
use registry_util::RegistryOverrideManager.
BUG=none
R=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/519773002
Cr-Commit-Position: refs/heads/master@{#292665}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium shares a message loop with Android on the browser UI thread.
This can cause problems when the associated Looper has a sync barrier,
preventing posted Chromium tasks from being dispatched until the
barrier is removed. Make this sharing more fair by marking all Chromium
Message tasks as asynchronous, avoiding stalls when there is a sync
barrier.
Note: This change is for gathering data about the perf impact and we'll
revert it before cutting a release branch.
BUG=407149,380781,407133
Review URL: https://codereview.chromium.org/512333002
Cr-Commit-Position: refs/heads/master@{#292551}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL add a ChannelProxy equivalent of the Channel benchmark
to ipc_perftests.
To use it in the benchmark, TestIOThread is extracted from
mojo/system/ to base/test
TEST=IPChannelPerfTest.ChannelProxyPingPong
R=viettrungluu@chromium.org,brettw@chromium.org,darin@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/488003003
Cr-Commit-Position: refs/heads/master@{#292518}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows the message pump code tried to manage the systemwide timer
resolution to fire delayed tasks with better than 15ms resolution but
it is buggy.
This is https://codereview.chromium.org/395913006
please see that review for rationale.
BUG=153139
TBR=jamesr,darin
TEST=included, also see bug for manual verification.
Review URL: https://codereview.chromium.org/509223002
Cr-Commit-Position: refs/heads/master@{#292493}
|
|
|
|
|
|
|
|
| |
BUG=110610
Review URL: https://codereview.chromium.org/511153002
Cr-Commit-Position: refs/heads/master@{#292429}
|
|
|
|
|
|
|
|
| |
BUG=163393
Review URL: https://codereview.chromium.org/509753002
Cr-Commit-Position: refs/heads/master@{#292394}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These functions where invaluable when trying to debug and fix the
cc::OrderedTestRunner as they let me easily inspect the tasks without having to
fire up GDB. They should also be useful in development / testing of other task
runners.
Added a very simple test for ShouldRunBefore which shows this stuff working. If
that test fails, the output looks like the following;
-------------------------------------------------------------------------------
../../base/test/test_pending_task_unittest.cc:49: Failure
Value of: task_after.ShouldRunBefore(task_first)
Actual: false
Expected: true
TestPendingTask(
{"delay":2000,"nestability":"NESTABLE","post_time":0,
"posting_function":"Unknown@Unknown:-1","run_at":2000}
).ShouldRunBefore(TestPendingTask(
{"delay":1000,"nestability":"NESTABLE","post_time":0,
"posting_function":"Unknown@Unknown:-1","run_at":1000})
)
-------------------------------------------------------------------------------
BUG=380889
Review URL: https://codereview.chromium.org/491743002
Cr-Commit-Position: refs/heads/master@{#292370}
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=asvitkine@chromium.org
Review URL: https://codereview.chromium.org/511903003
Cr-Commit-Position: refs/heads/master@{#292340}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Res is supported (patchset #7 of https://codereview.chromium.org/446203002/)
Reason for revert:
It causes a Canary crash
https://code.google.com/p/chromium/issues/detail?id=408354
The added static initializer causes a crash in libpeerconnetion used by WebRTC
Fix to reland: remove static initializer.
Original issue's description:
> We have noticed a clock shift when QPC was deployed. It shows as a regression on the perf bots
> https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928
>
> It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC).
> This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper.
>
> By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize.
>
> BUG=158234
>
> Committed: https://chromium.googlesource.com/chromium/src/+/10c40c221c314e41add0a5b4df1ee7467681a430
TBR=jar@chromium.org,willchan@chromium.org,maruel@chromium.org,thakis@chromium.org,jam@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=158234
Review URL: https://codereview.chromium.org/516693002
Cr-Commit-Position: refs/heads/master@{#292288}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently chrome creates a file path when uploading a photo taken through camera
However, this doesn't always work.
Instead, we should use content URI. See more details in the crbug.
BUG=405593
Review URL: https://codereview.chromium.org/489053003
Cr-Commit-Position: refs/heads/master@{#292257}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
two possible period values for timeBeginPeriod and timeEndPeriod.
Currently while on battery we disable calls to timeBeginPeriod
which make the windows timers have 15ms resolution.
This change makes it so when EnableHighResolutionTimer(true) which
is on AC power the timer is 1ms and EnableHighResolutionTimer(false)
is 4ms.
This should provide significant power savings while meeting some
timer resolution requirements needed by the GPU compositor.
But also this CL fixes the following:
EnableHighResolutionTimer() and ActivateHighResolutionTimer() are
pretty broken. This CL fixes most issues:
1- The existing logic fails to account that EnableHighResolutionTimer
can be called while the browser is running
2- All related functions need to be thread safe.
3- ActivateHighResolutionTimer was buggy.
BUG=153139
Review URL: https://codereview.chromium.org/489793003
Cr-Commit-Position: refs/heads/master@{#292094}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/510563002
Cr-Commit-Position: refs/heads/master@{#292050}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/506013004/)
Reason for revert:
All windows perf bots (official builds) crashing.
http://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/73062/steps/generate_telemetry_profiles/logs/stdio
ChildEBP RetAddr
0022f7c0 6a3ffa19 chrome_69c90000!base::debug::BreakDebugger+0x10
0022f830 6a400622 chrome_69c90000!CheckIsChromeSxSProcess+0x26
0022f834 6a400d52 chrome_69c90000!InstallUtil::IsChromeSxSProcess+0x16
0022f83c 6a400c29 chrome_69c90000!BrowserDistribution::GetSpecificDistribution+0x3b
0022f844 6a3fe166 chrome_69c90000!BrowserDistribution::GetDistribution+0x7
0022f930 6a3fe11d chrome_69c90000!`anonymous namespace'::GetChromeChannelInternal+0x2c
0022f948 6a092c6c chrome_69c90000!GoogleUpdateSettings::GetChromeChannel+0x21
0022f9b4 6a08f70f chrome_69c90000!chrome::VersionInfo::GetChannel+0x60
0022f9b8 6a08f65a chrome_69c90000!`anonymous namespace'::UseHooks+0x5
0022f9dc 6a08eb5a chrome_69c90000!InstallCloseHandleHooks+0x15
0022fa20 00fb7623 chrome_69c90000!ChromeMain+0x3e
0022fab0 00fb7026 chrome!MainDllLoader::Launch+0x15f
0022faf4 00fd936a chrome!wWinMain+0x5a
0022fb40 766e338a chrome!__tmainCRTStartup+0xfd
WARNING: Stack unwind information not available. Following frames may be wrong.
0022fb4c 76f99f72 kernel32!BaseThreadInitThunk+0x12
0022fb8c 76f99f45 ntdll!RtlInitializeExceptionChain+0x63
0022fba4 00000000 ntdll!RtlInitializeExceptionChain+0x36
Original issue's description:
> Improve the ScopedHandle verifier.
>
> 1. Automate the selection of the proper channel to enable the verifier.
> Now the code is enabled at runtime.
>
> 2. Switch to a hash_map to track handles.
>
> 3. Intercept CloseHandle to detect the code that is closing handles owned
> by ScopedHandles. The initial implementation only covers chrome.exe/dll,
> but the plan is to extend that in the future to all modules loaded in the
> process.
>
> BUG=362176
> R=cpu@chromium.org
> R=sky@chromium.org
>
> See https://codereview.chromium.org/490043002/ for the actual review.
>
> TBR=cpu@chromium.org
> TBR=sky@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c928d0383db43f2f4baf8f9b24ed7454bf7eda64
TBR=cpu@chromium.org,sky@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=362176
Review URL: https://codereview.chromium.org/507893002
Cr-Commit-Position: refs/heads/master@{#292047}
|
|
|
|
|
|
|
|
|
| |
BUG=374763
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/502173002
Cr-Commit-Position: refs/heads/master@{#291994}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regression on the perf bots
https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928
It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC).
This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper.
By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize.
BUG=158234
Review URL: https://codereview.chromium.org/446203002
Cr-Commit-Position: refs/heads/master@{#291974}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Automate the selection of the proper channel to enable the verifier.
Now the code is enabled at runtime.
2. Switch to a hash_map to track handles.
3. Intercept CloseHandle to detect the code that is closing handles owned
by ScopedHandles. The initial implementation only covers chrome.exe/dll,
but the plan is to extend that in the future to all modules loaded in the
process.
BUG=362176
R=cpu@chromium.org
R=sky@chromium.org
See https://codereview.chromium.org/490043002/ for the actual review.
TBR=cpu@chromium.org
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/506013004
Cr-Commit-Position: refs/heads/master@{#291969}
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the rest of the non-rtc and non-vpx linker errors for the chrome target.
BUG=
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/505853003
Cr-Commit-Position: refs/heads/master@{#291952}
|
|
|
|
|
|
|
|
|
|
|
|
| |
scoped_refptr previously got this for free since it implemented operator
T*, but the conversion operator is being removed. This prevents awkward
looking code like *my_favorite_pointer.get().
BUG=110610
Review URL: https://codereview.chromium.org/505943002
Cr-Commit-Position: refs/heads/master@{#291869}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it harder to accidently use the wrong
macro.
Also, removes the D* variants of the macros and
associated DebugNow() function. These were rarely
used and removing them removes clutter from the
header file. Existing uses converted to be behind
NDEBUG ifdefs.
No functional changes except for a fix to the
code in content_based_thumbnailing_algorithm.cc
which was incorrectly using a ternary operator for
the histogram name (which doesn't work since the
macros cache the histogram object) and removal
of local histograms Spellcheck.SuggestTime and
Spellcheck.InitTime per groby@.
Since this is an API rename, TBR'ing downstream
owners.
BUG=311349
TBR=groby@chromium.org,zea@chromium.org,jeremy@chromium.org,reveman@chromium.org,agl@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/484603006
Cr-Commit-Position: refs/heads/master@{#291840}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tie Domain Reliability uploads to metrics reporting -- halt uploads when
reporting is turned off. (Keep recording, since we will eventually be able to
access reports through JavaScript as well.)
BUG=407170
Review URL: https://codereview.chromium.org/491753003
Cr-Commit-Position: refs/heads/master@{#291740}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/476543004/)
Reason for revert:
Multiple tests are timing out on dbg bots.
Original issue's description:
> Implement unit test specific test launcher timeout
>
> BUG=402213
TBR=jam@chromium.org,dalecurtis@chromium.org,rileya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402213
Review URL: https://codereview.chromium.org/504813003
Cr-Commit-Position: refs/heads/master@{#291682}
|
|
|
|
|
|
|
|
|
| |
BUG=402213
R=dalecurtis@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/476543004
Cr-Commit-Position: refs/heads/master@{#291673}
|
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/486193003
Cr-Commit-Position: refs/heads/master@{#291456}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Chrome]HistogramTester.
Design Doc (Googlers Only):
https://docs.google.com/a/google.com/document/d/1RUY0BcxBppdkwFP3T8qbQmQStBRFGsLmuR4WuIXhiCA/edit
BUG=384011
TBR=timsteele@chromium.org
Review URL: https://codereview.chromium.org/379283002
Cr-Commit-Position: refs/heads/master@{#291207}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=302040
TBR=noelallen@chromium.org
Review URL: https://codereview.chromium.org/357623003
Cr-Commit-Position: refs/heads/master@{#291168}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current random base address generation in the Android chromium linker is prone
to error. It selects an address at random between 0x20000000 and 0x40000000 and
expects that this will be clear. This is occasionally untrue for ARM, but very
often untrue for MIPS. As a consequence, RELRO sharing is being turned off more
frequently than it could be.
This change removes the local random address generation code and instead replaces
it with code that speculatively maps a large region, captures the address returned
by mmap, then unmaps and returns the address. The expectation is that this region
will remain free for use when the time comes for the crazy linker to map the browser
into it. This generally holds because the time between these two actions is short
and little, if anything, loads or mmaps between them. Worst case is that RELRO
sharing turns off as at present, but the probability of this happening should now
be much lower.
Note that capturing the address from mmap relies on Android ASLR being active for
mmap. This is the default device state since ICS. The revised random browser
load address is only as entropic as Android's ASLR.
BUG=397634
Review URL: https://codereview.chromium.org/470053003
Cr-Commit-Position: refs/heads/master@{#291111}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the eager class registration from RegisterNatives when possible.
BUG=402003
TBR=sievers@chromium.org, brettw@chromium.org, torne@chromium.org
Review URL: https://codereview.chromium.org/491043002
Cr-Commit-Position: refs/heads/master@{#291095}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android's bionic C library is intending to adopt the same semantics as
glibc for strerror_r: define the version that returns char* if the
source is compiled with _GNU_SOURCE instead of the POSIX version which
returns int. Add __BIONIC__ to the condition for
USE_HISTORICAL_STRERRO_R so that Chromium will still work.
BUG=
Review URL: https://codereview.chromium.org/491893002
Cr-Commit-Position: refs/heads/master@{#291050}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, change the NativeLibraries template to use preprocessor defines
instead of includes. This allows us to delete all the corresponding
headers.
Then, change the ordered libraries file to be a dict with both the list
of library paths and the java-style list of library names.
Update a bunch of things that used the ordered libraries file to instead
take the list of libraries directly as an argument (as a FileArg in
every case).
Add calculating the list of libraries to write_build_config and add it
to the build config (gn can use this then instead of a separate ordered
libraries file).
Add a simple copy step in gn to set up the native libraries directory
for an apk. Use this directory when creating the apk.
BUG=359249
NOTRY=true
Review URL: https://codereview.chromium.org/456493002
Cr-Commit-Position: refs/heads/master@{#290963}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang warns:
..\..\base\files\file_path.cc(695,47) : warning(clang): cast to 'wchar_t *' from smaller integer type 'LONG' (aka 'long') [-Wint-to-pointer-cast]
wchar_t c1 = (wchar_t)LOWORD(::CharUpperW((LPWSTR)MAKELONG(*i1, 0)));
^
CharUpper() is a pretty whacko: It takes a pointer, but: """
A null-terminated string, or a single character. If the high-order word of this
parameter is zero, the low-order word must contain a single character to be
converted.""" (!)
It's not clear to me what this means on 64bit, but the code as-is casted a
32bit int (a DWORD) to a pointer, which I think doesn't guarantee that the
upper 4 byte of the 8 byte pointer are zero. So insert a cast to a pointer-wide
int type to guarantee this, and to fix this warning.
BUG=82385
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/491883003
Cr-Commit-Position: refs/heads/master@{#290905}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(the CL is only for the branch, not ToT)
> Base: Disable the scoped handle verifier.
>
> This is intended for the M38 branch. (The verifier is not intended for
> Beta/Stable)
>
> BUG=405224
> R=cpu@chromium.org
> TBR=cpu@chromium.org
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/484293002
TBR=rvargas@chromium.org
Review URL: https://codereview.chromium.org/495683002
Cr-Commit-Position: refs/heads/master@{#290892}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The documentation says that CreateProcess() can modify its second parameter
in UNICODE builds.
BUG=396705
R=scottmg@chromium.org, vitalybuka@chromium.org
TBR=cpu
Review URL: https://codereview.chromium.org/487303004
Cr-Commit-Position: refs/heads/master@{#290890}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended for the M38 branch. (The verifier is not intended for
Beta/Stable)
BUG=405224
R=cpu@chromium.org
TBR=cpu@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/484293002
Cr-Commit-Position: refs/heads/master@{#290861}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Make class lookup lazy in jni_generator when using lazy method lookup.
>
> This removes the eager class registration from RegisterNatives when possible.
>
> BUG=402003
> TBR=sievers@chromium.org, brettw@chromium.org
>
> Review URL: https://codereview.chromium.org/472553002
TBR=mkosiba@chromium.org
Review URL: https://codereview.chromium.org/492713002
Cr-Commit-Position: refs/heads/master@{#290813}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the eager class registration from RegisterNatives when possible.
BUG=402003
TBR=sievers@chromium.org, brettw@chromium.org
Review URL: https://codereview.chromium.org/472553002
Cr-Commit-Position: refs/heads/master@{#290810}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems the last place where it was used is no longer needed.
The special case was added in 2012 (https://chromiumcodereview.appspot.com/10890031)
and if somehow we still need it now, I'd rather adjust action_max_timeout
for android (in C++ sources) rather than have another kind of timeout.
BUG=none
R=ajwong@chromium.org, yfriedman@chromium.org
Review URL: https://codereview.chromium.org/485173002
Cr-Commit-Position: refs/heads/master@{#290808}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=405076
TEST=none
Review URL: https://codereview.chromium.org/485193002
Cr-Commit-Position: refs/heads/master@{#290725}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=405074
R=scottmg@chromium.org
TBR=brettw, davidben
Review URL: https://codereview.chromium.org/468773003
Cr-Commit-Position: refs/heads/master@{#290612}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a window is on a secondary screen, and "Displays have separate spaces"
option is turned on, the menu bar is not hidden during immersive fullscreen
mode. The problem was that the logic to hide the menu bar was incorrectly
determining whether the screen had a menu bar.
After fixing the logic, I also had to introduce a minor hack to counteract the
"helpfulness" of AppKit. See http://crbug.com/403203 for further details.
BUG=396980
Review URL: https://codereview.chromium.org/467093002
Cr-Commit-Position: refs/heads/master@{#290598}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows Chrome to accept a Handoff from any app when Chrome is the default
browser. This has been manually tested.
Note that getting this to work in Yosemite DP5 requires manual modification of
the Info.plist prior to codesigning, as well as Chrome to be built as a 64-bit
binary. The former is an Apple bug, and the latter won't matter, since we're
phasing Chrome off of 32-bits. See bug for more details.
BUG=381516
Review URL: https://codereview.chromium.org/481563002
Cr-Commit-Position: refs/heads/master@{#290404}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Make sActivityInfo a ConcurrentHashMap instead of just a HashMap.
BUG=403951
Review URL: https://codereview.chromium.org/479603003
Cr-Commit-Position: refs/heads/master@{#290379}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WebRTC bots happen to run with gtest filters, but want to run tests
in parallel anyway. It makes sense for bot mode to disregard the gtest
filter rule, which is a good heuristic in other cases.
BUG=402089
Review URL: https://codereview.chromium.org/485733002
Cr-Commit-Position: refs/heads/master@{#290274}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Linux/Mac/FreeBSD platform, NumberOfProcessors() was returning the number of
online processors. Change it to return the number of configured processors
(incl. offline processors).
1. Most callers of this API expect it to return totally available cpu cores,
mainly for threading optimization.
2. The number of online processors is changed within seconds on some embedded
platforms. It is wrong to pass the cached value of the number of currently
online processors to Blink sandbox.
BUG=404364
TEST=Tested on nyan (it may have 1~4 cpu cores online)
Review URL: https://codereview.chromium.org/454053002
Cr-Commit-Position: refs/heads/master@{#290209}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A recent Linux kernel change changed this to a number larger than 63 bits which causes us to compute 0 size.
I kept the size_t overflow check for cases where size_t is 32-bits.
BUG=403869
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/471893003
Cr-Commit-Position: refs/heads/master@{#289903}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failures by default.
Previously, gtest-based tests would not run tests in parallel or retry failures
by default unless you specified the --test-launcher-bot-mode flag
This patch changes the behavior so that we run tests in parallel and retry failures by
default if we are running *all* of the tests (i.e., --gtest_filter was *not* specified).
You can still pass --test-launcher-jobs=X to control how many tests run in parallel,
and --test-launcher-retry-limit=0 to turn retries off and
--test-launcher-retry-limit=X to control how many times to retry.
R=jam@chromium.org, phajdan.jr@chromium.org, ojan@chromium.org, tonyg@chromium.org
BUG=402089
Review URL: https://codereview.chromium.org/469533002
Cr-Commit-Position: refs/heads/master@{#289839}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As of r287591 the android chromium linker supports EM_X86_64 and x86_64
relocations. Remove the restriction preventing libchromium_android_linker.so
building when arch=x64.
BUG=369133
Review URL: https://codereview.chromium.org/470133003
Cr-Commit-Position: refs/heads/master@{#289683}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289683 0039d316-1c4b-4281-b951-d872f2087c98
|