summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Clang: enable -Wbool-conversions and -Wunused-variables on Linux.hans@chromium.org2011-01-144-43/+42
| | | | | | | | | | | | | | | -Wbool-conversion warns about EXPECT_EQ(false, blah), so replace that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah) for good measure (even though that doesn't generate warnings). Also remove the one instance of an unused variable. BUG=69421 TEST=buildbots all compile and all tests pass Review URL: http://codereview.chromium.org/6300001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up threading model of external extension providersgfeher@chromium.org2011-01-143-46/+0
| | | | | | | | | | | Move blocking IO of loading the lists of external extensions from the UI thread to the FILE thread. Remove the ExternalPolicyExtensionProvider-specific parts from ExtensionsService. Side-effects: reduce the number of PostTask operations from 9 to 4. Trigger uninstall of external extensions immediately after they are removed from a policy. BUG=65107,63667 TEST=ExtensionManagementTest.ExternalPolicyRefresh for the new functionality, lot of other extension tests are updated Review URL: http://codereview.chromium.org/5742008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71427 0039d316-1c4b-4281-b951-d872f2087c98
* NSS: don't set environment variables when multi-threaded.agl@chromium.org2011-01-132-0/+21
| | | | | | | | | | | | | We can't alter the envionment once we have gone multithreaded because glibc's getenv doesn't take the environment lock. Thus we add an EarlyNSSInit() function which can do so, early in startup. BUG=66835 TEST=ThreadSanitizer http://codereview.chromium.org/6185005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71351 0039d316-1c4b-4281-b951-d872f2087c98
* Added WARN_UNUSED_RESULT to ScopedTempDir methods.cbentzel@chromium.org2011-01-132-7/+7
| | | | | | | | | BUG=NONE TEST=all targets build, tests pass. Review URL: http://codereview.chromium.org/6042009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71322 0039d316-1c4b-4281-b951-d872f2087c98
* NSS: PKCS 11 password prompt.mattm@chromium.org2011-01-133-0/+58
| | | | | | | | | | | This was based off of davidben's WIP cl http://codereview.chromium.org/3186021/show. BUG=42073 TEST=add password to NSS DB with "certutil -d sql:.pki/nssdb -W", try client auth, <keygen>, cert manager Review URL: http://codereview.chromium.org/5686002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71281 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GrabWindowSnapshot for Mac Chrome.rkc@chromium.org2011-01-121-9/+19
| | | | | | | | | | | Changed the mechanism to take a screenshot over to CG; we now just take a direct bit dump of the window into an image and convert that to a png. BUG=69160 TEST=Tested with sending feedback from a Mac; screenshot appeared on screen and on the report correctly. Review URL: http://codereview.chromium.org/6121005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71233 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing several typos in gyp files detected by jeanluc's forthcoming changes ↵bradnelson@google.com2011-01-111-1/+1
| | | | | | | | | | | to gyp. BUG=None TEST=None Review URL: http://codereview.chromium.org/6130007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71082 0039d316-1c4b-4281-b951-d872f2087c98
* Add workaround for VS2005 compile error introduced by r70933akalin@chromium.org2011-01-111-3/+27
| | | | | | | | | BUG=None TEST=compiles on VS2005 Review URL: http://codereview.chromium.org/6198003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71081 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-114-19/+30
| | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
* Order function definitions in base/ according to the header.erg@google.com2011-01-1132-971/+973
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6085015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70975 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the stubbed out headers in chrome/browser/views.msw@chromium.org2011-01-101-3/+3
| | | | | | | | | | | | | | | | | Update references to use headers in chrome/browser/ui/views. Update copyright dates in affected files. /chrome/browser/ui/views/constrained_html_delegate_win.cc Add space before 'private' label (presubmit warning) /chrome/browser/ui/views/toolbar_view.cc Add space before 'cleanup' label (presubmit warning) BUG=69082 TEST=Compiling... Review URL: http://codereview.chromium.org/6204002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70965 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak atomicops implementation for Mac OS X to compile correctly when __LP64__mark@chromium.org2011-01-101-11/+12
| | | | | | | | | | | | | | is defined. Patch by Ben Karel <eschew@gmail.com>. BUG=54554 TEST= - base_unittests --gtest_filter='AtomicOpsTest.*' - Compile base/string_util.cc (outside of Chromium) as 64-bit code on Mac OS X 10.6. Review URL: http://codereview.chromium.org/6091007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70942 0039d316-1c4b-4281-b951-d872f2087c98
* Made ObserverListThreadSafe's destructor private since it's ref-counted.akalin@chromium.org2011-01-101-7/+9
| | | | | | | | | BUG=None TEST=Compiles Review URL: http://codereview.chromium.org/3832006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70933 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70920 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-104-30/+19
| | | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6099012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-104-19/+30
| | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
* Fix file descriptor leak in base_unittests ProcessUtilTest.LaunchApp. Themark@chromium.org2011-01-101-2/+5
| | | | | | | | | | TestLaunchApp helper function should close base_unittests' end of the pipe. BUG=none TEST=base_unittests --gtest_filter=ProcessUtilTest.LaunchApp Review URL: http://codereview.chromium.org/6128004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70901 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Remove base/scoped_handle_win.h."tfarina@chromium.org2011-01-099-55/+51
| | | | | | | | | | | | | | | Fixed the problem with rlz library. Now should be fine to land this again. This reverts commit 3620d9501af7bff688862c54fdd60f7eb41797f3. Original Review URL: http://codereview.chromium.org/6126002/ BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove base/scoped_handle_win.h stub and fix up all callers to use ↵thakis@chromium.org2011-01-079-51/+55
| | | | | | | | | | the new location and namespace." This reverts r 70795, it broke the build. TBR=vandebo git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70802 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/scoped_handle_win.h stub and fix up all callers to use the new ↵tfarina@chromium.org2011-01-079-55/+51
| | | | | | | | | | | location and namespace. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6126002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70795 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-073-26/+15
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-073-15/+26
| | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
* Make the order of methods in the cc files match the headers in base/.erg@google.com2011-01-078-412/+395
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6189001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70771 0039d316-1c4b-4281-b951-d872f2087c98
* Support OVERRIDE for clang.thakis@chromium.org2011-01-071-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6165001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70763 0039d316-1c4b-4281-b951-d872f2087c98
* Start sorting methods in class declarations.erg@google.com2011-01-0736-281/+317
| | | | | | | | | | | | | | | | | | | | | | | | A lot of our headers are a mess and aren't organized. Impose the following order on files in the base/ directory: class Blah { each public/protected/private section: typedefs; enums; static constants; ctors; dtors; methods; overridden virtual methods; data members; }; BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70749 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath.tfarina@chromium.org2011-01-073-37/+0
| | | | | | | | | | | Fix the callers and remove the deprecated function. BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6111003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70705 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove deprecated file_util::GetFilenameFromPath function.tfarina@chromium.org2011-01-063-21/+1
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6057010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70610 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove unnecessary includes from scoped_handle_win.htfarina@chromium.org2011-01-051-4/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5988009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70500 0039d316-1c4b-4281-b951-d872f2087c98
* Increasing live (sync) operation timeout to 45 seconds.rsimha@chromium.org2011-01-041-1/+1
| | | | | | | | | | | | | | | | | The sync integration tests were using a timeout of 30 seconds for live operations. Some of the sync stress tests are timing out because it takes longer for a full sync cycle to complete. This patch increases the timeout to 45 seconds, and should eliminate the occasional failures on the builders. TBR=tim@chromium.org BUG=68207 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6023011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70451 0039d316-1c4b-4281-b951-d872f2087c98
* Typo fix.avi@chromium.org2011-01-041-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6049009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70433 0039d316-1c4b-4281-b951-d872f2087c98
* Add SCOPED_TRACEs to ICUStringConversionsTestphajdan.jr@chromium.org2011-01-041-0/+20
| | | | | | | | | | | | to help debug http://bugs.gentoo.org/show_bug.cgi?id=350347 They are also useful in general, so I don't plan to remove them later. BUG=none TEST=none Review URL: http://codereview.chromium.org/5982003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70430 0039d316-1c4b-4281-b951-d872f2087c98
* MessageLoop: use dynamic_annotations.h & RunningOnValgrind instead of ↵timurrrr@chromium.org2011-01-041-5/+5
| | | | | | | | | | valgrind.h & RUNNING_ON_VALGRIND This way we'll be able to delete all tasks on Windows under Dr. Memory TEST=trybots Review URL: http://codereview.chromium.org/6073004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70425 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'using' declaration of ScopedBitmap from scoped_handle_win.htfarina@chromium.org2011-01-031-1/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6013010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70400 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mac build by fixing some include pathsbrettw@chromium.org2011-01-022-2/+2
| | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70375 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'using' declaration of ScopedHGlobal from scoped_handle_win.htfarina@chromium.org2011-01-021-1/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6058007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70371 0039d316-1c4b-4281-b951-d872f2087c98
* Move CancellationFlag and WaitableEvent to the synchronization subdirectory.brettw@chromium.org2011-01-0221-65/+63
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5977010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70369 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/lock and base/condition_variable to base/synchronization/brettw@chromium.org2011-01-0124-239/+281
| | | | | | | | | | | I kept a base/lock.h in place with a using statement to avoid updating all callers in one CL. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6018013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70363 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/debug_on_start to base/debugger and rename it to be _win since itbrettw@chromium.org2011-01-015-16/+31
| | | | | | | | | | only does anything on Windows. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5984007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70362 0039d316-1c4b-4281-b951-d872f2087c98
* move base/object_watcher into base/win and add the win namespace. Fixup callers.brettw@google.com2011-01-017-24/+32
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5971008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70360 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/mac_util.h to base/mac and use the base::mac namespace.brettw@chromium.org2011-01-017-38/+41
| | | | | | | | | | | Fix up callers to use the new location & namespace. Remove includes from  files where it wasn't necessary. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6046009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70359 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/debug_util. Move the debug UI related functions to ↵brettw@google.com2011-01-0111-60/+58
| | | | | | | | | | | | base/debug/debugger.h Move the OS X specific crash report changing function to base/mac/os_crash_dumps TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6092005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70358 0039d316-1c4b-4281-b951-d872f2087c98
* Move non_thread_safe from base to base/threading and into the base namespace.brettw@chromium.org2011-01-017-16/+26
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6005010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70351 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/platform_thread.h stub and fix up all callers to use the new ↵brettw@google.com2011-01-012-27/+3
| | | | | | | | | location and namespace. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70346 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/thread.h to base/threading, fix up callers to use the new location.brettw@chromium.org2011-01-0138-50/+50
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6028009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70345 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/win_util to app/win and fix the namespace usage.brettw@google.com2010-12-311-1/+1
| | | | | | | | | | | | | | Split out the two classes: ScopedComInitializer and ScopedCOMem (which I renamed) to separate files. I removed the win_util_path file which had one function in it and moved the function to win_util. Somehow, this was getting picked up by the nacl64 build and the call in sandbox_policy was then not being defined. I just implemented the function in-plcae since it's just a simple wrapper around a Windows API call. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6013009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70343 0039d316-1c4b-4281-b951-d872f2087c98
* Move platform_thread to base/threading and put in the base namespace. I left abrettw@chromium.org2010-12-3153-264/+327
| | | | | | | | | | | stub and "using" declarations in the old location to avoid having to change the entire project at once. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6001010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70342 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/win_util to the base/win directory and use the base::win namespace.brettw@google.com2010-12-317-38/+64
| | | | | | | | | Fix up includes, many files including base/win_util don't actually need it. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70341 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'using' declaration of ScopedHDC from scoped_handle_win.htfarina@chromium.org2010-12-311-1/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6031011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70326 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Check for NULL display.sadrul@chromium.org2010-12-301-0/+6
| | | | | | | | | | The display can be NULL when, for example, the message pump is created for a plugin. BUG=none TEST=none TBR=sadrul@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70325 0039d316-1c4b-4281-b951-d872f2087c98
* Move thread local stuff from base to base/threading and consistently use thebrettw@chromium.org2010-12-3017-45/+63
| | | | | | | | | | | base namespace. This also fixes references to TLSSlot to base::ThreadLocalStorage::Slot. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5986012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70322 0039d316-1c4b-4281-b951-d872f2087c98
* Fix exclusion for the worker pool posix unit test on Windows.brettw@chromium.org2010-12-301-1/+1
| | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70316 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-28 22:36:36 +0000