summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* linux (and some posix): multiprocess plugins compiling.evan@chromium.org2009-04-232-0/+12
| | | | | | | | | | | | | | | | | | | The goal of this change is to *not* make any behavioral change, but to instead just get all the plugin-related files linking on Linux with a bunch of NOTIMPLEMENTED()s in the appropriate places. It's enormous enough already without any refactorings or new features. Changes include: - Lots of gcc warning fixes. - Use portable replacements for Windows-specific functions (_strdup, etc.). - Use TransportDIB instead of just shared memory in the plugin messaging. Note that this is not fleshed out on Linux and on Windows it just hacks in the existing handles so there should be no functional change. - Fix --plugin-launcher to use cross-platform APIs. Review URL: http://codereview.chromium.org/79020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14338 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling flaky StatsTableTest.MultipleThreads on Linux too.robertshield@google.com2009-04-231-3/+2
| | | | | | | | | | | Fails here for example: http://build.chromium.org/buildbot/waterfall/builders/Modules%20Linux%20(dbg)/builds/7281/steps/base_unittests/logs/stdio BUG=http://code.google.com/p/chromium/issues/detail?id=10611 Review URL: http://codereview.chromium.org/92075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14330 0039d316-1c4b-4281-b951-d872f2087c98
* The PPID is in kp_eproc, not kp_proc. (The field we were previously looking ↵avi@google.com2009-04-231-1/+1
| | | | | | | | at was always zero.) Review URL: http://codereview.chromium.org/96009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14316 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting http://codereview.chromium.org/87039 on behalf of hamaji.erikkay@google.com2009-04-232-3/+20
| | | | | | Review URL: http://codereview.chromium.org/92053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14304 0039d316-1c4b-4281-b951-d872f2087c98
* Protect RandUint64 against EINTR.phajdan.jr@chromium.org2009-04-233-3/+24
| | | | | | Review URL: http://codereview.chromium.org/77022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14297 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with bookmark bar introduced by window sharing; prefjrg@chromium.org2009-04-231-0/+6
| | | | | | | | | | | | change needs to change all open windows with the same preferences, not just the current one). Improve unit testing. Limit bookmark menu size width (1st pass). Cleanup/delete of code which no longer does much. Review URL: http://codereview.chromium.org/79068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14282 0039d316-1c4b-4281-b951-d872f2087c98
* Enable more tests, change a NOTREACHED to a bug since it's not fatal in the ↵pinkerton@chromium.org2009-04-221-1/+1
| | | | | | | | download code. Get other tests compiling even if disabled. Mark why tests are failing in gyp file. Review URL: http://codereview.chromium.org/92033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14239 0039d316-1c4b-4281-b951-d872f2087c98
* Ensures we don't leak handles in ProcessUtil::GetAppOutput.jcampan@chromium.org2009-04-221-7/+7
| | | | | | | | TEST=Run base_unit_tests BUG=None Review URL: http://codereview.chromium.org/93030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14235 0039d316-1c4b-4281-b951-d872f2087c98
* StopWatchingFileDescriptor needs to free struct event.dkegel@google.com2009-04-223-11/+108
| | | | | | | | | | | Also, there's no point in using scoped_ptr for event_ anymore, so removed that. Should fix http://crbug.com/10503 "Crash in network layer" Review URL: http://codereview.chromium.org/87045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14233 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DIR_SOURCE_ROOT to work in bundles like Chromium.app. Add more ui tests. ↵pinkerton@chromium.org2009-04-221-4/+16
| | | | | | | | Add a resource for tabs with no title on mac. Fix window title reporting. Remove the Browser dependency from the tab strip (only needs a TabStripModel). Review URL: http://codereview.chromium.org/93025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14212 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14152.thestig@chromium.org2009-04-215-9/+21
| | | | | | | TBR=tony Review URL: http://codereview.chromium.org/87066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14154 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using and remove deprecated file_util::TrimTrailingSeparator().thestig@chromium.org2009-04-215-21/+9
| | | | | | Review URL: http://codereview.chromium.org/67271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14152 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak when we fail to load a gdkpixbuf. I meant to do this intc@google.com2009-04-211-0/+24
| | | | | | | | | the last change, but forgot. Review URL: http://codereview.chromium.org/69042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14143 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using and remove deprecated file_util::TrimFilename().thestig@chromium.org2009-04-212-12/+0
| | | | | | Review URL: http://codereview.chromium.org/67267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14142 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a utility method that lets you start a process and block until ↵jcampan@chromium.org2009-04-213-7/+122
| | | | | | | | | | | | | the process terminates, and retrieve what the process printed to the standard output. That util function is needed for the new in-process test framework. It is Windows only for now. BUG=None TEST=Covered by new unit test. Review URL: http://codereview.chromium.org/87008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14135 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate a circular dependency by making BGRAToRGBA() generic (no pulling ↵sgk@google.com2009-04-216-28/+56
| | | | | | | | in guchar from gtk.h) and moving it from base/gfx to base. Review URL: http://codereview.chromium.org/87016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14117 0039d316-1c4b-4281-b951-d872f2087c98
* More solid detection of browser process in chrome_process_util_linux.cc:phajdan.jr@chromium.org2009-04-212-5/+12
| | | | | | | | | | | | | | | | - use GetAppOutput instead of popen - make unexpected conditions fatal (otherwise the tests using this code would mistakenly assume that there is no running browser process) Also add a constant for SingletonSocket. Make necessary adjustments to GetAppOutput - ignore stderr (because fuser prints the file name to stderr and having stderr in |output| would require more parsing). Review URL: http://codereview.chromium.org/77031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14091 0039d316-1c4b-4281-b951-d872f2087c98
* Implement file_util::CountFilesCreatedAfter() for posix environments.evan@chromium.org2009-04-213-6/+42
| | | | | | | | | BUG=9833 Review URL: http://codereview.chromium.org/87003 Patch from Shinichiro Hamaji <hamaji@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14081 0039d316-1c4b-4281-b951-d872f2087c98
* plugins: move NativeLibrary into base.evan@chromium.org2009-04-215-0/+171
| | | | | | | | | | NativeLibrary is used by some plugin code under chrome/. Rather than including webkit/glue there, this relocation is the smallest logical bite to take. :\ Review URL: http://codereview.chromium.org/87012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14071 0039d316-1c4b-4281-b951-d872f2087c98
* posix: port PrependCommand to Windows and use for the plugin launcher.evan@chromium.org2009-04-202-1/+10
| | | | | | Review URL: http://codereview.chromium.org/88006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14065 0039d316-1c4b-4281-b951-d872f2087c98
* Landing this patch for Jamesr.mad@chromium.org2009-04-202-0/+20
| | | | | | | | CR was done at: http://codereview.chromium.org/67257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14048 0039d316-1c4b-4281-b951-d872f2087c98
* Add a FieldTrial and histograms for measuring impact of http prioritization.willchan@chromium.org2009-04-201-1/+1
| | | | | | | | | Currently this FieldTrial is measuring the transaction latencies of requests, separated into frame/subframe requests vs subresource requests. We run a 2% holdback experiment where the people in the holdback don't have http prioritization enabled. Add class static method to ResourceDispatcherHost to disable http prioritization. BUG=10486 Review URL: http://codereview.chromium.org/67119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14040 0039d316-1c4b-4281-b951-d872f2087c98
* Hide the Fullscreen exit bubble if the mouse goes idle. It took a ↵pkasting@chromium.org2009-04-202-0/+7
| | | | | | | | | | | depressing amount of time for me to think my way through this algorithm :( Along the way I added an operator=() to convert from POINT to gfx::Point() since doing explicit temp conversion for a case like this annoys me. BUG=10568 Review URL: http://codereview.chromium.org/67265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14031 0039d316-1c4b-4281-b951-d872f2087c98
* Disable StatsTableTest.MultipleThreads since it is flaky under heavy load.maruel@chromium.org2009-04-201-0/+5
| | | | | | | BUG=10611 Review URL: http://codereview.chromium.org/79010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14029 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the test ConditionVariableTest.MultiThreadConsumerTest until it is ↵maruel@chromium.org2009-04-201-1/+2
| | | | | | | | | | stable. BUG=10607 R=jar Review URL: http://codereview.chromium.org/79002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14028 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in LaunchApp:phajdan.jr@chromium.org2009-04-181-17/+11
| | | | | | | | | | - don't copy argv strings - use pid_t instead of int - simplify the control flow a bit Review URL: http://codereview.chromium.org/77024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14004 0039d316-1c4b-4281-b951-d872f2087c98
* Retrial of the first step to port file_util::CountFilesCreatedAfter()erikkay@google.com2009-04-187-19/+47
| | | | | | | | | Submitting http://codereview.chromium.org/75033 on behalf of hamaji Review URL: http://codereview.chromium.org/67276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13993 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetAppOutput function, a better replacement for popen.phajdan.jr@chromium.org2009-04-173-0/+92
| | | | | | | | | | | | It will replace popen call in chrome_process_util_linux. I don't see much benefit in having a Windows implementation (not many useful programs you can launch and get output), so POSIX-only. Review URL: http://codereview.chromium.org/67226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13920 0039d316-1c4b-4281-b951-d872f2087c98
* Minor tweaks to deal with the split between CFBundleVersionjrg@chromium.org2009-04-161-1/+6
| | | | | | | | | (which has numerical limits) and Chrome version (which does not). Use Chrome version when we can. Review URL: http://codereview.chromium.org/79021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13881 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing include needed for malloc.thestig@chromium.org2009-04-161-0/+1
| | | | | | | | Patch by Craig Schlenter <craig.schlenter@gmail.com> Review URL: http://codereview.chromium.org/67228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13864 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit previous change with GYP files fixed.erg@google.com2009-04-162-68/+0
| | | | | | | | | | | | | Implement BookmarkContextMenuGtk and hook it up to most bookmark bar elements. Also: - Fixes window dispositions (shift-click works on bookmark bar items). - Reorganizes gtk_utils Original Review URL: http://codereview.chromium.org/76002 Review URL: http://codereview.chromium.org/67223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13857 0039d316-1c4b-4281-b951-d872f2087c98
* Have ResourceBundle own GdkPixbufs.tc@google.com2009-04-161-2/+0
| | | | | | | | | | | | | | | | | This is the same as how ResourceBundle owns the SkBitmaps it loads. This should be faster than before because ResourceBundle will only load each bitmap once and cache the image. Also fix a memory leak in GdkPixbufFromSkBitmap. valgrind says we're not leaking here. BUG=9988 Review URL: http://codereview.chromium.org/67179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13847 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts the previous two commits. (r13812 and r13811).erg@google.com2009-04-152-0/+70
| | | | | | Review URL: http://codereview.chromium.org/75023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13813 0039d316-1c4b-4281-b951-d872f2087c98
* Implement BookmarkContextMenuGtk and hook it up to most bookmark bar elements.erg@google.com2009-04-152-70/+0
| | | | | | | | | | Also: - Fixes window dispositions (shift-click works on bookmark bar items). - Reorganizes gtk_utils Review URL: http://codereview.chromium.org/76002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13811 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TimerTest.RepeatingTimer the suspected test in base_unittests whichnirnimesh@chromium.org2009-04-151-0/+5
| | | | | | | | hangs under Valgrind on Mac. Review URL: http://codereview.chromium.org/73054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13791 0039d316-1c4b-4281-b951-d872f2087c98
* base_unittests.exe is still timing out in the testwtc@chromium.org2009-04-151-0/+3
| | | | | | | | | | | SignatureVerifierTest.BasicTest on the Purify bot, so we still need to disable this test. R=erikkay BUG=10031 Review URL: http://codereview.chromium.org/67172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13754 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 13748.erikkay@google.com2009-04-153-21/+18
| | | | | | Review URL: http://codereview.chromium.org/73084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13751 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting http://codereview.chromium.org/73075 on behalf of ↵erikkay@google.com2009-04-153-18/+21
| | | | | | | | shinichiro.hamaji@gmail.com Review URL: http://codereview.chromium.org/73083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13748 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the negative test cases in the testwtc@chromium.org2009-04-152-3/+9
| | | | | | | | | | | SignatureVerifierTest.BasicTest when running inside Purify because Purify disables digital signature verification. R=erikkay BUG=10031 Review URL: http://codereview.chromium.org/69010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13724 0039d316-1c4b-4281-b951-d872f2087c98
* Few changes to the NTP remove thumbnails:jcampan@chromium.org2009-04-151-2/+5
| | | | | | | | | | | | | | - some minor string changes - there is now a Cancel button next to the Done button to restore the thumbnails removed during the current editing session - link and favico are opacified as well in remove mode - now using a dictionary instead of a list to store the URL blacklist for faster access - now storing URL hashes instead of URLs (for privacy and also because the DictionaryValue breaks down keys on . characters) BUG=None TEST=Make sure removing thumbnails works as expected. Start removing thumbnails then click Cancel, verify that the thumbnails just removed are restored. Review URL: http://codereview.chromium.org/69007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13723 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up icon loader/manager in preparation for porting.estade@chromium.org2009-04-141-0/+4
| | | | | | | | Remove a bunch of unused functions and change wstrings to filepaths and remove an obsolete enum. Review URL: http://codereview.chromium.org/73007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13718 0039d316-1c4b-4281-b951-d872f2087c98
* Save and restore the value of GetLastError() when [D]LOG/[D]CHECK etc on ↵tommi@google.com2009-04-142-0/+28
| | | | | | | | | | Windows. Also for log levels higher than INFO, the value of GLE is tagged onto the log message. Review URL: http://codereview.chromium.org/73010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13667 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the internal GetStringF to use string16. This saves atc@google.com2009-04-143-50/+54
| | | | | | | | | | | | | | | conversion from string16 to wstring on the linux side when calling GetStringFUTF8 methods. It actually adds extra conversions when calling GetStringF, but we're going to get rid of all those, right? BUG=9911 Review URL: http://codereview.chromium.org/67112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13666 0039d316-1c4b-4281-b951-d872f2087c98
* Typo in test is exposed as a flaky testjar@chromium.org2009-04-141-1/+1
| | | | | | | | | | | | | I recently updated these tests to reduce flakiness, but there was a typo in one line of the update. Since tasks were run serially, the total time to run N-1 tasks should be greater than or EQUAL to the task durtaion, times N-1. r=mark Review URL: http://codereview.chromium.org/74003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13640 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cast style.erg@google.com2009-04-131-1/+1
| | | | | | | | TBR=deanm Review URL: http://codereview.chromium.org/67084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13603 0039d316-1c4b-4281-b951-d872f2087c98
* Report what went wrong when initializing NSS_NoDB_Init.erg@google.com2009-04-131-2/+10
| | | | | | | | BUG=9857 Review URL: http://codereview.chromium.org/71009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13602 0039d316-1c4b-4281-b951-d872f2087c98
* Disable gcc 4.4 warnings about hash_map and hash_set beingtc@google.com2009-04-131-0/+14
| | | | | | | | | | | deprecated. backward_warning.h in gcc 4.4.0 wraps the warning around an ifdef __DEPRECATED. Review URL: http://codereview.chromium.org/67056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13599 0039d316-1c4b-4281-b951-d872f2087c98
* Disables the test SignatureVerifierTest.BasicTest on the purify bot assky@chromium.org2009-04-131-0/+3
| | | | | | | | | | | | | it's either crashing or hanging server. I've filed bug 10031 to track this. BUG=10031 TEST=none TBR=erikkay Review URL: http://codereview.chromium.org/67081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13594 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce flakiness of condition var unit test by reducing timing dependence.jar@chromium.org2009-04-111-40/+75
| | | | | | | | | | | | | Re-enable test, with hopes that external changes plus my changes reduce flakyness sufficiently. Also switch to using standard sleep method for better readability. bug=3599 r=mark Review URL: http://codereview.chromium.org/19729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13557 0039d316-1c4b-4281-b951-d872f2087c98
* Set the svn:eol-style properties of these new files to LF.wtc@chromium.org2009-04-102-10/+10
| | | | | | | | | | | Normalize the CRLF line endings to LF in signature_verifier.h and signature_verifier_unittest.cc. R=erikkay BUG=6305 Review URL: http://codereview.chromium.org/67060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13548 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 13:48:04 +0000