summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Fix a bunch of clang warnings/errors.thakis@chromium.org2010-09-213-24/+26
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60109 0039d316-1c4b-4281-b951-d872f2087c98
* Support for building Chrome using Clang.evan@chromium.org2010-09-181-1/+8
| | | | | | | | | | | | | | | | To build, set the clang=1 gyp_define. This patch is the culmination of many months of effort and many patches. It contains the minimal changes to Chrome that are Clang-specific. With this, I can build the "chrome" target. Once this patch is in, we can incrementally fix bits of Chrome and various tests and remove the Clang-specific workarounds. Review URL: http://codereview.chromium.org/522020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59882 0039d316-1c4b-4281-b951-d872f2087c98
* Fix removal of multiple observers in ObserverListThreadSafe.willchan@chromium.org2010-09-172-5/+49
| | | | | | | | | BUG=55725 TEST=ObserverListThreadSafeTest.RemoveMultipleObservers Review URL: http://codereview.chromium.org/3381009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59833 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Replace the existing browser-child mach ipc with a long-lived listener ↵rohitrao@chromium.org2010-09-174-131/+28
| | | | | | | | | | | | | | | | | on a well-known port. Before this CL: Before fork()ing a child, the browser process creates a mach receive port with a random name. After the fork() but before exec(), the child uses mach ipc to transmit send rights to its task port. The child has access to the random name because it inherits it from the browser process. Unfortunately, some of the library functions involved in sending a mach message are not safe to call after fork(). After this CL: Before forking the first child, the browser spins off a new thread that listens on a well-known port for mach ipc from any process. This well-known port is "com.google.Chrome.<browserpid>". When a child process starts up, it sends a mach message to its parent browser's well-known port. On the browser side, we listen for said message, extract the pid of the sending process, and ignore any messages from processes we did not personally fork(). This check is necessary because any arbitrary process on the system could send mach ipc to that port. BUG=35374 TEST=Browser should still start up. The task manager should still show correct cpu/memory data. There should be no perf regressions. TEST=Mac ui_tests and browser_tests should be less flaky. Review URL: http://codereview.chromium.org/3443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59782 0039d316-1c4b-4281-b951-d872f2087c98
* Make a destructor protected per darin@'s request in a previous code review.erg@google.com2010-09-161-2/+4
| | | | | | | | | | TBR=darin@chromium.org BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3390010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59737 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style guide errors in commentsdpolukhin@chromium.org2010-09-162-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3402004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59622 0039d316-1c4b-4281-b951-d872f2087c98
* Various style fixes (indenting, captitalization, adding some comments).levin@chromium.org2010-09-161-13/+16
| | | | | | | | | | | Also removed a function that is no longer called. BUG=None TEST=Build works. Review URL: http://codereview.chromium.org/3453006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59592 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move Extension::LaunchContainer to extension_constants.h.erg@google.com2010-09-162-0/+5
| | | | | | | | | | | This makes browser.h not depend on extension.h. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3399008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59588 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bad URLRequest leak detection. nss_ocsp creates asky@chromium.org2010-09-152-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | URLRequest. This URLRequest, if valid, is deleted when the IO thread is being shutdown by way of a DestructionObserver attached to the IO thread. Prior to this patch this proves problematic as the LeakTracker is run before DestructionObservers, which means we were errorenously detecting a leak and causing random UI failures (and perhaps other tests). To fix this I've moved the LeakTracker to run after the IO thread MessageLoop has been deleted (which means DestructionObservers have been notified). Doing this triggered a DCHECK in ChromeNetLog::AddEntry: DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO)); Here's the full stack: StackTrace::StackTrace() [0xf247c1] logging::LogMessage::~LogMessage() [0xf3ef4f] ChromeNetLog::AddEntry() [0x5c9639] net::BoundNetLog::AddEntry() [0x147d8a3] net::BoundNetLog::AddEvent() [0x147d92a] net::internal::ClientSocketPoolBaseHelper::CancelRequest() [0x132d032] net::ClientSocketPoolBase<>::CancelRequest() [0x134aabd] net::TCPClientSocketPool::CancelRequest() [0x1348fdb] net::ClientSocketHandle::ResetInternal() [0x13273b7] net::ClientSocketHandle::Reset() [0x1327874] net::ClientSocketHandle::~ClientSocketHandle() [0x1327895] scoped_ptr<>::~scoped_ptr() [0x1304b97] net::HttpStreamRequest::~HttpStreamRequest() [0x1300933] base::RefCounted<>::Release() [0xa15b83] scoped_refptr<>::operator=() [0x12f2da4] net::HttpNetworkTransaction::~HttpNetworkTransaction() [0x12ee377] scoped_ptr<>::~scoped_ptr() [0x12e2724] net::HttpCache::Transaction::~Transaction() [0x12e10a6] scoped_ptr<>::reset() [0x12d1f0b] URLRequestHttpJob::DestroyTransaction() [0x142229e] URLRequestHttpJob::Kill() [0x14252e5] URLRequest::DoCancel() [0x137af1e] URLRequest::Cancel() [0x137b081] (anonymous namespace)::OCSPRequestSession::CancelURLRequest() [0x13142a7] (anonymous namespace)::OCSPRequestSession::WillDestroyCurrentMessageLoop() [0x1314b30] MessageLoop::~MessageLoop() [0xf421ab] base::Thread::ThreadMain() [0xf71395] ThreadFunc() [0xf54338] start_thread [0x7ff66c6d83f7] 0x7ff669d5cbbd This is still on the IO thread, but the DCHECK fails because at the time the DestructionObservers are run Thread::message_loop() returns NULL, which means the DCHECK fails. I've fixed this by changing the DCHECK to pass if the current thread's message loop is NULL. I feel a bit quesy about this as it seems a bit fragile (well, all this code is fragile). I would be inclined to make Thread::message_loop() return the MessageLoop until after the destructor has run, but this seems equally risky. Let me know what you prefer. BUG=52022 TEST=none Review URL: http://codereview.chromium.org/3402006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59566 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Fix FileUtilTest so multiple test instances can run in parallel.phajdan.jr@chromium.org2010-09-151-110/+106
| | | | | | | | | BUG=54098 TEST=base_unittests Review URL: http://codereview.chromium.org/3444003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59548 0039d316-1c4b-4281-b951-d872f2087c98
* Change platform_file_unittest.cc to report the time values when andumi@chromium.org2010-09-151-6/+9
| | | | | | | | | | | assertion fails. TEST=none BUG=55517 Review URL: http://codereview.chromium.org/3428003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59535 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chrome build for 10.6 SDK.jrg@chromium.org2010-09-151-2/+6
| | | | | | | | | | | Should fix Mac coverage bot compile errors. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3380005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59531 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitStringDontTrim functions from string_util.h to string_split.htfarina@chromium.org2010-09-157-47/+91
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3366011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some simple code typos spotted while investigating bug 54229.evan@chromium.org2010-09-141-3/+3
| | | | | | | | TEST=compiles Review URL: http://codereview.chromium.org/3432002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59446 0039d316-1c4b-4281-b951-d872f2087c98
* Lock log files when reiniting them.davemoore@chromium.org2010-09-141-100/+148
| | | | | | | | | | | | This is a second attempt of this cl: http://codereview.chromium.org/3195014/show BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/3347016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59439 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of match preview tweaks:sky@chromium.org2010-09-141-1/+1
| | | | | | | | | | | | | | | | . Makes MatchPreview owned by Browser rather than each TabContents. . Makes MatchPreview dismiss when the omnibox closes. . Supports the ability to send script to the page rather than reloading on every keystroke. . Supports receiving results from the page that drives the suggest text in the omnbox. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3332022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a stupid bug in GetRunningOnValgrind, this is a copy of TSan r2453 changetimurrrr@chromium.org2010-09-141-1/+1
| | | | | | | | TEST=RunningOnValgrind() should be fixed on Windows TBR=glider Review URL: http://codereview.chromium.org/3437001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59359 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run PlatformFile.TouchGetInfoPlatformFile under Valgrindtimurrrr@chromium.org2010-09-141-0/+3
| | | | | | | | BUG=55517 TBR=glider Review URL: http://codereview.chromium.org/3400002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59351 0039d316-1c4b-4281-b951-d872f2087c98
* Implement SymmetricKey::Import for HMAC-SHA-1 keys on Windows.wtc@chromium.org2010-09-142-14/+20
| | | | | | | | | | | | | | Port SymmetricKeyTest.ImportGeneratedKey and SymmetricKeyTest.ImportDerivedKey to all platforms. On Mac, the salt for PBKDF2 must be at least 8 bytes long. R=tim BUG=none TEST=base_unittests --gtest_filter=SymmetricKeyTest.ImportDerivedKey should pass on Windows. Review URL: http://codereview.chromium.org/3361020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59330 0039d316-1c4b-4281-b951-d872f2087c98
* clang: don't build unused functionevan@chromium.org2010-09-131-0/+2
| | | | | | | | | | This function is not used when the tested #define isn't available. TEST=compiles Review URL: http://codereview.chromium.org/3290001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59247 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58786 - Adding debugging info for thread name.eroman@chromium.org2010-09-111-18/+0
| | | | | | | | | | | | | This temporary instrumentation has already yielded the intended data, so it is no longer necessary. BUG=54307 Review URL: http://codereview.chromium.org/3337012 TBR=huanr@chromium.org Review URL: http://codereview.chromium.org/3322020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59178 0039d316-1c4b-4281-b951-d872f2087c98
* Make the glob matcher support UTF8 strings.mnissler@chromium.org2010-09-104-58/+139
| | | | | | | | | | | This generalizes the existing pattern matching code to support UTF8 strings. BUG=53158 TEST=string_util_unittests.cc Review URL: http://codereview.chromium.org/3295018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59071 0039d316-1c4b-4281-b951-d872f2087c98
* Adding some functions that operate on file handles.dumi@chromium.org2010-09-108-56/+857
| | | | | | | | | | TEST=platform_file_unittest.cc BUG=none TBR=darin Review URL: http://codereview.chromium.org/3354020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59041 0039d316-1c4b-4281-b951-d872f2087c98
* Fix CheckFalseTest.CheckFails on Linux after my change to ui_test.phajdan.jr@chromium.org2010-09-092-15/+27
| | | | | | | | | | | | | This makes PathService clear its cache after overriding a path. We have many paths depending on each other, so this is necessary to avoid inconsistencies. TEST=ui_tests in Release mode BUG=49838 Review URL: http://codereview.chromium.org/2805100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59021 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59007 - Adding some utility functions that work on file handles, and ↵dumi@chromium.org2010-09-098-854/+55
| | | | | | | | | | | | | | | | | adding the corresponding relays to file_util_proxy. BUG=none TEST=none Review URL: http://codereview.chromium.org/3303007 TBR=dumi@chromium.org Review URL: http://codereview.chromium.org/3371011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59013 0039d316-1c4b-4281-b951-d872f2087c98
* Adding some utility functions that work on file handles, and addingdumi@chromium.org2010-09-098-55/+854
| | | | | | | | | | | | the corresponding relays to file_util_proxy. BUG=none TEST=none Review URL: http://codereview.chromium.org/3303007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59007 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Time::FromDoubleT so that it will return null time when 0 is passed.jianli@chromium.org2010-09-092-0/+15
| | | | | | | | | | | | This is the rework of this issue before previous submit is reverted. We need to fix the usage of Time::FromDoubleT(0) in extension history API. BUG=none TEST=non Review URL: http://codereview.chromium.org/3295001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58953 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in CBU16_IS_SURROGATEjshin@chromium.org2010-09-081-2/+2
| | | | | | | | | | | | It's pointing to U_IS_SURROGATE instead of CBU_IS_SURROGATE. BUG=NONE TEST=CBU16_IS_SURROGATE works fine in base. TBR=brettw Review URL: http://codereview.chromium.org/3294018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58866 0039d316-1c4b-4281-b951-d872f2087c98
* Adding debugging info for thread name.huanr@chromium.org2010-09-081-0/+18
| | | | | | | | | | | | This may not provide enough information to analyze the bug, but it is a start with minimal impact. BUG=54307 TEST=none Review URL: http://codereview.chromium.org/3337012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58786 0039d316-1c4b-4281-b951-d872f2087c98
* Add recursive flag to file_util_proxy::CreateDirectory.kinuko@chromium.org2010-09-082-3/+8
| | | | | | | | | BUG=54352 TEST=all the FileSystemOperationTest.TestCreateDir* should continue to pass Review URL: http://codereview.chromium.org/3293009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58781 0039d316-1c4b-4281-b951-d872f2087c98
* Change ICU_UTIL_DATA_IMPL on Linux to match the reality.jshin@chromium.org2010-09-071-4/+2
| | | | | | | | | | | | | | | | | We've bundled the ICU data file for 'ages' on Linux, but ICU_UTIL_DATA_IMPL on Linux is still set to ICU_UTIL_DATA_FILE. Apparently, this hasn't been noticed because u_setDataDirectory and udata_setFileAccess just set the global variable pointing to the data file location. This is not totally free because u_setDataDirectory does some locking/unlocking. BUG=NONE TEST=Builds go through on Linux and binaries (chrome, test, etc) run just fine. Review URL: http://codereview.chromium.org/3329012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58725 0039d316-1c4b-4281-b951-d872f2087c98
* 2nd attempt: Write the outcome of the Toast Experiment for system-level ↵finnur@chromium.org2010-09-072-10/+31
| | | | | | | | | | | | | | installs to the right registry key. This time with the two boolean parameters in process_util_win.cc:281 flipped to match the function signature. TBR=cpu BUG=44378 TEST=None Review URL: http://codereview.chromium.org/3297015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58693 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58639 - nsylvain@chromium.org2010-09-072-31/+10
| | | | | | | | | | | | | | | | This seems to have caused some ui_tests to fail (AllowCookies, BlockCookies) Original comment: Write the outcome of the Toast Experiment for system-level installs to the right registry key. BUG=44378 TEST=None Review URL: http://codereview.chromium.org/3308003 TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/3369002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58667 0039d316-1c4b-4281-b951-d872f2087c98
* Write the outcome of the Toast Experiment for system-level installs to the ↵finnur@chromium.org2010-09-062-10/+31
| | | | | | | | | | | right registry key. BUG=44378 TEST=None Review URL: http://codereview.chromium.org/3308003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58639 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate a benign race between task_.get() and task_.reset()glider@chromium.org2010-09-061-1/+5
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/3365009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58625 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some duplicated includes.tfarina@chromium.org2010-09-042-2/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3358014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58582 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58576 - Adds logging into fork_and_get_task() to test a hypothesis on ↵rohitrao@chromium.org2010-09-041-7/+0
| | | | | | | | | | | | | | | why WaitForInitialLoads() is failing. Will be reverted soon. BUG=None TEST=None Review URL: http://codereview.chromium.org/3353012 TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/3354009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58579 0039d316-1c4b-4281-b951-d872f2087c98
* Adds logging into fork_and_get_task() to test a hypothesis on why ↵rohitrao@chromium.org2010-09-041-0/+7
| | | | | | | | | | | | WaitForInitialLoads() is failing. Will be reverted soon. BUG=None TEST=None Review URL: http://codereview.chromium.org/3353012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58576 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Move the reset of signal handlers to be very soon after the fork, ↵rohitrao@chromium.org2010-09-041-6/+16
| | | | | | | | | | | | | | | | | | | | | | | before we do any mach IPC. The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible. Nico would like me to mention that this was his idea. This is take two. I couldn't reproduce the unit_tests failures either locally or on the release try bots. BUG=35374 TEST=If in the forever backwards spinner state, closing the tab should not quit the browser. TEST=In general, renderers and extensions and plugins should still work. Review URL: http://codereview.chromium.org/3302009 TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/3322013 TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/3360009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58572 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58558 - [Mac] Move the reset of signal handlers to be very soon after ↵rohitrao@chromium.org2010-09-031-16/+6
| | | | | | | | | | | | | | | | | | the fork, before we do any mach IPC. The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible. Nico would like me to mention that this was his idea. BUG=35374 TEST=If in the forever backwards spinner state, closing the tab should not quit the browser. TEST=In general, renderers and extensions and plugins should still work. Review URL: http://codereview.chromium.org/3302009 TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/3322013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58560 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Move the reset of signal handlers to be very soon after the fork, ↵rohitrao@chromium.org2010-09-031-6/+16
| | | | | | | | | | | | | | | before we do any mach IPC. The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible. Nico would like me to mention that this was his idea. BUG=35374 TEST=If in the forever backwards spinner state, closing the tab should not quit the browser. TEST=In general, renderers and extensions and plugins should still work. Review URL: http://codereview.chromium.org/3302009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58558 0039d316-1c4b-4281-b951-d872f2087c98
* Add a term feature extractor for client-side phishing detection.bryner@chromium.org2010-09-032-0/+11
| | | | | | | | | | | | | | | | | | | | This class creates features for n-grams in the page text that appear in the phishing classification model. It will eventually operate on the plain text that is extracted by RenderView::CaptureText(). To make it harder for phishers to enumerate the terms in the classification model, they will be supplied as SHA-256 hashes rather than plain text. The term feature extractor hashes the words in the document in order to check whether they match the model. Since this is potentially expensive, the term feature extractor limits how long it will run on each iteration, similar to the PhishingDOMFeatureExtractor. TEST=PhishingTermFeatureExtractorTest BUG=none Review URL: http://codereview.chromium.org/3214002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58537 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the default argument from RegKey::ReadValue.tfarina@chromium.org2010-09-031-6/+1
| | | | | | | | | BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Review URL: http://codereview.chromium.org/3259005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58456 0039d316-1c4b-4281-b951-d872f2087c98
* Moving file_util::FileInfo to base::PlatformFileInfo, and adding thedumi@chromium.org2010-09-039-26/+38
| | | | | | | | | | | | last_accessed and creation_time fields. BUG=none TEST=none Review URL: http://codereview.chromium.org/3347005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58454 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands 58186:bryeung@chromium.org2010-09-0316-1920/+0
| | | | | | | | | | | | | | | | | | | | Original message: """ Move the keyboard files from base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 """ TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58438 0039d316-1c4b-4281-b951-d872f2087c98
* Change file_util_proxy::Entry::isDirectory to is_directory.kinuko@chromium.org2010-09-022-3/+5
| | | | | | | | | BUG=54228 TEST=none, just code cleanup Review URL: http://codereview.chromium.org/3357003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58415 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from ↵akalin@chromium.org2010-09-0215-0/+1909
| | | | | | | | | | | | | | | | | | | | | base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 TBR=bryeung@chromium.org Review URL: http://codereview.chromium.org/3337006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-0215-1909/+0
| | | | | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58388 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add comment explaining why we create the mach receive port when we do.rohitrao@chromium.org2010-09-021-0/+4
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3217010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58357 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run ProcessUtilTest.CalcFreeMemory under TSan on Windowstimurrrr@chromium.org2010-09-021-0/+3
| | | | | | | | BUG=54229 TBR=glider Review URL: http://codereview.chromium.org/3290005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58333 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 16:23:03 +0000