| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had not unloaded them as a premature optimization, thinking it'd be
better to leave 'em around since they'll eventually be loaded by a page.
But that happens in the plugin process and reading the mime type happens
in the browser process, so it didn't help anyway.
BUG=17444
Review URL: http://codereview.chromium.org/160303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Plugins need to keep their symbol visibility correct.
BUG=17557
Review URL: http://codereview.chromium.org/160302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allow the src_url argument of Clipboard::ReadHTML and the
html and base_url arguments of ClipboardUtil::CFHtmlToHtml
to be NULL.
Fix nits reported by cpplint.py.
In Clipboard::SetGtkClipboard, use strdup to duplicate
strings.
R=tony
BUG=http://crbug.com/17101
TEST=none
Review URL: http://codereview.chromium.org/160247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
negative.
Add a unit test for WriteData(NULL, 0).
R=darin
BUG=none
TEST=new unit test should pass
Review URL: http://codereview.chromium.org/159310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/17839
Review URL: http://codereview.chromium.org/160217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
references to each other) anywhere in the Chromium code base.
BUG=none
TEST=rebuild
Review URL: http://codereview.chromium.org/159523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
cycle."
This reverts r21826.
Review URL: http://codereview.chromium.org/160261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=willchan
Review URL: http://codereview.chromium.org/159491
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to get a handle on a number of browser crashes, this patch
adds an options for Google internal folks to upload full core files
when the browser crashes. The core files are uploaded to an internal
IP address and will be available to other developers.
This is only enabled for Chrome branded builds and then, only if
--google-internal-crash-reporting is given on the command line.
http://codereview.chromium.org/160212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/74001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Use long for int64 (still 64 bits) to avoid annoying nspr clash.
- Fix some incorrect define guards and add some functions to atomicops.
Review URL: http://codereview.chromium.org/159428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
va_copy is a builtin, you can't just pass it references like we did previously.
Review URL: http://codereview.chromium.org/160191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specifying "frame_color" and "inactive_frame_color" in the gtk_color_scheme.
Also attempts to do a better job matching the frame color. Most window
managers (defined as metacity default theme and xfwm's default theme)
take bg[SELECTED] tint it by 80%. We hand code that behaviour in, as it
will be wrong a smaller percentage of the time then our current
behaviour.
http://crbug.com/16271 (dark theme bug)
http://crbug.com/13967 (theme color metabug)
Review URL: http://codereview.chromium.org/160188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since our packagers have been requesting that we support using more
system libraries, I'm starting to commit these sorts of changes.
However, please note that one MUST NOT use the system libpng on, at
least, Ubuntu 64-bit. Because Chromium on Linux is still a 32-bit
build we end up with the 32-bit compat versions of libraries and, on
Ubuntu at least, this includes a very old libpng with security issues.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Symbol `SSL_ImplementedCiphers' has different size in shared object, consider re-linking"
if SSL_ImplementedCiphers is different size on target system than it was on build system.
BUG=12826
TEST=run on Jaunty, look for "Symbol `SSL_ImplementedCiphers' has different size in shared object" in console output
Review URL: http://codereview.chromium.org/118367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Original review: http://codereview.chromium.org/160050
Patch by dhg@google.com
Review URL: http://codereview.chromium.org/159347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unfortunately, hash_map<> does not know how to hash a string16 when string16 isn't a wstring. I looked in <tr1/functional> and saw that only std::string and std::wstring have hashing functions.
This change adds a hashing function for string16's when they're not the same as a std::wstring.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
get rid of kEnableSVG
BUG=12272
TEST=I made it load an svg for the download shelf and it worked. SVGZ did not work.
Review URL: http://codereview.chromium.org/159247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16095
Review URL: http://codereview.chromium.org/160035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17363
Review URL: http://codereview.chromium.org/159297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- reduce header dependencies by using bookmark_model_observer.h
- replace #include <iostream> by #include <iosfwd> in headers
Review URL: http://codereview.chromium.org/159280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 26f9edf949e1678d4f8a3479518568b8a6e1972c.
Review URL: http://codereview.chromium.org/160033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16095
Review URL: http://codereview.chromium.org/160020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
conditions.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This splits the ipc code from the common project. The 'common' project pulls in
all of webkit, the v8 bindings, skia, googleurl, and a number of other projects
which makes it very difficult to deal with especially for external projects
wanting just to use some of Chromium's infrastructure. This puts the ipc code
into its top-level ipc/ directory with a dependency only on base. The common
project depends on the new ipc/ipc.gyp:ipc target so that all projects currently
pulling common in to get the IPC code still have it available. This mostly
follows agl's pre-gyp attempt to do this which was r13062.
Known issues:
- Currently a number of projects depend on chrome/chrome.gyp:common in order to
use the IPC infrastructure. Rather than fixing all of these dependencies I have
made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules
section of DEPS so that checkdeps.py doesn't complain. Over time projects that
need IPC should depend on the IPC project themselves and dependencies on common
removed, although I don't think many projects that need IPC will be able to get
away without common currently.
- ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a
ipc/ should not refer to files in chrome/... now. I'm not sure how to resolve
this since it's really an IDE bug
- the named pipe name (windows+linux) and the logging event name (all) + env
variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion
of ipc/ being an independent library. I think this should be examined in a
subsequent, much smaller patch.
- I've eliminated the IPC.SendMsgCount counter since it was implemented in a way
to create a dependency from ipc/ to chrome/common/chrome_counters. This is the
same approach that r13062 took.
http://codereview.chromium.org/155905
(Patch from James Robinson)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=willchan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155906
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
failure conditions.
BUG=17329
TEST=none
Review URL: http://codereview.chromium.org/159201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Joel Stanley.
BUG=http://crbug.com/16251
Review URL: http://codereview.chromium.org/149455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
"skia/ext/platform_canvas.h"
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159057
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
be aggregated separately from standard Chrome on Linux
Review URL: http://codereview.chromium.org/155101
Patch from Chris Masone <cmasone@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11507
TEST=Open options, click change proxy, gnome-network-preferences should launch. If gnome isn't installed or running, LinuxProxyConfig wiki page should load.
Review URL: http://codereview.chromium.org/155792
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrappers that launch Chromium will need to set CHROMIUM_SAVED_GTK_PATH before
modifying GTK_PATH. This can be done later in separate CLs.
BUG=15565
TEST=see bug
Review URL: http://codereview.chromium.org/159112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16887
TEST=paste from intellij into chrome render view
Review URL: http://codereview.chromium.org/159107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit d06bc0c855b1e81e36c7bfc9bef342eb358d99a5.
TBR=estade
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11507
TEST=Open options, click change proxy, gnome-network-preferences should launch. If gnome isn't installed, LinuxProxyConfig wiki page should load.
Review URL: http://codereview.chromium.org/149785
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keep the cairo clipping region in sync with the Skia one.
The PlatformCanvas now tracks this, so we don't need to have the similar code
in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the
cairo_t has a transform and clip but the surface does not.
Review URL: http://codereview.chromium.org/149409
Review URL: http://codereview.chromium.org/155700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Behavior was changed in r4515 but the comment wasn't updated to match.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
functions with no arguments and a return value. This is useful in calling all of the getters we have in the code, instead of creating wrapper functions that take a pointer argument.
Review URL: http://codereview.chromium.org/155630
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension developers who want to package extensions as part of a build script
and aren't there to click the message box.
R=aa,jackson
BUG=14732
TEST=Pack an extension with the --no-message-box flag and notice that there is no message box.
Review URL: http://codereview.chromium.org/149795
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
/etc/lsb-release does not exist on all distros, and sometimes it does
not provide any useful info. Whereas all LSB complaint distros return
useful data with the lsb_release command.
Review URL: http://codereview.chromium.org/155653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=16512,16871
Review URL: http://codereview.chromium.org/149765
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=aa
TEST=LayoutTests/http/tests/security/isolatedWorld/ (will be landing soon after this patch)
BUG=12218
Review URL: http://codereview.chromium.org/155626
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=15606
TEST=none
Original review: http://codereview.chromium.org/149202
Patch by tyoshino@google.com
(Myself. Got code reviewed before becoming committer)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
dispatch to the delegate when one becomes available.
BUG=16732
TEST=rm ~/Library/Preferences/com.google.Chrome.plist, launch official-branding
Google Chrome, dismiss first-run dialog. The application should be
usable.
Review URL: http://codereview.chromium.org/149687
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20770 0039d316-1c4b-4281-b951-d872f2087c98
|