summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Additional svn ignores for native_client and Makefile.thestig@chromium.org2009-07-131-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20553 0039d316-1c4b-4281-b951-d872f2087c98
* Revert previous clipping rect change for Cairo to see if it fixes the build.brettw@chromium.org2009-07-131-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20516 0039d316-1c4b-4281-b951-d872f2087c98
* Keep the cairo clipping region in sync with the Skia one.brettw@chromium.org2009-07-131-2/+2
| | | | | | | | | | The PlatformCanvas now tracks this, so we don't need to have the similar code in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the cairo_t has a transform and clip but the surface does not. Review URL: http://codereview.chromium.org/149409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20499 0039d316-1c4b-4281-b951-d872f2087c98
* OFFICIAL_BUILD is only set in windows builds, so add some complexity to get ↵thomasvl@chromium.org2009-07-131-1/+5
| | | | | | | | | | | | the logging turned off the mac/linux builds as intended. The referenced bug will stay open since this probably shouldn't be the long term fix. BUG=16512 TEST=logging shows up for debug builds, but all platforms don't have logging in official builds. Review URL: http://codereview.chromium.org/149534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20497 0039d316-1c4b-4281-b951-d872f2087c98
* Move TrimWhitespaceUTF8 from string_util_icu to string_util.deanm@chromium.org2009-07-132-14/+14
| | | | | | | | | It does not directly use ICU, so this is its proper home. Review URL: http://codereview.chromium.org/155415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20492 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused base/zygote_manager_unittest.cc.deanm@chromium.org2009-07-131-266/+0
| | | | | | | Review URL: http://codereview.chromium.org/149537 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20486 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Generate total-load-time histograms from thervargas@google.com2009-07-112-4/+13
| | | | | | | | | | | disk cache experiment. BUG=none TEST=none Review URL: http://codereview.chromium.org/155380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that happens if a tab is closed whiletc@google.com2009-07-102-1/+14
| | | | | | | | | | | | | | | | | we're in the middle of a drag originating from the tab. The problem is that the tab gets deleted out from under the drag operation which is happening in a nested message loop. To work around this, if we're in the middle of a drag and we get a tab close request, delay the tab close until after the drag operation is finished. BUG=16280 Review URL: http://codereview.chromium.org/149466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20436 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the local directory listing, FTP directory listing and the local file ↵jshin@chromium.org2009-07-093-178/+441
| | | | | | | | | | | | | | | | | | | | | | | | | | | handling (drag'n'drop and opening from the file list). For the local file listing, use the OS file system encoding. For the FTP directory listing, use ICU's encoding detector.GetDirectoryListingEntry and GetDirectoryLisingHeader were changed to accept string16 for file/directory names. To the former, a new parameter (|raw_bytes|) was added. It can be used to make a FTP request to a file with a non-ASCII name encoded in a legacy encoding. For the local file handling on Windows, get rid of the code for 'doubly converted' UTF-8 in FileURLToFilePath, which led to issue 4619 and add a few cases to NetUtil*.FileURLConversion* test. In addition, add CodepageToUTF16 and UTF16ToCodepage along with a new unittest (ConvertBetweenCodepageAndUTF16) that shares the same set of case as ConvertBetweenCodepageAndWide. The test cases were expanded and revised a bit. BUG=2939,13229,4619 http://crbug.com/2939 http://crbug.com/13229 http://crbug.com/4619 TEST=1. Pass URLRequest*.FTP* (net_unittests) 2. Pass StringUtiltTest.ConvertBetweenCode* 3. Pass NetUtil*.GetDirectoryLis* (net_unittests) 4. Open a local directory containing files with non-ASCII names and they're displayed correctly in the directory list. On Windows and Mac OS X, it should always work. On Linux, your locale encoding (as returned by nl_langinfo(CODESET)) should match the actual encoding used in your filename. 5a. Pass NetUtil*.FileURL* (net_unittests) with the default codepage set to 1252 and 932. 5b. Make a file named 'caf챕.txt' on Windows and see if it can be opened both by clicking in the directory listing page of Chrome and by drag'n'drop. Test this with the default OS code pages set to Windows-1252, Windows-1251 (Russian) and Windows-932 (Japanese). Review URL: http://codereview.chromium.org/151065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20331 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NOTIMPLs into a bug.estade@chromium.org2009-07-091-4/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20274 0039d316-1c4b-4281-b951-d872f2087c98
* Make converting from NativeViewId to NativeView an error on Mac.shess@chromium.org2009-07-081-1/+10
| | | | | | | | Goal is to prevent someone from checking in new cross-platform code relying on this. Review URL: http://codereview.chromium.org/149342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20193 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a non-templatized version of QI for times when the IID and type ↵tommi@chromium.org2009-07-082-7/+24
| | | | | | | | | | | | | aren't associated. Also fixing the ScopedComPtrVector unit test. The problem with the test was that it expected AddRef to be called twice and Release() once when pushing a pointer to the vector. However that only happens when a push causes a reallocation. When there's no reallocation, there's only a single call to AddRef and no call to Release, causing the test to report failure. The fix is to simply use std::list instead and fix the expected values. TEST=Run *ScopedComPtr* unit tests. BUG=none Review URL: http://codereview.chromium.org/149345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20183 0039d316-1c4b-4281-b951-d872f2087c98
* GdkPixbufFromSkBitmap needs to un-premultiply the alpha beforetc@google.com2009-07-081-4/+30
| | | | | | | | | | passing off the data to gdk_pixbuf. This is required in the theme code for tinted bitmaps. Review URL: http://codereview.chromium.org/150151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20164 0039d316-1c4b-4281-b951-d872f2087c98
* linux: OOP windowed pluginsevan@chromium.org2009-07-071-3/+3
| | | | | | | | | | | | | | There are still a few issues, but that's a start. - only windowed plugins - we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID). - the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC. - some code is duplicated between chrome and test_shell. We should probably refactor it, but I'm not sure where the common part should live. Patch from Antoine Labour <piman@google.com>, with some touchups by me. Review URL: http://codereview.chromium.org/146078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20041 0039d316-1c4b-4281-b951-d872f2087c98
* Fix retarded bitmath. << 8 != * 255glen@chromium.org2009-07-072-6/+10
| | | | | | | | BUG=13360 Review URL: http://codereview.chromium.org/149164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20040 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tools/valgrind/chrome_tests.sh to always use --log-file optiondank@chromium.org2009-07-071-0/+6
| | | | | | | | | | | | | | | so fork() doesn't corrupt log files; lets --generate_suppressions work even with the hacky valgrind fix that makes anything but --log-file crash on child of fork(). Also avoid killing user desktop session if zygote dies! BUG=none, but related to fix for http://crbug.com/15771 TEST=patch valgrind with fork workaround; sh tools/valgrind/chrome_tests.sh --generate_suppressions -t ui logs you out on linux without this. Review URL: http://codereview.chromium.org/155130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20024 0039d316-1c4b-4281-b951-d872f2087c98
* Fix few trivial Coverity issues, mainly PASS_BY_VALUE.phajdan.jr@chromium.org2009-07-065-9/+12
| | | | | | Review URL: http://codereview.chromium.org/155022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19974 0039d316-1c4b-4281-b951-d872f2087c98
* Minor Coverity nit: Unit test leaking data if failure occurs.finnur@chromium.org2009-07-031-9/+7
| | | | | | | | | BUG=None TEST=Coverity should stop complaining about this leak. Review URL: http://codereview.chromium.org/149153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19886 0039d316-1c4b-4281-b951-d872f2087c98
* We recently enabled reading sysctl values from inside the sandbox. This CL ↵jeremy@chromium.org2009-07-023-38/+12
| | | | | | | | removes workarounds needed when sysctl reads where blocked. Review URL: http://codereview.chromium.org/151202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19809 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging code in hopes of tracking down asky@chromium.org2009-07-011-3/+14
| | | | | | | | | | | | | | | | crash. Specifically: . Adds a CHECK to IDMap that evaluates to true if adding NULL. The default isn't to do this check. . browser_shutdown CHECKs if the # RPHs changes while iterating through the RPHs. BUG=15615 TEST=none Review URL: http://codereview.chromium.org/150181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19779 0039d316-1c4b-4281-b951-d872f2087c98
* Adds time-out to browser-tests to prevent a hanging test from hanging the ↵jcampan@chromium.org2009-07-012-0/+7
| | | | | | | | | | entire test suite. Bug=None TEST=None Review URL: http://codereview.chromium.org/151158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19755 0039d316-1c4b-4281-b951-d872f2087c98
* Implement shortcut for finalizing a trial with all remaining probabilityjar@chromium.org2009-07-013-7/+33
| | | | | | | | | | | It is helpful when defining experiments to put all remaining probability on the final (often the "control" group), without having to keep a careful tally of assignments of probabilities. This CL implements that functionality. r=rvargas Review URL: http://codereview.chromium.org/150141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19696 0039d316-1c4b-4281-b951-d872f2087c98
* make FilePath:IsParent use case-insensitive compare for drive letters on windowsrafaelw@chromium.org2009-07-013-7/+124
| | | | | | | | | R=erikkay BUG=15659 Review URL: http://codereview.chromium.org/150109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19694 0039d316-1c4b-4281-b951-d872f2087c98
* Create A/B test of SDCHjar@chromium.org2009-06-303-70/+132
| | | | | | | | | | | | | | | | | | | | | To do this, I needed to add the feature that ALL FieldTrials that are established in the browser process are forwarded and established in the corresponding renderer processes. This then allows both DNS impact, as well as SDCH inmpact (and any other field tests) to be studied at the same time in a single binary. This checkin also establishes a pattern that when we're doing A/B tests via a histogram such as RequestToFinish, that we produce names for all groups, rather than leaving one group as the "default" or "empty postfix" group. This is critical for naming various sub-groups when a multitude of tests are taking place at the same time. BUG=15479 r=mbelshe Review URL: http://codereview.chromium.org/150087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19595 0039d316-1c4b-4281-b951-d872f2087c98
* Reland of r19131, this time with real Math:glen@chromium.org2009-06-302-3/+65
| | | | | | | | | | | | | | | PNGDecoder wasn't multiplying the alpha like PNGEncoder was. This lead to color overflow. This intermediate fix makes everything correct, but will make alphaed pixels slightly darker until the user's cache is flushed (I have screenshots of the effect). BUG=13360 TEST=Run base_unittests.exe --gtest_filter=*PNG* Review URL: http://codereview.chromium.org/150107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19589 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Don't crash if we fail to dlopen a pluginevan@chromium.org2009-06-291-2/+4
| | | | | | | Review URL: http://codereview.chromium.org/146073 Patch from Antoine Labour <piman@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19554 0039d316-1c4b-4281-b951-d872f2087c98
* More web contents dragging.estade@chromium.org2009-06-292-0/+7
| | | | | | | | TEST=drag an image (such as the google logo from google.com) into gimp or onto the desktop. BUG=http://crbug.com/15429 Review URL: http://codereview.chromium.org/151033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19553 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension extensions to be case-insensitive.avi@chromium.org2009-06-293-26/+73
| | | | | | | | | BUG=none TEST=try to load an extension with a capital letter or two in the extension's extension. It should load. Review URL: http://codereview.chromium.org/147017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19520 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize delegate_.finnur@chromium.org2009-06-291-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19504 0039d316-1c4b-4281-b951-d872f2087c98
* Use C99 standard format macros for 64-bit values.agl@chromium.org2009-06-292-1/+52
| | | | | | | | | | | | | | | | | | | Currently we have several uses of %I64d in format strings to indicate a 64-bit value. This does not work on Mac or Linux, where 'I' indicates the use of locale specific digits. Instead, we introduce base/format_macros.h which mimic the C99 standard macros for 64-bit values in a cross-platform manner. Dean pointed out that V8 is handling this themselves rather than use inttypes.h. Maybe we'll end up going down the same path but, for the moment, we'll try and do it the 'correct' way and see how it works out. http://codereview.chromium.org/147154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19500 0039d316-1c4b-4281-b951-d872f2087c98
* Create a more fine grained histogram of SDCH payload sizesjar@chromium.org2009-06-291-0/+16
| | | | | | | r=mbelshe Review URL: http://codereview.chromium.org/149119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19491 0039d316-1c4b-4281-b951-d872f2087c98
* Use platform-appropriate newlines in JSON output.mark@chromium.org2009-06-2611-10/+147
| | | | | | | | BUG=15462 TEST=base_unittests, unit_tests, check newlines in bookmarks file Review URL: http://codereview.chromium.org/147220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19418 0039d316-1c4b-4281-b951-d872f2087c98
* linux plugins: eliminate GtkWidget* from plugin processevan@chromium.org2009-06-261-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | [retry with mac hopefully fixed this time] GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19387 0039d316-1c4b-4281-b951-d872f2087c98
* Gracefully do nothing when run loop sources fire and no delegate is available.mark@chromium.org2009-06-261-0/+26
| | | | | | | | | | | This can happen if foreign code spins the run loop without Run being on the stack. BUG=2708 TEST=none Review URL: http://codereview.chromium.org/149082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19382 0039d316-1c4b-4281-b951-d872f2087c98
* Added dynamic annotation files into base/.deanm@chromium.org2009-06-267-4/+468
| | | | | | | | | | | | | | Added annotations for atomic reference counting, LazyInstance and Singleton classes. This changelist is a part of an effort of adding ThreadSanitizer support for Chromium. See http://code.google.com/p/data-race-test/wiki/ThreadSanitizer Patch by Timur Iskhodzhanov. Review URL: http://codereview.chromium.org/147008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19353 0039d316-1c4b-4281-b951-d872f2087c98
* Cache the file descriptor for /dev/urandom to avoid needing to reopen it for ↵deanm@chromium.org2009-06-261-3/+30
| | | | | | | | | | | | | | every call. Patch by Mike Mammarella. BUG=none TEST=none Review URL: http://codereview.chromium.org/144010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19352 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Linux sys_string_conversions using the system APIs.deanm@chromium.org2009-06-262-4/+250
| | | | | | | | | BUG=14826 Review URL: http://codereview.chromium.org/149065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19351 0039d316-1c4b-4281-b951-d872f2087c98
* Revert all of my patches from today.evan@chromium.org2009-06-261-13/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19328 0039d316-1c4b-4281-b951-d872f2087c98
* mac: retry build fix.evan@chromium.org2009-06-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19327 0039d316-1c4b-4281-b951-d872f2087c98
* linux plugins: eliminate GtkWidget* from plugin processevan@chromium.org2009-06-261-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19320 0039d316-1c4b-4281-b951-d872f2087c98
* When falling out of a nested loop, if higher-priority work is done, be sure tomark@chromium.org2009-06-251-0/+10
| | | | | | | | | | still arrange to run lower-priority work on a subsequent pass. BUG=13468 TEST=http://crbug.com/13468#c5 Review URL: http://codereview.chromium.org/149029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19305 0039d316-1c4b-4281-b951-d872f2087c98
* Allow work that was deferred on account of not being runnable in a nested loopmark@chromium.org2009-06-253-133/+277
| | | | | | | | | | to be processed when returning to an outer loop. BUG=11470 13442 13468 TEST=base_unittests, test cases in bugs Review URL: http://codereview.chromium.org/146006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19272 0039d316-1c4b-4281-b951-d872f2087c98
* On Linux, the path to the exe is used to fork renderer processes.jcampan@chromium.org2009-06-252-6/+12
| | | | | | | | | | | This was causing the browser tests to create browser tests instead of a renderer processes. Also the SSL tests now pass on Linux and have been enabled. BUG=None TEST=Run the browser tests on Linux. Review URL: http://codereview.chromium.org/146057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19257 0039d316-1c4b-4281-b951-d872f2087c98
* Fix embarassing purify error due to length mismatch.cevans@chromium.org2009-06-251-1/+1
| | | | | | | | | | BUG=NONE TEST=PickleTest.EvilLengths TBR=cpu Review URL: http://codereview.chromium.org/149011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19255 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of integer issues in Pickle deserialization. Neither representcevans@chromium.org2009-06-252-1/+32
| | | | | | | | | | | | | a significant risk because the code is not directly exposed to user input. In addition, neither error leads to memory corruption. At worse, there's a C++ exception or abort(). BUG=NONE TEST=PickleTest.EvilLengths Review URL: http://codereview.chromium.org/146121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19249 0039d316-1c4b-4281-b951-d872f2087c98
* change backing store cache to be memory-based rather than counterikkay@chromium.org2009-06-251-0/+2
| | | | | | | | | BUG=13763 TEST=none Review URL: http://codereview.chromium.org/146095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19246 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Linux sys_string_conversion changes.deanm@chromium.org2009-06-252-222/+4
| | | | | | | | | | | | This reverts r19239 and r19240. Tests are failing on the buildbots probably because they aren't in a UTF-8 locale. BUG=14826 Review URL: http://codereview.chromium.org/147148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19241 0039d316-1c4b-4281-b951-d872f2087c98
* Only run the UTF-8 assuming sys conversion tests on Linux.deanm@chromium.org2009-06-251-0/+3
| | | | | | | Review URL: http://codereview.chromium.org/147146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19240 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Linux sys_string_conversions using the system APIs.deanm@chromium.org2009-06-252-4/+219
| | | | | | | | | BUG=14826 Review URL: http://codereview.chromium.org/140062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19239 0039d316-1c4b-4281-b951-d872f2087c98
* Run content scripts in their own isolated world. Hidden behind the ↵abarth@chromium.org2009-06-252-0/+5
| | | | | | | | --isolated-world command line argument to let us iterate on this feature.R=aaBUG=12218TEST=None :( (I have a testing plan we can put in place once the upstream half of this CL lands.) Review URL: http://codereview.chromium.org/118188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19225 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 20:28:16 +0000