summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Temporary whitelist several cases of disk I/O on the UI threads in cros.nkostylev@chromium.org2011-01-241-0/+3
| | | | | | | | | BUG=60211, 70097, 70119, 70131, 62626, 61143, chromium-os:11102, chromium-os:11104, chromium-os:11105, chromium-os:11106, chromium-os:11109 TEST=bots Review URL: http://codereview.chromium.org/6272012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72331 0039d316-1c4b-4281-b951-d872f2087c98
* Remove sanity check in RegKey to prevent usage of checkingamit@chromium.org2011-01-212-67/+34
| | | | | | | | | | | | return value as a bool BUG=none TEST=none Review URL: http://codereview.chromium.org/6346010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72110 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the process is _really_ gone after a __debugbreak(). We've had acevans@chromium.org2011-01-212-0/+6
| | | | | | | | | | | | | few annoying cases where someone has been monitoring Chrome under windbg, which can skip over __debugbreak() and then show them a scary-looking access violation. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6372008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72107 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-2127-143/+125
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* base/i18n: Add namespace i18n to CharIterator.tfarina@chromium.org2011-01-203-9/+25
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6355005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71910 0039d316-1c4b-4281-b951-d872f2087c98
* Move BiDiLineIterator to base/i18n/ directory.tfarina@chromium.org2011-01-203-0/+109
| | | | | | | | | BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/6249007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71884 0039d316-1c4b-4281-b951-d872f2087c98
* .c Feature to disable field trials in old versions of Chromium. Field trialsrtenneti@chromium.org2011-01-193-83/+242
| | | | | | | | | | | | | | tests are (usually) monitored for a fixed length of time. With this change field trial tests turn them selves off (will use the default group) after the expiration time (specified in the Field Trial constructor). BUG=13463 TEST=field_trial_unittests tests this code thorougly. spdy session and testing field_trials in renderer process would be very helpful. thanks much. Review URL: http://codereview.chromium.org/6317004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71820 0039d316-1c4b-4281-b951-d872f2087c98
* Fail gracefully if profile Temp dir can not be accessed.skerner@chromium.org2011-01-191-4/+5
| | | | | | | | | BUG=60634, 67627 TEST=Manually interfere with Temp directory creation, see that expected failures happen. Review URL: http://codereview.chromium.org/6297003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71788 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary DCHECK causing unit test failure.amit@chromium.org2011-01-191-1/+0
| | | | | | | | | | BUG=none TEST=GoogleUpdateSettings::SetCollectStatsConsent TBR=cevans Review URL: http://codereview.chromium.org/6281008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71773 0039d316-1c4b-4281-b951-d872f2087c98
* Regkey functions return error code instead of boolamit@chromium.org2011-01-194-148/+214
| | | | | | | | | | | | | | | | | | | | | | Change the Regkey helper to consistently use and return LONG instead of bool. Fix RegKey usage all over the code base and get rid of workarounds due to lack of return value. Reviewers: brettw: everything (skip parts for other reviewers if you wish) robertshield,grt: chrome_frame, installer siggi: ceee BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/6090006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup for r71281: replace usage of "pk11" with "pkcs11" or "crypto ↵mattm@chromium.org2011-01-193-16/+16
| | | | | | | | | | | module", as appropriate. BUG=42073 TEST=manual,trybotss Review URL: http://codereview.chromium.org/6303004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71749 0039d316-1c4b-4281-b951-d872f2087c98
* The SSL server's RSA private key must be imported with thewtc@chromium.org2011-01-191-3/+7
| | | | | | | | | | | | | | | | | | KU_KEY_ENCIPHERMENT key usage to support the RSA key exchange algorithm. Remove the incorrect workarounds for this bug. In the SSLServerSocketTest.DataTransfer unit test, do not proceed to data transfer if the SSL connection cannot be established. Not required for fixing this bug: create an RSA private key with all applicable key usage bits to be future-proof. R=hclam BUG=67928 TEST=net_unittests --gtest_filter=SSLServerSocketTest.* Review URL: http://codereview.chromium.org/6297008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71739 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Adding CHECKs to troubleshoot the crash issue ..."oshima@google.com2011-01-181-7/+0
| | | | | | | | | | | | | Revert "Adding CHECKs to troubleshoot the crash issue intuple.h/browser_render_process_host.cc (see bug description)" This reverts commit 29801f4598cf1a605c6e1a7b0295e0ac29f27b59. BUG=chromium-os:7327 TEST=none Review URL: http://codereview.chromium.org/6323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71680 0039d316-1c4b-4281-b951-d872f2087c98
* Made return types of various Value::DeepCopy() implementations more specificakalin@chromium.org2011-01-183-31/+90
| | | | | | | | | | | | | | | | | | Since C++ supports covariant return types, a subclass of Value can return its own pointer type for Value::DeepCopy(). Also made signatures of Value::Create*Value() more specific. Removed now-unnecessary casts. Added test for covariant return types. BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6324004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71617 0039d316-1c4b-4281-b951-d872f2087c98
* Order function definitions in base/win/registry.cc according to the header.tfarina@chromium.org2011-01-142-162/+168
| | | | | | | | | BUG=68682 TEST=trybots Review URL: http://codereview.chromium.org/6354002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71511 0039d316-1c4b-4281-b951-d872f2087c98
* Clang: enable -Wbool-conversions and -Wunused-variables on Linux.hans@chromium.org2011-01-144-43/+42
| | | | | | | | | | | | | | | -Wbool-conversion warns about EXPECT_EQ(false, blah), so replace that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah) for good measure (even though that doesn't generate warnings). Also remove the one instance of an unused variable. BUG=69421 TEST=buildbots all compile and all tests pass Review URL: http://codereview.chromium.org/6300001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up threading model of external extension providersgfeher@chromium.org2011-01-143-46/+0
| | | | | | | | | | | Move blocking IO of loading the lists of external extensions from the UI thread to the FILE thread. Remove the ExternalPolicyExtensionProvider-specific parts from ExtensionsService. Side-effects: reduce the number of PostTask operations from 9 to 4. Trigger uninstall of external extensions immediately after they are removed from a policy. BUG=65107,63667 TEST=ExtensionManagementTest.ExternalPolicyRefresh for the new functionality, lot of other extension tests are updated Review URL: http://codereview.chromium.org/5742008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71427 0039d316-1c4b-4281-b951-d872f2087c98
* NSS: don't set environment variables when multi-threaded.agl@chromium.org2011-01-132-0/+21
| | | | | | | | | | | | | We can't alter the envionment once we have gone multithreaded because glibc's getenv doesn't take the environment lock. Thus we add an EarlyNSSInit() function which can do so, early in startup. BUG=66835 TEST=ThreadSanitizer http://codereview.chromium.org/6185005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71351 0039d316-1c4b-4281-b951-d872f2087c98
* Added WARN_UNUSED_RESULT to ScopedTempDir methods.cbentzel@chromium.org2011-01-132-7/+7
| | | | | | | | | BUG=NONE TEST=all targets build, tests pass. Review URL: http://codereview.chromium.org/6042009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71322 0039d316-1c4b-4281-b951-d872f2087c98
* NSS: PKCS 11 password prompt.mattm@chromium.org2011-01-133-0/+58
| | | | | | | | | | | This was based off of davidben's WIP cl http://codereview.chromium.org/3186021/show. BUG=42073 TEST=add password to NSS DB with "certutil -d sql:.pki/nssdb -W", try client auth, <keygen>, cert manager Review URL: http://codereview.chromium.org/5686002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71281 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GrabWindowSnapshot for Mac Chrome.rkc@chromium.org2011-01-121-9/+19
| | | | | | | | | | | Changed the mechanism to take a screenshot over to CG; we now just take a direct bit dump of the window into an image and convert that to a png. BUG=69160 TEST=Tested with sending feedback from a Mac; screenshot appeared on screen and on the report correctly. Review URL: http://codereview.chromium.org/6121005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71233 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing several typos in gyp files detected by jeanluc's forthcoming changes ↵bradnelson@google.com2011-01-111-1/+1
| | | | | | | | | | | to gyp. BUG=None TEST=None Review URL: http://codereview.chromium.org/6130007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71082 0039d316-1c4b-4281-b951-d872f2087c98
* Add workaround for VS2005 compile error introduced by r70933akalin@chromium.org2011-01-111-3/+27
| | | | | | | | | BUG=None TEST=compiles on VS2005 Review URL: http://codereview.chromium.org/6198003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71081 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-114-19/+30
| | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
* Order function definitions in base/ according to the header.erg@google.com2011-01-1132-971/+973
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6085015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70975 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the stubbed out headers in chrome/browser/views.msw@chromium.org2011-01-101-3/+3
| | | | | | | | | | | | | | | | | Update references to use headers in chrome/browser/ui/views. Update copyright dates in affected files. /chrome/browser/ui/views/constrained_html_delegate_win.cc Add space before 'private' label (presubmit warning) /chrome/browser/ui/views/toolbar_view.cc Add space before 'cleanup' label (presubmit warning) BUG=69082 TEST=Compiling... Review URL: http://codereview.chromium.org/6204002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70965 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak atomicops implementation for Mac OS X to compile correctly when __LP64__mark@chromium.org2011-01-101-11/+12
| | | | | | | | | | | | | | is defined. Patch by Ben Karel <eschew@gmail.com>. BUG=54554 TEST= - base_unittests --gtest_filter='AtomicOpsTest.*' - Compile base/string_util.cc (outside of Chromium) as 64-bit code on Mac OS X 10.6. Review URL: http://codereview.chromium.org/6091007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70942 0039d316-1c4b-4281-b951-d872f2087c98
* Made ObserverListThreadSafe's destructor private since it's ref-counted.akalin@chromium.org2011-01-101-7/+9
| | | | | | | | | BUG=None TEST=Compiles Review URL: http://codereview.chromium.org/3832006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70933 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70920 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-104-30/+19
| | | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6099012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-104-19/+30
| | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
* Fix file descriptor leak in base_unittests ProcessUtilTest.LaunchApp. Themark@chromium.org2011-01-101-2/+5
| | | | | | | | | | TestLaunchApp helper function should close base_unittests' end of the pipe. BUG=none TEST=base_unittests --gtest_filter=ProcessUtilTest.LaunchApp Review URL: http://codereview.chromium.org/6128004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70901 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Remove base/scoped_handle_win.h."tfarina@chromium.org2011-01-099-55/+51
| | | | | | | | | | | | | | | Fixed the problem with rlz library. Now should be fine to land this again. This reverts commit 3620d9501af7bff688862c54fdd60f7eb41797f3. Original Review URL: http://codereview.chromium.org/6126002/ BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove base/scoped_handle_win.h stub and fix up all callers to use ↵thakis@chromium.org2011-01-079-51/+55
| | | | | | | | | | the new location and namespace." This reverts r 70795, it broke the build. TBR=vandebo git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70802 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/scoped_handle_win.h stub and fix up all callers to use the new ↵tfarina@chromium.org2011-01-079-55/+51
| | | | | | | | | | | location and namespace. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6126002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70795 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-073-26/+15
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-073-15/+26
| | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
* Make the order of methods in the cc files match the headers in base/.erg@google.com2011-01-078-412/+395
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6189001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70771 0039d316-1c4b-4281-b951-d872f2087c98
* Support OVERRIDE for clang.thakis@chromium.org2011-01-071-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6165001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70763 0039d316-1c4b-4281-b951-d872f2087c98
* Start sorting methods in class declarations.erg@google.com2011-01-0736-281/+317
| | | | | | | | | | | | | | | | | | | | | | | | A lot of our headers are a mess and aren't organized. Impose the following order on files in the base/ directory: class Blah { each public/protected/private section: typedefs; enums; static constants; ctors; dtors; methods; overridden virtual methods; data members; }; BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70749 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath.tfarina@chromium.org2011-01-073-37/+0
| | | | | | | | | | | Fix the callers and remove the deprecated function. BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6111003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70705 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove deprecated file_util::GetFilenameFromPath function.tfarina@chromium.org2011-01-063-21/+1
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6057010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70610 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove unnecessary includes from scoped_handle_win.htfarina@chromium.org2011-01-051-4/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5988009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70500 0039d316-1c4b-4281-b951-d872f2087c98
* Increasing live (sync) operation timeout to 45 seconds.rsimha@chromium.org2011-01-041-1/+1
| | | | | | | | | | | | | | | | | The sync integration tests were using a timeout of 30 seconds for live operations. Some of the sync stress tests are timing out because it takes longer for a full sync cycle to complete. This patch increases the timeout to 45 seconds, and should eliminate the occasional failures on the builders. TBR=tim@chromium.org BUG=68207 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6023011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70451 0039d316-1c4b-4281-b951-d872f2087c98
* Typo fix.avi@chromium.org2011-01-041-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6049009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70433 0039d316-1c4b-4281-b951-d872f2087c98
* Add SCOPED_TRACEs to ICUStringConversionsTestphajdan.jr@chromium.org2011-01-041-0/+20
| | | | | | | | | | | | to help debug http://bugs.gentoo.org/show_bug.cgi?id=350347 They are also useful in general, so I don't plan to remove them later. BUG=none TEST=none Review URL: http://codereview.chromium.org/5982003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70430 0039d316-1c4b-4281-b951-d872f2087c98
* MessageLoop: use dynamic_annotations.h & RunningOnValgrind instead of ↵timurrrr@chromium.org2011-01-041-5/+5
| | | | | | | | | | valgrind.h & RUNNING_ON_VALGRIND This way we'll be able to delete all tasks on Windows under Dr. Memory TEST=trybots Review URL: http://codereview.chromium.org/6073004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70425 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'using' declaration of ScopedBitmap from scoped_handle_win.htfarina@chromium.org2011-01-031-1/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6013010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70400 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mac build by fixing some include pathsbrettw@chromium.org2011-01-022-2/+2
| | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70375 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'using' declaration of ScopedHGlobal from scoped_handle_win.htfarina@chromium.org2011-01-021-1/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6058007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70371 0039d316-1c4b-4281-b951-d872f2087c98
* Move CancellationFlag and WaitableEvent to the synchronization subdirectory.brettw@chromium.org2011-01-0221-65/+63
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5977010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70369 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 23:41:44 +0000