summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Added last_modified field to TemplateURL and database. Updated unit tests, ↵stevet@chromium.org2011-06-283-0/+99
| | | | | | | | | | including refactoring MockTimeProvider out of media/. BUG=None TEST=No visible changes. Ensure that changed unittests all pass. Review URL: http://codereview.chromium.org/7232023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90764 0039d316-1c4b-4281-b951-d872f2087c98
* Move the thread test helper to base/testjochen@chromium.org2011-06-283-0/+84
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7239023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix comment in base/auto_reset.h to refer to AutoReset instead ofmark@chromium.org2011-06-281-9/+8
| | | | | | | | | | | | | | | | AutoResetValue. This inconsistency was introduced in r48644. The review history for that change, http://codereview.chromium.org/2394001, indicates that AutoResetValue was initially used in this file but not at any of the use sites. When it changed to AutoReset in patch set 2, matching the use sites, the comment still was not updated. BUG=none, cleanup TEST=none Review URL: http://codereview.chromium.org/7253032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90707 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90681 - New NaCl zygote implementation 2, in which Chrome zygote ↵fischman@chromium.org2011-06-282-40/+4
| | | | | | | | | | | | | | | | forks a NaCl helper. This patch can launch earth_c.html with and without the SUID sandbox. It is enabled with the environment variable NACL_NEW_ZYGOTE. BUG=nativeclient:480 TEST=nativeclient in-browser tests on Linux, ChromeOS Review URL: http://codereview.chromium.org/6995121 TBR=bradchen@google.com Review URL: http://codereview.chromium.org/7274011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90682 0039d316-1c4b-4281-b951-d872f2087c98
* New NaCl zygote implementation 2, in which Chrome zygote forks a NaCl helper.bradchen@google.com2011-06-272-4/+40
| | | | | | | | | | | This patch can launch earth_c.html with and without the SUID sandbox. It is enabled with the environment variable NACL_NEW_ZYGOTE. BUG=nativeclient:480 TEST=nativeclient in-browser tests on Linux, ChromeOS Review URL: http://codereview.chromium.org/6995121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90681 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream android string implementation etc.michaelbai@google.com2011-06-275-16/+46
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7238018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90616 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity fixes CID=15870,13529 Check pointer before assign, resource leak.gbillock@chromium.org2011-06-272-4/+11
| | | | | | Review URL: http://codereview.chromium.org/7222010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90599 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity Fixlet: UNINIT_CTORscr@chromium.org2011-06-271-2/+2
| | | | | | | | | | | CID=5172 BUG= TEST= Review URL: http://codereview.chromium.org/7219008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90598 0039d316-1c4b-4281-b951-d872f2087c98
* Add COMPILE_ASSERT to ensure the result of Bind matches the Callback's type.ajwong@chromium.org2011-06-2611-4/+399
| | | | | | | | | | | | | | Required because we abstract the storage of the funciton pointer out using a reinterpret_cast to reduce template bloat. This effectively readds the failure that would have happened had we stored the function pointer directly in the template class. BUG=86008 TEST=new unittests. Review URL: http://codereview.chromium.org/7241015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90525 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Move app/win/* files to base/win/, ui/base/win and chrome/common/ ↵tfarina@chromium.org2011-06-254-4/+418
| | | | | | | | | | | | | | | | directories." The issue with the r90464 was that in the win shared build we build dlls and we need BASE_API to export functions and symbols. BUG=72317 TEST=None TBR=rsesek@chromium.org,brettw@chromium.org Review URL: http://codereview.chromium.org/7263009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90505 0039d316-1c4b-4281-b951-d872f2087c98
* Patch for Solaris support, mostly ifdefs and header files, plus adds ↵chromium@hybridsource.org2011-06-258-13/+227
| | | | | | | | | | | libevent configuration. BUG=30101 TEST=compiles Review URL: http://codereview.chromium.org/7238021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90494 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up of -Wunused-but-set-variable (gcc 4.6)pph34r@gmail.com2011-06-252-7/+3
| | | | | | | | | | BUG=80071 TEST=base_unittests Review URL: http://codereview.chromium.org/7232025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90489 0039d316-1c4b-4281-b951-d872f2087c98
* TCPServerSocketLibevent should call StopWatchingFileDescriptor()wtc@chromium.org2011-06-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | when Accept() completes asynchronously (because Accept() calls WatchFileDescriptor() in persistent mode) or before it closes socket_. This matches what TCPClientSocketLibevent does. Without this fix, the TCPServerSocketTest.Accept2Connections unit test may crash in accept_callback.WaitForResult() for some message loop scheduling policies because two connections are ready to be accepted but only one accept_socket_ is provided. Fix a comment typo in object_watcher.h. Avoid a redundant StopWatchingFileDescriptor call in TCPClientSocketLibevent. R=sergeyu@chromium.org,willchan@chromium.org BUG=none TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/7239018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90476 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90464 - Move app/win/* files to base/win/, ui/base/win and ↵tfarina@chromium.org2011-06-254-417/+4
| | | | | | | | | | | | | | | | chrome/common/ directories. BUG=72317 TEST=None R=rsesek@chromium.org,brettw@chromium.org Review URL: http://codereview.chromium.org/7231016 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/7265009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90471 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/win/* files to base/win/, ui/base/win and chrome/common/ directories.tfarina@chromium.org2011-06-254-4/+417
| | | | | | | | | | | BUG=72317 TEST=None R=rsesek@chromium.org,brettw@chromium.org Review URL: http://codereview.chromium.org/7231016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90464 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the glib message-pump, and use it as the base for a gtk message ↵sadrul@chromium.org2011-06-2410-226/+293
| | | | | | | | | | | | | | | | | | | pump and an X message pump. The changes: * Rename MessagePumpGlibX to MessagePumpX. * Rename MessagePumpForUI to MessagePumpGlib. * Move some stuff out of MessagePumpGlib, and into MessagePumpGtk and MessagePumpX. * Rename MessagePumpForUI::Observer to MessageObserver, moved the platform-specific implementations into MessagePumpGtk and MessagePumpX. Ditto for MessagePumpForUI::Dispatcher. MessagePumpX is independent of MessagePumpGtk. At the moment, MessagePumpX does process some GDK event, but once we have a complete native_widget_x, we can take out the GDK processing and things should continue to work. BUG=none TEST=existing message-pump tests. Review URL: http://codereview.chromium.org/7250001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90418 0039d316-1c4b-4281-b951-d872f2087c98
* Fix relaunches on the Mac.mark@chromium.org2011-06-242-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Relaunches that go through browser_shutdown and relaunches after install-from-disk-image should both be improved. browser_shutdown relaunches include those that occur when Chrome detects a new version and offers to relaunch itself, and those that occur when you change about:flags and click "Relaunch Now." When relaunching Chrome in the same location via browser_shutdown, the same Dock tile should now always be reused, provided that the tile is persistent, meaning that the user has chosen "Keep in Dock" from the tile's contextual menu. The relaunched process' activation status (foreground or background application) should now track the original process' activation status. BUG=42962, 85073 TEST=1a. Change something in about:flags and hit "Relaunch Now" at the bottom. If you had a persistent Dock tile, the same tile should be used for the relaunched browser every time, without fail. 1b. Same, but once you're running a version of Chrome (including a canary) with this fix, when an update is applied and you relaunch from within the application via the "Update Google Chrome" item in the wrench menu or the "Relaunch" button in the about window, the same tile should be used for the relaunched browser every time, without fail. 2. Relaunch after install from disk image. Remove Chrome from /Applications and double-click the Chrome icon in a read-only disk image carrying a version that has this fix. (Our official or canary disk images will work). Chrome will offer to install itself. Let it. Upon completion of the installation, Chrome should launch out of /Applications properly. If you had a persistent Dock tile pointing to a copy in /Applications, it will be used. Activation status (foreground or background) in the relaunched browser will match the status in the process that had run out of the disk image at the time that the installation completed. Review URL: http://codereview.chromium.org/7215040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90371 0039d316-1c4b-4281-b951-d872f2087c98
* Remove default initializtion of BirthPlace in Tracked.ajwong@chromium.org2011-06-232-6/+7
| | | | | | | | | | | | | | | | | | | | | | | Previously, MessageLoop::PostTask set the BirthPlace of the Task object (subclass of Tracked), which would decrement the counter for the Location("NoFunctionName", "NeedToSetBirthPlace", -1) Birth, and replace it with a more appropriate Location provided by the FROM_HERE argument. With the MessageLoop restructuring in r82300, tracking of Births is moved up from the Task object into the MessageLoop::PendingTask structure. The side-effect is that the default birth is never decremented, and we double count each task's creation. This default Birth is effectively a count of "tasks that were created, but not posted" without a stored reference to location, so removing it is the simplest fix to the double counting. BUG=none TEST=about:tasks looks sane. Review URL: http://codereview.chromium.org/7029038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90290 0039d316-1c4b-4281-b951-d872f2087c98
* Add back a check for improper usage of IsOneTimeRandomizationEnabled.joi@chromium.org2011-06-222-11/+11
| | | | | | | | | BUG=none TEST=existing Review URL: http://codereview.chromium.org/7204004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90135 0039d316-1c4b-4281-b951-d872f2087c98
* Localize strings, speeds.avi@chromium.org2011-06-227-151/+189
| | | | | | | | | BUG=86527 TEST=run in non-English. For European languages, during a download the decimal separators should be commas (e.g. "0,0 MB"). (The speeds are in strings files and might take a little time to run through the translation machinery.) Review URL: http://codereview.chromium.org/7189076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90092 0039d316-1c4b-4281-b951-d872f2087c98
* Add a flag to open files in share delete modejochen@chromium.org2011-06-223-0/+40
| | | | | | | | | | BUG=86928 TEST=base_unittests Review URL: http://codereview.chromium.org/7233007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90071 0039d316-1c4b-4281-b951-d872f2087c98
* net doesn't depend on libevent directly now.wtc@chromium.org2011-06-222-7/+4
| | | | | | | | | | | | | | | | Remove unnecessary forward declarations of struct event and inclusions of the event.h header. Use MessageLoopForIO::FileDescriptorWatcher and MessageLoopForIO::Watcher typedefs. R=mark@chromium.org,rvargas@chromium.org BUG=none TEST=no build errors Review URL: http://codereview.chromium.org/7232002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89995 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2011-06-222-1/+2
| | | | | | | | | | | | CID=9269,13399,14520 BUG=none TEST=none R=vandebo@chromium.org Review URL: http://codereview.chromium.org/7216031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89966 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream android file related code.michaelbai@google.com2011-06-2111-6/+247
| | | | | | | | | | | Implemented file related features BUG=None TEST=None Review URL: http://codereview.chromium.org/7184032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89914 0039d316-1c4b-4281-b951-d872f2087c98
* Add a warning to the top of base/memory/singleton.hscherkus@chromium.org2011-06-211-0/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7217014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89870 0039d316-1c4b-4281-b951-d872f2087c98
* Avoiding duplication of singular iteratortzik@chromium.org2011-06-211-1/+1
| | | | | | | | | | BUG= 65151 TEST='MRUCacheTest.*' Review URL: http://codereview.chromium.org/7187005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89848 0039d316-1c4b-4281-b951-d872f2087c98
* Always search TIDs for the crashing processes.kmixter@chromium.org2011-06-212-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | Kernels newer than 2.6.32 support TID and PID namespacing where processes' view of their TIDs and PIDs are not globally unique or externally meaningful. We have workarounds to find the TID and PID of the crashing process from outside in the browser process. However, we were only assuming TID namespacing was happening if PID namespacing was enabled and the kernel had a bug that was fixed since 2.6.38. This change causes us to always treat the TID as subject to namespacing. Our trick to find the TID relies on a procfs feature added in 2008. We assume if that feature is not yet present that the TID translation is not necessary. This fixes the bug where all crashes of non-browser processes on Linux 2.6.38+ (Chrome OS r13+) are unusable (result in UnspecifiedStackSignature). BUG=chromium-os:15462 TEST=Do about:crash on 2.6.38 kernel and verify proper tid listed in MDException block Review URL: http://codereview.chromium.org/7190019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89795 0039d316-1c4b-4281-b951-d872f2087c98
* Base: cleanup for base.dll.rvargas@google.com2011-06-201-4/+1
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/7213001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89763 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of ClearByPathBackupExclusion.mark@chromium.org2011-06-202-27/+0
| | | | | | | | | | | | | | | | | | | | We planned on keeping ClearByPathBackupExclusion around as temporary code to clean up the mess we used to make in /Library/Preferences/com.apple.TimeMachine.plist. Evidently, when we ask CSBackupSetItemExcluded to include-by-path an item that was previously excluded by path, it will remove the ExcludeByPath entry for the path from that plist, but it will also add an IncludeByPath entry. There is no way using this API to clean up the mess we made in the past, we can only trade an "exclude" mess for an "include" mess. It's not worth attempting to modify the file ourselves, avoiding the CSBackupSetItemExcluded API, and it's probably not even possible because the plist will likely be rewritten by a system process anyway. BUG=86845, 85999 TEST=No changes made to the plist mentioned above. Review URL: http://codereview.chromium.org/7206030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89741 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in base/test.joaodasilva@chromium.org2011-06-205-47/+66
| | | | | | | | | | | | | | This is related to http://codereview.chromium.org/7003028/. BUG=60476 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89664 Review URL: http://codereview.chromium.org/7129056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89681 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89664 - Cleanup in base/test.joaodasilva@chromium.org2011-06-205-66/+47
| | | | | | | | | | | | | | | This is related to http://codereview.chromium.org/7003028/. BUG=60476 TEST=None Review URL: http://codereview.chromium.org/7129056 TBR=joaodasilva@chromium.org Review URL: http://codereview.chromium.org/7212008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89669 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in base/test.joaodasilva@chromium.org2011-06-205-47/+66
| | | | | | | | | | | | This is related to http://codereview.chromium.org/7003028/. BUG=60476 TEST=None Review URL: http://codereview.chromium.org/7129056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89664 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing inclusionstzik@chromium.org2011-06-186-4/+9
| | | | | | | | | | BUG=None TEST='LoggingTest.*,FileUtilTest.*,PlatformFile.*,StringNumberConversionsTest.*,Time,TimeTicks,TimeDelta' Review URL: http://codereview.chromium.org/7108033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89595 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the KillProcess timeout when running under Valgrindtimurrrr@chromium.org2011-06-181-0/+8
| | | | | | | BUG=17453 Review URL: http://codereview.chromium.org/7204002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89593 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TouchGetInfoPlatformFile as Flaky on Mac OS X.leandrogracia@chromium.org2011-06-171-1/+7
| | | | | | | | | BUG=86494 TEST=PlatformFile.TouchGetInfoPlatformFile Review URL: http://codereview.chromium.org/7205001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89479 0039d316-1c4b-4281-b951-d872f2087c98
* Merge google-perftools r109 (the current contents of ↵glider@chromium.org2011-06-172-2/+9
| | | | | | | | | | | | | third_party/tcmalloc/vendor) with the forked Chromium version of tcmalloc. This change also requires some fixes to base/allocator/allocator.gyp: new tcmalloc source files added, unittest_utils.cc disabled (tcmalloc has its own snprintf() implementation now) Review URL: http://codereview.chromium.org/7050034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89452 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Split DirectoryChangeListener for thread-safetyakalin@chromium.org2011-06-161-1/+22
| | | | | | | | | | | | | | | | | | | | | | | | | Split DirectoryChangeListener into DirectoryChangeDelegate and TransactionObserver classes. This removes a remove/notify race condition with the DirectoryChange events. Make syncable::{Read,Write}Transaction take Locations instead of file/line pairs. Move construction of sync_manager_ into sync thread. Add logging utils in sync/logging.{h,cc}. Add overloads to ObserverListThreadSafe::Notify for 2, 3, and 4 arguments. Fixed 'Inital' misspelling in SyncBackendHost (finally). BUG=85656 TEST= Review URL: http://codereview.chromium.org/7190001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89413 0039d316-1c4b-4281-b951-d872f2087c98
* Implement A/B experiment for anti-DDoS.joi@chromium.org2011-06-161-1/+3
| | | | | | | | | BUG=85258 TEST=manual testing done by developer Review URL: http://codereview.chromium.org/7027040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89376 0039d316-1c4b-4281-b951-d872f2087c98
* Add three more possibilites for inlining for the base::mac::IsOS* family.mark@chromium.org2011-06-152-0/+9
| | | | | | | | BUG=85972 TEST=base_unittests MacUtilTest.IsOSEllipsis Review URL: http://codereview.chromium.org/7172022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89241 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Leftover -journal File By-path Exclusionsmrossetti@chromium.org2011-06-152-12/+27
| | | | | | | | | | Added code to clear old History and Thumbnail -journal file by-path backup exclusions. BUG=None TEST=None Review URL: http://codereview.chromium.org/7148024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89225 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move UI code out of SysInfo.derat@chromium.org2011-06-155-106/+0
| | | | | | | | | | | | | | | | This moves GetPrimaryDisplayDimensions() and DisplayCount() out of base and into a new DisplayUtils class (currently alongside the metrics code, since that's the only place that they're called). These methods add a GDK dependency that prevents Chrome OS from including process_util (which depends on SysInfo) in its libchrome library. BUG=chromium-os:16153 TEST=moved existing unit tests Review URL: http://codereview.chromium.org/7128001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89194 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid abs() of unsigned values.tzik@chromium.org2011-06-151-18/+16
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7134090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89173 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: base/scoped_ptr.h -> base/memory/scoped_ptr.h. (part 2)thestig@chromium.org2011-06-153-3/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7149008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89131 0039d316-1c4b-4281-b951-d872f2087c98
* Don't do the pre-emptive unexclude by-path on Lion. It's available to rootmark@chromium.org2011-06-141-6/+16
| | | | | | | | | | | | | only so it never works for us and spews log messages: "This process is attempting to exclude an item from Time Machine by path without administrator privileges. This is not supported." BUG=74053 TEST=No more console spew for this issue on Lion Review URL: http://codereview.chromium.org/7166006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89081 0039d316-1c4b-4281-b951-d872f2087c98
* Change the files in base and net to include foundation_util.hwtc@chromium.org2011-06-141-1/+1
| | | | | | | | | | | | instead of mac_util.h. R=rohitrao@chromium.org,mark@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7145016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89040 0039d316-1c4b-4281-b951-d872f2087c98
* Improve and unify Mac OS X run-time version checks.mark@chromium.org2011-06-145-35/+241
| | | | | | | | | | | | Don't use base::SysInfo::OperatingSystemVersionNumbers, because it calls Gestalt, which has a few bad properties. Introduce new functions that perform specific version checks. BUG=85972 TEST=base_unittests MacUtilTest.IsOSEllipsis Review URL: http://codereview.chromium.org/7144007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89028 0039d316-1c4b-4281-b951-d872f2087c98
* Support creating temporary files for sync file operations.noelutz@google.com2011-06-132-7/+19
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7066067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88884 0039d316-1c4b-4281-b951-d872f2087c98
* Remove msvs_guids from app, base, breakpad and build.tony@chromium.org2011-06-134-8/+0
| | | | | | | | BUG=28727 Review URL: http://codereview.chromium.org/7108053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88871 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two bugs found by a new clang warning I'm currently testing:thakis@chromium.org2011-06-131-1/+1
| | | | | | | | | | | | | | | | | | | | | /Users/thakis/src/chrome-git/src/base/md5.cc:250:24: error: The sizeof expression in 'memset' has type 'struct Context *', the same type that the first argument has. The sizeof expression should probably have type 'struct Context' instead. [-Werror] memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */ ^ 1 error generated. /Users/thakis/src/chrome-git/src/media/video/capture/fake_video_capture_device.cc:75:32: error: The sizeof expression in 'memset' has type 'unsigned char *', the same type that the first argument has. The sizeof expression should probably have type 'unsigned char' instead. [-Werror] memset(fake_frame_.get(), 0, sizeof(fake_frame_.get())); ^ 1 error generated. The warning is up for review here: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20110613/042719.html BUG=none TEST=none Review URL: http://codereview.chromium.org/7003140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88855 0039d316-1c4b-4281-b951-d872f2087c98
* Mark FilePathWatcherTest.DestroyWithPendingNotification as FLAKY on MacOSasargent@chromium.org2011-06-131-1/+7
| | | | | | | | | BUG=85930 TEST=none TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88851 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 03:45:12 +0000