summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Initial implementation of new AssertAcquired() functionality for Posix.rdsmith@google.com2010-06-166-74/+111
| | | | | | | | | | | | | | | | Hoisted the windows LockImpl funcitonality up into Lock and added material to ConditionVariable to adjust those shadow variables when needed. Also got rid of os_lock() primitive in Lock class by piggybacking on friend decl needed for accessing shadow variables. BUG=44091 TEST=Try bot run on Windows, Linux, Mac. Will land during low traffic time and revert on any problems or perf degradation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49648 Review URL: http://codereview.chromium.org/2196001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49926 0039d316-1c4b-4281-b951-d872f2087c98
* Add DISABLE_RUNNABLE_METHOD_REFCOUNT to make disabling refcounts in ↵ajwong@chromium.org2010-06-162-6/+28
| | | | | | | | | | | RunnableMethods easier. BUG=none TEST=none Review URL: http://codereview.chromium.org/2830006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49887 0039d316-1c4b-4281-b951-d872f2087c98
* Compile base_fpic for 32 bits as well.jam@chromium.org2010-06-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/2804004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49873 0039d316-1c4b-4281-b951-d872f2087c98
* Improve error messages for bad SocketParams.willchan@chromium.org2010-06-152-0/+30
| | | | | | | | | | Make it a compile-time error instead of link-time. Add a check to make sure you don't try to use it with a pointer. BUG=41016 Review URL: http://codereview.chromium.org/1604042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49823 0039d316-1c4b-4281-b951-d872f2087c98
* Support for DIR_SOURCE_ROOT in a case of WebKit-only checkout.tkent@chromium.org2010-06-152-3/+23
| | | | | | | | | BUG=none TEST=none. It's hard to write tests for DIR_SOURCE_ROOT without DIR_SOURCE_ROOT. Review URL: http://codereview.chromium.org/2865002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49769 0039d316-1c4b-4281-b951-d872f2087c98
* Fix fpic build on official builders by taking out -gstabs.jam@chromium.org2010-06-151-0/+5
| | | | | | Review URL: http://codereview.chromium.org/2862003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49756 0039d316-1c4b-4281-b951-d872f2087c98
* If CreateDirectory() fails during extension unpacking, log the exact OS call ↵skerner@chromium.org2010-06-142-20/+52
| | | | | | | | | | | | | that failed. This change is designed to help understand bug 35198, which we can not reproduce locally. BUG=35198 TEST=manual Review URL: http://codereview.chromium.org/2714016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49703 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49648 - Initial implementation of new AssertAcquired() functionality ↵rdsmith@google.com2010-06-136-107/+74
| | | | | | | | | | | | | | | | for Posix. Webkit compile failing. BUG=44091 TEST=Try bot run on Windows, Linux, Mac. Will land during low traffic time and revert on any problems or perf degradation. Review URL: http://codereview.chromium.org/2196001 TBR=rdsmith@google.com Review URL: http://codereview.chromium.org/2805001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49649 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implementation of new AssertAcquired() functionality for Posix.rdsmith@google.com2010-06-136-74/+107
| | | | | | | | | | | | | | Hoisted the windows LockImpl funcitonality up into Lock and added material to ConditionVariable to adjust those shadow variables when needed. Also got rid of os_lock() primitive in Lock class by piggybacking on friend decl needed for accessing shadow variables. BUG=44091 TEST=Try bot run on Windows, Linux, Mac. Will land during low traffic time and revert on any problems or perf degradation. Review URL: http://codereview.chromium.org/2196001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49648 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms to track the size of the profile data.rvargas@google.com2010-06-113-0/+33
| | | | | | | | | | BUG=16705 TEST=FileUtilTest.FileAndDirectorySize Review URL: http://codereview.chromium.org/2778006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49606 0039d316-1c4b-4281-b951-d872f2087c98
* Moving link settings to individual targets.bradnelson@google.com2010-06-111-10/+20
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/2711012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49604 0039d316-1c4b-4281-b951-d872f2087c98
* Do not use CRT strcmp function in PEImage.victorw@chromium.org2010-06-111-1/+22
| | | | | | | | | | | | | | | | | | | | This is for chromium dev build with MSVCRT dll. On render process dll initialization, sandbox interception agent patches the dlls, calls PEImage::GetProcOrdinal and GetProcOrdinal calls CRT strcmp function. This may happen before MSVCRT dll loads and crash render process. Using a local string compare function in PEImgage fixes the issue. The patch does not add new functionality and GetProcOrdinal is already covered by existing unittests. R=nsylvain,rvargas BUG=46311 TEST=none Review URL: http://codereview.chromium.org/2756008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49598 0039d316-1c4b-4281-b951-d872f2087c98
* Second try of building a version of base with -fPIC for internal plugin. ↵jam@chromium.org2010-06-111-158/+210
| | | | | | | | Credit to bradnelson. Review URL: http://codereview.chromium.org/2767010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49597 0039d316-1c4b-4281-b951-d872f2087c98
* Mac/clang: Uncontentious fixes.thakis@chromium.org2010-06-111-1/+1
| | | | | | | | | | | | | * Remove unused variables * Make types in h and cc files agree * Use subclasses if we call subclass methods * Fix one real bug (`if (a); a->foo()`) * Fix forward declarations to be correct * Don't mark some definitions with "extern" Review URL: http://codereview.chromium.org/2730015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49570 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanups of usage of process_util code.maruel@chromium.org2010-06-113-17/+26
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2791006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49568 0039d316-1c4b-4281-b951-d872f2087c98
* Adding sync to be called on ChromeOS after a delete operation has. This ↵dhg@chromium.org2010-06-111-0/+3
| | | | | | | | | | ensures that if the user deleted something on a sd card, its synced right after. BUG=chromium-os:2661 TEST=none Review URL: http://codereview.chromium.org/2735013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49550 0039d316-1c4b-4281-b951-d872f2087c98
* Make gtest report an error if there are tests marked as "MAYBE"glider@chromium.org2010-06-111-0/+25
| | | | | | Review URL: http://codereview.chromium.org/2762016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49526 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted an occasional change to ToolsSanityTests brought by r49524glider@chromium.org2010-06-111-1/+1
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/2758008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49525 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress another leak from bug 46343.glider@chromium.org2010-06-111-1/+1
| | | | | | | | | | | Suppress bug 46345 BUG=46345,46343 TBR=jam,darin Review URL: http://codereview.chromium.org/2779017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49524 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49502 - Build a version of base with -fPIC turned on. Use it for ↵jam@chromium.org2010-06-111-217/+165
| | | | | | | | | | | internal plugin. Credit to bradnelson who did this. Review URL: http://codereview.chromium.org/2796002 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/2778007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49505 0039d316-1c4b-4281-b951-d872f2087c98
* Build a version of base with -fPIC turned on. Use it for internal plugin. ↵jam@chromium.org2010-06-111-165/+217
| | | | | | | | Credit to bradnelson who did this. Review URL: http://codereview.chromium.org/2796002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49502 0039d316-1c4b-4281-b951-d872f2087c98
* TTF: Re-Re-enable MessageLoopTest.FileDescriptorWatcherOutlivesMessageLoop asjhawkins@chromium.org2010-06-111-4/+1
| | | | | | | | | | | it was inappropriately disabled due to Valgrind errors. BUG=none TEST=none Review URL: http://codereview.chromium.org/2780007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49474 0039d316-1c4b-4281-b951-d872f2087c98
* Return NULL instead of false when appropriate.evan@chromium.org2010-06-102-2/+2
| | | | | | | | (Found by clang.) Review URL: http://codereview.chromium.org/2725010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49466 0039d316-1c4b-4281-b951-d872f2087c98
* posix: set thread namesevan@chromium.org2010-06-102-8/+71
| | | | | | | | | | | | | | | | There's a non-portable function for doing this: pthread_setname_np. It's supported by OS X >= 10.6 and the Xcode debugger will show the thread names if they're provided. On Linux, support has just recently been added to glibc for the same function. Since OS coverage of the function is so spotty, we look for the symbol at runtime; on Linux we fall back to another implementation of the same functionality if the function isn't available. [reland of r49212, with Mac fixed and Linux disabled; see comments in code as to why Linux is disabled] Review URL: http://codereview.chromium.org/2774001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49465 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the position of the output->swap() call. This way, even if the ↵maruel@chromium.org2010-06-103-10/+6
| | | | | | | | | | command encounters an error, we still record the output. This is important for the case when stderr has been redirected to stdout, and we'd like to see stdout even when the exit code is non-zero. Patch contributed by Michael Williamson. Review URL: http://codereview.chromium.org/2665004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49423 0039d316-1c4b-4281-b951-d872f2087c98
* Changing temporary files on posix to have a . in front so they are hidden on ↵dhg@chromium.org2010-06-101-3/+2
| | | | | | | | | | | linux systems (i.e. chromeos) BUG=chromium-os:3110 TEST=none Review URL: http://codereview.chromium.org/2662005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49413 0039d316-1c4b-4281-b951-d872f2087c98
* Minor comment fix.glider@chromium.org2010-06-101-0/+1
| | | | | | | | | TBR=phajdan.jr BUG=46246 Review URL: http://codereview.chromium.org/2735009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49389 0039d316-1c4b-4281-b951-d872f2087c98
* Mark FileUtilTest.CountFilesCreatedAfter as flakyglider@chromium.org2010-06-101-2/+2
| | | | | | | | | TBR=erikkay BUG=46246 Review URL: http://codereview.chromium.org/2756007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49386 0039d316-1c4b-4281-b951-d872f2087c98
* Give the extension unpacker process a junction/symlink free path to the ↵skerner@chromium.org2010-06-095-45/+437
| | | | | | | | | | | unpack directory. BUG=35198,13044 TEST=FileUtilTest.NormalizeFilePathBasic,FileUtilTest. NormalizeFilePathReparsePoints,FileUtilTest.NormalizeFilePathSymlinks Review URL: http://codereview.chromium.org/2088006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49337 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r49188.willchan@chromium.org2010-06-098-72/+307
| | | | | | | | It was reverted due to breaking a valgrind test which has since been disabled. Review URL: http://codereview.chromium.org/2763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49320 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 48102 - this test is now failing again, apparently since r49188 ↵joth@chromium.org2010-06-091-1/+2
| | | | | | | | | | | | | | | | | | | | landed. As it is not clear this test was enabled due to the functionality it test being required (indeed, the comment still states it is not), disabling it again to get the tree open. Original description from reverted change r48102: TTF: Re-enable the FileDescriptorWatcherOutlivesMessageLoop test as it now appears to be passing. BUG=none TEST=MessageLoopTest.FileDescriptorWatcherOutlivesMessageLoop Patch by Doug Muir <dmuir@google.com>. Review URL: http://codereview.chromium.org/2077014 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/2789002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49241 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests whose expectations were changed by r55714.hamaji@chromium.org2010-06-098-307/+72
| | | | | | | | | | | | The patch removed extra paddings inside buttons. http://trac.webkit.org/changeset/55714 BUG=1437 TEST=none Review URL: http://codereview.chromium.org/789003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49225 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "posix: set thread names"evan@chromium.org2010-06-082-67/+8
| | | | | | This reverts commit r49212. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49214 0039d316-1c4b-4281-b951-d872f2087c98
* posix: set thread namesevan@chromium.org2010-06-082-8/+67
| | | | | | | | | | | | | There's a non-portable function for doing this: pthread_setname_np. It's supported by OS X >= 10.6 and the Xcode debugger will show the thread names if they're provided. On Linux, support has just recently been added to glibc for the same function. Since OS coverage of the function is so spotty, we look for the symbol at runtime; on Linux we fall back to another implementation of the same functionality if the function isn't available. Review URL: http://codereview.chromium.org/2774001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49212 0039d316-1c4b-4281-b951-d872f2087c98
* Jankometer: Generalize the code more. Add better support for monitoring IO ↵willchan@chromium.org2010-06-088-72/+307
| | | | | | | | | | | | | thread. Previously, the Jankometer only monitored windows messages on the UI thread (or gtk events). I've added observers for tasks and IO events. This lets us monitor all events on UI & IO threads (UI messages, all Tasks, and IO events). Replaces the JankObserver with a UIJankObserver and an IOJankObserver. Shares common code in JankObserverHelper. The JankObserverHelper and JankWatchdog are generic enough that they can probably move out to chrome/common and be reused by the renderer. Review URL: http://codereview.chromium.org/2098020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49188 0039d316-1c4b-4281-b951-d872f2087c98
* Make SysNativeMB converters assume UTF-8 on Chrome OS. jshin@chromium.org2010-06-071-0/+15
| | | | | | | | | | | Instead of using wcs*mbs and mbs*wcs, just call UTF-8 converters. BUG=39096 TEST=Covered by existing tests Review URL: http://codereview.chromium.org/1222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49118 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of DISALLOW_EVIL_CONSTRUCTORS macro usage in our code base.tfarina@chromium.org2010-06-071-1/+5
| | | | | | | | | | | TODO: Fix the remaining usages in third_party libraries and get rid of the macro in question. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2657005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49032 0039d316-1c4b-4281-b951-d872f2087c98
* Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in app ↵tfarina@chromium.org2010-06-0411-27/+27
| | | | | | | | | | | and base directories. BUG=None TEST=None Review URL: http://codereview.chromium.org/2654001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48931 0039d316-1c4b-4281-b951-d872f2087c98
* Record out-of-proc-tests' FAILS/FLAKY failures in the XML output.kinuko@chromium.org2010-06-031-0/+6
| | | | | | | | | BUG=40473 TEST=Run browser_tests and see if failed FAILS_ or FLAKY_ tests are recorded in its XML output. Also make sure that failures of FAILS/FLAKY tests don't make the browser_tests exit with non-zero return value. Review URL: http://codereview.chromium.org/2431003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48873 0039d316-1c4b-4281-b951-d872f2087c98
* Add Tokenize() for StringPiece.mbelshe@chromium.org2010-06-023-41/+59
| | | | | | | | | BUG=none TEST=StringUtilTest.TokenizeStringPiece Review URL: http://codereview.chromium.org/2463007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48792 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored Histogram::FactoryGet() to be style-compliantziadh@chromium.org2010-06-022-7/+7
| | | | | | | | | | Currently, two (2) overloaded versions of Histogram::FactoryGet() exist. Google's C++ style guide discourages such implementations. I refactored the methods into Histogram::FactoryGet() (no name change), which takes 'Sample' types as arguments, and Histogram::FactoryTimeGet(), which takes base::TimeDelta types as arguments. r = jar Review URL: http://codereview.chromium.org/2423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48766 0039d316-1c4b-4281-b951-d872f2087c98
* Disable CFAllocator patching on systems for which we don't know their ↵avi@chromium.org2010-06-021-26/+36
| | | | | | | | | | | internal structure. BUG=http://crbug.com/45363 TEST=no crash on unreleased systems Review URL: http://codereview.chromium.org/2417008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48747 0039d316-1c4b-4281-b951-d872f2087c98
* Reset signal handlers in forked children.agl@chromium.org2010-06-021-0/+7
| | | | | | | | | | | | If a signal is delivered to a child process in between forking and execing then it will trigger Chrome's signal handlers. This will likely result in sadness. BUG=44953 http://codereview.chromium.org/2452003/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48744 0039d316-1c4b-4281-b951-d872f2087c98
* Implement most of the ridealong fixes/cleanups I suggested during review for ↵pkasting@chromium.org2010-06-011-27/+27
| | | | | | | | | | enabling warn-on-signed-versus-unsigned-equality-comparisions on Windows. BUG=none TEST=none Review URL: http://codereview.chromium.org/2395001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48666 0039d316-1c4b-4281-b951-d872f2087c98
* Pressing the search button brings the NTP or close it if it is opened.jcivelli@chromium.org2010-06-011-0/+2
| | | | | | | | | | | | Note: this requires the WebKit https://bugs.webkit.org/show_bug.cgi?id=39752 to work. BUG=3404 TEST=See bug. Review URL: http://codereview.chromium.org/2260004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48658 0039d316-1c4b-4281-b951-d872f2087c98
* Use SSLClientSocketNSS on Mac OS X. By default, chrome still useswtc@chromium.org2010-06-012-11/+5
| | | | | | | | | | | | | | | | | | SSLClientSocketMac. Specify the --use-nss-for-ssl command-line option to use SSLClientSocketNSS. The nss.gyp in src/net/third_party/nss is renamed ssl.gyp to avoid a naming conflict with the nss.gyp in src/third_party/nss. The GYP generator for Xcode project files disallows same-named .gyp files. SSL client authentication doesn't work yet. R=mark BUG=30689 TEST=No build and test failures on Mac and Windows. Review URL: http://codereview.chromium.org/2322008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48650 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing AutoReset to be a template.gspencer@chromium.org2010-06-012-12/+15
| | | | | | | | | | | I've run into a couple of times this week when I needed one of these, for two different types besides bool. Time to fix the TODO. TEST=trybots FTW, and built locally. BUG=none Review URL: http://codereview.chromium.org/2394001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48644 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add FRIEND_TEST_ALL_PREFIXES, a FRIEND_TEST replacementphajdan.jr@chromium.org2010-06-014-8/+36
| | | | | | | | | | | that works with all test prefixes (DISABLED, FLAKY, FAILS). TEST=none BUG=44549 Review URL: http://codereview.chromium.org/2439001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48634 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run ProcessUtilTest.EnableLFH under Dr.Memorytimurrrr@chromium.org2010-06-011-0/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/2461001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48626 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run some of the base tests under Dr.Memorytimurrrr@chromium.org2010-06-011-0/+5
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/2417002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48623 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 03:11:13 +0000