summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Refactor EDID parsing utilities and consolidate them under ui/display/chromeosdnicoara@chromium.org2014-03-255-430/+0
| | | | | | | | | | This refactoring splits EDID parsing to generic parsing and Xrandr helpers. I'm also consolidating EDID parsing under ui/display/chromeos since this is the only place it is used. BUG=333413 Review URL: https://codereview.chromium.org/196413010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259316 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Enable DMP for system Chromium WebView on Android"primiano@chromium.org2014-03-251-5/+0
| | | | | | | | | | | | | | | | | This reverts commit a2f57e2cbfffa257ef542aa44807ee5d616cd15d. (http://crrev.com/18314006) Reason for the revert: it is not being actively used anymore, since having tcmalloc in libwebviewchromium.so doens't help with allocations from other libraries like system skia. Also, some work on the android_use_tcmalloc is ongoing and this dead code is adding unnecessary maintaining effort. BUG=345554 Review URL: https://codereview.chromium.org/208263016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259209 0039d316-1c4b-4281-b951-d872f2087c98
* Remove prtypes.h and prcpucfg*.h from base/third_party/nspr.wtc@chromium.org2014-03-2515-3069/+17
| | | | | | | | | | | | | | Copy the type and macro definitions we need to base/third_party/nspr/prtime.h. Add chromium-prtypes.h to crypto/third_party/nss. content/common/plugin_list_posix.cc doesn't need to include prcpucfg_linux.h. R=ananta@chromium.org,mark@chromium.org,rsleevi@chromium.org Review URL: https://codereview.chromium.org/209343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259148 0039d316-1c4b-4281-b951-d872f2087c98
* Report PPAPI plugin load error code to UMA.xhwang@chromium.org2014-03-254-11/+43
| | | | | | | | | TBR=sky@chrmium.org BUG=353886 Review URL: https://codereview.chromium.org/206713004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259091 0039d316-1c4b-4281-b951-d872f2087c98
* [UMA] Update documentation for running the extract_actions.py script.isherman@chromium.org2014-03-251-3/+4
| | | | | | | | | | BUG=none TEST=none R=asvitkine@chromium.org Review URL: https://codereview.chromium.org/206473008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259060 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the LIKELY() macro.viettrungluu@chromium.org2014-03-241-9/+0
| | | | | | | | R=brettw@chromium.org Review URL: https://codereview.chromium.org/209423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259027 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the NSSTRING_FORMAT() macro.viettrungluu@chromium.org2014-03-241-13/+0
| | | | | | | | R=brettw@chromium.org Review URL: https://codereview.chromium.org/209433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258991 0039d316-1c4b-4281-b951-d872f2087c98
* Add Arm64 atomicops to base.rmcilroy@chromium.org2014-03-242-1/+363
| | | | | | | | | | These are taken from the implementation in v8/src/atomicops_internals_a64_gcc.h BUG=354405 Review URL: https://codereview.chromium.org/206373005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258985 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of mprotect() in DiscardableMemoryAllocatorAndroid.pliard@chromium.org2014-03-241-12/+6
| | | | | | | | | | | | | | On Samsung devices mprotect(addr, length, PROT_READ | PROT_WRITE) fails after a previous call to mprotect(addr, length, PROT_NONE) when addr is inside an ashmem mapping. It is not worth introducing some extra code detecting at runtime whether this specific pattern is supported for a feature that is only used in debug mode. BUG=348564 Review URL: https://codereview.chromium.org/207953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258850 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the (private) SharedMemory::{PrepareMapFile,FilePathForMemoryName}() ↵viettrungluu@chromium.org2014-03-222-3/+4
| | | | | | | | | | | | on Android. The first isn't implemented and the second isn't used. TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/206453009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258797 0039d316-1c4b-4281-b951-d872f2087c98
* Stack trace symbolization for Chrome sandbox processes.ivanpe@google.com2014-03-224-5/+313
| | | | | | | | | | | | | | | | | | | | | | | | Patching the POSIX implementation of base::debug::StackTrace to properly symbolize stack traces when used in Chrome sandbox processes. The main reason symbolization doesn't work today is because sandboxed processes cannot open proc/self/maps and the object files that contain the symbols. The proposed solution is to open all necessary files before enabling the sandbox and then keep their file descriptors around for the duration of the sandboxed process. This cannot be done in shipping/retail builds because it has security implications so for the time being this code will run only in DEBUG builds of Chrome. Originally, the code review was started under a different account. For more information take a look at: https://codereview.chromium.org/156043003/ BUG=341966 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258548 Review URL: https://codereview.chromium.org/184273012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258719 0039d316-1c4b-4281-b951-d872f2087c98
* Make possible to check memory allocations inside chromiumb.kelemen@samsung.com2014-03-217-25/+172
| | | | | | | | | | | | | | | | | | | | | This patch implements UncheckedMalloc and UncheckedCalloc for Linux. Previously it was only possible on Mac. The motivation is to let callers handle OOM gracefully instead of aborting. When tcmalloc is used this is implemented via a weak symbol that is overridden by tcmalloc. This way we get around the problem that neither base cannot depend on tcmalloc and vica versa. Unfortunately weak symbols are not supported on Windows. To make that work on Windows one will have to do some build system craft that is similar of what we do to replace the system malloc with tcmalloc. This cl does not try to solve the more controversial problem of disallowing the OOM handler for third party libraries under special circumstances. BUG=73751 Review URL: https://codereview.chromium.org/55333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258681 0039d316-1c4b-4281-b951-d872f2087c98
* GN: update base for recent gyp changesscottmg@chromium.org2014-03-211-3/+2
| | | | | | | | | TBR=brettw@chromium.org BUG=354261 Review URL: https://codereview.chromium.org/206453014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258622 0039d316-1c4b-4281-b951-d872f2087c98
* base: Rename DiscardableMemoryProvider to DiscardableMemoryManager.reveman@chromium.org2014-03-216-95/+95
| | | | | | | | | | | Simple renaming in preparation for refactor that will make this logic usable by more than "emulated" discardable memory. BUG=327516 Review URL: https://codereview.chromium.org/204783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258590 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Stack trace symbolization for Chrome sandbox processes. ↵vsevik@chromium.org2014-03-214-319/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/184273012/) Reason for revert: I believe this has broken ProcMapsTest.ParseProcMapsInvalidParameter test in base_unittests, see http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/18196 Original issue's description: > Stack trace symbolization for Chrome sandbox processes. > > Patching the POSIX implementation of base::debug::StackTrace to properly > symbolize stack traces when used in Chrome sandbox processes. The main > reason symbolization doesn't work today is because sandboxed processes > cannot open proc/self/maps and the object files that contain the symbols. > > The proposed solution is to open all necessary files before enabling the > sandbox and then keep their file descriptors around for the duration of > the sandboxed process. This cannot be done in shipping/retail builds > because it has security implications so for the time being this code will > run only in DEBUG builds of Chrome. > > Originally, the code review was started under a different account. For > more information take a look at: https://codereview.chromium.org/156043003/ > > BUG=341966 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258548 TBR=jamesr@chromium.org,jln@chromium.org,ajwong@chromium.org,rsesek@chromium.org,ivanpe@google.com NOTREECHECKS=true NOTRY=true BUG=341966 Review URL: https://codereview.chromium.org/208363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258587 0039d316-1c4b-4281-b951-d872f2087c98
* Stack trace symbolization for Chrome sandbox processes.ivanpe@google.com2014-03-214-5/+319
| | | | | | | | | | | | | | | | | | | | | | Patching the POSIX implementation of base::debug::StackTrace to properly symbolize stack traces when used in Chrome sandbox processes. The main reason symbolization doesn't work today is because sandboxed processes cannot open proc/self/maps and the object files that contain the symbols. The proposed solution is to open all necessary files before enabling the sandbox and then keep their file descriptors around for the duration of the sandboxed process. This cannot be done in shipping/retail builds because it has security implications so for the time being this code will run only in DEBUG builds of Chrome. Originally, the code review was started under a different account. For more information take a look at: https://codereview.chromium.org/156043003/ BUG=341966 Review URL: https://codereview.chromium.org/184273012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258548 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Workaround of an android platform bug.feng@chromium.org2014-03-214-6/+367
| | | | | | | | | | | | | | | | On some Android devices (e.g., Sony Xperia), package manager may fail to extract native libraries when updating Chrome. The change tries alleviate the situation by: 1) name libchrome with version number; 2) when failed to load library, try to extract native libraies and load them. BUG=311644 Review URL: https://codereview.chromium.org/200753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258546 0039d316-1c4b-4281-b951-d872f2087c98
* Expose original_function in IATPatchFunction and use that to set ↵hans@chromium.org2014-03-212-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | g_iat_orig_duplicate_handle Previously, the code would initialize g_iat_orig_duplicate_handle like this, before patching the IAT: g_iat_orig_duplicate_handle = ::DuplicateHandle; However, there is no guarantee that this actually ends up storing the original function pointer from the IAT. It could also just store the address of the thunk. Or, in the case of Clang, ::DuplicateHandle would get constant propagated to the call site that used g_iat_orig_duplicate_handle, which would then end up calling the patched ::DuplicateHandle and not the original one. The best way to get the address of the unpatched function is to get it from IATPatchFunction itself. BUG=82385 Review URL: https://codereview.chromium.org/205033009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258533 0039d316-1c4b-4281-b951-d872f2087c98
* net: Update FileStream to use base::File instead of PlatformFile.rvargas@chromium.org2014-03-217-40/+54
| | | | | | | | | | | | | As collateral damage, OpenContentUriForRead is now returning File instead of a plain file descriptor. BUG=322664 TEST=net_unittests R=willchan@chromium.org Review URL: https://codereview.chromium.org/189393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258472 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 258395 "Add a death test to check field trial creation be..."benwells@chromium.org2014-03-211-11/+0
| | | | | | | | | | | | | | | | This caused memory errors on the linux and chromeos valgrind bots. > Add a death test to check field trial creation before FieldTrialList. > > BUG=123063 > > Review URL: https://codereview.chromium.org/206523002 TBR=asvitkine@chromium.org Review URL: https://codereview.chromium.org/206473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258464 0039d316-1c4b-4281-b951-d872f2087c98
* Add the NSPR macro definitions for ARM64 bit.tedchoc@chromium.org2014-03-201-0/+53
| | | | | | | | BUG=354405 Review URL: https://codereview.chromium.org/206073009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258430 0039d316-1c4b-4281-b951-d872f2087c98
* Remove CreateAndOpenTemporaryShmemFile().viettrungluu@chromium.org2014-03-204-23/+6
| | | | | | | | | | It had exactly one use. R=brettw@chromium.org Review URL: https://codereview.chromium.org/205273004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258414 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "unreachable code" warnings (MSVC warning 4702) in base/.pkasting@chromium.org2014-03-202-9/+2
| | | | | | | | | | | | This also does a little bit of code formatting in the hopes of shorter, more readable code. BUG=346399 TEST=none R=thakis@chromium.org Review URL: https://codereview.chromium.org/202993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258398 0039d316-1c4b-4281-b951-d872f2087c98
* Add a death test to check field trial creation before FieldTrialList.asvitkine@chromium.org2014-03-201-0/+11
| | | | | | | | BUG=123063 Review URL: https://codereview.chromium.org/206523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258395 0039d316-1c4b-4281-b951-d872f2087c98
* Enable re2 for GN buildscottmg@chromium.org2014-03-201-1/+0
| | | | | | | | | R=brettw@chromium.org BUG=354261 Review URL: https://codereview.chromium.org/205723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258388 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated IsRunningOnHighRamDevice() method.lliabraa@chromium.org2014-03-203-12/+0
| | | | | | | | | | There are no longer any references to this deprecated method. BUG=353230 Review URL: https://codereview.chromium.org/204553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258378 0039d316-1c4b-4281-b951-d872f2087c98
* Convert scoped_ptr_malloc -> scoped_ptr, part 6.viettrungluu@chromium.org2014-03-201-134/+1
| | | | | | | | | | | scoped_ptr_malloc is deprecated; let's get rid of it. BUG=344245 R=brettw@chromium.org Review URL: https://codereview.chromium.org/202633004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258304 0039d316-1c4b-4281-b951-d872f2087c98
* Make the shmem-specific functions in file_util.h POSIX-only.viettrungluu@chromium.org2014-03-204-51/+44
| | | | | | | | | | | They're only used on POSIX. (This is an initial move/removal; more to come.) R=brettw@chromium.org Review URL: https://codereview.chromium.org/204683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258242 0039d316-1c4b-4281-b951-d872f2087c98
* Set error in LoadNativeLibrary() on Windows.xhwang@chromium.org2014-03-202-5/+12
| | | | | | | | | | | | | If the native library fails to load, call GetLastError() immediately and set error with the last system error code. The list of Windows system error codes can be found at: http://msdn.microsoft.com/en-us/library/windows/desktop/ms681381.aspx BUG=353771 TBR=evan@chromium.org Review URL: https://codereview.chromium.org/199413026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258214 0039d316-1c4b-4281-b951-d872f2087c98
* Fix trivial compile error in thread_perftest.ccjhorwich@chromium.org2014-03-191-1/+1
| | | | | | | | | | | | | Win_x64 LKGR builder has been red for awhile due to a trivial compile-time conversion error (size_t to int). BUG= TEST=run base_perftest on linux TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/203543009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258145 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a compile failure on some FYI bot that is worried about use-without-init.pkasting@chromium.org2014-03-191-17/+7
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258144 0039d316-1c4b-4281-b951-d872f2087c98
* Style changes split off of https://codereview.chromium.org/202993003/ .pkasting@chromium.org2014-03-192-80/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Violations: * If any conditional arms have braces, all arms must have braces. * Don't handle DCHECK failure. * No else after return * Use DCHECK instead of CHECK unless CHECK is truly necessary * Declare variables in the most local scope possible * Prefer (foo == 0) to (0 == foo) * Avoid unnecessary vertical whitespace * All lines of args should begin at the same position Not violations: * Use DCHECK_EQ() where possible for better error messages * Split compound DCHECKs into separate ones so it's easier to see which failed * Reverse conditionals where doing so allows removing braces and reducing indenting of more lines * Rewrap to avoid splitting a string constant * Don't use at(), it buys nothing over [] when exceptions are off * delete [] -> delete[] * Avoid unnecessary temps BUG=none TEST=none R=thakis@chromium.org Review URL: https://codereview.chromium.org/203223008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258095 0039d316-1c4b-4281-b951-d872f2087c98
* x11: Move X11ErrorHandler out of //base/ into //ui/gfx/x/sadrul@chromium.org2014-03-194-112/+0
| | | | | | | | | | | | | This is a simple file-move, with a notable change for linux-gtk that instead of using the GDK API for capturing X errors, this patch uses raw X API (which is currently used on chromeos and linux-aura). BUG=none R=brettw@chromium.org, oshima@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/203273006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258061 0039d316-1c4b-4281-b951-d872f2087c98
* Add an operator!= to base::FileDescriptor.viettrungluu@chromium.org2014-03-191-0/+4
| | | | | | | | | | (It already has an operator==.) R=brettw@chromium.org Review URL: https://codereview.chromium.org/203303007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257962 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded include string_util_posix.h.zvorygin@chromium.org2014-03-191-1/+0
| | | | | | | | | BUG=353954 R=thakis@chromium.org Review URL: https://codereview.chromium.org/203763007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257946 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate build warnings in base/ for Android x64zhenyu.liang@intel.com2014-03-194-10/+19
| | | | | | | | | | | This CL fixes format strings of printf and type conversions that cause compilation warnings while building Android x64. BUG=346626 Review URL: https://codereview.chromium.org/185423006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257942 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for Time and TimeTicks inside trace_event.mithro@mithis.com2014-03-192-0/+54
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/203063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257934 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a unused method and fix some styles according to the style guide.sungmann.cho@navercorp.com2014-03-191-25/+13
| | | | | | Review URL: https://codereview.chromium.org/201543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257921 0039d316-1c4b-4281-b951-d872f2087c98
* IPC: Make ipc_perftests run on Android.epenner@chromium.org2014-03-194-7/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | There was several minor issues: - Base perf logging file location was off-limits on Android - Printf needs to be flushed to be visible on Android. - Android needs to reset the 'PipeMap' manually since we can't 'exec' after forking a test process. If we don't do this the Channel thinks we are in a single- process test and tries to open an FD which was closed during forking. - Android's base file descriptor needs to be increased to prevent stomping the android native logging file-descriptor with the default pipe. - The test took too long, so the 'exponent' is reduced from 5 to 3 - We need an APK With this patch the test runs like on other platforms, and lots of testing code is fixed such that it works the same way on all platforms. BUG=345471 Review URL: https://codereview.chromium.org/196343019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257877 0039d316-1c4b-4281-b951-d872f2087c98
* Remove X11 and GTK dependencies from host_forwarderzhenyu.liang@intel.com2014-03-193-14/+7
| | | | | | | | | | Use libevent as the implementation of MessagePumpForUI. BUG=346113 Review URL: https://codereview.chromium.org/176713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257853 0039d316-1c4b-4281-b951-d872f2087c98
* base: Replace BytesToReclaimUnderModeratePressure with ↵reveman@chromium.org2014-03-183-27/+23
| | | | | | | | | | | | | | | | BytesToKeepUnderModeratePressure. Instead of purging a fixed amount of discardable memory under moderate pressure, purge until within some specific usage. This is a better behavior and less complicated to implement. BUG= TEST=base_unittests --gtest_filter=DiscardableMemoryProvider* Review URL: https://codereview.chromium.org/195813020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257802 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow calling Map on currently-mapped SharedMemoryjbauman@chromium.org2014-03-185-2/+24
| | | | | | | | | | This would leak the previous mapping of the memory. TBR=brettw Review URL: https://codereview.chromium.org/203123009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257789 0039d316-1c4b-4281-b951-d872f2087c98
* MemorySanitizer: adjust thread stack size to work around an MSan bug.earthdok@chromium.org2014-03-181-1/+2
| | | | | | | | | | BUG=353687 TBR=thakis@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/196343027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257779 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor IsRunningOnHighRamDevice() to be more specific.lliabraa@chromium.org2014-03-182-1/+32
| | | | | | | | | | | Deprecate IsRunningOnHighRamDevice() in favor of methods that allow more specific targeting of devices by amount of RAM. BUG=353230 Review URL: https://codereview.chromium.org/203593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257773 0039d316-1c4b-4281-b951-d872f2087c98
* Remove two Unicode characters that are not white space perpkasting@chromium.org2014-03-181-33/+31
| | | | | | | | | | | | | | http://www.unicode.org/Public/7.0.0/ucd/PropList-7.0.0d29.txt. This also gives all constants their official Unicode names. BUG=60231 TEST=Copy string from bug comment 0, but paste into omnibox instead of find box. Ensure there is no space in the pasted string. R=brettw@chromium.org Review URL: https://codereview.chromium.org/198853004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257704 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a brace style according to the style guide.sungmann.cho@navercorp.com2014-03-181-2/+1
| | | | | | Review URL: https://codereview.chromium.org/196653011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257696 0039d316-1c4b-4281-b951-d872f2087c98
* stack_trace_posix: Make size be a size_t in ProcessBacktrace().raphael.kubo.da.costa@intel.com2014-03-181-4/+4
| | | | | | | | | | | StackTrace::count_ has been a size_t since r148420, so adjust ProcessBacktrace() to use the same type as the rest of the code. R=ajwong@chromium.org Review URL: https://codereview.chromium.org/200713007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257642 0039d316-1c4b-4281-b951-d872f2087c98
* Run ContentMain in a browser_test's browser process. This removes ↵jam@chromium.org2014-03-182-7/+23
| | | | | | | | | | | | | duplication of code in the browser test harness for setting up the browser process, and also ensures that initialization code in ContentMainRunner runs. Most of the changes are to unit tests which run in browser test executables. These were getting all the setup that these binaries did for browser tests even though they were unit tests. Now they have to explicitly setup objects that they need. This would be done automatically if they were in a unit test binary and therefore using the unit test harness. The goal should be to move these tests to unit test binaries, and make them support launching some tests in separate processes building on the work that Pawel did. BUG=350550 R=sky@chromium.org Review URL: https://codereview.chromium.org/190663012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257597 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 257577 "Revert 257562 "Base: Make base::File use ScopedFD..."zmo@chromium.org2014-03-184-29/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reland this: turns out not responsible. > Revert 257562 "Base: Make base::File use ScopedFD on POSIX." > > Might caused a bunch of layout test failures, at least on Linux > > fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html, > fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html, > fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html, > fast/dom/Window/property-access-on-cached-window-after-frame-removed.html > > > Base: Make base::File use ScopedFD on POSIX. > > > > Now that ScopedFD lives outside of file_util, File can use it to remove manual > > lifetime management. > > > > This also standarizes the behavior on Close failures for all platforms. > > > > BUG=none > > > > Review URL: https://codereview.chromium.org/201083002 > > TBR=rvargas@chromium.org > > Review URL: https://codereview.chromium.org/202583005 TBR=zmo@chromium.org Review URL: https://codereview.chromium.org/202493007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257581 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 257562 "Base: Make base::File use ScopedFD on POSIX."zmo@chromium.org2014-03-184-39/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | Might caused a bunch of layout test failures, at least on Linux fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html, fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html, fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html, fast/dom/Window/property-access-on-cached-window-after-frame-removed.html > Base: Make base::File use ScopedFD on POSIX. > > Now that ScopedFD lives outside of file_util, File can use it to remove manual > lifetime management. > > This also standarizes the behavior on Close failures for all platforms. > > BUG=none > > Review URL: https://codereview.chromium.org/201083002 TBR=rvargas@chromium.org Review URL: https://codereview.chromium.org/202583005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257577 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 06:13:25 +0000