summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* wtc: please look at URL related code, and hooks and nitsjar@chromium.org2009-03-131-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | you might have commented on before. huanr: please look at sdch_filter code. The intent was no semantic change, and only change in histograms and stats gathered. I wanted to be sure I had better stats on several failure cases, as the turn-around time of adding stats to instrument such cases after they surface is just too long. The big feature is the mechanism for getting the total number of bytes passed to a filter. We use the filter context to achieve this, and then the SDCH filter can calculate compression ratio (from pre-gunzip vs post SDCH decompress). The number of bytes read was also histogrammed in a number of error scenarios, to better diagnose what is going on when these cases arrise (example: When some data is still buffered in the VCDIFF decoder). The sdch_filter destructor was getting long and hard to read with multiple if blocks, so I cleaned that up as well a bit (less indentation, and use of early returns). Nits not included in previous CL that earlier are listed as well. r=wtc,huanr Review URL: http://codereview.chromium.org/40319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11665 0039d316-1c4b-4281-b951-d872f2087c98
* Implement DownloadFile::Rename() for posix. Downloads work on linux!estade@chromium.org2009-03-132-3/+11
| | | | | | Review URL: http://codereview.chromium.org/46020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11659 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files ↵thestig@chromium.org2009-03-1312-6/+6
| | | | | | | | to ~400. Review URL: http://codereview.chromium.org/46039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the look of the Linux omnibox.deanm@chromium.org2009-03-132-0/+22
| | | | | | | | | | | | | | | | - Paint a border around the input widget, which makes it fit better into the toolbar. A bordered widget is also very nice to have for debugging, so I abstracted a small helper for making a bordered bin. - Improve the results popup by painting with some Pango attributes. Sort of looks awful over NX, but I'm hoping it looks better on a real session. BUG=8236 Review URL: http://codereview.chromium.org/46035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11644 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded platform_thread.h includes. Reduces number of includes from ↵thestig@chromium.org2009-03-132-2/+1
| | | | | | | | 598 to 511. Review URL: http://codereview.chromium.org/42165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11617 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging.h from cc files that don't use it.thestig@chromium.org2009-03-1216-18/+0
| | | | | | Review URL: http://codereview.chromium.org/42155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of logging.h in header files.thestig@chromium.org2009-03-129-5/+7
| | | | | | Review URL: http://codereview.chromium.org/43148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
* Add a GDK_COLOR_RGB macro for constructing GdkColors.deanm@chromium.org2009-03-121-0/+5
| | | | | | | | | This does the simple math of * 257 to map from a 1 byte component to the gint16 GdkColor values, and initializes the pixel field to 0. Review URL: http://codereview.chromium.org/43077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11526 0039d316-1c4b-4281-b951-d872f2087c98
* Switching to gyp generated vcprojs for some components.bradnelson@google.com2009-03-121-154/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Includes propset changes: Property changes on: C:\clients\chrome6\src\skia ___________________________________________________________________ Modified: svn:ignore - skia.xcodeproj + skia.xcodeproj skia.sln Property changes on: C:\clients\chrome6\src\third_party\zlib ___________________________________________________________________ Modified: svn:ignore - zlib.xcodeproj + zlib.xcodeproj zlib.sln Property changes on: C:\clients\chrome6\src\third_party\libpng ___________________________________________________________________ Modified: svn:ignore - libpng.xcodeproj + libpng.xcodeproj libpng.sln Property changes on: C:\clients\chrome6\src\third_party\libjpeg ___________________________________________________________________ Modified: svn:ignore - libjpeg.xcodeproj + libjpeg.xcodeproj libjpeg.sln Property changes on: C:\clients\chrome6\src\build ___________________________________________________________________ Modified: svn:ignore - all.xcodeproj + all.xcodeproj all.sln All.vcproj Property changes on: C:\clients\chrome6\src\base ___________________________________________________________________ Modified: svn:ignore - base.xcodeproj + base.xcodeproj base.vcproj base_gfx.vcproj base_unittests.vcproj debug_message.vcproj Property changes on: C:\clients\chrome6\src\testing ___________________________________________________________________ Modified: svn:ignore - gtest gtest.xcodeproj + gtest gtest.xcodeproj gtest.sln Review URL: http://codereview.chromium.org/43101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11512 0039d316-1c4b-4281-b951-d872f2087c98
* (purify bustage) Correct purify (only) reference to variablejar@chromium.org2009-03-111-1/+1
| | | | | | | tbr=erikkay Review URL: http://codereview.chromium.org/43097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11476 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tree bustagejar@chromium.org2009-03-111-2/+4
| | | | | | | | | mac/linux didn't like unused local varible. tbr=erikkay Review URL: http://codereview.chromium.org/43096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11474 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid leaks at shutdown when running purifyjar@chromium.org2009-03-111-4/+10
| | | | | | | | | | | | | We'll risk a (rare) crash under purify, but avoid having a leak detected. Note that this "leak" at shutdown is NBD, but this code at least shows that the would be leak is "understood" and acceptable. bug=6532 r=erikkay Review URL: http://codereview.chromium.org/42083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11473 0039d316-1c4b-4281-b951-d872f2087c98
* file_util::Move fails on Windows if moving a directoryhuanr@chromium.org2009-03-113-2/+61
| | | | | | | | | | | across volumes. This change adds a CopyAndDeleteDirectory function, and Move falls back to CopyAndDeleteDirectory if moving directory fails. BUG=8505 Review URL: http://codereview.chromium.org/43069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11460 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back change 11431 (didn't work with a clobber either).bradnelson@google.com2009-03-111-0/+154
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11432 0039d316-1c4b-4281-b951-d872f2087c98
* Attempting to roll out gyp for base.bradnelson@google.com2009-03-111-154/+0
| | | | | | | Broke the build last time. Trying it again, this time with clobber. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11431 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back change 11429.bradnelson@google.com2009-03-111-0/+154
| | | | | | | | Attempt to roll gyp out for base. The gyp script is not getting called at the right time to make this work. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11430 0039d316-1c4b-4281-b951-d872f2087c98
* junkbradnelson@google.com2009-03-111-154/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11429 0039d316-1c4b-4281-b951-d872f2087c98
* Adding more guids (realized unit tests get included in slns up higher in the ↵bradnelson@google.com2009-03-101-2/+3
| | | | | | | | tree. Review URL: http://codereview.chromium.org/43050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11397 0039d316-1c4b-4281-b951-d872f2087c98
* Adding fixed guids to some modules to facilitate incremental switch to gyp.bradnelson@google.com2009-03-101-0/+2
| | | | | | Review URL: http://codereview.chromium.org/42044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11388 0039d316-1c4b-4281-b951-d872f2087c98
* This changes the base clipboard class, as accomplishing paste requires that ↵avi@chromium.org2009-03-104-60/+75
| | | | | | | | Clipboard::FormatType be IPC-able. The lowest-common denominator of unsigned int, NSString*, and GdkAtom is string, so string it is. (Linux changes by estade.) Review URL: http://codereview.chromium.org/41012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11383 0039d316-1c4b-4281-b951-d872f2087c98
* Move FilePathTest under test_dir_ so it gets cleaned up on TearDown.thestig@chromium.org2009-03-101-3/+1
| | | | | | Review URL: http://codereview.chromium.org/41023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11349 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing test_file_util_posix.cc file.sgk@google.com2009-03-101-0/+1
| | | | | | Review URL: http://codereview.chromium.org/43024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11335 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-10143-146/+0
| | | | | | | | | Normalize end of file newlines in base/. All files end in a single newline. Review URL: http://codereview.chromium.org/42011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11329 0039d316-1c4b-4281-b951-d872f2087c98
* Move GdkPixbufFromSkBitmap to gtk_util so it can easily be shared.deanm@chromium.org2009-03-102-0/+45
| | | | | | | Review URL: http://codereview.chromium.org/38009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11327 0039d316-1c4b-4281-b951-d872f2087c98
* Add API functions to control Quantify, as well as expose theseasargent@chromium.org2009-03-095-0/+96
| | | | | | | | | functions to javascript. Review URL: http://codereview.chromium.org/40255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11291 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky TimerTest.DelayTimer_Reset test.phajdan.jr@chromium.org2009-03-092-1/+8
| | | | | | | | | | Not filing a bug because timer test are difficult to make not-flaky on the buildbots. However, added comments to the code so that people who touch this area remember to run all tests. Review URL: http://codereview.chromium.org/40312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11276 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilterContext to allow filters to access URLRequestJob datajar@chromium.org2009-03-091-0/+4
| | | | | | | r=wtc,darin,huanr Review URL: http://codereview.chromium.org/40138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11248 0039d316-1c4b-4281-b951-d872f2087c98
* Bringup sys_string_conversions_unittest.cc on Linux.jeremy@chromium.org2009-03-081-1/+0
| | | | | | Review URL: http://codereview.chromium.org/29010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11223 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in operator=() to ScopedComPtr.tommi@chromium.org2009-03-072-0/+8
| | | | | | Review URL: http://codereview.chromium.org/40256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11193 0039d316-1c4b-4281-b951-d872f2087c98
* Start the crash_service on windows when running ui tests, if it's not ↵jam@chromium.org2009-03-061-1/+1
| | | | | | | | running already. Otherwise there's no point in running ui_tests! Review URL: http://codereview.chromium.org/39282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11172 0039d316-1c4b-4281-b951-d872f2087c98
* Build test_shell and test_shell_tests on Linux from gyp-generated scons files:sgk@google.com2009-03-061-2/+9
| | | | | | | | | | | | | | | | | | | | | | * Catch up to recent changes: * Rename RenderThemeChromiumGtk.cpp to RenderThemeChromiumLinux.cpp. * Fix spelling of V*NPObject.{cpp,h} * Explicitly include varions WebCore *Gtk.cpp and *Linux.cpp files that are excluded by the general regular expression. * Add webinput_event_util.cc. * Exclude glue/plugins/plugin_stubs.cc. * Add a Linux test_shell_resources target to build test_shell_resources.{h,pak}. * Add an explicit test_shell action to repack resources into test_shell.pak. * Use -Wno-multichar when building libtest_shell_common.a. * Use -DWTF_USE_PTHREADS when building libwtf.a, and when dependent targets compile against it. * Use tools/test_shell/test_shell_main{,_GYP}.scons as the main entry point for GYP-based builds of webkit. * Add base/gfx/gtk_util.cc to the base build. Review URL: http://codereview.chromium.org/39219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11160 0039d316-1c4b-4281-b951-d872f2087c98
* In preparation for making changes to worker_pool_linux.cc.willchan@chromium.org2009-03-065-41/+41
| | | | | | Review URL: http://codereview.chromium.org/39081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11149 0039d316-1c4b-4281-b951-d872f2087c98
* I verified that the Visual C++ 2005 bug has been fixed inwtc@chromium.org2009-03-061-1/+1
| | | | | | | | | | Visual C++ 2008, so limit our workaround to Visual C++ 2005. R=eroman BUG=4387 Review URL: http://codereview.chromium.org/39225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11139 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in {test_,}file_util_posix.ccphajdan.jr@chromium.org2009-03-062-6/+10
| | | | | | | | | | - DCHECK_EQ instead of DCHECK(foo == bar) - more detailed log error messages - add a comment why we use 0777 permissions for new dirs (umask should produce sane permissions) Review URL: http://codereview.chromium.org/40162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11105 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11102.phajdan.jr@chromium.org2009-03-062-10/+6
| | | | | | | | | | Used git svn dcommit instead of git cl dcommit by mistake. Reverting to re-commit properly. TBR=erikkay Review URL: http://codereview.chromium.org/40213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11104 0039d316-1c4b-4281-b951-d872f2087c98
* Make CrashAwareSleep more accurate on POSIX (checking if the process exists).phajdan.jr@chromium.org2009-03-061-8/+20
| | | | | | Review URL: http://codereview.chromium.org/39185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11103 0039d316-1c4b-4281-b951-d872f2087c98
* first cutphajdan.jr@chromium.org2009-03-062-6/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11102 0039d316-1c4b-4281-b951-d872f2087c98
* An assert was being hit because WaitableEvent's dtor was calling CloseHandle ↵jam@chromium.org2009-03-062-0/+9
| | | | | | | | | | on a handle that we already closed. BUG=8070 Review URL: http://codereview.chromium.org/40195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11078 0039d316-1c4b-4281-b951-d872f2087c98
* Added a new method CreateNonJoinable() to PlatformThread. Added the windows ↵willchan@chromium.org2009-03-053-6/+41
| | | | | | | | and posix implementations. Review URL: http://codereview.chromium.org/40133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11053 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Rewrite IPC's interaction with FileDescriptoragl@chromium.org2009-03-051-0/+4
| | | | | | | | | | | | | | | | | | | The FileDescriptor API is clearly too hard to use. It's the only IPC data type which is non-POD and serialising an invalid file descriptor is fatal to Chrome on POSIX. The use of Maybe is possibly non-obvious to non-functional programmers. This patch merges Maybe and FileDescriptor so that serialising invalid file descriptors is permitted and results in -1 at the other end. (Serialising /closed/ a file descriptor is still fatal.) Also, it adds a pointer in base/file_descriptor.h to instructions for its use with IPC. Although it's generally bad practice to mention IPC in base, in this case I cannot find another suitable location. Review URL: http://codereview.chromium.org/39208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11041 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE.maruel@google.com2009-03-052-4/+6
| | | | | | | Split the lines >80 cols. (Part 1) Review URL: http://codereview.chromium.org/39206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
* Make UTF8ToWide take a StringPiece, to avoid copying to a std::string.deanm@chromium.org2009-03-052-2/+3
| | | | | | | | | The previous prototype took only a std::string, unless you used the less convenient output parameter version. This required copying char* input to a std::string. Using a StringPiece the input will be implicitly both std::string and char* without any copying. This helps especially on Linux, where all input we get will be in utf8 char*. Review URL: http://codereview.chromium.org/40106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10985 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-056-32/+32
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* Make startup_tests build and run on Linux (except reference tests).phajdan.jr@chromium.org2009-03-053-1/+120
| | | | | | Review URL: http://codereview.chromium.org/27240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10978 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 7377: Regression: Omnibox trims URL ending with 0x85 (Take 2)hbono@chromium.org2009-03-054-7/+85
| | | | | | | | | This is the same change as "http://codereview.chromium.org/20219/show", which I reverted it because it caused build breaks on sandbox. To investigate this build break, it seems this build break is somehow caused by "base/string_util.cc" that includes the TrimWhiteSpaceUTF8() function. To fix this build break, I moved the TrimWhiteSpaceUTF8() function to "base/string_util_icu.cc". BUG=7377 Review URL: http://codereview.chromium.org/28310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10970 0039d316-1c4b-4281-b951-d872f2087c98
* Make file_version_info work even without including windows.hbrettw@chromium.org2009-03-051-1/+4
| | | | | | Review URL: http://codereview.chromium.org/39166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10942 0039d316-1c4b-4281-b951-d872f2087c98
* Expose the iostream (logging) interfaces of some gfx:: classes.evan@chromium.org2009-03-043-17/+3
| | | | | | | | | This is useful when developing anyway, and the compiler ought to be able to eliminate any dead code if we don't use it. Review URL: http://codereview.chromium.org/39089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10926 0039d316-1c4b-4281-b951-d872f2087c98
* Make UITest::CrashAwareSleep portable.phajdan.jr@chromium.org2009-03-043-4/+29
| | | | | | Review URL: http://codereview.chromium.org/40119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10916 0039d316-1c4b-4281-b951-d872f2087c98
* Add trivial theming support in extensions.erikkay@google.com2009-03-041-3/+0
| | | | | | | NOTE: This is not final API. It *will* change. It's purely for testing purposes. Review URL: http://codereview.chromium.org/40042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10913 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NavigationEntry title to string16. TabContents::GetTitle no longer needsbrettw@chromium.org2009-03-042-2/+17
| | | | | | | | | | | | | | | to be virtual, either. This also changes how the display URL is computed. Instead of doing it preemptively, we now do so lazily. This allows us to do the URL formatting correctly using the elider so that we can do IDN and unescaping. I changed string_util's singleton functions. I was worried that other code might make a singleton of string, which would give you this same value as a non-const string. This would mean our empty strings might no longer be empty. Review URL: http://codereview.chromium.org/39022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10872 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-12-24 03:44:38 +0000