summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Don't allow dragging browser actions between regular and incognito windows.mpcomplete@chromium.org2010-03-302-0/+16
| | | | | | | | | | | | This fixes a crash. Also small fix to Pickle::ReadBytes to fix up the iterator if it is NULL. BUG=39340 Review URL: http://codereview.chromium.org/1542007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43147 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call Thread::CleanUp() before the MessageLoop destruction observers ↵eroman@chromium.org2010-03-303-23/+136
| | | | | | | | | | | | | | have run. This is consistent with the comment for Thread::CleanUp(), which says it runs after the message loop has "stopped". Certain consumers depend on this ordering to avoid accessing variables which are deleted by Thread::CleanUp(). BUG=39723 TEST=ThreadTest.CleanUp Review URL: http://codereview.chromium.org/1540002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43127 0039d316-1c4b-4281-b951-d872f2087c98
* For systems where SIZEOF_VOID_P is not defined, determine it basedpvalchev@google.com2010-03-301-1/+15
| | | | | | | | | on __LP64__ (which is predefined in gcc on 64-bit systems) (Necessary for BSD port) Review URL: http://codereview.chromium.org/747003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43108 0039d316-1c4b-4281-b951-d872f2087c98
* Minor C++ fixes found by Clang.evan@chromium.org2010-03-302-5/+7
| | | | | | | | | In cases where I've added an #include, it's generally due to Clang being more picky about templates being available during expansions. Review URL: http://codereview.chromium.org/1432003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43098 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43086 - 1. Create a new sandbox type which allows access to Unix ↵dmaclach@chromium.org2010-03-301-3/+0
| | | | | | | | | | | | | | | | | | sockets in the Mac renderer sandbox to support running Native Client. 2. Put the Native Client sel_ldr (which contains the user's untrusted code into a new Mac sandbox type. 3. Open /dev/random in SandboxWarmup(). 4. Remove the "nosandbox" flag when running Mac tests. BUG=http://code.google.com/p/nativeclient/issues/detail?id=327 TEST=nacl_ui_tests still pass while running in the sandbox. Review URL: http://codereview.chromium.org/1234003 TBR=msneck@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43093 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Create a new sandbox type which allows access to Unix sockets in the Macmsneck@google.com2010-03-301-0/+3
| | | | | | | | | | | | | | renderer sandbox to support running Native Client. 2. Put the Native Client sel_ldr (which contains the user's untrusted code into a new Mac sandbox type. 3. Open /dev/random in SandboxWarmup(). 4. Remove the "--nosandbox" flag when running Mac tests. BUG=http://code.google.com/p/nativeclient/issues/detail?id=327 TEST=nacl_ui_tests still pass while running in the sandbox. Review URL: http://codereview.chromium.org/1234003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43086 0039d316-1c4b-4281-b951-d872f2087c98
* Add win32 gtest filter files shared between Wine and TSan/Windowstimurrrr@chromium.org2010-03-302-18/+7
| | | | | | | BUG=28363 Review URL: http://codereview.chromium.org/1377003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43076 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r42300: "HttpRequestHeaders refactor."willchan@chromium.org2010-03-293-1/+105
| | | | | | | | | Adds a fix and tests for empty header values. The particular bug happened when the value was non-empty, but was all LWS, so it was effectively empty. BUG=22588 Review URL: http://codereview.chromium.org/1370001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43000 0039d316-1c4b-4281-b951-d872f2087c98
* Report unreadable files as size zero when uploading.vandebo@chromium.org2010-03-291-0/+54
| | | | | | | | | | | Upload zero bytes if the file size shrinks. BUG=30850 TEST=uploading an unreadable file works Review URL: http://codereview.chromium.org/1250002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42981 0039d316-1c4b-4281-b951-d872f2087c98
* linux: make shm opening failure fatalevan@chromium.org2010-03-291-3/+5
| | | | | | | | | | | | | | We should eventually add some recovery code path, but right now it's completely broken (see bug) and this is the quicker fix. FATAL logs pop up a dialog explaining what went wrong, too, so this will help users who don't look at the console output. BUG=39710 TEST=sudo chmod o-w /dev/shm; verify you get a dialog that yells at you at startup Review URL: http://codereview.chromium.org/1545003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42973 0039d316-1c4b-4281-b951-d872f2087c98
* Add Mac implementations of new SymmetricKey and Encryptor classes.snej@chromium.org2010-03-2916-96/+379
| | | | | | | | | BUG=none TEST=EncryptorTest, SymmetricKeyTest Review URL: http://codereview.chromium.org/1347002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42964 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Turn on the GTK+ integration by default.erg@chromium.org2010-03-262-0/+5
| | | | | | | | | | | | | | This will regress default startup time for users by 50ms. This doesn't matter because this is what the users want--I've lost count of the number bloggers, people on twitter, and people in our IRC channel complaining about the lack of GTK+ integration...when it's just not on by default. BUG=none TEST=none Review URL: http://codereview.chromium.org/1442001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42804 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run Memcheck sanity tests under ThreadSanitizertimurrrr@chromium.org2010-03-261-0/+5
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1408002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42760 0039d316-1c4b-4281-b951-d872f2087c98
* Implement more sanity tests for Memcheck/Valgrindtimurrrr@chromium.org2010-03-261-1/+67
| | | | | | Review URL: http://codereview.chromium.org/1242008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42751 0039d316-1c4b-4281-b951-d872f2087c98
* Add the linux_use_heapchecker GYP variable that should turn the tcmalloc heapglider@chromium.org2010-03-262-3/+13
| | | | | | | lleak checker on and off. Review URL: http://codereview.chromium.org/1334002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42740 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug where an empty version string is considered valid.akalin@chromium.org2010-03-253-18/+53
| | | | | | | | | | | | Made default constructor public, but DCHECK() on any use of a default-constructed object. BUG=none TEST=unittests Review URL: http://codereview.chromium.org/1364002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42681 0039d316-1c4b-4281-b951-d872f2087c98
* Implement random key generation and AES encryption using NSS.albertb@chromium.org2010-03-2517-138/+422
| | | | | | | | | BUG=none TEST=unit test Review URL: http://codereview.chromium.org/1142004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42649 0039d316-1c4b-4281-b951-d872f2087c98
* posix: stat() uses errno, not its return value, for errorsevan@chromium.org2010-03-251-1/+1
| | | | | | | | | | | | | l/stat() always return -1 on error, so we must examine errno if we want to handle errors specially. (This is only used for judging whether to print an error message, so it's not too harmful.) TEST=symlink to nowhere in a dir; Chrome should not complain about that symlink when enumerating files in the directory Review URL: http://codereview.chromium.org/1352001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42647 0039d316-1c4b-4281-b951-d872f2087c98
* Round the size of shared memory regions up to 64K. This allowssehr@google.com2010-03-251-1/+8
| | | | | | | | | native client modules to map these regions. With this fix, Pepper audio works on all three platforms. Review URL: http://codereview.chromium.org/1242006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42621 0039d316-1c4b-4281-b951-d872f2087c98
* Function to compute the total size of the files in a directorycpu@chromium.org2010-03-243-0/+52
| | | | | | | | | | | | | We need this for the diagnostic mode but it can be used by others. Did not see test for GetFileSize() so added them BUG=none TEST=ut included Review URL: http://codereview.chromium.org/1220001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42540 0039d316-1c4b-4281-b951-d872f2087c98
* Enable WorkerPoolTest.PostTask back under ThreadSanitizer on Mac OS.glider@chromium.org2010-03-241-6/+0
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/1276001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42462 0039d316-1c4b-4281-b951-d872f2087c98
* Annotated the scoped leak inside base::RSAPrivateKey::CreateFromPrivateKeyInfo,glider@chromium.org2010-03-243-17/+4
| | | | | | | | | | | | removed the annotations from the tests calling it (RSAPrivateKeyUnitTest.* and SignatureCreatorTest.BasicTest) BUG=34742 TBR=wtc Review URL: http://codereview.chromium.org/1271002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42459 0039d316-1c4b-4281-b951-d872f2087c98
* print stack trace to stderr as well as to dialog.oshima@chromium.org2010-03-241-12/+10
| | | | | | | | | | | Stacktrace info was shown only in dialog, and chromeos was not getting this as it does not have xmessage. Changed to include stacktrace to the log message before being printed to stderr. BUG=none TEST=none Review URL: http://codereview.chromium.org/1094012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42431 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Reland r42300: "HttpRequestHeaders refactor."""willchan@chromium.org2010-03-233-105/+1
| | | | | | | | Broke another layout test. Review URL: http://codereview.chromium.org/1223001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42387 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r42300: "HttpRequestHeaders refactor.""willchan@chromium.org2010-03-233-1/+105
| | | | | | | | | | | | This time, make sure HttpRequestHeaders::FindHeader() checks key lengths are equal. * Create HttpRequestHeaders. * Switch HttpNetworkTransaction to build request headers. TODO: Change extra_headers to use HttpRequestHeaders. BUG=22588 Review URL: http://codereview.chromium.org/1110014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42376 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r42300: "HttpRequestHeaders refactor."willchan@chromium.org2010-03-233-105/+1
| | | | | | | | | Broke access-control-basic-whitelist-request-headers.html layout test. BUG=22588 Review URL: http://codereview.chromium.org/1110012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42305 0039d316-1c4b-4281-b951-d872f2087c98
* HttpRequestHeaders refactor.willchan@chromium.org2010-03-233-1/+105
| | | | | | | | | | | * Create HttpRequestHeaders. * Switch HttpNetworkTransaction to build request headers. TODO: Change extra_headers to use HttpRequestHeaders. BUG=22588 Review URL: http://codereview.chromium.org/1039001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42300 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux shared library build.mmoss@google.com2010-03-221-0/+8
| | | | | | | | r42182 moved some gtk code into a library that didn't link gtk libs. Review URL: http://codereview.chromium.org/1074007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42261 0039d316-1c4b-4281-b951-d872f2087c98
* Allowing MSI mode detection to work from the master preferences file. robertshield@chromium.org2010-03-222-3/+8
| | | | | | | | | | | | | | | | Refactor the piece of master preferences code that was in setup_util.h|cc (setup) into master_preferences.h|cc (install_util). This adds an install_util -> googleurl dependency, which should to be fine. Add in master_preferences_dummy.cc to keep the nacl64 stuff compiling happily. Add values.h|cc to the portion of base built in 64 bit mode and add a minor fix to values.cc to make it build. Also refactor accompanying master_preferences test code from setup tests to install_util tests. BUG=19370 Review URL: http://codereview.chromium.org/979003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42248 0039d316-1c4b-4281-b951-d872f2087c98
* PBKDF2 implemetation using NSS.albertb@chromium.org2010-03-2214-30/+358
| | | | | | | | | BUG=none TEST=unit test Review URL: http://codereview.chromium.org/1024001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42247 0039d316-1c4b-4281-b951-d872f2087c98
* Annotated the memory leaks in RSAPrivateKeyUnitTest.* and glider@chromium.org2010-03-222-0/+17
| | | | | | | | | | SignatureCreatorTest.BasicTest. BUG=34742 TBR=wtc Review URL: http://codereview.chromium.org/1117007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42223 0039d316-1c4b-4281-b951-d872f2087c98
* fix mac bustage by adding NL to end of fileben@chromium.org2010-03-201-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42183 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-205-1/+611
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42152 - Fix the case where the browser livelocks if we cannot open a ↵vandebo@chromium.org2010-03-193-22/+0
| | | | | | | | | | | | | | | | | | | | | | file. If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. BUG=30850 Review URL: http://codereview.chromium.org/541022 TBR=vandebo@chromium.org Review URL: http://codereview.chromium.org/1145004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42154 0039d316-1c4b-4281-b951-d872f2087c98
* Notification for battery with <= 15 minutes remaining.seanparent@google.com2010-03-192-0/+55
| | | | | | | | | BUG=521 TEST=none Review URL: http://codereview.chromium.org/1079007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the case where the browser livelocks if we cannot open a file.vandebo@chromium.org2010-03-193-0/+22
| | | | | | | | | | | | | | | | | If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. BUG=30850 Review URL: http://codereview.chromium.org/541022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42152 0039d316-1c4b-4281-b951-d872f2087c98
* Just need to trigger a buildagl@chromium.org2010-03-191-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42141 0039d316-1c4b-4281-b951-d872f2087c98
* Die on an OOM situation in many more cases.avi@chromium.org2010-03-195-19/+249
| | | | | | | | | | | Continuation of http://codereview.chromium.org/875004 after a revert. BUG=http://crbug.com/12673 TEST=run out of memory and die Review URL: http://codereview.chromium.org/1039007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42127 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run ProcessUtilTest.GetAppOutputRestrictedNoZombies under TSantimurrrr@chromium.org2010-03-191-0/+2
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1075007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42096 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for interacting with the DOM in browser_tests.kkania@chromium.org2010-03-182-1/+18
| | | | | | | | | BUG=none TEST=none Reivew url: http://codereview.chromium.org/660046 Review URL: http://codereview.chromium.org/1051005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42026 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the license check script for base/third_party/{nss,nspr}.evan@chromium.org2010-03-184-3/+71
| | | | | | | | | Rather than trying to be clever about licenses, just include the proper licenses directly. Review URL: http://codereview.chromium.org/1143001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42020 0039d316-1c4b-4281-b951-d872f2087c98
* Pass license-checker script for base/third_party/*.evan@chromium.org2010-03-1816-11/+186
| | | | | | | | | | | | | License checker change: Since most projects have a LICENSE file, look for that by default. Since as far as I can tell NSS and NSPR are both just MPL tri-license without a per project copyright, I think I will amend the license-checker to source those licenses separately. Review URL: http://codereview.chromium.org/1121003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42016 0039d316-1c4b-4281-b951-d872f2087c98
* Added release() method to ScopedHGlobal.sanjeevr@chromium.org2010-03-181-0/+6
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/1063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41960 0039d316-1c4b-4281-b951-d872f2087c98
* Merged third_party/tcmalloc/vendor/src(google-perftools r87) intoglider@chromium.org2010-03-181-20/+2
| | | | | | | | | | third_party/tcmalloc/chromium/src. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41938 Review URL: http://codereview.chromium.org/576001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41950 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41938 - Merged third_party/tcmalloc/vendor/src(googleperftools r87) intoglider@chromium.org2010-03-181-2/+20
| | | | | | | | | | | third_party/tcmalloc/chromium/src. Review URL: http://codereview.chromium.org/576001 TBR=glider@chromium.org Review URL: http://codereview.chromium.org/1076002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41942 0039d316-1c4b-4281-b951-d872f2087c98
* Merged third_party/tcmalloc/vendor/src(google-perftools r87) intoglider@chromium.org2010-03-181-20/+2
| | | | | | | | third_party/tcmalloc/chromium/src. Review URL: http://codereview.chromium.org/576001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41938 0039d316-1c4b-4281-b951-d872f2087c98
* In release mode, trigger a SIGABRT rather than a SIGTRAP for fatal log ↵thestig@chromium.org2010-03-181-10/+28
| | | | | | | | | | errors, i.e. CHECK(false). Also enable tests to make sure we assert/crash as expected. BUG=none TEST=Chrome in release mode generates crash dumps when CHECK() fails. See UI tests: AssertionTest.*:CheckFalseTest.*:RendererCrashTest.* Review URL: http://codereview.chromium.org/830003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41912 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Handle race conditions in file_util::CreateDirectory where multiple ↵thestig@chromium.org2010-03-171-4/+10
| | | | | | | | | | processes tries to create the same file system tree simultaneously. BUG=38112 TEST=none Review URL: http://codereview.chromium.org/990002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41881 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that an autorelease pool is available in worker_pool_mac'smark@chromium.org2010-03-171-0/+2
| | | | | | | | | | WorkerPool::PostTask. BUG=38357, 20471 (but probably only peripherally) TEST=no messages from __NSAutoreleaseNoPool() at launch Review URL: http://codereview.chromium.org/999002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41871 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 41834; ui tests are asploding.avi@chromium.org2010-03-175-251/+20
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41837 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 05:51:00 +0000