summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* CommandLineTest.ProgramQuotes: Fix crash-prone test.mgiuca2014-09-241-4/+1
| | | | | | | | | | | | Previously, this test would crash if the output wasn't quoted properly (since it assumes that cmd_string.length() >= program_string.length() + 2). Instead, directly compare the string with the expected output. This also guards against the possibility of mis-constructing the expected string. Review URL: https://codereview.chromium.org/589393002 Cr-Commit-Position: refs/heads/master@{#296350}
* Make content_shell_apk build completelycjhopman2014-09-241-2/+7
| | | | | | | | | | | | | | | | | | | | This fixes configuration of various targets (mostly adding some missing files for is_android builds). Adds a target setting up the content_shell_apk assets directory. Uncomments the previously non-working dependencies from libcontent_shell_content_view. Adds forwarding of testonly in all of the android templates. TBR=mark@ BUG=359249 Review URL: https://codereview.chromium.org/569923003 Cr-Commit-Position: refs/heads/master@{#296319}
* Replace forward_dependent_configs with public_depsBrett Wilson2014-09-232-2/+2
| | | | | | | | | | | | This is the new name. It has the same meaning but additionally with a "you can use the headers" permission. Rename direct_dependent_configs to public_configs. This is the new name with identical meaning. TBR=jamesr Review URL: https://codereview.chromium.org/595073002 Cr-Commit-Position: refs/heads/master@{#296302}
* Remove implicit HANDLE conversions from base.rvargas2014-09-239-60/+63
| | | | | | | | | BUG=416722 R=brettw@chromium.org Review URL: https://codereview.chromium.org/593113004 Cr-Commit-Position: refs/heads/master@{#296276}
* Remove TSan annotations from base/glider2014-09-234-24/+0
| | | | | | | | | | | | | , because ThreadSanitizer v2 doesn't need base::subtle to be annotated. We can't drop the dependency on libdynamic_annotations yet, because some code calls RunningOnValgrind(). Also remove the unused dynamic_annotations.h headers from base/ and add one to content/test/, which uses RunningOnValgrind(). BUG=349861 R=ajwong@chromium.org,phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/580813002 Cr-Commit-Position: refs/heads/master@{#296265}
* Use ScopedHandle for the private members of WaitableEvent.rvargas2014-09-232-13/+12
| | | | | | | | | BUG=416721 R=brettw@chromium.org Review URL: https://codereview.chromium.org/593973002 Cr-Commit-Position: refs/heads/master@{#296258}
* Adds Build.MANUFACTURER to native BuildInfo wrapper.gunsch2014-09-233-0/+11
| | | | | | | | | R=yfriedman@chromium.org BUG=None Review URL: https://codereview.chromium.org/599553002 Cr-Commit-Position: refs/heads/master@{#296257}
* [Android] Experimental sync barrier detection for tracingjdduke2014-09-231-1/+106
| | | | | | | | | | | | | | | | | | | | | | | When an Android View is invalidated outside of frame dispatch (animation/input/draw), a sync barrier may be inserted into the shared UI thread message loop. This effectively blocks dispatch of all Chrome tasks posted to the browser UI thread for an entire frame (or more if the View is continually invalidated). There are currently no easy or even automated ways to avoid this untimely invalidation, and judicious coding can only take us so far. As an intermediate assist in debugging the issue, use reflection and a crude form of MessageQueue inspection to trace known cases where the MessageQueue is blocked by a sync barrier. Note that this detection is not perfect, neither is it exact, but it's a solid proxy for informing traces about such pipeline stalls. BUG=407133 Review URL: https://codereview.chromium.org/575103002 Cr-Commit-Position: refs/heads/master@{#296249}
* Only do aggressive metro viewer termination in testsscottmg2014-09-224-190/+0
| | | | | | | | | | | | | | | | | | The previous patch https://codereview.chromium.org/584513004 ran on all metro viewer shutdowns, which would lead to Alt-F4 not being processed which means that the proper metro process shutdown wouldn't happen, potentially leaving the "ghost" icon. Instead, only do the aggressive termination from the process_host side and only when running test binaries (where we're concerned about having the viewer be able to run again immediately.) R=ananta@chromium.org BUG=411147,416356 Review URL: https://codereview.chromium.org/584213002 Cr-Commit-Position: refs/heads/master@{#295995}
* Disable implicit conversions of scoped_refptr to T* on Mac.dcheng2014-09-201-1/+1
| | | | | | | | | | | | | The implicit conversion has already been disabled for Linux and ChromeOS builds. https://codereview.chromium.org/510323002 explains the rationale for proceeding incrementally. BUG=110610 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/589853002 Cr-Commit-Position: refs/heads/master@{#295889}
* GN: Build //base with USE_SYMBOLIZE on Linuxcmasone2014-09-201-0/+2
| | | | | | | | | | | | | | | | In base.gyp, USE_SYMBOLIZE is added for Desktop Linux and Chrome OS builds for both base and base_unittests. In the GN build, it's added for 'is_linux' builds (which does not include Android), but only for base_unittests. This adds the define for //base as well. BUG=335824 TEST=build base and base_unittests, make a debug build and force a DCHECK() -- you should get a useful stack trace R=scottmg@chromium.org Review URL: https://codereview.chromium.org/583263003 Cr-Commit-Position: refs/heads/master@{#295885}
* [Checkstyle] Enable boolean simplification and empty expression checks.aurimas2014-09-201-1/+1
| | | | | | | | | | | Fix up some issues along the way. BUG=318404 TBR=nyquist@chromium.org,boliu@chromium.org Review URL: https://codereview.chromium.org/587893002 Cr-Commit-Position: refs/heads/master@{#295884}
* Remove implicit conversions from scoped_refptr to T* in FileWatcher.dcheng2014-09-202-2/+2
| | | | | | | | | | | | | Since set_message_loop() takes ownership of the MessageLoop parameter anyway, just pass it a const scoped_refptr<T>&, rather than converting from scoped_refptr to T* back to scoped_refptr. BUG=110610 TBR=rvargas@chromioum.org Review URL: https://codereview.chromium.org/588003002 Cr-Commit-Position: refs/heads/master@{#295875}
* Remove implicit conversions from scoped_refptr to T* in base/dcheng2014-09-201-2/+2
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Mac build. BUG=110610 Review URL: https://codereview.chromium.org/584883003 Cr-Commit-Position: refs/heads/master@{#295855}
* Improve GN header checker, make "check" on //ui/* pass.Brett Wilson2014-09-191-2/+5
| | | | | | | | | | | | | | | | | | | | I went through and made "gn check //ui/*" pass, and did a lot of enhancements for the bugs I found. Fixes a big bug in the header checker where it did not consider direct private dependencies to be OK from a header include perspective. However, private deps only change things when there are intermediate targets. This patch marks direct deps OK, and changes the variable names from is_public to is_permitted (since it may not actually be public). Allow includes to be permitted if any target allows the include, rather than all of them. This happens if multiple targets have the same file as sources. Strip the generated file directory from the beginning of sources. Previously, this was only for outputs (since typically they're included assuming the root gen dir is on the path). This comes up when an action generates a file, and then it's put into a source set (which we do a lot). This change allows a public dependency on the source set to count for header include purposes. Track public/private deps in the dependency path finder so the error message can show which deps are private that break the chain. This was really helpful when tracking down errors. Add deps and public deps to the build to make check pass. R=scottmg@chromium.org Review URL: https://codereview.chromium.org/584683002 Cr-Commit-Position: refs/heads/master@{#295783}
* Disable TLS destructor tests on Win x64 incrementalscottmg2014-09-193-2/+19
| | | | | | | | | | | | | | | The linker is coalescing sections incorrectly (x64-only, incremental-only), so disable these tests for now in that configuration. See crbug.com/251251 for more details. Upstream toolchain bug at https://connect.microsoft.com/VisualStudio/feedbackdetail/view/967992 R=wfh@chromium.org BUG=251251 Review URL: https://codereview.chromium.org/580213002 Cr-Commit-Position: refs/heads/master@{#295770}
* Only add pdb to isolate when fastbuild!=2.John Abd-El-Malek2014-09-191-3/+1
| | | | | | | | | | BUG=414808 R=scottmg@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/589633002 Cr-Commit-Position: refs/heads/master@{#295754}
* Do not special case the accept button of the time picker.miguelg2014-09-191-6/+0
| | | | | | | | BUG=412458 Review URL: https://codereview.chromium.org/587613002 Cr-Commit-Position: refs/heads/master@{#295731}
* Component updater must fallback on using HTTP on Windows XPSP2 and belowsorin2014-09-192-0/+26
| | | | | | | | BUG=411009 Review URL: https://codereview.chromium.org/581803002 Cr-Commit-Position: refs/heads/master@{#295633}
* [Android] Invalidate ChromeShell progress bar during animationjdduke2014-09-181-0/+32
| | | | | | | | | | | | View invalidations outside of animation can stall the Chrome message loop. Avoid such stalls during page load by synchronizing all ChromeShell progress drawable updates with View animation. BUG=414674 Review URL: https://codereview.chromium.org/583673002 Cr-Commit-Position: refs/heads/master@{#295604}
* Clean up unused param in RegistryOverrideManagergab2014-09-183-9/+6
| | | | | | | | | | This param has been unused since http://crrev.com/234367 and makes the method confusing. BUG=314800 Review URL: https://codereview.chromium.org/575253002 Cr-Commit-Position: refs/heads/master@{#295400}
* Compile specific parts of the Android build with -O2.fdegans2014-09-176-2/+53
| | | | | | | | BUG=411909 Review URL: https://codereview.chromium.org/555373004 Cr-Commit-Position: refs/heads/master@{#295306}
* Disable implicit conversions of scoped_refptr to T* on CrOS.dcheng2014-09-171-1/+1
| | | | | | | | | | | | The implicit conversion has already been disabled for Linux builds for some time now. https://codereview.chromium.org/510323002 explains the rationale for proceeding incrementally. BUG=110610 Review URL: https://codereview.chromium.org/572713003 Cr-Commit-Position: refs/heads/master@{#295234}
* Make base::internal::CallbackBase::is_null inline.ricea2014-09-172-5/+1
| | | | | | | | | | | | This saves 11 bytes per call site on x64-clang and 12 byte per call site on ARM-gcc. BUG=410776 TEST=base_unittests Review URL: https://codereview.chromium.org/540883002 Cr-Commit-Position: refs/heads/master@{#295215}
* gn: add base/debug/asan_invalid_access.*scottmg2014-09-161-0/+2
| | | | | | | | | | | | Added at https://codereview.chromium.org/306753003 but not included into the GN build. R=brettw@chromium.org BUG=335824 Review URL: https://codereview.chromium.org/581483002 Cr-Commit-Position: refs/heads/master@{#295175}
* Revert of Set the javac target and source to 1.7 (patchset #2 id:20001 of ↵aurimas2014-09-161-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | https://chromiumcodereview.appspot.com/545363002/) Reason for revert: Not all bots have Java 7 yet :( Original issue's description: > Set the javac target and source to 1.7 > > BUG=336589 > TBR=yfriedman@chromium.org > > Committed: https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b > Cr-Commit-Position: refs/heads/master@{#295162} TBR=cjhopman@chromium.org,yfriedman@chromium.org NOTREECHECKS=true NOTRY=true BUG=336589 Review URL: https://codereview.chromium.org/579543003 Cr-Commit-Position: refs/heads/master@{#295165}
* Set the javac target and source to 1.7aurimas2014-09-161-0/+2
| | | | | | | | | BUG=336589 TBR=yfriedman@chromium.org Review URL: https://codereview.chromium.org/545363002 Cr-Commit-Position: refs/heads/master@{#295162}
* CreateTrailsFromString function accepts values for trails_string argument ↵gayane2014-09-162-4/+14
| | | | | | | | | | without last separator symbol BUG=401298 Review URL: https://codereview.chromium.org/452923003 Cr-Commit-Position: refs/heads/master@{#295153}
* Use a better c++11 readiness check.Nico Weber2014-09-161-56/+0
| | | | | | | | | | | | | | | This is like https://codereview.chromium.org/443483002/ , but that check wasn't as convincing as it could have been since clang accepts override and final as an extension in c++98 mode. No intended behavior change. If your bot can't deal with this, please let me know! BUG=none R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/555383004 Cr-Commit-Position: refs/heads/master@{#295128}
* Use a C++11 feature in a single file, to discover if this works everywhere.Nico Weber2014-09-161-16/+0
| | | | | | | | | | | | | | | | | | Similar to https://codereview.chromium.org/385743002 , but in a file that's also built in host targets. Depends on r#294584. If your bot can't deal with this, please let me know! BUG=none Committed: https://crrev.com/5928c2f978a43488a2f45fe7da1d91dfdba1d593 Cr-Commit-Position: refs/heads/master@{#294687} R=ajwong@chromium.org Review URL: https://codereview.chromium.org/443483002 Cr-Commit-Position: refs/heads/master@{#294961}
* Avoid unsafe usage of CancelIo() within Windows SyncSocket.dalecurtis2014-09-161-12/+18
| | | | | | | | | | | | | | | | | The CancelIo() operation does not synchronously cancel IO operations, we must wait for them to return before returning to avoid writes to resources which may have already been destructed. See this blog post for more information: http://blogs.msdn.com/b/oldnewthing/archive/2011/02/02/10123392.aspx BUG=413494 TEST=manual inspect of cancellation states. Review URL: https://codereview.chromium.org/570713003 Cr-Commit-Position: refs/heads/master@{#294946}
* Revert of [Android] Mark posted UI thread tasks as asynchronous (patchset #4 ↵jdduke2014-09-151-49/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:60001 of https://codereview.chromium.org/512333002/) Reason for revert: This patch was purely experimental, and the experiment has expired. Original issue's description: > [Android] Mark posted UI thread tasks as asynchronous > > Chromium shares a message loop with Android on the browser UI thread. > This can cause problems when the associated Looper has a sync barrier, > preventing posted Chromium tasks from being dispatched until the > barrier is removed. Make this sharing more fair by marking all Chromium > Message tasks as asynchronous, avoiding stalls when there is a sync > barrier. > > Note: This change is for gathering data about the perf impact and we'll > revert it before cutting a release branch. > > BUG=407149,380781,407133 > > Committed: https://crrev.com/feabeebb3ac5810f896ac8303a77ee695acaf9d4 > Cr-Commit-Position: refs/heads/master@{#292551} TBR=aelias@chromium.org,epenner@chromium.org,nyquist@chromium.org,sievers@chromium.org,skyostil@chromium.org NOTREECHECKS=true NOTRY=true BUG=407149,380781,407133 Review URL: https://codereview.chromium.org/564373005 Cr-Commit-Position: refs/heads/master@{#294875}
* Creating a framework for suppressing pollution of the profiler data and ↵vadimt2014-09-1511-128/+499
| | | | | | | | | | | | | | | | | | applying for know cases of pollution. See the bug. The CL introduces TaskStopwatch that has to be used to measure run time for tasks. It takes care of double-counting run time in the nested-tasks case by subtracting run time of nested tasks from their parents. TaskStopwatch can be also used for subtracting other nested intervals, such as the time while a nested message pump runs. ThreadData::TallyADeath now takes a stopwatch parameter instead of start_time and end_time. This helps avoid mistakes when the interval passed up to the parent for exclusion is different from the interval for the current task duration. BUG=401560 Review URL: https://codereview.chromium.org/445413003 Cr-Commit-Position: refs/heads/master@{#294865}
* Revert of Use a C++11 feature in a single file, to discover if this works ↵kevers2014-09-151-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | everywhere. (patchset #5 id:70001 of https://codereview.chromium.org/443483002/) Reason for revert: Breaks Arm compile of Chrome on ChromeOS. http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/1732 chromeos-chrome-39.0.2157.0_alpha-r1: In file included from threading/watchdog.cc:5:0: chromeos-chrome-39.0.2157.0_alpha-r1: ../base/threading/watchdog.h:68:29: error: override controls (override/final) only available with -std=c++11 or -std=gnu++11 [-Werror] chromeos-chrome-39.0.2157.0_alpha-r1: virtual void ThreadMain() OVERRIDE; Original issue's description: > Use a C++11 feature in a single file, to discover if this works everywhere. > > Similar to https://codereview.chromium.org/385743002 , but in a file > that's also built in host targets. Depends on r#294584. > > If your bot can't deal with this, please let me know! > > BUG=none > > Committed: https://crrev.com/5928c2f978a43488a2f45fe7da1d91dfdba1d593 > Cr-Commit-Position: refs/heads/master@{#294687} TBR=ajwong@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/570083002 Cr-Commit-Position: refs/heads/master@{#294822}
* Revert of Cleanup: Remove base/file_util.h. Convert remaining references. ↵thestig2014-09-131-0/+6
| | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/568873004/) Reason for revert: Broke some internal builds. Need to give them a chance to fix their builds. Original issue's description: > Cleanup: Remove base/file_util.h. Convert remaining references. > > TBR=brettw@chromium.org > > Committed: https://crrev.com/6d63c4898c2da5a286d01f80229baeb914f99f18 > Cr-Commit-Position: refs/heads/master@{#294729} TBR=brettw@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/565803006 Cr-Commit-Position: refs/heads/master@{#294755}
* Maintaing the proper order of initialization WeakPtrFactorykulkarni.a2014-09-135-9/+10
| | | | | | | | | | | | | Changing in the intialization order of WeakPtrFactory in "src/base" module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Review URL: https://codereview.chromium.org/565123002 Cr-Commit-Position: refs/heads/master@{#294741}
* Cleanup: Remove base/file_util.h. Convert remaining references.thestig2014-09-131-6/+0
| | | | | | | | TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/568873004 Cr-Commit-Position: refs/heads/master@{#294729}
* Use a C++11 feature in a single file, to discover if this works everywhere.thakis2014-09-121-16/+0
| | | | | | | | | | | | | Similar to https://codereview.chromium.org/385743002 , but in a file that's also built in host targets. Depends on r#294584. If your bot can't deal with this, please let me know! BUG=none Review URL: https://codereview.chromium.org/443483002 Cr-Commit-Position: refs/heads/master@{#294687}
* Migrate ResourceExtractor.java inside org.chromium.base package.vivek.vg2014-09-122-0/+413
| | | | | | | | | | | | | | | | | | | With the CL, https://codereview.chromium.org/456413002, we are migrating from embedding inline resources inside blink towards using chromium's grd resource system. As part of this effort, most of the tests would require to use the 'pak' files packaged as android application assets. These assets need to be extracted to the application data directory during the startup of the test application. The native libraries would be able to work with these 'pak' files only after the extraction from the asset manager. To achieve this goal, we would require that ResourceExtractor.java to be moved inside the org.chromium.base pacakge so that it can be utilized in ChromeNativeTestActivity.java BUG=312586 Review URL: https://codereview.chromium.org/548023002 Cr-Commit-Position: refs/heads/master@{#294548}
* On library load failure, retry without shared RELRO.simonb2014-09-112-8/+46
| | | | | | | | | | | | | | | | | | https://codereview.chromium.org/443393003 introduced code for service processes that turns off RELRO sharing and retries a library load in the event of an address clash or other failure to load a library with shared RELRO. This change adds the same back off and retry strategy to the libraries loaded in the main browser process, for cases where low memory devices aggressively share RELRO as widely as possible. BUG=411928 TBR=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/551373004 Cr-Commit-Position: refs/heads/master@{#294393}
* Do not rely on XDG_CURRENT_DESKTOP only when testing for Unity.joleksy2014-09-111-2/+10
| | | | | | | | | | | gnome-fallback sessions set XDG_CURRENT_DESKTOP to Unity, DESKTOP_SESSION needs to be tested as well. BUG= Review URL: https://codereview.chromium.org/550173006 Cr-Commit-Position: refs/heads/master@{#294381}
* gn: Add missing -Wexit-time-destructors on basescottmg2014-09-111-0/+2
| | | | | | | | | TBR=brettw@chromium.org BUG=335824 Review URL: https://codereview.chromium.org/560143002 Cr-Commit-Position: refs/heads/master@{#294263}
* Give asan/win bot a very generous timeout.thakis2014-09-101-1/+1
| | | | | | | | | | | | | | The previous increase in r293993 didn't help anything; make the timeout really large to make sure that things aren't just slow. (Once this hasn't helped either, we're going to remove this win/asan special case.) BUG=412471 TBR=timurrrr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/557333007 Cr-Commit-Position: refs/heads/master@{#294242}
* Clean up investigation code in DeleteHelper::DoDeletetzik2014-09-101-4/+0
| | | | | | | | | | | Removing a local variable to keep it in the crash dump, that is added in: http://crrev.com/c7f0b95fefa64b7bb0accea8aafc3fb819bfdcc7 BUG=393634 Review URL: https://codereview.chromium.org/562493004 Cr-Commit-Position: refs/heads/master@{#294143}
* Make base_unittests_apk actually workcjhopman2014-09-093-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes the "test" template to create a shared_library (instead of an executable) on Android. After this, we can actually run base_unittests with `build/android/test_runner.py gtest -s base_unnittests` as normal (though may need to CHROMIUM_OUT_DIR and BUILDTYPE as appropriate). This requires adding the following targets: //testing/android:native_test_native_code //testing/android:native_test_util //testing/android:native_test_jni_headers //tools/android/md5sum:md5sum //tools/android/md5sum:md5sum_bin //tools/android/md5sum:md5sum_prepare_dist //tools/android/md5sum:md5sum_copy_host Also, makes it so that native executables are stripped (just like shared libraries). Adds a simple create_native_execuatable_dist template that sets up a dist directory for the executable (see build/android/gyp/native_app_dependencies.gyp). BUG=359249 TBR=rlarocque Review URL: https://codereview.chromium.org/557463002 Cr-Commit-Position: refs/heads/master@{#294032}
* Fix SDK forward declarations after CL 530193004jiangj2014-09-091-25/+19
| | | | | | | | | | | | The APIs that need forward declarations were actually introduced in OS X 10.7 SDK instead of 10.9 SDK, forward declare them in the wrong place will cause build issue when using older SDKs like 10.7 or 10.8. BUG=390212 Review URL: https://codereview.chromium.org/555163002 Cr-Commit-Position: refs/heads/master@{#294013}
* Speculatively increase the test timeout for win/asan.Nico Weber2014-09-091-0/+4
| | | | | | | | | BUG=412471 TBR=timurrrr@chromium.org Review URL: https://codereview.chromium.org/558733002 Cr-Commit-Position: refs/heads/master@{#293993}
* Add an 'Idle Wake Ups' metric to the Linux task manager, implement backend.thestig2014-09-094-41/+104
| | | | | | | | BUG=120488 Review URL: https://codereview.chromium.org/546193002 Cr-Commit-Position: refs/heads/master@{#293991}
* Remove the IShellLink::Resolve step in ResolveShortcutProperties.Gabriel Charette2014-09-092-7/+6
| | | | | | | | | | | | | | | This call was only useful if we cared to have Windows attempt to find the target should the path have moved. Since moving Chrome installs (or installing them on anything but a local C: drive) is unsupported there is no need to do this. This code only cares about the target path currently stored in the shortcut (regardless of its existence) -- for which GetPath() is sufficient. This call could otherwise take up to 3 seconds per unresolvable shortcut which can drastically impact uninstall times when setup.exe attempts to delete all shortcuts pointing to its chrome.exe in common shortcut paths. This should also get rid of LOG(ERROR)s in test_installer about unresolveable shortcuts as we will now only inspect the path stored in the shortcut without trying to actually resolve it. BUG=412380 R=cpu@chromium.org, grt@chromium.org Review URL: https://codereview.chromium.org/553783005 Cr-Commit-Position: refs/heads/master@{#293986}
* Added BASE_EXPORT to EnabledStateObserver classxunjieli2014-09-091-1/+2
| | | | | | | | | | | | | This CL adds a BASE_EXPORT to EnabledStateObserver class. This CL is a part of the effort to get NetLog data into tracing. Since EnabledStateObserver is not base exported, we would like it to be so that we can use it outside base. BUG=399701 Review URL: https://codereview.chromium.org/551333003 Cr-Commit-Position: refs/heads/master@{#293943}
generated by cgit v1.1 at 2025-03-27 23:15:12 +0000