| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of the big things is starting to move/declare ctors/dtors that derive from RefCounted<> to/in the implementation file.
(Saves 4 megabytes from libglue.a alone. 1 meg off libbrowser.a. Hundred of kilobyte savings in a large number of .a files; only libmedia.a grew and it's only 100k.)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3452030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=WatchdogTest.DisarmTest doesn't go flaky
Review URL: http://codereview.chromium.org/3545001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I adjusted the test to not depend on timed waits,
but instead to spin-wait until stable states are
reached. This test will now fail (slowly) as
though via an infinite loop, if ever the expected
conditions are not met.
It should also run very fast, and succeed quickly
in the expected cases (and usually fail quickly
when there is a minor regression).
Bottom line: Hopefully flakiness is gone.
BUG=10607
r=wtc
Review URL: http://codereview.chromium.org/3462013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47058
TEST=none
Review URL: http://codereview.chromium.org/3415025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calls to ClosePlatformFile() ignore the return value, but there are
two calls that do use it:
1. webkit/glue/webfileutilities_impl.cc, closeFile() method: i talked
to jianli who changed that method most recently, and he said he
prefers the handle to be reset to base::kInvalidPlatformFileValue if
ClosePlatformFile() succeeded, so no change is needed to that code.
2. webkit/database/database_tracker.cc, CloseIncognitoFileHandle():
this code needs to be updated.
TEST=WebSQLDBs don't crash in incognito mode.
BUG=56237
Review URL: http://codereview.chromium.org/3387018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3444023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The rlz library was updated to include the right header from these string functions.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3506003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This was found by the Clang bot!
TEST=compiles
Review URL: http://codereview.chromium.org/3470015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The wrapper was using the size of the input string as the number of hash bytes
to compute, rather than the size of the output string (SHA256_LENGTH). Added a
test for this.
BUG=none
TEST=Sha256Test.Test1_String
Review URL: http://codereview.chromium.org/3492008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we do on Linux and Mac. This can be very helpful when
trying to debug flaky tests.
R=erikkay
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3435027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove switch --issue35198-logging .
BUG=56664
TEST=Install an extension on all platforms.
Review URL: http://codereview.chromium.org/3427019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_split.h
BUG=None
TEST=trybos
Review URL: http://codereview.chromium.org/3447008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
argument (instead of PlatformFile).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3380024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests are over 20% of the time taken by base_unittests.
I don't think making these sleeps shorter should affect their
reliability too much.
BUG=10611
Review URL: http://codereview.chromium.org/3474009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3496005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove logging.h and other headers where possible.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3461019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 60322.
TBR=dumi
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3439019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
related to FILE_WRITE_ATTRIBUTES on Windows.
BUG=none
TEST=FileUtilTest::TouchFile
Review URL: http://codereview.chromium.org/3404018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
high resolution clock is intentionally disabled on some systems (old AMDs).
If QueryPerformanceCounter doesn't work on this system, we shouldn't run the
test.
Second, however, if the time between two HighResNow() calls is *always* 0us,
then this test would fail. Due to speedstep technology with intentionally
underclocked QPC (at the windows level), this is quite possible.
BUG=42850
TEST=TimeTicks.SubMillisecondTimers
Review URL: http://codereview.chromium.org/3387011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=phajdan.jr,glider
Review URL: http://codereview.chromium.org/3413032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=./tools/valgrind/chrome_tests.sh -t base --gtest_filter="Sanity*" on Linux and Mac
Review URL: http://codereview.chromium.org/3470006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=PPAPI UI tests
BUG=none
Review URL: http://codereview.chromium.org/3386019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If a chrome test that uses a testserver were to crash, the testserver process ends up being orphaned, potentially affecting subsequent tests. This patch causes child processes of a test case to be killed along with the test case if it were to be abruptly terminated.
BUG=55808
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3423012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit API types.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3406008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3473006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To build, set the clang=1 gyp_define.
This patch is the culmination of many months of effort and many
patches. It contains the minimal changes to Chrome that
are Clang-specific.
With this, I can build the "chrome" target. Once this patch
is in, we can incrementally fix bits of Chrome and various
tests and remove the Clang-specific workarounds.
Review URL: http://codereview.chromium.org/522020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55725
TEST=ObserverListThreadSafeTest.RemoveMultipleObservers
Review URL: http://codereview.chromium.org/3381009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on a well-known port.
Before this CL:
Before fork()ing a child, the browser process creates a mach receive port with a random name. After the fork() but before exec(), the child uses mach ipc to transmit send rights to its task port. The child has access to the random name because it inherits it from the browser process. Unfortunately, some of the library functions involved in sending a mach message are not safe to call after fork().
After this CL:
Before forking the first child, the browser spins off a new thread that listens on a well-known port for mach ipc from any process. This well-known port is "com.google.Chrome.<browserpid>". When a child process starts up, it sends a mach message to its parent browser's well-known port. On the browser side, we listen for said message, extract the pid of the sending process, and ignore any messages from processes we did not personally fork(). This check is necessary because any arbitrary process on the system could send mach ipc to that port.
BUG=35374
TEST=Browser should still start up. The task manager should still show correct cpu/memory data. There should be no perf regressions.
TEST=Mac ui_tests and browser_tests should be less flaky.
Review URL: http://codereview.chromium.org/3443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin@chromium.org
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3390010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3402004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed a function that is no longer called.
BUG=None
TEST=Build works.
Review URL: http://codereview.chromium.org/3453006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes browser.h not depend on extension.h.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3399008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequest. This URLRequest, if valid, is deleted when the IO thread
is being shutdown by way of a DestructionObserver attached to the IO
thread. Prior to this patch this proves problematic as the LeakTracker
is run before DestructionObservers, which means we were errorenously
detecting a leak and causing random UI failures (and perhaps other
tests).
To fix this I've moved the LeakTracker to run after the IO thread
MessageLoop has been deleted (which means DestructionObservers have
been notified). Doing this triggered a DCHECK in
ChromeNetLog::AddEntry:
DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
Here's the full stack:
StackTrace::StackTrace() [0xf247c1]
logging::LogMessage::~LogMessage() [0xf3ef4f]
ChromeNetLog::AddEntry() [0x5c9639]
net::BoundNetLog::AddEntry() [0x147d8a3]
net::BoundNetLog::AddEvent() [0x147d92a]
net::internal::ClientSocketPoolBaseHelper::CancelRequest() [0x132d032]
net::ClientSocketPoolBase<>::CancelRequest() [0x134aabd]
net::TCPClientSocketPool::CancelRequest() [0x1348fdb]
net::ClientSocketHandle::ResetInternal() [0x13273b7]
net::ClientSocketHandle::Reset() [0x1327874]
net::ClientSocketHandle::~ClientSocketHandle() [0x1327895]
scoped_ptr<>::~scoped_ptr() [0x1304b97]
net::HttpStreamRequest::~HttpStreamRequest() [0x1300933]
base::RefCounted<>::Release() [0xa15b83]
scoped_refptr<>::operator=() [0x12f2da4]
net::HttpNetworkTransaction::~HttpNetworkTransaction() [0x12ee377]
scoped_ptr<>::~scoped_ptr() [0x12e2724]
net::HttpCache::Transaction::~Transaction() [0x12e10a6]
scoped_ptr<>::reset() [0x12d1f0b]
URLRequestHttpJob::DestroyTransaction() [0x142229e]
URLRequestHttpJob::Kill() [0x14252e5]
URLRequest::DoCancel() [0x137af1e]
URLRequest::Cancel() [0x137b081]
(anonymous namespace)::OCSPRequestSession::CancelURLRequest() [0x13142a7]
(anonymous namespace)::OCSPRequestSession::WillDestroyCurrentMessageLoop() [0x1314b30]
MessageLoop::~MessageLoop() [0xf421ab]
base::Thread::ThreadMain() [0xf71395]
ThreadFunc() [0xf54338]
start_thread [0x7ff66c6d83f7]
0x7ff669d5cbbd
This is still on the IO thread, but the DCHECK fails because at the
time the DestructionObservers are run Thread::message_loop() returns
NULL, which means the DCHECK fails. I've fixed this by changing the
DCHECK to pass if the current thread's message loop is NULL. I feel a
bit quesy about this as it seems a bit fragile (well, all this code is
fragile). I would be inclined to make Thread::message_loop() return
the MessageLoop until after the destructor has run, but this seems
equally risky. Let me know what you prefer.
BUG=52022
TEST=none
Review URL: http://codereview.chromium.org/3402006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54098
TEST=base_unittests
Review URL: http://codereview.chromium.org/3444003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
assertion fails.
TEST=none
BUG=55517
Review URL: http://codereview.chromium.org/3428003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Should fix Mac coverage bot compile errors.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3380005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3366011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=compiles
Review URL: http://codereview.chromium.org/3432002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a second attempt of this cl:
http://codereview.chromium.org/3195014/show
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/3347016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Makes MatchPreview owned by Browser rather than each TabContents.
. Makes MatchPreview dismiss when the omnibox closes.
. Supports the ability to send script to the page rather than
reloading on every keystroke.
. Supports receiving results from the page that drives the suggest
text in the omnbox.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3332022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=RunningOnValgrind() should be fixed on Windows
TBR=glider
Review URL: http://codereview.chromium.org/3437001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=55517
TBR=glider
Review URL: http://codereview.chromium.org/3400002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Port SymmetricKeyTest.ImportGeneratedKey and
SymmetricKeyTest.ImportDerivedKey to all platforms. On Mac,
the salt for PBKDF2 must be at least 8 bytes long.
R=tim
BUG=none
TEST=base_unittests --gtest_filter=SymmetricKeyTest.ImportDerivedKey
should pass on Windows.
Review URL: http://codereview.chromium.org/3361020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This function is not used when the tested #define isn't available.
TEST=compiles
Review URL: http://codereview.chromium.org/3290001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This temporary instrumentation has already yielded the intended data, so it is no longer necessary.
BUG=54307
Review URL: http://codereview.chromium.org/3337012
TBR=huanr@chromium.org
Review URL: http://codereview.chromium.org/3322020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This generalizes the existing pattern matching code to support UTF8 strings.
BUG=53158
TEST=string_util_unittests.cc
Review URL: http://codereview.chromium.org/3295018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=platform_file_unittest.cc
BUG=none
TBR=darin
Review URL: http://codereview.chromium.org/3354020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.
TEST=ui_tests in Release mode
BUG=49838
Review URL: http://codereview.chromium.org/2805100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
adding
the corresponding relays to file_util_proxy.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3303007
TBR=dumi@chromium.org
Review URL: http://codereview.chromium.org/3371011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the corresponding relays to file_util_proxy.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3303007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59007 0039d316-1c4b-4281-b951-d872f2087c98
|