summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
...
* Ensure existing user pinned chrome shortcuts have correct app id.xiyuan@chromium.org2010-01-133-5/+10
| | | | | | | | | | | On Win7, check if user has pinned chrome shortcuts and ensure they have correct app id. BUG=28104 TEST=On Win7, install chrome prior 4.0.266.0 and pin chrome shortcut (browser with default profile, browser with non-default profile, web apps etc). Then update to a version with this fix. After update, running chrome should not have duplicate icon spawned. Review URL: http://codereview.chromium.org/548008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36193 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: UI tweaks for task manager.thakis@chromium.org2010-01-138-38/+36
| | | | | | | | | | | | | | | | | | | | | | | Nib change: Reduce row height, make scrollbars smaller. Make text in task manager table slightly smaller. Show in decimal digit for %cpu. Show memory in KB/MB, not always in K. Change update frequency from 1s to 2s to match Activity Monitor's default. (all mac-only. ui team is fine with this.) Finally, turn taskman on. BUG=13156 TEST=Open task manager, look at it. Should look & feel similar to Activity Monitor. Review URL: http://codereview.chromium.org/536038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36096 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Remove some unneccesary IPC from fork_and_get_task.thakis@chromium.org2010-01-131-45/+0
| | | | | | | | | | | This was a left-over from the previous swap-bootstrap-port-based approach. BUG=13156 TEST=Open task manager. Should still work. Review URL: http://codereview.chromium.org/551004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36088 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the priority of background tabs more aggresively.davemoore@chromium.org2010-01-131-2/+6
| | | | | | | | | | This will continue to only affect users who have their nice rlimit set so that process priorities can be raised back to 0. That may be the default on later versions of Ubuntu. Review URL: http://codereview.chromium.org/523102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36074 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Unbreakpad.thakis@chromium.org2010-01-122-0/+8
| | | | | | | | | BUG=32100 TEST=no idea Review URL: http://codereview.chromium.org/548016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36047 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tree bustage temporarillyjar@chromium.org2010-01-121-2/+3
| | | | | | | | BUG=32070 tbr=nsylvain Review URL: http://codereview.chromium.org/542032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36018 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-125-2/+789
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also move mach_ipc_mac to base, where it's now used. Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , but uses a named connection instead. Do the IPC right after fork-time, so that the sandbox is not yet in effect. See the codereview comments for a benchmark that proves that this shouldn't be expensive, and for pros and cons for using a named connection vs temporarily switching out the bootstrap port. Works for worker processes too and seems more reliable in general. Measured perf impact in http://src.chromium.org/viewvc/chrome?view=rev&revision=35888 , it's negligible. BUG=13156 TEST=(requires that one enables the task manager in browser.cc) 1.) Open one tab that plays a youtube video 2.) Open a second and visit http://www.whatwg.org/demos/workers/primes/page.html 3.) Install e.g. the gmail checker extension 4.) Open the task manager It should report metrics for * one browser process * two renderer processes * one plugin process * one worker process * one extension process Check that %cpu etc more or less match what Activity Monitor displays if you filter for "Chromium". Also choose "Open all bookmarks" on the bookmarks bar with the task manager open and check that metrics for all tabs appear immediately. Review URL: http://codereview.chromium.org/549002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35977 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CommandLine::AppendLooseValue() to append the parameter to the ↵jschuh@chromium.org2010-01-111-0/+1
| | | | | | | | | | | loose_values_ vector. BUG=None. TEST=None. Review URL: http://codereview.chromium.org/536012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35970 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an error when calling ReplaceFile for files on a Windows file share.phajdan.jr@chromium.org2010-01-111-6/+13
| | | | | | | | | | | | Add debugging code to get more info about further issues I couldn't reproduce and fix yet. TEST=none BUG=19607 Review URL: http://codereview.chromium.org/541004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35934 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35907 - Fixes CommandLine::AppendLooseValue() to append the parameter ↵jschuh@chromium.org2010-01-111-1/+0
| | | | | | | | to the loose_values_ vector. TBR=jschuh@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35913 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CommandLine::AppendLooseValue() to append the parameter to the ↵jschuh@chromium.org2010-01-111-0/+1
| | | | | | loose_values_ vector. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35907 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35888 - Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-101-146/+0
| | | | | | | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proofofconcept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Next try: Submitting to get perf numbers, will revert. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35883 Review URL: http://codereview.chromium.org/549002 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/536009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35890 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-101-0/+146
| | | | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proof-of-concept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Next try: Submitting to get perf numbers, will revert. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35883 Review URL: http://codereview.chromium.org/549002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35888 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35883 - Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-101-143/+0
| | | | | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proofofconcept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Submitting to get perf numbers, will revert. Review URL: http://codereview.chromium.org/549002 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/544004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35884 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-101-0/+143
| | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proof-of-concept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Submitting to get perf numbers, will revert. Review URL: http://codereview.chromium.org/549002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35883 0039d316-1c4b-4281-b951-d872f2087c98
* official build and buildbots are now chromeos=1oshima@chromium.org2010-01-091-1/+1
| | | | | | | | | | | | valgrind bots are up (they're still red tho). I believe it's ready to check this in. BUG=None TEST=None Review URL: http://codereview.chromium.org/487003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35858 0039d316-1c4b-4281-b951-d872f2087c98
* linux: provide a hint to people with misconfigured shmevan@chromium.org2010-01-081-1/+6
| | | | | | | | BUG=24213 Review URL: http://codereview.chromium.org/539003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35838 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: reenable malloc overrides.agl@chromium.org2010-01-082-107/+60
| | | | | | | | | | | | | | | | | (These were disabled in r35804 and r35810.) This time we are using the __libc_* names to get at the real glibc functions rather than dlsym. This now means that code that calls __libc_* gets the raw functions, not 'safe' ones. Also, this sets the visibility correctly. Previously we were not overriding malloc calls made in shared libraries. BUG=31809 TEST=Covered by unittests. http://codereview.chromium.org/533001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35823 0039d316-1c4b-4281-b951-d872f2087c98
* Also disable tests for code removed in r35804.agl@chromium.org2010-01-082-0/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35810 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: disable malloc tricks to unbreak Ubuntu build.agl@chromium.org2010-01-081-0/+7
| | | | | | | | | BUG=31809 TEST=Run chromium-browser on Ubuntu. It should work. http://codereview.chromium.org/524075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35804 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and ↵pkasting@chromium.org2010-01-081-4/+9
| | | | | | | | | | EmptyGURL(), since the code in question can just use the default constructor. BUG=none TEST=none Review URL: http://codereview.chromium.org/517054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
* Allow using system libevent instead of the bundled one.phajdan.jr@chromium.org2010-01-071-0/+4
| | | | | | | | | | | Patch by Bernard Cafarelli <voyageur@gentoo.org> TEST=none BUG=22140 Review URL: http://codereview.chromium.org/524061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35711 0039d316-1c4b-4281-b951-d872f2087c98
* Make JoinString implementation match prototype.craig.schlenter@chromium.org2010-01-051-1/+1
| | | | | | | | | | This fixes the linux shared build. Error was: out/Release/lib.target/chrome/libbrowser.so: undefined reference to `JoinString(std::vector<std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> >, std::allocator<std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > > > const&, unsigned short)' Review URL: http://codereview.chromium.org/518037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35533 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement the cookie managerrsesek@chromium.org2010-01-051-0/+1
| | | | | | | | | | | | | This CL creates the basic cookie management interface, allowing users to view and delete cookies from Chromium. TODO: (1) Add the filtering by domain capability. (2) Localize the NIB. BUG=15360 TEST=Chromium-->Preferences-->Under the Hood-->Show Cookies. Also covered by unit tests. Review URL: http://codereview.chromium.org/523025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35512 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ContactInfo, the FormGroup that stores contact information.jhawkins@chromium.org2010-01-043-53/+197
| | | | | | | | BUG=none TEST=StringUtilTest.Tokenizer Review URL: http://codereview.chromium.org/502103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35475 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: stop zombie ps processes from being created.viettrungluu@chromium.org2010-01-042-10/+34
| | | | | | | | | | | | | | | This fixes two bugs: - the output buffer for the ps command being run could be too small (fix: buffer enlargened); and - if the output buffer was too small, waitpid() wouldn't be called (fix: always call waitpid(), obviously). BUG=31378 TEST=On a big, long-running Chrome/Chromium (with many processes, e.g., renderers), check that there are no zombie ps processes (with PPID the browser process); looking at about:memory may help speed up the creation of such zombies. Also, run the new test, ProcessUtilTest.GetAppOutputRestrictedNoZombies. Review URL: http://codereview.chromium.org/523033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35456 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the last remaining vsprops files (that are hooked in).bradnelson@google.com2010-01-041-2/+2
| | | | | | | | | | | | | Also pulling in a newer nacl version. Switching to use AdditionalOptions in list form. BUG=None TEST=None TBR=mmentovai Review URL: http://codereview.chromium.org/523027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35449 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use readlink() and prctl() in SetProcTitle() to fix "exe" showing in ↵mdm@chromium.org2010-01-032-3/+37
| | | | | | | | | | | process listings. BUG=29118 TEST=none Review URL: http://codereview.chromium.org/490028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35441 0039d316-1c4b-4281-b951-d872f2087c98
* Upload renderer histograms to browser after a page loadsjar@chromium.org2010-01-022-20/+2
| | | | | | | | | | | | | | | | | | | WARNING: We need to watch the perf charts when this lands to be sure that it doesn't cause a regression. Since there is no finalizer for a renderer, and some renderers are just terminated with no warning, the only way to get consistent page data is to send it to the browser after each page loads. That is the bulk of this change. I also fixed up a few nits relating to making this work in single process mode. BUG=16495 r=raman.tenneti Review URL: http://codereview.chromium.org/515072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35431 0039d316-1c4b-4281-b951-d872f2087c98
* If we can't read a unicode character, write the standard "unknown" (0xFFFD) ↵cevans@chromium.org2010-01-014-14/+12
| | | | | | | | | | | character. This will prevent security issues where the current behaviour can be used to strip characters out of a string after it has passed some validation. BUG=30798 TEST=utf_string_conversions_unittest.cc,utf_offset_string_conversions_unittest.cc,zip_unittest.cc Review URL: http://codereview.chromium.org/522029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35430 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid re-initializing object_trackerjar@chromium.org2009-12-312-3/+28
| | | | | | | | | | ...even if we're asked to do so in repetetive tests. BUG=31334 r=apavlov Review URL: http://codereview.chromium.org/515068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35415 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid calling vector resize() with excessive size parameter: fix broken ↵cevans@chromium.org2009-12-311-6/+13
| | | | | | | | | | | integer overflow checks, or remove resize() calls to simplify non-hot-path cases, or add stronger validations as appropriate. BUG=31364 TEST=NONE Review URL: http://codereview.chromium.org/519031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35414 0039d316-1c4b-4281-b951-d872f2087c98
* linux: reenable symbols in backtraces in debug buildsevan@chromium.org2009-12-311-9/+14
| | | | | | | | This is easy enough to fix, and would be occasionally helpful. Review URL: http://codereview.chromium.org/524015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35405 0039d316-1c4b-4281-b951-d872f2087c98
* Add NSTemporaryDirectory() to the list of ignored to catch all possible ↵thomasvl@chromium.org2009-12-301-6/+19
| | | | | | | | | | values. Also handle all the forms of the paths with links resolved. TEST=page cycles, browser_tests all get back to being fast. normal profiles still exclude the files listed in the first bug. BUG=25959,30002 Review URL: http://codereview.chromium.org/523026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35394 0039d316-1c4b-4281-b951-d872f2087c98
* Defense-in-depth: initialize some variables.cevans@chromium.org2009-12-301-0/+3
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/517025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35387 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] address perf regressions on botsthomasvl@chromium.org2009-12-301-0/+13
| | | | | | | | | | This isn't the prettiest, but it should get the perf back where we want it. If the file we're asked to exclude is in /var or /private, ignore it. The problem on the bots is the TimeMachine prefs plist is growing unbounded as we keep adding 4 files each run for temporary profiles. The load/modify/write gets slower with each addition. This quick/dirty check to avoid that. Since the original bug for the backup of this data is still open, I figure landing this is the right thing to do until that is fully addressed. BUG=25959,30002 TEST=page cycles, browser_tests all get back to being fast. normal profiles still exclude the files listed in the first bug. Review URL: http://codereview.chromium.org/523024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35382 0039d316-1c4b-4281-b951-d872f2087c98
* Provide a quick and dirty way to reset about:objects datajar@chromium.org2009-12-303-37/+279
| | | | | | | | | | | | | | | | | | | | | To make it easier to use the about:object profiling facility, I put in a quick/dirty way to reset all profile stats to 0 (as if there were no births, deaths, etc.). This code is only activated under debug builds (or if a developer inists in a private build). These stats don't impact semantics of the browser, so the hackish approach to clearing the data counts can't instigate a crash, and it makes it much easier to look at changes in the stats. While changing the code, I also added a lot of comments, and did a few minor cleanups items. I also officially added about:tasks as a replacement for about:objects, as this is really how the service is used in Chrome. r=mbelshe Review URL: http://codereview.chromium.org/100297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35372 0039d316-1c4b-4281-b951-d872f2087c98
* linux: reduce header interdependenciesevan@chromium.org2009-12-292-52/+0
| | | | | | | | | | | | By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify licenses on a bunch of files.evan@chromium.org2009-12-291-0/+4
| | | | | | | | | | | In this process, I also filed bugs on various projects we depend on that also have unclear licenses. BUG=28291 Review URL: http://codereview.chromium.org/521009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35323 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to base/ from a combination of FreeBSD and OpenBSD patches.evan@chromium.org2009-12-2929-68/+99
| | | | | | Review URL: http://codereview.chromium.org/495002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35321 0039d316-1c4b-4281-b951-d872f2087c98
* Typo spelling in comment corrected.jar@chromium.org2009-12-281-1/+1
| | | | | | | TBR=raman.tenneti Review URL: http://codereview.chromium.org/515042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35303 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac tree bustagejar@chromium.org2009-12-281-1/+0
| | | | | | | | | | | Remove overly aggressive DCHECK() which was tripping in HISTOGRAM_ENUMERATION on the mac. BUG=31206 TBR=ramana.tenneti Review URL: http://codereview.chromium.org/519006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35296 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup histogram classes mixing SetFlags into FactoryGet argumentsjar@chromium.org2009-12-284-448/+195
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Generic cleanup of histogram class, renaming *FactoryGet to FactoryGet, along with reformatting. The macros were cleaned up to use common sub-macros rather than repeating code as much. Removed ThreadSafeHistogram (and associated ASSET_HISTOGRAM macros) since this class was not getting used. I introduced UMA_HISTOGRAM_ENUMERATION to support the common use of LinearHistograms to count various enumerated values. I added a Flags argument to all the FactoryGet routines to help avoid needing to call SetFlags each time a new sample is Add()ed. This also simplifies the code. This will all help prepare for a "don't histogram at all" macro setting so that I can test the impact of the histogram macro calls on performance (since there are now so many active histograms). BUG=31206 r=raman.tenneti Review URL: http://codereview.chromium.org/515033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35295 0039d316-1c4b-4281-b951-d872f2087c98
* Add a change that was supposed to be part of the previous CL - see ↵gregoryd@google.com2009-12-221-1/+1
| | | | | | | | http://codereview.chromium.org/501127/show Review URL: http://codereview.chromium.org/507074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35182 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-221-2/+2
| | | | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35012 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35129 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Create a pid->task_t mapping in the browser process.thakis@chromium.org2009-12-212-7/+8
| | | | | | | | | | | Since nothing writes to this map in the browser atm, this does not have any visible effect. BUG=13156,25454 TEST=unittest Review URL: http://codereview.chromium.org/501138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35092 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35025 - Revert 34994, maybe it regressed startup perf Fix cpu/memory ↵viettrungluu@chromium.org2009-12-194-54/+177
| | | | | | | | | | | | | | | | | | | measurements on OS X. Right now, this only works for the current process; support for child processes will be added in a later CL. BUG=13156,25454 TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes. Review URL: http://codereview.chromium.org/500118 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/504068 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/505056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35043 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34994, maybe it regressed startup perf - Fix cpu/memory measurements ↵thakis@chromium.org2009-12-194-177/+54
| | | | | | | | | | | | | | | | on OS X. Right now, this only works for the current process; support for child processes will be added in a later CL. BUG=13156,25454 TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes. Review URL: http://codereview.chromium.org/500118 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/504068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35025 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Port browser action popup test to mac.kkania@chromium.org2009-12-192-0/+20
| | | | | | | | BUG=29710 TEST=none Review URL: http://codereview.chromium.org/506069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35020 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35012 - Rearrange build configurations make it clearer and allow ↵gregoryd@google.com2009-12-191-2/+2
| | | | | | | | | | | | | | better support for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/500149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 15:27:25 +0000