| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=
TBR=tfarina
Review URL: https://chromiumcodereview.appspot.com/16950027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically tracks the number of AddRef()/Release() pairs called for a
method expecting a "const scoped_refptr<T>&". base::Bind()'s impl
currently leads to too many AddRef()/Release() pairs.
BUG=251937
Review URL: https://chromiumcodereview.appspot.com/17514007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Makes the favicons (tab, bookmarks) look the same in the browser UI as they do in the renderer). This fixes a regression (probably by one of my CLs) since https://codereview.chromium.org/6117006
2) Make the favicons in the tab strip look the same after refreshing. The difference is due to the conversions PNG -> NSImage and PNG -> SkBitmap -> NSImage producing visually different NSImages. In particular, the result is different when the input PNG data has no colorspace information specified. Cocoa defaults to the device colorspace when decoding PNG data with no colorspace information. The generic RGB colorspace is used for converting from SkBitmap to NSImage.
BUG=242877
TEST=Manual, see bug
Review URL: https://chromiumcodereview.appspot.com/16370006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows using:
adb shell am start -a org.chromium.content_shell.action.ACTION_LOW_MEMORY \
-n org.chromium.content_shell_apk/.ContentShellActivity
to simulate memory pressure signals.
BUG=
Review URL: https://chromiumcodereview.appspot.com/17108012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will make it possible to write a TestLauncherDelegate for small
unit tests, for which the overhead of launching each one in its own
process would be too big.
This new interface makes it possible for the TestLauncherDelegate
to e.g. batch test runs, launch child process to run the batch,
and then call a series of callbacks for the tests in the batch.
BUG=236893
R=sky@chromium.org
Review URL: https://codereview.chromium.org/17551010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update all callers of InitLogging() to use LoggingSettings, only
setting fields that need a non-default value.
Turn LoggingDestination enum into a bit field and define add
LOG_DEFAULT and LOG_ALL constants.
Fix erroneous comment saying that the default was to not lock
the log file.
BUG=247594
TBR=brettw@chromium.org, cpu@chromium.org, gene@chromium.org, jam@chromium.org, rch@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, sky@chromium.org, tkent@chromium.org, yfriedman@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/16519003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Noticed by Stuart.
BUG=251957
R=mark@chromium.org
Review URL: https://codereview.chromium.org/16876006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Previously, it was not possible to produce unofficial builds without
DCHECKS and DLOGS.
Review URL: https://chromiumcodereview.appspot.com/17165003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
could be re-used outside of src/remoting.
BUG=241939
Review URL: https://chromiumcodereview.appspot.com/16780006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixes a comment in version.cc.
BUG=
Review URL: https://chromiumcodereview.appspot.com/17351015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236893
R=jam@chromium.org
Review URL: https://codereview.chromium.org/16820008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
And remove the forwarding file.
TBR=darin@chromium.org, eroman@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/16835007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
So it's next to scoped_cftyperef.h. Also move both scoped_nsobject and
ScopedCFTypeRef to namespace base.
BUG=251957
R=mark@chromium.org
Review URL: https://codereview.chromium.org/17500005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/17509002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android.
Because of the nested message pump implementation used by Android for
running layout tests, which uses a base::WaitableEvent to wait for new
messages, we need to allow waiting on the UI thread.
The ScopedAllowWaitForAndroidLayoutTest class has been implemented as
a member of the WebKitTestController, to ensure that the exception's
lifetime is tied to the layout test controller itself.
BUG=232044
R=jam@chromium.org, jochen@chromium.org
Review URL: https://codereview.chromium.org/17395002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=everything compiles OK
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/17390010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add a Java and native method for detecting if a device should be considered low end.
BUG=246134
Review URL: https://chromiumcodereview.appspot.com/17151011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/17094004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This seems to have been an old implicit assumption that use_glib==1 meant OS=="linux".
Review URL: https://chromiumcodereview.appspot.com/17076009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative revert: Suspected to break NavigationControllerTest.PurgeScreenshot.
> Make sure that the UI window created by base::MessagePumpForUI is destoyed on the same thread (Windows).
>
> Currently the window created base::MessagePumpForUI can be destroyed on a wrong thread. base::MessagePumpForUI is a ref-counted class so it can (and does) outlive the owning base::MessageLoop. As the result DestroyWindow() can be called on a wrong thread. This makes TSAN unhappy and it reports races deep unside user32.dll.
>
> Changes in this CL:
> - The message pump is now notified when the owning message loop is being destroyed. The notification is used to free all resources that hve to be released on the base::MessageLoop's thread.
> - MessagePumpForUI::ScheduleWork() synchronizes access to the message-only window handle to avoid posting messages to the window during or after its destruction.
>
> BUG=241939
>
> Review URL: https://chromiumcodereview.appspot.com/15709015
TBR=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/17143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on the same thread (Windows).
Currently the window created base::MessagePumpForUI can be destroyed on a wrong thread. base::MessagePumpForUI is a ref-counted class so it can (and does) outlive the owning base::MessageLoop. As the result DestroyWindow() can be called on a wrong thread. This makes TSAN unhappy and it reports races deep unside user32.dll.
Changes in this CL:
- The message pump is now notified when the owning message loop is being destroyed. The notification is used to free all resources that hve to be released on the base::MessageLoop's thread.
- MessagePumpForUI::ScheduleWork() synchronizes access to the message-only window handle to avoid posting messages to the window during or after its destruction.
BUG=241939
Review URL: https://chromiumcodereview.appspot.com/15709015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=compile works
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17385006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Media Galleries API Picasa Import will require reading some INI files. Rather than re-invent the wheel and duplicate code, we are moving the INI parser used by Firefox import into chrome/browser/common.
BUG=151701
Review URL: https://chromiumcodereview.appspot.com/16982004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
Reland of 206507.
Original review https://codereview.chromium.org/17078005/
TBR=sky
Review URL: https://codereview.chromium.org/16897006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
They will be used by content_shell to create the necessary fifos when running layout tests.
BUG=232044
TBR=darin,yfriedman
Review URL: https://chromiumcodereview.appspot.com/16599008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes from using cc::Thread to base::SingleThreadTaskRunner in
FrameRateController, DelayBasedTimeSource, and ResourceUpdateController.
Then all unit tests for these classes are switched from using
cc::FakeThread to base::TestSimpleTaskRunner.
This is a step toward deleting cc::Thread and moving to using
MessageLoopProxy directly in cc.
R=piman
BUG=251134
Review URL: https://chromiumcodereview.appspot.com/17362002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Following crrev.com/205796, the internal observer list is
ref-counted, the lazy instance must keep a ref to it.
BUG=246125
Review URL: https://chromiumcodereview.appspot.com/17242002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/17327004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When first_run_tabs are set through master_preferences, the sync promo
should be shown if not explicitly suppressed. When RestoreOnStartupURLs
is set through policy, the sync promo should never be shown. This is
long-standing behavior, as evidenced here:
http://crbug.com/125467#c26
That behavior recently regressed with the sync promo appearing even if
RestoreOnStartupURLs are set. The regression happened here:
https://chromiumcodereview.appspot.com/12638005
This CL fixes the regression by ensuring that when RestoreOnStartup=4 and
RestoreOnStartupURLs are set, the sync promo is not shown. The CL also
adds browser tests to protect against similar regressions in the future.
BUG=244849
TEST=Manual and new browser_tests
Review URL: https://chromiumcodereview.appspot.com/16141008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=170549
Review URL: https://chromiumcodereview.appspot.com/16703022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Example diagnostic:
In file included from ../../ppapi/tests/test_flash_file.cc:5:
../../ppapi/tests/test_flash_file.h:5:9: error: 'PAPPI_TESTS_TEST_FLASH_FILE_H_' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ppapi/tests/test_flash_file.h:6:9: note: 'PPAPI_TESTS_TEST_FLASH_FILE_H_' is defined here; did you mean 'PAPPI_TESTS_TEST_FLASH_FILE_H_'?
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
PAPPI_TESTS_TEST_FLASH_FILE_H_
1 error generated.
BUG=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/17321002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Change the default constructor to set is_null_ to true. This makes NullableString16 act more like a WebKit::WebString, which is really the reason NullableString16 exists at all.
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/17289005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
seeded with the number of seconds since Epoch. This was flaky when many directories were generated within a second, such as within a unit test.
This fix changes it to use base::rand_util.
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/15479003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NaCl code is not built with LSan runtime, so annotations should not be used.
R=glider@chromium.org, jar@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16845006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
debugging reported crash. This could be likely cause of the crash, which is not repro at this time on my VM with outlined steps.
To test fixed issue:
Open chrome in metro mode with a html page which shows notification like following.
var notification = webkitNotifications.createNotification("", "Notification Created", "Notification created", "");
notification.show();
BUG=240260
Test=As outlined in description above.
R=cpu,ananta,dewittj
Review URL: https://chromiumcodereview.appspot.com/16865017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we are calling postInvalidateOnAnimation on JB+, a better match on
ICS would be to call postInvalidate instead of the more synchronous
invalidate.
BUG=
Review URL: https://chromiumcodereview.appspot.com/17092002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move message_pump to base/message_loop.
>
> This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
>
> BUG=
> R=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/17078005
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/16897005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
BUG=
R=sky@chromium.org
Review URL: https://codereview.chromium.org/17078005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RefCountedDeleteOnMessageLoop is similar to RefCountedThreadSafe, but guarantees that
the referenced object will be deleted on the specified loop.
The functionality is similar to content::DeleteOnThread<> but does not depend on
BrowserThread.
The CL includes an example use of the class.
BUG=248049
TBR=stuartmorgan, joth
Review URL: https://chromiumcodereview.appspot.com/16938006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds explicit namespace to a bunch of places.
BUG=
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16797003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trivial patch changing "generate enum" to "generate enum values" in comments
justifying the lack of include guards in xmacro value lists.
NOTRY=true
TBR=yfriedman,atwilson,gavinp
Review URL: https://chromiumcodereview.appspot.com/16147015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110610
TBR=darin
Review URL: https://chromiumcodereview.appspot.com/16998003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Keep a forwarding header to avoid updating all callers.
BUG=
TBR=avi
Review URL: https://chromiumcodereview.appspot.com/15682017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If building with LeakSanitizer, define leak annotations appropriately.
http://clang.llvm.org/docs/LeakSanitizer.html
R=glider@chromium.org,jar@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15652009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the base/ directory.
BUG=173286
Review URL: https://chromiumcodereview.appspot.com/16950008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows observers to call code that uses TRACE_EVENT macros.
BUG=none, noticed while developing memory tracing patch
TEST=Added to base_unittests TraceEventTestFixture
Review URL: https://chromiumcodereview.appspot.com/16829002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=no change
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/16415016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add unit tests for the following functions in base:
StringToUint
StringToUint64
StringToSizeT
Review URL: https://chromiumcodereview.appspot.com/15521004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
After this, android_clang_dbg (tree-closer) will be switched to use components.
BUG=247855
Review URL: https://chromiumcodereview.appspot.com/15942017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=none
Review URL: https://codereview.chromium.org/15663007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205819 0039d316-1c4b-4281-b951-d872f2087c98
|