| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
| |
This change prevents compiling cpu_unittest on 32-bit GCC since some builders does not compile with SSE support.
TBR=jiesun
BUG=none
TEST=fix build.
Review URL: http://codereview.chromium.org/6581032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change prevents compiling cpu_unittest on 32-bit GCC since some builders does not compile with SSE support.
TBR=jiesun
BUG=none
TEST=fix build.
Review URL: http://codereview.chromium.org/6578017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just adds a unit test "CPU.RunExtendedInstructions" to base_unittests, which runs extended instructions for each CPU member function.
BUG=none
TEST=CPU.RunExtendedInstructions
Review URL: http://codereview.chromium.org/6548003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adjust the expected result for the display name of es-419. It does not have
'Carribean Islands' any more in the English display name. Also, swap
two parameters of EXPECTED_EQ so that the 1st param is 'expected' and
the 2nd is 'actual' in two tests in l10n_util_unittest.cc
In addition, change icu_string_conversions.cc to fix the failure
of ICUStringConversionsTest.ConvertCodepageUTF8.
The test uses WideToCodepage that calls u_strFromWCS. Where
U_WCHAR_IS_UTF32 is defined, it calls u_strFromUTF32. On Mac,
it's not defined because neither __STDC_ISO_10646__ nor _UCS4_ is defined.
As a result, wcstombs is called, which doesn't work as we want it to.
There are two ways to fix this:
- Directly call u_strFromUTF32 on Mac/Linux. What this CL does.
- Manually define U_WCHAR_IS_UTF32 in icu's pmac.h, which is done
in http://codereview.chromium.org/6578003
We do both to be block wcs*mbs/mbs*wcs from being called in other parts
of ICU when U_WCHAR_IS_UTF32 is not defined.
BUG=61514
TEST=Build goes fine and tests pass.
Review URL: http://codereview.chromium.org/6532030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
histogram that are larger 1G. Added CHECK's to catch bucket_count_
is not corrupted before accessing ranges_ vector.
BUG=73452
TEST=none. histogram unit tests are enough.
Review URL: http://codereview.chromium.org/6542034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6574005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also adds error logging to the various places we close file descriptors, to help diagnosing future similar issues.
BUG=none
TEST=Pepper Flash + youtube in oop with --enable-accelerated-plugins
Review URL: http://codereview.chromium.org/6549037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
They're printed to stderr, and the dialogs are often too high to fit on a (30'') screen.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6482013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the setting of the Zone Identifier to not include an unnecessary trailing null byte, modifies the test to check for any of a range of options known to be acceptable to Windows, and makes explicit the restriction the utility test function works under.
BUG=20809
TEST=Test run on windows and successful try bot run (with test enabled).
Review URL: http://codereview.chromium.org/6541003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=73740
Review URL: http://codereview.chromium.org/6549019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ViewHostMsg_FrameNavigate.
This will be used to run pre-classification checks for client-side phishing
detection, and will also enable the socket address to be exposed via the
webRequest extension API. This is adapted from the original patch by pmarks
on http://codereview.chromium.org/6369003/ .
BUG=51663
TEST=added socket address checks to various unittests
Review URL: http://codereview.chromium.org/6488010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved all stuff related to GetOwnershipStatus from user_cros_settings.cc where it was irrelevant to OwnershipService.
Prefetch and cache ownership status in order not to block on UI thread.
BUG=chromium:70097
TEST=Manual
Review URL: http://codereview.chromium.org/6538057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for these tests.
TEST=DrM bot shouldn't be affected after landing this. Before DrM r175 it would crash
BUG=http://code.google.com/p/drmemory/issues/detail?id=51
TBR=bruening
Review URL: http://codereview.chromium.org/6538092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from other threads.
BUG=73385
TEST=PrefMemberTest.MoveToThread
Review URL: http://codereview.chromium.org/6524041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Use GetFunctionPointer/GetProcAddress to avoid XP link and run errors. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring.
BUG=70824
TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75405
Review URL: http://codereview.chromium.org/6462024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In preparation for attempting to support __stdcall, __fastcall, etc., break
apart the templates so that instead of having one set of InvokerNs per type
of function pointer, only have one per syntactic method of invocation.
This lets the number of template specializations scale better. Previously,
for each type of function pointer, we needed sum(1...arity) InvokerN
specializations. There were 3 types (function, method, const method).
The Windows calling conventions would have added another 2.
in this method, we have 2 sets of InvokerN templates, and 1 set of
FunctionTraits templates for each type. We only need (arity) number of
FunctionTraits templates, so this is a net win. For our 6-arity system,
it should go from
5 types * (1+2+3+4+5+6) InvokerNs = 105 specializations
to
5 types * 6 FunctionTraits + 2 calling_syntaxes * (1+2+3+4+5+6) InvokerNs = 72 specializations
This puts a bit more work on the compiler, but...hey, better it than the reader of the code.
BUG=35223
TEST=none
Review URL: http://codereview.chromium.org/6538045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
XFlush() the XTest calls.
BUG=none
TEST=Connect to a host and try moving the mouse and typing. Both inputs should be reflected correctly.
Review URL: http://codereview.chromium.org/6489031
Patch from Jamie Walch <jamiewalch@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
callback_internal.h
We can re-inline later if it starts being an issue.
BUG=none
TEST=unit-tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75443
Review URL: http://codereview.chromium.org/6542026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
callback_internal.h"
This reverts commit r75443.
TBR=akalin
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
callback_internal.h
We can re-inline later if it starts being an issue.
BUG=none
TEST=unit-tests
Review URL: http://codereview.chromium.org/6542026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser_main startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring.
BUG=70824
TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments.
Review URL: http://codereview.chromium.org/6462024
TBR=msw@chromium.org
Review URL: http://codereview.chromium.org/6538059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring.
BUG=70824
TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments.
Review URL: http://codereview.chromium.org/6462024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- use ScopedTempDir in work items that need backup space for rollback
- all work items that need backup space take a parent dir in which they create temp dirs
- use ScopedTempDir in a few other places
- renamed some parameters in certain functions so that the same name is used everywhere
While I was at it, I couldn't help but replace Append(UTF8ToWide(version.GetString())) with the more pleasing AppendASCII(version.GetString())
BUG=70368
TEST=existing tests in installer_util_unittests cover the changes
Review URL: http://codereview.chromium.org/6538025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since Callback<> is essentially a smartpointer, some introspective APIs are
required for sensible usage.
BUG=35223
TEST=new unittests
Review URL: http://codereview.chromium.org/6507029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the client-side phishing detection classifies a page as phishing it will
send back a ping to Google to verify whether or not the page is really phishing.
If the server also classifies the site as phishing we may show a phishing
interstitial if it is enabled.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6014003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
priority.
BUG=72007
TEST=base_unittests --gtest_filter=MessageLoopTest.RecursiveDenial3
Review URL: http://codereview.chromium.org/6507017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that if you nest a template inside the initializer list of another template, the namelookup in windows gets all funky. In this case, it couldn't tell that the found name was a function.
Luckily, we could just move the template parameters one level deeper.
BUG=none
TEST=unittests & trybots.
Review URL: http://codereview.chromium.org/6537001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybot
Review URL: http://codereview.chromium.org/6526005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=8517
Review URL: http://codereview.chromium.org/6482024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Redo "Add extra heap-allocation to refcounting. For perf test only."
- Another intentional leak introduced by r74850
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6484047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71130
Review URL: http://codereview.chromium.org/6523009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Clang try-bot passes.
Review URL: http://codereview.chromium.org/6523014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
internal callback code.
This callback system allows for creation of functors for normal functions, methods, and const methods. It is a superset of the functionality of NewRunnableMethod, NewRunnableFunction, NewCallback, and CreateFunctor.
We support partial binding of function arguments, and also specification of refcounting semantics by wrapping a target object in a wrapper object.
BUG=35223
TEST=none
Review URL: http://codereview.chromium.org/6109007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Leaving it in tree for longer perf testing.
Original review http://codereview.chromium.org/6484024/
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6517022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=7562
Review URL: http://codereview.chromium.org/6482025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=1647
Review URL: http://codereview.chromium.org/6469028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Revert after one build."
This reverts commit r74764.
TBR=willchan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
after one build.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6484024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not handling correctly caused a crash. Added unit tests to cover those cases.
BUG=71953
TEST=covered by installer util unit tests
Review URL: http://codereview.chromium.org/6485026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove hacky code to increase timeout for specific tests.
Instead, allow to increase test termination timeout
via SLOW_ prefix (should be used as last resort).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6410059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes an error clang shows with -Woverloaded-virtual.
BUG=72575
TEST=none
Review URL: http://codereview.chromium.org/6487004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=13412
Review URL: http://codereview.chromium.org/6483011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=14347
Review URL: http://codereview.chromium.org/6476028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on full dom tracing, I need larger names and more of them. Increase
the counter limit and the size per name.
This only has effect when the user is using --enable-stats-table
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6474008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Mac Foundation utility for fetching a resource from the MainAppBundle.
- Bringing in newer ICU dep that has optional support for using the ICU data
file.
- If Mac is built using a ICU data file, directly map in the data so it will
work even in a sandboxed process.
**The build does not use this data file support at this time.**
This might help the Mac bots as it means each unittest that depends on base
will be ~10meg smaller, helping link and also helping with the copy of bits
from the builder to the tester.
If Mac ever support a Universal binary (32bit and 64bit) it will also probably
want to use this to avoid carrying two copies of the ICU data.
Review URL: http://codereview.chromium.org/6479021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:10876,chromium-os:10924
TEST=login (w/auto restore) with a large number of tabs. Verify that system is still responsive.
Review URL: http://codereview.chromium.org/6459003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6312195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67929
TEST=BUILD
Review URL: http://codereview.chromium.org/6312157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using string* directly works.
Made LogMessage delete any passed in string* after it uses it.
Removed suppressions for fixed memory leak.
BUG=57683
TEST=Existing unit tests
Review URL: http://codereview.chromium.org/6413032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6246155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74065 0039d316-1c4b-4281-b951-d872f2087c98
|