summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* The code to validate whether plugin dlls are 32 bit failed for some dll's as ↵ananta@chromium.org2011-03-101-4/+2
| | | | | | | | | | | | | | | | | | | the attempt to create a memory mapped section with the size of the file fails with the section too large error. As per msdn documentation we can safely pass in 0 for the file size for CreateFileMapping and MapViewOfFile which indicates that the whole file is being mapped. This caused some plugin dlls like acrobat reader 9 to not load in chrome. Fixes bug http://code.google.com/p/chromium/issues/detail?id=75351 BUG=75351 TEST=manually as described in the bug. Review URL: http://codereview.chromium.org/6661010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77575 0039d316-1c4b-4281-b951-d872f2087c98
* FilePath: remove .ToWStringHack()evan@chromium.org2011-03-102-9/+2
| | | | | | | | | | | | I introduced this in 2008, thinking it'd be a temporary thing. It has taken a very long time to undo the damage, but it's done now. BUG=69467 Review URL: http://codereview.chromium.org/6659018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77565 0039d316-1c4b-4281-b951-d872f2087c98
* Ubuntu: Detect "xubuntu" as DESKTOP_SESSION.erg@google.com2011-03-101-1/+2
| | | | | | | | | BUG=none TEST=On xubuntu lucid, actually detect that we're running xfce. Review URL: http://codereview.chromium.org/6612056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77561 0039d316-1c4b-4281-b951-d872f2087c98
* Remove temporary testing junk accidentally included in last commit.mark@chromium.org2011-03-091-3/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77531 0039d316-1c4b-4281-b951-d872f2087c98
* Replace LSUIElement with LSBackgroundOnly.mark@chromium.org2011-03-091-2/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6656007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77530 0039d316-1c4b-4281-b951-d872f2087c98
* This change enables ExtensionApiTest.WebSocket on Mac again.toyoshim@chromium.org2011-03-091-0/+17
| | | | | | | | BUG=56596 TEST=none Review URL: http://codereview.chromium.org/6611007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77387 0039d316-1c4b-4281-b951-d872f2087c98
* Add/improve a bunch of commentsjar@chromium.org2011-03-082-6/+5
| | | | | | | | | | | Also remove mention of about:tasks in release build, where we don't generate any data for that about page. R=eroman Review URL: http://codereview.chromium.org/6626064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77323 0039d316-1c4b-4281-b951-d872f2087c98
* Support mixed allocation in browser vs subprocessesjar@chromium.org2011-03-083-18/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [This is a re-landing of CL 6623059, which broke the shared library build on windows in revision 77207. An ifdef has been added to avoid the unresolved variable when allocator_shim.cc is never even compiled] Continue to support selection of a browser allocator selection via the environment variable CHROME_ALLOCATOR, and also add CHROME_ALLOCATOR_2 that can select the allocator to use in subprocesses, such as a renderer. Temporarilly set the browser default to the default windows heap allocator, and the subprocess allocator to TCMalloc to help detect memory corruption in a cannary for a few days. This may illuminate some flakiness in the tree, as double frees (hidden by races) may cause crashes. Add minor cleanup (removing reserved word "override" etc.). BUG=74901 TBR=mbelshe Review URL: http://codereview.chromium.org/6623072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77245 0039d316-1c4b-4281-b951-d872f2087c98
* Force sync integration try jobs on patches that touch sync dependenciesrsimha@chromium.org2011-03-081-0/+13
| | | | | | | | | | | | | | | | | Chrome sync is dependent on other areas of chrome, and patches committed to these areas could potentially break sync. In the past, we have seen sync integration test failures caused by patches to net, jingle and base. This patch adds a PRESUBMIT.py file to each of these directories, that will result the sync integration tests being run on any code that touches these directories as part of their try runs. BUG=70311 TEST=modify something under base, net or jingle and do a "git try" or "gcl try" Review URL: http://codereview.chromium.org/6624086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77242 0039d316-1c4b-4281-b951-d872f2087c98
* IDMap derives from NonThreadSafe.cbentzel@chromium.org2011-03-081-2/+22
| | | | | | | | | | | During a code review I noticed that RenderViewHost::FromID was being called from the IO thread, but there were no automated assertions that fired. BUG=None TEST=DCHECK fires when I add bad code. Otherwise Chrome works without crashing in Debug build. Review URL: http://codereview.chromium.org/6591108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77232 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77207 - Support mixed allocation in browser vs subprocessesjar@chromium.org2011-03-073-78/+18
| | | | | | | | | | | | | | | | | | | | | | | | | Continue to support selection of a browser allocator selection via the environment variable CHROME_ALLOCATOR, and also add CHROME_ALLOCATOR_2 that can select the allocator to use in subprocesses, such as a renderer. Temporarilly set the browser default to the default windows heap allocator, and the subprocess allocator to TCMalloc to help detect memory corruption in a cannary for a few days. Add minor cleanup (removing reserved word "override" etc.). r=mbelshe bug=74901 Review URL: http://codereview.chromium.org/6623059 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6623069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77208 0039d316-1c4b-4281-b951-d872f2087c98
* Support mixed allocation in browser vs subprocessesjar@chromium.org2011-03-073-18/+78
| | | | | | | | | | | | | | | | | | | | | | Continue to support selection of a browser allocator selection via the environment variable CHROME_ALLOCATOR, and also add CHROME_ALLOCATOR_2 that can select the allocator to use in subprocesses, such as a renderer. Temporarilly set the browser default to the default windows heap allocator, and the subprocess allocator to TCMalloc to help detect memory corruption in a cannary for a few days. Add minor cleanup (removing reserved word "override" etc.). r=mbelshe bug=74901 Review URL: http://codereview.chromium.org/6623059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77207 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77111 - Test performance of default allocator in browser processjar@chromium.org2011-03-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This is a test, and will be reverted as soon as the build starts. We just want to see what the perf bots have to say. This CL changes the default allocator to be the Windows Allocator (rather than TCMalloc), but then overrides that default via the environment variable control *during* the running of the browser_main. The result is that the browser process will use the Windows Allocator, but all sub-processes, such as renderers, will use TCMalloc. TBR=cpu BUG=74901 Review URL: http://codereview.chromium.org/6624050 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6627045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77116 0039d316-1c4b-4281-b951-d872f2087c98
* Test performance of default allocator in browser processjar@chromium.org2011-03-071-1/+1
| | | | | | | | | | | | | | | | | | | | | This is a test, and will be reverted as soon as the build starts. We just want to see what the perf bots have to say. This CL changes the default allocator to be the Windows Allocator (rather than TCMalloc), but then overrides that default via the environment variable control *during* the running of the browser_main. The result is that the browser process will use the Windows Allocator, but all sub-processes, such as renderers, will use TCMalloc. TBR=cpu BUG=74901 Review URL: http://codereview.chromium.org/6624050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77111 0039d316-1c4b-4281-b951-d872f2087c98
* Lower logging for expected errors in process_util_mac.mmsail@chromium.org2011-03-062-2/+23
| | | | | | | | BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77082 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77066 - Test impact of using default windows allocatorjar@chromium.org2011-03-061-1/+1
| | | | | | | | | | | | | | | | | | | I'll revert this as soon as the builds kick off. I just want to look at perf impact. I'll ceate a fancier CL that uses different allocators for render vs browser, but I wanted an overall baseline for transitioning completely from TCMalloc to the default allocator on Windows. TBR=cpu Review URL: http://codereview.chromium.org/6635004 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6623041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77067 0039d316-1c4b-4281-b951-d872f2087c98
* Test impact of using default windows allocatorjar@chromium.org2011-03-061-1/+1
| | | | | | | | | | | | | | | | I'll revert this as soon as the builds kick off. I just want to look at perf impact. I'll ceate a fancier CL that uses different allocators for render vs browser, but I wanted an overall baseline for transitioning completely from TCMalloc to the default allocator on Windows. TBR=cpu Review URL: http://codereview.chromium.org/6635004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77066 0039d316-1c4b-4281-b951-d872f2087c98
* Reland code to detect corruption of histogram rangesjar@chromium.org2011-03-053-67/+180
| | | | | | | | | | | | | | | | | | | | | | | | | | | This code was reverted because it caused, or exposed flakiness in sync unit test code (mostly on the Mac). We need to monitor that closely as we re-land. See the reviews and history in CLs: http://codereview.chromium.org/6577013 and http://codereview.chromium.org/6591052 This code generates CRC checksums for the histogram bucket-range vectors, and guarantees they remain intact when the histogram data is about to be uploaded to UMA. If the data is corrupted, then we will fail on a CHECK(). r=mbelshe,rvargas bug=73939 Review URL: http://codereview.chromium.org/6627011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77033 0039d316-1c4b-4281-b951-d872f2087c98
* Change other usages of .size() to .empty() when applicable.erg@google.com2011-03-044-7/+7
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6609008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76962 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetWindowsArchitecture() to windows_version.h.pkasting@chromium.org2011-03-044-25/+25
| | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6624025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76947 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function to get the processor architecture. I will be using this in ↵pkasting@chromium.org2011-03-043-5/+30
| | | | | | | | | | | | the user agent construction code. Also cleans up a few nearby things. BUG=none TEST=none Review URL: http://codereview.chromium.org/6632002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76945 0039d316-1c4b-4281-b951-d872f2087c98
* While enumerating plugins under the MozillaPlugins registry key, we should ↵ananta@chromium.org2011-03-042-2/+36
| | | | | | | | | | | | | | | | | | ignore 64 bit plugins. We validate whether a plugin is a 32 bit dll by reading its PE image. This fixes bug http://code.google.com/p/chromium/issues/detail?id=73032 Added support for the win32 version of the MemoryMappedFile helper class in base to map a file as an image section. BUG=73032 TEST=As described in the bug at this point. Review URL: http://codereview.chromium.org/6611028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76934 0039d316-1c4b-4281-b951-d872f2087c98
* Create a "GetWOW64Status()" utility function and make the rest of the ↵pkasting@chromium.org2011-03-042-2/+39
| | | | | | | | | | codebase call it. BUG=none TEST=none Review URL: http://codereview.chromium.org/6610029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76854 0039d316-1c4b-4281-b951-d872f2087c98
* Modify ThreadChecker and NonThreadSafe so that theirjoi@chromium.org2011-03-0310-160/+256
| | | | | | | | | | | | | | | functionality is available in release builds if explicitly requested by using their Impl types. The default usage remains that they do nothing in release mode. Also, update unit tests to run in release mode, verifying that the release versions of NonThreadSafe and ThreadChecker do nothing in release builds. BUG=none TEST=base unit tests Review URL: http://codereview.chromium.org/6599004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76833 0039d316-1c4b-4281-b951-d872f2087c98
* Kill CleanUpAfterMessageLoopDestruction.willchan@chromium.org2011-03-033-12/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6602047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76800 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: allow converting FilePath to wstring in testsevan@chromium.org2011-03-033-0/+16
| | | | | | | | | | | | Many of our tests want to use Unicode literal strings with the L"foobar" syntax. Allow us to test FilePaths against these strings. BUG=69467 Review URL: http://codereview.chromium.org/6606025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76763 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up CF To NS Casts and make them slightly saferdmaclach@chromium.org2011-03-032-40/+131
| | | | | | | | | | | | Also adds streaming for CFStringRefs and CFErrorRefs making it easier to add them to LOG() type statements. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/6594096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76714 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76239 - Crash when we notice a corruption of the histogram range-vectorrsimha@chromium.org2011-03-033-170/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reason for revert: This patch might have resulted in some flakiness in the sync bots on the chromium waterfall. The range vector is calculated once when a histogram is constructed, and should never change over the lifetime of the histogram. When it does change, it means that memory is being overwritten. We now crash (via CHECK) when there is any detected corruption of the range vector. This CL uses a more robust check-sum algorithm to detect corruption of the vector. The previous algorithm just did a sum, and was too easilly tricked by small (offsetting) changes in several ranges. Hopefully, this CRC-32 implementation will not be so easilly fooled. I had to refactor the class to ensure that each histogram was completely constructed before I registered it. The old code could sometimes register a base class (tradtional Histogram, with exponential bucket spread) and then run the derived constructor (such as when creating a LinearHistogram, with a second construction of the ranges and checksum). I now carefully avoid generating the checksum until fully constructing the instance, and then I run InitializeBuckets only once on the instance before registering it. bug=73939,74467 r=mbelshe Review URL: http://codereview.chromium.org/6577013 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6611001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76667 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76345 - Small cleanup for previous histogram checkinrsimha@chromium.org2011-03-022-17/+14
| | | | | | | | | | | | | | | | | | | | | Reason for revert: This patch might have resulted in some flakiness in the sync bots on the chromium waterfall. CL http://codereview.chromium.org/6577013/ had a few changes suggested that were not incorporated. This CL has those name changes etc. r=rvargas Review URL: http://codereview.chromium.org/6591052 BUG=74467 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6591129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76662 0039d316-1c4b-4281-b951-d872f2087c98
* touch: more fixes in the message pump.sadrul@chromium.org2011-03-021-5/+18
| | | | | | | | | | | | | | | | Remove the signal handler when the message-pump terminates. This wouldn't normally be necessary, but it can happen that the message-pump is terminated, and then additional GTK+ operations happen (e.g. in unit_tests). Also check for non-null dispatcher before dispatching events. This can happen for the first-run dialog, and also in the unit_tests. BUG=none TEST=unit_tests Review URL: http://codereview.chromium.org/6596094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76643 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up mac test client and simple host for remoting.dmaclach@chromium.org2011-03-021-0/+7
| | | | | | | | | | | | | Remoting's test client and simple host weren't initializing the NSApplication correctly which is required for MessageLoops to work on the Mac. These are just test apps that we use, so I felt it was ok to bring in code from base/test. Also added a check to message_pump_mac.mm to verify that NSApp is initialized before we attempt to use it. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/6461023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76624 0039d316-1c4b-4281-b951-d872f2087c98
* Until we have sparse histograms, to track error codes, we are usingrtenneti@chromium.org2011-03-022-2/+2
| | | | | | | | | | | | | UMA_HISTOGRAM_ENUMERATION and specify 16000 as the bucket size. Bumped up kBucketCount_MAX to 2**16. BUG=74618 TEST=We need to test MemoryMappedFile on windows in the browser to send histogram data for MemoryMappedFile.CreateFileMapping. R=jar Review URL: http://codereview.chromium.org/6592087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76514 0039d316-1c4b-4281-b951-d872f2087c98
* Pure pedantry: Replace all ".size() == 0" with ".empty()".erg@google.com2011-03-027-7/+7
| | | | | | | | | BUG=carnitas TEST=compiles; existing unit tests. Review URL: http://codereview.chromium.org/6602049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76467 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix unit_tests crash.sadrul@chromium.org2011-03-011-0/+5
| | | | | | | | | | | Setup XInput2 events only for the regular windows (and not for temporary ones). This was causing unit_tests to crash. BUG=unit_tests crashes for touch TEST=unit_tests Review URL: http://codereview.chromium.org/6602050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76461 0039d316-1c4b-4281-b951-d872f2087c98
* Commneted out ShutdownSingleThreadedCleanup in debug builds tortenneti@google.com2011-03-011-7/+4
| | | | | | | | | | | | suppress the TSan complaints. Enabled NonSearchToSearchDoesntSupportInstant in intractive_ui_tests for Linux. BUG=70810,61179 TEST=please test interactive_ui_tests. Review URL: http://codereview.chromium.org/6546020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76430 0039d316-1c4b-4281-b951-d872f2087c98
* FilePath: add a convertor to ASCIIevan@chromium.org2011-03-012-0/+17
| | | | | | | | | This is needed for cases where we need to work with known-ASCII filenames, like locale paths. Review URL: http://codereview.chromium.org/6597075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76426 0039d316-1c4b-4281-b951-d872f2087c98
* Out-of-line default Commandline ctor and provide dtor.msw@chromium.org2011-03-012-2/+10
| | | | | | | | | BUG=73195 TEST=none Review URL: http://codereview.chromium.org/6588087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76419 0039d316-1c4b-4281-b951-d872f2087c98
* Small cleanup for previous histogram checkinjar@chromium.org2011-03-012-14/+17
| | | | | | | | | | | | | | CL http://codereview.chromium.org/6577013/ had a few changes suggested that were not incorporated. This CL has those name changes etc. r=rvargas Review URL: http://codereview.chromium.org/6591052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76345 0039d316-1c4b-4281-b951-d872f2087c98
* More DCHECK() updates. A mixture of _EQ and _GE.mhm@chromium.org2011-03-0115-28/+28
| | | | | | | | Bug=58409 Review URL: http://codereview.chromium.org/6469070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76343 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize CommandLine code.msw@chromium.org2011-03-012-344/+297
| | | | | | | | | | | | The majority of these changes are purely moving code. Conducted some minor (and hopefully straightforward) refactoring. BUG=73195 TEST=none Review URL: http://codereview.chromium.org/6596020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76339 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilation bug on ARMjar@chromium.org2011-02-282-3/+3
| | | | | | | | | | Avoid re-use of method name with different signature when creating custom histograms TBR=mbelshe Review URL: http://codereview.chromium.org/6592043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76244 0039d316-1c4b-4281-b951-d872f2087c98
* Crash when we notice a corruption of the histogram range-vectorjar@chromium.org2011-02-283-60/+170
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The range vector is calculated once when a histogram is constructed, and should never change over the lifetime of the histogram. When it does change, it means that memory is being overwritten. We now crash (via CHECK) when there is any detected corruption of the range vector. This CL uses a more robust check-sum algorithm to detect corruption of the vector. The previous algorithm just did a sum, and was too easilly tricked by small (offsetting) changes in several ranges. Hopefully, this CRC-32 implementation will not be so easilly fooled. I had to refactor the class to ensure that each histogram was completely constructed before I registered it. The old code could sometimes register a base class (tradtional Histogram, with exponential bucket spread) and then run the derived constructor (such as when creating a LinearHistogram, with a second construction of the ranges and checksum). I now carefully avoid generating the checksum until fully constructing the instance, and then I run InitializeBuckets only once on the instance before registering it. bug=73939 r=mbelshe Review URL: http://codereview.chromium.org/6577013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76239 0039d316-1c4b-4281-b951-d872f2087c98
* Callback support for __fastcall and __stdcall functions.ajwong@chromium.org2011-02-276-24/+236
| | | | | | | | | | | | | | Create FunctionTraits specializations that can unwrap function pointers that are delcared with __fastcall and __stdcall on windows. Only include these in the Windows build. BUG=35223 TEST=new unittests Review URL: http://codereview.chromium.org/6561004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76174 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the command line from ServiceProcessState::AddToAutoRun() and had ↵sanjeevr@chromium.org2011-02-252-0/+12
| | | | | | | | | | | the class calculate its own command line. Wired up Linux autorun code and added unit tests. BUG=None TEST=Test service process autorun when enabling the cloud print proxy, unit-tests. Review URL: http://codereview.chromium.org/6591002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76077 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style mistakes in r75477.ajwong@chromium.org2011-02-252-10/+17
| | | | | | | | | | | Associated review at: http://codereview.chromium.org/6489031/ BUG=none TEST=none Review URL: http://codereview.chromium.org/6532102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76074 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fixes in FieldTrial.cbentzel@chromium.org2011-02-252-2/+4
| | | | | | | | | | | | | | - Add a DCHECK - Comment what the return value is on AddGroup - const a member - Typo fix BUG=None TEST=None Review URL: http://codereview.chromium.org/6577038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76061 0039d316-1c4b-4281-b951-d872f2087c98
* Comment out unused parameter names in function definitions,joi@chromium.org2011-02-253-3/+3
| | | | | | | | | | | | | | to adhere to the C++ Style Guide. Landing for roubert@google.com, original review http://codereview.chromium.org/6485028/ BUG=none TEST=none Review URL: http://codereview.chromium.org/6580049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76017 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gtest 492:539 and gmock 300:358thakis@chromium.org2011-02-241-0/+3
| | | | | | | | | | | | | | | | | | | | Skimming their changelogs, it looks like this range contains only minor tweaks for the most part. gtest r500 is interesting: http://code.google.com/p/googletest/source/detail?spec=svn500&r=500 "Modifies handling of C++ exceptions in death tests to treat exceptions escaping them as failures." This confuses to death tests in message_loop_unittest on Windows, MessageLoopTest::Crasher and MessageLoopTest::CrasherNasty. These two tests set the global SEH handler. gtest now uses a frame-level exception handler, which overrides this global handler. Hence, disable gtest's new death test behavior for base_unittests on windows. This is to prepare a gmock roll to 359, which should improve build speed on mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/6580010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75972 0039d316-1c4b-4281-b951-d872f2087c98
* Mac specific chromium-style issues now that the trybot is sane.erg@google.com2011-02-242-2/+3
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6575020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75939 0039d316-1c4b-4281-b951-d872f2087c98
* Get service process running standalone on the mac by hooking it into launchd.dmaclach@chromium.org2011-02-244-12/+101
| | | | | | | | | BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/6482016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75893 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 11:20:17 +0000