| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the current setup, if you have a header file my_class.h
class BASE_EXPORT MyClass {
public:
void MyInlineMethod() { /* do stuff, inline */ }
};
then every cc file that includes my_class.h will have a public symbol
for MyInlineMethod (because inline methods need to be emitted to
every translation unit, and the linker sorts them out). With the
components build, the linker can't decide to drop these inline methods,
so every .so that uses this header file will have the same public symbol.
With this proposed change, the symbol will only be visible in the target
the header file belongs to, and it will be hidden in all other components.
That's cleaner, and it also prevents accident hidden dependencies (say
target A depends on B, and B depends on C. A accidentally uses an inline
function from a class in C. With this change, that would result in a linker
error, and an explicit dependency from A on C would have to be added).
Also add a missing CHROMEOS_IMPLEMENTATION define which went
unnoticed until now.
BUG=90078
TEST=Things still build.
TBR=ben, tony, viettrungluu, thestig, agl, willchan
Review URL: https://chromiumcodereview.appspot.com/10386108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The EtwTraceConsumerRealtimeTest test fixture subclass contained a second instance of the
test_provider_ member variable. This occluded the initialized superclass instance's variable
and led to the test relying on uninitialized data.
BUG=127671
TEST=Unittests pass on Vista.
Review URL: https://chromiumcodereview.appspot.com/10386141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename tests_run to test_isolation_mode.
TBR=mad@chromium.org
BUG=98636
TEST=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10392073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trailing whitespace without a \n character is still trimmed away.
Adds additional tests for this.
Also, makes the code use ContainsOnlyWhitespace() from base
and makes the implementation of ContainsOnlyWhitespace()
shorter (based on the code that was in text_elider.cc.)
BUG=126297
TEST=New tests in text_elider_unittest.cc
Review URL: https://chromiumcodereview.appspot.com/10386016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a patch that FireFox has had for > 5 years. This is just
a guess based on where the crash is happening.
BUG=123157
TEST=Covered by exising unit tests.
Review URL: https://chromiumcodereview.appspot.com/10332147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=127671
TEST=Test passes on Vista test bots.
Review URL: https://chromiumcodereview.appspot.com/10383162
TBR=siggi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10382159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=127671
TEST=Test passes on Vista test bots.
Review URL: https://chromiumcodereview.appspot.com/10383162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reported in https://bugs.gentoo.org/show_bug.cgi?id=415601
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10399002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will help me in narrowing down which URLFetcher is leaking the URLRequest in these crashes.
BUG= 90971,127860
TBR=eroman
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10383145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Now ThreadTaskRunnerHandle is used instead of MessageLoop::current(). This allows to use Timer classes on threads that don't have MessageLoop but have a different task runner.
Review URL: https://chromiumcodereview.appspot.com/10213012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some minor changes to support and make clear that a DataFetcher can
return true without providing an orientation. This is the case for
Android's data fetcher where we need to wait for the sensor manager to
push an event instead of being able to directly poll the orientation
sensor.
TBR=jam@chromium.org
TEST=content_unittests:DeviceOrientationProviderTest
Review URL: https://chromiumcodereview.appspot.com/10268013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, Don't make try_compile_test bot RED if native tests APK fails to compile.
BUG=125059
TBR=mark@chromium.org,tsepez@chromium.org
TEST=
Review URL: https://chromiumcodereview.appspot.com/10310098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move the date checking to the FactoryGetFieldTrial() factory method instead.
BUG=none
TEST=existing unit tests
Review URL: https://chromiumcodereview.appspot.com/10332076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yzshen@chromium.org
BUG=127671
Review URL: https://chromiumcodereview.appspot.com/10389082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yzshen@chromium.org
BUG=127671
Review URL: https://chromiumcodereview.appspot.com/10387067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Manually define CLOCK_SYSTEM_TRACE for OS_CHROMEOS. This is in the code (and not gyp) to minimize scope.
BUG=chromium-os:30502
TEST=verify chrome:tracing works w/ a chromeos=1 build on linux and on cros (using the correct clock in each case)
Change-Id: I9439a1de9fe30cb2f34652020a29a4450b71e1ea
Review URL: https://chromiumcodereview.appspot.com/10356028
TBR=sleffler@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10382112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Manually define CLOCK_SYSTEM_TRACE for OS_CHROMEOS. This is in the code (and not gyp) to minimize scope.
BUG=chromium-os:30502
TEST=verify chrome:tracing works w/ a chromeos=1 build on linux and on cros (using the correct clock in each case)
Change-Id: I9439a1de9fe30cb2f34652020a29a4450b71e1ea
Review URL: https://chromiumcodereview.appspot.com/10356028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=127364
TEST=no leak
TBR=willchan,dhollowa
Review URL: https://chromiumcodereview.appspot.com/10382088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/10035034
Review URL: https://chromiumcodereview.appspot.com/10392025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Build media java files (we weren't).
Fix adb_install_content_shell for cases where the app was stuck.
Add upstream staging gyp var / #define.
Be more consistent about jar output files (all in lib.java).
Upstream a bunch of random files (e.g. ppapi).
Upstream a bunch of java and native code hit as part of shlib init.
Properly package jar files in content shell.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10377059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In r136174 I broke the Mac component build. Fix was to properly export GetSearchPathDirectory().
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10387050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also:
* Clarify the interface for DictionaryValue::MergeDictionary.
* Add tests that MergeDictionary performs a deep copy.
FYI:
* ReadExternalExtensionPrefFile() needs unit testing.
CID=103941
BUG=none
TEST=ValuesTest.MergeDictionaryDeepCopy
R=finnur
TBR=brettw
Review URL: https://chromiumcodereview.appspot.com/10358020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
classes are properly associated with the modules containing their window procedures.
TEST=win,win_rel
Review URL: https://chromiumcodereview.appspot.com/10315012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The class will be used to hold a reference to the thread's task runner.
Review URL: https://chromiumcodereview.appspot.com/10380016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The manifest package name should not be hardcoded, but instead read from
the context.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10381066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=content_unittests: GeolocationProvider.* LocationArbitrator.*
There are also some integration tests downstream for the Java specific part.
Review URL: https://chromiumcodereview.appspot.com/10209003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is prerequisite for adding support for running chrome on network
shared location
BUG=120388
TEST=base_unittests:PathServiceTest.Override
Review URL: https://chromiumcodereview.appspot.com/10388027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=126008
TEST=TaskRunnerHelpersTest.PostTaskAndReplyWithResultPassed
R=willchan
Review URL: https://chromiumcodereview.appspot.com/10384021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be needed by the Finch client (soon to be known as the Variations Service) that will get updated information about FieldTrials and pre-feed the field trial list based on this information.
So this is different from CreateFieldTrial, which forced a group choice, this new method allows forcing a new set of appended groups.
BUG=121695
TEST=build\Debug\base_unittests.exe --gtest_filter=FieldTrialTest.SetForced
Review URL: https://chromiumcodereview.appspot.com/10382018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed an "unused variable" issue of the original CL (http://codereview.chromium.org/10224004/).
Use Android API for GetDisplayNameForLocale().
Using Android API, we can reduce the data size of ICU and thus reduce the
binary size of chromium-android.
BUG=none
TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry
TBR=jrg@chromium.org,isherman@chromium.org,mark@chromium.org,jshin@chromium.org,rvargas@chromium.org
Review URL: http://codereview.chromium.org/10310029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failure:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/4835/steps/BuildTarget/logs/stdio
Using Android API, we can reduce the data size of ICU and thus reduce the
binary size of chromium-android.
BUG=none
TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry
TBR=sky
Review URL: http://codereview.chromium.org/10224004
TBR=wangxianzhu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10380018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using Android API, we can reduce the data size of ICU and thus reduce the
binary size of chromium-android.
BUG=none
TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry
TBR=sky
Review URL: http://codereview.chromium.org/10224004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Previously that method was crashing when called when thread is not running
Review URL: http://codereview.chromium.org/10375014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are allowed to create the profile directory.
This patch lets Chrome start with profile located on a network share on
Windows Vista and newer.
BUG=120388
TEST=Start Chrome with --user-data-dir pointing to a network share location and try to navigate to a web page. This should not lead to a hang of the renderer.
Review URL: http://codereview.chromium.org/10306009
TBR=pastarmovj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10382012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
create the profile directory.
This patch lets Chrome start with profile located on a network share on
Windows Vista and newer.
BUG=120388
TEST=Start Chrome with --user-data-dir pointing to a network share location and try to navigate to a web page. This should not lead to a hang of the renderer.
Review URL: http://codereview.chromium.org/10306009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ObserverList.
R=jar
TEST=base unit tests
BUG=126027
Review URL: http://codereview.chromium.org/10342021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=125846
R=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10302004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(eg: scoped_ptr and friends), .Pass() the result to the reply.
Because the temporary storage of the result is an implementation detail of PostTaskAndReplyWithResults, its safe to always assume that passed types should be passed.
BUG=126008
TEST=TaskRunnerHelpersTest.PostTaskAndReplyWithResultPassed
Review URL: http://codereview.chromium.org/10344012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not be represented with class/structs.
BUG=chromium-os:30217
TEST=JSONValueConverterTest.*
Review URL: https://chromiumcodereview.appspot.com/10354015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
patch includes two parts:
1. gyp files modification to include x86 android build.
2. add android config files for yasm which is copied from linux ones. enable android x86 build
This patch is cloned from the issue #10198027 for ownership issue.
https://chromiumcodereview.appspot.com/10198027/
BUG=125160
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135087
Review URL: http://codereview.chromium.org/10271039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
patch includes two parts:
1. gyp files modification to include x86 android build.
2. add android config files for yasm which is copied from linux ones. enable android x86 build
This patch is cloned from the issue #10198027 for ownership issue.
https://chromiumcodereview.appspot.com/10198027/
BUG=125160
TEST=
Review URL: http://codereview.chromium.org/10271039
TBR=james.wei@intel.com
Review URL: https://chromiumcodereview.appspot.com/10331008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
patch includes two parts:
1. gyp files modification to include x86 android build.
2. add android config files for yasm which is copied from linux ones. enable android x86 build
This patch is cloned from the issue #10198027 for ownership issue.
https://chromiumcodereview.appspot.com/10198027/
BUG=125160
TEST=
Review URL: http://codereview.chromium.org/10271039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles chrome, browser_tests and ui_tests
Review URL: http://codereview.chromium.org/10272004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
lately.
Review URL: https://chromiumcodereview.appspot.com/10337007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currently displayed tab url and title.
This is retrieved via a registered window message sent by the metro driver.
The information is used by the share charm in metro.
BUG=125673
R=cpu,sky
Review URL: https://chromiumcodereview.appspot.com/10287005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
information about the current tab with the metro driver.
BUG=125673
R=cpu
Review URL: https://chromiumcodereview.appspot.com/10290004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change includes a process id in the synthesized temp dir
names, so that created directories will be more unique across
the system when you're running a bunch of base-using processes at
once (e.g., in the layout tests).
BUG=125678
R=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10264026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add TimeTicks::NowFromSystemTraceTime to return the current system trace
event clock (falling back to TimeTicks::HighResNow when not supported).
On systems where the system trace clock is available this allows
system and chrome events to be stamped with a common clock (eliminating
post-processing time shift adjustment that can be hard).
BUG=chromium-os:27809
TEST=unit tests + collect trace data on chrome os w/ kernel that supports clock_gettime(CLOCK_SYSTEM_TRACE)
Change-Id: Ia6a500bd13a6f09c49052a1dd1421027960d8dea
Review URL: http://codereview.chromium.org/10257020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=125415
TEST=Manual
Review URL: http://codereview.chromium.org/10254024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134759 0039d316-1c4b-4281-b951-d872f2087c98
|