| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none,100309
Review URL: https://chromiumcodereview.appspot.com/10977073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-Windows. Instead change files that use this to specifically #ifdef it for OS_WIN, like we do most other Windows-specific code.
I plan to factor out the "subclass base::Thread to init MTA on Windows" pattern to its own file in a followup change.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/10990079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when a proc field is very large. For example,
proc_stats[VM_VSIZE]=="3073200128" is possible and causes StringToInt
to return false.
Review URL: https://chromiumcodereview.appspot.com/10990101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses a more compact format to avoid generating uber-long names.
Changes media_player_bridge to use such format.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10957037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
greater than 1366x768.
BUG=152198
TEST=Chrome should switch to metro after making it the default browser via first-run UI on a machine that satisfies the new heuristic.
Review URL: https://chromiumcodereview.appspot.com/10986066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10939010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
std::string internals.
BUG=126107
TEST=Unit tests on Windows and Android.
Review URL: https://chromiumcodereview.appspot.com/11004002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
compiler-based ThreadSanitizer (http://dev.chromium.org/developers/testing/threadsanitizer-tsan-v2)
BUG=128314
Review URL: https://codereview.chromium.org/10949021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is to overwrite the shortcut completely (i.e. like SHORTCUT_CREATE_ALWAYS), but only if it exists already.
In this line of thought, SHORTCUT_UPDATE_EXISTING should now only be used when the desire is to update a subset of the properties without affecting other properties currently set on the shortcut.
The two current uses of SHORTCUT_UPDATE_EXISTING at
http://108.166.104.54/xref/chromium/src/chrome/browser/ui/web_applications/web_app_ui.cc#275
and http://108.166.104.54/xref/chromium/src/chrome/browser/shell_integration_win.cc#343
The other uses in the installer are not, but I will change this as part of my big ShellUtil CL coming up.
BUG=148539
TEST=base_unittests.exe --gtest_filter=ShortcutTest*
Review URL: https://chromiumcodereview.appspot.com/10965053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unit tests have to restore the Overrdies they make because they all live in the same
process and not cleaning up their mess means other tests will run against possibly
modified profiles. This class allows tests to set up path overrides and clean them up
in a convenient way and makes sure the global path map stays clean afterwards.
BUG=149161
TEST=unit_tests still pass.
Review URL: https://chromiumcodereview.appspot.com/10948010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
registry key. This is the norm for the Win32 API. base::win::RegKey need not disallow a NULL name in DeleteValue.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10987033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
target base/test/test_shortcut_win.cc
BUG=148539
TEST=base_unittests.exe --gtest_filter=ShortcutTest*
installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest*
unit_tests --gtest_filter=ProfileShortcutManagerTest*
Locally tried a test meant to fail for every property:
TEST_F(ShortcutTest, CreateShortcutVerifyPropertiesWrong) {
ASSERT_TRUE(base::win::CreateOrUpdateShortcutLink(
link_file_, link_properties_, base::win::SHORTCUT_CREATE_ALWAYS));
base::win::ShortcutProperties wrong_properties = link_properties_;
wrong_properties.set_target(FilePath(L"g:\\src\\component\\.gclient"));
wrong_properties.set_working_dir(temp_dir_2_.path());
wrong_properties.set_arguments(string16());
wrong_properties.set_description(L"foo");
wrong_properties.set_icon(temp_dir_2_.path().Append(L"joe.ico"), 8);
wrong_properties.set_app_id(L"JOE");
wrong_properties.set_dual_mode(true);
base::win::ValidateShortcut(link_file_, wrong_properties);
}
And got expected failure output for every property:
[ RUN ] ShortcutTest.CreateShortcutVerifyPropertiesWrong
g:\src\component\src\base\test\test_shortcut_win.cc(54): error: Value of: long_actual_path
Actual: G:\src\temp\scoped_dir14192_645\Target 1.txt
Expected: long_expected_path
Which is: g:\src\component\.gclient
g:\src\component\src\base\test\test_shortcut_win.cc(54): error: Value of: long_actual_path
Actual: G:\src\temp\scoped_dir14192_645
Expected: long_expected_path
Which is: G:\src\temp\scoped_dir14192_27681
g:\src\component\src\base\test\test_shortcut_win.cc(95): error: Value of: read_arguments
Actual: L"--magic --awesome"
Expected: properties.arguments
Which is: L""
g:\src\component\src\base\test\test_shortcut_win.cc(101): error: Value of: read_description
Actual: L"Chrome is awesome."
Expected: properties.description
Which is: L"foo"
g:\src\component\src\base\test\test_shortcut_win.cc(43): error: Expected: (0U) != (::GetLongPathNameW( expected_path.val
ue().c_str(), long_expected_path_chars, 260)), actual: 0 vs 0
Failed to get LongPathName of G:\src\temp\scoped_dir14192_27681\joe.ico
g:\src\component\src\base\test\test_shortcut_win.cc(108): error: Value of: read_icon_index
Actual: 4
Expected: properties.icon_index
Which is: 8
g:\src\component\src\base\test\test_shortcut_win.cc(129): error: Value of: read_app_id
Actual: L"Chrome"
Expected: properties.app_id
Which is: L"JOE"
g:\src\component\src\base\test\test_shortcut_win.cc(138): error: Value of: static_cast<bool>(read_dual_mode)
Actual: false
Expected: properties.dual_mode
Which is: true
[ FAILED ] ShortcutTest.CreateShortcutVerifyPropertiesWrong (37 ms)
Review URL: https://chromiumcodereview.appspot.com/10996005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Used in upcoming http://codereview.chromium.org/10996005/ (and potentially others).
BUG=148539
TEST=Write a test with an error comparing two FilePaths and confirm the paths' values are printed by gtest as opposed to the byte-representation.
Review URL: https://chromiumcodereview.appspot.com/10984028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is especially useful for unit tests because they live in the same process
and share all the singletons including PathService. One can of course override
the overrides but it is much cleaner and sometimes the only good solution to
return to the original PathProvider instead.
BUG=149161
TEST=base_unittests:PathServiceTest.*
Review URL: https://chromiumcodereview.appspot.com/10909228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It stores mapping between object's starting addresses and their
allocated types when a build option 'clang_type_profiler=1' is
specified. It enables information like
"an object at 0x37f3c88 is an instance of std::string."
Nothing is changed when the option is not specified.
It depends on a modified version of the LLVM/Clang compiler
introduced at deps/third_party/llvm-allocated-type.
BUG=123758
TEST=build with clang_type_profiler=1 and run type_profiler_unittests and type_profiler_map_unittests manually.
Review URL: https://chromiumcodereview.appspot.com/10411047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
POSIX versions return consistent architecture names.
Review URL: https://chromiumcodereview.appspot.com/10910247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Gives the GC a little less work todo, especially during repeatedly called async callpaths.
Review URL: https://chromiumcodereview.appspot.com/10913284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DIR_USER_DESKTOP does not apply on iOS, so exclude it from the set of paths that
are tested.
BUG=b/151050
Review URL: https://chromiumcodereview.appspot.com/10970019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp targets should not depend on tests from other packages, but
instead be able to depend on their test utils.
The target including the base utilities is called
base_java_test_support and contains files from
base/test/android/javatests.
base_java_test_support was also the name of the wrongly named target for
building base/android/javatests, but since only contained util-classes,
no new target has been created for tests of base/android/java.
BUG=151561,150773
Review URL: https://chromiumcodereview.appspot.com/10974012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=152037
TEST=none
TBR=willchan@chromium.org
Review URL: https://codereview.chromium.org/10978006
TBR=rvargas@google.com
Review URL: https://codereview.chromium.org/10978007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=152037
TEST=none
TBR=willchan@chromium.org
Review URL: https://codereview.chromium.org/10978006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file contains some hand-written JNI, and a few
hops native<->java.
This clarifies things a bit by:
- adding a MediaPlayerBridge.java to avoid some hops.
- moving code to MediaPlayerListener.java.
Further clean up will be done by auto-generating bindings for
android.media.MediaPlayer directly.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10961015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows to simplify some places such as surface_texture_bridge.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10968009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=base_unittests
TBR=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10969059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
g_vlog_info_prev is not currently referenced in the nacl build of
logging.cc. Cast to void to suppress warning and reduce build spew.
BUG=http://code.google.com/p/chromium/issues/detail?id=148648
TEST=no spew on incremental
R=bbudge@chromium.org,brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10960029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=139612
Review URL: https://chromiumcodereview.appspot.com/10829466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous CL broke the build, because the changes in net_errors_java.template
didn't get the net_error_java target to be rebuilt. We needed a net.gyp change
that makes sure NetError.java gets recreated after the changes.
BUG=137967
TBR=jam@chromium.org, mkosiba@chromium.org, willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10963041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves related callabcks from content_view_client to
web_contents_observer_android and makes the client a Java only API.
This broke the compile:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=16035
ErrorCodeConversionHelper, new in this change, failed to build.
BUG=137967
Review URL: https://chromiumcodereview.appspot.com/10952029
TBR=yusufo@chromium.org
Review URL: https://codereview.chromium.org/10969045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves related callabcks from content_view_client to
web_contents_observer_android and makes the client a Java only API.
BUG=137967
Review URL: https://chromiumcodereview.appspot.com/10952029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's still some default handling needed if the embedder doesn't override the handler.
Includes clean-up of previous hooks in content that aren't needed anymore.
BUG=138483
Review URL: https://chromiumcodereview.appspot.com/10907166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I had left a TODO for myself, but ended up doing it in the same CL in http://crrev.com/156250
NOTRY=True
BUG=148539
Review URL: https://chromiumcodereview.appspot.com/10911345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
folders.
Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667).
This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests!
Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo.
TBR=brettw@chromium.org
BUG=148539
TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user)
Desktop shortcuts installed in the right place (both All Users and per-user installs).
installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest*
unit_tests.exe --gtest_filter=ProfileShortcutManagerTest*
base_unittests --gtest_filter=PathServiceTest*
Review URL: https://chromiumcodereview.appspot.com/10964007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Quick Launch folders.
The previous patch failed PathServiceTest.Get.
This allows usage of PathService to cache the paths and more importantly to mock them in shortcut tests!
Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo.
BUG=148539
TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user)
Desktop shortcuts installed in the right place (both All Users and per-user installs).
installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest*
unit_tests.exe --gtest_filter=ProfileShortcutManagerTest*
base_unittests --gtest_filter=PathServiceTest*
Review URL: https://chromiumcodereview.appspot.com/10910209
TBR=gab@chromium.org
Review URL: https://codereview.chromium.org/10958009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
folders.
This allows usage of PathService to cache the paths and more importantly to mock them in shortcut tests!
Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo.
BUG=148539
TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user)
Desktop shortcuts installed in the right place (both All Users and per-user installs).
installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest*
unit_tests.exe --gtest_filter=ProfileShortcutManagerTest*
base_unittests --gtest_filter=PathServiceTest*
Review URL: https://chromiumcodereview.appspot.com/10910209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On tcmalloc-based versions of Chromium, skia resets the global new
handler to prevent the oom-killer from kicking in. Traditionally the
OSX developers have been agin this, because it's not thread-safe, and
we have questions about whether it's even the right thing to do. This
change should be thread-safe because g_old_malloc is only set on the
main thread at startup.
As far as whether it's the right thing to do, I'm tired and want to
quit hearing about it.
Additionally, remove a bit of leftover pre-10.6 code.
BUG=103980,73751,117949
Review URL: https://chromiumcodereview.appspot.com/10908245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to make it possible for a ResourceThrottle (which runs on
the IO thread) to call a WebViewClient method. This requires
caching the RenderViewHost<->WebContents relationship in
a threadsafe way.
BUG=138481
Review URL: https://codereview.chromium.org/10702083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upstreaming the Select File Dialog and its dependencies needed for
Chrome on Android
BUG=116131
Review URL: https://chromiumcodereview.appspot.com/10916160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To do this properly, we need a new type of trace event "FLOW" which will be drawn as lines in about:tracing from BEGIN to END.
Also instruments SequencedWorkerPool and ChannelReader::DispatchInputData, which were not currently traced.
BUG=79942
Review URL: https://codereview.chromium.org/10913242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/10908271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shortcuts on the chrome shortcut or simply from the
command line, if we defer to immersive chrome if it is already running, then we should also activate the metro chrome instance.
Added a helper function IsProcessImmersive which takes in the process handle to determine if it is immersive to base\win\metro.cc/.h
BUG=144297
R=cpu
Review URL: https://codereview.chromium.org/10910311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10825250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requirs us to use leakable Singleton/LazyInstance object since.
See crbug.com/134118 for details
BUG=134118
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10580038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a class to monitor disks being added, removed or changed. When ever such events happen notifications are posted through base::SystemMonitor.
BUG=110400, 110823
Review URL: https://chromiumcodereview.appspot.com/10919185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10914279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, does a bit of style cleanup by alpha sorting the list.
BUG=146004
Review URL: https://chromiumcodereview.appspot.com/10907240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ConvertJavaToUTF functions can have undefined behavior when called with
null strings. This CL makes it easier to catch such problems.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10916281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add an android_webview ResourceDispatchHostLoginDelgate that forwards
the auth request to the java side embedder via
AwContents.onReceivedHttpAuthRequest.
Review URL: https://chromiumcodereview.appspot.com/10918023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Typed Append methods to ListValue (AppendString etc) including AppendStrings.
- Typed SetWithoutPathExpansion methods (SetStringWithoutPathExpansion etc).
The latter is important because it's a common mistake to use Set rather than
SetWithoutPathExpansion; the existence of these extra methods should help.
Review URL: https://chromiumcodereview.appspot.com/10914246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for Windows, which
when set ensures that the child process is created with the CREATE_BREAKAWAY_FROM_JOB flag.
BUG=148753
R=cpu
Review URL: https://codereview.chromium.org/10914277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156690 0039d316-1c4b-4281-b951-d872f2087c98
|