summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Log the argument (NSS config directory) that we pass towtc@chromium.org2009-10-231-3/+5
| | | | | | | | | | | NSS_InitReadWrite if it fails. R=senorblanco BUG=18772 TEST=none Review URL: http://codereview.chromium.org/335001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29953 0039d316-1c4b-4281-b951-d872f2087c98
* Move the json-related files into a separate json directory. This hopefully alsobrettw@chromium.org2009-10-2310-47/+75
| | | | | | | | | | | makes the naming of string_escape more clear (it's actually JSON-specific). Move the files into the base namespace. TEST=none BUG=none Review URL: http://codereview.chromium.org/316016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29934 0039d316-1c4b-4281-b951-d872f2087c98
* Implements tests for testing browser's overall key events handling behavior.suzhe@chromium.org2009-10-232-50/+26
| | | | | | | | | | | | This CL implements some basic tests for testing browser's overall key events handling behavior. This CL depends on http://codereview.chromium.org/235039 and http://codereview.chromium.org/195062. Currently, only Linux and Windows are supported. The tests assume US keyboard layout is used and no IME is activated. We still need to investigate how to write tests that involving different keyboard layout and input methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/268035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29866 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the FileUtilICU tests because they hang purifynsylvain@chromium.org2009-10-231-2/+2
| | | | | | | BUG: 25598 Review URL: http://codereview.chromium.org/334003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29852 0039d316-1c4b-4281-b951-d872f2087c98
* Do some cleanup of file path name handling.brettw@chromium.org2009-10-223-44/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | This started trying to cleanup DownloadManager::GenerateFilename which asserts if your system locale isn't UTF-8 (I ran into this when mine got messed up). The solution is to have GetSuggestedFilename return a FilePath rather than calling FromWStringHack. The rest of the patch is a result of trying to write GetSuggestedFilename in a reasonable way. I changed ReplaceIllegalCharacters to work on a FilePath::StringType. Some places in the code calling these functions got cleaner, some got messier. I think overall the ones that got messier are the ones doing sketchy things with paths and the ones that got cleaner are the ones doing things more properly. The only code here that gets called a nontrivial number of times is the weburlloader, and I think the new code does about the same number of string conversions overall (though on certain platforms the number will be higher or lower). BUG=none TEST=none Review URL: http://codereview.chromium.org/271056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29832 0039d316-1c4b-4281-b951-d872f2087c98
* Call MaybeScheduleNestingDeferredWork at the top of each loop iteration frommark@chromium.org2009-10-222-17/+58
| | | | | | | | | | | | | | | a kCFRunLoopBeforeSources observer. A busy loop that's driven with a nonzero duration might not go to sleep or exit soon after a nested loop exits, so calling MaybeScheduleNestingDeferredWork from the existing kCFRunLoopBeforeWaiting and kCFRunLoopExit observers may not be sufficient to guarantee processing of nesting-deferred work in all situations. BUG=24968 TEST=All of the test cases listed in the commit message from r29749. No new test cases; this change addresses a purely theoretical case. Review URL: http://codereview.chromium.org/315010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29775 0039d316-1c4b-4281-b951-d872f2087c98
* Change the strategy used to attempt nesting-deferred work to account equallymark@chromium.org2009-10-222-73/+117
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | well for nested run loops under our own control (those started by Run) and those beyond our control (native event loops). Previously, upon any exit from a nested native loop, we would schedule nesting-deferred work for processing. However, some nested native loops do not execute in a single loop; rather, they start and stop the CFRunLoop rapidly. In such cases, each exit from the CFRunLoop would cause nesting-deferred work to be scheduled, and on each new entry to the CFRunLoop, we would attempt to process it. This rapid-fire action meant that we'd never sleep. Nested loops managed by Run were exempt from these problems since r28811, because we could defer scheduling nesting-deferred work until returning to Run. The new strategy is to detect whether any nested loops (native or managed by Run) had run before the run loop goes to sleep or exits. If any nested loops did run, nesting-deferred work is scheduled for processing. BUG=24968 TEST=1. Test case from bug 24968, printing: open any page, press command-P, leave the dialog up, and check Chrome's CPU usage. No Chrome process should be monopolizing any CPU. This tests nested native run loops. 2. Test case from bug 24337, JS alerts: open Gmail, start composing a new message in a new window, address it to yourself, move focus to the subject field, click the Discard button, and click "OK" at the alert. The alert and composition window should close. 3. Test case from bug 24383, JS alerts: no Chrome processes should use 100% CPU after visiting javascript:alert("hi"). The JS alert cases test nested run loops managed by Run. 4. Test case from bug 13468 comment 5, autocomplete: autocomplete should still work after using "Back" from a contextual menu. This tests that nesting-deferred work is processed after leaving a nested run loop. 5. First run UI test case (no bug). Remove or move aside the profile directory (~/Library/Application Support/Chromium or ~/Library/Application Support/Google/Chrome) and launch the application. There should be first-run UI and it should be usable. Upon clicking "Start (application)", the application should start and be usable as normal. This tests delegateless run loops and delegateless work redispatch. 6. base_unittests --gtest_filter='MessageLoopTest.*' Review URL: http://codereview.chromium.org/300044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29749 0039d316-1c4b-4281-b951-d872f2087c98
* Trim the lsb_release output in GetLinuxDistro.thestig@chromium.org2009-10-211-1/+3
| | | | | | | | BUG=none TEST=With crash reporting enabled, renderer process command line doesn't have a trailing '?' in the --enable-crash-reporter switch value. Review URL: http://codereview.chromium.org/307027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29718 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify GetLinuxDistro() for Chrome OS.thestig@chromium.org2009-10-211-5/+13
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/303018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29682 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ProcessUtilTest.FDRemapping hang on x86_64 by counting open fds in child ↵dkegel@google.com2009-10-201-1/+3
| | | | | | | | | | | process nondestructively BUG=25270 TEST=base_unittests --gtest_filter=ProcessUtilTest.FDRemapping on x86_64 linux Review URL: http://codereview.chromium.org/293018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29570 0039d316-1c4b-4281-b951-d872f2087c98
* Add a comment warning against using RSAPrivateKeyImport on untrusted sources.rafaelw@chromium.org2009-10-201-4/+6
| | | | | | Review URL: http://codereview.chromium.org/307009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29566 0039d316-1c4b-4281-b951-d872f2087c98
* Remove +x bit from files that shouldn't have it.evan@chromium.org2009-10-202-0/+0
| | | | | | Review URL: http://codereview.chromium.org/307007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29548 0039d316-1c4b-4281-b951-d872f2087c98
* Minimize dependency of user scripts.mad@chromium.org2009-10-203-4/+175
| | | | | | | | | | | And made some minor lint fixes and code refactoring on the way, based on CR comments of previous attempt. BUG=none TEST=Make sure that the extension resources can still be properly localized and that they also load correctly when they are not localized. Review URL: http://codereview.chromium.org/267051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29512 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: change PIDs to base::ProcessId (or pid_t, as appropriate).viettrungluu@chromium.org2009-10-202-4/+4
| | | | | | | | | | | We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this. BUG=25272 TEST=none Review URL: http://codereview.chromium.org/300010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29511 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate PathService::Get(..., wstring*) and use FilePath instead.evan@chromium.org2009-10-194-8/+9
| | | | | | | | | | | | I tried fixing all the Windows code but there's a *ton* of it. This change will at least prevent people from adding new code that uses the deprecated version (as that won't compile on Lin/Mac). BUG=24672 Review URL: http://codereview.chromium.org/293013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29472 0039d316-1c4b-4281-b951-d872f2087c98
* Provide better diagnostics when launching with a silly executable path.mark@chromium.org2009-10-191-3/+4
| | | | | | | | BUG=24842 TEST=none Review URL: http://codereview.chromium.org/304004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29442 0039d316-1c4b-4281-b951-d872f2087c98
* Add more string16 variants.darin@chromium.org2009-10-192-0/+38
| | | | | | | | | | R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/304003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29440 0039d316-1c4b-4281-b951-d872f2087c98
* First fix to minimize copying of image data.erg@google.com2009-10-193-2/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is the first of multiple patches that clean up handling of memory regarding images. Previously, the code did several memcpy()s or equivalents. This change: - Creates an abstract interface RefCountedMemory which provides access to the front() of a memory range and the size() of it. It is a RefCountedThreadSafe. - Adds a RefCountedStaticMemory class which isa RefCountedMemory. - Pushes RefCountedBytes up into base/ from chrome/ and make it conform to RefCountedMemory. - Have ResourceBundle return RefCountedStaticMemory to the mmaped() or DLL loaded resources instead of memcpy()ing them. - General cleanups to minimize copies in constructing RefCountedBytes. - Use the above consistent interface in the BrowserThemeProvider, along with special casing the loading of the new tab page background. This patch is mostly cleanups and there should only be a slight performance gain if any. Most of the real speedups should come in subsequent patches. BUG=http://crbug.com/24493 TEST=Slightly faster on Perf bot; does not introduce crashes. Review URL: http://codereview.chromium.org/288005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29412 0039d316-1c4b-4281-b951-d872f2087c98
* We want GOOGLE_CHROME_BUILDs on Chrome OS to get the appropriate OS version ↵cmasone@google.com2009-10-191-1/+1
| | | | | | | | info. Review URL: http://codereview.chromium.org/294003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29408 0039d316-1c4b-4281-b951-d872f2087c98
* On Linux, Chrome uses lsb_release (a python script) to determine the name of ↵cmasone@google.com2009-10-191-0/+4
| | | | | | | | the distro. On Chrome OS, we don't need to do this. Review URL: http://codereview.chromium.org/285013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29405 0039d316-1c4b-4281-b951-d872f2087c98
* Forces user to use ScopedNSAutoreleasePool instead of using dmaclach@chromium.org2009-10-191-0/+26
| | | | | | | | | | | NSAutoreleasePool with scoped_nsobject. BUG=none TEST=none Review URL: http://codereview.chromium.org/292011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29399 0039d316-1c4b-4281-b951-d872f2087c98
* Remove special code fro calculating bucket index in linear histogramsjar@chromium.org2009-10-172-21/+8
| | | | | | | | | | | | | | | | | IMO, the original code was a premature optimization, and worse yet, it had a subtle off by 1 bug due to floating point rounding (which was identified by ERoman.... Thanks!!). This CL removes the special code from linear histograms, and relies on the "standard" binary search approach to locate the correct bucket when a new sample is processed. r=eroman BUG=24160 Review URL: http://codereview.chromium.org/273065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29371 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for Reset in StringTokenizerT and HttpHeadersIterator.tommi@chromium.org2009-10-162-0/+29
| | | | | | | | | TEST=Run HeadersIterator_Reset and the Reset test for StringTokenizer BUG=none Review URL: http://codereview.chromium.org/276067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29330 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust comment following r29182 post-commit feedback.mark@chromium.org2009-10-161-7/+6
| | | | | | | | | | Put now-unused macros back to how they are upstream. BUG=24911 TEST=none Review URL: http://codereview.chromium.org/289003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29328 0039d316-1c4b-4281-b951-d872f2087c98
* Mark some disabled tests as flaky to increase test coverage.phajdan.jr@chromium.org2009-10-162-5/+4
| | | | | | | | | | | | When a test doesn't hang or crash, it can run on the bots and on developers' machines. BUG=none TEST=none Review URL: http://codereview.chromium.org/269104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29279 0039d316-1c4b-4281-b951-d872f2087c98
* Add AtomicFlag class to base/...timurrrr@chromium.org2009-10-164-0/+147
| | | | | | | | | | This class is intended to replace wrong synchronization via boolean like those in the bugs listed below. TEST=./sconsbuild/Debug/base_unittests --gtest_filter="*AtomicFlag*" BUG=21468,22520,24419 Review URL: http://codereview.chromium.org/276002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29265 0039d316-1c4b-4281-b951-d872f2087c98
* Add string16 support for LowerCaseEqualsASCII, StartsWith, and EndsWith.darin@chromium.org2009-10-152-10/+71
| | | | | | | | | | R=mpcomplete BUG=none TEST=none Review URL: http://codereview.chromium.org/274067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29209 0039d316-1c4b-4281-b951-d872f2087c98
* Make all NSPR symbols "private extern".mark@chromium.org2009-10-151-1/+25
| | | | | | | | | | | | | | | BUG=24911 TEST=mac$ nm C.app/Contents/Versions/*/C F.framework/C F | grep " [A-TV-Z] " should not show any NSPR symbols. The following NSPR symbols were formerly exported: __Z14PR_ImplodeTimePK14PRExplodedTime __Z16PR_GMTParametersPK14PRExplodedTime __Z16PR_NormalizeTimeP14PRExplodedTimePF16PRTimeParametersPKS_E __Z18PR_ParseTimeStringPKciPx These symbols should no longer be exported on any platform. Review URL: http://codereview.chromium.org/274068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29182 0039d316-1c4b-4281-b951-d872f2087c98
* Add a variation of a stack to the base unittest umr flaky list.nsylvain@chromium.org2009-10-151-0/+18
| | | | | | Review URL: http://codereview.chromium.org/282008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29174 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r29078: Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-152-22/+0
| | | | | | | | | | | | | With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced). Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705 mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491 linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466 I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet. Review URL: http://codereview.chromium.org/271099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
* Remove file_util::TrimTrailingSeparators(), which is deprecated andtkent@chromium.org2009-10-155-18/+6
| | | | | | | | | | doesn't work well for Windows root drives. BUG=24722 TEST=existing tests are enough. Review URL: http://codereview.chromium.org/271086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29093 0039d316-1c4b-4281-b951-d872f2087c98
* Revert wstring patch (r29078 and follow up commits). It is causing failures ↵estade@chromium.org2009-10-152-0/+22
| | | | | | | | | | on the buildbots. TBR=nsylvain Review URL: http://codereview.chromium.org/280004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-152-22/+0
| | | | | | | | | | | death to the wstring TEST=trybots BUG=none Review URL: http://codereview.chromium.org/276016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use NSBundle when unsure of thread safety.mark@chromium.org2009-10-151-12/+11
| | | | | | | | BUG=24842 TEST=unit tests pass, app still works Review URL: http://codereview.chromium.org/271094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29077 0039d316-1c4b-4281-b951-d872f2087c98
* More CopyDirectory tests and fixesvandebo@chromium.org2009-10-153-9/+145
| | | | | | | | | BUG=themes stopped working on Linux and Mac TEST=unittests Review URL: http://codereview.chromium.org/269083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29076 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the base_gfx project since it no longer has an external dependencies.brettw@chromium.org2009-10-141-30/+28
| | | | | | | | | | Replace it with base_i18n which encapsulates all ICU dependencies. BUG=none TEST=none Review URL: http://codereview.chromium.org/267048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29036 0039d316-1c4b-4281-b951-d872f2087c98
* Re-attempt r28993darin@chromium.org2009-10-142-28/+64
| | | | | | | | | | | | | | Add string16 support for TrimString, TrimWhitespace, and CollapseWhitespace. Also adds kWhitespaceUTF16. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/275019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29012 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 28993.darin@chromium.org2009-10-142-64/+28
| | | | | | Review URL: http://codereview.chromium.org/267100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28994 0039d316-1c4b-4281-b951-d872f2087c98
* Add string16 support for TrimString, TrimWhitespace, and CollapseWhitespace.darin@chromium.org2009-10-142-28/+64
| | | | | | | | | | | | Also adds kWhitespaceUTF16. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/267098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28993 0039d316-1c4b-4281-b951-d872f2087c98
* John, please review everything.ananta@chromium.org2009-10-142-3/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | agl, please review changes to the waitable_event_watcher code. Multiple sync channels if used in the same listener thread could result in calls completing in the wrong context at times. This happens if there are nested calls on these sync channels, i.e 1. Call from client 1 on channel 1 to server 1. Message pumping is enabled for the corresponding message 2. Call from client 2 on channel 2 to server 2, Message pumping is enabled for the corresponding message Now if a reply for 1 arrives, it should be queued until reply 2 arrives. This does not happen which causes 2 to terminate prematurely leading to crashes, 1 waiting indefinitely at times, etc. The fix for this issue is to maintain a local global stack for the send done event watcher object. The global object is in the form of a TLS. This ensures that we only watch for completed events on the outermost sync channel. The changes in the Waitable event watcher object are to return the current delegate which is needed to start watching the old send watcher once we are done and to ensure that the event member is set even if it was already signaled when StartWatching was called. I have added a unit test in ipc_tests for this case. I removed the old QueuedReply based unit tests as they did not test the actual nested call case. While debugging these issues I also found some issues in BrowserRenderProcessHost::OnChannelError where it would delete a sync channel while it was in use. Based on a discussion with jam we decided to DeleteSoon the sync channel pointer. However this broke some browser ui tests which relied on the timing of the OnChannelError notification. We decided to leave the existing code as is for now. I removed the DCHECK on channel as it would fire repeatedly if the channel died while multiple sync calls were waiting to complete leading to OnChannelError firing multiple times. Bug=24427 Review URL: http://codereview.chromium.org/271033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28967 0039d316-1c4b-4281-b951-d872f2087c98
* Move the framework and helper application into a versioned directory in supportmark@chromium.org2009-10-141-6/+1
| | | | | | | | | | | | | | | | | | | | | | of unbreaking auto-update. BUG=14610 TEST= - The following bundles should be gone: - Chromium.app/Contents/Frameworks/Chromium Framework.framework - Chromium.app/Contents/Resources/Chromium Helper.app They should be replaced by: - Chromium.app/Contents/Versions/*/Chromium Framework.framework - Chromium.app/Contents/Versions/*/Chromium Helper.app - The application should continue to function properly and all tests should still pass. - The signed application should have the inner framework and helper application signed, and the outer application signed. The outer seal should permit unknown versions to be present in the Versions directory, but should protect the active versioned directory. - Auto-updating to an official build with this change should still work. Review URL: http://codereview.chromium.org/261031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28963 0039d316-1c4b-4281-b951-d872f2087c98
* Add a comment to file_path.h describing a couple of bits of trivia that camemark@chromium.org2009-10-141-0/+28
| | | | | | | | | | up today. We should have these documented. Now we do. BUG=0 TEST={} Review URL: http://codereview.chromium.org/274043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28946 0039d316-1c4b-4281-b951-d872f2087c98
* Demangle C++ symbols in stack traces for Linux.evan@chromium.org2009-10-142-2/+74
| | | | | | | | | | | | | | | | | | | | | | | | | My first Chromium linux build greeted me with a backtrace of mangled symbols (FWIW, my /dev/shm permission was wrong). That made me write this patch. BEFORE: ../sconsbuild/Debug/base_unittests(_ZN10StackTraceC1Ev+0x20) [0x817795e] ../sconsbuild/Debug/base_unittests(_ZN30StackTrace_OutputToStream_Test8TestBodyEv+0x18) [0x805fc98] ../sconsbuild/Debug/base_unittests(_ZN7testing4Test3RunEv+0x7e) [0x82005ea] AFTER: ../sconsbuild/Debug/base_unittests(StackTrace::StackTrace()+0x20) [0x817778c] ../sconsbuild/Debug/base_unittests(StackTrace_OutputToStream_Test::TestBody()+0x18) [0x805fc98] ../sconsbuild/Debug/base_unittests(testing::Test::Run()+0x7e) [0x8200786] BUG=none TEST=manually tested. also ran base_unittests Review URL: http://codereview.chromium.org/267074 Patch from Satoru Takabayashi <satorux@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28940 0039d316-1c4b-4281-b951-d872f2087c98
* Convert SysInfo::AmountOfFreeDiskSpace from wstring to FilePath.tony@chromium.org2009-10-144-6/+9
| | | | | | | | BUG=24672 Review URL: http://codereview.chromium.org/276012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28927 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole bunch of style nits.erg@google.com2009-10-135-8/+13
| | | | | | | | (Long term intention is to add a subset of cpplint.py to the presubmit script.) Review URL: http://codereview.chromium.org/276008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
* Add API to CommandLine to get a FilePath value of a switch.evan@chromium.org2009-10-131-2/+7
| | | | | | | | | | | This is the last piece needed before I can clean up all the callers. BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/274022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28876 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate all uses of strerror() in code that uses src/base. strerror() is ↵tschmelcher@chromium.org2009-10-138-24/+16
| | | | | | | | | | | inherently unsafe in multi-threaded apps because it stores the string in a global buffer. It should never be used. If you want to log an error, use PLOG and friends, or if that's too high-level then use safe_strerror(). TEST=built on Linux in 32-bit and 64-bit mode; ran base_unittests in each case; ran Chromium itself in each case; try servers BUG=none Review URL: http://codereview.chromium.org/261055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28850 0039d316-1c4b-4281-b951-d872f2087c98
* Match window's behavior when recursively copying directories that exist.vandebo@chromium.org2009-10-132-5/+153
| | | | | | | | | | | Unit test improvement from here (sgk): http://codereview.chromium.org/271060 BUG=none TEST=unittests Review URL: http://codereview.chromium.org/270086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28838 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePathTest.StripTrailingSeparators to base_unittests to testmark@chromium.org2009-10-131-1/+64
| | | | | | | | | | FilePath::StripTrailingSeparators. BUG=24692 TEST=this Review URL: http://codereview.chromium.org/272039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28832 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make the nsimage_cache behave more like +[NSImage imageNamed:]avi@chromium.org2009-10-131-1/+7
| | | | | | | | | BUG=none TEST=no visible change Review URL: http://codereview.chromium.org/272032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28815 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 00:53:18 +0000