| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=554298
Review URL: https://codereview.chromium.org/1828923004
Cr-Commit-Position: refs/heads/master@{#383315}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Change PacketReader interface to return packet sizes as return
values instead of buffer offsets. Nonzero offsets can create unwanted
behavior for callers that depend on the data() method for accessing
the result. It is also a better fit with established net/ conventions.
* Modify PacketWriter to take buffer refptrs by const ref, reducing refcounting churn.
BUG=
R=wez@chromium.org
Review URL: https://codereview.chromium.org/1831833003
Cr-Commit-Position: refs/heads/master@{#383244}
|
|
|
|
|
|
|
|
|
|
| |
This is the third CL for enabling text input. Created protobuf ImeMessage containing text and IME related information to be sent over network. Added WebInputFeature and WebInputFeatureDelegate to handle these messages.
BUG=585646
Review URL: https://codereview.chromium.org/1779673003
Cr-Commit-Position: refs/heads/master@{#383242}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1783053002/ )
Reason for revert:
Engine crashes. https://bugs.chromium.org/p/chromium/issues/detail?id=597838
Original issue's description:
> Initial addition of Blimp engine crash client code.
>
> This introduces a simple crash client for the engine, which includes a client that will always allow and always upload crash reports with the "Chrome_Blimp_Engine" name. Crash reporting is enabled for all processes.
>
> BUG=597454
>
> Committed: https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc
> Cr-Commit-Position: refs/heads/master@{#383161}
TBR=kmarshall@chromium.org,mark@chromium.org,marcinjb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=597454
Review URL: https://codereview.chromium.org/1830393002
Cr-Commit-Position: refs/heads/master@{#383193}
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary fix to prevent resize of blimp view and at the same time be able to show the WebInputBox right above IME to enable the user to see what they type. Without resize, WebInputBox hides under IME. Current fix is to resize the view only when text input is required and resize it back after hiding IME.
BUG=596653
Review URL: https://codereview.chromium.org/1824813002
Cr-Commit-Position: refs/heads/master@{#383178}
|
|
|
|
|
|
|
|
| |
BUG=597708
Review URL: https://codereview.chromium.org/1827223002
Cr-Commit-Position: refs/heads/master@{#383177}
|
|
|
|
|
|
|
|
|
|
| |
This introduces a simple crash client for the engine, which includes a client that will always allow and always upload crash reports with the "Chrome_Blimp_Engine" name. Crash reporting is enabled for all processes.
BUG=597454
Review URL: https://codereview.chromium.org/1783053002
Cr-Commit-Position: refs/heads/master@{#383161}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the override of the ContextFactory and replaces it by just
dropping the OnAcceleratedWidgetAvailable call on the floor. This
prevents GetSharedBitmap/ResizeDisplay/CreateOutputSurface from being
called at all rather than ignoring them when they got called.
R=sievers@chromium.org,haibinlu@chromium.org
Review URL: https://codereview.chromium.org/1830293003
Cr-Commit-Position: refs/heads/master@{#383156}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the remaining copy constructors for complex classes.
After this patch, it should be possible to enable the heavy class copy
constructor checks by default.
R=thakis@chromium.org, dcheng@chromium.org
TBR=jam@chromium.org
BUG=436357
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1825273002
Cr-Commit-Position: refs/heads/master@{#383131}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The BlimpUiContextFactory handles creating surface id allocators, so
also needs to register them as being valid surfaces with the surface
manager like GpuProcessTransportFactory does.
In order to do this, the surface manager and surface id allocator
logic from content/browser/compositor/surface_utils is hoisted up
into content/public/browser so that BlimpUiContextFactory can get
at the global SurfaceManager.
This is a band-aid fix, as it's possible for existing code to create
a surface using the GpuProcessTransportFactory::GetContextFactory
(which is the GpuProcessTransportFactory itself) instead of the
ui::aura::Env::GetInstance()->GetContextFactory() which is overridden
by Blimp and is the BlimpUiContextmanager. This needs to be cleaned
up separately.
BUG=595497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1808313002
Cr-Commit-Position: refs/heads/master@{#383096}
|
|
|
|
|
|
|
|
|
|
|
|
| |
by #define-s
Xlib.h has #define Status int which conflicts with Status class in protobuf
BUG=597321
Review URL: https://codereview.chromium.org/1826073002
Cr-Commit-Position: refs/heads/master@{#382989}
|
|
|
|
|
|
|
|
| |
BUG=597026
Review URL: https://codereview.chromium.org/1823383002
Cr-Commit-Position: refs/heads/master@{#382906}
|
|
|
|
|
|
|
|
|
|
|
| |
Previously blimp_engine_bundle depended directly on blimp_engine_app,
thereby missing several necessary dependencies of the bundling step.
BUG=587247
Review URL: https://codereview.chromium.org/1830493002
Cr-Commit-Position: refs/heads/master@{#382861}
|
|
|
|
|
|
|
|
| |
See "Extensions impact on startup?" thread on (internal) chrome-fast mailing list from 8/14/2015 for background, which showed that effectively undoing this logic showed a 3% reduction on first_non_empty_paint_time. This lazy initialization used to be a performance win when it was added years ago, but has since become a performance drag. Since it's effectively not used now (since ChromeContentRendererClient::RenderThreadStarted always initializes WebKit through its call to RenderThread::RegisterExtension), just remove this unused logic.
Review URL: https://codereview.chromium.org/1821413003
Cr-Commit-Position: refs/heads/master@{#382795}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes NOTIMPLEMENTED which generate lots of Engine logs.
Issue with sending tab favicon change to Client (BlimpEngineSession::NavigationStateChanged) is now tracked by crbug.com/597094.
No need to implement BlimpUiContextFactory::ResizeDisplay/GetSharedBitmapManager/CreateOutputSurface
Review URL: https://codereview.chromium.org/1822223002
Cr-Commit-Position: refs/heads/master@{#382750}
|
|
|
|
|
|
|
|
| |
BUG=593180
Review URL: https://codereview.chromium.org/1818253003
Cr-Commit-Position: refs/heads/master@{#382721}
|
|
|
|
|
|
|
|
|
|
| |
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=442811
Review URL: https://codereview.chromium.org/1671283002
Cr-Commit-Position: refs/heads/master@{#382393}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The BlimpEngineSession now listens to LoadProgressChanged updates from
WebContents and sends these to the client. The android client shows a
progress bar to denote when the page load is finished.
BUG=589216
Review URL: https://codereview.chromium.org/1808113002
Cr-Commit-Position: refs/heads/master@{#382347}
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/1812283002
Cr-Commit-Position: refs/heads/master@{#382278}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use disable-threaded-animation command line switch for
testing purposes.
Now blink knows ahead of time, whether we support threaded animations.
See
RendererBlinkPlatformImpl::isThreadedAnimationEnabled()
BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1798503004
Cr-Commit-Position: refs/heads/master@{#381192}
|
|
|
|
|
|
|
|
| |
BUG=585646
Review URL: https://codereview.chromium.org/1802203002
Cr-Commit-Position: refs/heads/master@{#381161}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
C++:
* add hooks for intercepting network events and routing them out via
NetworkEventObserver methods.
* plumb NetworkEventObserver events to Java layer via JNI.
Java:
* display event details as Toast messages.
R=dtrainor@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1789713003
Cr-Commit-Position: refs/heads/master@{#381065}
|
|
|
|
|
|
|
|
|
|
|
| |
Also, erase LayerTreeSettings::use_compositor_animation_timelines flag.
BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1783613004
Cr-Commit-Position: refs/heads/master@{#380914}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently this information is either not captured in docs or widely spread.
This document provides the key guidelines and best practices for creating and using a new Chrome build arg.
BUG=593073
Review URL: https://codereview.chromium.org/1772213002
Cr-Commit-Position: refs/heads/master@{#380702}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes a manual roll to:
4984c3c95f18eda44492a2126c9958e447f2cca8
The Skia change is here:
https://codereview.chromium.org/1716523002/
This should also save a few rows of memory
per image.
BUG=
Review URL: https://codereview.chromium.org/1719533002
Cr-Commit-Position: refs/heads/master@{#380432}
|
|
|
|
|
|
|
|
|
|
|
| |
The engine can't be reused across connections until a session recovery protocol is in place. This CL makes the engine quit on disconnect, so that later clients will have a clean initialized state.
BUG=576342
R=maniscalco@chromium.org,wez@chromium.org
Review URL: https://codereview.chromium.org/1581563002
Cr-Commit-Position: refs/heads/master@{#380340}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#380300}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The blimp engine is currently using Linux fonts, which works well
for Linux clients. However, for Android clients, Skia should be
instructed to use Android fonts instead to ensure that the font
rendering works correctly.
This CL adds a starting set of fonts to be used, ensures that they
are part of the engine bundle, and provides documentation for how
to use them in locally hosted engines and also for how to keep the
fonts up to date.
This also updates the engine manifest and starts loading a new
dynamic library while running the engine plus fixes the documentation
for running the engine as a container.
Initial CL: https://codereview.chromium.org/1735783002/
Revert: https://codereview.chromium.org/1772343003/
BUG=585668, 588929
Review URL: https://codereview.chromium.org/1776133002
Cr-Commit-Position: refs/heads/master@{#380022}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the remote compositor we can get into a state where the LTH on the
client requests a BeginMainFrame and then releases the output surface.
The server will still send a commit but we can't push this commit till
the client initializes a new output surface.
At the same time the scheduler will not request a new output surface
till it clears the pipeline of the previous commit.
This change adds a setting to the Scheduler to allow it to request a new
output surface, while there is a commit pending. The RemoteChannelImpl
queues any protos received if the output is released and process them
when a new output surface is initialized.
BUG=586210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1691143002
Cr-Commit-Position: refs/heads/master@{#379947}
|
|
|
|
|
|
|
|
|
|
| |
This is the second CL for enabling text input from user in blimp which contains JNI part for the Java feature. Renamed the textbox to WebInputBox from TextInputFeature to be more appropriate.
BUG=585646
Review URL: https://codereview.chromium.org/1706283003
Cr-Commit-Position: refs/heads/master@{#379894}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1735783002/ )
Reason for revert:
Will change to use a single archive instead of multiple files.
Original issue's description:
> Add Android fonts to blimp engine
>
> The blimp engine is currently using Linux fonts, which works well
> for Linux clients. However, for Android clients, Skia should be
> instructed to use Android fonts instead to ensure that the font
> rendering works correctly.
>
> This CL adds a starting set of fonts to be used, ensures that they
> are part of the engine bundle, and provides documentation for how
> to use them in locally hosted engines and also for how to keep the
> fonts up to date.
>
> This also updates the engine manifest and starts loading a new
> dynamic library while running the engine plus fixes the documentation
> for running the engine as a container.
>
> BUG=585668, 588929
>
> Committed: https://crrev.com/7b1d1d89b247c0bd82d527c6ded5da4128883274
> Cr-Commit-Position: refs/heads/master@{#379734}
TBR=dpranke@chromium.org,dtrainor@chromium.org,maniscalco@chromium.org,open-source-third-party-reviews@google.com,klobag@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=585668, 588929
Review URL: https://codereview.chromium.org/1772343003
Cr-Commit-Position: refs/heads/master@{#379860}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The blimp engine is currently using Linux fonts, which works well
for Linux clients. However, for Android clients, Skia should be
instructed to use Android fonts instead to ensure that the font
rendering works correctly.
This CL adds a starting set of fonts to be used, ensures that they
are part of the engine bundle, and provides documentation for how
to use them in locally hosted engines and also for how to keep the
fonts up to date.
This also updates the engine manifest and starts loading a new
dynamic library while running the engine plus fixes the documentation
for running the engine as a container.
BUG=585668, 588929
Review URL: https://codereview.chromium.org/1735783002
Cr-Commit-Position: refs/heads/master@{#379734}
|
|
|
|
|
|
|
|
|
| |
R=haibinlu@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1770933002
Cr-Commit-Position: refs/heads/master@{#379604}
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1757093002/
This change fixes that Markdown so the new instructions appear appropriately in a code block.
BUG=
Review URL: https://codereview.chromium.org/1766533005
Cr-Commit-Position: refs/heads/master@{#379410}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently all args must be manually set per output blimp build. Blimp already uses 3 common development builds.
Using templates to define args would allow for developers to keep their args in sync more easily and would simplify blimp's gn build instructions.
BUG=
Review URL: https://codereview.chromium.org/1757093002
Cr-Commit-Position: refs/heads/master@{#379325}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and NetworkComponents.
-- Adds ThreadPipeManager for managing thread pipes and registering features across UI and IO threads.
-- Makes ThreadPipeManager not depend on NetworkComponents.
-- Adds unit test for ThreadPipeManager
BUG=574884
Review URL: https://codereview.chromium.org/1647193003
Cr-Commit-Position: refs/heads/master@{#379182}
|
|
|
|
|
|
|
|
|
|
| |
URLRequestContext.
BUG=590251
Review URL: https://codereview.chromium.org/1764493002
Cr-Commit-Position: refs/heads/master@{#379112}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL allows the Blimp client to establish TLS-protected channels with the backend engine. The authenticity of the engine is validated by checking if its cert is an exact match of a certificate provided separately by the Assigner API.
* Create new Blimp SSL transport class: SSLClientTransport.
* Create custom CertValidator for checking an exact cert match against the SSL peer's cert
* Integrate SSLClientTransport with BlimpClientSession.
* Assignment: add certificate field.
* AssignmentSource: add certificate file reading; PEM file parsing;
X509 certificate parsing.
* Created new DEPS entries as appropriate.
R=wez@chromium.org
CC=rsleevi@chromium.org
BUG=585279,589202
Committed: https://crrev.com/c80f5095f045ad1712f1f1075a44547a561f774a
Cr-Commit-Position: refs/heads/master@{#378839}
Review URL: https://codereview.chromium.org/1696563002
Cr-Commit-Position: refs/heads/master@{#379081}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1696563002/ )
Reason for revert:
Broke blimp_unittests_apk building on android:
FAILED: python "/b/build/slave/android_build/build/src/build/toolchain/gcc_solink_wrapper.py" --readelf="../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-readelf" --nm="../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-nm" --strip=../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-strip --sofile="./lib.unstripped/libblimp_client_android.so" --tocfile="./libblimp_client_android.so.TOC" --output="./libblimp_client_android.so" -- ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -fuse-ld=gold -Wl,--no-undefined -Wl,--exclude-libs=libgcc.a -Wl,--exclude-libs=libc++_static.a -Wl,--exclude-libs=libvpx_assembly_arm.a -Wl,--icf=all -Wl,--warn-shared-textrel -Wl,-O1 -Wl,--as-needed -nostdlib -Wl,--warn-shared-textrel --sysroot=../../third_party/android_tools/ndk/platforms/android-16/arch-arm -Wl,--version-script=/b/build/slave/android_build/build/src/build/android/android_no_jni_exports.lst -L../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a -o "./lib.unstripped/libblimp_client_android.so" -Wl,-soname="libblimp_client_android.so" @"./libblimp_client_android.so.rsp"
../../content/browser/android/in_process/synchronous_compositor_factory_impl.cc:125: error: undefined reference to 'content::SynchronousCompositorExternalBeginFrameSource::SynchronousCompositorExternalBeginFrameSource(int, content::SynchronousCompositorRegistry*)'
../../content/browser/android/in_process/synchronous_compositor_factory_impl.cc:113: error: undefined reference to 'content::SynchronousCompositorOutputSurface::SynchronousCompositorOutputSurface(scoped_refptr<cc::ContextProvider> const&, scoped_refptr<cc::ContextProvider> const&, int, content::SynchronousCompositorRegistry*, scoped_refptr<content::FrameSwapMessageQueue>)'
../../base/memory/ref_counted.h:193: error: undefined reference to 'content::FrameSwapMessageQueue::~FrameSwapMessageQueue()'
../../content/browser/android/in_process/synchronous_compositor_factory_impl.cc:93: error: undefined reference to 'content::SynchronousCompositorFactory::SetInstance(content::SynchronousCompositorFactory*)'
../../content/browser/android/in_process/synchronous_compositor_factory_impl.cc:197: error: undefined reference to 'content::StreamTextureFactorySynchronousImpl::Create(base::Callback<scoped_refptr<content::StreamTextureFactorySynchronousImpl::ContextProvider> ()> const&)'
../../content/browser/android/in_process/synchronous_compositor_factory_impl.cc:272: error: undefined reference to 'content::RenderThreadImpl::SetStreamTextureFactory(scoped_refptr<content::StreamTextureFactory>)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:102: error: undefined reference to 'content::SynchronousCompositorOutputSurface::SetTreeActivationCallback(base::Callback<void ()> const&)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:125: error: undefined reference to 'content::SynchronousCompositorOutputSurface::SetSyncClient(content::SynchronousCompositorOutputSurfaceClient*)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:126: error: undefined reference to 'content::SynchronousCompositorExternalBeginFrameSource::SetClient(content::SynchronousCompositorExternalBeginFrameSourceClient*)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:135: error: undefined reference to 'content::SynchronousCompositorOutputSurface::SetTreeActivationCallback(base::Callback<void ()> const&)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:141: error: undefined reference to 'content::SynchronousCompositorExternalBeginFrameSource::SetClient(content::SynchronousCompositorExternalBeginFrameSourceClient*)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:142: error: undefined reference to 'content::SynchronousCompositorOutputSurface::SetSyncClient(content::SynchronousCompositorOutputSurfaceClient*)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:178: error: undefined reference to 'content::SynchronousCompositorOutputSurface::ReturnResources(cc::CompositorFrameAck const&)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:215: error: undefined reference to 'content::SynchronousCompositorOutputSurface::SetMemoryPolicy(unsigned int)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:275: error: undefined reference to 'content::SynchronousCompositorExternalBeginFrameSource::BeginFrame(cc::BeginFrameArgs const&)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:320: error: undefined reference to 'content::SynchronousCompositorOutputSurface::GetMessagesToDeliver(std::__1::vector<scoped_ptr<IPC::Message, std::__1::default_delete<IPC::Message> >, std::__1::allocator<scoped_ptr<IPC::Message, std::__1::default_delete<IPC::Message> > > >*)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:167: error: undefined reference to 'content::SynchronousCompositorOutputSurface::DemandDrawHw(gfx::Size const&, gfx::Transform const&, gfx::Rect const&, gfx::Rect const&, gfx::Rect const&, gfx::Transform const&)'
../../content/browser/android/in_process/synchronous_compositor_impl.cc:187: error: undefined reference to 'content::SynchronousCompositorOutputSurface::DemandDrawSw(SkCanvas*)'
../../content/browser/android/in_process/synchronous_compositor_renderer_statics.cc:12: error: undefined reference to 'content::SynchronousCompositorProxy::SetSkCanvasForDraw(SkCanvas*)'
../../content/browser/android/synchronous_compositor_base.cc:32: error: undefined reference to 'content::InProcessGpuThread::InProcessGpuThread(content::InProcessChildThreadParams const&, gpu::GpuPreferences const&, gpu::SyncPointManager*)'
collect2: error: ld returned 1 exit status
Original issue's description:
> Blimp: add support for SSL connections.
>
> This CL allows the Blimp client to establish TLS-protected channels with the backend engine. The authenticity of the engine is validated by checking if its cert is an exact match of a certificate provided separately by the Assigner API.
>
> * Create new Blimp SSL transport class: SSLClientTransport.
> * Create custom CertValidator for checking an exact cert match against the SSL peer's cert
> * Integrate SSLClientTransport with BlimpClientSession.
> * Assignment: add certificate field.
> * AssignmentSource: add certificate file reading; PEM file parsing;
> X509 certificate parsing.
> * Created new DEPS entries as appropriate.
>
> R=wez@chromium.org
> CC=rsleevi@chromium.org
> BUG=585279,589202
>
> Committed: https://crrev.com/c80f5095f045ad1712f1f1075a44547a561f774a
> Cr-Commit-Position: refs/heads/master@{#378839}
TBR=wez@chromium.org,dtrainor@chromium.org,rsesek@chromium.org,rsleevi@chromium.org,kmarshall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=585279,589202
Review URL: https://codereview.chromium.org/1757153002
Cr-Commit-Position: refs/heads/master@{#378892}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL allows the Blimp client to establish TLS-protected channels with the backend engine. The authenticity of the engine is validated by checking if its cert is an exact match of a certificate provided separately by the Assigner API.
* Create new Blimp SSL transport class: SSLClientTransport.
* Create custom CertValidator for checking an exact cert match against the SSL peer's cert
* Integrate SSLClientTransport with BlimpClientSession.
* Assignment: add certificate field.
* AssignmentSource: add certificate file reading; PEM file parsing;
X509 certificate parsing.
* Created new DEPS entries as appropriate.
R=wez@chromium.org
CC=rsleevi@chromium.org
BUG=585279,589202
Review URL: https://codereview.chromium.org/1696563002
Cr-Commit-Position: refs/heads/master@{#378839}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blimp uses target_os=chromeos to avoid dependencies (e.g. X11) that are the default on linux, but will be unavailable in a docker container.
However this causes a host of other changes to the resulting binary that are not desired (e.g. crash reporting flow).
This change uses target_os='linux' with the unsupported dependencies turned off. It will work within a docker container without the unwanted binary changes.
BUG=589166, 590816
Review URL: https://codereview.chromium.org/1751433002
Cr-Commit-Position: refs/heads/master@{#378794}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This application is bound to an individual profile data dir. While it
isn't yet sandboxed to that location, that's our long term intention
with this design. This application colocates the Profile service and the
LevelDB service so that these will be in the same process.
The way we register a Browser Context to a user id works for now, but
will need to be redone once we start spawning processes for the Profile.
BUG=585587
Review URL: https://codereview.chromium.org/1741953002
Cr-Commit-Position: refs/heads/master@{#378620}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add detailed logging support for BlimpMessage and subtypes.
* Create FieldExtractor interface for classes which can extract
loggable content from BlimpMessages.
* Implement FieldExtractors for most BlimpMessage types.
* Add BlimpMessageLogger class to manage FieldExtractors
and serialize log messages.
* Add unit tests to verify log output of most BlimpMessage types.
R=dtrainor@chromium.org,haibinlu@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1741943002
Cr-Commit-Position: refs/heads/master@{#378573}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#378350}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Even though the encoding of WebP on the blimp engine uses an alpha
channel, the encoder itself might decide that the encoded image should
be without an alpha channel if the value is 255 throughout the whole
image.
This means that we can not assume on the decoding side that there
will always be an alpha-channel for the input.
We can still decide that the decoding output should use an alpha
channel though, so the colorspace of the decoding buffer does
not have to change because of this.
BUG=589272
Review URL: https://codereview.chromium.org/1742893002
Cr-Commit-Position: refs/heads/master@{#378296}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix minor name mismatch on "navigation_state_changed" BlimpMessage field.
It was "navigation_state_change". This CL adds the missing "d".
R=dtrainor@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1740093003
Cr-Commit-Position: refs/heads/master@{#378056}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the error in generating MotionEvents and WebGestureEvents on
android which were causing incorrect resolution of touch targets on the
client and the engine.
Also increase the max payload size to 1MB since the compositor messages
can be large right now.
BUG=589323
Review URL: https://codereview.chromium.org/1739563004
Cr-Commit-Position: refs/heads/master@{#377938}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because Engine is built under Linux, the default OS info string is "X11; Linux x86_64", which causes a website to provide its desktop version.
By spoofing Android OS, mobile versions will be provided by websites.
Right now, the Android version is hardcoded. We should use Client's Android version (crbug.com/589917)
BUG=589882
Review URL: https://codereview.chromium.org/1742493002
Cr-Commit-Position: refs/heads/master@{#377665}
|
|
|
|
|
|
|
|
| |
BUG=496258
Review URL: https://codereview.chromium.org/1718333002
Cr-Commit-Position: refs/heads/master@{#377653}
|
|
|
|
|
|
|
|
|
|
| |
No functional changes.
BUG=546953
Review URL: https://codereview.chromium.org/1730533002
Cr-Commit-Position: refs/heads/master@{#377549}
|