| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
breakpad_unittests and sandbox_linux_unittests
R=thestig@chromium.org, jbudorick@chromium.org, jorgelo@chromium.org
BUG=344868
TEST=Turn on components build (component=shared_library) ensure that
breakpad_unittests and sandbox_linux_unittests are starting
(breakpad_unittests_deps and sandbox_linux_unittests_deps targets
correspondingly)
Review URL: https://codereview.chromium.org/655543005
Cr-Commit-Position: refs/heads/master@{#301797}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This picks up the microdump refactoring and updates the gyp/gn
makefiles accordingly.
SVN changes picked up by this roll:
r1388: Microdumps: refactor out common parts of minidump_writer.cc
BUG=410294
Review URL: https://codereview.chromium.org/602403002
Cr-Commit-Position: refs/heads/master@{#297635}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Configure Breakpad to run in-process on Yosemite by setting the
BREAKPAD_IN_PROCESS option.
Roll breakpad r1359 -> r1375.
r1375 Mac: Add support for in-process crash reporting to Breakpad.
r1374 This CL initialize NSData in HTTPMultipartUpload.m to nil.
r1373 Update processor.gyp file with new files added as part of microdump
r1372 Introduce stub microdump processor classes.
r1371 Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd.
r1370 Extract DumpContext base class from MinidumpContext
r1369 Back out trunk r1367.
r1368 Adding possibility for client to upload the file
r1367 Support for multiple upload files in CrashReportSender/HTTPUpload
r1366 constructor init list in wrong order in CrashGenerationServer
r1365 update svn:ignore
r1364 make "make install" also install headers and pkgconfig files
r1363 Set 32 bits iOS app to use vm_region_recurse_64.
r1362 update svn:ignore lists
r1361 Update lss from r24 to r31.
r1360 upload_system_symbols: Use the Go1.3 improvements to debug/macho.
BUG=414239
Review URL: https://codereview.chromium.org/571663002
Cr-Commit-Position: refs/heads/master@{#295094}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
breakpad_client builds fine for daisy with and without this flag,
so might as well not pass it, for consistency with 288830.
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/458743006
Cr-Commit-Position: refs/heads/master@{#288856}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, every gyp file that wanted to set clang warnings had to check
for clang==1 and then set cflags and xcode_settings.WARNING_CFLAGS. Factor
this out, so that targets only need to set clang_warning_flags for warnings
that apply to all platforms. (Per-platform flags still need to be set manually.)
This removes existing duplication from gyp files, and prevents adding more
duplication when trying to add the same warning flags for clang/win.
BUG=82385
R=hans@chromium.org, scottmg@chromium.org
TBR=various owners
Review URL: https://codereview.chromium.org/437543007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Comment the breakpad gyp file.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/413863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
r1319: Change PrintFunctions to print functions in address order.
r1320: Linux: Check the CRC32 of the debug link file in the symbol dumper.
r1321: Clean up common.gypi.
Review URL: https://codereview.chromium.org/253783004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=354405,346626
Review URL: https://codereview.chromium.org/229653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GTM isn't necessary for iOS's breakpad client.
BUG=339495
TEST=None
Review URL: https://codereview.chromium.org/139203006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows the test runner to not depend on the STRIP env var, which is going away.
Other approaches considered:
1. Converting the remaining exe-based tests to apk tests. The apk versions
were slower, and didn't pass without other changes though.
2. Just don't strip. But that slows down these two tests by over 100%
(due to copying data to the device is slow, and stripped size is 0.5MB while
unstripped size is on the order of 10MB).
3. Try to get a trip binary from third_party/android_tools/ndk. That's fiddly
since it requires getting the right arch.
Since there are only two exe-based tests left, just strip them from gyp.
Medium-term, maybe gyp/mac's postbuild stuff can be brought to android,
it looks like there are various things that could be made simpler with that.
BUG=142642
TEST=
build/android/test_runner.py gtest -s sandbox_linux_unittests &&
build/android/test_runner.py gtest -s breakpad_unittests
R=bulach@chromium.org, frankf@chromium.org
TBR=jln, thestig
Review URL: https://codereview.chromium.org/157743004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add myself to the AUTHORS file.
BUG=
Review URL: https://codereview.chromium.org/142573006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead we add a gyp file in third_party/google_toolbox_for_mac to build
the sources from third_party/GTM. This is the third and last patch in
this series.
BUG=299841
TEST=None
R=mark@chromium.org,ben@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/107933006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With chromium r238524 breakpad was rolled to r1240. In breakpad r1240 the
file auto_testfile.h was removed. This CL removes this file from the gyp
file for breakpad in chromium.
R=blundell@chromium.org, mark@chromium.org
Review URL: https://codereview.chromium.org/104913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r1240: Add missing #include of eintr_wrapper.h to auto_testfile.h.
r1239: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.
r1238: Re-enable ios_exception_minidump_generator being built on non-ARM.
r1237: Fix BREAKPAD_OUTPUT_DUMP_FILE on iOS.
r1236: Process minidumps generated on ARM64 in iOS apps.
r1235: Generate minidumps for 64-bit ARM apps on iOS.
Review URL: https://codereview.chromium.org/102103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, minidump_stackwalk produces far more debug output than
actual output.
BUG=none
R=mark@chromium.org
Review URL: https://codereview.chromium.org/59163005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r1230 (mac sender) NSLocalizedString compatibility (10.8 SDK and clang trunk -Wformat-extra-args).
r1229 (processor) map_serializers_unittest: fix unused variable warning.
r1228 (linux symupload) Print response code when sym_upload fails.
r1227 (processor) Add some symbols missing from last commit.
r1226 (processor) Add simple exploitability analysis for Linux crashes.
r1225 (common) Switch to scoped_array instead of inappropriate scoped_ptr.
r1224 (linux handler) Increase exception handler stack size for dumping thread.
r1223 (mac handler) Remove define of mach_vm_region from mach_vm_compatibility.h.
BUG=314109
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/60293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add missing header location for linux_dumper_unittest_helper for Android. It
is required to correctly locate sgidefs.h.
In addition, this change removes duplicate '-ldl', since the order of listed
libraries is important for GNU ld (still used for some architectures such as
MIPS).
BUG= fail to build breakpad tests for MIPS
TEST= build breakpad tests MIPS-Android
Review URL: https://codereview.chromium.org/26006002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring the latest changes from breakpad that include support for MIPS. Includes the following changes:
"r1213: Fix for a clang error"
"r1212: Adding support for mips."
Update breakpad/breakpad.gyp with new files too.
BUG= Build for MIPS-Chromium breaks without support in breakpad
TEST=trybots
Review URL: https://chromiumcodereview.appspot.com/23527005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See thread "[chromium-dev] PSA: Breakpad is now compiled into
Chromium by default on Linux' for background
TBR=sbc@chromium.org, thakis@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/18770006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When iOS builds support ninja and enable GYP_CROSSCOMPILE=1, ninja
will build breakpad, protoc and iossim using host arch instead
of the sub-out-ninja workaround.
TBR=mark@chromium.org
BUG=236517
Review URL: https://chromiumcodereview.appspot.com/14597007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from http://breakpad.appspot.com/299001 that never got committed upstream.
Testing shows that these changes are no longer necessary, and maintaining the
fork of these files has been cumbersome. This change also brings in new
Windows dump_syms and symupload binaries.
This also updates Breakpad to r1178, picking up:
------------------------------------------------------------------------
r1178 | mark@chromium.org | 2013-05-09 17:56:18 -0400 (Thu, 09 May 2013) | 3 lines
Fix following r1175: the section name is __debug_info, not .debug_info.
Review URL: https://breakpad.appspot.com/583003
------------------------------------------------------------------------
r1177 | chrisha@chromium.org | 2013-05-09 12:29:56 -0400 (Thu, 09 May 2013) | 9 lines
Check in new Windows binaries.
These binaries include recent changes to pdb_source_line_writer for handling
PDBs with OMAP data. They were built using the GYP build files, MSVS 2010 and
DIA SDK 8.0.
Review URL: https://breakpad.appspot.com/584002/
------------------------------------------------------------------------
r1176 | thestig@chromium.org | 2013-05-08 16:24:03 -0400 (Wed, 08 May 2013) | 5 lines
Mac: Fix more errors from clang to get crash_report.xcodeproj close to compiling.
R=thestig@chromium.org
Review URL: https://breakpad.appspot.com/593002
------------------------------------------------------------------------
r1175 | thestig@chromium.org | 2013-05-08 13:41:12 -0400 (Wed, 08 May 2013) | 5 lines
Fix mac dump_syms after r1163.
Review URL: https://breakpad.appspot.com/592002
------------------------------------------------------------------------
TEST=Mac crash reports should have good stacks. So should Windows crash
reports.
Review URL: https://codereview.chromium.org/14876014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=qsr
Review URL: https://chromiumcodereview.appspot.com/15026007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Based on https://codereview.chromium.org/13864007/
BUG=77656
Review URL: https://codereview.chromium.org/14744007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77656
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14192004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r1146: Fix build on Android - add a missing NT_GNU_BUILD_ID define.
r1145: Remove auto_ptr usage in Breakpad.
r1144: Turn off verbose logging but keep logic for future reference for debug logging.
r1143: Try to find a build-id through PT_NOTE program headers
r1142: Support generic Elf notes, with unit tests
r1141: Refactor BasicElf synth_elf unitest
r1140: These are prerequisites needed for a wider effort inside Google to enable
structured logging. This is basically wrapping std::ostream within a new type.
No functional differences from this change are expected.
Review URL: https://codereview.chromium.org/13820025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
With https://code.google.com/p/google-breakpad/source/detail?r=1096
breakpad's scoped_ptr.h moved to common. Update gyp file so that IDEs
have the correct location for this file in their projects.
Review URL: https://codereview.chromium.org/12334114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Previously, these would only be built on Linux and Android with
linux_breakpad==1. These can be built now on Mac.
Review URL: https://chromiumcodereview.appspot.com/11418122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111541
R=thestig@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11347046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several auxiliary tools used when building Chrome for iOS are generated via the
following two-step pattern: (1) compiling the executable with ninja, and (2)
copying the executable into a location that is shared with other projects.
Previously, these two steps were specified as actions in the same target.
However, as the ordering of multiple actions in one target is defined only by
inputs and outputs and the compilation action had no inputs/outputs set, the
copying action wasn't properly depending on the compilation action.
As it's challenging to set correct inputs for the ninja build, this CL
separates these actions into two targets in order to be able to specify that
the second action should not run until the first action finishes.
Review URL: https://chromiumcodereview.appspot.com/11301003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
overcommitting registers.
Review URL: https://chromiumcodereview.appspot.com/11198019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark
Review URL: https://chromiumcodereview.appspot.com/11110005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11098059
Reverting because it caused a linker error on the "iOS Device" bot.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/11118007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11098059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The file itself was added in August but the gyp file doesn't point
to it upstream.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11038050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Removed redundant toolset line which is already set for Android below.
TBR=mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10907002
TBR=mmoss@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10910002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10907002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings in fixes to the Android unit tests.
You can quickly test this with:
. build/android/envsetup.sh
GYP_DEFINES="$GYP_DEFINES linux_breakpad=1"
android_gyp
make out/Debug/breakpad_unittests
adb push out/Debug/breakpad_unittests /data/local/tmp/breakpad_unittests
adb shell /data/local/tmp/breakpad_unittests
BUG=
Review URL: https://chromiumcodereview.appspot.com/10875048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the generic support for bouncing iOS dependencies through
ninja to build breakpad utilities, as is done for other host-targetted
utilities needed for iOS builds.
The built utilities are copied to the non-ninja output locations, so that
the bots can find them the same way they do for a Mac build.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10855263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breakpad uses a custom version of GTMLogger to work around a toolchain
bug in Xcode 4.2; this bug isn't present in 4.3, which iOS Chromium
requires.
Using a custom GTMLogger causes problems when any other code also uses
GTMLogger, so this instead exports the third-party version as a
linker dependency (where it can be harmlessly de-dup'd).
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10823433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android NDK toolchain doesn't support it.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10824330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138571
TBR=tony
Review URL: https://chromiumcodereview.appspot.com/10855238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rolling the DEPS of Breakpad in order to get the file descriptor support for
generating minidumps, it is needed on Android.
BUG=None
TEST=Breakpad unit-tests should compile and run.
Review URL: https://chromiumcodereview.appspot.com/10825329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10832007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137676
TEST=none
TBR=mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NaCl again
BUG=137676
TEST=none
TBR=deps
Review URL: https://chromiumcodereview.appspot.com/10808107
TBR=rsesek@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10816042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137676
TEST=none
TBR=deps
Review URL: https://chromiumcodereview.appspot.com/10808107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting because we believe it is causing Windows NaCL builds to fail.
BUG=137676
TEST=none
TBR=deps
Review URL: https://chromiumcodereview.appspot.com/10805065
TBR=rsesek@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10806095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137676
TEST=none
TBR=deps
Review URL: https://chromiumcodereview.appspot.com/10805065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add two NULL parameters to CrashGenerationServer ctor to match the new prototype (changed in r952)
Add the files appeared in r945 to breakpad.gyp
BUG=127776,132164
TEST=remoting_unittests.BreakpadWinDeathTest.*
Review URL: https://chromiumcodereview.appspot.com/10544121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142200 0039d316-1c4b-4281-b951-d872f2087c98
|