| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3112019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Official Mac bot builds.
TBR=mark
Review URL: http://codereview.chromium.org/3176020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids a link error due to missing dependencies to stuff defined in
test_assembler.cc.
BUG=none
TEST=dump_syms links
Review URL: http://codereview.chromium.org/2873058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Chromium r52958.
BUG=none
TEST=official build
Review URL: http://codereview.chromium.org/3008012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Convert files in .nib format to .xib format.
BUG=38443
TEST=none
Review URL: http://codereview.chromium.org/2854020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2335006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2355004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2397002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
with "shared_library".
Review URL: http://codereview.chromium.org/2388001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GYP files that's needed by r583, but not defined in Chrome. Since Chrome uses its own GYP files for breakpad, we have to duplicate the definition.
Submitting on behalf of hansl@google.com, original change at http://codereview.chromium.org/2290001/show.
BUG=None
TEST=None
TBR=siggi@chromium.org
Review URL: http://codereview.chromium.org/2257006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that's needed by r583, but not defined in Chrome. Since Chrome uses its own GYP files for breakpad, we have to duplicate the definition.
Submitting on behalf of hansl@google.com, original change at http://codereview.chromium.org/2290001/show.
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2113020
TBR=zhurunz@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2113020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
I had left over .o files in my out/ directory so the last change didn't catch
everything.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Looks like I lost a GYP define after a gclient sync and didn't notice
that I got some paths wrong in breakpad.gyp.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
http://codereview.chromium.org/1589017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
invalid argument CRT reports are generated to allow sorting those dumps by stack signature.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1418001
TBR=siggi@chromium.org
Review URL: http://codereview.chromium.org/1556003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
considering the alternatives, I've decided that it's not terrible. This code
does not make it into the Chrome build, it's only used for the symbol dumper.
BUG=none
TEST=Mac official build
Review URL: http://codereview.chromium.org/1535005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CRT reports are generated to allow sorting those dumps by stack signature.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1418001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for x64 on Windows
TEST=none
BUG=29467
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35012
Review URL: http://codereview.chromium.org/501127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
files moved in Breakpad r446, and the .gyp file should have been modified when
Breakpad was updated from r432 to r452 in our r34916.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/504077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
better support for x64 on Windows
TEST=none
BUG=29467
Review URL: http://codereview.chromium.org/501127
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/500149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for x64 on Windows
TEST=none
BUG=29467
Review URL: http://codereview.chromium.org/501127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is required for supporting NaCl on 64-bit Windows. breakpad_handler and breakpad_sender targets now have 32-bit and 64-bit versions.
Review URL: http://codereview.chromium.org/464027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28276
TEST=dump_syms works with ToT Chrome.
Review URL: http://codereview.chromium.org/414049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
without -fexceptions in upstream r417.
BUG=24911 (because this also eliminates some C++ exception symbols from the
symbol table)
TEST=none
Review URL: http://codereview.chromium.org/267129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to avoid Application Verifier errors on some corner cases.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support. (Try 2)
TEST=none
BUG=19663
Original Review URL: http://codereview.chromium.org/173095
Review URL: http://codereview.chromium.org/173397
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It seemed that r24220 caused failures on all of Linux UI (valgrind) bots.
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/173345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
support.
TEST=none
BUG=19663
Review URL: http://codereview.chromium.org/173095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
build, where C++ exceptions are already disabled.
BUG=19094 12248
TEST=Mac release-mode Google Chrome.app should shrink by about 6MB.
Mac disk image should shrink by about 1.5MB.
Linux binary and package should shrink too.
Review URL: http://codereview.chromium.org/165330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes the need for separate build runs with different hammer flags (e.g.
--mode=Tool).
Review URL: http://codereview.chromium.org/125009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
allow dump_syms to access DWARF data for line numbers and other stuff, and not
just public symbol table data.
BUG=12776
TEST=set branding to Chrome, dsymutil should run and take forever
Review URL: http://codereview.chromium.org/113999
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
memory instead of MD5 of text section.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
leiz reports that it doesn't build: missing assert.h. Since it's
breakpad code I'm not going to fork it just for this.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
See comment in the patch.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commits a rewrite of the Breakpad Linux client.
The old code:
* Had a number of plain bugs in it, but those could just have been
fixed.
* Allocated memory from the heap, which is a no go.
* Made libc calls which can enter the dynamic linker - another source
of crashes.
* Didn't understand some of the tricks needed, like clone() via libc
will write to random areas of memory because it assumes that it's
only called from libpthread
Additionally, we had one more requirement which meant changing the
interface:
* We need to be able to crash dump the renderers from the browser
process.
And that last one really needed a rewrite.
We intend to try and upstream this new code into Breakpad.
The new Breakpad design works like this:
When a renderer crashes, a signal handler runs on an alternative stack
and collects information about the registers of the thread before the
crash. Then we enter Chromium specific code an send a datagram message
to a magic file descriptor (4) containing:
* the registers and tid of the crashing thread
* the active URL
* a file descriptor to a socket
* a CREDENTIALS structure giving the PID of the renderer.
On the other end of the socket is an object on the IO thread
(render_crash_handler_host_linux.cc) which reads and parses the
datagram. The CREDENTIALS structure is validated by the kernel, so the
renderer can't lie about it's PID and try and get the browser to crash
dump the wrong process.
The browser then ptraces the renderer and extracts all the needed
information to write a minidump to a temp file. Then we write a byte
to the file descriptor which the renderer gave the browser in the
datagram and that's the signal to the renderer to finish dying. It
dies by sending itself the same signal which trigger the crash dump in
the first place, so it will appear to crash as normal as far as kernel
core dumps and waitpid are concerned.
The browser then constucts a MIME message in a temp file for upload to
the crash service. We then fork out to /usr/bin/wget to actually do
the upload (since Debian numbers suggest that 99.8% of users have wget
installed.) A second forked child unlinks the temp files once wget has
completed.
For a browser crash, everything works pretty much the same except that
the datagram step is omitted and we clone() off a process to ptrace
ourselves and write the minidump.
This code is only enabled in Chrome branded builds. Stub source files
are substituted in the case of a Chromium build.
http://codereview.chromium.org/115526
BUG=9646,10772
TEST=Build a Chrome branded binary. Send SEGV to a renderer and verify that wget output appears on stderr. Send a SEGV to the main binary and verify the same.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
string based.
Review URL: http://codereview.chromium.org/115510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(out of build/temp_gyp)
Review URL: http://codereview.chromium.org/113352
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Compile OS X dump_syms & symupload utilities from the public repository to simplify the branded builder.
* Correct comment in breakpad_mac_stubs.mm so it more accurately reflects reality.
Review URL: http://codereview.chromium.org/113114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Link agasint Breakpad from public svn repo.
* Bump DEPS to new svn rev of Breakpad with fixes for 10.5 compilation.
* Fill in code to differentiate between processes types in crash report.
Review URL: http://codereview.chromium.org/88043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/87014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14110 0039d316-1c4b-4281-b951-d872f2087c98
|