| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead we add a gyp file in third_party/google_toolbox_for_mac to build
the sources from third_party/GTM. This is the third and last patch in
this series.
BUG=299841
TEST=None
R=mark@chromium.org,ben@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/107933006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With chromium r238524 breakpad was rolled to r1240. In breakpad r1240 the
file auto_testfile.h was removed. This CL removes this file from the gyp
file for breakpad in chromium.
R=blundell@chromium.org, mark@chromium.org
Review URL: https://codereview.chromium.org/104913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r1240: Add missing #include of eintr_wrapper.h to auto_testfile.h.
r1239: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.
r1238: Re-enable ios_exception_minidump_generator being built on non-ARM.
r1237: Fix BREAKPAD_OUTPUT_DUMP_FILE on iOS.
r1236: Process minidumps generated on ARM64 in iOS apps.
r1235: Generate minidumps for 64-bit ARM apps on iOS.
Review URL: https://codereview.chromium.org/102103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, minidump_stackwalk produces far more debug output than
actual output.
BUG=none
R=mark@chromium.org
Review URL: https://codereview.chromium.org/59163005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r1230 (mac sender) NSLocalizedString compatibility (10.8 SDK and clang trunk -Wformat-extra-args).
r1229 (processor) map_serializers_unittest: fix unused variable warning.
r1228 (linux symupload) Print response code when sym_upload fails.
r1227 (processor) Add some symbols missing from last commit.
r1226 (processor) Add simple exploitability analysis for Linux crashes.
r1225 (common) Switch to scoped_array instead of inappropriate scoped_ptr.
r1224 (linux handler) Increase exception handler stack size for dumping thread.
r1223 (mac handler) Remove define of mach_vm_region from mach_vm_compatibility.h.
BUG=314109
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/60293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add missing header location for linux_dumper_unittest_helper for Android. It
is required to correctly locate sgidefs.h.
In addition, this change removes duplicate '-ldl', since the order of listed
libraries is important for GNU ld (still used for some architectures such as
MIPS).
BUG= fail to build breakpad tests for MIPS
TEST= build breakpad tests MIPS-Android
Review URL: https://codereview.chromium.org/26006002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring the latest changes from breakpad that include support for MIPS. Includes the following changes:
"r1213: Fix for a clang error"
"r1212: Adding support for mips."
Update breakpad/breakpad.gyp with new files too.
BUG= Build for MIPS-Chromium breaks without support in breakpad
TEST=trybots
Review URL: https://chromiumcodereview.appspot.com/23527005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See thread "[chromium-dev] PSA: Breakpad is now compiled into
Chromium by default on Linux' for background
TBR=sbc@chromium.org, thakis@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/18770006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When iOS builds support ninja and enable GYP_CROSSCOMPILE=1, ninja
will build breakpad, protoc and iossim using host arch instead
of the sub-out-ninja workaround.
TBR=mark@chromium.org
BUG=236517
Review URL: https://chromiumcodereview.appspot.com/14597007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from http://breakpad.appspot.com/299001 that never got committed upstream.
Testing shows that these changes are no longer necessary, and maintaining the
fork of these files has been cumbersome. This change also brings in new
Windows dump_syms and symupload binaries.
This also updates Breakpad to r1178, picking up:
------------------------------------------------------------------------
r1178 | mark@chromium.org | 2013-05-09 17:56:18 -0400 (Thu, 09 May 2013) | 3 lines
Fix following r1175: the section name is __debug_info, not .debug_info.
Review URL: https://breakpad.appspot.com/583003
------------------------------------------------------------------------
r1177 | chrisha@chromium.org | 2013-05-09 12:29:56 -0400 (Thu, 09 May 2013) | 9 lines
Check in new Windows binaries.
These binaries include recent changes to pdb_source_line_writer for handling
PDBs with OMAP data. They were built using the GYP build files, MSVS 2010 and
DIA SDK 8.0.
Review URL: https://breakpad.appspot.com/584002/
------------------------------------------------------------------------
r1176 | thestig@chromium.org | 2013-05-08 16:24:03 -0400 (Wed, 08 May 2013) | 5 lines
Mac: Fix more errors from clang to get crash_report.xcodeproj close to compiling.
R=thestig@chromium.org
Review URL: https://breakpad.appspot.com/593002
------------------------------------------------------------------------
r1175 | thestig@chromium.org | 2013-05-08 13:41:12 -0400 (Wed, 08 May 2013) | 5 lines
Fix mac dump_syms after r1163.
Review URL: https://breakpad.appspot.com/592002
------------------------------------------------------------------------
TEST=Mac crash reports should have good stacks. So should Windows crash
reports.
Review URL: https://codereview.chromium.org/14876014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=qsr
Review URL: https://chromiumcodereview.appspot.com/15026007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Based on https://codereview.chromium.org/13864007/
BUG=77656
Review URL: https://codereview.chromium.org/14744007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77656
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14192004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r1146: Fix build on Android - add a missing NT_GNU_BUILD_ID define.
r1145: Remove auto_ptr usage in Breakpad.
r1144: Turn off verbose logging but keep logic for future reference for debug logging.
r1143: Try to find a build-id through PT_NOTE program headers
r1142: Support generic Elf notes, with unit tests
r1141: Refactor BasicElf synth_elf unitest
r1140: These are prerequisites needed for a wider effort inside Google to enable
structured logging. This is basically wrapping std::ostream within a new type.
No functional differences from this change are expected.
Review URL: https://codereview.chromium.org/13820025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
With https://code.google.com/p/google-breakpad/source/detail?r=1096
breakpad's scoped_ptr.h moved to common. Update gyp file so that IDEs
have the correct location for this file in their projects.
Review URL: https://codereview.chromium.org/12334114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Previously, these would only be built on Linux and Android with
linux_breakpad==1. These can be built now on Mac.
Review URL: https://chromiumcodereview.appspot.com/11418122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111541
R=thestig@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11347046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several auxiliary tools used when building Chrome for iOS are generated via the
following two-step pattern: (1) compiling the executable with ninja, and (2)
copying the executable into a location that is shared with other projects.
Previously, these two steps were specified as actions in the same target.
However, as the ordering of multiple actions in one target is defined only by
inputs and outputs and the compilation action had no inputs/outputs set, the
copying action wasn't properly depending on the compilation action.
As it's challenging to set correct inputs for the ninja build, this CL
separates these actions into two targets in order to be able to specify that
the second action should not run until the first action finishes.
Review URL: https://chromiumcodereview.appspot.com/11301003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
overcommitting registers.
Review URL: https://chromiumcodereview.appspot.com/11198019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark
Review URL: https://chromiumcodereview.appspot.com/11110005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11098059
Reverting because it caused a linker error on the "iOS Device" bot.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/11118007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11098059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The file itself was added in August but the gyp file doesn't point
to it upstream.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11038050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Removed redundant toolset line which is already set for Android below.
TBR=mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10907002
TBR=mmoss@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10910002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10907002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings in fixes to the Android unit tests.
You can quickly test this with:
. build/android/envsetup.sh
GYP_DEFINES="$GYP_DEFINES linux_breakpad=1"
android_gyp
make out/Debug/breakpad_unittests
adb push out/Debug/breakpad_unittests /data/local/tmp/breakpad_unittests
adb shell /data/local/tmp/breakpad_unittests
BUG=
Review URL: https://chromiumcodereview.appspot.com/10875048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the generic support for bouncing iOS dependencies through
ninja to build breakpad utilities, as is done for other host-targetted
utilities needed for iOS builds.
The built utilities are copied to the non-ninja output locations, so that
the bots can find them the same way they do for a Mac build.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10855263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breakpad uses a custom version of GTMLogger to work around a toolchain
bug in Xcode 4.2; this bug isn't present in 4.3, which iOS Chromium
requires.
Using a custom GTMLogger causes problems when any other code also uses
GTMLogger, so this instead exports the third-party version as a
linker dependency (where it can be harmlessly de-dup'd).
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10823433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android NDK toolchain doesn't support it.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10824330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138571
TBR=tony
Review URL: https://chromiumcodereview.appspot.com/10855238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rolling the DEPS of Breakpad in order to get the file descriptor support for
generating minidumps, it is needed on Android.
BUG=None
TEST=Breakpad unit-tests should compile and run.
Review URL: https://chromiumcodereview.appspot.com/10825329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10832007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137676
TEST=none
TBR=mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NaCl again
BUG=137676
TEST=none
TBR=deps
Review URL: https://chromiumcodereview.appspot.com/10808107
TBR=rsesek@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10816042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137676
TEST=none
TBR=deps
Review URL: https://chromiumcodereview.appspot.com/10808107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting because we believe it is causing Windows NaCL builds to fail.
BUG=137676
TEST=none
TBR=deps
Review URL: https://chromiumcodereview.appspot.com/10805065
TBR=rsesek@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10806095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137676
TEST=none
TBR=deps
Review URL: https://chromiumcodereview.appspot.com/10805065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add two NULL parameters to CrashGenerationServer ctor to match the new prototype (changed in r952)
Add the files appeared in r945 to breakpad.gyp
BUG=127776,132164
TEST=remoting_unittests.BreakpadWinDeathTest.*
Review URL: https://chromiumcodereview.appspot.com/10544121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: symupload got broken
BUG=127776
TBR=mark
Review URL: https://chromiumcodereview.appspot.com/10377108
TBR=glider@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10398022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add two NULL parameters to CrashGenerationServer ctor to match the new prototype (changed in r952)
Add the files appeared in r945 to breakpad.gyp
BUG=127776
TBR=mark
Review URL: https://chromiumcodereview.appspot.com/10377108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Third time is a charm.
Original Reviews:
https://chromiumcodereview.appspot.com/9838033/
http://codereview.chromium.org/9967017
Revert "Revert 131593"
This reverts commit e306ea7f630d4264075913ea3a1a728d98ca9605.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9960072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculatively reverting due to gyp update error on official bots:
KeyError: 'src/breakpad/breakpad.gyp:dump_syms#target while trying to load target src/remoting/remoting.gyp:remoting_linux_symbols#target'
This is the only patch in the regression range that touches breakpad.gyp.
---
Upstream Android native crash handling changes.
This is actulaly the second time.
Revert "Revert 131404 - Upstream native crash handling changes for Android."
This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba.
Conflicts:
chrome/browser/chrome_browser_main.cc
BUG=
TEST=
Review URL: http://codereview.chromium.org/9967017
TBR=carlosvaldivia@google.com
Review URL: https://chromiumcodereview.appspot.com/10037013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is actulaly the second time.
Revert "Revert 131404 - Upstream native crash handling changes for Android."
This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba.
Conflicts:
chrome/browser/chrome_browser_main.cc
BUG=
TEST=
Review URL: http://codereview.chromium.org/9967017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android native crash handling is almost identical to linux handling with
some differences.
Note that even after this change Chrome on Android will not compile with
the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should
remedy this state of affairs.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9838033
TBR=carlosvaldivia@google.com
Review URL: https://chromiumcodereview.appspot.com/9999004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android native crash handling is almost identical to linux handling with
some differences.
Note that even after this change Chrome on Android will not compile with
the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should
remedy this state of affairs.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9838033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
916: Creating minidump for uncaught exception on iOS.
917: Add missing include. (iOS)
918: Avoid setting an alternative stack for signals if there's already one (linux)
919: Add filename to error when PDBSourceLineWriter::Open fails (win)
920: Add some missing #includes
921: Add a bootstrap_register() wrapper to fix deprecation warnings (mac)
922: Move away from the 10.4 SDK. (mac)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9433023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
903: Build LinuxLibcSupportTest and make it pass. (test-only)
904: Skip ElfCoreDumpTest.ValidCoreFile test if no core dump is generated. (linux)
905: Implement core dump to minidump conversion. (linux / chromeos)
906: Use sys_prctl instead of prctl. (linux)
907: Fix several clang warnings in breakpad. (mac)
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9290055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
CrOS's branch. Cleanup some whitespaces while we're at it.
Review URL: http://codereview.chromium.org/9158035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=mark@chromium.org,benchan@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9021040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115614 0039d316-1c4b-4281-b951-d872f2087c98
|