summaryrefslogtreecommitdiffstats
path: root/breakpad
Commit message (Collapse)AuthorAgeFilesLines
* Update breakpad to 888 to correct compilation warnings.qsr@chromium.org2011-11-241-2/+2
| | | | | | | | | BUG=105053 TEST=Compiling breakpad tests does not generate issues about mktemp Review URL: http://codereview.chromium.org/8681010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111502 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad to rev: 886.qsr@chromium.org2011-11-211-1/+1
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/8595014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110931 0039d316-1c4b-4281-b951-d872f2087c98
* Make dump_syms 64-bit on Mac.mark@chromium.org2011-10-311-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | The framework's grown to the point that 32-bit dump_syms no longer has enough memory to do its job. It is failing with messages like: dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug terminate called after throwing an instance of 'St9bad_alloc' what(): std::bad_alloc Moving to 64-bit gives it more space to work with. 64-bit dump_syms is able to dump 32-bit files. BUG=102361 TEST=Breakpad-enabled official release builds Review URL: http://codereview.chromium.org/8409009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107947 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r864, picking up some Mac refactorings and adjusting themark@chromium.org2011-10-111-0/+2
| | | | | | | | build configuration appropriately. This update also contains Clang warning fixes and allows Breakpad's checkout in Chrome to pull its svn:externals. Review URL: http://codereview.chromium.org/8233018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104934 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r842, picking up:mark@chromium.org2011-10-032-46/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ------------------------------------------------------------------------ r842 | mark@chromium.org | 2011-10-03 15:54:28 -0400 (Mon, 03 Oct 2011) | 11 lines Use a bootstrap subset port for the inspector, tying the subset to the lifetime of the task to be monitored, the invoking task. This allows the bootstrap server (in launchd) to automatically clean up the Mach server registration when the task being monitored exits, avoiding leaks of com.Breakpad.Inspector(pid) ports in "launchctl bslist". BUG=chromium:28547 TEST=Handler should still crash catches, but inspector ports should no longer show up in "launchctl bslist". They should show up under a subset port in "launchctl bstree" instead. "launchctl bstree" must be invoked as root. Review URL: http://breakpad.appspot.com/306001 ------------------------------------------------------------------------ This gives each Breakpad instance its own bootstrap subset port as a subset of the process' bootstrap port, and places the Breakpad inspector port into the bootstrap subset port. This completely eliminates leaks of on-demand Mach services advertised via the bootstrap server. This also reverts r34318 and r34534, "temporary" (21-month) hacks to mitigate the leak. The temporary hacks were never completely effective against Breakpad ports leaking from child processes. DestructCrashReporter at process shutdown was deemed unnecessary and is being removed. As this was the last caller to that function, the implementation is removed as well. This is addressed in Breakpad rather than Chrome because a mechanism to fix it without changing the process' bootstrap port was discovered. It was determined that the rohitfork port is already immune to leaks of the sort that the Breakpad inspector port experiences. A previous attempt to fix this bug was r103089, but that caused bug 98550. This strategy is safer. The forked Breakpad module.cc is updated to match upstream r835, which allows the unforking of the CFI-disabling code. A new CFI-disabling "-c" option to dump_syms is now available and used by the dump_product_syms script. BUG=28547 TEST=1. "launchctl bslist" should no longer show on-demand com.Breakpad.Inspector ports (in Breakpad-enabled builds with Breakpad on) ports. 2. "launchctl bstree" (as root) should reveal a bootstrap subset for each process as a child of the per-user/per-session bootstrap namespace if crash reporting is on. One com.Breakpad.Inspector port should show up as a child of each bootstrap subset. As each process exits (even if mercilessly killed by "kill -9"), the associated subsets and inspector ports should disappear. 3. Breakpad reports should be generated on crashes. For example, about:crash and about:inducebrowsercrashforrealz should each cause a minidump to be written in ~/Library/Application Support/Google/Chrome/Crash Reports when Breakpad is enabled. This tests that the Breakpad ports are functioning properly. 4. The browser process should be able to access child process data. Window:Task Manager should show valid values for the Memory, CPU, and Network columns for all child processes. This tests that the rohitfork port is functioning properly. Note that this version of the change does not change the handling of rohitfork ports at all, but this test case was useful in a previous version of this patch. 5. Test case from bug 98550: Have a link in a web browser window (in a different browser) and drag it into Chrome. Expect the drag operation to operate properly in both the tab strip and in web content. See bug 98550 for details. 6. Unreported test case that failed in r103089: browser relaunch should work. Visit chrome://flags, change some flags to get the "Relaunch Now" button at the bottom (you can put the flags back to how you found them initially), and click "Relaunch Now". The browser should close and then be relaunched. Review URL: http://codereview.chromium.org/8120007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103778 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PIE for dump_syms. The framework is too big to reliably be able tomark@chromium.org2011-09-081-0/+6
| | | | | | | | | | | mmap it in a 32-bit process with PIE on. There may not be a big enough gap in the address space to mmap it. BUG=none TEST=none Review URL: http://codereview.chromium.org/7840040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100149 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of <iostream> where unnecessary.evan@chromium.org2011-09-011-1/+1
| | | | | | | | | | | | | | Any file which uses <iostream> gains a static initializer, which is both disallowed by our style guide and also harms startup performance. Note that Chrome's logging.h uses <ostream> (note missing "i"), which includes the << operators for logging but does *not* use cin/cout. This is fine. BUG=94794 Review URL: http://codereview.chromium.org/7811002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99237 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r828 to pick up:mark@chromium.org2011-08-261-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ------------------------------------------------------------------------ r828 | mark@chromium.org | 2011-08-26 18:29:33 -0400 (Fri, 26 Aug 2011) | 8 lines Fix a Breakpad crash during teardown when USE_PROTECTED_ALLOCATIONS is in effect. BUG=none TEST=Apple Crash Reporter logs from processes in which Breakpad handles the crash should point the finger at the actual crash source, not the Breakpad thread's attempt to write to unwritable memory. Review URL: http://breakpad.appspot.com/301001 ------------------------------------------------------------------------ r827 | mark@chromium.org | 2011-08-26 17:37:59 -0400 (Fri, 26 Aug 2011) | 5 lines Add missing (parentehses.) BUG=247, chromium:94107 TEST=Minidump file sizes should be manageable Review URL: http://breakpad.appspot.com/300002 ------------------------------------------------------------------------ This also enables USE_PROTECTED_ALLOCATIONS. This should have been on all along because we're using Breakpad through the Framework/Breakpad.mm interface, which requires it. Note that if we ought not have been using USE_PROTECTED_ALLOCATIONS, the build would fail. BUG=94107 TEST=Breakpad should upload reasonably-sized minidump files. Apple Crash Reporter logs from processes in which Breakpad handles the crash should point the finger at the actual crash source, not the Breakpad thread's attempt to write to unwritable memory. Review URL: http://codereview.chromium.org/7761007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98505 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily remove STACK CFI lines from Breakpad dump_syms symbol files.mark@chromium.org2011-08-241-0/+5
| | | | | | | | BUG=google-breakpad:443 TEST=Better-looking, more thorough stacks produced on the crash server Review URL: http://codereview.chromium.org/7714022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97967 0039d316-1c4b-4281-b951-d872f2087c98
* Make Breakpad dump_syms compatible with DWARF produced by clang.mark@chromium.org2011-08-195-2/+3460
| | | | | | | | | | | | | | | | | | | This adds the changes in http://breakpad.appspot.com/299001 to a "pending" area of our tree so that we can move forward with the clang switchover in advance of finding someone to review the upstream change. (The change is largeish and there aren't too many people qualified to review it.) As soon as the patch is reviewed and lands upstream, I'll switch us back over to using it. I've only changed Mac dump_syms, because nobody on Linux has asked for this yet. BUG=google-breakpad:441, 91371 TEST=Do an official build with clang. Breakpad dump_syms should produce usable output. It should not produce any warnings. Review URL: http://codereview.chromium.org/7692005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97500 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix for Linux official builds following r94352.mark@chromium.org2011-07-271-0/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7482027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94365 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r819 to remove its OpenSSL libcrypto dependency.mark@chromium.org2011-07-271-4/+2
| | | | | | | | | | | BUG=90665 TEST=otool -L '/Applications/Google Chrome Canary.app/Contents/Versions/14.0.837.0/Google Chrome Framework.framework/Google Chrome Framework' | grep libcrypto should not show any output once this is fixed. You must run this on an official build such as a canary. Unofficial builds do not include Breakpad and thus should not show this library. Review URL: http://codereview.chromium.org/7477046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94352 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the comments setting emands and vim tab width and expansion variables.tony@chromium.org2011-07-111-6/+0
| | | | | | | | | | | | | | | | | These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS to breakpad.thakis@chromium.org2011-07-021-0/+2
| | | | | | | | | | BUG=88315 TEST=none Review URL: http://codereview.chromium.org/7289053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91433 0039d316-1c4b-4281-b951-d872f2087c98
* Remove msvs_guids from app, base, breakpad and build.tony@chromium.org2011-06-131-2/+0
| | | | | | | | BUG=28727 Review URL: http://codereview.chromium.org/7108053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88871 0039d316-1c4b-4281-b951-d872f2087c98
* Remove files that don't exist, and fix typos in gyp filessadrul@chromium.org2011-05-251-2/+0
| | | | | | | | | BUG=none TEST=things still work Review URL: http://codereview.chromium.org/6990028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86533 0039d316-1c4b-4281-b951-d872f2087c98
* Globally replace <(library) with static_libraryevan@chromium.org2011-05-193-9/+9
| | | | | | | | | | | We provided <(library) as a variable to support a peculiar build configuration on Linux. We no longer support that build configuration, so we can simplify this code to no longer use a variable. Review URL: http://codereview.chromium.org/7051014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 64-bit Breakpad build when building for target_arch=ia32.thestig@chromium.org2011-05-131-0/+1
| | | | | | | | BUG=none TEST=chrome on chromeos builder goes green. Review URL: http://codereview.chromium.org/6973061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85321 0039d316-1c4b-4281-b951-d872f2087c98
* See http://codereview.chromium.org/6901037/. Same CL but to ToT.raymes@chromium.org2011-04-281-0/+6
| | | | | | Review URL: http://codereview.chromium.org/6880262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83271 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r786 to pick up:mark@chromium.org2011-04-051-0/+1
| | | | | | | | Use task_info(..., TASK_DYLD_INFO, ...) on 10.6 and later in preference to looking up the _dyld_all_image_infos symbol in /usr/lib/dyld. Review URL: http://codereview.chromium.org/6693096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80480 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang warning / miscompilethakis@chromium.org2011-01-241-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6271005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72364 0039d316-1c4b-4281-b951-d872f2087c98
* Breakpad: Include src/client/mac/handler/breakpad_nlist_64.cc in the build.thestig@chromium.org2011-01-121-1/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6115010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71251 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new breakpad target that is built in a manner suitable for use in a ↵robertshield@chromium.org2011-01-101-6/+26
| | | | | | | | | | | DLL. Specifically, do NOT #define BREAKPAD_NO_TERMINATE_THREAD in this new target since that makes crash reporting shutdown racy and crash-prone. BUG=68536 TEST=NONE Review URL: http://codereview.chromium.org/6102001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70898 0039d316-1c4b-4281-b951-d872f2087c98
* scons: excise more scons references from the code baseevan@chromium.org2010-12-031-1/+1
| | | | | | | | | | I got to undo some hacks, too! TEST=compiles Review URL: http://codereview.chromium.org/5535003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68119 0039d316-1c4b-4281-b951-d872f2087c98
* Save real .dSYMs for Breakpad's crash_inspector and crash_report_sender.app mark@chromium.org2010-10-071-0/+6
| | | | | | | | | | | | | for proper debugging and Breakpadding. Dump symbols for Breakpad for these new files and for libffmpegsumo.dylib, and save all of their .dSYMs in the .dSYM archive. BUG=58310 TEST=none Review URL: http://codereview.chromium.org/3516022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61808 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Breakpad r697:r700.thestig@chromium.org2010-09-261-2/+2
| | | | | | | | BUG=none TEST=official builds work properly. Review URL: http://codereview.chromium.org/3417024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60593 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix linux_syscall_support #include path for generate-test-dump.cc.thestig@chromium.org2010-09-241-1/+1
| | | | | | | | | BUG=none TEST=none TBR=markus Review URL: http://codereview.chromium.org/3402033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60545 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Breakpad r692:r697, try 3.thestig@chromium.org2010-09-231-0/+25
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3432019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60320 0039d316-1c4b-4281-b951-d872f2087c98
* Breakpad DEPS roll 657:692thestig@chromium.org2010-09-171-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3460005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59766 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59753 - Linux Breakpad: Update #include in generate-test-dump.cc.inferno@chromium.org2010-09-171-1/+1
| | | | | | | | | | | | BUG=none TEST=none TBR=markus Review URL: http://codereview.chromium.org/3419006 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/3407006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59754 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Breakpad: Update #include in generate-test-dump.cc.thestig@chromium.org2010-09-161-1/+1
| | | | | | | | | BUG=none TEST=none TBR=markus Review URL: http://codereview.chromium.org/3419006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59753 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable symbol dumping on 64-bit Breakpad.thestig@chromium.org2010-08-311-2/+2
| | | | | | | | BUG=20737 TEST=none Review URL: http://codereview.chromium.org/3213005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58050 0039d316-1c4b-4281-b951-d872f2087c98
* Update symupload.exe to r659 from breakpad treeeblake@chromium.org2010-08-201-0/+0
| | | | | | | | | | | Hopefully has options to produce more logging info to help debug upload problem BUG=None TEST=None Review URL: http://codereview.chromium.org/3158025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56879 0039d316-1c4b-4281-b951-d872f2087c98
* Allow minidump-2-core to be built from gypmarkus@chromium.org2010-08-191-0/+13
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3112019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56692 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Speculative fix following the Breakpad roll to r657.thestig@chromium.org2010-08-191-0/+2
| | | | | | | | | BUG=none TEST=Official Mac bot builds. TBR=mark Review URL: http://codereview.chromium.org/3176020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56664 0039d316-1c4b-4281-b951-d872f2087c98
* Resync dump_syms binary in breakpad.gyp with upstream.mnissler@chromium.org2010-07-231-2/+0
| | | | | | | | | | | | This avoids a link error due to missing dependencies to stuff defined in test_assembler.cc. BUG=none TEST=dump_syms links Review URL: http://codereview.chromium.org/2873058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53444 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad.gyp for Mac compatibility with Breakpad r627 as used bymark@chromium.org2010-07-201-5/+25
| | | | | | | | | | Chromium r52958. BUG=none TEST=official build Review URL: http://codereview.chromium.org/3008012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53041 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r609 to pick up:mark@chromium.org2010-06-241-1/+1
| | | | | | | | | | Convert files in .nib format to .xib format. BUG=38443 TEST=none Review URL: http://codereview.chromium.org/2854020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50764 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Remove invalid gyp settings.thestig@chromium.org2010-06-142-10/+0
| | | | | | | | BUG=45067 TEST=gyp r827 works on Windows. Review URL: http://codereview.chromium.org/2718014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49713 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break due to breakpad gyp missing stabs_to_module.*zhurunz@google.com2010-05-291-0/+2
| | | | | | Review URL: http://codereview.chromium.org/2335006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48564 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break due to dump_stabs/breakpad.zhurunz@google.com2010-05-291-2/+0
| | | | | | Review URL: http://codereview.chromium.org/2355004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48563 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break in breakpad.zhurunz@google.com2010-05-291-0/+7
| | | | | | Review URL: http://codereview.chromium.org/2397002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48562 0039d316-1c4b-4281-b951-d872f2087c98
* Sync to latest breakpad which don't have deps on libglog. Be able to build ↵zhurunz@google.com2010-05-281-0/+6
| | | | | | | | with "shared_library". Review URL: http://codereview.chromium.org/2388001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48539 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 48397 - Upgrade the breakpad deps to r600. Includes a #define in the ↵siggi@chromium.org2010-05-271-6/+0
| | | | | | | | | | | | | | | GYP files that's needed by r583, but not defined in Chrome. Since Chrome uses its own GYP files for breakpad, we have to duplicate the definition. Submitting on behalf of hansl@google.com, original change at http://codereview.chromium.org/2290001/show. BUG=None TEST=None TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/2257006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48407 0039d316-1c4b-4281-b951-d872f2087c98
* Upgrade the breakpad deps to r600. Includes a #define in the GYP files ↵siggi@chromium.org2010-05-271-0/+6
| | | | | | | | | | | | that's needed by r583, but not defined in Chrome. Since Chrome uses its own GYP files for breakpad, we have to duplicate the definition. Submitting on behalf of hansl@google.com, original change at http://codereview.chromium.org/2290001/show. BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48397 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad to make it build with new files from upstream.zhurunz@google.com2010-05-221-1/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47985 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47955 - Update breakpad to make it build with new files from upstream.skrul@chromium.org2010-05-211-7/+1
| | | | | | | | Review URL: http://codereview.chromium.org/2113020 TBR=zhurunz@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47962 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad to make it build with new files from upstream.zhurunz@google.com2010-05-211-1/+7
| | | | | | Review URL: http://codereview.chromium.org/2113020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47955 0039d316-1c4b-4281-b951-d872f2087c98
* Breakpad: sort unittests and add file_id_unittest.ccagl@chromium.org2010-04-051-3/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43668 0039d316-1c4b-4281-b951-d872f2087c98
* Fix breakpad (again)agl@chromium.org2010-04-051-2/+2
| | | | | | | I had left over .o files in my out/ directory so the last change didn't catch everything. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43662 0039d316-1c4b-4281-b951-d872f2087c98