| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=105053
TEST=Compiling breakpad tests does not generate issues about mktemp
Review URL: http://codereview.chromium.org/8681010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8595014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The framework's grown to the point that 32-bit dump_syms no longer has enough
memory to do its job. It is failing with messages like:
dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12)
*** error: can't allocate region
*** set a breakpoint in malloc_error_break to debug
dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12)
*** error: can't allocate region
*** set a breakpoint in malloc_error_break to debug
dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12)
*** error: can't allocate region
*** set a breakpoint in malloc_error_break to debug
terminate called after throwing an instance of 'St9bad_alloc'
what(): std::bad_alloc
Moving to 64-bit gives it more space to work with. 64-bit dump_syms is able to
dump 32-bit files.
BUG=102361
TEST=Breakpad-enabled official release builds
Review URL: http://codereview.chromium.org/8409009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
build configuration appropriately. This update also contains Clang warning
fixes and allows Breakpad's checkout in Chrome to pull its svn:externals.
Review URL: http://codereview.chromium.org/8233018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------------------------------------------------------------------------
r842 | mark@chromium.org | 2011-10-03 15:54:28 -0400 (Mon, 03 Oct 2011) | 11 lines
Use a bootstrap subset port for the inspector, tying the subset to the
lifetime of the task to be monitored, the invoking task. This allows the
bootstrap server (in launchd) to automatically clean up the Mach server
registration when the task being monitored exits, avoiding leaks of
com.Breakpad.Inspector(pid) ports in "launchctl bslist".
BUG=chromium:28547
TEST=Handler should still crash catches, but inspector ports should no longer
show up in "launchctl bslist". They should show up under a subset port in
"launchctl bstree" instead. "launchctl bstree" must be invoked as root.
Review URL: http://breakpad.appspot.com/306001
------------------------------------------------------------------------
This gives each Breakpad instance its own bootstrap subset port as a subset
of the process' bootstrap port, and places the Breakpad inspector port into
the bootstrap subset port.
This completely eliminates leaks of on-demand Mach services advertised via the
bootstrap server.
This also reverts r34318 and r34534, "temporary" (21-month) hacks to mitigate
the leak. The temporary hacks were never completely effective against Breakpad
ports leaking from child processes.
DestructCrashReporter at process shutdown was deemed unnecessary and is being
removed. As this was the last caller to that function, the implementation is
removed as well.
This is addressed in Breakpad rather than Chrome because a mechanism to fix it
without changing the process' bootstrap port was discovered. It was determined
that the rohitfork port is already immune to leaks of the sort that the
Breakpad inspector port experiences. A previous attempt to fix this bug was
r103089, but that caused bug 98550. This strategy is safer.
The forked Breakpad module.cc is updated to match upstream r835, which allows
the unforking of the CFI-disabling code. A new CFI-disabling "-c" option to
dump_syms is now available and used by the dump_product_syms script.
BUG=28547
TEST=1. "launchctl bslist" should no longer show on-demand
com.Breakpad.Inspector ports (in Breakpad-enabled builds with Breakpad
on) ports.
2. "launchctl bstree" (as root) should reveal a bootstrap subset for each
process as a child of the per-user/per-session bootstrap namespace if
crash reporting is on. One com.Breakpad.Inspector port should show up
as a child of each bootstrap subset. As each process exits (even if
mercilessly killed by "kill -9"), the associated subsets and inspector
ports should disappear.
3. Breakpad reports should be generated on crashes. For example,
about:crash and about:inducebrowsercrashforrealz should each cause a
minidump to be written in
~/Library/Application Support/Google/Chrome/Crash Reports
when Breakpad is enabled. This tests that the Breakpad ports are
functioning properly.
4. The browser process should be able to access child process data.
Window:Task Manager should show valid values for the Memory, CPU, and
Network columns for all child processes. This tests that the rohitfork
port is functioning properly. Note that this version of the change
does not change the handling of rohitfork ports at all, but this test
case was useful in a previous version of this patch.
5. Test case from bug 98550: Have a link in a web browser window (in a
different browser) and drag it into Chrome. Expect the drag operation
to operate properly in both the tab strip and in web content. See bug
98550 for details.
6. Unreported test case that failed in r103089: browser relaunch should
work. Visit chrome://flags, change some flags to get the "Relaunch Now"
button at the bottom (you can put the flags back to how you found them
initially), and click "Relaunch Now". The browser should close and then
be relaunched.
Review URL: http://codereview.chromium.org/8120007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mmap it in a 32-bit process with PIE on. There may not be a big enough gap in
the address space to mmap it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7840040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Any file which uses <iostream> gains a static initializer, which is both
disallowed by our style guide and also harms startup performance.
Note that Chrome's logging.h uses <ostream> (note missing "i"), which includes
the << operators for logging but does *not* use cin/cout. This is fine.
BUG=94794
Review URL: http://codereview.chromium.org/7811002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------------------------------------------------------------------------
r828 | mark@chromium.org | 2011-08-26 18:29:33 -0400 (Fri, 26 Aug 2011) | 8 lines
Fix a Breakpad crash during teardown when USE_PROTECTED_ALLOCATIONS is in
effect.
BUG=none
TEST=Apple Crash Reporter logs from processes in which Breakpad handles the
crash should point the finger at the actual crash source, not the
Breakpad thread's attempt to write to unwritable memory.
Review URL: http://breakpad.appspot.com/301001
------------------------------------------------------------------------
r827 | mark@chromium.org | 2011-08-26 17:37:59 -0400 (Fri, 26 Aug 2011) | 5 lines
Add missing (parentehses.)
BUG=247, chromium:94107
TEST=Minidump file sizes should be manageable
Review URL: http://breakpad.appspot.com/300002
------------------------------------------------------------------------
This also enables USE_PROTECTED_ALLOCATIONS. This should have been on all
along because we're using Breakpad through the Framework/Breakpad.mm
interface, which requires it. Note that if we ought not have been using
USE_PROTECTED_ALLOCATIONS, the build would fail.
BUG=94107
TEST=Breakpad should upload reasonably-sized minidump files.
Apple Crash Reporter logs from processes in which Breakpad handles the
crash should point the finger at the actual crash source, not the
Breakpad thread's attempt to write to unwritable memory.
Review URL: http://codereview.chromium.org/7761007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=google-breakpad:443
TEST=Better-looking, more thorough stacks produced on the crash server
Review URL: http://codereview.chromium.org/7714022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the changes in http://breakpad.appspot.com/299001 to a "pending"
area of our tree so that we can move forward with the clang switchover in
advance of finding someone to review the upstream change. (The change is
largeish and there aren't too many people qualified to review it.) As soon as
the patch is reviewed and lands upstream, I'll switch us back over to using
it.
I've only changed Mac dump_syms, because nobody on Linux has asked for this
yet.
BUG=google-breakpad:441, 91371
TEST=Do an official build with clang. Breakpad dump_syms should produce usable
output. It should not produce any warnings.
Review URL: http://codereview.chromium.org/7692005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7482027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=90665
TEST=otool -L '/Applications/Google Chrome Canary.app/Contents/Versions/14.0.837.0/Google Chrome Framework.framework/Google Chrome Framework' | grep libcrypto
should not show any output once this is fixed. You must run this on an
official build such as a canary. Unofficial builds do not include Breakpad
and thus should not show this library.
Review URL: http://codereview.chromium.org/7477046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were added in r28089 (http://codereview.chromium.org/256059) but
are unnecessary bloat for everyone to carry around, even those that don't
use emacs or vim.
In an earlier change, I added editor config files in src/tools/emacs/
and src/tools/vim/ so users of the appropriate editor can source those
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7310019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88315
TEST=none
Review URL: http://codereview.chromium.org/7289053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28727
Review URL: http://codereview.chromium.org/7108053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=things still work
Review URL: http://codereview.chromium.org/6990028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We provided <(library) as a variable to support a peculiar
build configuration on Linux. We no longer support that build
configuration, so we can simplify this code to no longer use
a variable.
Review URL: http://codereview.chromium.org/7051014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=chrome on chromeos builder goes green.
Review URL: http://codereview.chromium.org/6973061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6880262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Use task_info(..., TASK_DYLD_INFO, ...) on 10.6 and later in preference to
looking up the _dyld_all_image_infos symbol in /usr/lib/dyld.
Review URL: http://codereview.chromium.org/6693096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6271005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6115010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DLL. Specifically, do NOT #define BREAKPAD_NO_TERMINATE_THREAD in this new target since that makes crash reporting shutdown racy and crash-prone.
BUG=68536
TEST=NONE
Review URL: http://codereview.chromium.org/6102001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I got to undo some hacks, too!
TEST=compiles
Review URL: http://codereview.chromium.org/5535003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for proper debugging and Breakpadding.
Dump symbols for Breakpad for these new files and for libffmpegsumo.dylib, and
save all of their .dSYMs in the .dSYM archive.
BUG=58310
TEST=none
Review URL: http://codereview.chromium.org/3516022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=official builds work properly.
Review URL: http://codereview.chromium.org/3417024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=markus
Review URL: http://codereview.chromium.org/3402033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3432019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3460005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=markus
Review URL: http://codereview.chromium.org/3419006
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/3407006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=markus
Review URL: http://codereview.chromium.org/3419006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20737
TEST=none
Review URL: http://codereview.chromium.org/3213005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Hopefully has options to produce more logging info to help debug upload problem
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3158025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3112019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Official Mac bot builds.
TBR=mark
Review URL: http://codereview.chromium.org/3176020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids a link error due to missing dependencies to stuff defined in
test_assembler.cc.
BUG=none
TEST=dump_syms links
Review URL: http://codereview.chromium.org/2873058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Chromium r52958.
BUG=none
TEST=official build
Review URL: http://codereview.chromium.org/3008012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Convert files in .nib format to .xib format.
BUG=38443
TEST=none
Review URL: http://codereview.chromium.org/2854020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=45067
TEST=gyp r827 works on Windows.
Review URL: http://codereview.chromium.org/2718014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2335006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2355004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2397002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
with "shared_library".
Review URL: http://codereview.chromium.org/2388001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GYP files that's needed by r583, but not defined in Chrome. Since Chrome uses its own GYP files for breakpad, we have to duplicate the definition.
Submitting on behalf of hansl@google.com, original change at http://codereview.chromium.org/2290001/show.
BUG=None
TEST=None
TBR=siggi@chromium.org
Review URL: http://codereview.chromium.org/2257006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that's needed by r583, but not defined in Chrome. Since Chrome uses its own GYP files for breakpad, we have to duplicate the definition.
Submitting on behalf of hansl@google.com, original change at http://codereview.chromium.org/2290001/show.
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2113020
TBR=zhurunz@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2113020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
I had left over .o files in my out/ directory so the last change didn't catch
everything.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43662 0039d316-1c4b-4281-b951-d872f2087c98
|