summaryrefslogtreecommitdiffstats
path: root/breakpad
Commit message (Collapse)AuthorAgeFilesLines
* Fix overlay for breakpad.qsr@chromium.org2013-02-053-133/+24
| | | | | | | | | | | | | | Version 1091 of breakpad change signature of some methods that were overlayed, resulting in the wrong method being called and preventing file and line number to be computed. R=mark@chromium.org BUG=174340 Review URL: https://chromiumcodereview.appspot.com/12213014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180727 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling nacl_win64 targets when building in target_arch!=ia32 mode.bradnelson@google.com2013-01-212-2/+10
| | | | | | | | | | | | | | | | When building on windows with target_arch=x64, we no longer need win32 targets forced to be 64-bit. This gates out these targets when target_arch!=ia32. (Prior CL dropped the minimal set to break the dependency between these targets and the rest of the build. This eliminates them completely.) BUG=None TEST=None R=jschuh@chromium.org,thestig@chromium.org TBR=darin@chromium.org,abodenha@chromium.org,apatrick@chromium.org,sra@chromium.org,wtc@chromium.org Review URL: https://chromiumcodereview.appspot.com/11929039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177959 0039d316-1c4b-4281-b951-d872f2087c98
* Build minidump_stackwalk and minidump_dump on all supported platforms.rsesek@chromium.org2012-11-212-161/+131
| | | | | | | | | | Previously, these would only be built on Linux and Android with linux_breakpad==1. These can be built now on Mac. Review URL: https://chromiumcodereview.appspot.com/11418122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169148 0039d316-1c4b-4281-b951-d872f2087c98
* breakpad: Build breakpad_client target as static_library.tfarina@chromium.org2012-10-311-1/+1
| | | | | | | | | | BUG=111541 R=thestig@chromium.org Review URL: https://chromiumcodereview.appspot.com/11347046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165082 0039d316-1c4b-4281-b951-d872f2087c98
* Specify dependences correctly when building mac tools for iOS.blundell@chromium.org2012-10-291-2/+23
| | | | | | | | | | | | | | | | | | | Several auxiliary tools used when building Chrome for iOS are generated via the following two-step pattern: (1) compiling the executable with ninja, and (2) copying the executable into a location that is shared with other projects. Previously, these two steps were specified as actions in the same target. However, as the ordering of multiple actions in one target is defined only by inputs and outputs and the compilation action had no inputs/outputs set, the copying action wasn't properly depending on the compilation action. As it's challenging to set correct inputs for the ninja build, this CL separates these actions into two targets in order to be able to specify that the second action should not run until the first action finishes. Review URL: https://chromiumcodereview.appspot.com/11301003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164743 0039d316-1c4b-4281-b951-d872f2087c98
* Allow building Official Chrome builds in Debug on ARM by avoiding ↵fischman@chromium.org2012-10-171-0/+5
| | | | | | | | overcommitting registers. Review URL: https://chromiumcodereview.appspot.com/11198019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162414 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Breakpad 1052:1069 (try 2, add missing mac files to breakpad.gyp)thestig@chromium.org2012-10-121-12/+17
| | | | | | | | TBR=mark Review URL: https://chromiumcodereview.appspot.com/11110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161524 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 161434 - Roll DEPS for Breakpad 1052:1069.falken@chromium.org2012-10-121-10/+7
| | | | | | | | | | | Review URL: https://codereview.chromium.org/11098059 Reverting because it caused a linker error on the "iOS Device" bot. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/11118007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161469 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Breakpad 1052:1069.thestig@chromium.org2012-10-111-7/+10
| | | | | | Review URL: https://codereview.chromium.org/11098059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161434 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Add source file to gypdfalcantara@chromium.org2012-10-051-0/+3
| | | | | | | | | | | | The file itself was added in August but the gyp file doesn't point to it upstream. BUG= Review URL: https://chromiumcodereview.appspot.com/11038050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160509 0039d316-1c4b-4281-b951-d872f2087c98
* Re-Fix official Linux builds, broken by missing symupload.mmoss@chromium.org2012-08-301-1/+0
| | | | | | | | | | Removed redundant toolset line which is already set for Android below. TBR=mark@chromium.org Review URL: https://chromiumcodereview.appspot.com/10913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154083 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 154068 - Fix official Linux builds, broken by missing symupload.karen@chromium.org2012-08-301-5/+1
| | | | | | | | | | | TBR=mark@chromium.org Review URL: https://chromiumcodereview.appspot.com/10907002 TBR=mmoss@chromium.org Review URL: https://chromiumcodereview.appspot.com/10910002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154079 0039d316-1c4b-4281-b951-d872f2087c98
* Fix official Linux builds, broken by missing symupload.mmoss@chromium.org2012-08-301-1/+5
| | | | | | | | TBR=mark@chromium.org Review URL: https://chromiumcodereview.appspot.com/10907002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154068 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Breakpad to release 1020digit@chromium.org2012-08-281-3/+17
| | | | | | | | | | | | | | | | | | | This brings in fixes to the Android unit tests. You can quickly test this with: . build/android/envsetup.sh GYP_DEFINES="$GYP_DEFINES linux_breakpad=1" android_gyp make out/Debug/breakpad_unittests adb push out/Debug/breakpad_unittests /data/local/tmp/breakpad_unittests adb shell /data/local/tmp/breakpad_unittests BUG= Review URL: https://chromiumcodereview.appspot.com/10875048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153653 0039d316-1c4b-4281-b951-d872f2087c98
* Use mac_build.gypi to build breakpad utilities on iOSstuartmorgan@chromium.org2012-08-211-0/+67
| | | | | | | | | | | | | | | This uses the generic support for bouncing iOS dependencies through ninja to build breakpad utilities, as is done for other host-targetted utilities needed for iOS builds. The built utilities are copied to the non-ninja output locations, so that the bots can find them the same way they do for a Mac build. BUG=None Review URL: https://chromiumcodereview.appspot.com/10855263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152624 0039d316-1c4b-4281-b951-d872f2087c98
* Use the shared GTMLogger for iOS breakpad buildsstuartmorgan@chromium.org2012-08-211-18/+17
| | | | | | | | | | | | | | | | | Breakpad uses a custom version of GTMLogger to work around a toolchain bug in Xcode 4.2; this bug isn't present in 4.3, which iOS Chromium requires. Using a custom GTMLogger causes problems when any other code also uses GTMLogger, so this instead exports the third-party version as a linker dependency (where it can be harmlessly de-dup'd). BUG=None Review URL: https://chromiumcodereview.appspot.com/10823433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152577 0039d316-1c4b-4281-b951-d872f2087c98
* Disable compiler option 'mimplicit-it' for Android ARMyongsheng.zhu@intel.com2012-08-201-1/+2
| | | | | | | | | | | | Android NDK toolchain doesn't support it. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10824330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152315 0039d316-1c4b-4281-b951-d872f2087c98
* linux/clang: Disable the last two warnings, turn on -Werrorthakis@chromium.org2012-08-181-0/+8
| | | | | | | | | BUG=138571 TBR=tony Review URL: https://chromiumcodereview.appspot.com/10855238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152242 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling the DEPS of Breakpad.jcivelli@chromium.org2012-08-152-8/+12
| | | | | | | | | | | | | Rolling the DEPS of Breakpad in order to get the file descriptor support for generating minidumps, it is needed on Android. BUG=None TEST=Breakpad unit-tests should compile and run. Review URL: https://chromiumcodereview.appspot.com/10825329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151612 0039d316-1c4b-4281-b951-d872f2087c98
* Update license tool to check several additional directoriessteveblock@chromium.org2012-08-091-1/+1
| | | | | | | | | | | | | | | | Some of these directories are currently excluded from the license check. This change fixes the metadata where required and removes them from PRUNE_PATHS. Other directories contain third-party code, but aren't in directories named 'third-party', so aren't checked by the license tool by default. This change fixes the metadata where required and adds them to ADDITIONAL_PATHS. To avoid adding to about:credits licenses for modules that don't ship as part of the product, this change also introduces a special 'NOT_SHIPPED' value for the 'License File' field. This will simplify the process of adding a tool to check license compatibility for the Android WebView build. BUG=138921 Review URL: https://chromiumcodereview.appspot.com/10830201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150800 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling breakpad on iOS.noyau@chromium.org2012-07-251-0/+76
| | | | | | | | | | BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10832007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148329 0039d316-1c4b-4281-b951-d872f2087c98
* Roll breakpad DEPS r977:998rsesek@chromium.org2012-07-251-0/+9
| | | | | | | | | | BUG=137676 TEST=none TBR=mark@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148327 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 148171 - Roll breakpad DEPS r977:996rsesek@chromium.org2012-07-241-9/+0
| | | | | | | | | | | | | | | NaCl again BUG=137676 TEST=none TBR=deps Review URL: https://chromiumcodereview.appspot.com/10808107 TBR=rsesek@chromium.org Review URL: https://chromiumcodereview.appspot.com/10816042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148185 0039d316-1c4b-4281-b951-d872f2087c98
* Roll breakpad DEPS r977:996rsesek@chromium.org2012-07-241-0/+9
| | | | | | | | | | BUG=137676 TEST=none TBR=deps Review URL: https://chromiumcodereview.appspot.com/10808107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148171 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 148133 - Roll breakpad DEPS r977:995acolwell@chromium.org2012-07-241-9/+0
| | | | | | | | | | | | | | | Reverting because we believe it is causing Windows NaCL builds to fail. BUG=137676 TEST=none TBR=deps Review URL: https://chromiumcodereview.appspot.com/10805065 TBR=rsesek@chromium.org Review URL: https://chromiumcodereview.appspot.com/10806095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148154 0039d316-1c4b-4281-b951-d872f2087c98
* Roll breakpad DEPS r977:995rsesek@chromium.org2012-07-241-0/+9
| | | | | | | | | | BUG=137676 TEST=none TBR=deps Review URL: https://chromiumcodereview.appspot.com/10805065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148133 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Breakpad to @970.alexeypa@chromium.org2012-06-141-0/+2
| | | | | | | | | | | | Add two NULL parameters to CrashGenerationServer ctor to match the new prototype (changed in r952) Add the files appeared in r945 to breakpad.gyp BUG=127776,132164 TEST=remoting_unittests.BreakpadWinDeathTest.* Review URL: https://chromiumcodereview.appspot.com/10544121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142200 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136762 - Bump Breakpad revision to r963glider@chromium.org2012-05-141-2/+0
| | | | | | | | | | | | | Reason: symupload got broken BUG=127776 TBR=mark Review URL: https://chromiumcodereview.appspot.com/10377108 TBR=glider@chromium.org Review URL: https://chromiumcodereview.appspot.com/10398022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136925 0039d316-1c4b-4281-b951-d872f2087c98
* Bump Breakpad revision to r963glider@chromium.org2012-05-121-0/+2
| | | | | | | | | | | Add two NULL parameters to CrashGenerationServer ctor to match the new prototype (changed in r952) Add the files appeared in r945 to breakpad.gyp BUG=127776 TBR=mark Review URL: https://chromiumcodereview.appspot.com/10377108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136762 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:executable on windows executables.maruel@chromium.org2012-04-271-0/+0
| | | | | | | | | | | | | Remove third_party/tlslite/installers/ TBR=thestig@chromium.org BUG= TEST= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10178018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134316 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream crash changes for android.carlosvaldivia@google.com2012-04-101-1/+162
| | | | | | | | | | | | | | | | | | | | | Third time is a charm. Original Reviews: https://chromiumcodereview.appspot.com/9838033/ http://codereview.chromium.org/9967017 Revert "Revert 131593" This reverts commit e306ea7f630d4264075913ea3a1a728d98ca9605. BUG= TEST= Review URL: http://codereview.chromium.org/9960072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131662 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 131593erg@google.com2012-04-101-150/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Speculatively reverting due to gyp update error on official bots: KeyError: 'src/breakpad/breakpad.gyp:dump_syms#target while trying to load target src/remoting/remoting.gyp:remoting_linux_symbols#target' This is the only patch in the regression range that touches breakpad.gyp. --- Upstream Android native crash handling changes. This is actulaly the second time. Revert "Revert 131404 - Upstream native crash handling changes for Android." This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba. Conflicts: chrome/browser/chrome_browser_main.cc BUG= TEST= Review URL: http://codereview.chromium.org/9967017 TBR=carlosvaldivia@google.com Review URL: https://chromiumcodereview.appspot.com/10037013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131600 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream Android native crash handling changes.carlosvaldivia@google.com2012-04-101-1/+150
| | | | | | | | | | | | | | | | | | | | This is actulaly the second time. Revert "Revert 131404 - Upstream native crash handling changes for Android." This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba. Conflicts: chrome/browser/chrome_browser_main.cc BUG= TEST= Review URL: http://codereview.chromium.org/9967017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131593 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 131404 - Upstream native crash handling changes for Android.msw@chromium.org2012-04-091-150/+1
| | | | | | | | | | | | | | | | | | | | Android native crash handling is almost identical to linux handling with some differences. Note that even after this change Chrome on Android will not compile with the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should remedy this state of affairs. BUG= TEST= Review URL: http://codereview.chromium.org/9838033 TBR=carlosvaldivia@google.com Review URL: https://chromiumcodereview.appspot.com/9999004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131420 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream native crash handling changes for Android.carlosvaldivia@google.com2012-04-091-1/+150
| | | | | | | | | | | | | | | | | Android native crash handling is almost identical to linux handling with some differences. Note that even after this change Chrome on Android will not compile with the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should remedy this state of affairs. BUG= TEST= Review URL: http://codereview.chromium.org/9838033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131404 0039d316-1c4b-4281-b951-d872f2087c98
* Update LICENSE file for breakpadsteveblock@chromium.org2012-03-261-0/+37
| | | | | | | | | | | | | | Breakpad mostly uses a new BSD license, plus an MIT/X derivate for libcurl. However, a couple of files use different licenses. This change updates the LICENSE file to reflect this. - src/client/mac/handler/breakpad_nlist_64.cc - Apple PSL 2.0 - src/common/mac/testing/GTMSenTestCase.h - ASL v2 Review URL: http://codereview.chromium.org/9856015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128950 0039d316-1c4b-4281-b951-d872f2087c98
* Fix licensing information for breakpad/steveblock@chromium.org2012-03-122-1/+59
| | | | | | | | | | | | | | | | | | | | | | | | This change adds the required fields to README.chromium and adds a license file. The license file contains the license for both breakpad and libcurl (included by breakpad as a third-party directory) ... - breakpad - Taken from upstream COPYING at r255. See http://code.google.com/p/google-breakpad/source/browse/trunk/COPYING?r=255. Note that this file isn't pulled into Chromium via DEPS as we don't pull the entire breakpad repository. - libcurl - Taken from upstream src/third_party/curl/COPYING at r932. See http://code.google.com/p/google-breakpad/source/browse/trunk/src/third_party/curl/COPYING?r=932. Note that this file isn't currently in Chromium as we're synced to r922 via DEPS. breakpad/ is currently skipped by tools/licenses.py. This exception can't easily be removed because breakpad/ contains a subdirectory named third_party which causes the tool to barf. Review URL: http://codereview.chromium.org/9630015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126088 0039d316-1c4b-4281-b951-d872f2087c98
* roll breakpad 915:922thakis@chromium.org2012-02-221-1/+2
| | | | | | | | | | | | | | | | | 916: Creating minidump for uncaught exception on iOS. 917: Add missing include. (iOS) 918: Avoid setting an alternative stack for signals if there's already one (linux) 919: Add filename to error when PDBSourceLineWriter::Open fails (win) 920: Add some missing #includes 921: Add a bootstrap_register() wrapper to fix deprecation warnings (mac) 922: Move away from the 10.4 SDK. (mac) BUG=none TEST=none Review URL: http://codereview.chromium.org/9433023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122963 0039d316-1c4b-4281-b951-d872f2087c98
* roll breakpad 902:907thakis@chromium.org2012-01-271-3/+25
| | | | | | | | | | | | | | | 903: Build LinuxLibcSupportTest and make it pass. (test-only) 904: Skip ElfCoreDumpTest.ValidCoreFile test if no core dump is generated. (linux) 905: Implement core dump to minidump conversion. (linux / chromeos) 906: Use sys_prctl instead of prctl. (linux) 907: Fix several clang warnings in breakpad. (mac) BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9290055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119319 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Breakpad r897:r902. Mostly changes being upstreamed from ↵thestig@chromium.org2012-01-131-0/+24
| | | | | | | | CrOS's branch. Cleanup some whitespaces while we're at it. Review URL: http://codereview.chromium.org/9158035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117602 0039d316-1c4b-4281-b951-d872f2087c98
* Roll breakpad to r897 to eliminate UnspecifiedStackSignature crash dumps.siggi@chromium.org2011-12-221-0/+10
| | | | | | | | | | | R=mark@chromium.org,benchan@chromium.org BUG=None TEST=None Review URL: http://codereview.chromium.org/9021040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115614 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Breakpad-enabled Mac builds following r111783, with the Breakpad updatemark@chromium.org2011-11-291-0/+9
| | | | | | | past r889. Review URL: http://codereview.chromium.org/8729037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111971 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad to 888 to correct compilation warnings.qsr@chromium.org2011-11-241-2/+2
| | | | | | | | | BUG=105053 TEST=Compiling breakpad tests does not generate issues about mktemp Review URL: http://codereview.chromium.org/8681010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111502 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad to rev: 886.qsr@chromium.org2011-11-211-1/+1
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/8595014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110931 0039d316-1c4b-4281-b951-d872f2087c98
* Make dump_syms 64-bit on Mac.mark@chromium.org2011-10-311-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | The framework's grown to the point that 32-bit dump_syms no longer has enough memory to do its job. It is failing with messages like: dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug terminate called after throwing an instance of 'St9bad_alloc' what(): std::bad_alloc Moving to 64-bit gives it more space to work with. 64-bit dump_syms is able to dump 32-bit files. BUG=102361 TEST=Breakpad-enabled official release builds Review URL: http://codereview.chromium.org/8409009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107947 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r864, picking up some Mac refactorings and adjusting themark@chromium.org2011-10-111-0/+2
| | | | | | | | build configuration appropriately. This update also contains Clang warning fixes and allows Breakpad's checkout in Chrome to pull its svn:externals. Review URL: http://codereview.chromium.org/8233018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104934 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r842, picking up:mark@chromium.org2011-10-032-46/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ------------------------------------------------------------------------ r842 | mark@chromium.org | 2011-10-03 15:54:28 -0400 (Mon, 03 Oct 2011) | 11 lines Use a bootstrap subset port for the inspector, tying the subset to the lifetime of the task to be monitored, the invoking task. This allows the bootstrap server (in launchd) to automatically clean up the Mach server registration when the task being monitored exits, avoiding leaks of com.Breakpad.Inspector(pid) ports in "launchctl bslist". BUG=chromium:28547 TEST=Handler should still crash catches, but inspector ports should no longer show up in "launchctl bslist". They should show up under a subset port in "launchctl bstree" instead. "launchctl bstree" must be invoked as root. Review URL: http://breakpad.appspot.com/306001 ------------------------------------------------------------------------ This gives each Breakpad instance its own bootstrap subset port as a subset of the process' bootstrap port, and places the Breakpad inspector port into the bootstrap subset port. This completely eliminates leaks of on-demand Mach services advertised via the bootstrap server. This also reverts r34318 and r34534, "temporary" (21-month) hacks to mitigate the leak. The temporary hacks were never completely effective against Breakpad ports leaking from child processes. DestructCrashReporter at process shutdown was deemed unnecessary and is being removed. As this was the last caller to that function, the implementation is removed as well. This is addressed in Breakpad rather than Chrome because a mechanism to fix it without changing the process' bootstrap port was discovered. It was determined that the rohitfork port is already immune to leaks of the sort that the Breakpad inspector port experiences. A previous attempt to fix this bug was r103089, but that caused bug 98550. This strategy is safer. The forked Breakpad module.cc is updated to match upstream r835, which allows the unforking of the CFI-disabling code. A new CFI-disabling "-c" option to dump_syms is now available and used by the dump_product_syms script. BUG=28547 TEST=1. "launchctl bslist" should no longer show on-demand com.Breakpad.Inspector ports (in Breakpad-enabled builds with Breakpad on) ports. 2. "launchctl bstree" (as root) should reveal a bootstrap subset for each process as a child of the per-user/per-session bootstrap namespace if crash reporting is on. One com.Breakpad.Inspector port should show up as a child of each bootstrap subset. As each process exits (even if mercilessly killed by "kill -9"), the associated subsets and inspector ports should disappear. 3. Breakpad reports should be generated on crashes. For example, about:crash and about:inducebrowsercrashforrealz should each cause a minidump to be written in ~/Library/Application Support/Google/Chrome/Crash Reports when Breakpad is enabled. This tests that the Breakpad ports are functioning properly. 4. The browser process should be able to access child process data. Window:Task Manager should show valid values for the Memory, CPU, and Network columns for all child processes. This tests that the rohitfork port is functioning properly. Note that this version of the change does not change the handling of rohitfork ports at all, but this test case was useful in a previous version of this patch. 5. Test case from bug 98550: Have a link in a web browser window (in a different browser) and drag it into Chrome. Expect the drag operation to operate properly in both the tab strip and in web content. See bug 98550 for details. 6. Unreported test case that failed in r103089: browser relaunch should work. Visit chrome://flags, change some flags to get the "Relaunch Now" button at the bottom (you can put the flags back to how you found them initially), and click "Relaunch Now". The browser should close and then be relaunched. Review URL: http://codereview.chromium.org/8120007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103778 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PIE for dump_syms. The framework is too big to reliably be able tomark@chromium.org2011-09-081-0/+6
| | | | | | | | | | | mmap it in a 32-bit process with PIE on. There may not be a big enough gap in the address space to mmap it. BUG=none TEST=none Review URL: http://codereview.chromium.org/7840040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100149 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of <iostream> where unnecessary.evan@chromium.org2011-09-011-1/+1
| | | | | | | | | | | | | | Any file which uses <iostream> gains a static initializer, which is both disallowed by our style guide and also harms startup performance. Note that Chrome's logging.h uses <ostream> (note missing "i"), which includes the << operators for logging but does *not* use cin/cout. This is fine. BUG=94794 Review URL: http://codereview.chromium.org/7811002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99237 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r828 to pick up:mark@chromium.org2011-08-261-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ------------------------------------------------------------------------ r828 | mark@chromium.org | 2011-08-26 18:29:33 -0400 (Fri, 26 Aug 2011) | 8 lines Fix a Breakpad crash during teardown when USE_PROTECTED_ALLOCATIONS is in effect. BUG=none TEST=Apple Crash Reporter logs from processes in which Breakpad handles the crash should point the finger at the actual crash source, not the Breakpad thread's attempt to write to unwritable memory. Review URL: http://breakpad.appspot.com/301001 ------------------------------------------------------------------------ r827 | mark@chromium.org | 2011-08-26 17:37:59 -0400 (Fri, 26 Aug 2011) | 5 lines Add missing (parentehses.) BUG=247, chromium:94107 TEST=Minidump file sizes should be manageable Review URL: http://breakpad.appspot.com/300002 ------------------------------------------------------------------------ This also enables USE_PROTECTED_ALLOCATIONS. This should have been on all along because we're using Breakpad through the Framework/Breakpad.mm interface, which requires it. Note that if we ought not have been using USE_PROTECTED_ALLOCATIONS, the build would fail. BUG=94107 TEST=Breakpad should upload reasonably-sized minidump files. Apple Crash Reporter logs from processes in which Breakpad handles the crash should point the finger at the actual crash source, not the Breakpad thread's attempt to write to unwritable memory. Review URL: http://codereview.chromium.org/7761007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98505 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-12 22:35:32 +0000