summaryrefslogtreecommitdiffstats
path: root/build/android
Commit message (Collapse)AuthorAgeFilesLines
* Upstream: Depend on OpenSSL directly instead of via system.gypjingzhao@chromium.org2012-05-161-24/+0
| | | | | | | | | | | | | build/android/system.gyp has an extra level of abstraction for openssl which is currently not really doing anything since we don't yet support using the system openssl on android. Remove it for now, because this stops there from being two targets called "ssl" (this one and the one for linux) - solving some problems with the android build backend for gyp. Review URL: https://chromiumcodereview.appspot.com/10332106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137379 0039d316-1c4b-4281-b951-d872f2087c98
* Put commandline for apk tests in /data/local/tmpnileshagrawal@chromium.org2012-05-161-1/+1
| | | | | | | | | | | | | | | We were trying to use the application directory which is not usually writable (unless the device is rooted). This allows us to run the tests on non-rooted devices. BUG=125059 TEST= Review URL: https://chromiumcodereview.appspot.com/10398049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137368 0039d316-1c4b-4281-b951-d872f2087c98
* Run APK tests on the android_test trybot.nileshagrawal@chromium.org2012-05-163-16/+27
| | | | | | | | | | | | Test failures are ignored for now. TBR=mark@chromium.org,tsepez@chromium.org BUG=125059 TEST= Review URL: https://chromiumcodereview.appspot.com/10387086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137352 0039d316-1c4b-4281-b951-d872f2087c98
* Add ${ANDROID_TOOLCHAIN} to $PATH to assist ninja.jrg@chromium.org2012-05-151-6/+8
| | | | | | | | | | | | Also minor upstreaming command movement. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10382177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137243 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing failing unittest for android: ↵mmocny@chromium.org2012-05-141-2/+0
| | | | | | | | | | | | | | GpuMemoryManagerTest.TestForegroundStubsGetBonusAllocation BUG=126521 TEST=fixing content_unittests, adding GpuMemoryManagerTest.TestForegroundStubsGetBonusAllocationAndroid Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136593 Review URL: https://chromiumcodereview.appspot.com/10383067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136904 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136593 - Fixing failing unittest for android: ↵mmocny@chromium.org2012-05-111-0/+2
| | | | | | | | | | | | | | | GpuMemoryManagerTest.TestForegroundStubsGetBonusAllocation BUG=126521 TEST=fixing content_unittests, adding GpuMemoryManagerTest.TestForegroundStubsGetBonusAllocationAndroid Review URL: https://chromiumcodereview.appspot.com/10383067 TBR=mmocny@chromium.org Review URL: https://chromiumcodereview.appspot.com/10332121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136613 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Compile to compile for CQ happinessjrg@chromium.org2012-05-111-1/+3
| | | | | | | | | | BUG=None TEST= Review URL: https://chromiumcodereview.appspot.com/10377110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136600 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing failing unittest for android: ↵mmocny@chromium.org2012-05-111-2/+0
| | | | | | | | | | | | GpuMemoryManagerTest.TestForegroundStubsGetBonusAllocation BUG=126521 TEST=fixing content_unittests, adding GpuMemoryManagerTest.TestForegroundStubsGetBonusAllocationAndroid Review URL: https://chromiumcodereview.appspot.com/10383067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136593 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromium_base.jar path for APK builds.nileshagrawal@chromium.org2012-05-111-2/+2
| | | | | | | | | | | | | Also, Don't make try_compile_test bot RED if native tests APK fails to compile. BUG=125059 TBR=mark@chromium.org,tsepez@chromium.org TEST= Review URL: https://chromiumcodereview.appspot.com/10310098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136496 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the 'Test Finished' step from run_tests.py.mkosiba@chromium.org2012-05-101-3/+13
| | | | | | | | | | | | | | | | | The 'Test Finished' step was introduced in r130823 to absorb the non-zero exit status which we'd get if any of the test suites in the batch would fail. Since the run_tests.py script will print a STEP_FAILURE annotation for every suite the exit status is redundant and therefore should be removed. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10382100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136302 0039d316-1c4b-4281-b951-d872f2087c98
* Strip 'webkit_unit_tests' before uploading to Android emulator or devicesyongsheng.zhu@intel.com2012-05-101-3/+0
| | | | | | | | | | | | | This binary is not stripped in the build step. It should be stripped for it's too big. BUG=126616 TEST= Review URL: https://chromiumcodereview.appspot.com/10375050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136236 0039d316-1c4b-4281-b951-d872f2087c98
* Android content shell bringup.jrg@chromium.org2012-05-103-2/+14
| | | | | | | | | | | | | | | | | | Build media java files (we weren't). Fix adb_install_content_shell for cases where the app was stuck. Add upstream staging gyp var / #define. Be more consistent about jar output files (all in lib.java). Upstream a bunch of random files (e.g. ppapi). Upstream a bunch of java and native code hit as part of shlib init. Properly package jar files in content shell. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10377059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136219 0039d316-1c4b-4281-b951-d872f2087c98
* Detect crashes while running native tests in APK.nileshagrawal@chromium.org2012-05-094-14/+26
| | | | | | | | | | | | | Adding signal handlers (for fatal signals) to output a marker indicating that the test crashed. BUG=125059 TEST= Review URL: https://chromiumcodereview.appspot.com/10310046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136050 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some test server based tests on Chromium Linux Android.jnd@chromium.org2012-05-091-2/+8
| | | | | | | | | | | | | The test server based tests are because test server spawner is not enabled on Chromium Android. Once the net upstreaming is done, test server spawner can be enabled and those tests should pass on Chromium Android. BUG=None. TEST=Make Chromium Linux Android bot green. TBR=jrg, yfriedman Review URL: https://chromiumcodereview.appspot.com/10381069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135996 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing GpuMemoryManagerTest for android.nileshagrawal@chromium.org2012-05-081-0/+2
| | | | | | | | | | BUG=126521 TEST= Review URL: https://chromiumcodereview.appspot.com/10375040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135859 0039d316-1c4b-4281-b951-d872f2087c98
* Let android_gyp pass extra parameters to gypwangxianzhu@chromium.org2012-05-071-1/+1
| | | | | | | | | | | | | | | This is useful for example android_gyp --help or android_gyp --format=dump_dependency_json (to generate a dependency graph). BUG=none TEST=Run android_gyp --help Review URL: https://chromiumcodereview.appspot.com/10381043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135746 0039d316-1c4b-4281-b951-d872f2087c98
* Add native debugging support to android content shell.jrg@chromium.org2012-05-071-0/+89
| | | | | | | | | | | | | | | | | | | | | | | How to native debug: - apply the patch listed in the code review description - adb_run_content_shell - gdb_content_shell - attach Eclipse; continue - now boom! SEGV in gdb. Sadly the native library crashes while loading so it's not registered with gdb yet (e.g no symbols or stack). This CL also adds in a file that got lost (testing/android/README.chromium). BUG= TEST= Review URL: http://codereview.chromium.org/10254028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135652 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply "Changes according to review comments"wangxianzhu@chromium.org2012-05-051-0/+2
| | | | | | | | | | | | | | | | | Fixed an "unused variable" issue of the original CL (http://codereview.chromium.org/10224004/). Use Android API for GetDisplayNameForLocale(). Using Android API, we can reduce the data size of ICU and thus reduce the binary size of chromium-android. BUG=none TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry TBR=jrg@chromium.org,isherman@chromium.org,mark@chromium.org,jshin@chromium.org,rvargas@chromium.org Review URL: http://codereview.chromium.org/10310029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135524 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 135484 - Use Android API for GetDisplayNameForLocale().rvargas@google.com2012-05-041-2/+0
| | | | | | | | | | | | | | | | | | | failure: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/4835/steps/BuildTarget/logs/stdio Using Android API, we can reduce the data size of ICU and thus reduce the binary size of chromium-android. BUG=none TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry TBR=sky Review URL: http://codereview.chromium.org/10224004 TBR=wangxianzhu@chromium.org Review URL: https://chromiumcodereview.appspot.com/10380018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135490 0039d316-1c4b-4281-b951-d872f2087c98
* Use Android API for GetDisplayNameForLocale().wangxianzhu@chromium.org2012-05-041-0/+2
| | | | | | | | | | | | | Using Android API, we can reduce the data size of ICU and thus reduce the binary size of chromium-android. BUG=none TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry TBR=sky Review URL: http://codereview.chromium.org/10224004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135484 0039d316-1c4b-4281-b951-d872f2087c98
* This patch is to enable x86 android build.james.wei@intel.com2012-05-031-22/+20
| | | | | | | | | | | | | | | | | | | patch includes two parts: 1. gyp files modification to include x86 android build. 2. add android config files for yasm which is copied from linux ones. enable android x86 build This patch is cloned from the issue #10198027 for ownership issue. https://chromiumcodereview.appspot.com/10198027/ BUG=125160 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135087 Review URL: http://codereview.chromium.org/10271039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135110 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 135087 - This patch is to enable x86 android build.rsleevi@chromium.org2012-05-031-20/+22
| | | | | | | | | | | | | | | | | | | | patch includes two parts: 1. gyp files modification to include x86 android build. 2. add android config files for yasm which is copied from linux ones. enable android x86 build This patch is cloned from the issue #10198027 for ownership issue. https://chromiumcodereview.appspot.com/10198027/ BUG=125160 TEST= Review URL: http://codereview.chromium.org/10271039 TBR=james.wei@intel.com Review URL: https://chromiumcodereview.appspot.com/10331008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135095 0039d316-1c4b-4281-b951-d872f2087c98
* This patch is to enable x86 android build.james.wei@intel.com2012-05-031-22/+20
| | | | | | | | | | | | | | | | | patch includes two parts: 1. gyp files modification to include x86 android build. 2. add android config files for yasm which is copied from linux ones. enable android x86 build This patch is cloned from the issue #10198027 for ownership issue. https://chromiumcodereview.appspot.com/10198027/ BUG=125160 TEST= Review URL: http://codereview.chromium.org/10271039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135087 0039d316-1c4b-4281-b951-d872f2087c98
* Disables a test to get the Android FYI bot greendfalcantara@chromium.org2012-04-281-0/+2
| | | | | | | | | | | | Disables FileUtilProxyTest.Touch; it doesn't seem to have ever worked for Android and is keeping the bot red. BUG= TEST= Review URL: http://codereview.chromium.org/10253018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134411 0039d316-1c4b-4281-b951-d872f2087c98
* Package and load native library in content shell. Add content shell util ↵jrg@chromium.org2012-04-264-0/+49
| | | | | | | | | | | | scripts. BUG=None TEST= Review URL: http://codereview.chromium.org/10223007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134030 0039d316-1c4b-4281-b951-d872f2087c98
* Fix commandline and disabling tests for apk based tests.nileshagrawal@chromium.org2012-04-251-1/+1
| | | | | | | | | | | | | | | | | Command for running with a test filter: ./build/android/run_tests.py -s out/Release/base_unittests_apk/base_unittests-debug.apk -f FileUtilTest.* The _disabled file should be base_unittests-debug_disabled BUG= TEST= Review URL: http://codereview.chromium.org/10214002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133838 0039d316-1c4b-4281-b951-d872f2087c98
* Add test summaries for native tests for Android.nileshagrawal@chromium.org2012-04-252-2/+15
| | | | | | | | | | | | | Modify test_result.LogFull() to print the summary, and call it when native finish running. BUG= TEST= Review URL: http://codereview.chromium.org/10210001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133830 0039d316-1c4b-4281-b951-d872f2087c98
* Update net/android/network_library.cc with fresher code.yfriedman@chromium.org2012-04-241-0/+3
| | | | | | | | | | Also adds it to the build to ensure it doesn't suffer bit-rot again, and include Java-side component. Review URL: http://codereview.chromium.org/10171009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133591 0039d316-1c4b-4281-b951-d872f2087c98
* Remove shebang from non-executable script.maruel@chromium.org2012-04-231-1/+0
| | | | | | | | | | | R=jrg@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/10186005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133567 0039d316-1c4b-4281-b951-d872f2087c98
* Look for "END" marker while runnig APK tests.nileshagrawal@chromium.org2012-04-231-2/+6
| | | | | | | | | | | | test_package_apk is watching adb logcat and will never see EOF. BUG= TEST= Review URL: http://codereview.chromium.org/10204001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133566 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:executable bit on scripts that are executable.maruel@chromium.org2012-04-231-1/+0
| | | | | | | | | | | R=mark@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/10165021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133399 0039d316-1c4b-4281-b951-d872f2087c98
* apk-based test runner work for android. 2 unit test bundles converted over ↵jrg@chromium.org2012-04-199-21/+180
| | | | | | | | | | | | | | | | | | | | | | | | (ipc, base). OFF by default; enable with a gyp var. E.g. GYP_DEFINES="$GYP_DEFINES gtest_target_type=shared_library" android_gyp Some useful commands: adb uninstall org.chromium.native_test adb install -r out/Release/base_unittests_apk/ChromeNativeTests-debug.apk adb shell am start -n org.chromium.native_test/org.chromium.native_test.ChromeNativeTestActivity For the moment, all apks can be built simultaneously but use the same activity name. Thus you cannot have more than one installed at the same time. BUG=None TEST= Review URL: http://codereview.chromium.org/10051021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133053 0039d316-1c4b-4281-b951-d872f2087c98
* Disable newly added test for Android.yfriedman@chromium.org2012-04-191-0/+2
| | | | | | | | Depends on test server which isn't operational yet. Review URL: https://chromiumcodereview.appspot.com/10124011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133015 0039d316-1c4b-4281-b951-d872f2087c98
* Enable gpu_unittests for Android.yfriedman@chromium.org2012-04-171-0/+1
| | | | | | | | | It builds and runs successfully. Review URL: http://codereview.chromium.org/10107023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132622 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some tests which newly fail on Androidjrg@chromium.org2012-04-131-0/+5
| | | | | | | | | BUG=None TEST= Review URL: https://chromiumcodereview.appspot.com/10082015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132241 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show failure of the last succeeded testwangxianzhu@chromium.org2012-04-051-0/+2
| | | | | | | | | | | | | | Before this change, if some test failed before the last test succeeded, because of the return value, the buildbot will show that the last test also failed. Add a summary build step to avoid that. BUG=None TEST=None Review URL: http://codereview.chromium.org/9989001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130823 0039d316-1c4b-4281-b951-d872f2087c98
* Build and push chrome.pak for ui_unittests on Android.wangxianzhu@chromium.org2012-04-045-16/+23
| | | | | | | | | | BUG=None TEST=build/android/run_tests.py -s out/Release/ui_unittests Review URL: http://codereview.chromium.org/9963086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130547 0039d316-1c4b-4281-b951-d872f2087c98
* Update test suppressions / disabled tests following refactoring.rsleevi@chromium.org2012-04-031-1/+0
| | | | | | | | | | | | | | | | Some of these suppressed tests no longer exist or were renamed. They have not been failing since they were renamed, so it should be fine. Additionally, in the case of the CertVerifier tests, these tests now use a mock stub for testing caching behaviour, and thus no longer block dependent on the system libraries. R=wtc BUG=117372, 67599 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/9965036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130419 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ui_unittests before we resolve resource pack issue.wangxianzhu@chromium.org2012-04-031-1/+1
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/9963076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130271 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ui_unittests in Android buildwangxianzhu@chromium.org2012-04-022-1/+63
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/9958026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130188 0039d316-1c4b-4281-b951-d872f2087c98
* Android fyi content_unittests fix.bulach@chromium.org2012-03-281-0/+3
| | | | | | | | | | | | | | Disables a couple of tests that are already marked as flaky on other platforms, and currently failing on our FYI bots: http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Android/builds/7638/steps/Test%20suite%20content_unittests/logs/stdio BUG=104950 TEST=content_unittests runs fine on android Review URL: http://codereview.chromium.org/9875017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129430 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes android.fiy bot base_unittests.bulach@chromium.org2012-03-281-0/+1
| | | | | | | | | | | | | | Following: http://codereview.chromium.org/9860035 we need to push an extra data file. BUG= TEST=JSONReaderTest.ReadFromFile Review URL: http://codereview.chromium.org/9844017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129419 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 128679 - Speculative revert. xcodebuilders hosed between r128678 - ↵rsleevi@chromium.org2012-03-245-108/+5
| | | | | | | | | | | | | | | | | | 128680 in GYP phse, this is the only change that touched GYP files. apk-based test runner work. Not enabled yet. This CL is a combination of upstreaming, ndk/ant-ification, and other tweaks. BUG=None TEST= Review URL: http://codereview.chromium.org/9834037 TBR=jrg@chromium.org Review URL: https://chromiumcodereview.appspot.com/9852004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128685 0039d316-1c4b-4281-b951-d872f2087c98
* apk-based test runner work. Not enabled yet. This CL is a combination of ↵jrg@chromium.org2012-03-245-5/+108
| | | | | | | | | | | | upstreaming, ndk/ant-ification, and other tweaks. BUG=None TEST= Review URL: http://codereview.chromium.org/9834037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128679 0039d316-1c4b-4281-b951-d872f2087c98
* Enable goma for Android. Fix non-goma 'make' builds.jrg@chromium.org2012-03-211-20/+40
| | | | | | | | | | BUG=None TEST= Review URL: http://codereview.chromium.org/9693016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127919 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome on Android: fix cross-compilation setup.bulach@chromium.org2012-03-202-35/+16
| | | | | | | | | | | | | | | | This patch removes the need of exporting / setting CROSS_C* variables when calling make for android. Instead, set them at Makefile generation time so that gyp will set the right compilers when calling android_gyp. This also allows goma builds. BUG= TEST=builds for android. Review URL: http://codereview.chromium.org/9693042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127667 0039d316-1c4b-4281-b951-d872f2087c98
* Disable GPUTestExpectationsParserTest.WebGLTestExpectationsValidation on Androidwangxianzhu@google.com2012-03-161-0/+2
| | | | | | | | | BUG=118542 TEST=none Review URL: https://chromiumcodereview.appspot.com/9699101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127075 0039d316-1c4b-4281-b951-d872f2087c98
* Disable URLFetcherUploadProgressTest.Basicwangxianzhu@google.com2012-03-161-0/+1
| | | | | | | | | | | It's not feasible to run it on Android for now. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9701087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127050 0039d316-1c4b-4281-b951-d872f2087c98
* Enable running content_unittests on the android builder.satish@chromium.org2012-03-152-1/+38
| | | | | | | | | | | | | This adds a blacklist of known test failures and adds content_unittests to the list of test suites to run. BUG=None TEST=content_unittests should start running and pass on the android builder. Review URL: http://codereview.chromium.org/9703066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127020 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream Android's PathUtils implementation.peter@chromium.org2012-03-141-0/+2
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/9443018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126624 0039d316-1c4b-4281-b951-d872f2087c98