| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=344868
R=yfriedman@chromium.org, bulach, yfriedman
Review URL: https://codereview.chromium.org/179693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChannelProxy currently offers messages to all member MessageFilters. It turns
out that a good portion of the most common message types will never be filtered,
making the O(N) filter walk an unnecessary affair. To prevent this, allow
MessageFilters to indicate which (if any) subset of message classes they may
filter, allowing the ChannelProxy to refine the list of filters that are offered
a particular message. This saves ~35us per message received on the browser IO
thread for a typical Android device.
Relanding with a few more guards for MessageFilter removal, access and message
class subscription.
BUG=340881
TBR=asargent@chromium.org
Review URL: https://codereview.chromium.org/142923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that https://code.google.com/p/trace-viewer/source/detail?r=1168
made trace files embedded in html files compressed, we can switch the
default trace output format to html while keeping the file sizes
manageable.
Note: it currently isn't possible to load the generated html in
about:tracing, so you can either use --view to automatically open the
recorded trace in a browser or --json to get the old raw trace format.
R=bulach@chromium.org
Review URL: https://codereview.chromium.org/178593004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Second try. TBR'ing because the CQ won't catch failures in this area
anyway; I'll watch the bots as this lands.
BUG=346585
TBR=zmo@chromium.org,skyostil@chromium.org,yfriedman@chromium.org
Review URL: https://codereview.chromium.org/177653008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces a multiprocess, pipelined and asynchronous ELF
symbolizer (based on addr2line) which gives honor to a bulkly workstation
when symbolizing large batches of symbols.
BUG=340294,339059
Review URL: https://codereview.chromium.org/167893009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the mode for writing out traces in HTML format. There is a new
third_party/trace-viewer/build/trace2html.py tool that we should use for
this purpose.
NOTRY=true
Review URL: https://codereview.chromium.org/177943003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=280354
Review URL: https://codereview.chromium.org/144183004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Then envsetup doesn't need to set it, and the chromium.gyp_env files
used in the ios build no longer has to set this either.
BUG=330631
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/175683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=168518
Review URL: https://codereview.chromium.org/165393008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These warnings are non actionable because they appear in third_party
code, silence them.
BUG=341086
TBR=brettw
Review URL: https://codereview.chromium.org/156953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 2955e4e3c747fd4aa3c227d6c4e4c698cf31b3c4.
Reason for revert: Frequent crashes on Windows.
BUG=345368
TBR=
Review URL: https://codereview.chromium.org/165333004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This addresses several cases (identified by Android lint) where we
implicitly used the default locale while formatting a string or calling
toLowerCase(). These operations would give different result depending on
the user's settings, which is not what we want, except when formatting
text for display.
Bugs fixed:
* The JellyBeanAccessibilityInjector now works in Arabic. Previously,
it used String.format() to create JavaScript statements... but in
Arabic the formatted numbers were invalid JavaScript.
* Percentages are now formatted correctly in Turkish and Farsi in the
Bandwidth Reduction settings menu.
* Several other minor fixes in tests
BUG=316522
Review URL: https://codereview.chromium.org/173143003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* inline common_vars_defines into its only caller
* then inline sdk_build_init into its only caller
* stop exporting ANDROID_SDK_BUILD since nothing reads it any more
* stop processing options; --target-arch has been a hard error for a while
and nothing blew up
* remove a check for CHROME_ANDROID_BUILD_WEBVIEW as that's now
never set when this script is sourced
BUG=330631
Review URL: https://codereview.chromium.org/171713010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a --trace-flow flag to adb_profile_chrome for tracing IPC call
flows.
NOTRY=true
Review URL: https://codereview.chromium.org/172803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By now, envsetup only sets OS=android and converts GOMA_DIR to the corresponding
gyp defines. It also sets GYP_CROSSCOMPILE. Nothing but the OS=android bit is
used by the webview build, so let android_webview/tools/gyp_webview set what
it needs directly instead of going through envsetup.
(envsetup also does a few envvar chanes to PATH etc, but gyp_webview calls
envsetup in a subshell, so it doesn't see these changes anyways.)
As a side effect, android_webview/tools/gyp_webview no longer ignores
GYP_DEFINES from the environment.
BUG=330631
R=torne@chromium.org
Review URL: https://codereview.chromium.org/170533004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LLVM r201571.
AddressSanitizer now prints "stack-overflow" report with all the stack
traces when it catches a SEGV caused by stack overflow.
BUG=263749
R=bulach@chromium.org
Review URL: https://codereview.chromium.org/173743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to make sure I found all the bots that used to pass this. I'll
completely remove the flag in a day or two.
Also remove the function for printing usage information. I accidentally removed
processing for --help in r252034, but having a --help flag for printing --help
as only supported flag is a bit silly anyways, so get rid of this.
(Depends on https://codereview.chromium.org/170783015/
and https://chrome-internal-review.googlesource.com/#/c/155292/)
BUG=330631
R=yfriedman@chromium.org
Review URL: https://codereview.chromium.org/173003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most people don't use this parameter and get arm binaries. This is
still the default, so this change shouldn't affect most people.
Folks should instead pass -Dtarget_arch to gyp. (Or, soon, envsetup will stop
clobbering GYP_DEFINES, then you can just add target_arch to your GYP_DEFINES.)
Note that in gyp land, 'mips' is called 'mipsel' and 'x86' is called 'ia32'.
'arm' stays 'arm'.
So for example, instead of running
. build/android/envsetup.sh --target-arch=mips
android_gyp
you'd run
. build/android/envsetup.sh
android_gyp -Dtarget_arch=mipsel
I updated the bots I was able to find to pass the -D flag in addition to
--target-arch. After this CL here is in, I'll update the bots to stop passing
--target-arch, and then I'll make --target-arch a hard error in this script for
a while, to make sure nobody still uses it.
BUG=330631,34476
R=torne@chromium.org
TBR=yfriedman
Review URL: https://codereview.chromium.org/171903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tools.
If ANDROID_SDK_ROOT is set, it's still added to the path for now, but it's
no longer passed to gyp. If you want to set a custom sdk root, call gyp like
"build/gyp_chromium -Dandroid_sdk_root=path".
If ANDROID_SDK_ROOT is not set, it's still getting exported with a default
value that's identical to the default value of gyp's android_sdk_root variable.
ANDROID_SDK_TOOLS and ANDROID_SDK_BUILD_TOOLS_VERSION are now
completely ignored. Set the android_sdk_tools or android_sdk_build_tools_version
gyp defines instead if you need to change either. If they are not set,
envsetup no longer sets them.
(Dependent on an internal that changes a bot to set these gyp defines in
addition to the env vars.)
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/164193010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=187570
TEST=RenderFrameHostManagerTest.* passes on Android
Review URL: https://codereview.chromium.org/163753003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
dummy values.
They shouldn't be used in a webview build, so make that more obvious.
BUG=330631
Review URL: https://codereview.chromium.org/167193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--trace-cc implied cc.debug* which enables a ton of stuff for
ubercompositor. This is bad for recording performance. In the vast
majority of use cases, users of adb_profile_chrome just want a basic
frame viewer-case. So rename the flags accordingly to facilitate
that use case.
R=skyostil
Review URL: https://codereview.chromium.org/166483011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use Enter to stop early instead of Ctrl-C so that users don't
accidentally hit Ctrl-C during the trace downloading phase.
BUG=337656
NOTRY=true
Review URL: https://codereview.chromium.org/164203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was lost when we unified the perf test runner
in crrev.com/217665.
BUG=343900
Review URL: https://codereview.chromium.org/166433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChannelProxy currently offers messages to all member MessageFilters. It turns
out that a good portion of the most common message types will never be filtered,
making the O(N) filter walk an unnecessary affair. To prevent this, allow
MessageFilters to indicate which (if any) subset of message classes they may
filter, allowing the ChannelProxy to refine the list of filters that are offered
a particular message. This saves ~35us per message received on the browser IO
thread for a typical Android device.
BUG=340881
TBR=asargent@chromium.org
Review URL: https://codereview.chromium.org/142923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like everything looks qualified paths to reference the binaries
in this folder already.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/167053003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=330631
R=frankf@chromium.org
Review URL: https://codereview.chromium.org/167643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If someone wants to use a custom android sdk version, they now need to set
the android_sdk_version gyp define instead of this env var.
(Depends on one internal change to an internal bot that currently sets the
env var: https://chrome-internal-review.googlesource.com/154255)
BUG=330631
Review URL: https://codereview.chromium.org/159463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=168518
NOTRY=true
Review URL: https://codereview.chromium.org/163923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flakily fails: MSE_ClearKey/EncryptedMediaTest.ConfigChangeVideo/0
NOTRY=true
TBR=yfriedman
BUG=343604
Review URL: https://codereview.chromium.org/163503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clients should set the host_os gyp variable instead. (As far as I can tell,
this flag was added for the webview build, and this CL updates gyp_webview
to use the gyp define instead. I haven't found other clients.)
Since several gyp targets check the value of host_os in a
target_conditions block and most of the build/common.gypi variables
aren't available during target_conditions processing time, use the same
trick that chromium_code uses to make host_os available at target_conditions
time.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/153623011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=True
Review URL: https://codereview.chromium.org/163883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Applies the same renaming as http://crrev.com/142523003 and also removes obsolete methods.
Renamed methods:
- DeriveFont(size_delta, style) => Derive(size_delta, style)
Removed methods:
- DeriveFont(size_delta)
- GetAverageCharacterWidth()
# Use GetExpectedTextWidth(1) instead.
- GetStringWidth(text)
# Use gfx::GetStringWidth(text, font_list) instead.
BUG=265485
TEST=Run ui_unittests, views_unittests.
Review URL: https://codereview.chromium.org/138013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some cases we have multiple libraries with the same package name
(particularly test+non-test). If one of these depends on the other and
refers to package-private stuff in the second, then it should be rebuilt
if the signature of package-private stuff is changed. To ensure that
happens, the TOC file must include the signatures of package-private
members.
Review URL: https://codereview.chromium.org/161773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=168518
Review URL: https://codereview.chromium.org/159853010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=168518
Review URL: https://codereview.chromium.org/137283007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=168518
Review URL: https://codereview.chromium.org/156603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also those needed to move the Trace classes to base, and tidy
up the other TODOs left over from these moves.
Depends on:
https://codereview.chromium.org/141223002 and
https://chrome-internal-review.googlesource.com/#/c/153179
BUG=225101
Review URL: https://codereview.chromium.org/152663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Addresses a review comment from frankf at https://codereview.chromium.org/157743004/
BUG=142642
Review URL: https://codereview.chromium.org/154153008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They are now set by the internal build script that also sets
CHROME_ANDROID_OFFICIAL_BUILD
( https://chrome-internal-review.googlesource.com/154265 ).
No intended behavior change.
BUG=330631
R=yfriedman@chromium.org
Review URL: https://codereview.chromium.org/159143003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/151913003/)
Reason for revert:
Broke the Blink Android Tests (dbg) bot:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20(dbg)
Neither of us can repro failures locally, reverting.
Original issue's description:
> Remove Android filter files for base_unittests
>
> BUG=339980
> R=bulach@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250169
TBR=bulach@chromium.org,phajdan.jr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=339980
Review URL: https://codereview.chromium.org/157593007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/132463007/)
Reason for revert:
This patch is probably the cause of crbug.com/342539.
Original issue's description:
> Enable presubmit pylint in build/android.
>
> BUG=168518
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249793
TBR=craigdh@chromium.org,frankf@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=168518
Review URL: https://codereview.chromium.org/153743008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/143623007/)
Reason for revert:
crbug.com/342539 is likely happening because of the patch that this patch depends on. I need to ensure that logcats work on the bots before relanding (and that the corresponding steps fail if they don't.)
Original issue's description:
> I broke something by removing an apparently unused import that actually was used elsewhere. I addressed the issue by having the client code just call android_commands.GetAttachedDevices explicitly.
>
> BUG=168518
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250206
TBR=craigdh@chromium.org,frankf@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=168518
Review URL: https://codereview.chromium.org/159453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/149113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
used elsewhere. I addressed the issue by having the client code just call android_commands.GetAttachedDevices explicitly.
BUG=168518
Review URL: https://codereview.chromium.org/143623007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Unused after r250141. No behavior change.
BUG=330631
TBR=torne@chromium.org
Review URL: https://codereview.chromium.org/159133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=339980
R=bulach@chromium.org
Review URL: https://codereview.chromium.org/151913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
build/common.gypi already sets <(android_toolchain) independently of this
env var, and nothing seems to really depend on the env var.
(tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py uses it
to print a better error message if it's available, but that doesn't seem
important.)
BUG=330631
R=torne@chromium.org
Review URL: https://codereview.chromium.org/146723004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The android library loader has no logical connection with content. Mojo
shell, which doesn't depend on content, wants to use it. This CL
moves it from content to base.
BUG=225101
NOTRY=true
Review URL: https://codereview.chromium.org/141223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
After the changes in crbug.com/142642 , this should no longer be used.
BUG=142642
Review URL: https://codereview.chromium.org/132953003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250109 0039d316-1c4b-4281-b951-d872f2087c98
|