| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 66120 - Simplify gyp files by adding a global glob for openssl/nss
BUG=None
TEST=Build
Review URL: http://codereview.chromium.org/4799003
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/5014001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build
Review URL: http://codereview.chromium.org/4799003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the *first* element in the pathname (ie- mac/foo.mm). But luckily, the
other rules have caught the places where this bug would have hit, but
nothing says that will always be true.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4915001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is upstreaming a Gentoo Linux patch.
BUG=13322
TEST=none
Review URL: http://codereview.chromium.org/4691001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Shouldn't affect anyone unless I enable this flag on the TSan bot.
TEST=Tested with a local waterfall
Review URL: http://codereview.chromium.org/4688001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61931
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NO CODE CHANGE.
TBR=robertshield
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4334003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn on use_cups for the Mac, add in the required library, and tweak the code
to get it linking. There is still more work to do; this is just a gyp-oriented
change to get things started.
BUG=none
TEST=All targets still build on all platforms.
Review URL: http://codereview.chromium.org/4167006
TBR=scottbyer@chromium.org
Review URL: http://codereview.chromium.org/4136011
TBR=scottbyer@google.com
Review URL: http://codereview.chromium.org/4137013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn on use_cups for the Mac, add in the required library, and tweak the code
to get it linking. There is still more work to do; this is just a gyp-oriented
change to get things started.
BUG=none
TEST=All targets still build on all platforms.
Review URL: http://codereview.chromium.org/4167006
TBR=scottbyer@chromium.org
Review URL: http://codereview.chromium.org/4136011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn on use_cups for the Mac, add in the required library, and tweak the code
to get it linking. There is still more work to do; this is just a gyp-oriented
change to get things started.
BUG=none
TEST=All targets still build on all platforms.
Review URL: http://codereview.chromium.org/4167006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Reason for revert: Widespread failures on Linux bots starting with http://build.chromium.org/p/chromium/builders/Linux%20Tests%20(dbg)(2)/builds/729)
Seeing how the bots feel about this again.
BUG=36133
Review URL: http://codereview.chromium.org/3539015
TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/4200010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Seeing how the bots feel about this again.
BUG=36133
Review URL: http://codereview.chromium.org/3539015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
printing/backend.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3945003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/3788003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/3807005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I got my double negatives incorrect, this should have been -Wnon-virtual-dtor.
BUG=45135
TEST=Targets build without error.
Review URL: http://codereview.chromium.org/3527003
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/3756003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45135
TEST=Targets build without error.
Review URL: http://codereview.chromium.org/3527003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not supported by Clang and causes a ton of "argument unused
during compilation" warnings.
BUG=none
TEST=everything still builds
Review URL: http://codereview.chromium.org/3614013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I want to get to r492 to pick up the fix for http://code.google.com/p/googletest/issues/detail?id=321 , but r446 needs some changes, so I'm doing an extra commit for this revision. See comments at http://code.google.com/p/googletest/source/detail?r=446
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3705002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a pre-requisite for http://codereview.chromium.org/3529008/show
There are no functional changes, it's only refactoring existing code.
BUG=None
TEST=Go to an https:// page and check the certificate info.
Review URL: http://codereview.chromium.org/3565006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r61557, unit_tests fail.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Seeing how the bots feel about this again.
BUG=36133
Review URL: http://codereview.chromium.org/3539015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I will watch the bots to see if this affects performance.
BUG=26625
TEST=compiles
Review URL: http://codereview.chromium.org/3501001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is early in-progress implementation, no cert handling supported. So only available under a build-time flag. (GYP_DEFINES="'use_openssl=1'")
Adds a new build dependency for system OpenSSL libraries, and a new USE_OPENSSL define. Eventually this will disable USE_NSS but for now the two coexist.
BUG=none
TEST=build with use_openssl=1. Goto some https:// pages.
Review URL: http://codereview.chromium.org/3495005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r60384, build breakage.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I will watch the bots to see if this affects performance.
BUG=26625
TEST=compiles
Review URL: http://codereview.chromium.org/3501001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the last few warnings / errors necessary to build chrome/mac with clang.
See http://code.google.com/p/chromium/wiki/Clang
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2762014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To build, set the clang=1 gyp_define.
This patch is the culmination of many months of effort and many
patches. It contains the minimal changes to Chrome that
are Clang-specific.
With this, I can build the "chrome" target. Once this patch
is in, we can incrementally fix bits of Chrome and various
tests and remove the Clang-specific workarounds.
Review URL: http://codereview.chromium.org/522020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is upstreaming a Gentoo Linux patch.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3380004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This was marginally faster in my local test on one file.
TEST=compiles
Review URL: http://codereview.chromium.org/3444006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Linux Reliability Builder test directory output is < 100 MB.
Review URL: http://codereview.chromium.org/3398004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add 'fa' entry to all the grd files.
For *locale_settings*, create new xtb files for Farsi (copied from Arabic).
Also, pulls in ICU @r=58904 (with Farsi data).
locale_settings_fa.xtb has a lot of UI dimensions that may not work
well in Farsi. We need LQA to take a look at them.
terms_FOO.html is not yet available for Farsi as well as Amharic and Swahili. Tentatively, use
terms_en.html.
BUG=45505
TEST='chrome --lang=fa' on Windows should bring up Chrome in Farsi. 'LANGUAGE=fa chrome' should do the same on Linux. (on Ubuntu, 'language-pack-gnome-fa' and 'language-pack-fa' have be installed to get Chrome in Farsi with the UI mirrored).
Review URL: http://codereview.chromium.org/3296013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remove dummy translations
Add the policy templates generated from chrome/app/policy_templates.json to the Mac application bundle. (The template generator for Mac is implemented in CL 3116027) Also remove the old manifest file and references to translations that are not there yet.
The problem with the previous landing attempt was that in Release mode build, the following script was looking for binary files that were not there: build/mac/strip_from_xcode
BUG=49316
TEST=add Chromium to the managed applications' list in the OSX Workgroup Manager, and see if it shows the manageable preferences with English descriptions
Review URL: http://codereview.chromium.org/3287003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Originally added: (http://codereview.chromium.org/3146031)
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/3347002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20737
TEST=none
Review URL: http://codereview.chromium.org/3213005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
heap leak checker to unwind the memory allocation stacks better.
Currently, if a memory region is allocated from a library built without frame
pointers heapchecker is unable to unwind the stack and records only the top
frame. This is inconvenient, because:
-- several leaks from different places are treated as leaks from the same
source
-- it's hard to suppress such leaks, because a one-line suppression is
uninformative
linux_shadow_stacks.cc keeps the threads' IP and SP values in thread-local
stacks upon each function entry/exit using gcc function instrumentation
(-finstrument-functions).
The GetStackTrace routine from stacktrace_shadow-inl.h unwinds the stack as
usual (using frame pointers), but then updates the result with the shadow stack
frames which SP values are below the bottom frame of the unwind result.
Note that -finstrument-functions affects only Chromium code, not the libraries.
This means that we cannot get more than one library function frame at the top
of the stack.
For example, consider a libfoo library that has a public foo_do_something()
routine which allocates memory via foo_alloc(). If Chromium calls
foo_do_something() from ChromeCallFoo(), then the following call chain
effectively happens:
main -> ChromeCallFoo -> foo_do_something -> foo_alloc
If libfoo is built with -fomit-frame-pointers, heapcheck can unwind only the
last stack frame:
foo_alloc
On the other hand, the shadow stack at the allocation site contains everything
below the libfoo calls:
main -> ChromeCallFoo
As a result the following allocation stack is recorded:
main -> ChromeCallFoo -> foo_alloc
This is enough to distinguish between e.g. ChromeCallFoo1 and ChromeCallFoo2
Review URL: http://codereview.chromium.org/3120017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52924
TEST=none
Review URL: http://codereview.chromium.org/3208002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For example, there are differences between unit_tests and browser_tests,
which cause ridiculous problems when moving a test between those.
We're using the symbols anyway, so let's centralize it for maintainability.
TEST=compile
BUG=none
Review URL: http://codereview.chromium.org/3173044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20737
TEST=none
Review URL: http://codereview.chromium.org/2892001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52924
TEST=none
Review URL: http://codereview.chromium.org/3174026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3146031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Having -rdynamic breaks some plugins since it exports more symbols into
the dynamic symbol table than wanted. In particular, this breaks users of
ppapi's C++ wrappers. It was added to make StaceTraces resolve to symbols
on linux. But now we use the symbolize library from glog so it isn't needed
anymore.
BUG=52105
TEST=Compiles and StackTrace.* test in base_unittests will work.
Review URL: http://codereview.chromium.org/3119033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of linux_fpic gyp variable.
BUG=26625
TEST=all linux builds should compile
Review URL: http://codereview.chromium.org/3135001
TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/3150006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of linux_fpic gyp variable.
BUG=26625
TEST=all linux builds should compile
Review URL: http://codereview.chromium.org/3135001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chain toolkit_views to touchui.
All touchui work is based on toolkit_views.
TEST=manually via gclient runhooks
BUG=none
Review URL: http://codereview.chromium.org/3173001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gentoo has some nice docs on it here:
http://www.gentoo.org/proj/en/qa/asneeded.xml
on my Maverick box I couldn't see a difference in the ldd output,
but I suppose it can't hurt on older systems.
BUG=11595
Review URL: http://codereview.chromium.org/3050043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This produced a ~7% startup performance gain in my local tests,
with no extra binary size cost(!?).
I'll watch the perf bots after commit to verify.
Review URL: http://codereview.chromium.org/3093009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome: create an option for using libcros provided by the system; fix all
includes referring to libcros to not include third_party/
* Headers fix is needed to support using system libcros (installed to /usr/include)
* All includes are "", and therefore a local variant in third_party/cros/ is
always preferred, but system will also get picked up as a secondary target
* Fixed chrome/browser/chromeos/cros/synaptics_library.h comments to better
reflect the header placement
* Added a variable system_libcros defaulting to 0
* Gotten rid of duplicate cros_api.gyp
* Changed both places to either link against cros_api or libcrosapi
TEST=build in the following scenarios:
1) libcros not installed, libcros sources in third_party/, !defined system_libcros
- sucess
2) installed libcros, put #error into /usr/include/cros/chromeos_cros_api.h, repeat 1)
- success
3) BUILD_DEFINES+=system_libcros=1, removed libcros from third_party, repeat 2)
- fail (on #error in chromeos_cros_api.h)
4) Installed clean libcros, repeat 3)
- success
Review URL: http://codereview.chromium.org/3043010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53288 0039d316-1c4b-4281-b951-d872f2087c98
|