| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
The the version string can be localized! The regexs assume English formatting and will fail to match under other localization (such as when the versions dots become commas).
http://www.gnu.org/software/gettext/manual/html_node/Locale-Environment-Variables.html#Locale-Environment-Variables
BUG=354231
Review URL: https://codereview.chromium.org/207873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/207303004/)
Reason for revert:
The second \. should have remained a .
Chris Dumez
1 minute ago #7
Message was sent while issue was closed.
https://codereview.chromium.org/207303004/diff/1/build/compiler_version.py
File build/compiler_version.py (right):
https://codereview.chromium.org/207303004/diff/1/build/compiler_version.py#ne...
build/compiler_version.py:31: version_re = re.compile(r"^GNU [^ ]+ .*
(\d+)\.(\d+)\.*?$", re.M)
The last "\.*" looks weird, I think it should be ".*"
Original issue's description:
> Minor fix to regex inside compiler_version.py
>
> These dots where meant to be literal dots, not anything.
>
> BUG=352046
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258570
TBR=thakis@chromium.org,thestig@chromium.org,ch.dumez@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=352046
Review URL: https://codereview.chromium.org/208313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These dots where meant to be literal dots, not anything.
BUG=352046
Review URL: https://codereview.chromium.org/207303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=353433
Review URL: https://codereview.chromium.org/195923004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds,
* Slow link times.
* Slow gdb startup times.
Lots more detailed information at http://gcc.gnu.org/wiki/DebugFission
Overall, this improves linking speed of debug Chrome builds on Linux
by ~12% and speeds up gdb by around 30%.
This requires a objcopy with --extract-dwo object (binutils newer then
2.22.52.0.4 // 2.23). Ubuntu Precise only comes with 2.23
BUG=
Review URL: https://codereview.chromium.org/197013010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't rely on compiler_version.py, we pass in the gcc_version for Android
Also revert the previous compiler_version.py change.
BUG=143889
Review URL: https://chromiumcodereview.appspot.com/11185059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ninja's cross compile mode still uses CXX_target as the target compiler
which needs to be detected before the host one.
This CL might be reverted once the ninja use CXX as target compiler.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10837005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp considers a shell variable substitution to have failed if it
generates any output to stderr, even if the exit status was zero.
This causes problems when gomacc automatically starts its proxy,
which helpfully reports "GOMA: Starting compiler proxy" to stderr.
Fixed by dropping stderr unless the underlying process returns
a non-zero exit status.
BUG=chromium-os:28670
TEST=Ran hooks normally and inside CrOS chroot, with and without
$CXX pointing to goma. A $CXX which writes to stderr and then
exits with failure still prints its output before the exception.
Review URL: http://codereview.chromium.org/10288005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that:
- shebang is only present for executable files
- shebang is #!/usr/bin/env python
- __main__ is only present for executable files
- file's executable bit is coherent
Also fix EOF LF to be only one.
TBR=michaelbai@chromium.org
BUG=105108
TEST=
Review URL: http://codereview.chromium.org/8667008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The regex didn't work for GCC = 4.4.
Review URL: http://codereview.chromium.org/341085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This runs g++ -dumpversion (or $CXX) to establish the compiler version
and set the gyp gcc_version variable automatically.
BUG=25209
Review URL: http://codereview.chromium.org/339046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30824 0039d316-1c4b-4281-b951-d872f2087c98
|