summaryrefslogtreecommitdiffstats
path: root/build/config
Commit message (Collapse)AuthorAgeFilesLines
* remove proprietary Google Play dependenciesreplicant-6.0Wolfgang Wiedmeyer2016-03-251-10/+0
| | | | Signed-off-by: Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de>
* Add gnu.build.id to shared libraries in GN.Torne (Richard Coles)2016-03-151-0/+1
| | | | | | | | | | | | | | | | | | We were doing this in gyp builds but not GN; add this in the GN config too so that we can be sure crash symbols match. BUG=594975 R=agrieve@chromium.org Review URL: https://codereview.chromium.org/1801073002 . Cr-Commit-Position: refs/heads/master@{#381242} (cherry picked from commit e67cbae553e592e7683aefc74c775f1e4a99296a) Review URL: https://codereview.chromium.org/1801243002 . Cr-Commit-Position: refs/branch-heads/2623@{#624} Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
* Fix GN configuration for inclusion of unwinding tables.Yaron Friedman2016-01-221-1/+0
| | | | | | | | | | | | | | | | | | | | build/config/compiler/BUILD.gn was already selecting between -fno-unwind-tables and -funwind-tables depending on whether it's an official build or not. Duplicating this flag causes both -fno-unwind-tables and -funwind-tables which results in unwind tables being included and a much larger shared library. BUG=580374 TBR=amineer Review URL: https://codereview.chromium.org/1617213003 Cr-Commit-Position: refs/heads/master@{#371044} (cherry picked from commit 33ecd69e345149844bef8f1026aebcb5f38afcec) Review URL: https://codereview.chromium.org/1620323004 . Cr-Commit-Position: refs/branch-heads/2623@{#88} Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
* [Android] Rework multidex and enable multidex for unit_tests_apk. (RELAND 2)jbudorick2016-01-161-2/+19
| | | | | | | | | | | this is a reland of https://codereview.chromium.org/1590243003/ BUG=272790 TBR=thakis@chromium.org,yfriedman@chromium.org,phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1594653002 Cr-Commit-Position: refs/heads/master@{#369906}
* Revert of [Android] Rework multidex and enable multidex for unit_tests_apk. ↵jbudorick2016-01-151-19/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (RELAND) (patchset #2 id:20001 of https://codereview.chromium.org/1590243003/ ) Reason for revert: mysterious compile errors on Android appeared two builds after this landed. https://build.chromium.org/p/chromium/builders/Android/builds/50690 Original issue's description: > [Android] Rework multidex and enable multidex for unit_tests_apk. (RELAND) > > This is a reland of https://codereview.chromium.org/1581563003 > > BUG=272790 > TBR=thakis@chromium.org,yfriedman@chromium.org,phajdan.jr@chromium.org > > Committed: https://crrev.com/ab450c5ede0635194331286088d0f488f4086ba5 > Cr-Commit-Position: refs/heads/master@{#369815} TBR=agrieve@chromium.org,thakis@chromium.org,yfriedman@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=272790 Review URL: https://codereview.chromium.org/1587673014 Cr-Commit-Position: refs/heads/master@{#369864}
* [Android] Rework multidex and enable multidex for unit_tests_apk. (RELAND)jbudorick2016-01-151-2/+19
| | | | | | | | | | | This is a reland of https://codereview.chromium.org/1581563003 BUG=272790 TBR=thakis@chromium.org,yfriedman@chromium.org,phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1590243003 Cr-Commit-Position: refs/heads/master@{#369815}
* Disable debug information when use_order_profiling=trueagrieve2016-01-151-0/+7
| | | | | | | | | | | We recently hit a limit when using use_order_profiling=true and symbol_level=2 where libchrome.so > 4gb and become corrupt. BUG=574476 Review URL: https://codereview.chromium.org/1588673003 Cr-Commit-Position: refs/heads/master@{#369777}
* Revert of [Android] Rework multidex and enable multidex for unit_tests_apk. ↵vasilii2016-01-151-15/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #7 id:120001 of https://codereview.chromium.org/1581563003/ ) Reason for revert: Broke compilation on Android https://build.chromium.org/p/chromium/builders/Android/builds/50665 FAILED: cd ../../components; python ../build/android/gyp/apk_obfuscate.py --configuration-name Release --android-sdk /b/build/slave/Android/build/src/third_party/android_tools/sdk//platforms/android-23 --android-sdk-tools /b/build/slave/Android/build/src/third_party/android_tools/sdk//build-tools/23.0.1 --android-sdk-jar /b/build/slave/Android/build/src/third_party/android_tools/sdk//platforms/android-23/android.jar "--input-jars-paths=/b/build/slave/Android/build/src/third_party/android_tools/sdk//extras/android/support/multidex/library/libs/android-support-multidex.jar \"../out/Release/lib.java/jsr_305_javalib.jar\" \"../out/Release/lib.java/base_java.jar\" /b/build/slave/Android/build/src/third_party/android_tools/sdk//extras/android/support/annotations/android-support-annotations.jar \"../out/Release/lib.java/cronet_api.jar\" \"../out/Release/lib.java/url_java.jar\" \"../out/Release/lib.java/net_java.jar\" \"../out/Release/lib.java/cronet_java.jar\" \"../out/Release/lib.java/chromium_apk_cronet_perf_test_apk.jar\"" "--proguard-configs=cronet/android/proguard.cfg \"../out/Release/cronet_perf_test_apk/proguard.txt\"" --test-jar-path ../out/Release/test.lib.java/CronetPerfTest.jar --obfuscated-jar-path ../out/Release/cronet_perf_test_apk/obfuscated.jar --proguard-jar-path ../third_party/proguard/lib/proguard.jar --stamp ../out/Release/cronet_perf_test_apk/obfuscate.stamp --testapp --proguard-enabled Traceback (most recent call last): File "../build/android/gyp/apk_obfuscate.py", line 185, in <module> sys.exit(main(sys.argv[1:])) File "../build/android/gyp/apk_obfuscate.py", line 167, in main DoProguard(options) File "../build/android/gyp/apk_obfuscate.py", line 124, in DoProguard proguard.CheckOutput() File "/b/build/slave/Android/build/src/build/android/gyp/util/proguard_util.py", line 180, in CheckOutput stderr_filter=stderr_filter) File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py", line 162, in CheckOutput raise CalledProcessError(cwd, args, stdout + stderr) util.build_utils.CalledProcessError: Command failed: ( cd /b/build/slave/Android/build/src/components; java -jar ../third_party/proguard/lib/proguard.jar -forceprocessing -libraryjars /b/build/slave/Android/build/src/third_party/android_tools/sdk//platforms/android-23/android.jar -injars /b/build/slave/Android/build/src/third_party/android_tools/sdk//extras/android/support/multidex/library/libs/android-support-multidex.jar:../out/Release/lib.java/jsr_305_javalib.jar:../out/Release/lib.java/base_java.jar:/b/build/slave/Android/build/src/third_party/android_tools/sdk//extras/android/support/annotations/android-support-annotations.jar:../out/Release/lib.java/cronet_api.jar:../out/Release/lib.java/url_java.jar:../out/Release/lib.java/net_java.jar:../out/Release/lib.java/cronet_java.jar:../out/Release/lib.java/chromium_apk_cronet_perf_test_apk.jar -include cronet/android/proguard.cfg -include ../out/Release/cronet_perf_test_apk/proguard.txt -outjars ../out/Release/cronet_perf_test_apk/obfuscated.jar -dump ../out/Release/cronet_perf_test_apk/obfuscated.jar.dump -printseeds ../out/Release/cronet_perf_test_apk/obfuscated.jar.seeds -printusage ../out/Release/cronet_perf_test_apk/obfuscated.jar.usage -printmapping ../out/Release/cronet_perf_test_apk/obfuscated.jar.mapping ) Warning: org.chromium.base.multidex.ChromiumMultiDexInstaller: can't find referenced class org.chromium.base.multidex.ChromiumMultiDex Warning: org.chromium.base.multidex.ChromiumMultiDexInstaller: can't find referenced class org.chromium.base.multidex.ChromiumMultiDex Warning: there were 2 unresolved references to classes or interfaces. You may need to specify additional library jars (using '-libraryjars'). Error: Please correct the above warnings first. Original issue's description: > [Android] Rework multidex and enable multidex for unit_tests_apk. > > This allows multidex to be used in release builds. > > BUG=272790 > > Committed: https://crrev.com/f743bef34d49987c0f1f69e2f0bb6cb8beb03bf5 > Cr-Commit-Position: refs/heads/master@{#369715} TBR=phajdan.jr@chromium.org,agrieve@chromium.org,dpranke@chromium.org,thakis@chromium.org,yfriedman@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=272790 Review URL: https://codereview.chromium.org/1587253003 Cr-Commit-Position: refs/heads/master@{#369717}
* [Android] Rework multidex and enable multidex for unit_tests_apk.jbudorick2016-01-151-0/+15
| | | | | | | | | | This allows multidex to be used in release builds. BUG=272790 Review URL: https://codereview.chromium.org/1581563003 Cr-Commit-Position: refs/heads/master@{#369715}
* Add WiFi Display session class skeleton and mojo servicemikhail.pozdnyakov2016-01-142-0/+6
| | | | | | | | | | | | | | | | | | | This patch introduces a WiFi Display session class skeleton and mojo service which provides network access for the render-hosted session. The introduced code is compiled only if a newly added 'enable_wifi_display' build option is set. Besides, some minor changes were applied to the DisplaySourceConnectionDelegate interface in order to better define its methods behavior. BUG=242107 Review URL: https://codereview.chromium.org/1540563002 Cr-Commit-Position: refs/heads/master@{#369415}
* Using alternative_android_sdk_jar in process_resources, package_resourcesmichaelbai2016-01-142-4/+23
| | | | | | | | BUG=576852 Review URL: https://codereview.chromium.org/1587513002 Cr-Commit-Position: refs/heads/master@{#369287}
* Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot onlysbc2016-01-131-23/+28
| | | | | | | | | | | | | | Previously we were using PKG_CONFIG_PATH to tell pkg-config to search the sysroot directories. However the default libpath is always added to this path, so pkg-config would fall back to looking in the system directories. Using PKG_CONFIG_LIBDIR instead overrides the default libdir which makes the build more hermetic and forces the sysroot to provide all the required .pc files. Review URL: https://codereview.chromium.org/1580643002 Cr-Commit-Position: refs/heads/master@{#369224}
* gn: Pass pkg_config_args when invoking pkg_config_script.raphael.kubo.da.costa2016-01-131-4/+4
| | | | | | | | | | | | | | | When invoking pkg_config_script directly, it is important to pass |pkg_config_args| together with the other arguments wanted, otherwise parameters such as --sysroot will not be passed to the pkg-config.py wrapper. In practice, this means that the libraries in the sysroots will not be used and the dependencies will be unconditionally looked for in the host system. R=sbc@chromium.org,dtseng@chromium.org,dmazzoni@chromium.org,dpranke@chromium.org Review URL: https://codereview.chromium.org/1536423003 Cr-Commit-Position: refs/heads/master@{#369204}
* Cleanup pkg-config.pysbc2016-01-121-98/+106
| | | | | | | | | | | | | While making a seperate change I noticed this script could use a re-factor. - Add --debug/-d flag to output extra information to stderr. - Move main logic into main() function (makes script more easily testable). - Add #! line to make script runnable. Review URL: https://codereview.chromium.org/1577163002 Cr-Commit-Position: refs/heads/master@{#368967}
* Fix typowzhong2016-01-121-1/+2
| | | | | | | | | | GN string needs double rather than single quote. BUG= Review URL: https://codereview.chromium.org/1576113005 Cr-Commit-Position: refs/heads/master@{#368961}
* Make enable_remoting reflect the default in common.gypipkotwicz2016-01-121-1/+1
| | | | | | | | | | | | In GYP remoting is off by default. This CL turns remoting off by default on GN too. This CL fixes a regression caused by https://codereview.chromium.org/1475453002 BUG=544298 Review URL: https://codereview.chromium.org/1482543002 Cr-Commit-Position: refs/heads/master@{#368943}
* [Chromecast] Don't export symbols from libffmpeg.awzhong2016-01-121-0/+4
| | | | | | | | | | | | | | | | | | Use "--exclude-libs" flag to prevent libffmpeg.a from exporting symbols implemented by assembly. Assembly functions marked with ".global" directive are automatically with global visibility and exported in executable and DSO. This is unnecessary and causes incorrect symbol resolution at run-time as Chromecast executable is built with "-Wl,--export-dynamic". BUG= internal b/26390825 TEST= 1) Use "nm" and make sure ff_* are not exported. 2) Test TuneIn playback. Review URL: https://codereview.chromium.org/1561833007 Cr-Commit-Position: refs/heads/master@{#368737}
* Remove gcc_version from gyp and gn files.thakis2016-01-112-58/+15
| | | | | | | | | | | | | | We used this to check if gcc is newer than 4.8 which is now required. Remove the plumbing for this until we need to check gcc compiler versions again, if ever. No behavior change. BUG=573778 Review URL: https://codereview.chromium.org/1577093002 Cr-Commit-Position: refs/heads/master@{#368706}
* Add proguard_verbose GN argagrieve2016-01-082-0/+6
| | | | | | | | | | | Useful when playing with proguard flags to be easily able to see all output & optimization summary. BUG=None Review URL: https://codereview.chromium.org/1568583005 Cr-Commit-Position: refs/heads/master@{#368424}
* Revert of GN: Use -std=gnu++0x for nacl_x86_glibc toolchain (patchset #1 ↵mcgrathr2016-01-081-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1568683002/ ) Reason for revert: Breaks the x64 build: crbug.com/575752 Original issue's description: > GN: Use -std=gnu++0x for nacl_x86_glibc toolchain > > The nacl_x86_glibc toolchain doesn't support -std=gnu++11 or > -std=c++11 but it does support -std=gnu++0x and -std=c++0x. > PPAPI tests built under this toolchain (among other toolchains) > use parts of base/ that have begun using some C++11 features that > require -std=gnu++0x to build with nacl_x86_glibc. > > R=brettw@chromium.org > BUG=none > > Committed: https://crrev.com/678f42a5815a53f9883807b37bd3a253e4bb9b18 > Cr-Commit-Position: refs/heads/master@{#368143} TBR=brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=575752 Review URL: https://codereview.chromium.org/1570513007 Cr-Commit-Position: refs/heads/master@{#368413}
* Enable warning on reserved user-defined literals everywhere but CrOS.thakis2016-01-081-2/+2
| | | | | | | | | | | | | | | | | | This was disabled because a dbus header was missing a few spaces. The version of the dbus header in the sysroot has them though, and we use the sysroot everywhere except in Chrome OS-on-Linux builds these days. The spaces were added here, almost 3 years ago by now: http://cgit.freedesktop.org/dbus/dbus/commit/?h=dbus-1.4&id=51b88b4c7919487290c0862b013cd8e7cd2de34b No behavior change. BUG=263960, 573778 Review URL: https://codereview.chromium.org/1570193002 Cr-Commit-Position: refs/heads/master@{#368408}
* Add librt to default libs on linuxspang2016-01-081-1/+4
| | | | | | | | | | | | | | | | | | | | It's needed by clock_gettime() on glibc < 2.17, and that function is called in various places in the codebase. This library is part of glibc, so just put in the default toolchain libs so we get it everywhere. It fixes the following build error: gn gen out_gn_ozone --args='use_ozone=true toolkit_views=false is_component_build=true' ninja -C out_gn_ozone content_shell ../ui/gl/sync_control_vsync_provider.cc:70: error: undefined reference to 'clock_gettime' ../ui/gl/sync_control_vsync_provider.cc:71: error: undefined reference to 'clock_gettime' Review URL: https://codereview.chromium.org/1565983002 Cr-Commit-Position: refs/heads/master@{#368383}
* Allow enable_topchrome_md to be overridden in gn buildtmoniuszko2016-01-081-2/+4
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1558123002 Cr-Commit-Position: refs/heads/master@{#368298}
* mac: Stop warning about missing newlines at eof.Nico Weber2016-01-071-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Files without a newline on the last line used to have undefined behavior in C++03 (and still have undefined behavior in C). C++11 changed this, see the last sentence in [lex.phases]p1.2 (it used to say "If a source file [...] does not end in a new-line character [...], the behavior is undefined" in 03, now it says "A source file [...] that does not end in a new-line character [...], shall be processed as if an additional new-line character were appended to the file"). We used to tell clang to warn on this on Mac only. We should generally use matching warning flags on all platforms, so the choice is to turn this on everywhere, or turn it off on Mac. Turning it on everywhere is somewhat involved, see https://codereview.chromium.org/1566003002/ for a partial attempt. Many of the violations are in third-party code. Since the warning doesn't have any real benefit in practice (other than your terminal looking nicer if you `cat` such a file), and since it doesn't have a benefit in theory for C++11 translation units, turning off the warning on Mac seems like the way to go. BUG=573778 R=brettw@chromium.org Review URL: https://codereview.chromium.org/1569943002 . Cr-Commit-Position: refs/heads/master@{#368179}
* GN: Use -std=gnu++0x for nacl_x86_glibc toolchainmcgrathr2016-01-071-6/+8
| | | | | | | | | | | | | | | The nacl_x86_glibc toolchain doesn't support -std=gnu++11 or -std=c++11 but it does support -std=gnu++0x and -std=c++0x. PPAPI tests built under this toolchain (among other toolchains) use parts of base/ that have begun using some C++11 features that require -std=gnu++0x to build with nacl_x86_glibc. R=brettw@chromium.org BUG=none Review URL: https://codereview.chromium.org/1568683002 Cr-Commit-Position: refs/heads/master@{#368143}
* Introduce a GN arg controlling the path prefix in pkg-config and modify ↵rjkroege2016-01-072-6/+27
| | | | | | | | pkg-config.py to use it. Review URL: https://codereview.chromium.org/1564503002 Cr-Commit-Position: refs/heads/master@{#367987}
* Copying gyp warning disables to gn for VS 2015 64-bitbrucedawson2016-01-061-5/+11
| | | | | | | | | | | | | | | | | | | | | | gyp 64-bit builds with VS 2015, but gn 64-bit builds do not, because some warnings are disabled for gyp builds but not gn builds. This change makes the gn settings consistent enough to let gn 64-bit VS 2015 builds work. - build\config\compiler\BUILD.gn - disabling of C4312 copied from build\common.gypi - third_party/libxml/BUILD.gn and third_party/libxslt/BUILD.gn - disabling of C4267 and C4311 copied from libxml.gyp and libxslt.gyp files. Disabling of C4101 was *removed* from libxml\BUILD.gn for consistency and because it isn't needed anymore - third_party/mesa/BUILD.gn - disabling of C4311 copied from mesa.gyp R=scottmg@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/1561913002 Cr-Commit-Position: refs/heads/master@{#367944}
* clang: Stop disabling -Wbitfield-widththakis2016-01-061-3/+0
| | | | | | | | | | | | | The warning was made less aggressive in clang a while ago and now never fires in practice unless it's useful. We can stop disabling it. No behavior change. BUG=none Review URL: https://codereview.chromium.org/1562123002 Cr-Commit-Position: refs/heads/master@{#367933}
* Fix a TODO.thakis2016-01-061-8/+0
| | | | | | | | | | No behavior change. BUG=462791 Review URL: https://codereview.chromium.org/1565943002 Cr-Commit-Position: refs/heads/master@{#367929}
* gn: leave PKG_CONFIG_PATH untouched when not using a sysrootmostynb2016-01-061-3/+2
| | | | | | | | This makes cross-compilation possible when not using a sysroot. Review URL: https://codereview.chromium.org/1543483002 Cr-Commit-Position: refs/heads/master@{#367906}
* GN(android): Simplify android default libs logicagrieve2016-01-062-32/+8
| | | | | | | | | | | | | * Always use full path to libgcc.a * Specify libs c, dl, m only once in either default_libs or runtime_library Should be a no-op. BUG=570406 Review URL: https://codereview.chromium.org/1539353002 Cr-Commit-Position: refs/heads/master@{#367877}
* clang: Enable -Wfor-loop-analysis.thakis2016-01-061-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Every time I try this warning, it finds a few true positives and has no false negatives. It looks like an excellent warning. I did three builds of target "gfx" in both Release and Debug with and without this warning enabled, doing local (non-goma) component builds (running -t clean between each build). This builds about 1.6k build steps each time. Warning on: Release: 0m26.850s 0m27.227s 0m27.159s Debug: 0m24.811s 0m25.044s 0m25.498s Warning off: Release: 0m26.834s 0m27.242s 0m26.952s Debug: 0m24.879s 0m25.064s 0m25.673s See e.g. the comments in https://codereview.chromium.org/1269343005/diff/240001/chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc https://codereview.chromium.org/196433002/diff/60001/media/cast/transport/pacing/paced_sender_unittest.cc for examples. BUG=none TBR=imcheng Review URL: https://codereview.chromium.org/1273313003 Cr-Commit-Position: refs/heads/master@{#367855}
* Move use_webview_internal_framework to android_webview/BUILD.gnagrieve2016-01-061-3/+0
| | | | | | | | BUG=574108 Review URL: https://codereview.chromium.org/1551393002 Cr-Commit-Position: refs/heads/master@{#367830}
* Allow placeholders when the native_libs is empty.hanxi2016-01-061-4/+4
| | | | | | Review URL: https://codereview.chromium.org/1563823002 Cr-Commit-Position: refs/heads/master@{#367825}
* GN(android) Don't enable --gc-sections by default in debug mode.agrieve2016-01-061-1/+4
| | | | | | | | | | The flag can cover over legitimate link errors. GYP does not enable it for debug builds. BUG=159847 Review URL: https://codereview.chromium.org/1541163002 Cr-Commit-Position: refs/heads/master@{#367756}
* GN: Set arm_float_abi when target_cpu = "arm64"agrieve2016-01-051-0/+3
| | | | | | | | | | | | | | | Fixes gn gen failure: Generating files... ERROR at //third_party/ffmpeg/BUILD.gn:199:11: Undefined identifier if (arm_float_abi == "hard") { ^------------ BUG=568883 Review URL: https://codereview.chromium.org/1551093002 Cr-Commit-Position: refs/heads/master@{#367615}
* GN Don't enable linker version script for componentsagrieve2016-01-051-5/+21
| | | | | | | | | | It breaks native JNI exporting. Change aligns with GYP behaviour. BUG=532905 Review URL: https://codereview.chromium.org/1548473003 Cr-Commit-Position: refs/heads/master@{#367470}
* Remove obsolete win_pdf_metafile_for_printing GN flag.thestig2016-01-041-3/+0
| | | | | | Review URL: https://codereview.chromium.org/1552673002 Cr-Commit-Position: refs/heads/master@{#367364}
* linux: Build third-party code with -Wunused-result.thakis2016-01-041-8/+0
| | | | | | | | | | Part of an effort to make warning flags consistent across platforms. BUG=574077 Review URL: https://codereview.chromium.org/1559903002 Cr-Commit-Position: refs/heads/master@{#367355}
* Enable -Wformat in linux, android, chromeos, cast builds.thakis2016-01-041-5/+0
| | | | | | | | | | No behavior change. BUG=573780 Review URL: https://codereview.chromium.org/1551313002 Cr-Commit-Position: refs/heads/master@{#367353}
* Fix proto_java_library comment exampledaniimms2016-01-041-1/+1
| | | | | | | | | | proto_path is a string not an array. BUG=NONE Review URL: https://codereview.chromium.org/1552073002 Cr-Commit-Position: refs/heads/master@{#367319}
* Linux/CrOS/Cast/Android (and Mac with gn): Build 3rd-party code with -Wall.thakis2016-01-021-0/+4
| | | | | | | | | | | | | | | | Lands the remaining -Wall bits of https://codereview.chromium.org/1551753002/ (reviewed there). Windows, Mac, and iOS already build 3rd-party code with -Wall. (Mac and iOS only in the gyp build, not in gn yet.) This makes the other platforms match and also adds -Wall to no_chromium_code in gn builds. BUG=573250 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1555893002 Cr-Commit-Position: refs/heads/master@{#367275}
* Linux/CrOS/Cast/Android (and Mac with gn): Build chromium_code with -Wextra.Nico Weber2016-01-011-9/+5
| | | | | | | | | | | | | | | | | Lands the -Wextra bits of https://codereview.chromium.org/1551753002/ (reviewed there). Windows, Mac, and iOS already build chromium_code with -Wextra. (Mac and iOS only in the gyp build, not in gn yet.) This makes the other platforms match and also adds -Wextra to chromium_code in gn builds. BUG=573250,572776 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1552863004 . Cr-Commit-Position: refs/heads/master@{#367256}
* port alternative_locale_resource to GN.michaelbai2015-12-302-0/+15
| | | | | | | | | | | | | | | | | | | Suppport to override existing locale resources in dep graph for android_apk targets. - Used is_locale_resource in build_config file to indicate that android_resources is locale_resource - Removed all locale_resource in deps graph if alternative_locale_resource_dep is specified in android_apk target. This feature was implemented in gyp. BUG=565532 Review URL: https://codereview.chromium.org/1554533003 Cr-Commit-Position: refs/heads/master@{#367182}
* Port android_aapt_path, app_as_shared_lib and alternative_sdk to GNmichaelbai2015-12-302-9/+59
| | | | | | | | | | alternative_sdk_jar is used in proguard BUG=565532 Review URL: https://codereview.chromium.org/1551863002 Cr-Commit-Position: refs/heads/master@{#367172}
* Move webview_framework_jar to config.gnimichaelbai2015-12-301-0/+5
| | | | | | | | | | | As the counterpart of android_sdk_jar, move webview_framework_jar to config.gni, so it is easy to be overriden in downstream. BUG=565532 Review URL: https://codereview.chromium.org/1554693002 Cr-Commit-Position: refs/heads/master@{#367167}
* win: Stop disabling compiler warning 4481.thakis2015-12-241-1/+0
| | | | | | | | | | The warning predates C++11. override is no longer a non-standard extension. BUG=none Review URL: https://codereview.chromium.org/1543043006 Cr-Commit-Position: refs/heads/master@{#366832}
* GN: Remove asset_location parameter in favour of android_assets()agrieve2015-12-232-14/+0
| | | | | | | | BUG=547162 Review URL: https://codereview.chromium.org/1533363002 Cr-Commit-Position: refs/heads/master@{#366747}
* GN: Set --coverage-dir in bin/run_* script when emma_coverage = trueagrieve2015-12-221-0/+8
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1544803003 Cr-Commit-Position: refs/heads/master@{#366674}
* Delete a duplicate assignment in android/config.gniagrieve2015-12-211-2/+0
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1540793003 Cr-Commit-Position: refs/heads/master@{#366410}