| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hooks up the rpath for Mac executables. This fixes a bug in iOS GYP generation where the architectures were specified as a string instead of a list.
Also fixes some base files that were out-of-sync from the GYP build.
BUG=345021
TBR=thakis
Review URL: https://codereview.chromium.org/179873008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the -D defines for the default desktop Linux build of re2 in GN match that of GYP.
This moves the SSL configuration stuff into the root build directory. It's better to match the GYP build exactly for ease of landing even though this is a stupid dependency.
Fixes the help text that still references the implicit "gen" command (I removed this).
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/170533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for the base shared library target on desktop Linux.
The remaining difference on Linux is that GYP's base build specifies -Wno-write-strings on Linux. This dates back to the first GYP file. I don't know why we would specify this for only base, and it seems not to trigger any warning without this flag, so I didn't add it.
This changes the pkg-config invocation from --libs to --libs-only-L and --libs-only-l. The output seems slightly different (--libs was producing an extra --export-dynamic for gmodule-2.0 that aren't present when invoking the other way, which is what the GYP build does).
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/165873004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=344361
Review URL: https://codereview.chromium.org/171263005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates all rebase_path calls to use the new parameter ordering.
Use the new getenv function and delete the Python script we had to get the home directory.
Takes advantage of the new ability to have the default value of declare_args blocks be dependent on other values. This simplifies some code.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/164773005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
r248477 made pkg-config.py print a 5-tuple. Change the default output accordingly.
BUG=none
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/171993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously this was being set for all .c[c] files on Mac.
BUG=336480
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/164193009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This renames the hack "my_msvs" project to "feature_flags" and creates an include file that gives the proper definitions of most of the UI-related feature and OS flags. Hook these flags up the build.
Review URL: https://codereview.chromium.org/160143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This stops doing the host build as a completely separate build and
instead identifies the proper host toolchain inside of the "regular"
build that we should use for host targets (if any). This should help
unify GN's concept of host/target builds with GYPs a bit more.
BUG=
Review URL: https://codereview.chromium.org/152683004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches the GYP definition and seems to be what most build files expect.
This also removes some additions of lib "dl" which I'm making global.
R=scottmg@chromium.org
TBR=scottmg
Review URL: https://codereview.chromium.org/156563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This properly sets the DEPLOYMENT_TARGET in the generated GYP file (previously this value wa salways hardcoded to empty -- whoops!).
Sets the simulator properly. Previously when not using an explicit SDK the Xcode generator would still end up with a simulator build. This turns the flag into a tri-state so gyp_chromium can set it explicitly when an SDK is specified, but otherwise we can trigger default behavior based on Xcode/Ninja.
TBR=scottmg
Review URL: https://codereview.chromium.org/155983003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This will make it possible to pull GN binaries on Linux which is currently blocked on the Android AOSP bot complaining about unused parameters.
TBR=scottmg
Review URL: https://codereview.chromium.org/157273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In GYP Mac, most targets got a default set of mac libraries by virtue
of depending on base, which due to a GYP bug pushed the libraries to
all targets depending on base, even separate shared libraries.
In GYP Windows the set of default libraries on Windows is global and
this keeps the same list and behavior.
The lists of libraries could use some cleanup, btu this patch just
attempts to keep the status quo in a cleaner way rather than fixing the
unreasonable list of libraries (especially on Windows).
R=scottmg@chromium.org, scottmg
Review URL: https://codereview.chromium.org/131513026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to actually reference this config when I created it.
R=thakis@chromium.org
TBR=thakis
Review URL: https://codereview.chromium.org/155653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hooks up Clang in the pure GN build (not the hybrid GYP mode).
Clang gave some warnings about compiler flags which made me realize that we were giving linker flags to the compiler in some cases. So I enhanced our pkg-config wrapper to to add libraries to the cflags (missing else), return ldflags separately, and also strip out -pthread which was getting included over and over.
BUG=
Review URL: https://codereview.chromium.org/147923010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separates out some "SDK" related setup on Mac land Linux like we do on Windows. I'm trying to make the "compiler" BUILD file just compiler warnings and CPU options, and have system library stuff on the platform directories.
This adds the capability for GN to produce GYP files on Mac that vary according
to the GYP generator as well as target-vs-host. I added a bunch of logic to the
GN iOS build to set up stuff accordingly based on my current knowledge of
what's required.
Sadly, this means we now have an 8-way GN build (all combinations of
debug/release, host/target, and xcode/ninja). I did some refactoring of the GYP
code in GN to make this less unreasonable.
I checked that the GYP files look the way I want, but I didn't actually test
the resulting builds yet. There is still likely to be some conditions wrong or
things not being set properly. I'm going to follow up with a second pass based on actual testing.
I believe, however, that with this new GYP generator code in GN, we can express
in the .gn files what we need to do the iOS build.
Review URL: https://codereview.chromium.org/149163005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mtune was set to cortex-a8, which is a Nexus S-generation CPU.
Removing it allows for small speed improvements (~1%) for
warm page load times on top10 mobile sites on more recent devices.
Data: https://docs.google.com/spreadsheet/ccc?key=0Ao-xIDuezqMNdDc5OWpxbkk4NFJ0SF9Iemt0Tlg3RFE&usp=sharing
And it has virtually no effect on binary size.
BUG=334271
Review URL: https://codereview.chromium.org/145663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally, the Windows binary is a debug build to help find a rare assertion failure.
Updates build files to use a list which this new build requires.
Update win-tool link commands to match GYP
TBR=scottmg
Review URL: https://codereview.chromium.org/139283005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hooks up detection for the "-arch" flag on Mac to set the GYP "ARCH" xcode variable. GN then removes the -arch argument from the compiler args, since GYP will then re-add it based on the ARCH value. Previously, not doing this resulting in mutliple "-arch" arguments to the compiler since GYP would always insert its own.
Disables some warnings on Windows for the re2 target to match the GYP build. The third warning (4018) that the GYP build sets is disabled globally so there's no need to do it for this target.
Hooks up some iOS SDK stuff.
BUG=336667
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/141433015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix build regression for MIPS Linux that came with r245563.
BUG= build regression for MIPS Linux
TEST= build Chromium for MIPS Linux
Review URL: https://codereview.chromium.org/143963006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This isn't correct for the iOS xcode builder.
> gn: Fix clang plugin on ios.
>
> BUG=336491
> TBR=brettw@chromium.org
>
> Review URL: https://codereview.chromium.org/144073003
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/134923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This isn't correct for the xcode iOS builder.
> gn: Default is_clang to true on iOS.
>
> Mirrors this condition in build/common.gypi:
>
> ['OS == "ios"', {
> # ...
>
> # Enable clang and host builds when generating with ninja-ios.
> 'conditions': [
> ['"<(GENERATOR)"=="ninja"', {
> 'clang%': 1,
> 'host_os%': "mac",
> }]
> ],
> }],
>
> BUG=336531
> TBR=brettw@chromium.org
>
> Review URL: https://codereview.chromium.org/143323008
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/138023008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=336491
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/144073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mirrors this condition in build/common.gypi:
['OS == "ios"', {
# ...
# Enable clang and host builds when generating with ninja-ios.
'conditions': [
['"<(GENERATOR)"=="ninja"', {
'clang%': 1,
'host_os%': "mac",
}]
],
}],
BUG=336531
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/143323008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This supports specifying the output_dir generator flag in the gn-generating-gyp
mode. The value of the output_dir flag is mapped to a gyp variable called gyp_output_dir
and a GN argument by the same name. References from gyp to gn-generated gyp files must
use this variable and references from BUILD.gn files must use the gn argument.
BUG=335760
TBR=brettw for build/config/BUILDCONFIG.gn (looked at in person)
Review URL: https://codereview.chromium.org/142223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/141143008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This generalizes the GCC iterator debugging flag to now be platform-independent.
R=scottmg@chromium.org
TBR=scottmg
Review URL: https://codereview.chromium.org/139783012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously this was ignored in the GN build but disabling the plugin is used on some buildbots.
BUG=http://crbug.com/330298
R=thakis@chromium.org, thakis
Review URL: https://codereview.chromium.org/142053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=scottmg@chromium.org, scottmg
Review URL: https://codereview.chromium.org/138273007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add a flag to disable GLIBCXX_DEBUG which is used in the GYP build on some bots.
TBR=scottmg
Review URL: https://codereview.chromium.org/141703004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This gets the path from xcodebuild rather than hardcoding it in the .gn files.
R=thakis
BUG=
Review URL: https://codereview.chromium.org/136793020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/135733006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This duplicates logic in common.gypi.
R=scottmg@chromium.org
TBR=scottmg
Review URL: https://codereview.chromium.org/139883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This sets use_aura on Windows in all cases (fixes base build).
Passes new argument to gyp link wrapper (GYP revision 1835).
R=sky@chromium.org
TBR=sky
Review URL: https://codereview.chromium.org/137993014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This emulates optimize=max from GYP. One difference is that this applies for all build types. The GYP one only applied optimize=max for the Official build. I can't think of why this should be the case, and it seems confusing to have such arbitrary official build differences.
R=bbudge@chromium.org
Review URL: https://codereview.chromium.org/138903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I accidentally used underscores which gives undefined option errors.
TBR=scottmg
Review URL: https://codereview.chromium.org/135733005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This duplicates the ARM architecture logic from common.gypi.
R=scottmg@chromium.org
TBR=scottmg
Review URL: https://codereview.chromium.org/137493004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously this was in a global config which also applied to the release build.
R=thakis@chromium.org
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/137553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It had an extra underscore at the beginning.
R=thakis@chromium.org
TBR=thakis
Review URL: https://codereview.chromium.org/137303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=scottmg@chromium.org
TBR=scottmg
Review URL: https://codereview.chromium.org/134613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Reported in "[chromium-dev] the problem i met when buliding chromium on the windows 7 without cygwin"
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/134763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This resulted in a double -D definition.
TBR=scottmg
Review URL: https://codereview.chromium.org/132903005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes make_global_settings closer to the GYP version. Previously it had relied on GYP concatenating two lists when running with goma, but it doesn't actually behave this way, resulting in unexpected output.
TBR=scottmg
Review URL: https://codereview.chromium.org/132833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fails on other configurations. The new behavior matches the GYP build.
R=scottmg@chromium.org
TBR=scottmg
Review URL: https://codereview.chromium.org/130923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds arm version and some android configuration build flags.
This adds most of the logic from common.gypi to the Android GN build.
This is currently missing the crtbegin/end stuff and won't actually make real Android builds. The logic in this patch is just the initial conversion that will require testing and several more passes of fixes.
R=torne@chromium.org, torne
Review URL: https://codereview.chromium.org/121173005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move sysroot.gni up a directory, as it applies to multiple
platforms now.
- Use existing find_sdk.py script to locate Mac SDK.
- Fix some gtest includes for Mac files.
BUG=
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/116763005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This searches the local system for Visual Studio versions like GYP. It enables specifically requesting one version, as well as overriding the directory like GYP.
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/126073005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This trybots said this was an unknown option, so the comment I was basing my
usage of "strong" on in common.gypi must be out-of-date. The GYP build does not
seem to specify "strong" in any cases except on Mac.
Hook up compiler finding to the Android build.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/99333020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the current GYP build.
Refactors the toolchain definitions by adding an include file to help defining GCC toolchains. This eliminates most of the duplication on Linux and Android. Adds make_global_settings for most Linux and Mac builds that should match the GYP build (this will require some more passes to get every place to be an exact match).
Fixes Android build issues in WebKit. Fixes the definition of is_android.
Renames the Linux toolchains to use the GN name of the CPU architecture so one can refer to them without conditionals. Remove conditionals from BUILDCONFIG.gn
Adds the gyp_header variable to the help (it wasn't getting inserted into the list of available variables).
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/117863003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the proper name of the Clang plugin on Linux (previously it was hardcoded to the Mac-style name).
This also fixes the path naming so the clang plugin is correct no matter where the output directory is.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/121423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242573 0039d316-1c4b-4281-b951-d872f2087c98
|